| Time |
Nick |
Message |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:51 |
|
rfrasur joined #evergreen |
| 07:12 |
|
agoben joined #evergreen |
| 07:15 |
|
rjackson_isl_hom joined #evergreen |
| 07:42 |
|
Dyrcona joined #evergreen |
| 07:52 |
|
mantis joined #evergreen |
| 08:27 |
|
alynn26 joined #evergreen |
| 08:27 |
|
alynn26_away joined #evergreen |
| 08:40 |
|
mmorgan joined #evergreen |
| 08:52 |
|
mmorgan1 joined #evergreen |
| 08:53 |
|
mmorgan2 joined #evergreen |
| 08:53 |
|
mmorgan2 left #evergreen |
| 09:02 |
|
mmorgan joined #evergreen |
| 10:12 |
|
dbwells joined #evergreen |
| 10:29 |
|
mmorgan left #evergreen |
| 10:34 |
|
mmorgan joined #evergreen |
| 10:45 |
|
mmorgan1 joined #evergreen |
| 10:50 |
Bmagic |
@seen sandbergja |
| 10:50 |
pinesol |
Bmagic: sandbergja was last seen in #evergreen 2 weeks, 2 days, 18 hours, 37 minutes, and 21 seconds ago: <sandbergja> csharp++ |
| 11:04 |
|
tlittle joined #evergreen |
| 11:15 |
Dyrcona |
@seen bshum |
| 11:15 |
pinesol |
Dyrcona: bshum was last seen in #evergreen 1 week, 2 days, 20 hours, 49 minutes, and 41 seconds ago: <bshum> Kidding, kidding... |
| 11:35 |
csharp |
@eightball was bshum really kidding? |
| 11:35 |
pinesol |
csharp: The answer is a resounding no. |
| 12:00 |
|
jihpringle joined #evergreen |
| 12:12 |
Bmagic |
All, I'm trouble shooting the presence of "Place Hold" in the OPAC. I've narrowed it down to the Apache ENV variable "physical_loc" - when it's set to "2" the "Place Hold" link is gone, When it's "3" - it's there. Found the function "global_record_copy_count" in biblio.pm where a SQL query figures out the counts |
| 12:16 |
Bmagic |
There is also a DB function: asset.record_has_holdable_copy - which takes the BIB ID and the context ORG unit. When I feed in "3", the function returns false, and when I feed "2" - it returns true. Which is opposite of the OPAC behavior. Not sure that this function is consulted for the OPAC, but it's curious none-the-less |
| 12:20 |
Bmagic |
All of the copies on my test bib are located beneath "2" - there are no copies for "3" or any org below "3". But "3" is the one that is working.... |
| 12:21 |
jihpringle |
Bmagic: sounds like https://bugs.launchpad.net/evergreen/+bug/1819956 |
| 12:21 |
pinesol |
Launchpad bug 1819956 in Evergreen "Place Hold Option Not Hidden In OPAC If Other Libraries Have Holdable Items" [Wishlist,Confirmed] |
| 12:23 |
Bmagic |
hmmm, this is different I think. The copies ARE holdable and OPAC visible |
| 12:23 |
Bmagic |
Therefore, the result I would expect is that the link should* appear |
| 12:50 |
|
tlittle joined #evergreen |
| 12:58 |
Bmagic |
I think I found it |
| 13:05 |
Bmagic |
It comes from the IF statement: IF ctx.place_unfillable || ( attrs.marc_xml.findnodes('//*[local-name()="holdings" and @has_holdable="true"]').size && (ctx.holds_block.enabled != 'true' || !attrs.org_copy_counts.$search_ou.available)) |
| 13:06 |
Bmagic |
in this case ctx.holds_block.enabled was set to "true" - but even so, it was negated because !attrs.org_copy_counts.$search_ou.available evaluated to "true" because physical_loc was set to a location that had no copies. haha |
| 13:07 |
Bmagic |
Strange logic. I would think that if the setting of "no holds allowed" for an OPAC would mean that we don't want holds allowed. But the logic is really "Don't allow holds for on bibs where I have copies" - in other words: "It's fine to place holds on other system's items, just not mine" |
| 13:22 |
bshum |
@roulette |
| 13:22 |
pinesol |
bshum: *click* |
| 14:26 |
|
sandbergja joined #evergreen |
| 14:43 |
miker |
berick: there seems to be something scary happening with the one (real) use of a allowFreeText=true combobox, which is used to create or select vandelay queue names ... the result is that it /looks/ like under the covers it's not actually recording the freetext value if an intermediate version of the string (as you type) matches the label of an extant queue... for instance, given a staff account that owns say 20 queues all starting with "bob" ( |
| 14:43 |
miker |
bobJune1, bobJune2, etc), we're seeing a situation where trying to create "bobJune42" by typing that in directly and bluring the field, bobJune4 gets selected instead, and editing the label to have a "2" on the end doesn't let you create the new one. instead you get an error about a duplicate queue name. |
| 14:44 |
berick |
well that's no fun |
| 14:45 |
miker |
I know that's a big wall of text... but ... it feels like the freetext logic is falling down at some point and hard-selecting the preexisting one by unsetting the freetext flag, grabbing the id for an intermediate-matching queue, and, now that it has an id, no going /back/ to freetext mode when you edit the label in the combobox |
| 14:45 |
berick |
k, yeah, i'll see if I can see what's up |
| 14:46 |
miker |
but the twisty passages of angular's observers are confusing me while troubleshooting |
| 14:46 |
berick |
on a related note, I need to make it easier to clear values in the comobobox. only way to do it now is to clear it and click elsewhere in the page |
| 14:47 |
miker |
it looks like there's at least on 200ms delayed observation? I don't know that the size of the queue list matters, or the speed of typing does ... or if that particular delay is a red herring |
| 14:50 |
miker |
berick: thanks for looking... it's driving me nuts, and obv new in 3.4+ |
| 14:54 |
berick |
of course |
| 14:54 |
berick |
surprised I haven't hit it yet. |
| 14:57 |
miker |
berick: new wrinkle (found by Steve here, actually) ... it looks like there may be 2 create calls being sent. gathering details |
| 15:03 |
miker |
bah... that would have been too easy. false alarm, no double create attempt. just overly verbose logging |
| 15:04 |
berick |
strange i can't reproduce it. can you do it reliably? |
| 15:05 |
berick |
i'm on master, though |
| 15:05 |
* berick |
tries on 3.4 |
| 15:07 |
berick |
ok, I am able to create some oddness in 3.4 |
| 15:07 |
berick |
specifically tabbing out of the input after trying to create a new queue |
| 15:08 |
berick |
it would revert to an existing queue |
| 15:09 |
miker |
ahh, that sounds promising. we have one user that can cause it on demand, yes |
| 15:09 |
berick |
there is a diff between master and 3.4 that at a glance could fix it |
| 15:09 |
miker |
I do /not/ know if they're tabbing out rather than clicking though |
| 15:09 |
miker |
if you have a commit hash handy, that'd be cool. or I can go look if not, no biggie |
| 15:10 |
berick |
yep, sec |
| 15:11 |
berick |
miker: part of 1e35be4827254524e229ead11f89c5de1340113d |
| 15:11 |
pinesol |
berick: [evergreen|Bill Erickson] LP1859241 Angular holds patron search dialog - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1e35be4> |
| 15:12 |
miker |
thanks! |
| 15:18 |
miker |
looks like at least the combobox hunk may want to be backported |
| 15:26 |
berick |
agreed |
| 15:48 |
|
mantis left #evergreen |
| 16:22 |
|
sandbergja joined #evergreen |
| 16:43 |
|
Dyrcona joined #evergreen |
| 17:29 |
|
mmorgan1 left #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:20 |
|
Dyrcona joined #evergreen |
| 22:38 |
|
sandbergja joined #evergreen |
| 23:26 |
|
sandbergja joined #evergreen |
