| Time |
Nick |
Message |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:10 |
|
rfrasur joined #evergreen |
| 07:26 |
|
dbwells joined #evergreen |
| 07:34 |
|
rjackson_isl_hom joined #evergreen |
| 07:53 |
|
rjackson_isl_hom joined #evergreen |
| 07:53 |
|
alynn26 joined #evergreen |
| 08:17 |
|
Stompro joined #evergreen |
| 08:25 |
|
alynn26_away joined #evergreen |
| 08:28 |
|
alynn26_away joined #evergreen |
| 08:29 |
|
alynn26 joined #evergreen |
| 08:30 |
|
mantis1 joined #evergreen |
| 08:33 |
|
mmorgan joined #evergreen |
| 09:22 |
JBoyer |
Bmagic, does the UPDATE_BIB_IMPORT_QUEUE have any effect on that situation? This sounds familiar and I think that perm was missing in the case I was looking at. |
| 09:22 |
Bmagic |
It might! I couldn't find anything in the logs asking for a certain permission |
| 09:22 |
Bmagic |
It was guess work and I gave up |
| 09:24 |
Bmagic |
Just checked - that permission is granted at system |
| 09:24 |
Bmagic |
UPDATE_BIB_IMPORT_IMPORT_FIELD_DEF is granted at consortium |
| 10:02 |
|
berick joined #evergreen |
| 10:19 |
JBoyer |
Bmagic, I just checked fm_IDL.xml. try changing that system to cons, because global_required=true is all over the place for that perm. |
| 10:28 |
csharp |
might have found a bug in the reporter - if I try to filter on a count (aggregate filter in the old UI) it's not populating the pre-entered value and it's also not providing a form for me to enter it if I leave it blank) |
| 10:29 |
|
Dyrcona joined #evergreen |
| 10:41 |
miker |
csharp: sounds like a likely spot for bugs (the folding together of aggregate and non-aggregate filters)... do you happen to have a template JSON blob from the xul days that did/does work and has an aggregate filter, and if so, could you attach that /and/ the new one to an LP bug? (want to gather info for when tuits arrive ... but amazon does not consider them "essential items" ;) ) |
| 10:43 |
miker |
csharp: in fact, the "debug" page from a run of each would be really great... ideal, even |
| 10:44 |
Dyrcona |
Bleh.... Gotta love non-obvious bugs.... |
| 10:52 |
Dyrcona |
miker: Do you know how I can examine egstrings in the console? |
| 10:52 |
Bmagic |
JBoyer: thanks! I'll give it a whirl |
| 10:53 |
miker |
Dyrcona: you mean the angular UI stuff? I do not. |
| 10:54 |
Dyrcona |
AngularJS. |
| 10:54 |
miker |
if it's angularjs, yes, the egstrings module is really just a hash :) |
| 10:54 |
Dyrcona |
egSrting['String']? |
| 10:55 |
miker |
well, not that directly I don't think, but ... basically. |
| 10:55 |
miker |
let me refresh my memory on ang-js |
| 10:57 |
Dyrcona |
Looks like i can't rely on my phone... |
| 11:07 |
miker |
Dyrcona: welp, I was wrong, it is that simple. see things like: $scope.title = egStrings.OP_CHANGE_TITLE; ... so, console.log(egStrings.WHATEVER_MAN) should work, given such a template that adds a WHATEVER_MAN property to the env that the JS runs in |
| 11:08 |
Dyrcona |
miker: Thanks. I'm not sure how much it will help at this point, but I'll give it a shot. |
| 11:08 |
Dyrcona |
I'm working on bug 1813088 and it appears to be a case of something that works everywhere else doesn't work in this one place. |
| 11:08 |
pinesol |
Launchpad bug 1813088 in Evergreen 3.4 "Notify by Email column on Hold Shelf not populating" [Undecided,Confirmed] https://launchpad.net/bugs/1813088 |
| 11:16 |
miker |
Dyrcona: could it really be that whatever renders t_shelf_list.tt2 does not end up including base_js.tt2? (anyway, jamming the string additions for YES and NO into the top of t_shelf_list.tt2 should address that, if that's really the case) |
| 11:17 |
Dyrcona |
miker: It is including base_js.tt2, at least it's there in the sources view. |
| 11:17 |
Dyrcona |
I thought about adding them to circ strings.tt2 |
| 11:17 |
miker |
Dyrcona: OH! you wanted to use the dev tools to show strings! |
| 11:17 |
miker |
I /can/ help with that! |
| 11:18 |
miker |
sec |
| 11:19 |
miker |
Dyrcona: the trick is to use the element picking tool (in chrome, top-left of the dev tools, the mouse cursor icon) to get as close to the context element as you can. in this case, a grid cell should be an easy target |
| 11:20 |
miker |
once you've selected the element you can do stuff like: angular.element($0).scope() |
| 11:20 |
miker |
in the console to see the $scope in context there |
| 11:22 |
miker |
if you just toss egStrings on the scope, like "$scope.egstrings = egStrings;", then you can say: angular.element($0).scope().egstrings.YES |
| 11:22 |
miker |
and you should see "Yes" appear... |
| 11:23 |
phasefx |
you can also console.log('egstrings',egStrings); and then right click on the output to store into temp1 in the console |
| 11:24 |
Dyrcona |
Thanks for the suggestions! |
| 11:24 |
Dyrcona |
miker++ phasefx++ |
| 11:25 |
Bmagic |
JBoyer - consortium perm for UPDATE_BIB_IMPORT_QUEUE didn't do the trick - giving up for now. Thanks for considering the issue |
| 11:26 |
Dyrcona |
I was hoping there would a JS error in the console log to point me at the problem. Something has to be interfering with the interpretation of egStrings. |
| 11:29 |
Dyrcona |
Well, I don't know what I'm doing. miker's suggestions aren't working for me. I need to learn more about debugging AngularJS. |
| 11:31 |
Dyrcona |
"Inspect the element from Chrome dev tools, and write $scope in the console. See the magic !" Yeah, no magic. |
| 11:33 |
phasefx |
one debug tip is to always have Disable Cache configured to true in the dev tools |
| 11:35 |
Dyrcona |
angular.element($0).scope(); <- Works! |
| 11:36 |
Dyrcona |
I think I'm going to give up on this and add the strings to circ_strings.tt2 and see what happens. |
| 11:36 |
Dyrcona |
phasefx: I'll do that. |
| 11:39 |
Dyrcona |
I'm also doing 'Empty Cache and Hard Reload' between changes. |
| 11:40 |
Dyrcona |
Moving strings to circ_strings.tt2 doesn't appear to help... |
| 11:40 |
pinesol |
[evergreen|Jason Etheridge] lp1834251: I18Nize these alt tags - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=4ea65d1> |
| 11:42 |
Dyrcona |
I'll see if putting them in hold_strings.tt2 helps. If it does it might help pinpoint the problem. If not, it's in something that comes after... |
| 11:42 |
Dyrcona |
Either way, I guess it helps... |
| 11:45 |
Dyrcona |
Nope. The strings are showing up where I expect them to in sources, but not populating in the grid. |
| 11:55 |
Dyrcona |
Not working in holds/index.tt2, either. It's got to be a JS problem that isn't showing up in the console. |
| 11:57 |
Dyrcona |
If I remove datatype="bool" on the eg-grid-field entries, the values show up as 1 or 0. |
| 12:06 |
|
jihpringle joined #evergreen |
| 12:10 |
|
mrisher joined #evergreen |
| 12:22 |
|
Dyrcona joined #evergreen |
| 12:23 |
Dyrcona |
Ok. That was an accidentally on purpose disconnection. |
| 12:25 |
Dyrcona |
So, this might be something to go on. Boolean fields are displaying correctly on the pull list, so the problem must be in the holds shelf templates or things included by them, but not the pull list. Why didn't I check that before? |
| 12:36 |
Dyrcona |
So, Email Notify shows up Yes or No on the pull list, but doesn't have the datatype="bool" set. It does have required. |
| 12:41 |
Dyrcona |
No.....!!!! That didn't help, either. |
| 12:41 |
csharp |
miker: it won't let me run the report because it's missing a parameter and it won't let me enter the parameter - if there's anything else diagnostically I can do, I will |
| 12:44 |
miker |
csharp: ah... well, the template JSON blob would still be helpful (along with a "working" template JSON blob) |
| 12:49 |
csharp |
I'll see what I can get |
| 12:52 |
miker |
thanks |
| 12:52 |
csharp |
miker: https://pastebin.com/uvkuxuP2 |
| 13:05 |
|
rfrasur joined #evergreen |
| 13:27 |
abneiman |
if any committers want to push this in honor of the extended Bug Squashing Week, it would be appreciated: https://bugs.launchpad.net/evergreen/+bug/1849683 |
| 13:27 |
pinesol |
Launchpad bug 1849683 in Evergreen "CSS From Library Setting Needs to have permissions " [Medium,New] |
| 13:29 |
|
rjackson_isl_hom joined #evergreen |
| 13:30 |
mmorgan |
Dyrcona: Does bug 1788417 help? |
| 13:30 |
pinesol |
Launchpad bug 1788417 in Evergreen 3.0 "Web client: Boolean fields say "true"/"false" when XUL client used "Yes"/"No"" [Undecided,Fix released] https://launchpad.net/bugs/1788417 |
| 13:45 |
|
Dyrcona joined #evergreen |
| 13:46 |
Dyrcona |
mmorgan: I looked at that yesterday and tried reverting the commit but it makes no difference. |
| 13:47 |
Dyrcona |
mmorgan: In fact, I'm trying to get that code to work on the holds shelf list. It seems to work everywhere else I've tested it. |
| 14:19 |
|
rfrasur joined #evergreen |
| 14:20 |
|
dbwells joined #evergreen |
| 15:14 |
|
mantis1 left #evergreen |
| 15:29 |
|
rfrasur joined #evergreen |
| 16:00 |
|
dbwells joined #evergreen |
| 16:31 |
|
sandbergja joined #evergreen |
| 17:07 |
|
mmorgan left #evergreen |
| 18:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:07 |
miker |
csharp: thanks, belatedly |
| 23:38 |
|
sandbergja joined #evergreen |
