Time |
Nick |
Message |
00:06 |
|
sandbergja joined #evergreen |
00:06 |
|
jonadab joined #evergreen |
00:29 |
|
sandbergja joined #evergreen |
03:41 |
|
devted joined #evergreen |
05:09 |
|
devted joined #evergreen |
06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
06:44 |
|
agoben joined #evergreen |
07:18 |
|
rjackson_isl_hom joined #evergreen |
07:34 |
|
rfrasur joined #evergreen |
08:07 |
|
Stompro joined #evergreen |
08:19 |
|
jvwoolf joined #evergreen |
08:31 |
|
Dyrcona joined #evergreen |
08:33 |
|
mantis1 joined #evergreen |
08:34 |
|
mmorgan joined #evergreen |
08:51 |
|
jvwoolf1 joined #evergreen |
09:10 |
|
Bmagic joined #evergreen |
09:18 |
Bmagic |
@coffee [someone] |
09:18 |
* pinesol |
brews and pours a cup of La Esmeralda, and sends it sliding down the bar to gmcharlt |
09:19 |
Bmagic |
cheers gmcharlt |
09:19 |
gmcharlt |
Bmagic++ |
09:19 |
gmcharlt |
@coffee Bmagic |
09:19 |
* pinesol |
brews and pours a cup of Kenya Ndiara Full Flavor Roast, and sends it sliding down the bar to Bmagic |
09:19 |
gmcharlt |
it should be noted that the bar is at least two meters long ;) |
09:19 |
Bmagic |
:) |
09:19 |
Bmagic |
https://www.coffeereview.com/review/kenya-ndiara-full-flavor-roast/ |
09:20 |
Bmagic |
Some real good stuff |
09:20 |
mmorgan |
@coffee everyone |
09:20 |
* pinesol |
brews and pours a cup of Colombia Tolimas, and sends it sliding down the bar to everyone |
09:21 |
mmorgan |
Has been that kind of week |
09:26 |
Bmagic |
mmorgan++ |
09:27 |
Bmagic |
Well, it seems we have some folks on IRC this morning - I'll post this and try to get some feedback (it is still bug squashing week :)) http://eg-docs.georgialibraries.org/prod |
09:27 |
Bmagic |
Looking for some review of the pages and links. Hunting for errors. The highest risk (I think) are links on documents pointing to other documents |
09:44 |
csharp |
hitting a perl issue: https://pastebin.com/BmuQAMhn |
09:45 |
csharp |
$hold->target = $rec; is causing this error: Can't modify non-lvalue subroutine call of &Fieldmapper::AUTOLOAD at /usr/local/share/perl/5.26.1/OpenILS/Application/Cat.pm line 1525. |
09:46 |
csharp |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Cat.pm;h=d844b8fa429beb623b4c4a18f0db5b4c9574ebc8;hb=08ce89cbe6681884942f3b6b650360b4411bf89a - is the version of the file I'm running |
09:46 |
Dyrcona |
csharp: You $_ and not $rec, IIRC. |
09:46 |
csharp |
goal is to grab the hold object, update the target on the object, then apply the change |
09:47 |
csharp |
oh - hmm |
09:47 |
Dyrcona |
Bleah.. you want $_ not $rec. |
09:47 |
csharp |
well, $rec is from further up in the sub |
09:47 |
Dyrcona |
Well, it's not present in the snippet that you pasted. |
09:47 |
csharp |
yeah |
09:47 |
|
sandbergja joined #evergreen |
09:48 |
csharp |
$rec is defined here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Cat.pm;h=d844b8fa429beb623b4c4a18f0db5b4c9574ebc8;hb=08ce89cbe6681884942f3b6b650360b4411bf89a#l1338 |
09:48 |
Dyrcona |
Oh, and given the error you want: $hold->target($rec); |
09:48 |
csharp |
ah - makes sense |
09:48 |
Dyrcona |
Members of instantiated objects are methods. |
09:48 |
csharp |
so it's not a reassignment with = |
09:48 |
Dyrcona |
@coffee |
09:48 |
* pinesol |
brews and pours a cup of Kenya Kangunu, and sends it sliding down the bar to Dyrcona |
09:49 |
csharp |
Dyrcona: perfect -thanks! |
09:51 |
csharp |
<ralph_wiggum>Programming is hard.</ralph_wiggum> |
09:56 |
|
dbwells joined #evergreen |
09:56 |
|
rjackson_isl_hom joined #evergreen |
10:02 |
JBoyer |
"I bent my keyboard." |
10:08 |
csharp |
JBoyer++ |
10:09 |
|
jvwoolf joined #evergreen |
10:10 |
* miker |
has long considered marking those generated subs as lvalue, but the proliferation of styles could get confusing... |
10:13 |
pinesol |
[evergreen|Sam Link] Bug 1834251: adding alt attributes to Open-ILS\src\templates\kpac\parts\paginate.tt2. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=85c19f2> |
10:16 |
miker |
(also, it gets tricky to do that (perhaps impossible?) the way we model objects internally in opensrf) |
10:24 |
* Dyrcona |
agrees re proliferation of styles. |
11:25 |
|
khuckins joined #evergreen |
11:29 |
|
mmorgan1 joined #evergreen |
11:56 |
|
mrisher joined #evergreen |
12:01 |
|
jihpringle joined #evergreen |
12:33 |
|
khuckins joined #evergreen |
13:02 |
|
jvwoolf joined #evergreen |
13:04 |
|
jvwoolf1 joined #evergreen |
13:16 |
Dyrcona |
So, I'm removing 1cb0d8c63c445979e272f4ad72ea912afcabf7e2 locally. I don't think it should have gone in. |
13:16 |
pinesol |
Dyrcona: [evergreen|Dan Scott] LP#1681095 Set aggressive default cache expires timelines - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1cb0d8c> |
13:21 |
Dyrcona |
Eighteen hours might still be too long for training, but it's better than 1 year. |
13:23 |
sandbergja |
Dyrcona: interesting! We ran into so many browser cache issues during our last migration |
13:23 |
Dyrcona |
Yeahp. Who doesn't? |
13:24 |
Dyrcona |
I'm leaning towards removing all of the Expires directives from the server and let the browsers figure it out. |
13:24 |
Dyrcona |
But, I'll start by reverting that one commit and see how things go from there. |
13:30 |
dbs |
Dyrcona: there's a branch that changes the Expires to 5 minutes |
13:30 |
dbs |
The agressive expires was fine until we forgot to add the cache-buster to all of the newly developed web tech |
13:33 |
dbs |
I'll be damned if I can find a bug for that branch |
13:39 |
Dyrcona |
I don't recall any bugs getting created, but lots of chat in IRC on the topic. |
13:48 |
Dyrcona |
Well, I love it when I think I saved a patch for something, and I can't find it in my main patch directory. |
13:49 |
Dyrcona |
I bet it was only on the VM that I destroyed yesterday. I guess I can reverse engineer it from a different git branch where it was applied to different files. |
13:50 |
Dyrcona |
too-many-git-branches-- |
14:12 |
csharp |
@decide bug squash week or bug squash month |
14:12 |
pinesol |
csharp: go with bug squash month |
14:12 |
csharp |
pinesol: kthx |
14:12 |
pinesol |
csharp: Sorry, we can't do that because, you know, SOFTWARE. |
14:17 |
* mmorgan1 |
didn't have the opportunity to look at a single bug this week, too busy dealing with that OTHER bug. |
14:17 |
csharp |
srsly |
14:18 |
alynn26 |
I know. I was working going to work on a few, but setting up remote workers. And getting everyone connected. |
14:20 |
rfrasur |
pinesol++ #agree or at least #another_week_please |
14:20 |
pinesol |
rfrasur: always listen to berick |
14:20 |
rfrasur |
pinesol, I always listen to berick. |
14:20 |
pinesol |
rfrasur: I'm sorry, Dave. I'm afraid I can't do that. |
14:20 |
* rfrasur |
shrugs |
14:20 |
mmorgan |
pinesol should take own advice and listen to berick |
14:20 |
pinesol |
mmorgan: have you tried local mean solar time for the named city as the reference point? |
14:21 |
mmorgan |
Actually, I've been doing that all day! |
14:27 |
csharp |
@quote get 149 |
14:27 |
pinesol |
csharp: Quote #149: "< Bmagic> my favorite viruses are the ones claiming to be the cure" (added by csharp at 10:32 AM, March 22, 2016) |
14:33 |
mmorgan |
csharp++ |
14:33 |
mmorgan |
Bmagic++ |
14:35 |
Dyrcona |
Well, I did a few bug things this week, but not as much as I had hoped. |
14:36 |
Dyrcona |
@quote random |
14:36 |
pinesol |
Dyrcona: Quote #90: "<jeff> I feel like I'm stuck inside of a TCP joke." (added by gmcharlt at 12:37 PM, August 27, 2014) |
15:34 |
|
rfrasur joined #evergreen |
16:05 |
|
mantis1 left #evergreen |
17:07 |
|
sandbergja joined #evergreen |
17:14 |
|
mmorgan left #evergreen |
17:31 |
|
sandbergja joined #evergreen |
18:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
18:11 |
|
dbwells_ joined #evergreen |
19:07 |
|
sandbergja joined #evergreen |
19:28 |
|
rfrasur joined #evergreen |
19:30 |
|
rfrasur joined #evergreen |
19:58 |
|
Dyrcona joined #evergreen |