Time |
Nick |
Message |
06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:08 |
|
agoben joined #evergreen |
07:14 |
|
rjackson_isl_hom joined #evergreen |
07:35 |
|
Dyrcona joined #evergreen |
08:05 |
|
alynn26 joined #evergreen |
08:17 |
rjackson_isl_hom |
Good morning Lynn |
08:17 |
alynn26 |
good morning. |
08:17 |
rjackson_isl_hom |
Got an early start - nothing to report waiting more patron extension requests |
08:17 |
rjackson_isl_hom |
did Akron |
08:18 |
rjackson_isl_hom |
Sorry - wrong window :( |
08:30 |
|
rjackson_isl_hom left #evergreen |
08:30 |
|
rjackson_isl_hom joined #evergreen |
08:34 |
|
mmorgan joined #evergreen |
08:43 |
|
mantis1 joined #evergreen |
08:59 |
|
tlittle joined #evergreen |
09:01 |
|
Dyrcona joined #evergreen |
09:05 |
|
jvwoolf joined #evergreen |
09:23 |
|
rfrasur joined #evergreen |
09:42 |
|
annagoben joined #evergreen |
09:44 |
|
dluch joined #evergreen |
09:44 |
|
Bmagic joined #evergreen |
10:26 |
|
collum joined #evergreen |
10:33 |
|
sandbergja joined #evergreen |
11:03 |
|
jvwoolf1 joined #evergreen |
11:40 |
abneiman |
morning all. anyone know of a test server with a payment processor demo currently active? |
11:50 |
|
mrisher joined #evergreen |
11:58 |
csharp |
if any experienced Perl-layer devs have any tuits today, I'd appreciate eyes on my first draft fix of bug 1398107 |
11:58 |
pinesol |
Launchpad bug 1398107 in Evergreen "No warning provided when bib records with holds are deleted" [High,Confirmed] https://launchpad.net/bugs/1398107 - Assigned to Chris Sharp (chrissharp123) |
11:58 |
csharp |
pinesol: ahem |
11:58 |
pinesol |
csharp: git diff origin/hamster |
12:00 |
csharp |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=78d95afde4e7063f3c59abc1337c8c3d89067e2c - I have a feeling I have the editor syntax wrong here - still a little shaky on perl references and not sure the type of object I have in my hands at any given time :-) |
12:01 |
|
mikerisher joined #evergreen |
12:03 |
|
jihpringle joined #evergreen |
12:05 |
|
mrisher joined #evergreen |
12:11 |
|
sandbergja joined #evergreen |
12:20 |
Dyrcona |
csharp: you need a transaction for the update to succeed, and then a commit. |
12:21 |
|
mantis1 left #evergreen |
12:24 |
Dyrcona |
Ah, but the editor already has a transaction open, so that looks OK to me. |
12:24 |
berick |
csharp: also avoid using '... if $e->die_event' because that will force-kill the transaction. return $e->die_event unless $e->update_action_... or similar is what you want. |
12:25 |
berick |
you'll want to run the hold targeter for the modified holds as well |
12:29 |
|
mrisher joined #evergreen |
12:30 |
Dyrcona |
Hm... yeah. but do we want the transaction to fail if the holds can't be updated? |
12:31 |
berick |
no, similar APIs do the retargeting after commit |
12:31 |
berick |
e.g. open-ils.cat.transfer_copies_to_volume |
12:32 |
Dyrcona |
OK. |
12:35 |
Dyrcona |
csharp: What part of the editor syntax are you concerned about? You did the editor calls correctly for what it looks like you're trying to do. |
12:35 |
Dyrcona |
Except the die_event as noted by berick. |
12:35 |
Dyrcona |
And, that's semantic not syntax..... |
12:35 |
berick |
Dyrcona: i might have misread your question.. we want the xact to fail if the hold update fails, but not if the regarget fails. |
12:36 |
Dyrcona |
OK. So should it return $e->event, not $e->die_event, then? |
12:37 |
berick |
it should just check the return value of the update call |
12:37 |
berick |
return $e->die_event unless $e->update_action_... |
12:37 |
berick |
(using your if/unless structure of choice) |
12:37 |
Dyrcona |
All right.... Too much going on this week. :) |
12:38 |
|
sandbergja joined #evergreen |
12:39 |
|
mantis1 joined #evergreen |
12:40 |
Dyrcona |
I totally missed the redundancy of the "if $e->die_event" |
12:43 |
Dyrcona |
Mabye a doughnut will help? :) |
12:43 |
Dyrcona |
And fewer typos. |
12:43 |
berick |
I'm pretty sure a doughnut will help |
12:46 |
mmorgan |
doughnuts++ |
12:50 |
|
khuckins joined #evergreen |
12:54 |
|
alynn26_away joined #evergreen |
13:01 |
|
sandbergja joined #evergreen |
13:02 |
csharp |
Dyrcona: berick: thanks so much for the feedback - about to chomp into homemade mexican and will review in detail afterwards :-) |
13:28 |
|
mrisher joined #evergreen |
13:38 |
|
alynn26 joined #evergreen |
13:42 |
sandbergja |
Hey all! We are doing a mass fine amnesty of all the fines (not replacement costs, fees, etc.) in our OU. Does anybody have a good procedure for that ready to go? I don't do much with fines usually. |
13:43 |
jeff |
I'm working on a new version of what we've used in the far past, but that won't help you right now. |
13:43 |
jeff |
Are you looking to forgive all outstanding fines of a particular billing type? |
13:43 |
jeff |
Or just have "everything checks in in amnesty mode" for a while, or? |
13:46 |
troy__ |
we are also looking at something like this, but just for overdues |
13:46 |
troy__ |
been poking around the database seeing how to best approach it |
13:47 |
troy__ |
if i can help build something for that let me know |
13:47 |
troy__ |
or if i finish something and other people would have use of it will also give that out |
13:51 |
|
Stompro joined #evergreen |
13:53 |
* Dyrcona |
has a script somewhere that I used to pay all bills of certain types or for certain ous somewhere. I'll see if I can find it and share it. |
13:54 |
Dyrcona |
Already on Pastebin: https://pastebin.com/feAsnERF |
13:54 |
sandbergja |
the first one: forgive all outstanding fines |
13:54 |
sandbergja |
Dyrcona++ |
13:55 |
sandbergja |
We were hoping to minimize some confusion for circ staff, and also not contribute to any financial duress at this time. |
13:56 |
Dyrcona |
The thing I shared is not what anyone has said they actually wanted, but it makes a decent starting point. You have to enter patron barcodes via STDIN. |
13:56 |
|
Stompro joined #evergreen |
13:57 |
troy__ |
thanks Dyrcona :) |
13:57 |
Dyrcona |
There's a slightly better example here: https://github.com/Dyrcona/evergreen2019-preconference/blob/master/examples/forgive_bills.pl |
13:57 |
troy__ |
anything that saves me time |
13:57 |
Stompro |
hoopla-- |
13:57 |
Dyrcona |
Different version of the same program. |
13:58 |
troy__ |
i'm currently looking at db updates / inserts, but may do something like that |
13:58 |
Dyrcona |
You'll want to run the Perl on a utility server or brick where you can access the backend via Perl, of course. |
13:58 |
sandbergja |
Dyrcona: that looks like a really good starting place! Thank you |
14:01 |
Dyrcona |
You're welcome! I have lots of things like that hanging around. I'll see if I have something better, but I don't think so. |
14:06 |
Dyrcona |
No, that looks like the best example. I've got a couple of bill search scripts and one that pays all bills that says in the comments it was trying to induce a debuggable crash. |
14:13 |
|
jvwoolf joined #evergreen |
14:15 |
gmcharlt |
for anybody still in the midst of working to close, libraries, here's a post written by abneiman explaining how to use Emergency Closing Handler (available in 3.2+) to faciliate that: https://www.equinoxinitiative.org/blog?sid=10145e725531c0993144 |
14:15 |
gmcharlt |
*to close libraries |
14:16 |
rfrasur |
abneiman++ |
14:16 |
rfrasur |
gmcharlt++ |
14:19 |
sandbergja |
abneiman++ |
14:19 |
sandbergja |
gmcharlt++ |
14:27 |
Dyrcona |
abneiman++ gmcharlt++ |
14:31 |
collum |
abneiman++ gmcharlt++ |
14:32 |
abneiman |
miker++ # wrote the feature |
14:32 |
abneiman |
pails++ # funded said |
14:32 |
collum |
miker++ pails++ It's a very nice feature. |
14:55 |
rfrasur |
pails++ miker++ # it is a very nice feature |
14:55 |
rfrasur |
Just right for a pandemic of indeterminate length. |
14:55 |
rfrasur |
rfrasur-- |
14:58 |
mmorgan |
Prior to current events, we've had a number of libraries go fine free, so I've been inserting forgive payments for circs that fit the criteria. Not perfect, as I realized the transactions don't get closed, so I had to clean that up. I'll share a sample database query. |
15:00 |
|
jvwoolf1 joined #evergreen |
15:00 |
gmcharlt |
rfrasur: a very long snow |
15:00 |
gmcharlt |
*snow day |
15:01 |
rfrasur |
Yes. |
15:04 |
mmorgan |
Snow days are more fun. |
15:05 |
rfrasur |
That's probably true. Some of us (me) are not great at remaining productive in the face of unexpected transitions to new work paradigms. We make up for this fact by attempting grammatically correct sentences and high dollar vocabulary. It's a front. |
15:06 |
mmorgan |
:) |
15:07 |
* mmorgan |
has acquired many more tasks to perform in the past week or so |
15:08 |
rfrasur |
mmorgan++ |
15:14 |
pastebot |
"mmorgan" at 168.25.130.30 pasted "Example queries to forgive fines using a staging table" (23 lines) at http://paste.evergreen-ils.org/10136 |
15:31 |
|
mantis1 left #evergreen |
15:44 |
sandbergja |
mmorgan++ |
15:44 |
|
jihpringle joined #evergreen |
15:57 |
mmorgan |
I just tested an emergency closing on a past due date on a test system, and the Emergency closing report indicated Circulations: 0/783. Am I missing a setting somewhere? |
16:07 |
|
Dyrcona joined #evergreen |
16:08 |
Dyrcona |
WRT bug 1865302, I've had this around for a while and just updated it today: https://github.com/Dyrcona/evergreen_utilities/blob/master/perl/parameters.pl |
16:08 |
pinesol |
Launchpad bug 1865302 in Evergreen "Wishlist: make loan rules clear to staff and patrons" [Undecided,New] https://launchpad.net/bugs/1865302 |
16:09 |
Dyrcona |
It doesn't really solve that problem, but it has helped me and others who are responsible for maintaining and figuring out what the rules do. |
16:14 |
mmorgan |
Oh. bug 1818912 |
16:14 |
pinesol |
Launchpad bug 1818912 in Evergreen "Single Day Emergency Closings Fail to Update Due Dates Correctly" [High,Confirmed] https://launchpad.net/bugs/1818912 |
16:18 |
mmorgan |
Adding multiple days in the past works just fine. |
16:56 |
|
mrisher joined #evergreen |
17:00 |
|
jvwoolf1 left #evergreen |
17:05 |
|
mmorgan left #evergreen |
17:08 |
sandbergja |
He already got karma for this, but... |
17:09 |
sandbergja |
Dyrcona++ # that bill-paying script |
17:32 |
Bmagic |
Anyone heard of this virus thing? wow it seems like a big deal |
18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
18:22 |
csharp |
@praise Bmagic |
18:22 |
* pinesol |
Bmagic is very kind and good-looking and always does what's best for the project |
18:30 |
|
mrisher joined #evergreen |
21:17 |
|
mrisher joined #evergreen |
21:37 |
|
alynn26_away joined #evergreen |