| Time |
Nick |
Message |
| 00:30 |
|
jonadab joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:10 |
|
rjackson_isl joined #evergreen |
| 08:14 |
|
rfrasur joined #evergreen |
| 08:17 |
|
tlittle joined #evergreen |
| 08:30 |
|
Dyrcona joined #evergreen |
| 08:42 |
|
mmorgan joined #evergreen |
| 08:44 |
|
mantis1 joined #evergreen |
| 09:45 |
Bmagic |
I've got a test machine that I just cannot get the permission groups interface to work. I've traced down the error in the OpenSRF code |
| 09:45 |
Bmagic |
here is the error "Session cache for thread xxxxxxxxxxxx does not match request" |
| 09:46 |
Bmagic |
which coorisponds to an if statement if(!strcmp(ipAddr, trans->remoteHost) && !strcmp(recipient, trans->recipient)) |
| 09:46 |
Bmagic |
in the C code |
| 09:46 |
Bmagic |
Apparently my session IP address isn't matching trans->remoteHost |
| 09:47 |
Bmagic |
I've got all of my eg_vhost.conf configs setup with the three RemoteIPInternalProxy lines uncommented |
| 09:50 |
|
sandbergja joined #evergreen |
| 09:50 |
Bmagic |
I wonder if it's X-Forwarded-For vs. X-Real_IP - trying that |
| 09:55 |
bshum |
Bmagic: What about the memcache setting in eg_vhost.conf ? Is that all pointing to the right places? |
| 09:55 |
Bmagic |
yeah |
| 09:55 |
Bmagic |
127.0.0.1 :) |
| 09:56 |
berick |
Bmagic: just one brick / apache / web server running? |
| 09:56 |
Bmagic |
yep, one machine with nginx over apache. I've set this up a hundred times |
| 09:57 |
Bmagic |
The only thing odd is it's OpenSRF 3.2.0 and EG 3.3.5 |
| 09:57 |
Bmagic |
they work together right? |
| 09:57 |
|
mantis2 joined #evergreen |
| 09:58 |
bshum |
I always feel weird about mixing those up |
| 09:58 |
Bmagic |
I might have noticed something |
| 09:58 |
Bmagic |
proxy_set_header X-Real-IP $remote_addr; appears in my running config |
| 09:59 |
Bmagic |
that line seems to be omitted in the stock config.... |
| 09:59 |
Dyrcona |
Bmagic: OpenSRF 3.2.0 should work with Evergreen 3.0 to 3.5 (not yet released). |
| 10:00 |
Dyrcona |
The versions do not go up together. |
| 10:02 |
Bmagic |
Dyrcona: That's what I was thinking - it should be fine |
| 10:02 |
Bmagic |
There is an IP mis/match issue somehow. Which makes me want to focus on those X-Real_forwarded lines in the apache/nginx configs |
| 10:09 |
Bmagic |
is there an apache module that needs enabling for "X-Forwarded-For" to work? |
| 10:14 |
berick |
Bmagic: these are the relevant headers that seem to work for me: https://gist.github.com/berick/7867a9cd1dbc3c2a03ce136401314c7b |
| 10:14 |
Bmagic |
thanks! I'll be sure and mirror those |
| 10:15 |
|
mantis1 joined #evergreen |
| 10:15 |
Bmagic |
berick: do you not have this one: proxy_set_header Host $host; ? |
| 10:16 |
berick |
Bmagic: oh, i do have that, just left it out |
| 10:16 |
Bmagic |
ah, ok |
| 10:17 |
Bmagic |
berick: the lines in this block "location /osrf-websocket-translator" are the same as what you have? |
| 10:18 |
Bmagic |
(pasted there I mean) |
| 10:18 |
berick |
Bmagic: it's a little different. the issue you are having is unrelated to websockets, though |
| 10:18 |
Bmagic |
right on |
| 10:28 |
|
jvwoolf joined #evergreen |
| 10:29 |
Bmagic |
still getting the same error - I'm going to rebuild with OpenSRF 3.1.1 for kicks |
| 10:37 |
berick |
Bmagic: what OS? |
| 10:37 |
Bmagic |
16.04 |
| 10:38 |
* berick |
nods |
| 10:46 |
gmcharlt |
berick: sandbergja: I would be curious about your thoughts on 1145542d9a0f3386ba38ef1546e25a1af2ddcf17 in the working repo |
| 10:46 |
gmcharlt |
that patch is currently part of the acquisitions search branch, but could be (and probably should be) broken out separately |
| 10:50 |
Dyrcona |
Bmagic: OpenSRF 3.2.0/master uses X-Forwarded-For. You probably just need to make sure that your Apache and nginx configuration use the same header. It doesn't matter as long as they are the same. |
| 10:58 |
Bmagic |
3.1.1 and eg 3.3.5 fully rebuilt is now working |
| 10:59 |
Bmagic |
Dyrcona: That's what I thought too :) - no matter which way I did it, it kept failing |
| 11:00 |
Dyrcona |
Bmagic: The configuration is finicky. Any little typo will break things. |
| 11:00 |
Bmagic |
that must have been it. Probably a space somewhere |
| 11:01 |
Bmagic |
now that I have a working machine, making a small tweak and trying again - I'm on the hunt |
| 11:43 |
|
sandbergja joined #evergreen |
| 11:45 |
Bmagic |
Dyrcona: it was hostname in the hosts file! |
| 11:45 |
Bmagic |
what a journey |
| 11:45 |
Dyrcona |
OK. |
| 11:46 |
Bmagic |
local IP needed to have the external DNS name assigned to it in hosts |
| 11:46 |
Bmagic |
I can't believe that took 4 hours |
| 11:47 |
Dyrcona |
That doesn't sound exactly right to me. |
| 11:48 |
Dyrcona |
But, if that fixes it for you, then I guess so. |
| 11:48 |
Bmagic |
yep, crazy |
| 11:48 |
Dyrcona |
Could mean something else is wrong. |
| 11:51 |
Dyrcona |
Oh, that probably is correct. I forget that all of my systems have DNS properly configured. :) |
| 11:52 |
Bmagic |
:) |
| 11:52 |
Dyrcona |
Likely a nginx thing.... |
| 11:54 |
berick |
gmcharlt: commit looks sane. I expect eventually the templates will be unified as in-code strings tagged with $localize (Angular 9 or after) |
| 11:54 |
|
Christineb joined #evergreen |
| 11:54 |
gmcharlt |
berick: ah, great, that will help a lot |
| 11:55 |
gmcharlt |
berick: also, 1793c9d237fbc56f817dfa2d84e3f308b4ecc53e may be of interest as well |
| 11:55 |
gmcharlt |
I fully expect that eg-combobox will implement every single interface in @angular/core by the time we're done with it :) |
| 11:56 |
berick |
heh, seriously |
| 11:57 |
berick |
i have a vague mental todo for breaking it up at some point, maybe doing some subclassing to segregate idl and non-idl uses. maybe there will be a v2 down the road |
| 11:58 |
berick |
but for now, may as well do what we need it to do |
| 11:58 |
gmcharlt |
yeah, I think eg-combobox in particular reflects a lot of the iterations of us teaching ourselves Angular |
| 11:59 |
berick |
exactly |
| 12:01 |
|
jihpringle joined #evergreen |
| 12:30 |
|
khuckins joined #evergreen |
| 12:44 |
* mmorgan |
is wondering, is there a chance bug 1424815 can make it into 3.5? |
| 12:44 |
pinesol |
Launchpad bug 1424815 in Evergreen "Wishlist: Add a “read more” feature to the OPAC bib record view for fields with lots of text" [Wishlist,Confirmed] https://launchpad.net/bugs/1424815 |
| 13:16 |
|
jihpringle joined #evergreen |
| 13:16 |
|
alynn26 joined #evergreen |
| 13:20 |
|
jwoodard joined #evergreen |
| 14:16 |
berick |
csharp: if you don't mind, I'm going to tweak your fix for bug 1863929 and bump the sequences up to 100 to leave room for future inserts w/o having to worry about once again modifying the sequences |
| 14:16 |
pinesol |
Launchpad bug 1863929 in Evergreen "Concerto survey data fails to bump sequences" [Low,New] https://launchpad.net/bugs/1863929 - Assigned to Bill Erickson (berick) |
| 14:19 |
csharp |
berick: sure thing |
| 14:19 |
csharp |
thank |
| 14:19 |
csharp |
s |
| 14:19 |
berick |
thanks |
| 14:29 |
pinesol |
[evergreen|Chris Sharp] LP#1863929 - Fix sample survey data. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=faf06e1> |
| 14:29 |
pinesol |
[evergreen|Mike Risher] lp1845240 port of Surveys UI from DOJO to Angular - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7fea3da> |
| 14:31 |
|
jihpringle joined #evergreen |
| 14:31 |
|
jvwoolf joined #evergreen |
| 14:33 |
Dyrcona |
csharp: Commit emails appear to be broken, again. |
| 14:34 |
Dyrcona |
At least, I've not gotten any since Friday at 11:11 am. |
| 14:36 |
* rfrasur |
has an affinity for 11:11 a.m. Just saying. |
| 14:37 |
berick |
elevenses! |
| 14:37 |
rfrasur |
berick++ |
| 14:42 |
|
abowling joined #evergreen |
| 14:45 |
abowling |
renewed certs for a library 2 days ago. opac works fine, but i'm getting the following for the staff client (running apache2-websockets): opensrf_ws.js:62 WebSocket connection to 'wss://[redacted.library.org]:7682/osrf-websocket-translator' failed: Error in connection establishment: net::ERR_CERT_DATE_INVALID |
| 14:45 |
abowling |
anyone run into this? |
| 14:45 |
pinesol |
[evergreen|Chris Sharp] LP#1846484 - Add BETWEEN SYMMETRIC to reporter SQL builder - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=65ebd48> |
| 14:45 |
abowling |
all the .conf files are correct...so i believe |
| 14:50 |
jeff |
abowling: sounds like your websockets instance of Apache hasn't been restarted? |
| 14:50 |
jeff |
(or whatever is answering on [redacted.library.org]:7682) |
| 14:51 |
abowling |
jeff: what's weird is it had been restarted tons of times. reload is actually what fixed it. &@#! |
| 14:51 |
* abowling |
might have figured that out by now |
| 14:53 |
|
Dyrcona joined #evergreen |
| 14:54 |
Dyrcona |
abowling: Use the nginx proxy and you won't have to worry about it. |
| 14:55 |
csharp |
Dyrcona: last post I see to open-ils-commits was Feb 23 11:11:32 2020 |
| 14:56 |
Dyrcona |
Well, we've had some commits go through today, so .... |
| 14:56 |
csharp |
just sharing data... |
| 14:56 |
Dyrcona |
Yeahp, cool. |
| 14:57 |
csharp |
the git server reports successfully sending an email to open-ils-commits at Feb 26 14:41:47 |
| 14:57 |
Dyrcona |
spam filter? |
| 15:00 |
csharp |
postfix believes it was "status=sent (delivered via mailman service)" |
| 15:01 |
csharp |
hmm - mailman must have been hung - seeing posts come through now |
| 15:01 |
csharp |
*sigh* |
| 15:02 |
Dyrcona |
Ah well. We lost our Internet briefly, so nothing's perfect. |
| 15:03 |
csharp |
Dyrcona: thanks for poking me about it - I was blissfully unaware |
| 15:03 |
* Dyrcona |
knows that feeling. :) |
| 15:04 |
berick |
well, today is "National Pistachio Day". maybe mailman was celebrating. |
| 15:05 |
csharp |
berick++ |
| 15:05 |
* csharp |
was going with Ash Wednesday |
| 15:05 |
csharp |
@repent |
| 15:05 |
pinesol |
csharp: zarro boogs found |
| 15:05 |
csharp |
ha! |
| 15:06 |
berick |
heh |
| 15:06 |
berick |
@coffee [band] |
| 15:06 |
* pinesol |
brews and pours a cup of Sumatra Danau Toba, and sends it sliding down the bar to Wrong Bug |
| 15:06 |
sandbergja |
pinesol++ |
| 15:18 |
berick |
if anyone wants to squeeze in a final staff catalog feature, just rebased bug 1851882 |
| 15:18 |
pinesol |
Launchpad bug 1851882 in Evergreen "Angular catalog recall, force, and part holds" [Wishlist,New] https://launchpad.net/bugs/1851882 |
| 15:29 |
|
mantis1 left #evergreen |
| 15:29 |
|
Dyrcona joined #evergreen |
| 15:32 |
jeffdavis |
bug 1811132 is signed off, would be nice for 3.5 if anyone feels like committing. It touches a lot of files but the actual changes aren't all that major. |
| 15:32 |
pinesol |
Launchpad bug 1811132 in Evergreen "Wishlist - New Payment Type "Debit" " [Wishlist,New] https://launchpad.net/bugs/1811132 |
| 15:38 |
jeffdavis |
And here are all signed-off, uncommitted wishlist bugs for 3.5/3.next: https://tinyurl.com/wb4oyrb |
| 15:39 |
mmorgan |
jeffdavis++ |
| 15:41 |
jeffdavis |
I wish I'd thought to look at that list on Monday though |
| 15:46 |
|
jwoodard joined #evergreen |
| 15:49 |
|
bdljohn1 joined #evergreen |
| 15:58 |
csharp |
miker: I added a signoff and a comment on bug 1789679 |
| 15:58 |
pinesol |
Launchpad bug 1789679 in Evergreen "Supply subtotal and grand total rows in reports that use aggregate functions" [Wishlist,Confirmed] https://launchpad.net/bugs/1789679 |
| 16:08 |
csharp |
jeffdavis: looking at bug 1811132, FYI |
| 16:09 |
pinesol |
Launchpad bug 1811132 in Evergreen "Wishlist - New Payment Type "Debit" " [Wishlist,New] https://launchpad.net/bugs/1811132 - Assigned to Chris Sharp (chrissharp123) |
| 16:09 |
jeffdavis |
csharp++ # Canada thanks you! |
| 16:10 |
|
bdljohn1 left #evergreen |
| 16:11 |
jeffdavis |
New committer question: When committing to master, we use cherry-pick? |
| 16:12 |
Dyrcona |
Yes, git cherry-pick -s |
| 16:12 |
jeffdavis |
thanks |
| 16:12 |
Dyrcona |
-s to add your signature. |
| 16:12 |
Dyrcona |
Make sure you get all of the commits in the right order, that's the tricky bit. |
| 16:13 |
Dyrcona |
I shared a gist of a tool that can help with that earlier this week. |
| 16:13 |
jeffdavis |
I'm looking at bug 1853363 which is a single commit and no db upgrades, so minimal potential for error :) |
| 16:13 |
pinesol |
Launchpad bug 1853363 in Evergreen "SIP2: add setting to specify overriding certain flag fields" [Wishlist,Confirmed] https://launchpad.net/bugs/1853363 |
| 16:13 |
jeffdavis |
but if someone is ready to go ahead and commit that one, please don't wait on me |
| 16:13 |
Dyrcona |
Yeah, good thing to start with. |
| 16:13 |
Dyrcona |
I'm heading out, now. Good luck, jeffdavis! |
| 16:13 |
csharp |
jeffdavis++ |
| 16:14 |
jeffdavis |
Thanks! |
| 16:17 |
* mmorgan |
holds up campaign sign for bug 1424815 ;-) |
| 16:17 |
pinesol |
Launchpad bug 1424815 in Evergreen "Wishlist: Add a “read more” feature to the OPAC bib record view for fields with lots of text" [Wishlist,Confirmed] https://launchpad.net/bugs/1424815 |
| 16:20 |
khuckins |
readmore++ |
| 16:20 |
khuckins |
But I'm biased :) |
| 16:20 |
mmorgan |
khuckins++ |
| 16:23 |
csharp |
calling 1200 in the name of odometers turning over everywhere |
| 16:27 |
jeffdavis |
I don't feel confident enough to commit that "read more" feature myself, but it would be nice to get it released after all that work and with at least one consortium already using it. |
| 16:27 |
pinesol |
[evergreen|Jeff Davis] LP#1811132: add Debit Card payment type - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3d7a7c1> |
| 16:27 |
pinesol |
[evergreen|Chris Sharp] LP#1811132 - Stamping upgrade script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=975ef96> |
| 16:27 |
csharp |
yeah, it's pretty intimidating |
| 16:28 |
csharp |
just trying to follow the comment thread on the bug was making my eyes roll around last week |
| 16:29 |
* csharp |
checks out the branch to install on his test server anyway |
| 16:30 |
mmorgan |
Read more example: https://evergreen.noblenet.org/eg/opac/record/4433320?locg=1 |
| 16:31 |
* mmorgan |
suggests starting with comment #19 on the bug https://bugs.launchpad.net/evergreen/+bug/1424815/comments/19 |
| 16:31 |
pinesol |
Launchpad bug 1424815 in Evergreen "Wishlist: Add a “read more” feature to the OPAC bib record view for fields with lots of text" [Wishlist,Confirmed] |
| 16:34 |
csharp |
khuckins: would you mind rebasing your branch to master? I'm getting conflicts on nearly every file due to new features added since |
| 16:34 |
csharp |
I'd be happy to test the branch if you do :-) |
| 16:34 |
khuckins |
Will do :) |
| 16:35 |
csharp |
thanks |
| 16:37 |
dbwells |
khuckins: I would also suggest squashing as a way to make it a bit easier to review. |
| 16:45 |
* mmorgan |
doesn't suppose there's any way that bug 1749475 could get in to 3.5 at this point, is there? |
| 16:45 |
pinesol |
Launchpad bug 1749475 in Evergreen "wishlist: Improved email and printing from the OPAC" [Wishlist,Confirmed] https://launchpad.net/bugs/1749475 |
| 16:51 |
|
jvwoolf left #evergreen |
| 16:58 |
khuckins |
Read More's been squashed and rebased |
| 16:59 |
jeffdavis |
gmcharlt/JBoyer: in testing bug 1853363 on a user with a PATRON_EXCEEDS_FINES penalty, patron_status_always_permit_loans sets charge/renewal privileges denied appropriately in the patron status fixed-length field, but the AF field will still read as "blocked" - I take it this is the desired behavior? |
| 16:59 |
pinesol |
Launchpad bug 1853363 in Evergreen "SIP2: add setting to specify overriding certain flag fields" [Wishlist,Confirmed] https://launchpad.net/bugs/1853363 - Assigned to Jeff Davis (jdavis-sitka) |
| 17:01 |
gmcharlt |
jeffdavis: it's at least not incompatible with what Hoopla is expecting to my knowledge |
| 17:01 |
gmcharlt |
... which is not intended as a strong defense of that behavior :) |
| 17:01 |
csharp |
heh |
| 17:02 |
jeffdavis |
Heh. So to put it more plainly, we are ok with setting AF = "blocked" even if the patron status field says checkout and renewal are allowed? |
| 17:03 |
jeffdavis |
It wouldn't be the first time a vendor has had weird SIP requirements... |
| 17:03 |
gmcharlt |
and it won't be the last |
| 17:03 |
csharp |
yeah - each one is a special snowflake |
| 17:03 |
* gmcharlt |
weeps |
| 17:03 |
* jeffdavis |
gesticulates wildly, mutters about working on PatronAPI compatibility |
| 17:09 |
|
mmorgan left #evergreen |
| 17:29 |
jeffdavis |
ok, SIP commit pushed to master, please let me know if I did anything wrong |
| 17:30 |
pinesol |
[evergreen|Galen Charlton] LP#1853363: add SIP2 option patron_status_always_permit_loans - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=42939f1> |
| 17:47 |
dbwells |
jeffdavis++ # looks good! |
| 17:47 |
jeffdavis |
Phew! Thanks for checking. :) |
| 17:51 |
csharp |
jeffdavis++ |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:07 |
|
sandbergja_ joined #evergreen |
| 18:18 |
|
RBecker joined #evergreen |
| 18:46 |
|
Christineb joined #evergreen |
| 19:42 |
|
jihpringle joined #evergreen |
| 19:43 |
|
sandbergja joined #evergreen |
| 20:16 |
|
sandbergja joined #evergreen |
