| Time |
Nick |
Message |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:57 |
|
agoben joined #evergreen |
| 07:07 |
|
rjackson_isl joined #evergreen |
| 07:48 |
|
rfrasur joined #evergreen |
| 07:57 |
|
Dyrcona joined #evergreen |
| 08:37 |
|
mmorgan joined #evergreen |
| 08:46 |
|
tlittle joined #evergreen |
| 08:50 |
|
jvwoolf joined #evergreen |
| 09:21 |
|
mantis1 joined #evergreen |
| 09:28 |
csharp |
@band add Feedbag Fest |
| 09:28 |
pinesol |
csharp: Band 'Feedbag Fest' added to list |
| 09:29 |
|
alynn26 joined #evergreen |
| 09:31 |
|
yboston joined #evergreen |
| 09:39 |
|
terranm joined #evergreen |
| 09:39 |
rfrasur |
lol csharp++ |
| 10:02 |
Dyrcona |
csharp: Have you had a chance to look into the missing git emails? |
| 10:05 |
|
mmorgan1 joined #evergreen |
| 10:11 |
Bmagic |
shoot - I know I've asked this before.... there was a lightning talk at a conference maybe two years ago where someone showed Evergreen OPAC re-worked with bootstrap and accessibility... |
| 10:11 |
|
BAMkubasa joined #evergreen |
| 10:12 |
berick |
https://bugs.launchpad.net/evergreen/+bug/1778972 |
| 10:12 |
berick |
Bmagic: ^-- that? |
| 10:12 |
pinesol |
Launchpad bug 1778972 in Evergreen "Wishlist - OPAC Redesign" [Wishlist,In progress] - Assigned to Christopher Burton (cburton) |
| 10:13 |
Bmagic |
!!! I think that's it |
| 10:13 |
Bmagic |
berick++ |
| 10:18 |
terranm |
One of Feedback Fest sandboxes had all its patches tested, so Chris has rebuilt it with a fresh set of patches ready for testing (Bite-Sized Group 3): https://docs.google.com/spreadsheets/d/1nDXg83ZAZlDYBxb0z59-hKqEjjPxpEuUssI2qtANax4/edit?usp=sharing |
| 10:18 |
terranm |
csharp++ |
| 10:19 |
tlittle |
csharp++ |
| 10:45 |
|
mmorgan joined #evergreen |
| 10:45 |
|
sandbergja joined #evergreen |
| 10:49 |
csharp |
Dyrcona: hmm - I resolved a few issues on the list server that I thought fixed everything, but yeah, I can see that I haven't received any mail from the list since 1/22 |
| 10:54 |
Dyrcona |
It could be something on the git server, but I don't think I have command line access. |
| 11:00 |
csharp |
I see the problem - it's trying to send to a defunct server |
| 11:07 |
|
jvwoolf1 joined #evergreen |
| 11:16 |
pinesol |
[evergreen|Bill Erickson] LP1860468 Org unit admin interface sorting - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f80965a> |
| 11:46 |
csharp |
ok, looks like email is back to flowing |
| 11:48 |
csharp |
the git server was configured to relay mail through the GPLS hosted email server, which we deactivated - I configured postfix on the git server to send from its own instance |
| 11:49 |
alynn26 |
csharp++ |
| 11:49 |
csharp |
there may be side effects to that, so please let me know if something else needs to happen |
| 11:52 |
Dyrcona |
OK. |
| 11:52 |
Dyrcona |
csharp++ |
| 11:54 |
bshum |
csharp++ |
| 13:25 |
|
sandbergja joined #evergreen |
| 13:35 |
|
terranm joined #evergreen |
| 14:02 |
|
dbwells_ joined #evergreen |
| 14:19 |
|
khuckins joined #evergreen |
| 14:35 |
|
jihpringle joined #evergreen |
| 14:47 |
|
dbwells joined #evergreen |
| 15:10 |
|
jihpringle joined #evergreen |
| 15:25 |
terranm |
Bmagic: I'm testing LP1849736 but I'm not seeing any emails come through. I set my email address on the org unit BR1 and as the sender email in the library settings editor for BR1. Is there an additional config piece I need? |
| 15:29 |
Bmagic |
terranm: looking |
| 15:30 |
Bmagic |
looks like it's AT not firing |
| 15:38 |
Bmagic |
terranm: did you setup the AT? |
| 15:39 |
Bmagic |
You should need to configure the email trigger to suit your needs. AKA: who it should email, which OU, etc. |
| 15:40 |
Bmagic |
The patch creates a action trigger template that you can use as an example (or just toggle it enabled after you vet the email template bits) |
| 15:40 |
Dyrcona |
Bmagic: An appropriate action_trigger_runner.pl also needs to be running, and the VM/docker instance needs to be able to deliver email. |
| 15:40 |
Bmagic |
Dyrcona: yep, that's setup |
| 15:41 |
Dyrcona |
Bmagic++ Just makin' sure. :) |
| 15:41 |
Bmagic |
:) # all the little EG pieces |
| 15:41 |
Dyrcona |
Indeed! |
| 15:42 |
terranm |
Bmagic: I didn't modify the default action trigger. I'll try that. |
| 15:44 |
terranm |
Bmagic: is params.recipient_email just a placeholder? |
| 15:49 |
Bmagic |
yep, if you provide the params for the AT, then it would kick in |
| 15:49 |
Dyrcona |
params.recipient_email is a variable that gets filled in by the a/t execution environment. |
| 15:49 |
Dyrcona |
If you're testing, you could hard code it, but its better to get the value in there however this event expects it to be filled in. |
| 15:50 |
|
jvwoolf joined #evergreen |
| 15:50 |
Dyrcona |
By hard code, I mean replace it with an actual, valid email address in the template. |
| 15:52 |
terranm |
So I tried it first by putting the email into the org unit email field, and into the library settings editor sender email field, and nothing came through. Then tried hardcoding it into the template and it didn't come through either. |
| 15:53 |
|
nfBurton joined #evergreen |
| 15:56 |
nfBurton |
@berick Hey! I see you were asking about https://bugs.launchpad.net/evergreen/+bug/1778972 |
| 15:56 |
pinesol |
nfBurton: PHRASING!!! |
| 15:56 |
pinesol |
Launchpad bug 1778972 in Evergreen "Wishlist - OPAC Redesign" [Wishlist,In progress] - Assigned to Christopher Burton (cburton) |
| 15:56 |
Bmagic |
nfBurton: that was me |
| 15:57 |
Bmagic |
terranm: The AT is still inactive |
| 15:57 |
nfBurton |
Oh I see. I may need a hand with pushing that GIT repo. It is fairly ready, just needs a bit more work that can be done while up |
| 15:57 |
terranm |
Bmagic: oh, doy |
| 15:57 |
nfBurton |
It is my first push, so I wanted to be sure it was done right but didnt want to miss this release |
| 15:58 |
Bmagic |
nfBurton: that was the work I figured needed done. I was thinking my steps would be: run a diff between your directory structure on github against rel_3_1/OpenILS/var/templates - then commit - then rebase against master |
| 15:58 |
Dyrcona |
Bmagic: I don't see how params.recipient_email is going to get filled in, but looks like you covered all the bases with the other email lookups. :) |
| 15:58 |
nfBurton |
It was also suggested to run it beside the current OPAC so it is an opt in until adoption |
| 15:59 |
nfBurton |
I've been busy lately so I need to check the diff first, then I can push the current progress. |
| 16:00 |
Dyrcona |
I recommend just doing a rebase and resolving any conflicts. I'm not sure how a diff is really going to help, unless you really want to see the drift before diving into the deep end. |
| 16:01 |
Bmagic |
Drycona: he doesn't have his code on top of any Evergreen git repo |
| 16:01 |
nfBurton |
If I commit to a working directory and link it in the ticket, will it be merged like that or is there more to do? |
| 16:01 |
|
lbmv joined #evergreen |
| 16:02 |
Bmagic |
nfBurton: this is what I am looking at: https://github.com/GalacticHero228/Evergreen-Bootstrap-Template is that the right stuff? |
| 16:02 |
Dyrcona |
Bmagic: You said "github." I assume that's a git repo. I assume nfBurton has a local copy. Then, adding a git.evergreen-ils.org remote and rebasing is easy peasy. |
| 16:02 |
|
khuckins joined #evergreen |
| 16:03 |
nfBurton |
That hasnt been updated since 3.1 but yeah. I have the current one with origin master |
| 16:04 |
nfBurton |
So I just push to a working branch with my name? |
| 16:04 |
nfBurton |
right? |
| 16:04 |
Dyrcona |
Yeah, pretty much. |
| 16:04 |
Bmagic |
oh good, it sounds like you already have the updates on top of a copy of Evergreen locally? |
| 16:04 |
Bmagic |
nfBurton: https://wiki.evergreen-ils.org/doku.php?id=dev:git |
| 16:04 |
nfBurton |
Yeah. My dev server is usually up to date. Its a few weeks behind now but easy enough to finish |
| 16:05 |
nfBurton |
I have that bookmarked :) |
| 16:05 |
Bmagic |
well then! It sounds like you are just one or two commands away |
| 16:05 |
terranm |
Does he need to be given permissions to push to working first? |
| 16:05 |
nfBurton |
yes |
| 16:05 |
* Dyrcona |
works with 7 Evergreen remotes on 3 different git servers. |
| 16:05 |
nfBurton |
I have my public key set up |
| 16:06 |
Bmagic |
terranm: yes, but I assumed that was done for him at some point |
| 16:06 |
nfBurton |
Dyrcona set me up a long while ago |
| 16:06 |
terranm |
perfect |
| 16:06 |
Dyrcona |
I can make doubly sure, but I am 99% certain that.... Yeah, what nfBurton said. :) |
| 16:07 |
nfBurton |
Cool. Just want to make sure. I've been excited to push but nervous too. It's my first heehee |
| 16:07 |
terranm |
nfBurton++ |
| 16:08 |
mmorgan |
nfBurton++ |
| 16:08 |
nfBurton |
Did I miss the cutoff for 3.5? |
| 16:08 |
Dyrcona |
No need to be nervous pushing to working. About the only thing that goes wrong is you forget to add user/<username>/... on your remote branch. |
| 16:08 |
Bmagic |
nfBurton: it's getting really really close - if we could get it included in this feedback fest, that would be sweet: <<< terranm |
| 16:09 |
nfBurton |
Yeah, I guess so |
| 16:09 |
Dyrcona |
nfBurton: Not yet, but an OPAC rewrite may be too big to make it in at this point, but ultimately that's up to csharp and berick. |
| 16:09 |
nfBurton |
Okay. Shoi;d have time to push tomorrow |
| 16:09 |
Bmagic |
nfBurton++ |
| 16:09 |
nfBurton |
It is big but gcharleton recommended that I add it as a secondary option like OPAC-New or something that can be switched to |
| 16:10 |
terranm |
Agree that something that big should require more extensive testing from the whole community, but I'm excited to poke at it |
| 16:10 |
Bmagic |
nfBurton++ # OPAC rewrite! Heck yes |
| 16:10 |
nfBurton |
So both would be available for a version or so |
| 16:10 |
terranm |
(Also a little terrified because it will probably conflict with the rbdigital work) |
| 16:11 |
Bmagic |
conflict shmanflict |
| 16:11 |
Bmagic |
:) |
| 16:11 |
nfBurton |
Maybe, but as a secondary template, we can figure it out |
| 16:11 |
Dyrcona |
bleh. github wants me to sign in again, but I don't feel like it. |
| 16:11 |
Bmagic |
Dyrcona: I agree |
| 16:12 |
Bmagic |
terranm: Got your stuff to execute - now dealing with your template - it resulted in no FROM address |
| 16:14 |
Dyrcona |
Bmagic: set org.bounced_emails? |
| 16:14 |
Bmagic |
yeah, it was set at BR1 but not at CONS |
| 16:14 |
Bmagic |
fixed that |
| 16:15 |
Bmagic |
hmm, still getting from=<> |
| 16:15 |
Dyrcona |
Is this Ubuntu 18.04? |
| 16:16 |
Bmagic |
oh, nevermind, it's all good |
| 16:16 |
Bmagic |
terranm: did you get an email? |
| 16:16 |
terranm |
Not yet |
| 16:17 |
Bmagic |
check spam? |
| 16:17 |
terranm |
Nothing in spam |
| 16:18 |
|
jvwoolf1 joined #evergreen |
| 16:19 |
Bmagic |
well, it fired, and ATE says it completed. The ATEO has the output looking good. Mail logs show the entry |
| 16:19 |
pastebot |
"Bmagic" at 168.25.130.30 pasted "AT Output" (11 lines) at http://paste.evergreen-ils.org/10127 |
| 16:19 |
Bmagic |
See anything wrong with that email ^ ? |
| 16:20 |
terranm |
No, it looks right to me |
| 16:21 |
|
mantis1 left #evergreen |
| 16:22 |
Dyrcona |
Bmagic: Do the mail logs show the message being delivered or was it greylisted? |
| 16:22 |
Bmagic |
I think the issue was having the "Auto-Submitted" clause below the Subject clause? I edited the template and moved that clause up a couple of lines and the email sent (terranm: you got an email this time?) |
| 16:23 |
terranm |
Nope, still no email |
| 16:24 |
Bmagic |
Dyrcona: mail logs look good. I think terranm got it.. After I moved the Auto-Submitted line, the mail logs got better :) |
| 16:24 |
terranm |
Comparing to the action triggers we have in production, and we have the auto-submitted line below the subject line, so I don't think that was it |
| 16:24 |
Bmagic |
to=<tmccanna georgialibraries.org>, delay=00:02:01, xdelay=00:02:01, mailer=esmtp, pri=120271, relay=alt2.aspmx.l.google.com. [64.233.177.27], dsn=2.0.0, stat=Sent (OK 1582060984 n2si2435814ywk.370 - gsmtp) |
| 16:24 |
terranm |
I got that one! |
| 16:24 |
Bmagic |
stat=Sent is a good thing right? |
| 16:24 |
Bmagic |
ok, thought so |
| 16:26 |
Bmagic |
terranm: now that this is working - test the bug again |
| 16:26 |
terranm |
thanks |
| 16:27 |
Bmagic |
cron runs every minute - you could expect to wait at least 1 minute or 2 or 3 for the server to fire the email and maybe another minute for your mail server to deliver it to the inbox and another 1 minute for your mail client to get the message (depending on a ton of variables) |
| 16:29 |
* Bmagic |
has watch command running for new rows to appear in ATE |
| 16:29 |
terranm |
I've submitted two new pending patrons |
| 16:30 |
terranm |
Added template body back in and submitted another |
| 16:32 |
Bmagic |
the AT delay value is set to 1 minute - it fired |
| 16:33 |
terranm |
Got it! |
| 16:33 |
Bmagic |
very good |
| 16:33 |
Bmagic |
computers++ |
| 16:33 |
* Dyrcona |
calls it a day. |
| 16:34 |
mmorgan |
Bmagic++ |
| 16:34 |
Bmagic |
Dyrcona: take it easy |
| 16:34 |
mmorgan |
terranm++ |
| 16:34 |
mmorgan |
teamwork++ |
| 16:34 |
terranm |
Bmagic++ |
| 16:34 |
Bmagic |
:) |
| 16:34 |
Bmagic |
terranm++ # hanging in there |
| 16:34 |
terranm |
Bmagic: was the auto-submitted line the problem, you think? Or was there something else? |
| 16:35 |
Bmagic |
not really sure - It's kind of assumed that libraries will customize the heck out of that and it won't look anything like the stock stub |
| 16:36 |
terranm |
Yeah, we've heavily customized all of ours. Hard to test when the stock doesn't work at all out of the box though. |
| 16:36 |
Bmagic |
looking to see what the differences are |
| 16:38 |
terranm |
I'm going to start plugging things back into the template |
| 16:38 |
Bmagic |
maybe something is required to appear in action_trigger.environment... this is mentioned target.0.home_ou.id which might throw a template error if the environment doesn't include home_ou |
| 16:39 |
Bmagic |
yeah, I bet that's it |
| 16:40 |
terranm |
I was wondering if that was it |
| 16:42 |
Bmagic |
you have a copy of the exact original template? |
| 16:42 |
terranm |
I'm looking at it in your pullrequest |
| 16:42 |
Bmagic |
put that in there and introduce an environment setting with simply "home_ou" |
| 16:43 |
terranm |
home_ou is already in the Event Environment |
| 16:44 |
Bmagic |
oh yeah, lol, there it is in the patch |
| 16:44 |
terranm |
I'm not sure if lib = target.0.home_ou is correct |
| 16:45 |
Bmagic |
target.0 should work when the event is grouped... and it is |
| 16:45 |
terranm |
ok |
| 16:46 |
Bmagic |
but maybe there are others watching the chat that know more on the subject |
| 16:52 |
Bmagic |
It might* be the minus sign after the percent sign. that's tt2 language for "remove white space caused by the beginning of this clause" - likewise with the minus sign before the percent sign "remove white space caused by the end of this clause" |
| 16:53 |
terranm |
I JUST thought of that :) |
| 16:54 |
terranm |
Plugged in the format we use locally and just submitted another |
| 16:54 |
Bmagic |
I see you have it back to non-original |
| 16:54 |
terranm |
Yep, I think it's the excess white space |
| 16:54 |
terranm |
The minus signs make it work, it didn't work without them |
| 16:56 |
Bmagic |
my logs suggest that the default template (that I just put back into place) would have resulted in an email to you |
| 16:56 |
terranm |
(at least when it's outside of the lt/gt signs) |
| 16:57 |
Bmagic |
sorry - I think we have been editing it at the same time. Take a look a the template at the moment - it's default from the patch |
| 16:58 |
terranm |
Okay, trying again now with the straight default |
| 16:58 |
Bmagic |
k |
| 17:00 |
terranm |
Nothing yet - are you seeing it generated? |
| 17:00 |
Bmagic |
yep, just generated |
| 17:02 |
Bmagic |
I think it worked - I think I figured it out - It's the whitespace at the top of the template |
| 17:02 |
Bmagic |
If there is more than one carriage return, the SMTP headers break |
| 17:02 |
Bmagic |
The patch has two |
| 17:02 |
terranm |
that makes sense - still no email though |
| 17:03 |
terranm |
I'm going to try stripping out the extra white spaces in from & to |
| 17:03 |
Bmagic |
oh - it went to tmccannamobiusconsortium.org |
| 17:03 |
terranm |
lol |
| 17:03 |
Bmagic |
I think we have to (at a minimum) put your email address raw into the template |
| 17:04 |
Bmagic |
how about this - leave the template alone and I'll make a recipient_email setting with your email address |
| 17:05 |
terranm |
It should be able to grab it from the org unit settings |
| 17:05 |
terranm |
It was entered wrong in the library setting - fixing now |
| 17:05 |
Bmagic |
heres the thing - we NEED it to forge the email with a FROM address xxxxmobiusconsortium.org for spam reasons |
| 17:06 |
terranm |
Ah |
| 17:06 |
Bmagic |
so the setting should be xxxxmobiusconsortium.org and that should get plopped into the from address with that variable chain |
| 17:07 |
terranm |
okay, changed it back to tmccannamobiusconsortium.org |
| 17:07 |
terranm |
modifying the To to hardcode in my email |
| 17:07 |
Bmagic |
ok, now, I think we are good - the template is stock from patch |
| 17:08 |
Bmagic |
leave the template stock, and I've introduced a parameter recipient_email |
| 17:09 |
Bmagic |
that way we are testing the patch template exactly |
| 17:09 |
terranm |
k - testing now |
| 17:09 |
Bmagic |
(with the extra line return removed though) |
| 17:10 |
Bmagic |
also - no need to re-re-register new patrons - I'm resetting the AT's with each test, and it generates a new email from the old ones again |
| 17:10 |
terranm |
oh, ok |
| 17:11 |
|
mmorgan left #evergreen |
| 17:12 |
terranm |
Nothing coming through |
| 17:13 |
Bmagic |
still mobius... working on it |
| 17:16 |
Bmagic |
welp - resorted to putting it into the template for the "To" clause and it worked |
| 17:16 |
terranm |
Okay, it worked that time |
| 17:17 |
Bmagic |
I think the patch needs the "double line at the top removal" tweak - but other than that, the stock template works. The To and the From need to be customized on a per branch/system basis. For it to forge the mail from the right email address (spam reasons) and to go to either the staff or the patron |
| 17:17 |
Bmagic |
which is the same as any other email/sms template in the stock template set |
| 17:19 |
terranm |
We do all our templates at the consortium level, but the libraries have to update their SPF records with our IP addresses |
| 17:19 |
Bmagic |
that'll work too :) |
| 17:19 |
terranm |
If you wanna update your patch to remove the extra blank line, I'll sign off! |
| 17:19 |
Bmagic |
groovy, just a sec |
| 17:30 |
Bmagic |
terranm: force pushed |
| 17:34 |
Bmagic |
I was starting to think we needed to move over to PM instead of flooding #evergreen - sorry all |
| 17:35 |
terranm |
I figured most everyone was already gone :) |
| 17:36 |
|
jvwoolf1 left #evergreen |
| 17:37 |
Bmagic |
:) - also - the double blank lines at the top of Email AT's - I would advocate that's a bug in Evergreen. It would be nicer if Evergreen would trim that off for us |
| 17:38 |
terranm |
Good point! |
| 17:38 |
Bmagic |
such an easy mistake - breaks the whole thing |
| 17:39 |
terranm |
And with that, 1855781 can be rolled off the sandbox and the next batch (Larger component group 5) can be put on when you have time |
| 17:40 |
Bmagic |
alright - will probably do that tomorrow - I'll let you know when it's set |
| 17:40 |
terranm |
Thanks! Bmagic++ |
| 17:40 |
Bmagic |
terranm++ |
| 17:41 |
terranm |
There's only one other bite-sized patch on there that hasn't been tested yet - maybe I can get Elaine to test it tomorrow morning so you can start fresh with a new bite sized group too |
| 17:41 |
Bmagic |
ok, I'll hold off for your go-ahead then |
| 17:44 |
terranm |
Cool beans, have a good night! |
| 17:44 |
Bmagic |
you too :) |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:05 |
|
sandbergja joined #evergreen |
| 20:57 |
|
sandbergja joined #evergreen |
| 21:26 |
|
sandbergja joined #evergreen |
| 21:30 |
|
sandbergja joined #evergreen |
| 23:29 |
|
sandbergja joined #evergreen |
