| Time |
Nick |
Message |
| 01:23 |
|
cmalm joined #evergreen |
| 01:53 |
|
sandbergja joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Failed Create Evergreen Database <http://testing.evergreen-ils.org/~live//archive/2020-01/2020-01-10_04:00:02/test.41.html> |
| 06:57 |
|
rfrasur joined #evergreen |
| 07:26 |
|
rjackson_isl joined #evergreen |
| 08:28 |
pastebot |
"phasefx" at 168.25.130.30 pasted "re: pgtap failure" (34 lines) at http://paste.evergreen-ils.org/10119 |
| 08:31 |
csharp |
investigating an issue where bib TCNs are getting changed to the record ID upon saving - I've ruled out BibCommon.pm as a possible cause - now looking at marcedit.js |
| 08:32 |
csharp |
apparently only happening when editing an existing record - imports from z39.50 are not affected as far as I understand |
| 08:32 |
csharp |
confirmed - only already existing records |
| 08:32 |
|
Dyrcona joined #evergreen |
| 08:33 |
csharp |
(on 3.4 testing server, btw) |
| 08:35 |
|
sandbergja joined #evergreen |
| 08:40 |
|
mantis1 joined #evergreen |
| 08:44 |
|
_bott_ left #evergreen |
| 08:45 |
|
mmorgan joined #evergreen |
| 08:59 |
mmorgan |
csharp: Could someone have changed a global flag? cat.bib.use_id_for_tcn |
| 09:00 |
|
mmorgan1 joined #evergreen |
| 09:01 |
csharp |
not in this case - I checked that early on |
| 09:01 |
csharp |
also, looks like that's only consulted during import if I'm reading BibCommon.pm correctly |
| 09:01 |
csharp |
edited records should preserve whatever the TCN is |
| 09:10 |
|
stephengwills joined #evergreen |
| 09:13 |
|
stephengwills left #evergreen |
| 09:20 |
csharp |
issue confirmed on current master |
| 09:38 |
|
jvwoolf joined #evergreen |
| 09:41 |
|
collum joined #evergreen |
| 09:47 |
csharp |
..and now my master server is permanently white-screened for some reason |
| 09:52 |
Bmagic |
whitescreen-- |
| 09:54 |
csharp |
pretty sure it's the new hatch changes + me not having upgraded my db after applying them |
| 10:00 |
|
cmalm joined #evergreen |
| 10:15 |
csharp |
ok, I tracked the TCN issue down to the fix for bug 1693580 |
| 10:15 |
csharp |
pinesol: yo |
| 10:15 |
pinesol |
Launchpad bug 1693580 in Evergreen 3.3 "web client: attempting to update a MARC record without required permissions fails without feedback to the user" [Medium,Fix released] https://launchpad.net/bugs/1693580 |
| 10:15 |
pinesol |
csharp: You keep using that word. I do not think it means what you think it means. |
| 10:15 |
berick |
pinesol throwing some shade |
| 10:15 |
pinesol |
berick: http://cat.evergreen-ils.org.meowbify.com/ |
| 10:16 |
berick |
oh no, meowbify is gone |
| 10:16 |
berick |
har https://github.com/mobify/meowbify |
| 10:25 |
* csharp |
opens https://bugs.launchpad.net/evergreen/+bug/1859191 |
| 10:25 |
pinesol |
Launchpad bug 1859191 in Evergreen "Editing and saving MARC record changes the TCN value" [High,New] |
| 10:30 |
|
sandbergja joined #evergreen |
| 10:35 |
JBoyer |
csharp: I don't know if it counts as insight, but the reason for the change in that bug is the change from a pcrud update on bre vs calling the open-ils.cat.biblio.record.marc.replace API, which does more stuff. Some of that other stuff must include accidentally updating the TCN when it's not supposed to. |
| 10:38 |
csharp |
oh - I'll look there - thanks for the pointer |
| 10:42 |
csharp |
my $fix_tcn = $self->api_name =~ /replace/o; - I guess this sets $fix_tcn to "true" |
| 10:44 |
JBoyer |
Yup. |
| 10:44 |
csharp |
yeah, and the _find_tcn_info sub grabs whatever's in the 001 and makes it the TCN - that seems to be the problem |
| 10:44 |
csharp |
that needs to be checking the global flag |
| 10:45 |
JBoyer |
I'm surprised this wasn't a bigger deal in the xul client, I didn't think that api had changed in ages. |
| 10:45 |
csharp |
I only know that it wasn't because PINES would've exploded and burned down by now if it was :-) |
| 10:54 |
gmcharlt |
csharp: I've responded in the bug as well |
| 10:54 |
gmcharlt |
upshot: open-ils.cat.biblio.record.xml.update appears to be what's needed |
| 10:55 |
gmcharlt |
also, this affects both the AngularJS and Angular sides |
| 10:57 |
* berick |
follows conversation |
| 10:58 |
csharp |
gmcharlt++ |
| 11:04 |
csharp |
gmcharlt: I can confirm that changing that call to xml.update works |
| 11:53 |
|
mmorgan joined #evergreen |
| 11:57 |
|
jihpringle joined #evergreen |
| 11:57 |
csharp |
gmcharlt: I added a branch to bug 1859191 for review - not sure about how to test Angular cataloging |
| 11:57 |
pinesol |
Launchpad bug 1859191 in Evergreen "Editing and saving MARC record changes the TCN value" [High,Confirmed] https://launchpad.net/bugs/1859191 |
| 12:10 |
|
rfrasur joined #evergreen |
| 12:12 |
|
yboston joined #evergreen |
| 12:19 |
|
aabbee left #evergreen |
| 12:21 |
|
mantis1 left #evergreen |
| 13:00 |
|
collum joined #evergreen |
| 13:09 |
|
jvwoolf joined #evergreen |
| 13:36 |
|
mantis1 joined #evergreen |
| 13:56 |
|
mantis1 left #evergreen |
| 14:30 |
|
stephengwills joined #evergreen |
| 14:49 |
|
_bott_ joined #evergreen |
| 16:34 |
|
dbwells joined #evergreen |
| 16:46 |
|
jvwoolf left #evergreen |
| 17:04 |
|
mmorgan left #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:14 |
|
dbwells_ joined #evergreen |
| 18:37 |
|
_bott_ joined #evergreen |
| 21:18 |
|
sandbergja joined #evergreen |
| 22:06 |
|
sandbergja joined #evergreen |
| 22:11 |
|
_bott_ joined #evergreen |
| 23:20 |
|
sandbergja joined #evergreen |
| 23:37 |
|
sandbergja joined #evergreen |
