| Time |
Nick |
Message |
| 00:09 |
|
sandbergja joined #evergreen |
| 07:12 |
|
rjackson_isl joined #evergreen |
| 07:27 |
|
collum joined #evergreen |
| 08:27 |
|
jvwoolf joined #evergreen |
| 08:36 |
|
Dyrcona joined #evergreen |
| 08:42 |
|
mmorgan joined #evergreen |
| 09:07 |
|
alynn26 joined #evergreen |
| 09:18 |
|
yboston joined #evergreen |
| 09:58 |
|
tlittle joined #evergreen |
| 10:05 |
|
mmorgan1 joined #evergreen |
| 10:24 |
|
alynn26_away joined #evergreen |
| 10:25 |
|
AFloyd__ joined #evergreen |
| 10:39 |
|
jvwoolf joined #evergreen |
| 10:49 |
berick |
@band add The Primal Nuggets |
| 10:49 |
pinesol |
berick: Band 'The Primal Nuggets' added to list |
| 10:49 |
berick |
from a bag of dog treats |
| 10:49 |
Dyrcona |
heh. |
| 10:49 |
AFloyd__ |
lol |
| 10:50 |
Dyrcona |
I thought of something that would make a decent band name this morning, but now I've forgotten it. |
| 11:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 11:04 |
rjackson_isl |
Prevagen... One of these days I will have to remember to buy |
| 11:05 |
|
rfrasur joined #evergreen |
| 11:06 |
Dyrcona |
rjackson_isl: :) |
| 11:18 |
|
sandbergja joined #evergreen |
| 11:25 |
|
mmorgan joined #evergreen |
| 11:45 |
|
dbriem joined #evergreen |
| 11:53 |
dbriem |
don't want to bother anyone, but thought i'd reach out here. i altered an opac tt2 file https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=332588c6c8ef7e19d45ad8036d23303272db5c74 |
| 11:53 |
pinesol |
dbriem: [evergreen|Dan Briem] LP#1778606 Web Client - Place Hold Requires Two Clicks on Submit - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=332588c> |
| 11:53 |
dbriem |
i realize now it might be cached, might be causing https://bugs.launchpad.net/evergreen/+bug/1851681 |
| 11:53 |
dbriem |
did i mess up by submitting a pr that alters an opac tt2? anything i should do to remediate this now? |
| 11:53 |
pinesol |
Launchpad bug 1851681 in Evergreen "When placing hold on an item, searching/selecting patron does not always enable the submit button" [Undecided,New] |
| 11:59 |
|
sandbergja joined #evergreen |
| 12:01 |
berick |
dbriem: it's perfectly fine to modify opac tt2 files in code pull requests. |
| 12:01 |
berick |
if you think additional changes are needed to resolve a related issue, please note that in the LP or open a new LP. |
| 12:03 |
|
jihpringle joined #evergreen |
| 12:05 |
|
yboston joined #evergreen |
| 12:14 |
dbriem |
berick: thank you, i'll do that |
| 12:30 |
|
collum joined #evergreen |
| 12:31 |
|
sandbergja joined #evergreen |
| 12:31 |
|
collum_ joined #evergreen |
| 12:33 |
|
collum__ joined #evergreen |
| 12:34 |
|
collum___ joined #evergreen |
| 12:35 |
|
collum joined #evergreen |
| 12:37 |
|
collu____ joined #evergreen |
| 12:38 |
|
collum_ joined #evergreen |
| 12:39 |
|
collum__ joined #evergreen |
| 12:56 |
|
collum joined #evergreen |
| 13:09 |
|
jvwoolf joined #evergreen |
| 13:30 |
|
jvwoolf left #evergreen |
| 13:56 |
* csharp |
considers adding a trigger to asset.call_number to mitigate bug 1849334 |
| 13:56 |
pinesol |
Launchpad bug 1849334 in Evergreen "Precat owning library should not be editable" [Undecided,Confirmed] https://launchpad.net/bugs/1849334 |
| 13:56 |
csharp |
super annoying |
| 14:11 |
csharp |
looking at Cat.pm - wondering if it's appropriate to add a check of whether the vol ID is -1, and if so, exit the function without changing anything |
| 14:11 |
csharp |
within the fleshed_volume_update sub |
| 14:12 |
csharp |
or if there's a better way to do it |
| 14:14 |
Dyrcona |
csharp: That's certainly one way, but I'm not sure what effect that would have on the client. It might return an error. I'd have to look at the code. You could always try it in a test environment to see what happens. |
| 14:15 |
Dyrcona |
A database trigger might have a similar effect depending on what it does. It could not do the update, but have it appear to be successful. |
| 14:18 |
csharp |
yeah, my first thought was a trigger, but then I wanted to look upstream to see why it ignores what apparently the XUL client took into account, and since I'm more confortable in perl than in Angular/JS I got caught there :-) |
| 14:18 |
Dyrcona |
It looks like the check was in the XUL client based on the bug description. It should probably be moved to the back end code, though. |
| 14:18 |
csharp |
agreed |
| 14:18 |
|
rfrasur joined #evergreen |
| 14:18 |
JBoyer |
Yeah, we don't want to have the UI making decisions based on db ids. |
| 14:19 |
|
yboston joined #evergreen |
| 14:19 |
Dyrcona |
I'm not fond of magical values, personally. I'd prefer some kind of flag on he object to say, "you can't touch this..." :) |
| 14:20 |
csharp |
I was just thinking the same thing |
| 14:20 |
JBoyer |
UPDATE asset.copy SET hammer_time = TRUE; |
| 14:20 |
Dyrcona |
I think a check for id < 0 would be reasonable, given what we've got not now. |
| 14:20 |
csharp |
JBoyer++ |
| 14:20 |
Dyrcona |
:) |
| 14:20 |
|
alynn26 joined #evergreen |
| 14:21 |
Dyrcona |
JBoyer++ |
| 14:21 |
Dyrcona |
Or maybe revese the logic and only allow the actual update code to run if id > -1? |
| 14:22 |
csharp |
so in an if block within a for loop, does "return" exit the whole loop? or just the if block? |
| 14:22 |
csharp |
ah - that would probably be better |
| 14:22 |
Dyrcona |
Yeah, definitely better to just wrap the update with if (id > -1) { ... } |
| 14:23 |
Dyrcona |
Or,maybe 0. Not sure I've seen an id 0, but I have seen negative ids lower than -1. |
| 14:24 |
Dyrcona |
It is id -1, right? |
| 14:24 |
* Dyrcona |
looks. |
| 14:24 |
JBoyer |
Yeah, -1 is the precat acn |
| 14:24 |
JBoyer |
and bre |
| 14:25 |
JBoyer |
I like the check of id > 0 though, because unless you make a special effort (i.e. another magic number) you'll never see id 0 either. |
| 14:25 |
Dyrcona |
Yeah. Agreed. |
| 14:26 |
Dyrcona |
This should also prevent the call number from being deleted. I've heard of that happening. |
| 14:27 |
Dyrcona |
And I'm using PgAdmin4 now instead of PgAdmin3. PgAdmin4 doesn't crash when it loses the database connection. It just sits there trying to run a query forever. |
| 14:28 |
Dyrcona |
Related, because I tried looking up the call number with a disconnected pgadmin4. It also doesn't know it lost the connection. |
| 14:29 |
Dyrcona |
More funky behavior after manually disconnecting. I may just go back to using psql all the time. |
| 14:30 |
jeff |
"They don't know they're dead." |
| 14:31 |
Dyrcona |
:) |
| 14:33 |
jeff |
oh. we have bre.id values of -3 and -2 in addition to -1 but they're not "some new thing like pre-cats", they're... possibly weird artifacts of a batch ebib load. |
| 14:33 |
Dyrcona |
Re negative ids: I find just -1 in asset.call_number I find bre.id all the way down to -383 in our database. |
| 14:33 |
csharp |
I went with id > 0 fwiw: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1849334_protect_precat_volume |
| 14:33 |
JBoyer |
csharp++ |
| 14:34 |
|
mmorgan1 joined #evergreen |
| 14:34 |
|
alynn26 joined #evergreen |
| 14:35 |
Dyrcona |
Fun to read that diff.... :) |
| 14:35 |
Dyrcona |
csharp++ |
| 14:37 |
csharp |
yeah - it looks like I changed more than I did - just trying to preserve indents was a little challenging :-) |
| 14:39 |
Dyrcona |
Is the id relevant when making a new call number? Is the id known in that case? |
| 14:43 |
csharp |
it doesn't appear so |
| 14:43 |
csharp |
looking at the create_volume and find_or_create_volume subs in AssetCommon.pm |
| 14:44 |
csharp |
in find_or_create, it looks up the call number, then cares about the ID after the volume is found |
| 14:47 |
csharp |
@band add Experienced Catalogers |
| 14:47 |
pinesol |
csharp: Band 'Experienced Catalogers' added to list |
| 14:47 |
csharp |
@band add Cataloging Experience |
| 14:47 |
pinesol |
csharp: Band 'Cataloging Experience' added to list |
| 14:49 |
Dyrcona |
So, your change may prevent the creation of new call numbers/volumes. |
| 14:49 |
csharp |
I'm about to find out |
| 14:51 |
Dyrcona |
It probably needs to be two separate if blocks, one with the vol->ischanged and one with vol->isdeleted. |
| 14:52 |
Dyrcona |
Or just an && vol->id > 0 on those if conditions, and I could be wrong. |
| 14:52 |
Dyrcona |
I think it will error when you try to make a new call number, though. |
| 15:03 |
Dyrcona |
@band add The Mundanes |
| 15:03 |
pinesol |
Dyrcona: Band 'The Mundanes' added to list |
| 15:03 |
Dyrcona |
Heh. That was an actual band. Figures. |
| 15:04 |
Dyrcona |
@band remove The Mundanes |
| 15:04 |
pinesol |
Dyrcona: Band 'The Mundanes' removed from list |
| 15:05 |
berick |
yeah, i can imagine |
| 15:07 |
csharp |
@band remove Experienced Catalogers |
| 15:07 |
pinesol |
csharp: Band 'Experienced Catalogers' removed from list |
| 15:07 |
csharp |
Cataloging Experience is a much better name |
| 15:08 |
Dyrcona |
yeah... like The Jimi Hendrix Experience. :) |
| 15:08 |
berick |
@who sang "MARC On a Lark" for Cataloging Experience? |
| 15:08 |
pinesol |
bwicksall sang MARC On a Lark for Cataloging Experience. |
| 15:08 |
csharp |
okay, so my patch passes a basic smoke test on a stock master server with concerto data |
| 15:09 |
Dyrcona |
And, I think I musta heard of The Mundanes before because John Linnell from They Might Be Giants was in the band. |
| 15:09 |
Dyrcona |
Yeah? You were able to create a new call number without it blowing up? |
| 15:12 |
csharp |
hmm - maybe not |
| 15:15 |
csharp |
Dyrcona: I think you were right - since $vol->id isn't necessarily there yet, it's not running anything after the block - I'll try the approach you suggested |
| 15:15 |
Dyrcona |
Ok. |
| 15:17 |
|
mmorgan joined #evergreen |
| 15:28 |
|
mmorgan left #evergreen |
| 15:29 |
csharp |
woohoo - that works |
| 15:30 |
csharp |
I'm able to create new volumes and the -1 volume wasn't affected by a batch update |
| 15:30 |
csharp |
I'll post the branch on the bug for review |
| 15:30 |
Dyrcona |
csharp++ |
| 15:37 |
|
abowling joined #evergreen |
| 15:42 |
|
yboston joined #evergreen |
| 15:48 |
|
jvwoolf joined #evergreen |
| 16:02 |
|
yboston joined #evergreen |
| 17:50 |
|
jihpringle joined #evergreen |
| 18:07 |
|
dbwells_ joined #evergreen |
| 18:11 |
gmcharlt |
a pull request is now available for that Hoopla SIP2 issue: bug 1853363 |
| 18:11 |
pinesol |
Launchpad bug 1853363 in Evergreen "SIP2: add setting to specify overriding certain flag fields" [Wishlist,New] https://launchpad.net/bugs/1853363 |
| 19:10 |
|
jihpringle joined #evergreen |
| 20:56 |
|
sandbergja joined #evergreen |
| 21:44 |
|
sandbergja joined #evergreen |
| 23:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
