Evergreen ILS Website

IRC log for #evergreen, 2019-11-20

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
06:53 agoben joined #evergreen
06:57 rfrasur joined #evergreen
07:03 tlittle joined #evergreen
07:06 rjackson_isl joined #evergreen
08:52 Dyrcona joined #evergreen
08:55 mmorgan joined #evergreen
08:59 alynn26 joined #evergreen
09:05 yboston joined #evergreen
09:06 rfrasur joined #evergreen
09:33 alynn26 joined #evergreen
09:35 alynn26_away joined #evergreen
09:38 jvwoolf joined #evergreen
09:57 sandbergja joined #evergreen
10:41 dbs joined #evergreen
10:45 collum joined #evergreen
10:47 Bmagic any ideas on how to fix this?
10:47 Bmagic [ERR :36222:Publisher.pm:406:] ARG! Couldn't load action class Publisher: Global symbol "%restrictions" requires explicit package name (did you forget to declare "my %restrictions"?) at /usr/local/share/perl/5.22.1/OpenILS/A​pplication/Storage/Publisher/action.pm line 2395.
10:48 sandbergja joined #evergreen
10:50 JBoyer Bmagic, sounds like a compilation error, missing a ; anywhere nearby?
10:50 Bmagic Ill look again
10:51 Bmagic pretty sure it's stock
10:56 Bmagic oh - nope
10:56 Bmagic https://git.evergreen-ils.org/?p=working/Everg​reen.git;a=blobdiff;f=Open-ILS/src/perlmods/li​b/OpenILS/Application/Storage/Publisher/action​.pm;h=67b6782854e8392a4b1e22ab1ba25f3dd268a233​;hp=213ed59e5a37fcf374555617def51600e8941471;h​b=8c3e76cb5a45dab8843015d977bb39c5ae31420c;hpb​=65ee0cb4c23f9f1277bd37ef7d52e186e1b6a303
10:56 pinesol Bmagic: [evergreen|Jason Boyer] LP1825403: Do not Include Tag Owner in Tag - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=65ee0cb>
10:56 Bmagic that commit (I believe) is causing the issue
11:01 pinesol News from qatests: Failed Installing AngularJS web client - Expected 6 errors but encountered 4. <http://testing.evergreen-ils.org/~li​ve/test.28.html#2019-11-20T11:00:52,231218480-0500 -0>
11:01 pinesol News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~li​ve/test.29.html#2019-11-20T11:00:52,280176385-0500 -2>
11:05 JBoyer It's possible. I'm a little weak on my perl type conversions so I'm not 100% certain what's being attempted there and where it's falling down.
11:17 Bmagic removing that patch and rebuilding now
11:18 Bmagic getting an error from "cellPrintValues" being present in various eg2 files. using npm version 6.12.1
11:21 Christineb joined #evergreen
11:25 Bmagic probably related to angular
11:26 berick cellPrintValues is from a not-yet-merged feature branch
11:26 Bmagic yep, I'm staging it
11:26 berick gotcha
11:26 berick i had to rebase it yesterday
11:26 berick to current master
11:27 berick the pre-rebased version still exists though
11:27 Bmagic for the New Developer's group today
11:27 Bmagic I was posting about the rebase issue on Monday, got crickets
11:28 Bmagic I took a stab at it and posted my "rebased" branch - I don't think I did it right
11:28 berick mine's at the bottom of https://bugs.launchpad.net/evergreen/+bug/1835982
11:28 Bmagic how do I fix this "Your global Angular CLI version (8.3.19) is greater than your local version (8.3.12). The local Angular CLI version is used."
11:28 pinesol Launchpad bug 1835982 in Evergreen "Angular: grid cells that use a cellTemplate aren't included in CSV or Print" [Medium,Confirmed]
11:28 berick Bmagic: you can ignore that warning
11:29 berick as long as the major version numbers are the same
11:29 Bmagic oh good.... I thought that was the issue
11:29 berick or you can update both versions of the CLI
11:29 Bmagic still having the " Property 'cellPrintValues' does not exist on type 'QueueComponent'." problem
11:30 berick Bmagic: using this branch?  user/berick/lp1835982-grid-csv-template-fields-3
11:30 Bmagic no, probably the previous revision - giving your new one a shot now
11:35 Bmagic berick: btw - I manually fixed the merge confilcts during git processes on the previous branch
11:36 Bmagic ok - getting back up to the ng build --prod step with the new branch merged on master...... no dice
11:37 * berick tries
11:38 miker Bmagic/JBoyer: looks like this line (2395 after the patch): "for my $rkey (keys %$restrictions{$r}) {" should instead be: "for my $rkey (keys %{$$restrictions{$r}}) {"
11:39 * berick reminds that prod builds would be faster if we could merge bug 1850955
11:39 pinesol Launchpad bug 1850955 in Evergreen "Angular build could be quicker and leaner (circa Angular8)" [Undecided,New] https://launchpad.net/bugs/1850955
11:39 berick Bmagic: confirmed.  I'll fix...
11:39 berick i clearly forgot to do a prod build :(
11:39 Bmagic :)
11:54 berick Bmagic: sorry, almost there, trying to test but running into other issue (so fun!)
11:59 berick Bmagic: follow up patch pushed to user/berick/lp1835982-grid-csv-template-fields-3
12:19 yboston joined #evergreen
12:20 jihpringle joined #evergreen
12:27 sandbergja joined #evergreen
12:41 khuckins joined #evergreen
12:52 collum joined #evergreen
13:40 gerlevi joined #evergreen
14:10 dbs anyone else see the dependabot warnings from github about our angular version?
14:15 jeff this, i assume? https://github.com/evergreen-li​brary-system/Evergreen/pull/92
14:17 dbs That would be the one
14:32 sandbergja Here's a weird issue: one of our librarians gets a ERR_INCOMPLETE_CHUNKED_ENCODING error in the console every time she tries to go into reports
14:32 sandbergja No matter which login she uses
14:32 sandbergja And on three different machines
14:32 sandbergja It doesn't happen on my machine, no matter which login I use
14:39 jeff sandbergja: do any accounts work on the affected machines?
14:39 jeff sandbergja: does her account work on your machine?
14:42 gmcharlt for any users of Hoopla, please note the bug I have just filed: https://bugs.launchpad.net/evergreen/+bug/1853363
14:42 pinesol Launchpad bug 1853363 in Evergreen "SIP2: add setting to specify overriding certain flag fields" [Wishlist,New]
14:42 gmcharlt I'm planning on submitting a patch by tomorrow
14:43 gmcharlt it definitely falls into the category of a "emergency workaround is workaroundish", so I would appreciate feedback
14:51 sandbergja jeff: no accounts work on the affected machines (at least two of the affected machines).  Her account does work on my machine.
14:52 sandbergja jeff: and the styles are weirdly messed up on my machine, even after clearing caches
14:52 Dyrcona gmcharlt: Really.... I looked at the thing from Hoopla and thought nothing would be required, and I didn't know that we do send card lost..... I mean, all of those sound like cases where you don't want the patron to use a service that costs the library money.
14:53 JBoyer Dyrcona, except for the case where they just happen to have the max number of items out; that penalty will block them from Hoopla (and some PC management systems).
14:54 JBoyer The lost card and barred ones are more definite though.
14:54 Dyrcona Well, all right... I'll grant some of the standing penalties, but generally, if you can't check out, you shouldn't be allowed to use an online service.
14:56 Dyrcona But, what do I know? I'm just the code jockey. ;)
14:56 gmcharlt Dyrcona: a reasonable argument.. and one that I wish had been embodied as additional configuration items in the Hoopla admin interface to let the library specify whether they wanted those flags taken into account or not
14:56 csharp I think PINES libraries will be ok with the defaults after the change
14:56 Dyrcona Lots of things in SIP feel like work arounds, so I'm sure this patch will fit right in. :)
14:57 Dyrcona gmcharlt: I'll take a look, though I might wait to see if anyone complains. :)
14:57 * Dyrcona is too busy cleaning up a parts mess today, and wonders if that query every finished running....
14:58 Dyrcona There doesn't seem to be a "fast" way to find all unfulfilled, not canceled, part holds....
14:59 jeff gmcharlt, Dyrcona: Where is the notice from the vendor regarding this?
15:00 yboston joined #evergreen
15:00 Dyrcona jeff: I don't know. Someone else here asked me about it via a forwarded email.
15:00 gmcharlt jeff: http://go.midwesttape.com/support/SIP2/
15:00 gmcharlt specifically, the SIP Methods PDF
15:00 jeff sandbergja: are the affected machines different in network firewall/proxy or local antivirus / endpoint protection software? that has been a common cause in the past with that kind of error.
15:00 jeff sandbergja: also worth checking (though this usually causes other problems first): sufficient free disk on the client?
15:01 sandbergja jeff: one is on a wireless network, but the other two are on the exact same network.
15:01 sandbergja I will check on the antivirus software
15:01 sandbergja One of the affected machines is a mac
15:02 jeff sandbergja: (free disk on the server likely doesn't need to be checked if the issue seems to be specific to particular clients, but you might want to double check anyway...)
15:02 sandbergja And I'll double check on the free disk
15:02 sandbergja Can't hurt to check!
15:02 jeff sandbergja: the other two affected machines are on the exact same network as your machine?
15:02 Dyrcona @blame Apple
15:02 pinesol Dyrcona: Forget it, Jake. It's just Apple.
15:02 sandbergja jeff: yup
15:03 jeff gmcharlt++ thanks for the link!
15:03 khuckins joined #evergreen
15:03 Dyrcona Well, Mercury is not in retrograde, so it can't be that.... :)
15:04 sandbergja Dyrcona: hahahaha
15:04 jeff ugh. their PIN-related questions bring back memories of their "we don't store pins! oh, wait... we do store pins!"
15:05 Dyrcona PINs.... What is this? The nineties?
15:06 * Dyrcona waits on the never-ending query... Looks around for a dragon.
15:07 Dyrcona SIP2 really needs to go away.
15:07 jeff after skimming that pdf i am finding myself:
15:07 jeff 1. annoyed
15:08 jeff 2. looking up the correct spelling of the word hand-wavy
15:08 jeff 3. happy to not be using SIP2 with Hoopla
15:09 jeff at least part of this document seems to imply that SIP 2.0 is a new thing, recently released.
15:09 gmcharlt jeff: out of curiosity, how are you doing auth for Hoopla?
15:09 jeff Patron API shim
15:09 gmcharlt gotcha
15:10 gmcharlt any library policy issues for blocking a patron presumably have been sorted out long ago?
15:10 jeff a very verbose true/false response to a card number submitted by hoopla over https
15:11 jeff and rather than sending them a bunch of data about the patron and then seeing if they can approve/reject the patron based on our requirements, we just do that on our end.
15:12 gmcharlt why jeff, that sounds like the sensible thing to do
15:12 jeff double benefit there being that we can have more esoteric rules not supported by the vendor, and we don't send patron data to the vendor.
15:12 gmcharlt we can't have that!
15:12 * Dyrcona starts looking around an age holds process.....
15:12 csharp @blame jeff for being reasonable
15:12 pinesol csharp: jeff is why we can never have nice things! for being reasonable
15:12 Dyrcona @praise jeff
15:12 * pinesol jeff can count to 1 billion
15:12 csharp pinesol++
15:13 jihpringle joined #evergreen
15:16 Dyrcona Well, there is a process to purge old holds, but naturally, we've not configured it.
15:17 csharp Dyrcona: definitely something you'll want to batch at first
15:17 Dyrcona Yeah.
15:17 Dyrcona Does anyone else have fields "history.hold.retention_age_canceled_[1-6]" in config.global_flag?
15:20 Dyrcona Oh, I guess they're standard fields, but I don't see any code that uses them.
15:20 Dyrcona That never-ending query finally ended: Connection to the server has been lost.
15:20 Dyrcona :(
15:21 Dyrcona And, then, just tell it run again and get results in 1.85 seconds.
15:22 * mmorgan was wondering why Dyrcona's part hold query was taking so long
15:57 jeff Dyrcona: the function action.purge_holds uses those flags.
15:57 jeff LEFT JOIN config.global_flag cgf_cs ON (ahr.cancel_cause IS NOT NULL AND cgf_cs.name = 'history.hold.retention_age_canceled_' || ahr.cancel_cause AND cgf_cs.enabled) ...
15:57 Dyrcona It does? I musta missed it, or the one in my database is out of date. I'll admit to not looking that closely.
16:01 Dyrcona Ah, yeah. I missed it because of the ||...
16:01 Dyrcona jeff++
16:07 nfBurton joined #evergreen
16:18 sandbergja_ joined #evergreen
16:28 jeff time to tidy up:
16:28 jeff 5:7:7 # iterm2 5 windows, 7 tabs, 7 sessions
16:28 jeff 22:90 # chrome 22 windows, 90 tabs
16:28 jeff that... iterm count is off.
16:31 berick jeff: those chome windows no longer sparking joy?
16:32 Dyrcona heh
16:43 * mmorgan hears jeff's computer breathe a sigh of relief
16:56 jeff 39:56:56 # iterm2 39 windows, 56 tabs, 56 sessions
16:56 jeff 22:93 # chrome 22 windows, 93 tabs
16:57 jeff (chrome tab count went up as I refreshed some AppleScript knowledge to fix the iTerm2 under-counting)
16:57 mmorgan jeff has an odd interpretation of tidying up!
17:03 yboston joined #evergreen
17:06 mmorgan left #evergreen
17:07 egbuilder joined #evergreen
17:31 jeff 30:47:47 # iterm2 30 windows, 47 tabs, 47 sessions
17:31 jeff 1:1 # chrome 1 windows, 1 tabs
17:39 jeffdavis \o/
18:45 jihpringle joined #evergreen
18:53 jeffdavis It is truly amazing what utter garbage modern JS build processes are.
19:02 jeffdavis currently running into this one, I think: https://github.com/nodejs/node/issues/29364
19:07 jeffdavis I think that bug is fixed in make-fetch-happen 5.0.2 but eg2's package-lock.json appears to specify 5.0.0
19:07 * jeffdavis grudgingly admits that package name is pretty good though
19:27 * jeffdavis rebases dev branch to EG3.3 in order to proceed with testing
21:05 sandbergja joined #evergreen
23:01 pinesol News from qatests: Failed Installing AngularJS web client - Expected 6 errors but encountered 7. <http://testing.evergreen-ils.org/~li​ve/test.28.html#2019-11-20T23:00:51,585731165-0500 -0>
23:01 pinesol News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~li​ve/test.29.html#2019-11-20T23:00:51,628837591-0500 -2>
23:38 sandbergja joined #evergreen

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat