| Time |
Nick |
Message |
| 07:06 |
|
rjackson_isl joined #evergreen |
| 07:35 |
|
EVGHack-A-Way joined #evergreen |
| 07:42 |
|
agoben joined #evergreen |
| 08:12 |
|
Dyrcona joined #evergreen |
| 08:31 |
|
bos20k joined #evergreen |
| 08:32 |
pinesol |
News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~live/test.29.html#2019-10-23T08:04:48,553808689-0400 -0> |
| 08:32 |
pinesol |
News from qatests: Failed Log Output: osrfsys.log <http://testing.evergreen-ils.org/~live/test.76.html#2019-10-23T08:04:48,597859892-0400 -2> |
| 08:54 |
|
mmorgan joined #evergreen |
| 09:00 |
|
tlittle joined #evergreen |
| 09:08 |
|
jvwoolf joined #evergreen |
| 09:10 |
pinesol |
[evergreen|Bill Erickson] LP1849372 Close all open dialogs on Angular route change - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2309b60> |
| 09:15 |
|
terranm joined #evergreen |
| 09:24 |
|
cmalm joined #evergreen |
| 09:24 |
JBoyer |
Dyrcona, dbs, depending on what kind of issues you were having yesterday you might have to remove all of /usr/local/lib/node_modules and start fresh. (IF you were trying to work with a post-Angular 8 branch) |
| 09:25 |
* Dyrcona |
had no issues yesterday, but that's good to know. I plan to try the upgrade steps this week. |
| 09:25 |
JBoyer |
And I've got a branch out there to ditch PhantomJS and test our Angular(JS) code with both of our supported browsers rather than just an old version of one of them. Just can't reasonably do it as part of a production install like we used to. |
| 09:41 |
|
stephengwills joined #evergreen |
| 09:42 |
pinesol |
[evergreen|Terran McCanna] LP#1806783 Offline: Non-cataloged item receipt printing - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0581bbf> |
| 09:50 |
|
yboston joined #evergreen |
| 10:03 |
|
jvwoolf joined #evergreen |
| 10:03 |
|
bos20k joined #evergreen |
| 10:05 |
berick |
tlittle: item.hold.requestor().id() != item.hold.usr().id() |
| 10:08 |
jeff |
Is the recording from yesterday's elusive "Patch / Bug Activity" discussion available? If not, is someone up for summarizing? |
| 10:20 |
|
collum joined #evergreen |
| 10:21 |
EVGHack-A-Way |
Anna is afk right now, so that answer is idk. But, it will be available at some point soon. (helpful, huh?) - Ruth |
| 10:23 |
dluch |
jeff: it's not a recording, but they did post gmcharlt's slideshow on the agenda page https://wiki.evergreen-ils.org/doku.php?id=hack-a-way:hack-a-way-2019-agenda |
| 10:24 |
dluch |
(I wasn't there either, so that's all I know) |
| 10:25 |
jeff |
dluch: thanks! gmcharlt had linked the slides above also. |
| 10:26 |
jeff |
0 results for repositories matching cal |
| 10:26 |
jeff |
1 result for repositories matching gcal |
| 10:27 |
* jeff |
shakes fist at github repository search |
| 10:32 |
Dyrcona |
Yeah, I still don't know what leap we're taking, but I suspect it's about switching to gitlab or something based on all the git statistics, but I really have no idea. |
| 10:32 |
Dyrcona |
I feel cheated that the thing was moved to 11:00 and no one explicitly said so in the channel. |
| 10:33 |
jeff |
i had a similar guess but s/gitlab/github/ |
| 10:33 |
jeff |
but yeah, i was disappointed to have missed the conversation. |
| 10:36 |
tlittle |
Dyrcona The end result was fairly summed up in the last "Challenges" slide |
| 10:36 |
tlittle |
(If that's helpful) |
| 10:37 |
Dyrcona |
Not really. It just says that we need to do some thing related to code review, but still doesn't say what the leap is. |
| 10:38 |
pinesol |
[evergreen|Jason Stephenson] Lp 1835620: Require some Storage submodules instead of use them - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ca6a08d> |
| 10:38 |
Dyrcona |
I work with code for a living. I can't go on assumptions or wild guesses because they're usually wrong and lead to down time. I want someone to explicitly state if that talk was about moving away from Lp and/or gitolite, what the conclusion was, and if yes, then when. |
| 10:39 |
tlittle |
It was not about that. |
| 10:39 |
Dyrcona |
Well, then, I'm getting excited over nothing. :) |
| 10:39 |
* jeff |
will wait for the recording and/or a summary |
| 10:41 |
gmcharlt |
the general "leap" is figuring out how to improve patch review coverage and committer workflow balancing, with the idea of setting ourselves up for less dependence on Price's Law distributions of folks doing the work |
| 10:42 |
gmcharlt |
but it wasn't specifically about things such as "adopting tool X" or "adopting practice Y" |
| 10:42 |
gmcharlt |
also, the presentation was a bit off the cuff :) |
| 10:42 |
jeff |
got it. :-) |
| 10:42 |
jeff |
"this is unsustainable. let's get better. ideas welcome. effort needed." |
| 10:42 |
gmcharlt |
however, I will be writing up something to expand on the presentation - definitely won't require that folks have been here |
| 10:44 |
csharp |
there were cats involved too |
| 10:44 |
gmcharlt |
I was allowed access to a slide deck generator == there were cats on it |
| 10:44 |
gmcharlt |
;) |
| 10:44 |
mmorgan |
What a surpise ;-) |
| 10:46 |
dbs |
I'll open a bug for https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/docs_remove_node_source so we can (maybe) add it ot the hack-a-way list of bugs fixed |
| 10:51 |
dbs |
Stompro: in my case I was testing against 3.4.0, so pre-Angular8 (and the problem with tests was only with the AngularJS portion) |
| 10:54 |
Stompro |
? dbs - I think you tagged me by accident. |
| 10:55 |
dbs |
Stompro: oh damnit, I meant JBoyer -- sorry! |
| 10:55 |
agoben |
jeff: I'll be converting all the videos and shipping them tomorrow. |
| 10:59 |
dbs |
and bug 1849506 is open |
| 10:59 |
pinesol |
Launchpad bug 1849506 in Evergreen "Remove manual node.js installation instructions" [Undecided,New] https://launchpad.net/bugs/1849506 |
| 10:59 |
JBoyer |
dbs++ |
| 10:59 |
|
jwoodard joined #evergreen |
| 11:00 |
* dbs |
did do a fair bit of 'rm -fr /usr/local/lib/node_modules' and 'npm cache clear --force' last night to try to ensure a clean env |
| 11:03 |
* dbs |
also gets confused by LP series & milestone targeting, again - heh |
| 11:04 |
jeff |
gmcharlt: the precipitous-sounding final slide combined with what initially looked like a cat with a knife made for... a slightly more dramatic conclusion than perhaps you intended. :-) |
| 11:04 |
jeff |
agoben++ thanks! |
| 11:05 |
berick |
hey! |
| 11:06 |
Dyrcona |
agoben++ |
| 11:06 |
dluch |
Lol. I liked all the cats. |
| 11:06 |
dluch |
agoben++ |
| 11:08 |
dluch |
I think this co-release manager/mentor idea is a good one. Makes it easier for new folks to have a path in to that sort of thing. |
| 11:10 |
dluch |
Which gets to the point of what I was assuming gmcharlt's presentation yesterday was about, increasing involvement |
| 11:11 |
JBoyer |
We definitely need to remove the "install the latest..." from that doc, but removing the tests (or rather, making them optional at install time) has been changed here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1845693-chrome-ang-testing |
| 11:11 |
|
jihpringle joined #evergreen |
| 11:11 |
JBoyer |
I'm certainly open for alternative ways to word / deal with that though. |
| 11:23 |
pinesol |
News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~live/test.29.html#2019-10-23T11:00:51,858757731-0400 -0> |
| 11:23 |
pinesol |
News from qatests: Failed Log Output: osrfsys.log <http://testing.evergreen-ils.org/~live/test.76.html#2019-10-23T11:00:51,900121137-0400 -2> |
| 11:27 |
dbs |
JBoyer: looks good enough - could just apply the first commit in my branch to remove the "install the latest" verbiage |
| 11:28 |
dbs |
also, JBoyer++ # nice branch |
| 11:32 |
|
sandbergja joined #evergreen |
| 11:35 |
|
jihpringle joined #evergreen |
| 11:40 |
gmcharlt |
dbs: JBoyer: I'm about to commit JBoyer's branch and will grab that verbiage-deleting commit from dbs' branch |
| 11:41 |
JBoyer |
gmcharlt++ |
| 11:41 |
JBoyer |
dbs++ |
| 11:56 |
* JBoyer |
claims 1196 for wild christmas themed opac buttons |
| 11:58 |
pinesol |
[evergreen|Jason Boyer] LP1845693: Test Angular(JS) with modern browsers - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=038227c> |
| 11:58 |
pinesol |
[evergreen|Dan Scott] LP#1849506: Remove "Install latest LTS node from source" docs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f88df97> |
| 11:58 |
pinesol |
[evergreen|Galen Charlton] LP#1845693: (follow-up) clarify what CHROME_BIN should be set to - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d6a9ed4> |
| 12:06 |
|
yboston joined #evergreen |
| 12:06 |
pinesol |
[evergreen|Rogan Hamby] loading custom css from library setting - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=485624d> |
| 12:06 |
pinesol |
[evergreen|Jason Boyer] Stamp upgrade script for LP 1849152 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=11868e9> |
| 12:19 |
jeff |
should that be behind a more restrictive update permission by default? |
| 12:20 |
jeff |
would that be a new bug now that the original is committed? |
| 12:37 |
rhamby |
jeff: the css? |
| 12:41 |
jeff |
yeah, bug 1849152 |
| 12:41 |
pinesol |
Launchpad bug 1849152 in Evergreen "Being able to set custom CSS from a Library Setting " [Wishlist,Fix committed] https://launchpad.net/bugs/1849152 - Assigned to Jason Boyer (jboyer) |
| 12:41 |
rhamby |
After some chatting about it yesterday I decided to add a new bug for it. I'll file that with the patch today or tomorrow. |
| 12:42 |
rhamby |
About to board a plane so not right now :) |
| 12:42 |
rhamby |
same for the jquery one |
| 12:43 |
rhamby |
jeff ^ |
| 12:45 |
JBoyer |
jeff++ |
| 12:45 |
JBoyer |
rhamby++ |
| 12:51 |
|
yboston joined #evergreen |
| 12:56 |
|
khuckins joined #evergreen |
| 13:21 |
* jeff |
looks for the jquery one |
| 13:21 |
jeff |
ah, bug 1849113 |
| 13:21 |
pinesol |
Launchpad bug 1849113 in Evergreen "Add the ability to have jQuery from a library setting" [Wishlist,New] https://launchpad.net/bugs/1849113 |
| 13:59 |
|
jihpringle joined #evergreen |
| 14:00 |
|
mmorgan1 joined #evergreen |
| 14:00 |
|
agoben joined #evergreen |
| 14:01 |
|
mmorgan2 joined #evergreen |
| 14:25 |
|
sandbergja joined #evergreen |
| 14:58 |
Dyrcona |
jeffdavis++ |
| 14:59 |
|
yboston joined #evergreen |
| 15:34 |
|
jihpringle joined #evergreen |
| 16:01 |
|
sandbergja_ joined #evergreen |
| 16:11 |
|
jvwoolf joined #evergreen |
| 16:16 |
|
jvwoolf left #evergreen |
| 16:24 |
|
sandbergja_ joined #evergreen |
| 16:48 |
|
jihpringle joined #evergreen |
| 17:07 |
|
mmorgan2 left #evergreen |
| 17:11 |
|
sandbergja_ joined #evergreen |
| 17:19 |
|
yboston joined #evergreen |
| 17:31 |
|
jihpringle joined #evergreen |
| 18:05 |
|
sandbergja_ joined #evergreen |
| 19:13 |
|
cmalm joined #evergreen |
| 20:17 |
|
book` joined #evergreen |
| 21:10 |
|
sandbergja joined #evergreen |
| 21:25 |
|
sandbergja joined #evergreen |
| 23:01 |
pinesol |
News from qatests: Failed Installing AngularJS web client <http://testing.evergreen-ils.org/~live/test.28.html#2019-10-23T23:00:52,490855211-0400 -0> |
| 23:01 |
pinesol |
News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~live/test.29.html#2019-10-23T23:00:52,534139946-0400 -2> |
| 23:01 |
pinesol |
News from qatests: Failed Log Output: osrfsys.log <http://testing.evergreen-ils.org/~live/test.76.html#2019-10-23T23:00:52,578055607-0400 -4> |
| 23:06 |
|
sandbergja joined #evergreen |
| 23:33 |
Bmagic |
The hack-away was awesome!!! Thanks everyone! Landed in MO just now! |
| 23:36 |
devted |
Yes, it was a really fun few days! Thanks everyone |
| 23:47 |
|
sandbergja joined #evergreen |
