Time |
Nick |
Message |
02:58 |
|
kfogel joined #evergreen |
03:00 |
kfogel |
I get the impression from the documentation (and the downloads page) that the Windows-native Evergreen Staff Client application stopped being A Thing (with its own installer) as of the 3.2 release series... Can anyone confirm that? |
03:00 |
kfogel |
(I guess my real question is "Does Evergreen still involve anything built natively for Windows?") |
05:22 |
|
sandbergja joined #evergreen |
07:04 |
|
agoben joined #evergreen |
07:07 |
|
collum joined #evergreen |
07:13 |
|
rjackson_isl joined #evergreen |
07:18 |
bshum |
Oh hmm, I guess I didn't notice that pgTap failure with testing the password |
07:18 |
bshum |
Quick guess is that the ID for the user we're testing moved when we added in the additional test users for the basic api auth testing :) |
07:28 |
bshum |
Yup, id moved from 187 to 195. Same thing happened last time we added new test users to concerto |
07:28 |
bshum |
Might be a good time to rewrite the test to use another identifier to track that test user for validation |
07:28 |
bshum |
Rather than ID |
08:07 |
bshum |
gmcharlt: Pushed a third commit onto https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1817645-perl-test-fixes |
08:08 |
bshum |
It should fix the test for passwd storage too |
08:08 |
bshum |
And hopefully future proof it against further ID changes |
08:09 |
csharp |
bshum++ |
08:09 |
bshum |
csharp: It was a fun little thought exercise :D |
08:10 |
csharp |
I like those kinds of problems too |
08:10 |
bshum |
I needed the practice for pgTap test writing |
08:11 |
bshum |
Probably more ways to skin the cat, but baby steps... |
08:11 |
csharp |
after the second week of October, when an 11-month-long leadership program I've been doing ends, my attention will be less divided and I'll be able to get serious about EG development again :-) |
08:12 |
bshum |
Fun times! :) |
08:12 |
bshum |
Okay, off to the office for more fun and games in other SQL lands... |
08:12 |
bshum |
Have a good week everybody ;) |
08:13 |
|
Dyrcona joined #evergreen |
08:17 |
|
bos20k joined #evergreen |
08:24 |
|
tlittle joined #evergreen |
08:41 |
|
mmorgan joined #evergreen |
09:03 |
|
nfBurton joined #evergreen |
09:09 |
|
sandbergja joined #evergreen |
09:21 |
|
terran joined #evergreen |
09:21 |
Dyrcona |
So, why would the staff client templates not see the circ.auto_renewal field? |
09:21 |
Dyrcona |
I have checked both IDLs and the field is there. |
09:23 |
|
terran left #evergreen |
09:23 |
|
terranm joined #evergreen |
09:34 |
mmorgan |
Dyrcona: By templates, do you mean the print templates? |
09:34 |
Dyrcona |
I have run autogen.sh. I have cleared my browser cache multiple times. I have delete the eg_template_cache on the server, though the changes were picked up there before I deleted the files. I'm not seeing any errors in the console. |
09:34 |
|
jvwoolf joined #evergreen |
09:35 |
Dyrcona |
mmorgan: No, I mean the tt2 files used to generate the Item Status views. The changes are actually in the JavaScript to add a check on circ.auto_renewal() == 't' and the changes are having no effect. |
09:38 |
Dyrcona |
I've also restarted Apache.. |
09:55 |
JBoyer |
Dyrcona, and memcached? Sometimes it holds on to things you'd rather it didn't. |
09:56 |
Dyrcona |
JBoyer: I'll give it a kick... |
09:57 |
Dyrcona |
And, now I can't login.... |
09:59 |
mmorgan |
Dyrcona: Have you tried an incognito browser window? |
09:59 |
Dyrcona |
Not since restarting memcached. |
09:59 |
* Dyrcona |
clears cookies, etc. |
10:00 |
|
mmorgan1 joined #evergreen |
10:00 |
Dyrcona |
Clearing cookies got me in, but no dice. The fields that I expect to have values are still blank. |
10:01 |
Dyrcona |
So, kicking memcached did no good. |
10:04 |
Dyrcona |
Oh, well. Other problems to deal with.... |
10:10 |
Dyrcona |
And the big one turns out to be possibly not a problem.. |
10:15 |
JBoyer |
:-/ |
10:15 |
Dyrcona |
fine generator still running for over an hour. If it's still running at 11:00, I'll stomp on it, too. |
10:22 |
Dyrcona |
So, here's a branch with the changes that I'm talking about not showing up: user/dyrcona/lp1835085-auto_renewal-not-desk_renewal |
10:23 |
Dyrcona |
It's in the working repo, of course. The top commit has the template changes and the previous commit has back end changes. |
10:24 |
Dyrcona |
I have also verified that I am testing with an auto-renewed circulation, i.e. I've verified the field in the database. |
10:24 |
Dyrcona |
If it matters, I've been testing with the commits applied to Evergreen 3.2.8. |
10:25 |
csharp |
@dessert add Browser Cookies |
10:25 |
pinesol |
csharp: The operation succeeded. Dessert #59 added. |
10:26 |
csharp |
@dessert add Syntactic Sugar |
10:26 |
pinesol |
csharp: The operation succeeded. Dessert #60 added. |
10:27 |
Dyrcona |
Is just copying the templates into place the wrong thing to do? I seem to recall having this conversation before and recommending against it. |
10:27 |
csharp |
for tt2 templates, that should Just Work™ |
10:30 |
berick |
Dyrcona: you can view-source on the template to check your work. just gotta invoke the right path. e.g. https://evgdemo.kcls.org/eg/staff/t_splash |
10:30 |
Dyrcona |
berick: I've looked at the installed templates with my editor over ssh and they look good. I'll try view source, too. |
10:31 |
Dyrcona |
For the logs: make install doesn't help, neither does npm update; npm run build-prod, then make install. |
10:33 |
|
sandbergja joined #evergreen |
10:36 |
Dyrcona |
It's there, see line 57: view-source:https://training.cwmars.org/eg/staff/cat/item/t_circ_list_pane |
10:38 |
Dyrcona |
It's also here on line 77: view-source:https://training.cwmars.org/eg/staff/cat/item/t_summary_pane |
10:39 |
Dyrcona |
What I'm seeing in the summary pane is an empty Renewal Type. In the circ history list, Renewal? is false. |
10:40 |
Dyrcona |
desk_renewal is false and auto_renewal is true on this particular circulation. |
10:40 |
Dyrcona |
It's also the most recent circulation. |
11:01 |
pinesol |
News from qatests: Failed Running pgTAP live tests <http://testing.evergreen-ils.org/~live/test.47.html#2019-09-09T11:00:43,578501076-0400 -0> |
11:01 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live/test.49.html#2019-09-09T11:00:43,606230460-0400 -2> |
11:06 |
Dyrcona |
And, killed the fine generator.... |
11:07 |
Dyrcona |
Storage has no running drones....figures.... |
11:08 |
Dyrcona |
I think I'm going to drop the parallel setting for the fine generator. I assume this is that bug that berick suspects but has not pinpointed with OpenSRF::MultiSession. |
11:11 |
Dyrcona |
Well, this time it's different. The Listener is running with 0 drones. Usually, I have drones but no listener. |
11:11 |
Dyrcona |
open-ils.storage... |
11:15 |
Dyrcona |
timed out waiting on open-ils.storage pid=19042 to die |
11:16 |
Dyrcona |
:( |
11:25 |
Dyrcona |
And the trouble just keeps coming: An autorenewal email got ACTION_CIRCULATION_NOT_FOUND for the failure reason. That's not good. |
11:25 |
Dyrcona |
And, "Evergreen is slow" says 1 library. :P |
11:35 |
|
bos20k joined #evergreen |
11:50 |
|
Christineb joined #evergreen |
11:57 |
|
aabbee joined #evergreen |
12:05 |
|
mmorgan joined #evergreen |
12:08 |
|
jihpringle joined #evergreen |
12:29 |
terranm |
Bmagic++ for setting up bug squashing test server! https://docs.google.com/spreadsheets/d/1qYNGrJBt42_ArQzbwlcnKxS3TobDnmquSXZzopOkZh4/edit#gid=0 |
12:29 |
Bmagic |
ty! |
12:34 |
|
collum_ joined #evergreen |
12:36 |
|
bos20k joined #evergreen |
12:41 |
|
khuckins joined #evergreen |
13:10 |
jeffdavis |
csharp: thanks for the response on OpenAthens, hope I haven't been stepping on too many toes |
13:13 |
|
jihpringle joined #evergreen |
13:22 |
csharp |
jeffdavis: I'm very glad you brought it up |
13:23 |
csharp |
we recommended that they get input from the larger community as they develop, so this is exactly what we had in mind :-) |
13:26 |
Dyrcona |
csharp: Going back to our memcached convo last week. I upped our allowed connections to 2048 per memcached instance, and we've gone over 1024 more than once today. |
13:26 |
Dyrcona |
We're currently at 988 and 1075 connections. |
13:27 |
Dyrcona |
Staff are not complaining about being kicked out of Evergreen. |
13:29 |
csharp |
oh - great to hear |
13:29 |
|
terranm joined #evergreen |
13:30 |
csharp |
I remember on one of our less-than-optimal DB hardware configurations that we had to up memcache connections higher than expected, but it's been a while since it has been an issue |
13:30 |
csharp |
(not implying anything about your setup - just sharing when it affected us :-) ) |
13:32 |
Dyrcona |
I've never kept a close eye on the number of connections until last week. I also don't see how less than optimal db settings would really affect memcached. |
13:33 |
Dyrcona |
We have cataloging staff complaining that Evergreen is slow, particularly z39.50 search with oclc, but I don't see anything wrong on any of the servers. We don't look that busy as far as the numbers are concerned. |
13:34 |
csharp |
DB disk was slow because we had everything on spinning HDDs on a single RAID controller, slow DB meant connections were slower to release, resulting in more requests, which cascaded into a flood of memcache entries |
13:34 |
Dyrcona |
I see... |
13:35 |
Dyrcona |
Our db is pretty fast, though it could probably have better optimization settings. |
13:37 |
csharp |
ours was untenable and problems didn't let up until we added a second RAID array on a separate controller - with SSDs in the picture we no longer need it |
13:38 |
csharp |
now we're on all flash storage everywhere |
13:38 |
Dyrcona |
Right. RAID controllers are often slower than SSDs these days. |
13:38 |
csharp |
yeah - it was a massive improvement when we moved to SSD |
13:38 |
Dyrcona |
Our db is stored on a ZFS mirrored array on NVMe SSDs. |
13:38 |
csharp |
nice |
13:38 |
csharp |
that's better than what we had during the Second Age of PINES |
13:39 |
csharp |
(now in the Third Age) |
13:39 |
Dyrcona |
It's basically just two NVMe drives, one a mirror of the other. The replication db is the same. |
13:39 |
* csharp |
blows the dust off the Boke of PINES |
13:40 |
Dyrcona |
:) |
13:40 |
Dyrcona |
The Pinesboke. |
13:40 |
csharp |
ooh - even better :-) |
13:42 |
csharp |
@praise 9 The PINESBoke |
13:42 |
* pinesol |
And The PINESBoke raised the report up on high, saying O Lord, bless this thy circ report, that with it thou mayst blow thine enemies to tiny bits, in thy mercy. |
13:43 |
Dyrcona |
:) |
13:43 |
csharp |
"And the Lord did grin. And the people did feast upon the lambs and sloths, and carp and anchovies, and orangutans and breakfast cereals, and fruit-bats" |
13:43 |
Dyrcona |
"Skip ahead a bit, brother." |
13:44 |
csharp |
never gets old for me |
13:44 |
* mmorgan |
listens for the sound of coconuts clapping together ;-) |
14:49 |
|
khuckins_ joined #evergreen |
15:03 |
|
mmorgan1 joined #evergreen |
15:15 |
Bmagic |
What would cause the offline circulation menu item to be disabled? |
15:19 |
berick |
Bmagic: if the browser can't use IndexedDB |
15:19 |
Bmagic |
hmmmm, clear cache? |
15:19 |
berick |
or if it can't talk to the shared worker which handles IndexedDB communication |
15:22 |
Bmagic |
berick++ |
15:31 |
gmcharlt |
bshum: thanks for the work over the weekend. I've variously cherry-picked your patches or pushed alternative approaches |
15:31 |
gmcharlt |
in particularly, I've elected not to add a new install-from-CPAN-dep for now |
15:34 |
pinesol |
[evergreen|Galen Charlton] LP#1817645: (follow-up) avoid hardcoding user ID in a live_t test - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a8f6ccf> |
15:34 |
pinesol |
[evergreen|Ben Shum] LP#1817645: fix live perl test for basic auth API - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c9404f6> |
15:34 |
pinesol |
[evergreen|Galen Charlton] LP#1817645: adjust live_t remoteauth checks - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0af1850> |
15:40 |
Dyrcona |
Well, I think I figured out the mystery of auto_renewal not being set. it looks like the circ object is combcirc, which lacks the field, though I'm pretty sure that I added it to our IDL on training, but I'll double check. |
15:41 |
Dyrcona |
Yep. I added it to the IDL on training, so why doesn't it show up in AngularJS? |
15:41 |
Dyrcona |
It's in both IDLs, AFAICT. |
15:43 |
Dyrcona |
Actually, looking at it in the JS debugger, field 49 is "T" and that would be the position of the auto_renewal field that I added to the IDL. |
15:45 |
Dyrcona |
Yeahp. That adds up. |
15:48 |
Dyrcona |
In the debugger, circ.auto_renewal() it "t"! |
15:49 |
Dyrcona |
But, when I let it run, the condition in the template for circ.auto_renewal() == 't' never triggers. |
15:51 |
|
mmorgan joined #evergreen |
15:52 |
Dyrcona |
Is it the grid? Does the grid need to be made aware of the field? Something to look into tomorrow morning. |
15:58 |
Dyrcona |
No, that doesn't seem to be the problem, either. |
16:14 |
pinesol |
[evergreen|Thomas Berezansky] Ensure "Reshelved" copies are still reshelving - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2d000a9> |
16:23 |
bshum |
gmcharlt++ # I like your fixes too :) |
16:24 |
bshum |
I think I tried it that way for the auth passwd test this morning but got hung up on all the single quote extra quotes and other stuff so I gave up and declared from the beginning |
16:25 |
JBoyer |
<Homer>Doh!</Homer> |
16:25 |
JBoyer |
At least that's a simple commit to learn a lesson on. :/ |
16:27 |
bshum |
JBoyer++ # commit more, be happy :) |
16:37 |
|
jvwoolf left #evergreen |
16:54 |
pinesol |
[evergreen|Galen Charlton] first rough pass at 3.4 release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=bbdb8fd> |
16:54 |
pinesol |
[evergreen|Galen Charlton] prune RELEASE_NOTES_NEXT - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=97c849b> |
17:01 |
gmcharlt |
bshum: should there be a new bzr branch for 3.3? |
17:02 |
bshum |
gmcharlt: Maybe have to check with dbwells on that, he was setting up the last ones, I wasn't involved |
17:03 |
bshum |
It doesn't appear to have been setup with LP |
17:03 |
bshum |
That whole process needs to be refactored anyways given how much is now supposed to be done in the new Poeditor site |
17:03 |
bshum |
And is undocumented |
17:08 |
pinesol |
[evergreen|Galen Charlton] Translation updates - newpot - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a272265> |
17:08 |
pinesol |
[evergreen|Galen Charlton] Translation updates - po files - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=33aeb89> |
17:09 |
|
mmorgan left #evergreen |
17:18 |
|
sandbergja joined #evergreen |
17:40 |
|
sandbergja joined #evergreen |
20:37 |
|
sandbergja joined #evergreen |
23:01 |
pinesol |
News from qatests: Failed Installing AngularJS web client <http://testing.evergreen-ils.org/~live/test.28.html#2019-09-09T23:00:55,734252544-0400 -0> |
23:01 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live/test.49.html#2019-09-09T23:00:55,762498360-0400 -2> |