Time |
Nick |
Message |
03:42 |
|
jamesrf joined #evergreen |
04:10 |
|
jamesrf joined #evergreen |
06:58 |
|
agoben joined #evergreen |
07:13 |
|
rjackson_isl joined #evergreen |
07:48 |
|
Dyrcona joined #evergreen |
08:06 |
|
bos20k joined #evergreen |
08:20 |
Dyrcona |
We set up the nginx proxy this morning and 1 library has already reported getting "too many redirects" with Chrome when trying to access a report. Has anyone else seen this and resolved it? |
08:25 |
JBoyer |
Dyrcona, I don't recall for certain, but in the Apache configs, if you don't have the right ports in the VirtualHost and ServerName/Alias lines they can do something like that. VHost gets the 7443 and 7080 lines of course, but you have to use the external ports (443, 80) in the ServerName/Alias lines. |
08:25 |
|
jvwoolf joined #evergreen |
08:26 |
Dyrcona |
Ah OK.... I'll change that. |
08:26 |
Dyrcona |
It wasn't clear to me. |
08:32 |
JBoyer |
And I should say, I *think* that can cause redirect issues. It's been long enough that I don't remember if anything else can do that. |
08:35 |
|
collum joined #evergreen |
08:36 |
Dyrcona |
OK. I've made the fix and we'll see. |
08:42 |
Dyrcona |
I should have realized that ServerName and ServerAlias didn't need the changes. Guess :% s/.../.../ was a bad idea. :) |
08:45 |
JBoyer |
:) |
08:48 |
Dyrcona |
JBoyer++ Looks like that was the issue. |
08:49 |
JBoyer |
Nice. |
08:51 |
|
mmorgan joined #evergreen |
09:02 |
|
yboston joined #evergreen |
09:21 |
|
jvwoolf joined #evergreen |
10:09 |
|
nfBurton joined #evergreen |
10:10 |
|
tlittle joined #evergreen |
11:02 |
|
jamesrf joined #evergreen |
11:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
11:20 |
|
sandbergja joined #evergreen |
11:20 |
|
yboston joined #evergreen |
11:25 |
|
cmalm joined #evergreen |
12:11 |
|
sandbergja_ joined #evergreen |
12:31 |
|
collum joined #evergreen |
12:39 |
|
khuckins joined #evergreen |
12:56 |
|
bos20k joined #evergreen |
12:59 |
|
bos20k joined #evergreen |
13:02 |
|
collum_ joined #evergreen |
13:12 |
|
bos20k joined #evergreen |
13:21 |
|
jihpringle joined #evergreen |
13:42 |
|
yboston joined #evergreen |
14:30 |
|
collum joined #evergreen |
14:34 |
|
nfBurton joined #evergreen |
14:54 |
|
khuckins joined #evergreen |
15:01 |
|
mmorgan1 joined #evergreen |
15:04 |
jeffdavis |
sandbergja: with your latest branch for bug 1816475, building the Angular client with `ng build` gives me some circular dependency warnings and Manage Reservations fails to load with a "No provider for BookingResourceBarcodeValidator" console error. Using `ng build --prod` works fine. |
15:04 |
pinesol |
Launchpad bug 1816475 in Evergreen "Booking module refresh" [Wishlist,Confirmed] https://launchpad.net/bugs/1816475 |
15:05 |
|
yboston joined #evergreen |
15:08 |
sandbergja |
jeffdavis: thanks for the heads up -- let me take a lok |
15:08 |
|
sandbergja_ joined #evergreen |
15:08 |
sandbergja |
^look |
15:55 |
sandbergja |
berick: have you run into issues where `ng build` fails but `ng build --prod` does not? If so, any advice to share? |
15:55 |
sandbergja |
(see jeffdavis' report above) |
15:56 |
berick |
sandbergja: i have not. in fact, --prod should be way more finicky |
15:56 |
* berick |
tries to reproduce |
15:56 |
sandbergja |
(twilight zone music) |
15:59 |
berick |
sandbergja: are you able to reproduce the issue? 'ng build', 'ng build --watch', 'ng build --prod' all work fine for me compiling user/sandbergja/lp1816475_booking_refresh_for_coop |
16:00 |
sandbergja |
hmmm... I was a minute ago. I'll give it another try |
16:01 |
berick |
I have Angular CLI: 7.3.6, Node: 8.11.4 |
16:17 |
|
mmorgan joined #evergreen |
16:38 |
|
sandbergja_ joined #evergreen |
16:58 |
sandbergja |
berick: do you get the circular dependency warnings at the end of ng build, by any chance? |
17:07 |
sandbergja |
berick: jeffdavis: I think I figured it out |
17:10 |
|
mmorgan left #evergreen |
17:10 |
sandbergja |
angular_dependency_injection+- |
17:16 |
berick |
sandbergja: no.. odd. just scrolled back through build history, no such warnings |
17:18 |
sandbergja |
Weird! I am Angular CLI 7.3.9, Node 8.10.0 |
17:19 |
sandbergja |
Angular 7.2.15 |
17:25 |
berick |
sandbergja: i'm a genius. i checked the branch out on one VM but compiled (master, apparently) on another VM. |
17:25 |
berick |
and now I see the warning |
17:26 |
sandbergja |
berick: excellent! |
17:26 |
sandbergja |
I wonder where those warnings go in the case of `ng build --prod`; I feel like they have to be logged somewhere... right? |
17:28 |
berick |
--prod is quite a different beast. it may just be less susceptible to circular deps. issues. |
17:28 |
berick |
not really sure |
17:29 |
berick |
but I'd be surprised if they didn't show a found warning / problem give how verbose ng build usually is |
17:29 |
berick |
*given |
17:34 |
sandbergja |
berick++ # https://bugs.launchpad.net/evergreen/+bug/1834662/comments/12 |
17:34 |
pinesol |
Launchpad bug 1834662 in Evergreen "Add date-time-select and date-range-select to Angular client" [Wishlist,Confirmed] |
17:37 |
|
jvwoolf left #evergreen |
17:45 |
|
yboston joined #evergreen |
19:45 |
|
sandbergja_ joined #evergreen |
21:16 |
|
sandbergja joined #evergreen |
21:46 |
|
sandbergja joined #evergreen |
22:45 |
|
sandbergja joined #evergreen |
23:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |