Time |
Nick |
Message |
00:37 |
|
sandbergja joined #evergreen |
00:42 |
|
abowling1 joined #evergreen |
00:46 |
|
abowling joined #evergreen |
01:06 |
|
gsams joined #evergreen |
02:07 |
|
sandbergja joined #evergreen |
04:57 |
|
jamesrf joined #evergreen |
05:02 |
pinesol |
News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~live/test.29.html#2019-05-29T04:53:52,213499125-0400 -0> |
05:02 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live/test.49.html#2019-05-29T04:53:52,247157428-0400 -2> |
06:32 |
bshum |
Hmm.. Time for Node v10? ;) |
06:33 |
bshum |
Or we need to pin a lower version of Angular CLI |
06:33 |
bshum |
Either way v8 is marked EOL on the site by end of 2019 |
07:14 |
|
rjackson_isl joined #evergreen |
07:15 |
bshum |
Yeah, angular CLI 8.0 was released 14 hours ago per https://github.com/angular/angular-cli/releases |
07:19 |
bshum |
Downgraded to 7.3.9 (last release before that one) and it still cries, but not as fatally |
07:21 |
bshum |
"Your global Angular CLI version (7.3.9) is greater than your local |
07:21 |
bshum |
version (7.0.7). The local Angular CLI version is used." |
07:21 |
bshum |
but at least, everything ran fine in eg2 without actual errors this time |
07:21 |
* bshum |
wonders if berick or others have looked at node.js v10 or v12 :D |
07:23 |
bshum |
Ah, okay, in package.json for eg2 we do set it to ^7.0.7 there |
07:23 |
bshum |
So maybe we also need to specify a version in the angularjs package.json file too |
07:23 |
bshum |
So that we don't install angular CLI 8 now that it's out |
07:24 |
* bshum |
goes back to the beginning and makes a new branch |
07:34 |
csharp |
how involved is upgrading everything to use the new angular cli? |
07:34 |
csharp |
or, in general, getting on a track where "downgrade X" isn't the answer? :-( |
07:35 |
bshum |
Well, technically it's not out of support (yet). So I'm OK with downgrading it since the new one also only just arrived on the scene :D |
07:35 |
bshum |
But yeah, getting to newer node versions is more complicated I think |
07:35 |
csharp |
ok - I was just thinking about the EOL issue |
07:36 |
bshum |
Maybe berick and everyone already has secret branches testing new Nodes :D |
07:36 |
* csharp |
wants to avoid repeating XUL/Dojo, etc. |
07:36 |
csharp |
prolly too early for this kind of discussion :-) |
07:37 |
bshum |
Probably :) |
07:37 |
csharp |
bshum++ # working on it |
07:37 |
bshum |
I'm just trying to see if I can figure out how to fix the installer so that we can keep working. :) |
07:37 |
csharp |
for sure |
07:37 |
bshum |
Otherwise, let's say that anybody else who tries to install Evergreen today is probably in troubles |
07:38 |
bshum |
I'm sure someone will grumble later about the upgrade process ;) |
07:41 |
bshum |
I guess we should probably be using node.js v8.16.0 (latest) instead of 8.11.4 which we pin in the makefile |
07:41 |
bshum |
But that's a whole other thing :) |
07:41 |
bshum |
Ho hum |
07:42 |
bshum |
I guess my branch idea won't work either. Cause it's off in the makefile where it installs angular-cli (and gets the latest) |
07:42 |
* bshum |
tries another idea |
07:43 |
bshum |
Yup |
07:43 |
bshum |
So in the Makefile.common |
07:43 |
bshum |
We run: npm install -g @angular/cli |
07:43 |
bshum |
We can change it there to: npm install -g @angular/cli7.0.7 (or whatever version we want) |
07:43 |
bshum |
And that should fix it. |
07:44 |
* bshum |
deletes his working branch and starts over |
07:47 |
bshum |
Okay - https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/pin-angular-cli-version |
07:51 |
|
collum joined #evergreen |
07:52 |
bshum |
I have to go get ready for work now, but I'll try to follow up with everyone later in the day on this issue |
07:53 |
* bshum |
leaves his VM to try installing the new branch and see if it bombs when he comes back |
07:54 |
* bshum |
has a few ideas for changes to berick's ansible installer to deal with some deprecation warnings from new ansible too |
07:56 |
* bshum |
thinks the LP ticket we eventually make on this should be about the node.js version upgrade, rather than pinning the angular-cli to older version |
07:56 |
bshum |
Since this is more of a hack fix to me, than a real long-term solution |
07:56 |
bshum |
Plus also, with EOL, it's better to look to the future |
07:57 |
csharp |
+1 |
07:58 |
bshum |
csharp++ # good mornin'! |
08:14 |
bshum |
Huzzah, happy install :) |
08:17 |
bshum |
So my test VM built the web client successfully without any errors with the branch change I made above |
08:19 |
* bshum |
leaves it there for now and heads off to work |
08:19 |
bshum |
Have a good day everybody! |
08:25 |
|
bos20k joined #evergreen |
08:45 |
|
mmorgan joined #evergreen |
08:52 |
csharp |
bshum++ |
08:55 |
|
Dyrcona joined #evergreen |
08:58 |
Dyrcona |
Ima just put this here for bshum: https://drive.google.com/open?id=1LPjv9jedXFVPsGVn81dqKYI5MHXwV6gx |
09:09 |
|
JBoyer_alt joined #evergreen |
09:18 |
|
khaun joined #evergreen |
09:27 |
|
JasonEDN joined #evergreen |
09:32 |
|
yboston joined #evergreen |
09:40 |
|
JasonEDN joined #evergreen |
09:43 |
|
JasonEDN1 joined #evergreen |
09:45 |
|
JasonEDN joined #evergreen |
09:54 |
|
aabbee joined #evergreen |
10:08 |
|
sandbergja joined #evergreen |
10:25 |
|
Christineb joined #evergreen |
10:41 |
|
bos20k joined #evergreen |
10:44 |
|
khuckins joined #evergreen |
10:51 |
pinesol |
[evergreen|Garry Collum] LP1772206 Tooltips missing from Patron Summary - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=16e2c31> |
10:59 |
pinesol |
[evergreen|Sam Link] LP1736967 Primary a CSS Styling Fix - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=092e8ff> |
10:59 |
pinesol |
[evergreen|Galen Charlton] LP#1736967: (follow-up) add release notes entry - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=550410d> |
11:03 |
|
sandbergja joined #evergreen |
11:15 |
pinesol |
[evergreen|Garry Collum] LP#1748265 SMS Carrier not an option in the patron's list of holds. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0f328e5> |
11:15 |
pinesol |
[evergreen|Bill Erickson] LP1748265 Hold fetch API sms_carrier option - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=04bc46e> |
11:30 |
|
sandbergja_ joined #evergreen |
11:40 |
|
sandbergja_ joined #evergreen |
12:14 |
pinesol |
[evergreen|Geoff Sams] LP1776913: Corrects Local Administration menu to use correct form Circulation Limit Sets and Age Overdue Circulations to Lost. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7675ee7> |
12:14 |
pinesol |
[evergreen|Geoff Sams] Docs: LP1776913: Fixes references to Circulation Limit Sets in docs. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=df482b4> |
13:16 |
|
collum_ joined #evergreen |
14:19 |
gsams |
@weather 76262 |
14:19 |
pinesol |
gsams: Error: Failed to load Wunderground API. Check the logs for more information. |
14:20 |
jeff |
bug 1830424 was reported by Evergreen Bug Maintenance. Was that just a case of someone forgetting which account they were using at the time, or do we have a process that results in some bugs having that reporter? |
14:20 |
pinesol |
Launchpad bug 1830424 in Evergreen ""Retrieve last bib record" broken from Angular (eg2) admin menu" [Undecided,Confirmed] https://launchpad.net/bugs/1830424 |
14:22 |
jeff |
never mind. looks like the former, based on a lack of other open bugs with that reporter. :-) |
14:23 |
Dyrcona |
jeff: I've commented on at least one bug when I was still logged in as the bug maintenance account. |
14:23 |
Dyrcona |
Don't think I've reported any that way. |
15:09 |
|
jamesrf joined #evergreen |
15:13 |
|
mmorgan left #evergreen |
15:15 |
|
yboston joined #evergreen |
15:32 |
pinesol |
Showing latest 5 of 25 commits to Evergreen... |
15:32 |
pinesol |
[evergreen|Bill Erickson] LP1819498 Release Notes - Staff Cat CN Browse - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f52728d> |
15:32 |
pinesol |
[evergreen|Bill Erickson] LP1819745 Ang staff result page link repairs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a09bc5d> |
15:32 |
pinesol |
[evergreen|Bill Erickson] LP1820304 Ang catalog copy/volume hold links - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d18bf8c> |
15:32 |
pinesol |
[evergreen|Bill Erickson] LP1821382 Initials Serials menu; button styling - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c367c3f> |
15:32 |
pinesol |
[evergreen|Bill Erickson] LP1823367 Angular lint repairs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d58e26f> |
15:33 |
* csharp |
watches as berick fixes all the rest of the bugs |
15:36 |
|
abowling left #evergreen |
15:36 |
|
abowling joined #evergreen |
15:37 |
|
abowling left #evergreen |
15:37 |
|
abowling joined #evergreen |
15:39 |
|
abowling left #evergreen |
15:39 |
|
jamesrf joined #evergreen |
15:40 |
|
abowling joined #evergreen |
15:46 |
|
yboston joined #evergreen |
16:03 |
|
abowling left #evergreen |
16:06 |
|
abowling joined #evergreen |
16:08 |
|
abowling left #evergreen |
16:11 |
|
abowling joined #evergreen |
16:12 |
abowling |
jlamos: do you see this? |
16:12 |
jlamos |
yep |
16:12 |
abowling |
anyone know why i appear voiceless? |
16:12 |
awitter |
in my pdgin none of us has the speaker icon or whatever that is |
16:13 |
bshum |
The voice is granted to users who are registered and identified to freenode IRC |
16:13 |
bshum |
*automatically granted |
16:13 |
abowling |
bshum: that's the confusion. i am registered with freenode. |
16:14 |
bshum |
Hmm |
16:14 |
bshum |
Maybe check with nickserv I guess |
16:14 |
bshum |
To see if it identified you properly |
16:14 |
abowling |
but you're hearing me...it's just i want my icon!!! |
16:14 |
bshum |
:D |
16:14 |
Dyrcona |
:) |
16:15 |
berick |
dbwells++ # catalog commits. |
16:15 |
* berick |
reviews follow-ups |
16:15 |
abowling |
yeah, everything checks out on freenode |
16:15 |
bshum |
Well I told pinesol to give you a voice ;) |
16:15 |
abowling |
bshum++ |
16:15 |
abowling |
thanks! |
16:16 |
awitter |
yaaay |
16:16 |
remingtron |
bshum++ #voices for the voiceless |
16:16 |
abowling |
making people heard |
16:16 |
bshum |
The next time you log in, I'll be curious if it fails again |
16:16 |
awitter |
bshum++ |
16:16 |
abowling |
bshum: me too |
16:19 |
jeff |
voice doesn't currently matter in #evergreen, so I have been a little lax in maintaining the flags in ChanServ. |
16:20 |
bshum |
It's okay, I'm sure the spammers were just waiting for you to let your guard down jeff ;) |
16:20 |
bshum |
And then that happens, lol |
16:21 |
jeff |
(heh) |
16:21 |
jeff |
that happened because i touched the flags -- added awitter |
16:22 |
awitter |
lol |
16:23 |
jeff |
er, s/awitter/abowling/ in my line above. |
16:23 |
bshum |
jeff++ |
16:36 |
bshum |
Noting for main channel logs, that the issue I worked on this morning with nodejs only impacts people who install master,rel_3_3,or rel_3_2 from git |
16:37 |
bshum |
The tarballs were built before the node problems, so should be fine. |
16:41 |
abowling |
anyone else have cat issues with $scope.hasMulti and a bad length in /openils/var/web/js/ui/default/staff/cat/volcopy/app.js? |
16:42 |
abowling |
trying to add the simplest holding and it's failing. can't figure out if it it's a bug or an error in the user's process. |
16:44 |
berick |
abowling: there's an LP on that |
16:44 |
berick |
https://bugs.launchpad.net/evergreen/+bug/1830394 |
16:44 |
abowling |
berick: thanks. my search must not have been good enough. |
16:44 |
pinesol |
Launchpad bug 1830394 in Evergreen "holdings editor can spew MultiMap errors in browser log" [Medium,New] |
16:45 |
abowling |
berick++ |
16:45 |
abowling |
gmcharlt++ |
17:00 |
pinesol |
News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~live/test.29.html#2019-05-29T16:55:54,955319834-0400 -0> |
17:00 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live/test.49.html#2019-05-29T16:55:54,982778127-0400 -2> |
17:09 |
|
khuckins joined #evergreen |
17:42 |
gmcharlt |
berick: bug 1830972 now has a pull reuest |
17:42 |
pinesol |
Launchpad bug 1830972 in Evergreen 3.2 "pin version of angular/cli that is installed globally by Makefile.common" [High,New] https://launchpad.net/bugs/1830972 |
17:43 |
* berick |
nods |
17:55 |
pinesol |
[evergreen|Galen Charlton] LP#1830972: update pin and add comments about keeping things in sync - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e816446> |
20:44 |
bshum |
berick++ gmcharlt++ # cool :) |
21:20 |
bshum |
berick: Also sorry about all the email you're probably getting about the ansible installer. I'm learning the hard way how to do the pullrequest stuff :) |
21:21 |
|
sandbergja joined #evergreen |
21:27 |
bshum |
Third time's the charm. Maybe. |
21:29 |
bshum |
I'll get the hang of it. Eventually. |
21:42 |
|
jamesrf joined #evergreen |
23:02 |
|
sandbergja joined #evergreen |
23:39 |
|
JasonEDN1 joined #evergreen |
23:43 |
|
JasonEDN joined #evergreen |
23:49 |
|
JasonEDN joined #evergreen |