Time |
Nick |
Message |
00:20 |
|
sandbergja joined #evergreen |
02:07 |
|
jamesrf joined #evergreen |
05:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:05 |
|
agoben joined #evergreen |
07:06 |
|
rjackson_isl joined #evergreen |
08:25 |
|
bos20k joined #evergreen |
08:38 |
|
mmorgan joined #evergreen |
08:39 |
|
collum joined #evergreen |
08:58 |
|
aabbee joined #evergreen |
09:05 |
|
Dyrcona joined #evergreen |
09:05 |
Dyrcona |
csharp: I guess tar pits don't have psychedelic tea parties. |
09:06 |
|
terran joined #evergreen |
09:16 |
|
yboston joined #evergreen |
09:29 |
|
Dyrcona joined #evergreen |
10:24 |
|
Christineb joined #evergreen |
10:26 |
|
mmorgan1 joined #evergreen |
10:26 |
stephengwills |
in opensrf.xml is the use of single v. double quotes a style thing or a necessary change. xml version=‘1.0’. ? |
10:27 |
aabbee |
xml shouldn't care about " vs ', but your message there just used ‘, which i don't think will work. |
10:29 |
stephengwills |
in my upgrades I do a diff opensrf.xml.example prod/opensrf.xml and if the only diffs are custom I ignore the step…but that single v. double quote made me wonder if I should fix that tag in prod. |
10:29 |
stephengwills |
my prod uses double and 3.3.0 is using single |
10:34 |
Dyrcona |
stephengwills: Don't use diff put your configuration in git. You will thank me tomorrow. |
10:34 |
Dyrcona |
As aabbee said, XML doesn't really care about single versus double quotes, as long as they're balanced. |
10:36 |
aabbee |
https://i.imgur.com/WdIeKEt.jpg |
10:37 |
Dyrcona |
So, I see you're a Lisp programmer..... :) |
10:38 |
aabbee |
https://xkcd.com/224/ :-) |
10:39 |
Dyrcona |
aabbee++ |
10:39 |
berick |
heh |
10:39 |
berick |
i've never seen that one |
10:39 |
Dyrcona |
That's about right The universe feels like a nasty Perl hack. |
10:40 |
aabbee |
img alt text: "We lost the documentation on quantum mechanics. You'll have to decode the regexes yourself." |
10:42 |
stephengwills |
@Drycona - my version of config is in git but I still want to make sure that the rel_3_3_0 version doesn’t have changes my custom version doesn’t have, right? |
10:42 |
pinesol |
stephengwills: Yeah, well, you know, that's just, like, your opinion, man. |
10:42 |
stephengwills |
lol, k |
10:46 |
|
yboston joined #evergreen |
10:49 |
Dyrcona |
stephengwills: That's easy, just git diff it or even just merge the 3.3.0 changes to your branch. |
10:50 |
Dyrcona |
If you use @ here, like you would on twitter, the bot thinks you're giving it a command. If it sees a command it doesn't recognize, it usually does the dunno command. |
10:50 |
Dyrcona |
@dunno |
10:50 |
pinesol |
Dyrcona: zarro boogs found |
10:51 |
Dyrcona |
I usually base my config and similar branches on master, then around release times, I make branch based on the rel_X_Y branch if we're going to upgrade to that release. |
10:52 |
Dyrcona |
Periodic rebases and/or merges keep things up to date. Note that I typically use rebase to keep my commits at the tip of the branch. |
10:53 |
|
mmorgan joined #evergreen |
10:53 |
Dyrcona |
Now, to figure out why psql tells me the home directory, also the current directory, doesn't exist for writing. |
10:54 |
Dyrcona |
I've even tried touching the file before writing to it, no dice. |
10:55 |
|
sandbergja joined #evergreen |
10:56 |
Dyrcona |
All right, using \o filename and then specifying stdout on the copy worked. |
10:57 |
Dyrcona |
That's clever... someone put their SMS number between U+202D and U+202C... Are those "smart" quotes? |
10:57 |
|
khuckins joined #evergreen |
10:59 |
Dyrcona |
Indeed they are. |
10:59 |
Dyrcona |
Patrons are so creative..... |
11:04 |
|
mmorgan1 joined #evergreen |
11:06 |
Dyrcona |
The database [:punct:] doesn't strip those out. I wonder if Perl does? |
11:13 |
* Dyrcona |
decides to revise a branch. |
11:21 |
gmcharlt |
here's one I've signed off now that should be easy for final committer review - bug 1785061 |
11:21 |
pinesol |
Launchpad bug 1785061 in Evergreen 3.2 "web client reporter: can't hard code a list of filter values" [High,Confirmed] https://launchpad.net/bugs/1785061 |
11:22 |
Dyrcona |
Definitely gonna revise the branch, but I think I'll do some more investigation, first. |
11:34 |
Dyrcona |
And, the branch/bug may not be necessary.... |
11:41 |
Dyrcona |
I'm missing it, though. A patron entered their sms notify with dashes, I can see that they were stripped out before the notice was sent, but I'm not finding the code that stripped out the dashes. The ahr table still has the dashes. |
11:43 |
Dyrcona |
All right. I found it. |
11:44 |
Dyrcona |
Someone confirmed my bug, and I was just about to mark it invalid.... :) |
11:47 |
jeff |
hah. |
11:47 |
jeff |
(and i just threw a comment on the pile, which probably references what you just found) |
11:58 |
Dyrcona |
jeff: Your comment almost covers what I found. I've added another comment, set the bug back to New status, and added the needsdiscussion tag. |
11:58 |
Dyrcona |
And, now, lunch! |
12:10 |
|
jihpringle joined #evergreen |
12:12 |
|
sandbergja joined #evergreen |
12:13 |
|
mmorgan joined #evergreen |
12:32 |
Dyrcona |
jeff: Do I remember correctly that you use Twilio for SMS messaging? |
12:34 |
jeff |
we do. |
12:35 |
jeff |
We've also taken steps to make hold notification preferences per-patron and not per-hold-per-patron. |
12:35 |
jeff |
(rather, not per-hold) |
12:39 |
Dyrcona |
jeff: Thanks. |
12:39 |
Dyrcona |
I'm starting to think the use case for per-hold notification preferences is wearing thin. :) |
12:40 |
Dyrcona |
Sometimes too many options is a bad thing. :) |
12:44 |
jeff |
part of where I'm going with reviving the idea of phone numbers like addresses (in another table) is getting away from the situation where you have lots of phone numbers as strings in lots of places. |
12:44 |
jeff |
here's a number, and the patron wants to use this number for text messages. |
12:46 |
jeff |
as opposed to "here's a daytime phone number, and here's that same number again as a opac.default_phone user setting, and the same number again as an opac.default_sms_notify user setting, and that same number again in action.hold_request.sms_notify, and action.hold_request.phone_notify, etc. |
12:47 |
Dyrcona |
jeff: Makes sense. I'm looking at the patron who got the smart quotes in 3 of his holds, and the sms number appears in at least 3 different forms, and it's redundant repeating it for every single hold. |
12:48 |
Dyrcona |
The patron's sms notify setting doesn't have the smart quotes. |
12:48 |
* Dyrcona |
suspects copy and paste or browser auto-fill based on a previous copy and paste. |
12:49 |
mmorgan |
Is there a way to get the call number prefix in the web client Hold Pull List print template? |
12:50 |
mmorgan |
I'm not seeing a launchpad bug, but that doesn't mean there isn't one |
13:14 |
|
jamesrf joined #evergreen |
13:20 |
|
mdriscoll joined #evergreen |
13:32 |
|
jamesrf joined #evergreen |
13:39 |
|
sandbergja joined #evergreen |
13:43 |
|
mmorgan1 joined #evergreen |
13:51 |
|
mdriscoll left #evergreen |
13:59 |
|
stephengwills joined #evergreen |
14:16 |
|
mdriscoll joined #evergreen |
14:28 |
bshum |
Okay, I fixed the LP milestone targets to show them as released. And not just invisible forever. |
14:29 |
bshum |
It looked weird to me in the milestone map to have them skip from 3.3.0 to 3.3.2 :) |
14:29 |
bshum |
Though oops, I think I just released the wrong 3.2, fixing that... |
14:33 |
bshum |
Okay that's better |
14:58 |
|
yboston joined #evergreen |
15:12 |
|
yboston joined #evergreen |
15:17 |
|
jamesrf joined #evergreen |
15:45 |
stephengwills |
For the record, i rebuilt my 3.3.0 using the tarball from the website and still had the error…i.e. the group permission id as username when I look at /eg/staff/reporter/legacy/main with my chrome browser but a fresh firefox browser doesn’t have the issue. After clearing chrome cache, quitting chrome and restarting chrome… it’s working. |
15:50 |
|
BAMkubasa joined #evergreen |
15:51 |
pinesol |
[evergreen|Sam Link] LP1735754 - WGAC Compliance for Advanced Search - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=4dad632> |
15:53 |
BAMkubasa |
Hey folks. SIP2 messages. 23 & 63 are patron status requests, with responses of 24 & 64. The first 14 characters (after24/64) are a status message. Seems from what I've seen they are either Y or blank, but what do they mean? I can't figure out which of the 14 characters are for what aspect of a patron status, and which ones should result in a denial of service |
15:55 |
berick |
BAMkubasa: http://multimedia.3m.com/mws/media/355361O/sip2-protocol.pdf |
15:55 |
berick |
search the doc for 'patron status' |
15:55 |
BAMkubasa |
I've read through 3M's SIP2 but maybe I missed it? |
15:55 |
berick |
around page 22/23 |
15:56 |
berick |
top of page 23 is the list |
15:57 |
BAMkubasa |
didn't read far enough. thank you berick |
16:10 |
|
mmorgan joined #evergreen |
17:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:11 |
|
mmorgan left #evergreen |
17:12 |
|
mdriscoll left #evergreen |
17:13 |
pinesol |
[evergreen|Bill Erickson] LP1693580 Marc editor notify and API changes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e84ec5e> |
17:13 |
pinesol |
[evergreen|Bill Erickson] LP1693580 Authority create/update API repairs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=98c12d6> |
17:25 |
|
sandbergja joined #evergreen |
17:44 |
|
jamesrf joined #evergreen |
18:09 |
pinesol |
[evergreen|Bill Erickson] LP1816679 Match Set Type selector options - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3c4bf97> |
19:19 |
|
jamesrf joined #evergreen |
19:44 |
|
Christineb joined #evergreen |
20:17 |
|
jamesrf joined #evergreen |
20:24 |
|
sandbergja joined #evergreen |
20:44 |
|
jamesrf joined #evergreen |
21:04 |
|
jamesrf joined #evergreen |
22:47 |
|
jamesrf joined #evergreen |
23:22 |
|
jamesrf joined #evergreen |