| Time |
Nick |
Message |
| 00:15 |
|
sandbergja joined #evergreen |
| 01:04 |
|
StomproJ joined #evergreen |
| 01:39 |
|
Stompro joined #evergreen |
| 05:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:12 |
|
rjackson_isl joined #evergreen |
| 08:18 |
|
collum joined #evergreen |
| 08:29 |
|
stephengwills joined #evergreen |
| 08:38 |
|
bos20k joined #evergreen |
| 08:40 |
|
mmorgan joined #evergreen |
| 09:27 |
|
yboston joined #evergreen |
| 10:01 |
|
sandbergja joined #evergreen |
| 10:34 |
|
stephengwills joined #evergreen |
| 10:41 |
Bmagic |
@coffee [someone] |
| 10:41 |
* pinesol |
brews and pours a cup of Kenyan Highland Cooperatives, and sends it sliding down the bar to book` |
| 10:58 |
Bmagic |
Has anyone noticed that the billing type dropdown menu on Webby has the default menu item selected that isn't the first menu item? Some systems have numbered these so that the one they want first will be first |
| 11:04 |
Bmagic |
I suppose everyone is getting ready to travel today! I must be alone in the channel.... or maybe I'm not connected anymore.... |
| 11:05 |
|
Bmagic joined #evergreen |
| 11:09 |
bshum |
Bmagic: You're never really alone. pinesol is (almost) usually there :D |
| 11:09 |
Bmagic |
:) |
| 11:10 |
Bmagic |
@coffee bshum |
| 11:10 |
* pinesol |
brews and pours a cup of Ethiopia Sidamo Special Prep, and sends it sliding down the bar to bshum |
| 11:10 |
Bmagic |
bshum++ |
| 11:10 |
Bmagic |
We going to see you at the conference? |
| 11:10 |
bshum |
Yes sir. I'll be driving on down sometime Wednesday unless I feel up to making the trek earlier |
| 11:10 |
Bmagic |
suuuweet! |
| 11:11 |
Bmagic |
I have to wake up at like 4am to catch a local flight at 6:30am |
| 11:11 |
Bmagic |
tomorrow |
| 11:11 |
bshum |
Yikes |
| 11:11 |
bshum |
That's very early :) |
| 11:11 |
Bmagic |
yeah, pretty nasty |
| 11:12 |
Bmagic |
I figure I will just stay up playing Starcraft 2 |
| 11:12 |
Bmagic |
and sleep when I get there |
| 11:12 |
bshum |
It's only a three hour or so drive from CT to PA, but have to factor in any weird traffic patterns through NY bridges, etc. |
| 11:12 |
Bmagic |
errrr, I mean, stay up hacking Evergreen |
| 11:12 |
berick |
:) |
| 11:12 |
berick |
bshum: gald you can make it! |
| 11:13 |
mmorgan |
Bmagic: Re: the billing type, hadn't noticed that before, but I see it now. |
| 11:13 |
bshum |
berick: Yes! It should be fun to catch up with everybody a bit |
| 11:13 |
bshum |
I'm not staying at the conference hotel, but I'll be a mile away or so |
| 11:15 |
Bmagic |
mmorgan: oh good, confirmed then? |
| 11:18 |
mmorgan |
Bmagic: Yes, confirmed |
| 11:19 |
Bmagic |
I'll make the bug report unless you know of one already |
| 11:24 |
mmorgan |
Bmagic: I don't know of an existing bug |
| 11:24 |
Bmagic |
cool |
| 11:24 |
|
khaun joined #evergreen |
| 11:25 |
jeff |
Bmagic: 4am solidarity! flight leaves here at 05:10 tomorrow... |
| 11:25 |
Bmagic |
jeff++ # hang in there buddy |
| 11:26 |
Bmagic |
jeff: you want to have a Starcraft 2 Epic tournament tonight? errr, I mean Epic Evergreen hackfest? |
| 11:28 |
|
khuckins joined #evergreen |
| 11:29 |
Bmagic |
mmorgan: bug 1825857 |
| 11:29 |
pinesol |
Launchpad bug 1825857 in Evergreen "Default selected Billing Type item is not the first item" [Undecided,New] https://launchpad.net/bugs/1825857 |
| 11:34 |
|
stephengwills joined #evergreen |
| 11:50 |
mmorgan |
Bmagic++ |
| 12:24 |
|
yboston joined #evergreen |
| 12:43 |
|
mllewellyn joined #evergreen |
| 12:43 |
|
bos20k joined #evergreen |
| 12:53 |
|
sandbergja joined #evergreen |
| 13:36 |
Bmagic |
I've got a circ policy with a limit set. The limit set doesn't specify a circ mod or copy location or limit group. It seems that the limit set is no longer being respected after upgrading to 3.1 (from 3.0). I've confirmed that this circ matchpoint is being chosen and the patron has exceeded the limit. All items are own and circed at the same library |
| 13:37 |
Bmagic |
I'm reading action.item_user_circ_test |
| 13:42 |
mmorgan |
Bmagic: bug 1761560 ? |
| 13:42 |
pinesol |
Launchpad bug 1761560 in Evergreen "Circulation Limit Set Failing " [Undecided,New] https://launchpad.net/bugs/1761560 |
| 13:43 |
Bmagic |
it seems that the SQL logic is requiring that there be SOMETHING for the limit set. A circ mod or location or limit group set. This limit set has none specified, therefore, I would think it would count ALL previously circed ID's |
| 13:45 |
Bmagic |
mmorgan: very close, but that report mentions a circ mod for the limit set. |
| 13:47 |
mmorgan |
Bmagic: The description on that bug suggests to me that circ limit sets work if all the checkouts happen in the same checkout session, but fail if the patron already has items that match the limit set checked out. I wonder if it matters whether a circ modifier is specified in the limit set. |
| 13:48 |
Bmagic |
I was wondering if anyone can confirm that (different session causes different limits) |
| 13:49 |
jeff |
I think that at least one circ policy related to limits/sets creates an entry/tag on checkout which isn't then "back" populated for circulations that happened before the creation of the set. |
| 13:49 |
* jeff |
looks |
| 13:49 |
|
mdriscoll joined #evergreen |
| 13:50 |
jeff |
oh, but Bmagic thinks it's a "broke at upgrade" thing. Hrm. |
| 13:50 |
Bmagic |
that is anecdotal |
| 13:50 |
jeff |
ah. |
| 13:52 |
Bmagic |
I'm working on a pastebin |
| 13:53 |
pastebot |
"Bmagic" at 64.57.241.14 pasted "Excerpt sub-query from action.item_user_circ_test" (45 lines) at http://paste.evergreen-ils.org/10851 |
| 13:53 |
Bmagic |
I'm not sure how to express it in SQL |
| 13:54 |
Bmagic |
I thought the coalesce would have done it |
| 13:54 |
jeff |
I'm thinking of action.circulation_limit_group_map |
| 13:55 |
Bmagic |
all three of those: config.circ_limit_set_circ_mod_map where limit_set=66 config.circ_limit_set_copy_loc_map WHERE limit_set = 66 config.circ_limit_set_group_map WHERE limit_set = 66 do not match (0 rows, null) |
| 14:02 |
Bmagic |
oh I see, the nested IN() query returns non-null |
| 14:02 |
Bmagic |
This leads me to believe that each limit set absolutely needs one of those three things specified |
| 14:04 |
Bmagic |
I guess this begs the quesiton: does anyone want Evergreen's limit sets to function like that? All circulations debit the max number regardless of those three things? |
| 14:05 |
|
JBoyer joined #evergreen |
| 14:05 |
* JBoyer |
emerges from the logs... |
| 14:06 |
JBoyer |
Bmagic, there's already a way to do that, you can set up a standing penalty that stops new circs/hold/etc. at a certain number of open circs. |
| 14:06 |
Bmagic |
but for only juvenile? |
| 14:06 |
JBoyer |
We do that at 100 here, no need for the circ policy matrix to be involved. |
| 14:06 |
JBoyer |
Ouch. We do not do that.... |
| 14:07 |
Bmagic |
I think it has to be a circ policy with a limit set |
| 14:07 |
JBoyer |
So maybe it's not that simple. (I missed that if you said it already) |
| 14:07 |
Bmagic |
I didn't say that before |
| 14:07 |
Bmagic |
the library claims this used to work |
| 14:08 |
Bmagic |
I think I can make a change to this query with some clever CASE clauses in the where subselects |
| 14:09 |
JBoyer |
So long as it doesn't have any adverse effects on the general case it may be a helpful addition. Good luck! |
| 14:09 |
Bmagic |
lol, thanks! |
| 14:09 |
* JBoyer |
returns to the loggy mists... |
| 14:22 |
csharp |
Bmagic: if you're still having the problem tomorrow/Wednesday, I'd be happy to be a second pair of eyes |
| 14:22 |
Bmagic |
:) |
| 14:22 |
Bmagic |
csharp++ |
| 14:37 |
pastebot |
"Bmagic" at 64.57.241.14 pasted "Correction to subquery to allow none of the limit set connections" (29 lines) at http://paste.evergreen-ils.org/10852 |
| 14:38 |
Bmagic |
That tweak seems to be the route |
| 14:42 |
Bmagic |
I'll probably bring it up at the hackfest |
| 14:43 |
Bmagic |
made the bug 1825881 |
| 14:43 |
pinesol |
Launchpad bug 1825881 in Evergreen "Circulation limit sets seem to require circ mod or location or limit group" [Undecided,New] https://launchpad.net/bugs/1825881 |
| 14:46 |
bshum |
So wait |
| 14:46 |
bshum |
What's the circ rule that matched do/say? |
| 14:46 |
bshum |
And why couldn't you include circ mods, location, etc. for the limit set? |
| 14:46 |
Bmagic |
it just says max 10 |
| 14:46 |
bshum |
Instead of leaving it purely open ended |
| 14:46 |
Bmagic |
regardless of the other stuff |
| 14:47 |
Bmagic |
juveniles cannot have more than 10 items no matter what sort of items |
| 14:47 |
bshum |
But that max of 10 only applies for that group of material? Or users? |
| 14:47 |
Bmagic |
the circ rule |
| 14:47 |
Bmagic |
if the circulation matches the policy, then the limit set comes into play but is ignored presently |
| 14:48 |
bshum |
Hmm |
| 14:48 |
bshum |
Okay I think I get it |
| 14:48 |
* bshum |
moves to classify that bug as a wishlist development :) |
| 14:48 |
Bmagic |
The group penalty would work if it were for an entire permission group |
| 14:49 |
bshum |
That's kind of where my mind was going in my head |
| 14:49 |
Bmagic |
it's a subset of patron (juvenile=true) |
| 14:49 |
bshum |
Like most places would probably set hard limits that way against a specific groups of users |
| 14:49 |
Bmagic |
but this code update would allow for any subset of permission group |
| 14:50 |
bshum |
I guess our libraries didn't use the juvenile flag, we had a split off group for it |
| 14:50 |
bshum |
So that way it was easy to program against the specific user groups |
| 14:51 |
bshum |
Either way, if what you've found is accurate, doesn't sound to me like it ever supported the use case described? |
| 14:52 |
bshum |
Limit sets I mean |
| 14:54 |
bshum |
In my experience, we always had specific circ mods to check for, or we'd just add them all to a limit set :) |
| 14:54 |
Bmagic |
I don't think it did, but I haven't gone back into git to see if those lines changed |
| 14:54 |
bshum |
Like saying you could only have X audio/visual items |
| 14:55 |
bshum |
So we'd have a series of circ mods to look for those item types anyways |
| 14:55 |
Bmagic |
right, that's typical |
| 15:47 |
|
khuckins joined #evergreen |
| 16:02 |
|
Christineb joined #evergreen |
| 16:47 |
|
mdriscoll left #evergreen |
| 17:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 17:02 |
|
sard joined #evergreen |
| 17:07 |
|
Glen joined #evergreen |
| 17:07 |
|
ejk joined #evergreen |
| 17:08 |
|
kipd joined #evergreen |
| 17:09 |
|
sard joined #evergreen |
| 17:09 |
|
mmorgan left #evergreen |
| 17:11 |
|
mllewellyn left #evergreen |
| 17:49 |
|
stephengwills joined #evergreen |
| 17:55 |
|
dbwells_ joined #evergreen |
| 17:55 |
|
remingtron_ joined #evergreen |
| 17:56 |
|
StomproJ joined #evergreen |
| 17:57 |
|
book`_ joined #evergreen |
| 18:00 |
|
rhamby joined #evergreen |
| 18:01 |
|
jyorio joined #evergreen |
| 18:02 |
|
ericar joined #evergreen |
| 18:02 |
|
felicia joined #evergreen |
| 18:08 |
|
_sandbergja joined #evergreen |
| 18:13 |
|
jeff___ joined #evergreen |
| 18:13 |
|
csharp_ joined #evergreen |
| 18:14 |
|
gmcharlt_ joined #evergreen |
| 18:14 |
|
genpaku_ joined #evergreen |
| 19:34 |
|
sandbergja joined #evergreen |
| 20:57 |
|
sandbergja joined #evergreen |
| 22:09 |
|
jamesrf joined #evergreen |
| 22:51 |
|
sandbergja joined #evergreen |
| 23:53 |
|
jamesrf joined #evergreen |
| 23:59 |
|
sandbergja joined #evergreen |
