| Time |
Nick |
Message |
| 03:10 |
|
beanjammin joined #evergreen |
| 03:42 |
|
jamesrf joined #evergreen |
| 05:00 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-03-04T04:57:50,470383187-0500 -0> |
| 07:05 |
|
JBoyer joined #evergreen |
| 07:13 |
|
agoben joined #evergreen |
| 07:14 |
|
rjackson_isl joined #evergreen |
| 07:35 |
|
bdljohn joined #evergreen |
| 07:56 |
|
littlet joined #evergreen |
| 08:07 |
|
Dyrcona joined #evergreen |
| 08:25 |
|
terran joined #evergreen |
| 08:48 |
|
jvwoolf joined #evergreen |
| 08:56 |
|
jvwoolf1 joined #evergreen |
| 09:13 |
Bmagic |
dbwells++ # releases |
| 09:19 |
|
collum joined #evergreen |
| 09:34 |
|
terran joined #evergreen |
| 09:44 |
|
littlet joined #evergreen |
| 09:44 |
terran |
Good morning Bug Squashers! Blake has set up some sandboxes here: https://docs.google.com/spreadsheets/d/1CLnGL1lzD3EVc3ppbjClR373U_0D3GZZ9vwRBzcRqII/edit#gid=1522803439 |
| 09:44 |
terran |
Bmagic++ |
| 09:45 |
terran |
And the tracking sheet has started already here: https://docs.google.com/spreadsheets/d/1x_sZcEaP62J42KcB03AUn1I1MSZQpPI5mF9r0Zrmhgo/edit#gid=0 |
| 09:46 |
dbwells |
terran++ Bmagic++ |
| 10:22 |
terran |
StomproJosh++ First patch submitted during Bug Squashing Week :) |
| 10:23 |
* StomproJosh |
did not realize it was bug squashing week, bonus. |
| 10:24 |
terran |
LOL |
| 10:28 |
Dyrcona |
:) |
| 10:30 |
* StomproJosh |
should have waited on the stuff I submitted last week for more karma, sigh. |
| 10:36 |
terran |
StomproJosh++ extra karma anyhoo |
| 10:38 |
jeff |
launchpad-- |
| 10:39 |
jeff |
terran: are you working on bug 1777677? you're currently assigned. |
| 10:39 |
pinesol |
Launchpad bug 1777677 in Evergreen "Test notification method" [Wishlist,New] https://launchpad.net/bugs/1777677 - Assigned to Terran McCanna (tmccanna) |
| 10:39 |
Dyrcona |
StomproJosh++ |
| 10:41 |
|
terran_ joined #evergreen |
| 10:41 |
terran_ |
@jeff - nope, sorry, forgot to take my name off |
| 10:41 |
pinesol |
terran_: Ba ba ba dook Dook DOOK! |
| 10:42 |
|
Christineb joined #evergreen |
| 10:53 |
|
yboston joined #evergreen |
| 11:03 |
JBoyer |
StomproJosh++ # Bug Squashing week and picking up the A/T aggregator bug I left unfinished. |
| 11:28 |
pinesol |
[evergreen|Josh Stompro] LP#1667497 - Define $params{depth} to avoid uninitialized warning. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3e3ec8e> |
| 11:29 |
* Dyrcona |
always gets nervous after pushing the "obvious" fix, even after exercising it with several different scenarios. |
| 11:30 |
* Dyrcona |
needs to stop worrying so much :) |
| 11:36 |
|
khuckins joined #evergreen |
| 11:43 |
Dyrcona |
How can I tell from the logs who is doing a bunch of ISBN searches that keep timing out? |
| 11:44 |
Dyrcona |
Oh, nice! We're being attacked. Someone is attempting SQL injection. |
| 11:48 |
|
beanjammin joined #evergreen |
| 12:00 |
littlet |
Anyone around that I can ask a newb Angular question? |
| 12:02 |
Dyrcona |
littlet: Just ask and if anyone can answer, they will. |
| 12:03 |
* Dyrcona |
uses iptable to combat "Bobby Tables." :) |
| 12:03 |
* Dyrcona |
can't type. :( |
| 12:04 |
littlet |
Thanks :) So, I'm trying to play around with the new Angular stuff, and just to change something simple, like a label or something to see the change show on my test server. But nothing I do changes anything--even if I change a label to say 'Cancel Reasons TESTING', it doesn't change. |
| 12:04 |
littlet |
I've cleared cache and cookies, and Googled, and I don't know if I'm just not Googling well... |
| 12:05 |
Dyrcona |
littlet: Did you just copy the file into place or edit in place, or did you the ng build --prod step, and then do make install? |
| 12:06 |
littlet |
I just edited in place |
| 12:09 |
Dyrcona |
I think you should edit it in the source code, then do the ng build --prod and make install steps. |
| 12:09 |
Dyrcona |
That should do the necessary cache-busting, but berick would know for sure. |
| 12:10 |
littlet |
I'll try that. Thanks so much! |
| 12:11 |
|
mmorgan joined #evergreen |
| 12:15 |
|
jihpringle joined #evergreen |
| 12:42 |
|
sandbergja joined #evergreen |
| 12:46 |
|
yboston joined #evergreen |
| 12:53 |
Bmagic |
Is there a reason that columns are not sortable on the holds shelf interface? |
| 12:55 |
Bmagic |
bug 1437104 ? |
| 12:55 |
pinesol |
Launchpad bug 1437104 in Evergreen "some columns are not sortable in the web staff client" [Medium,Confirmed] https://launchpad.net/bugs/1437104 |
| 13:00 |
Bmagic |
ah, it's this: bug 1712854 |
| 13:00 |
pinesol |
Launchpad bug 1712854 in Evergreen 3.1 "web client: Sorting for view record holds and holds shelf interfaces" [High,Confirmed] https://launchpad.net/bugs/1712854 |
| 13:02 |
Bmagic |
Is it possible to have the web client "remember" or default the checkbox for "Receipt upon payment" ? |
| 13:04 |
mmorgan |
Bmagic: I noticed that most if not all of the checkboxes in the web client are not "sticky" and they should be. |
| 13:04 |
* mmorgan |
was about to open a bug :) |
| 13:04 |
Bmagic |
Something new to me: XUL client had a tooltip on the item details interface. The tooltip when hovering over the total circs would display the total circs for ALL years. Leave it to the circ staff to find these things. Webby doesn't seem to have the same function |
| 13:05 |
jihpringle |
Bmagic: there's a bug for that one |
| 13:05 |
Bmagic |
oh! |
| 13:05 |
jeff |
bug 1743611 |
| 13:05 |
pinesol |
Launchpad bug 1743611 in Evergreen "Web Client: Lost Circ History by Year Info" [Medium,Confirmed] https://launchpad.net/bugs/1743611 |
| 13:05 |
Bmagic |
I searched for "tooltip" and didn't find it on launchapd |
| 13:05 |
Bmagic |
awesome |
| 13:06 |
Bmagic |
jeff++ jihpringle++ mmorgan++ |
| 13:07 |
Bmagic |
mmorgan: are you opening the bug about the sticky checkboxes? It sounds like you might have more of the language/examples? |
| 13:10 |
mmorgan |
Bmagic: I was planning on opening a bug for the checkboxes on Checkout (strict barcode) and Checkin (strict barcode, trim list (20 rows)). I wonder, though if there should be different bugs for the different screens? Or if it should be one bug that covers them all. |
| 13:10 |
jihpringle |
mmorgan: https://bugs.launchpad.net/evergreen/+bug/1777938 |
| 13:11 |
pinesol |
Launchpad bug 1777938 in Evergreen "Web Client - Trim List Checkbox is Not Sticky" [Undecided,New] |
| 13:11 |
mmorgan |
jihpringle++ |
| 13:11 |
Bmagic |
Ah! A trend seems to have been set |
| 13:11 |
Bmagic |
one per |
| 13:11 |
Bmagic |
I'll do the receipt upon payment |
| 13:11 |
jihpringle |
that bug also mentions strict barcode |
| 13:12 |
jeff |
tempting to rename/repurpose that bug to cover the two cases in it already plus others. |
| 13:12 |
jeff |
and then if there's reason for some to have their own bug at some point they could. |
| 13:12 |
Bmagic |
ok, less bugs to track is better |
| 13:12 |
Bmagic |
I'll tag mine on there then |
| 13:13 |
mmorgan |
Bmagic: What release are you on? I looked at Receipt On Payment in 3.2.4 and that one looks to be sticy there. |
| 13:14 |
Bmagic |
3.1.10 |
| 13:15 |
Bmagic |
I didn't try newer versions, so, yeah, it might already be fixed |
| 13:19 |
Bmagic |
Confirmed fixed in 3.2.3 |
| 13:27 |
mmorgan |
One less bug needing squashing! |
| 13:27 |
Bmagic |
Now that I'm on a roll: Record bucket searching by ISBN doesn't seem to use the same methods as an OPAC search. Specifically the 10/13 normalizer is not taken into account. Is that a bug? |
| 13:34 |
jihpringle |
Bmagic: my vote would be searching for the ISBN should work the same throughout the OPAC/staff client |
| 13:35 |
Bmagic |
yeah, agreed. Not sure what the underlying record bucket search uses, but based upon some test examples, it's not using the same methods as OPAC search |
| 13:36 |
* mmorgan |
would agree also, but wonders how it worked in the xul client |
| 13:40 |
mmorgan |
Bmagic: xul client record bucket search on isbn also does not employ the isbn 10/13 normalizer. So it was always broken :-( |
| 13:40 |
jihpringle |
I suspect buckets weren't the same as the OPAC in the xul client which might make this more of a new feature (change of existing behaviour) than a bug |
| 13:41 |
Bmagic |
I've never "liked" using the record bucket search, so I've not investigated much |
| 13:42 |
Bmagic |
New feature sounds like the right choice if a bug were created |
| 13:44 |
* mmorgan |
thinks it's worth a Launchpad entry |
| 14:19 |
terran_ |
littlet++ for tag-wrangling! |
| 14:25 |
Dyrcona |
jeff: Are you working on bug 1519879? |
| 14:25 |
pinesol |
Launchpad bug 1519879 in Evergreen "SIP Precedence Warning, possible logic issue" [Undecided,Confirmed] https://launchpad.net/bugs/1519879 - Assigned to Jeff Godin (jgodin) |
| 14:26 |
jeff |
I wasn't, but I can be. Dusting off memories... |
| 14:27 |
Dyrcona |
The fix is exactly as mentioned in the description, use && instead of and. I've verified it with a test script. |
| 14:28 |
Dyrcona |
As long as circ is not blocked, it always returns true the was it is written. |
| 14:28 |
Dyrcona |
So, I can post a branch if you don't have the time. |
| 14:29 |
jeff |
go ahead, if you beat me to the branch i can signoff/merge. i think there was something more subtle (and the reason i grabbed and was going to comment on it), but as you can see, there's no comment. |
| 14:30 |
Dyrcona |
Well, I'll take a look, but the return value thing is spot on. |
| 14:31 |
jeff |
sorry, berick. |
| 14:35 |
Dyrcona |
Hmm.... Looks like someone already fixed it. :) |
| 14:37 |
jeff |
fixed what? |
| 14:38 |
Dyrcona |
Bmagic fixed the precedence issue in Lp 1659928 |
| 14:38 |
pinesol |
Launchpad bug 1659928 in Evergreen "SIP is not respecting standing penalties for charge ok and hold ok" [Medium,Fix released] https://launchpad.net/bugs/1659928 |
| 14:41 |
jeff |
ah. |
| 14:42 |
berick |
jeff: hm? |
| 14:43 |
jeff |
berick: you didn't have voice. a few messages you sent this morning were only seen by myself. |
| 14:44 |
jeff |
I think (knock on wood) that it might be safe to do this: |
| 14:44 |
jeff |
And now voice doesn't matter, but we'll probably still maintain the list so that it's a simple mode change if it becomes a problem again. |
| 14:53 |
berick |
jeff: oh, thanks |
| 15:22 |
|
tlittle joined #evergreen |
| 15:27 |
|
_sandbergja joined #evergreen |
| 15:35 |
_sandbergja |
tlittle++ #bug-squashing week star! |
| 15:46 |
|
sandbergja_ joined #evergreen |
| 16:10 |
|
makohund joined #evergreen |
| 16:11 |
rhamby |
csharp: bshum: dyrcona: where can I request membership in the bug wrangling group on launchpad. I can't find the link for it. |
| 16:12 |
rhamby |
nevermind found it |
| 16:12 |
rhamby |
asking for help finding something publically increases my chances of seeing it by roughly 90% |
| 16:14 |
makohund |
I'm having a vandelay failure... unable to read MARC file in /tmp/blahblah.mrc... because it is never getting written/uploaded in the first place. Where to start? |
| 16:25 |
Dyrcona |
makohund: permissions? apache_run_user. apache logs. |
| 16:26 |
jeff |
makohund: i suggest changing to a different path, since /tmp is typically virtualized now. |
| 16:27 |
makohund |
Dyrcona: I've got Vandelay.pm open in one window, and apache & nginx logs in another, looking |
| 16:27 |
Dyrcona |
And, yeah, what jeff said.... "Thanks, systemd!" |
| 16:28 |
jeff |
makohund: it's defined in opensrf.xml, near a comment "temporary location for MARC import files" -- open-ils.vandelay/app_settings/databases i think |
| 16:28 |
jeff |
er, open-ils.vandelay/app_settings/databases/importer |
| 16:28 |
makohund |
jeff: configure a different path in opensrf.xml, and in eg_vhosts.conf? |
| 16:28 |
jeff |
makohund: which path in eg_vhosts.conf do you think needs to be adjusted? None come to mind in this context. |
| 16:30 |
makohund |
jeff: right, nevermind, just remembered seeing a location directive in there... but that's just calling the handler |
| 16:34 |
makohund |
jeff: found it in opensrf.xml, now... where to change it too... hmm... |
| 16:41 |
makohund |
jeff: boom. that was it, works now. thanks! |
| 16:43 |
jeff |
great! |
| 16:43 |
makohund |
add that to the "how to make EG work on debian buster" list |
| 16:45 |
makohund |
though I'm not sure I ever tried it back on jessie on this machine either, so it may have been broken all along |
| 16:53 |
|
Bmagic joined #evergreen |
| 16:56 |
|
mnsri_away joined #evergreen |
| 17:00 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-03-04T16:58:41,171347372-0500 -0> |
| 17:03 |
|
mmorgan left #evergreen |
| 17:39 |
makohund |
I'm not outta the woods yet... inspecting my import queue, none of the descriptive fields show anything at all (Title, Author, ISBN, etc). Even though the fields are there if I view MARC. (Or look at it in vandelay.queued_record, or vandelay.queued_bib_record.) And if I import the same file again, expecting matches to be found... nope. |
| 17:40 |
makohund |
I import the same test file on our production system... no such problems. Fields are fleshed out, second import matches on all records, etc. |
| 19:12 |
|
dickreckard joined #evergreen |
| 19:30 |
|
beanjammin joined #evergreen |
| 19:34 |
|
jvwoolf joined #evergreen |
| 19:39 |
|
jvwoolf left #evergreen |
| 19:53 |
makohund |
I've just confirmed that my import problem predates my buster upgrade test... I jumped back to a vm snapshot on old evergreen version on jessie... importing was fine. Jumped forward to stretch, and no import, until changing it from /tmp to somewhere else. Now records import, but no matching and no data in the fields on the inspect queue screen. Hmm. |
| 20:33 |
|
beanjammin joined #evergreen |
| 21:28 |
|
sandbergja joined #evergreen |
| 22:07 |
|
sandbergja joined #evergreen |
