Time |
Nick |
Message |
04:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
06:04 |
|
jamesrf joined #evergreen |
06:35 |
|
jamesrf joined #evergreen |
07:33 |
|
bdljohn joined #evergreen |
10:21 |
|
Christineb joined #evergreen |
10:50 |
csharp |
should reporter.simple_record have multiple rows per record? |
11:12 |
bshum |
csharp: Hmm, well reporter.simple_record is a view |
11:13 |
bshum |
That still doesn't sound good though |
11:15 |
csharp |
yeah, it's not |
11:15 |
csharp |
creating some havoc |
11:16 |
csharp |
I think there's a thinko somewhere that's not considering multiple values for single fields |
11:19 |
|
terran joined #evergreen |
11:30 |
csharp |
found it |
11:31 |
csharp |
LEFT JOIN metabib.full_rec pubdate ON r.id = pubdate.record AND (pubdate.tag = '260'::bpchar OR publisher.tag = '264'::bpchar AND publisher.ind2 = '1'::text) AND pubdate.subfield = 'c'::text |
11:31 |
csharp |
should be OR pubdate.tag = '264'::bpchar AND pubdate.ind2 = '1'::text |
11:31 |
csharp |
probably copy/paste-o |
11:36 |
bshum |
pretty old change for you and me csharp |
11:36 |
bshum |
git blame shows me cbee3dea52a for that changeset :) |
11:37 |
pinesol |
bshum: [evergreen|Chris Sharp] LP#1368314: Add RDA support to reporter.simple_record. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=cbee3de> |
11:37 |
bshum |
So I guess you guys finally got enough RDA records to notice a problem |
11:38 |
csharp |
cbee3dea |
11:38 |
pinesol |
csharp: [evergreen|Chris Sharp] LP#1368314: Add RDA support to reporter.simple_record. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=cbee3de> |
11:38 |
csharp |
and it's MY copy/paste-o! |
11:38 |
bshum |
The circle of life is complete :) |
11:38 |
csharp |
broken since 2014 |
11:38 |
csharp |
hehe |
11:40 |
bshum |
Easy fix |
11:41 |
bshum |
csharp++ |
11:50 |
bshum |
If you get around to making a fix and put it to working, I can push it on through for everybody |
11:51 |
bshum |
I have half the responsibility for pushing the original issue :) |
11:54 |
|
jamesrf joined #evergreen |
11:55 |
csharp |
bu 1812698 |
11:55 |
csharp |
bug 1812698 |
11:55 |
pinesol |
Launchpad bug 1812698 in Evergreen "reporter.simple_record mistakenly allows multiple/bogus values for pubdate" [High,New] https://launchpad.net/bugs/1812698 |
11:55 |
csharp |
bshum: ^^ |
11:55 |
csharp |
thanks! |
11:55 |
csharp |
bshum++ |
11:58 |
bshum |
Oh, good; rel_3_0 is EOL Jan 3, 2019. |
11:58 |
* bshum |
skips that one |
11:58 |
bshum |
Calling 1142 |
12:03 |
bshum |
Oops |
12:03 |
bshum |
Guess we need new LP milestones |
12:03 |
* bshum |
will make some and retarget that bug accordingly |
12:04 |
pinesol |
[evergreen|Chris Sharp] LP#1812698 - Fix broken pubdate display - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2eda2f5> |
12:04 |
pinesol |
[evergreen|Ben Shum] LP#1812698 - stamping upgrade script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ef866ff> |
12:04 |
* bshum |
will also edit the release dates for the downloads page to say Jan 2019 not 2018 |
12:04 |
bshum |
:D |
12:15 |
|
jihpringle joined #evergreen |
12:30 |
|
sandbergja joined #evergreen |
12:42 |
|
beanjammin joined #evergreen |
13:04 |
|
Adams_ joined #evergreen |
13:05 |
Adams_ |
Hi everyone, I was wondering with evergreen since its under the GPL license can I redistribute it commercially |
13:09 |
csharp |
Adams_: I'm going to refer you to https://www.gnu.org/licenses/gpl.html and the GNU project for that question |
13:11 |
csharp |
hmm - seems like my understanding was incorrect about the new rmsr stuff - it's using reporter.old_super_simple_record, not reporter.simple_record |
13:11 |
csharp |
and that's unfortunate because it appears that reporter.old_super_simple_record is based on MODS 3.3, which it not RDA-aware |
13:12 |
csharp |
so publisher info is not making it to the display |
13:12 |
csharp |
I guess we can tinker with config.metabib_fields and config.display_fields? |
13:12 |
* csharp |
wishes miker was around but, you know, holidays |
13:33 |
remingtron |
bshum: oops, sorry, I signed up for making the new milestones and didn't get to it. |
13:34 |
remingtron |
I'll work on pushing uncommitted bugs to the new milestone now. |
13:35 |
csharp |
found a bug in the fix for parent/guardian (bug 1714070) which is in "Fix Committed" status |
13:36 |
pinesol |
Launchpad bug 1714070 in Evergreen "Web Client: Parent/Guardian Field vs Secondary Identification" [Wishlist,Fix committed] https://launchpad.net/bugs/1714070 |
13:36 |
csharp |
is it more appropriate to file a new bug since that's been in master since November? |
13:39 |
* csharp |
assumes so and does it |
13:39 |
remingtron |
csharp: probably, especially since it's actually been released (and I'm going to mark it so right now) |
13:55 |
bshum |
csharp: remingtron: It's been in master, but we haven't released 3.3-beta1 yet. If it was me, I would just tack it onto the original bug and make sure it was followed up on |
13:55 |
bshum |
But your way works too |
13:55 |
bshum |
remingtron++ # bug wrangling, thanks |
13:56 |
bshum |
Since you already made a new bug csharp, no worries :) |
13:58 |
remingtron |
bshum: good point! we haven't released that fix yet. |
14:04 |
csharp |
good that this was caught before it was widely distributed |
14:52 |
|
bos20k joined #evergreen |
14:55 |
|
MOSES_ joined #evergreen |
15:21 |
|
dbwells joined #evergreen |
15:53 |
|
sandbergja joined #evergreen |
16:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
19:06 |
|
beanjammin joined #evergreen |
19:57 |
|
beanjammin joined #evergreen |
20:12 |
|
sandbergja joined #evergreen |