| Time |
Nick |
Message |
| 03:26 |
|
jamesrf joined #evergreen |
| 04:21 |
|
RBecker joined #evergreen |
| 07:03 |
|
agoben joined #evergreen |
| 07:27 |
|
bos20k joined #evergreen |
| 08:00 |
|
tlittle joined #evergreen |
| 08:15 |
|
Dyrcona joined #evergreen |
| 08:43 |
|
rjackson_isl joined #evergreen |
| 08:51 |
|
mmorgan joined #evergreen |
| 08:56 |
|
JBoyer joined #evergreen |
| 09:08 |
|
terran joined #evergreen |
| 09:13 |
|
yboston joined #evergreen |
| 09:33 |
|
aabbee joined #evergreen |
| 09:48 |
|
dkyle1 joined #evergreen |
| 10:01 |
csharp |
miker: I'm looking to put your branch for bug 1749475 on our 3.2.2 test server... |
| 10:02 |
pinesol |
Launchpad bug 1749475 in Evergreen "wishlist: Improved email and printing from the OPAC" [Wishlist,New] https://launchpad.net/bugs/1749475 |
| 10:02 |
csharp |
my concern is the change to the eg2 stuff - will that require a rebuild of the ang6 stuff? |
| 10:02 |
csharp |
git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=f882dae5c875ce11f8cdeff046ddb1928af7c4fd is the commit in question for others possibly interested |
| 10:03 |
csharp |
f882dae5 |
| 10:03 |
csharp |
oh - right it doesn't work for working branches |
| 10:07 |
berick |
csharp: server admin isn't exposed in the webstaff yet (related: bug 1811156) so you won't have to rebuild eg2 in this case |
| 10:07 |
pinesol |
Launchpad bug 1811156 in Evergreen "Port server admin page to Angular" [Undecided,New] https://launchpad.net/bugs/1811156 |
| 10:08 |
csharp |
oh - awesome |
| 10:08 |
csharp |
berick: thanks! |
| 10:09 |
berick |
confirmed, the same config options were added to the angjs server admin page |
| 10:10 |
csharp |
perfect - thanks |
| 10:18 |
|
jvwoolf joined #evergreen |
| 10:27 |
miker |
csharp: as berick said, it's not required but you should consider rebuilding it if you want to be able to get to the UI to configure formats |
| 10:31 |
|
sandbergja joined #evergreen |
| 10:31 |
|
Christineb joined #evergreen |
| 12:06 |
|
beanjammin joined #evergreen |
| 12:51 |
mmorgan |
We're not seeing the fix for bug 1699838 work as expected in the xul client on Release 3.1.8. Has anyone else encountered this? |
| 12:51 |
pinesol |
Launchpad bug 1699838 in Evergreen "OU setting needed for default pickup location for staff placed holds" [Medium,Fix released] https://launchpad.net/bugs/1699838 |
| 12:51 |
mmorgan |
We are still seeing the patron home library used as the pickup point in the xul client with the ou setting to use the workstation ou set to true. |
| 12:52 |
mmorgan |
Seems to work ok in the web client. |
| 12:53 |
bshum |
mmorgan: Does the patron have a preferred pickup library? |
| 12:54 |
csharp |
mmorgan: from my reading of the fix, it only touches web client files |
| 12:54 |
* bshum |
hadn't gotten that far yet |
| 12:58 |
bshum |
kmlussier opened a followup bug off that other bug |
| 12:58 |
bshum |
https://bugs.launchpad.net/evergreen/+bug/1759382 |
| 12:58 |
pinesol |
Launchpad bug 1759382 in Evergreen "Provide setting for honoring patron preferred pickup lib for staff placed holds" [Wishlist,New] |
| 12:59 |
bshum |
In that description, it says that the default will only be used if the patron has not selected a default pickup library |
| 12:59 |
bshum |
That's why I was asking if the patron had a value in their prefs |
| 13:00 |
mmorgan |
bshum: no value in the patron prefs, I did see that bug. |
| 13:01 |
bshum |
For staff placed holds, is this using the TPAC place hold? Or is this that other place hold in the XUL side? |
| 13:02 |
bshum |
If it's the latter, I agree with csharp that it doesn't seem any of the merged code seems to touch anything XUL related |
| 13:02 |
mmorgan |
csharp: Hmm. I'll look at that again, looked to my untrained eye like it was in the right places to apply to xul, too. |
| 13:02 |
* mmorgan |
thought it was using the TPAC place hold. |
| 13:02 |
bshum |
The XUL client has two place hold places if I remember right (and I might not, because it's been a few years) |
| 13:09 |
bshum |
Yeah the only place where "circ.staff_placed_holds_fallback_to_ws_ou" gets used is in that eframe.js from webstaff side. |
| 13:09 |
bshum |
I don't see it in the opac js file that was changed too |
| 13:09 |
bshum |
So that means it probably doesn't affect the behavior in TPAC place hold |
| 13:10 |
bshum |
Though now I'm not sure |
| 13:10 |
* bshum |
doesn't have any 3.1 systems to test with :D |
| 13:12 |
Dyrcona |
We reverted the patch that introduced the change in behavior to our XUL client when upgrading to 3.0. I'll see if I can find the commit. |
| 13:12 |
mmorgan |
We've been reverting the changes from bug 1167541 for the past couple releases, by just commenting out the changes to eframe.js and staff.js. But those changes have, well, changed. |
| 13:12 |
pinesol |
Launchpad bug 1167541 in Evergreen 2.11 "Pickup library defaults to Home OU of staff, instead of patron when placing holds" [Medium,Fix released] https://launchpad.net/bugs/1167541 |
| 13:20 |
Dyrcona |
mmorgan: https://pastebin.com/dY1zMmnG |
| 13:22 |
mmorgan |
Dyrcona++ |
| 13:22 |
mmorgan |
Thanks!! I'll give it a try. |
| 13:23 |
Dyrcona |
That change requires that you build a custom client and that staff use it. The change is in the chrome, i.e. the part that gets bundled into the locally installed client. |
| 13:23 |
|
jvwoolf joined #evergreen |
| 13:24 |
mmorgan |
Ok, thanks! |
| 13:27 |
|
BAMkubasa joined #evergreen |
| 13:36 |
|
jihpringle joined #evergreen |
| 13:58 |
|
khuckins joined #evergreen |
| 14:55 |
|
RMiller joined #evergreen |
| 14:56 |
|
Christineb joined #evergreen |
| 15:02 |
RMiller |
Is there some sorcery involved in getting the default Vandelay circulation modifier to actually apply that circulation modifier when bulk importing copies? |
| 15:03 |
|
mmorgan1 joined #evergreen |
| 15:12 |
|
khuckins_ joined #evergreen |
| 15:13 |
|
jvwoolf joined #evergreen |
| 15:30 |
csharp |
Dyrcona: I had a slightly different take on the fix to bug 1803734: https://gist.github.com/chrissharp123/6bdb800ed329dda418502e7cd0d2914b - don't have a great handle on JSON query though, so the -and might not be necessary |
| 15:30 |
pinesol |
Launchpad bug 1803734 in Evergreen 3.2 "edi_order_pusher.pl blindly pushes ancient orders" [Critical,Confirmed] https://launchpad.net/bugs/1803734 |
| 16:03 |
Dyrcona |
csharp: Feel free to share it. |
| 16:04 |
Dyrcona |
With JSON queries "and" is almost never necessary, it's the default. |
| 16:14 |
Dyrcona |
csharp: Your change and mine are identical in functionality, just different in the approach. |
| 16:38 |
|
bdljohn joined #evergreen |
| 16:58 |
|
mmorgan1 left #evergreen |
| 17:22 |
|
jvwoolf left #evergreen |
| 17:38 |
csharp |
Dyrcona: cool - thanks for the clarification! |
| 19:31 |
* Dyrcona |
decides it is time to leave the channel. |
