| Time |
Nick |
Message |
| 06:59 |
|
JBoyer joined #evergreen |
| 07:05 |
|
agoben joined #evergreen |
| 07:06 |
|
rjackson_isl joined #evergreen |
| 07:27 |
|
bdljohn joined #evergreen |
| 08:21 |
|
bos20k joined #evergreen |
| 08:43 |
|
mmorgan joined #evergreen |
| 09:32 |
|
tlittle joined #evergreen |
| 09:43 |
|
yboston joined #evergreen |
| 09:47 |
|
jvwoolf joined #evergreen |
| 10:02 |
|
mmorgan1 joined #evergreen |
| 10:34 |
|
mmorgan joined #evergreen |
| 10:43 |
|
khuckins_ joined #evergreen |
| 10:54 |
|
stephengwills joined #evergreen |
| 11:19 |
csharp |
@band add The Org Tree |
| 11:19 |
pinesol |
csharp: Band 'The Org Tree' added to list |
| 11:19 |
mmorgan |
:) |
| 11:54 |
JBoyer |
The Org Tree sounds like a jam band that might just through an 11 hour concert one weekend and forget to sell tickets. Everyone still has a good time, friendships are born and die, and somehow there are 3-5 different types of food carts that pop up. No one remembers how the music compares to the studio versions. |
| 12:01 |
Bmagic |
Since when does the patron barcode UI box remove spaces inside the barcode? I remember the head/trailing space removal but I don't remember it removing the spaces inside the barcode |
| 12:04 |
JBoyer |
Bmagic, perhaps an over-correction to the web client when it didn't remove any while the xul client trimmed the beginning and end? |
| 12:05 |
Bmagic |
yeah, that's what I am seeing |
| 12:05 |
mmorgan |
Bmagic: I remembered a bug about this issue |
| 12:05 |
Bmagic |
I found this one: bug 1332651 |
| 12:06 |
pinesol |
Launchpad bug 1332651 in Evergreen "Screens are inconsistent when there is a space within the barcode of items or patrons" [Undecided,Confirmed] https://launchpad.net/bugs/1332651 |
| 12:06 |
Bmagic |
but that's not exactly the issue |
| 12:06 |
mmorgan |
There's also lp 1692986 which says fix released |
| 12:06 |
pinesol |
Launchpad bug 1692986 in Evergreen "Web Client checkout trims spaces from patron barcodes differently than xul client checkout" [Medium,Fix released] https://launchpad.net/bugs/1692986 |
| 12:07 |
Bmagic |
only for EG > 2.12.6 ? |
| 12:08 |
Bmagic |
not rel_3_0 or rel_3_1 or rel_3_2 ? |
| 12:08 |
mmorgan |
It sounds like the behavior you describe is the fixed behavior. |
| 12:09 |
* mmorgan |
cranks up xul client |
| 12:09 |
Bmagic |
args.barcode = args.barcode.replace(/\s/g,''); seems like it would remove spaces in the middle |
| 12:09 |
JBoyer |
It would |
| 12:10 |
Bmagic |
well, there we have it, the code is doing it on purpose as per this patch |
| 12:10 |
mmorgan |
Bmagic: Right, because that's what xul did. |
| 12:11 |
Bmagic |
xul removed spaces in the middle? |
| 12:11 |
JBoyer |
I imagine the xul client did a /^\s//g and /\s$//g to deal with spaces. |
| 12:11 |
* mmorgan |
nods |
| 12:11 |
mmorgan |
Yes, xul removed all spaces in the patron barcode at checkout |
| 12:11 |
Bmagic |
that's news to me. I thought XUL was strictly head/trailing spaces |
| 12:12 |
* mmorgan |
just confirmed in 3.0.9 xul client |
| 12:14 |
Bmagic |
wow, mind blown |
| 12:14 |
JBoyer |
Looks like the xul client just calls trim(), I would also expect that to leave internal spaces alone. |
| 12:14 |
JBoyer |
But I haven't tested it, so mmorgan++ for actually doing it. :) |
| 12:15 |
|
jihpringle joined #evergreen |
| 12:15 |
Bmagic |
I'm working on getting it worked out on xul, hunting for an example barcode to use though :) |
| 12:16 |
Bmagic |
my regular expression may not be right [^\s]*?\s*?[^\s]*$ |
| 12:16 |
JBoyer |
What are you trying to do with that? |
| 12:16 |
Bmagic |
find a barcode with a space in the middle |
| 12:16 |
JBoyer |
You can also do this: select * from actor.card where barcode like '% %' limit 2; |
| 12:17 |
Bmagic |
:) |
| 12:17 |
JBoyer |
I initially thought that regexp was headed for the client and was going to have some opinions. ;) |
| 12:17 |
Bmagic |
that doesn't ensure that the space is in the middle though :) |
| 12:17 |
JBoyer |
true. |
| 12:17 |
Bmagic |
found one! and yep confirmed |
| 12:18 |
Bmagic |
"GIVE TO SUSAN" became "GIVETOSUSAN" |
| 12:18 |
Bmagic |
one of our proudest barcodes btw |
| 12:18 |
JBoyer |
ITSAPRETIGEOUSAWARD |
| 12:19 |
* Bmagic |
laughs |
| 12:19 |
Bmagic |
well, sheesh, it seems that Evergreen is now a no-internal-space-barcode ILS |
| 12:19 |
Bmagic |
which means that the bug I linked needs to be wrapped up |
| 13:16 |
* jeff |
looks at long-outstanding "make barcode transforms configurable (though try not to be turing complete)" todo list item |
| 13:18 |
|
bdljohn joined #evergreen |
| 13:24 |
JBoyer |
"Pray, Mr. Babbage, if you put into the machine wrong barcodes, will the right barcodes come out?" |
| 13:33 |
|
yboston joined #evergreen |
| 13:33 |
jonadab |
Hehe. |
| 13:33 |
jonadab |
JBoyer++ |
| 13:34 |
jeff |
open-ils.barcode-transform: What is this? |
| 13:35 |
jeff |
open-ils.barcode-transform: What is this, please? |
| 13:35 |
jeff |
... |
| 13:49 |
* jeff |
goes looking at an old bug, which links to an old irc conversation, which links to... at least one 404 paste. :P |
| 13:53 |
jeff |
then later on in that conversation, another paste that is not 404, but is spam. |
| 14:24 |
|
bdljohn joined #evergreen |
| 15:24 |
|
bdljohn joined #evergreen |
| 15:33 |
pinesol |
[evergreen|Jason Boyer] LP1807398: Add workstation to marc_stream_importer - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=60492d0> |
| 15:33 |
pinesol |
[evergreen|Bill Erickson] LP#1807398 marc_stream/oils_header auth repairs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=209dd23> |
| 15:40 |
jonadab |
Too bad launch pad doesn't make local archives of linked-to pages. |
| 15:41 |
jonadab |
Although, wait, if it went through an IRC conversation intermediate, than that wouldn't have helped anyway in this case. |
| 15:45 |
|
khuckins joined #evergreen |
| 17:01 |
|
mmorgan left #evergreen |
| 17:03 |
|
jvwoolf left #evergreen |
| 17:07 |
|
yboston joined #evergreen |
| 17:19 |
|
khuckins_ joined #evergreen |
| 18:08 |
|
bdljohn joined #evergreen |
| 18:10 |
|
khuckins joined #evergreen |
| 18:20 |
|
khuckins joined #evergreen |
| 18:46 |
|
beanjammin joined #evergreen |
| 19:19 |
|
beanjammin joined #evergreen |
