| Time |
Nick |
Message |
| 00:01 |
|
bshum joined #evergreen |
| 07:33 |
|
bdljohn joined #evergreen |
| 08:53 |
|
collum joined #evergreen |
| 09:01 |
|
Dyrcona joined #evergreen |
| 10:53 |
|
khuckins joined #evergreen |
| 11:20 |
|
khuckins joined #evergreen |
| 11:35 |
|
remingtron joined #evergreen |
| 12:08 |
csharp |
cad66c01 |
| 12:08 |
csharp |
pinesol: awake? |
| 12:08 |
pinesol |
csharp: pretty sure there's already a bug report about that. |
| 12:25 |
miker |
grabbing 1134 |
| 12:28 |
pinesol |
[evergreen|Dan Wells] LP#1773479 Show Located URIs in browse - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=bfbd4ee> |
| 12:28 |
pinesol |
[evergreen|Mike Rylander] Stamping upgrade script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a52c09e> |
| 12:34 |
jeff |
dbwells++ miker++ |
| 12:34 |
csharp |
after applying e-resource visibility fixes atop 3.0.2(ish), I'm seeing the following error in our logs: |
| 12:34 |
csharp |
ERROR: function search.calculate_visibility_attribute_test(unknown, integer, boolean) does not exist |
| 12:34 |
csharp |
LINE 13: ...visibility_attribute_test('circ_lib','{7}',FALSE),search.cal... |
| 12:35 |
miker |
csharp: yeah, the fix in 3.0 will be different in detail |
| 12:35 |
csharp |
oh - so it's a known bug? |
| 12:36 |
miker |
I don't know about 3.0 re that bug |
| 12:36 |
miker |
but I know the 3.0 vis tests are different than 3.1+ |
| 12:37 |
csharp |
I'm trying to nail down the parameters of search that cause the bug - most searches appear to work fine |
| 12:37 |
miker |
csharp: you mean LP#1773479? that's specifically about browse, fwiw |
| 12:38 |
jeff |
oh, that reminds me that i need to turn up some logs and look into the case where locations()-style search limiting in a filter group entry was seeming to be ignored. |
| 12:39 |
csharp |
miker: not that, no - I think the coincidence of your commit and my complaint may have confused both of us :-) |
| 12:40 |
miker |
heh :) |
| 12:40 |
csharp |
jeff: one of my log messages (so far) has been a search limited to a copy location |
| 12:45 |
csharp |
CALL: open-ils.search open-ils.search.biblio.multiclass.query HASH(0x645c2c0), kaolin locations(1773) site(OCRL-DUBLN) depth(2), 1 |
| 12:45 |
csharp |
CALL: open-ils.search open-ils.search.biblio.multiclass.query HASH(0x65820d0), watkins georgia locations(1773) site(OCRL-DUBLN) depth(2), 1 |
| 12:47 |
csharp |
yeah, each of the errors so far include filters for copy locations |
| 12:54 |
csharp |
...and, more tickets about this coming in |
| 12:54 |
csharp |
fun! |
| 13:01 |
miker |
csharp: you have the top 2 commits from http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1723977-staff-visibility-test-squash-upgrade right? |
| 13:01 |
|
beanjammin joined #evergreen |
| 13:05 |
csharp |
select * from search.calculate_visibility_attribute_test('location',3391,FALSE); is what's eliciting the error |
| 13:05 |
csharp |
apparently it's not seeing 'location' as text |
| 13:12 |
csharp |
miker: hmm - possibly not |
| 13:12 |
csharp |
looks like some of that code is there and some not - maybe a bad conflict resolution |
| 13:22 |
csharp |
rats - still seeing the problem after installing the upgrade query parser file - (DB change was already in place) |
| 13:22 |
csharp |
upgraded* |
| 13:23 |
csharp |
still showing search.calculate_visibility_attribute_test('location',3391,FALSE) as an example of the problem - PG is not seeing the first parameter as "text" |
| 13:24 |
csharp |
actually this seems to be the issue |
| 13:25 |
csharp |
if I do 'select * from search.calculate_visibility_attribute_test('location', 3391, FALSE);' I see the issue |
| 13:25 |
csharp |
if I change that to 'select * from search.calculate_visibility_attribute_test('location','{3391}',FALSE);', it works |
| 13:26 |
csharp |
why would postgresql act like that? |
| 13:28 |
csharp |
here's another failing one |
| 13:28 |
csharp |
c_attr AS (SELECT (ARRAY_TO_STRING(ARRAY[search.calculate_visibility_attribute_test('circ_lib','{164}',FALSE),search.calculate_visibility_attribute_test('location',3009,7870,8856,FALSE)],'&'))::query_int AS vis_test FROM asset.patron_default_visibility_mask() x) |
| 13:28 |
csharp |
so in that case the user selected multiple locations, so that makes more sense that PG would see it as search.calculate_visibility_attribute_test(unknown, integer, integer, integer, boolean) |
| 13:29 |
miker |
the second param is supposed to be an int array, not a bare int, it would seem |
| 13:29 |
csharp |
yeah |
| 13:29 |
miker |
that includes when there's only one in the list |
| 13:29 |
csharp |
makes sense now |
| 13:29 |
csharp |
I was seeing JSON |
| 13:30 |
csharp |
yeah, manually wrapping them in curly braces in quotes solves it |
| 13:31 |
csharp |
now just need to know what in the front end passes it down that way |
| 13:32 |
miker |
that is almost certainly generated by QP |
| 13:34 |
miker |
csharp: you're sure you have df6e607db567ecc5270305d351f034176c30c52e in place? |
| 13:34 |
pinesol |
miker: [evergreen|Jason Boyer] LP1744489: Location Search Limiter - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=df6e607> |
| 13:34 |
miker |
and you've restarted open-ils.storage since putting that in place? |
| 13:35 |
dbwells |
that commit is a likely suspect indeed |
| 13:35 |
miker |
looks like that was post-3.0.3, based on the preceding commits |
| 13:37 |
csharp |
well, that certainly looks like the problem - searching QP.pm now |
| 13:38 |
csharp |
nope - I don't have that |
| 13:39 |
csharp |
and, I was looking at the wrong QP file ;_0 |
| 13:39 |
csharp |
:-) |
| 13:40 |
csharp |
miker++ #thanks for helping me troubleshoot |
| 13:40 |
csharp |
I have a feeling this will solve the problem |
| 13:41 |
csharp |
so... this shows the risk of cherry-picking backports instead of just upgrading to point releases, kids |
| 13:47 |
jeff |
...if the choir would please turn to page df6e607 in their songbooks... |
| 13:47 |
pinesol |
jeff: [evergreen|Jason Boyer] LP1744489: Location Search Limiter - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=df6e607> |
| 13:50 |
csharp |
jeff++ |
| 13:51 |
* csharp |
sings the tenor part for the old timey classic "Location Search Limiter" |
| 13:52 |
csharp |
all looks good here after applying the patch |
| 13:59 |
|
eady joined #evergreen |
| 14:11 |
|
khuckins_ joined #evergreen |
| 15:22 |
|
khuckins_ joined #evergreen |
| 15:38 |
jeff |
Anyone here know if we've ever considered including LP numbers in release notes? |
| 15:38 |
Bmagic |
I'm in favor |
| 15:39 |
jeff |
Seems it might help in cases where a bug fix is listed as "Fixes bugs that caused activity metric data when performing searches." |
| 15:39 |
jeff |
I think that might be referring to bug 1781480, but I'm not certain. |
| 15:40 |
pinesol |
Launchpad bug 1781480 in Evergreen "Activity metric data isn't always retrieved as expected for searches" [Medium,Fix released] https://launchpad.net/bugs/1781480 |
| 15:40 |
jeff |
Actually, looking at the bug and not just the single commit I was looking at, I'm pretty sure that's it. |
| 16:35 |
csharp |
I think that would be super helpful |
| 16:35 |
csharp |
even in parens after the release notes heading |
| 17:08 |
|
khuckins joined #evergreen |
| 19:15 |
|
beanjammin joined #evergreen |
| 20:24 |
|
beanjammin joined #evergreen |
