Time |
Nick |
Message |
00:16 |
|
sandbergja joined #evergreen |
01:35 |
|
bwicksall_ joined #evergreen |
07:51 |
|
Dyrcona joined #evergreen |
09:50 |
|
jvwoolf joined #evergreen |
12:21 |
csharp |
curious about how others are setting the "history.circ.retention_count" global flag - PINES currently has this set at 3, but I'm starting to think it should be 0 |
12:28 |
Dyrcona |
There was some part of XUL that broke with that setting less than 2, IIRC. Not sure about the browser client. |
12:29 |
csharp |
Dyrcona: setting it to 2 would definitely help :-) |
12:31 |
Dyrcona |
And, we, apparently haven't set it. Perhaps, I was thinking of a different setting? |
12:32 |
Dyrcona |
Oh, right global flag.... Ours is 1. |
12:33 |
* Dyrcona |
can't comma today. |
12:33 |
csharp |
ah - well 1 is even better |
12:33 |
csharp |
thanks! |
12:33 |
Dyrcona |
Yw. |
12:33 |
Dyrcona |
Too late form comma/coma joke... |
12:34 |
Dyrcona |
Oi! I should just give up.... "form" should be "for my" |
12:35 |
Dyrcona |
There's an interface in XUL that shows the last two circs on a copy. I think that can get weird if you set that flag to 0, and mybe 1, too. I forget the details. tsbere would remember, but he's not around here any more. |
13:01 |
Dyrcona |
I'm wondering how lines like this are working in Open-ILS/web/js/ui/default/staff/circ/services/circ.js: copy.status().id() |
13:01 |
Dyrcona |
When I try that, I get status is not a function. I had to do copy['status.id']. |
13:06 |
aabbee |
where do you have to use copy['status.id']? is copy.status fleshed? |
13:08 |
Dyrcona |
aabbee: I really don't know. When I tried this first back in July/August, I think there there was a bug. When I tried fleshing copy status, it didn't work. |
13:08 |
Dyrcona |
I'm rewriting the code so I don't have to worry about it. What I was trying didn't work any how because asynchronous promises. |
13:10 |
Dyrcona |
The busted code is here if you want to look: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/wip-mark-item-discard |
13:10 |
Dyrcona |
I wouldn't base anything on that because I rebase it quite frequently. |
13:11 |
Dyrcona |
Guess it was 2 September when I tried not fleshing copy status: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=d5e90b08b745ae8497ac74daa5741c4d359ae012 |
13:12 |
* Dyrcona |
did an AngularJS tutorial about 4 years ago and hasn't done anything with it since. |
13:12 |
aabbee |
if i were to guess (and it is just a guess), copy.status().id() works when copy.status is fleshed, so the 'status' key is defined on the copy object (as a function that returns the status object). but if the status isn't there then you're stuck with the 'status.id' key on the copy object which is just an int, so you wouldn't have, for example, 'status.name' |
13:13 |
aabbee |
@hate javascript |
13:13 |
pinesol |
aabbee: The operation succeeded. aabbee hates javascript. |
13:13 |
Dyrcona |
Right, I kind of figured that, but the attempt to flesh copy status wasn't working. |
13:13 |
Dyrcona |
@hates |
13:13 |
pinesol |
Dyrcona hates MARC; Launchpad Search; and printing |
13:14 |
Dyrcona |
@loathe JavaScript |
13:14 |
pinesol |
Dyrcona: Try running autogen |
13:14 |
Dyrcona |
:) |
13:14 |
Dyrcona |
@hate JavaScript |
13:14 |
pinesol |
Dyrcona: The operation succeeded. Dyrcona hates JavaScript. |
13:14 |
aabbee |
i played with some of this, but don't remember well enough how fleshing can fail. i seem to have misplaced my test server.. |
13:14 |
Dyrcona |
Also, what I've learned and played with in AngularJS is a lot simpler than what goes on in the browser client. |
13:15 |
aabbee |
i've been working on understanding angular6. i wouldn't call it simple. |
13:16 |
Dyrcona |
I did a plunk to figure out how to use $q.defer() and tried that but it didn't work in the context of Evergreen. Looking at the other uses of defer in the current browser client leaves me scratching my head. |
13:17 |
Dyrcona |
So, today, I'm trying to reorganize eveything so that it works with then() on promises. I think I'm gonna end up with a big mess... |
13:18 |
aabbee |
good luck with that! :-) |
13:18 |
* Dyrcona |
should have definitely voted "No" at the Grand Rapids hack-away. |
13:19 |
Dyrcona |
You want to hear something funny? Douglas Crockford muted me on Google+ because I said his book, "JavaSCript the Good Parts" was proof that JavaScript sucks. |
13:20 |
aabbee |
ha! and they said google+ wasn't good for anything. |
13:21 |
Dyrcona |
My argument was that his book is 174 pages and JavaScript: the Definitive Guide is 1096 pages, so 85% of JavaScript is useless. :) |
13:22 |
aabbee |
honestly, i'm surprised he'd disagree with you. his book calls out several language features as mistakes. |
13:22 |
Dyrcona |
Anyway, enough complaining. I'm trying to figure if I need a custom dialog or if I can do what I want with egConfirmDialog. I'm probably doing it wrong. |
13:24 |
Dyrcona |
I'm also looking at what I can do with a custom dialog, and I'm probably OK with egConfirmDialog. My logic will be just as twisted either way. |
13:25 |
Dyrcona |
@loves |
13:25 |
pinesol |
Dyrcona loves git; sed; OpenBSD; gnu/emacs; git tag; and git-quickpick |
13:25 |
Dyrcona |
@help love |
13:25 |
pinesol |
Dyrcona: (love <thing>) -- Declare your love for <thing> |
13:31 |
Dyrcona |
switches within switches... |
13:40 |
Dyrcona |
As for Angular 6, I haven't really started looking at it, yet. |
13:51 |
|
jvwoolf joined #evergreen |
14:02 |
Dyrcona |
Ah ha! Brilliant... Fall-through FTW! |
14:10 |
Dyrcona |
Hmm. Maybe that's not so great after all? |
14:11 |
Dyrcona |
If I do manage to successfully flesh copy status, is the name field translated? |
14:15 |
Dyrcona |
Ok. So, I think my flesh_copy_status wasn't working because it was asynchronous, so happening after the rest of the code ran. JBoyer was right about asynchronous code being hard. :) |
14:18 |
Dyrcona |
Nah. I'm lost, again. :( |
14:47 |
Dyrcona |
Yeahp. I get this when I try to flesh copy status: TypeError: copy.status is not a function at circ.js:706. That line 706 is where it tries set the copy status: copy.status(egCore.env.ccs.map[copy.status()]); |
14:49 |
Dyrcona |
I swear kmlussier opened a Lp bug on it or mentioned it in channel and berick "fixed" it, but I must be hallucinating again. |
14:51 |
Dyrcona |
For the sake of discussion, I'll leave the link to the commit here so someone can tell me what I'm doing wrong: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=7248fc97f04c645409c6c244b1de5cc1937fa267 |
14:58 |
Dyrcona |
I should probably add that I'm trying this code from Item Status. I retrieve a copy, then try my new Actions command on it. |
14:59 |
* Dyrcona |
takes a break. |
16:16 |
|
jvwoolf joined #evergreen |
18:13 |
Dyrcona |
@dunno |
18:13 |
pinesol |
Dyrcona: Yeah, well, you know, that's just, like, your opinion, man. |
18:13 |
Dyrcona |
@dunno get 5 |
18:13 |
pinesol |
Dyrcona: Dunno #5: "Beyond here be dragons." (added by Dyrcona at 02:46 PM, July 02, 2012) |
18:15 |
Dyrcona |
bug 924952 |
18:15 |
pinesol |
Launchpad bug 924952 in Evergreen "Acquisitions: Order record loads fail when there is a null value in a holdings subfield" [High,Confirmed] https://launchpad.net/bugs/924952 |
18:16 |
* Dyrcona |
is showing IRC to someone. Don't mind the noise. |
21:46 |
|
Dyrcona joined #evergreen |
21:47 |
Dyrcona |
Just popped in to say that I'm still not getting anywhere. |
21:51 |
Dyrcona |
Whoa! I finally got something simple to work. |
21:58 |
Dyrcona |
Oh. This is gonna get ugly. |
22:19 |
Dyrcona |
And, the rest of that ended up being a dead end.... |
23:15 |
|
beanjammin joined #evergreen |