| Time |
Nick |
Message |
| 07:18 |
|
We joined #evergreen |
| 07:44 |
|
rlefaive joined #evergreen |
| 08:08 |
|
A_D9 joined #evergreen |
| 08:21 |
|
yboston joined #evergreen |
| 08:42 |
|
TriJetScud6 joined #evergreen |
| 09:20 |
|
Guest49956 joined #evergreen |
| 09:38 |
|
PityDaFool joined #evergreen |
| 09:38 |
|
Venusaur4 joined #evergreen |
| 09:43 |
|
Zimmedon21 joined #evergreen |
| 10:33 |
|
Guest83575 joined #evergreen |
| 11:27 |
|
stephengwills joined #evergreen |
| 11:35 |
|
surfist27 joined #evergreen |
| 12:25 |
|
HackMaster6 joined #evergreen |
| 15:10 |
|
ejk joined #evergreen |
| 15:10 |
|
Glen joined #evergreen |
| 15:11 |
|
eby joined #evergreen |
| 15:13 |
|
eby joined #evergreen |
| 19:21 |
|
arahael14 joined #evergreen |
| 21:12 |
|
rogue28 joined #evergreen |
| 22:22 |
asjoyner |
tonights fun adventure: I created a catalog record. I attempted to add a copy (Add Copies) of that, which opens a new window where I can enter a barcode number, but Save and Exit does nothing... attempting to exit the window warns me things won't be saved. |
| 22:23 |
asjoyner |
digging around in the logs, I find /openils/var/log/open-ils.cat_stderr.log contains Caught error from 'run' method: Can't call method "isdeleted" on unblessed reference at /usr/local/share/perl/5.24.1/OpenILS/Application/Cat.pm line 1185. |
| 22:27 |
asjoyner |
grubbing around in Cat.pm, it seems to fail to create the volume at line 1174, but it misinterprets the return value of create_volume() so it does not return the error |
| 22:28 |
asjoyner |
this is somewhat understandable, as create_volume() seems to be very inconsistent about what it stuffs into return... sometimes the first thing returned is an error, sometimes a volume... |
| 22:36 |
asjoyner |
the reason volume creation is failing seems to be that my org_cannot_have_vols(), presumably because I haven't bothered to change the default organization setup and CONS can't own a volume |
| 22:36 |
asjoyner |
so the punchline is I'm holding it wrong, but by doing so it seems to highlight that the error handling in this part of the code is suboptimal |
| 22:40 |
asjoyner |
I took a stab at cleaning up create_volume() in this commit to my fork: https://github.com/asjoyner/Evergreen/commit/7930bec4f1c8ac50fb23470755ebcf3d8510687a |
| 22:41 |
asjoyner |
Cat.pm now does not crash, correctly interprets the event in the return value of create_volume, and exits early. Unfortunately, the client interprets this as "Success!" |
| 22:42 |
asjoyner |
I haven't yet dug into the error handling in the web staff client to understand why it doesn't somehow present that event to the user |
| 22:57 |
|
AlexZ19 joined #evergreen |
