Evergreen ILS Website

IRC log for #evergreen, 2018-08-22

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
02:41 fsamareanu10 joined #evergreen
04:26 obserd joined #evergreen
06:31 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:03 agoben joined #evergreen
07:26 rjackson_isl joined #evergreen
07:35 bdljohn joined #evergreen
07:53 theWhisper_ joined #evergreen
07:56 littlet joined #evergreen
08:22 Dyrcona joined #evergreen
08:33 agoben joined #evergreen
08:37 mmorgan joined #evergreen
09:03 bos20k joined #evergreen
09:04 csharp mornin' all.  Cutoff for additions to 3.0 and 3.1 releases is 2:00 p.m. today.  As you were.
09:05 * csharp starts looking for signed off bugfixes himself
09:06 * Dyrcona was thinking of doing that very thing before you mentioned the cutoff.
09:08 lsach joined #evergreen
09:10 csharp hmm - I'm interested in getting berick's fix for bug 1774448 in, but I have no idea how to test it without just throwing it into production :-/
09:10 pinesol Launchpad bug 1774448 in Evergreen 3.0 "web staff client can spam open-ils.auth.session.retrieve requests" [Undecided,Confirmed] https://launchpad.net/bugs/1774448
09:12 JBoyer speaking of testing things, bug 1733590 just got a fresh branch. (people have Strong Feelings about only printing what they've selected from Items Out)
09:12 pinesol Launchpad bug 1733590 in Evergreen "Web Client: Print Item Receipt not selective" [Medium,Confirmed] https://launchpad.net/bugs/1733590
09:13 * Dyrcona tests Lp 1743801
09:13 pinesol Launchpad bug 1743801 in Evergreen 3.0 "web client: item status list view display issues" [High,Confirmed] https://launchpad.net/bugs/1743801 - Assigned to Jason Stephenson (jstephenson)
09:13 csharp JBoyer: oooh - I'll see if we have time to test it today
09:15 JBoyer csharp, and I think for the one you're looking at, I think it can be tested by setting an absurd value for the login timeout pre-patch, watch the browser just flood your system with session retrieve calls, and then apply the patch and see if the number drops to a reasonable level. (and that you can still do things, etc.
09:15 JBoyer I'll try to poke at that one.
09:16 Dyrcona JBoyer: By "absurd value" you mean an absurdly low value, right?
09:16 Dyrcona Like 5 seconds or something dumb like that?
09:18 JBoyer Actually I think it would be best to test it 2 ways, something like 500ms and then (32 bit) INT_MAX + 500. Those should both call it excessively, and post-patch both should be set to the new minimum of 60000ms
09:18 Dyrcona A'ight.....
09:18 JBoyer I don't know who is just typing 20 digit numbers into the LSE for their auth timeouts, but it sounds like it must have happened at least once.
09:19 Dyrcona Well, if time permits, I can give that one a whirl unless someone else beats me to it.
09:19 JBoyer Dyrcona++
09:19 Dyrcona I'm going for the "High" priority bug, first.
09:21 yboston joined #evergreen
09:24 csharp our libraries are known for having stupid-high timeouts trying to get around an authtoken cache miss issue we had c.2012
09:26 aabbee joined #evergreen
09:33 csharp JBoyer: your items out patch works for me - I think I'll give Terran a chance to poke before I call it done though
09:33 csharp JBoyer++
09:36 * csharp hopes we can get away from "compendium" bugs like 1772053
09:37 csharp bug 1772053, even
09:37 pinesol Launchpad bug 1772053 in Evergreen 3.0 "Web Client: Print Templates - Missing/Problem Fields" [Undecided,Confirmed] https://launchpad.net/bugs/1772053
09:37 csharp librarians like grouping things together, I get it, but that bug will likely be open for years :-/
09:38 JBoyer Ah, I misunderstood the point of the 32 bit overflow. A better test would be to set it to , 4500ms short of the overflow at 2,147,483,647 so it's valid for about 25 days but session retrieve is called every half-second. (The minimum if you choose a small value is 5 seconds + the small value.)
09:38 * Dyrcona doesn't like "omnibus" bugs/branches much either.
09:38 csharp Dyrcona: same
09:39 Dyrcona So, on Lp 1743801, I'm not actually seeing the problem.
09:39 JBoyer 2147479147ms, that is.
09:39 pinesol Launchpad bug 1743801 in Evergreen 3.0 "web client: item status list view display issues" [High,Confirmed] https://launchpad.net/bugs/1743801 - Assigned to Jason Stephenson (jstephenson)
09:39 Dyrcona Loan Durations and Fine Level already show up as words in my item status display on a test VM with 3.0 installed.
09:39 JBoyer I had a hard time following what the remaining issue with that one was also. (aside from the t/f - y/n that was explicitly called out)
09:40 JBoyer And I know fine level and circ duration should have been fixed at some point because I remember doing it. (One of those angular str-to-int things)
09:40 jvwoolf joined #evergreen
09:41 Dyrcona And, I don't have circ as type in my item status display, so that might be an issue.
09:42 * Dyrcona feels like setting the bug incomplete or invalid even. :)
09:42 JBoyer (Oops, I didn't do it in Item status.)
09:42 * csharp starts a spreadsheet to parse the issues reported :-/
09:43 aabbee this one was confusing, but i think everything in the original report was resolved. 1738249 had some overlap
09:43 Dyrcona So, circ as type is there if I add it in list view, but detail view doesn't seem to have it.
09:44 aabbee i do not understand the last comment on 1743801. afaik, this bug was only talking about the list view (not detail view.)
09:44 * aabbee is the idjit that worked on this one. hello.
09:45 Dyrcona All right, then. I'll look at list view.
09:45 Dyrcona The way I got to item status it defaulted to detail view.
09:47 Dyrcona All right, I can confirm Loan Duration as a number in list view.
09:47 * Dyrcona needs to find a copy with circ_as_type, but bet we don't use it much here.
09:53 csharp aabbee: is this patch meant to be included in your branch?: https://bugs.launchpad.net/eve​rgreen/+bug/1743801/comments/9
09:53 pinesol Launchpad bug 1743801 in Evergreen 3.0 "web client: item status list view display issues" [High,Confirmed] - Assigned to Jason Stephenson (jstephenson)
09:54 aabbee if and only if the community decides it would rather see "Yes" and "No" instead of "true" and "false" on boolean-type grid fields. this was somewhat ambiguous.
09:54 csharp maybe breaking that into a separate bug would be appropriate?
09:55 rlefaive joined #evergreen
09:55 aabbee that seemed to be the consensus last time this came up: http://irc.evergreen-ils.org/​evergreen/2018-06-08#i_363534
09:55 aabbee i don't have a dog in the race, so i just left it separate and optional
09:55 csharp ok, I'll create a new bug for that and let you branchify your patch
09:56 aabbee sure
09:56 csharp if you do it today, we can probably get it into the releases (but no real rush)
09:57 aabbee sure, the patch is pretty minimal.
09:58 Dyrcona Looks like the signoff branch could use a rebase, and it has additional conflicts with rel_3_0, but I can deal with that. The differences are easy/obvious to resolve.
10:00 csharp aabbee: bug 1788417
10:00 pinesol Launchpad bug 1788417 in Evergreen "Web client: Boolean fields say "true"/"false" when XUL client used "Yes"/"No"" [Undecided,New] https://launchpad.net/bugs/1788417
10:06 Dyrcona Hm... Fine level isn't working for me. Maybe I broke it with the conflict resolution?
10:12 berick csharp: I'll add a test note for bug 1774448
10:12 pinesol Launchpad bug 1774448 in Evergreen 3.0 "web staff client can spam open-ils.auth.session.retrieve requests" [Undecided,Confirmed] https://launchpad.net/bugs/1774448
10:12 Dyrcona Weird....
10:13 aabbee 1788417: dunzo.
10:15 csharp aabbee++ #will test
10:16 aabbee csharp: i hope it works. instead of testing it myself, i discovered some ssl errors on my testing VM and got distracted. lemme know! :-)
10:16 csharp also, I can confirm that https://bugs.launchpad.net/ever​green/+bug/1743801/comments/15 is because the fix was not applied correctly to the servers - my bad
10:16 pinesol Launchpad bug 1743801 in Evergreen 3.0 "web client: item status list view display issues" [High,Confirmed] - Assigned to Jason Stephenson (jstephenson)
10:17 csharp we're testing multiple branches on that server - probably overwrote it at some point
10:22 Dyrcona I don't even understand that comment, tbh.
10:22 JBoyer csharp++ # Bug 1788417; Readability is important, t/f?
10:22 pinesol Launchpad bug 1788417 in Evergreen "Web client: Boolean fields say "true"/"false" when XUL client used "Yes"/"No"" [Undecided,New] https://launchpad.net/bugs/1788417
10:22 phasefx 1
10:23 JBoyer phasefx++
10:23 Dyrcona And, I guess I need to check out a stock 3.0 branch and apply the fix to there because I do not see why fine level isn't working for me, but loan duration is.
10:24 csharp it's all working for me
10:25 csharp well, except Owning Library is still displaying as a number, but I need to make sure we've got the fixes to bug 1738249 applied
10:25 pinesol Launchpad bug 1738249 in Evergreen 3.0 "Circulation Library in Item Status" [Low,Fix released] https://launchpad.net/bugs/1738249
10:26 aabbee Dyrcona: weird. fine level and loan duration were fixed in the same commit (not just the same branch). does age protect show up correctly?
10:27 bos20k_ joined #evergreen
10:28 Dyrcona One thing I've noticed is there are two </eg-grid> at the bottom of the file.
10:28 csharp aabbee: I see it working on my test
10:28 aabbee csharp++ \o/ whoo!
10:35 Dyrcona Now, it's working.
10:37 JBoyer berick++ # Clarification
10:37 JBoyer I have *definitely* verified that the spamming is for real. Just now applying the patch to verify it's out.
10:40 khuckins joined #evergreen
10:42 * JBoyer would have better luck testing if he applied the correct branch. :-/
10:42 Dyrcona :P
10:51 csharp yeah, looks like we need the fixes from bug 1738249 applied to see the list stuff completely fixed (another omnibus fix)
10:51 pinesol Launchpad bug 1738249 in Evergreen 3.0 "Circulation Library in Item Status" [Low,Fix released] https://launchpad.net/bugs/1738249
10:52 csharp my "lock into a release and cherry-pick selected fixes" approach is pretty painful ATM
10:53 Dyrcona csharp: Do you want help with the cherry-picks?
10:53 * Dyrcona is in the process of picking another branch with conflicts, ATM.
10:54 csharp nah, it's okay - honestly it's really just trying to test too many fixes on the same server at once
10:56 Dyrcona OK. I'm 'bout to push the branch I tested this morning.
10:56 csharp Dyrcona++
10:59 Christineb joined #evergreen
11:01 pinesol [evergreen|a. bellenir] LP#1743801: Item Status List View Display Issues - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3710c28>
11:01 pinesol [evergreen|a. bellenir] LP#1743801: Item Status List Display Issues - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a1cbed7>
11:01 csharp aabbee++
11:10 csharp aabbee: I've applied the t/f y/n fix to my test server and it's displaying "
11:10 csharp {{itemFieldValue(item, col) | egGridValueFilter:col:item}}"
11:11 pinesol [evergreen|Bill Erickson] LP#1724029 Patron search API returns correct order - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=6e32bb5>
11:11 csharp not sure whether that's a "me" problem or a code problem
11:11 csharp I've verified that both files are changed ok
11:12 csharp ah: ReferenceError: egStrings is not defined
11:12 aabbee d'oh.
11:12 aabbee it turns out your dependencies don't get injected if you don't inject your dependencies.
11:13 csharp heh
11:16 aabbee it's a one-line change: including egStrings in the dependencies for .filter('egGridValueFilter', ... should i just commit that separately, or can i squash that into my last commit?
11:18 * csharp votes "squash"
11:18 aabbee i'll do that once i figure out how to use git. that wasn't one of the seven commands i memorized.
11:19 berick aabbee++
11:19 csharp aabbee: commit locally, then 'rebase -i origin/master', selecting "f"/"fixup" for the commit you want to smoosh into the previous one
11:23 csharp aabbee: oh, and then add --force when you push the branch back up
11:24 Dyrcona csharp++
11:24 * csharp runs off to lunch
11:24 aabbee whale shoot. it pushed as a separate commit.
11:25 aabbee and i'm still decapitated (detatched HEAD)
11:25 berick and if your branch is not based on master, rebase -i HEAD~2 (or some other number of commits back)
11:26 Dyrcona aabbee: Sounds like you might have a conflict in the rebase.
11:27 berick jeff++ # bug 1684970 -- will retest mod_remoteip w/ C code change soon-ish
11:27 pinesol Launchpad bug 1684970 in OpenSRF "Proxy setup masks client IP needed by osrf-http-translator" [Medium,Confirmed] https://launchpad.net/bugs/1684970
11:27 Dyrcona Hm. Nope, no conflict.
11:28 aabbee i'mma just nuke the branch and try again (including *all* of the patch this time.)
11:28 Dyrcona I'll push to a collab branch and test it since I tried the rebase, myself.
11:29 rlefaive joined #evergreen
11:30 Dyrcona aabbee: It would be well worth the practice to try it again, just the same.
11:32 JBoyer bug 1774448 : the tin accurately describes the functioning of its contents.
11:32 pinesol Launchpad bug 1774448 in Evergreen 3.0 "web staff client can spam open-ils.auth.session.retrieve requests" [Undecided,Confirmed] https://launchpad.net/bugs/1774448
11:34 Dyrcona And, I busted my backport to my local 3.0 branch. :)
11:39 aabbee branch is fixed. (recreated.) i think i got it right this time.
11:42 Dyrcona aabbee++
11:42 Dyrcona I've tested it and it works for me. I'm going to push a signoff branch in case csharp still wants to look at it.
11:43 Dyrcona I'm going to make a separate branch for rel_3_0 becasue there is a conflict there.
11:43 aabbee Dyrcona++ csharp++ berick++ # \o/
11:44 bos20k joined #evergreen
11:52 Dyrcona And now, I'm getting some lunch.
11:58 sandbergja joined #evergreen
12:07 jihpringle joined #evergreen
12:16 sandbergja_ joined #evergreen
12:16 badseed16 joined #evergreen
12:17 Bmagic Can Evergreen handle dollar signs in the MARC editor data? Do they need to be escaped or something? Is there a trick for flat text versus standard editor? XUL client
12:18 badseed16 was kicked by jeff: badseed16
12:19 jeff Bmagic: standard editor: just use $ where desired. flat text editor: instead of $ the string {dollar} is used.
12:19 Bmagic ah! Thanks
12:20 jeff Bmagic: you can see this by entering a $ in a subfield in the standard editor, then toggling flat text mode.
12:20 Bmagic ah! Thanks again!
12:22 jeff various mostly-contrived, mostly-invalid-or-non-standard-MARC corner cases surround $ in the LDR, control fields, or indicators.
12:22 jeff but within the contents of subfields is as described above.
12:22 Bmagic yep, that's the case I am handling
12:24 jeff I think the convention originates in this document describing marcmaker/marcbreaker: http://www.loc.gov/marc/makrbrkr.html
12:25 jeff Bmagic: sorry, which case are you handling?
12:25 pinesol [evergreen|Bill Erickson] LP#1774448 Auth poll spam/timing repairs - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=2a05ce8>
12:27 * jeff finds at least one slightly-less-contrived corner case
12:27 Bmagic the accidental dollar sign tricking the interface into thinking it's a subfield
12:28 Dyrcona So, someone editing field data in the flat-text editor.....
12:37 jeff The least-contrived corner case where I think we have a bug at present is: switching from regular to flat text doesn't properly escape { and } (as {lcub} and {rcub}, respectively), so a literal {dollar} string can end up being turned into the character $. The string "{dollar}" should be expressed as "{lcub}dollar{rcub}" in the flat text editor.
12:38 eido1on joined #evergreen
12:38 eido1on was kicked by jeff: eido1on
12:43 berick jeff++ # gatekeeper
12:56 bdljohn joined #evergreen
12:59 pinesol [evergreen|a. bellenir] LP#1788417: boolean fields should say 'Yes'/'No' instead of true/false - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3100c32>
13:00 csharp aabbee++ Dyrcona++
13:19 Dyrcona sandbergja++ # more release notes
13:21 pinesol [evergreen|Jane Sandberg] Docs: updating 3.0.11 release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=eda0a99>
13:23 pinesol [evergreen|Jane Sandberg] Docs: more release notes for 3.1.5 - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=7eff66d>
13:26 ningalls joined #evergreen
13:26 khuckins joined #evergreen
13:26 egbuilder joined #evergreen
13:27 drigney joined #evergreen
13:27 maryj joined #evergreen
13:27 foobarrel joined #evergreen
13:30 jeff_ joined #evergreen
13:33 jeff_ joined #evergreen
13:41 csharp argh - I missed a signoff on a commit I pushed to rel_3_0 and it's not letting me correct it - any advice?
13:45 Dyrcona csharp: Forget about it.
13:45 berick csharp: nothing you can do but revert and commit a new patch.  not worth it for a secondary sign-off, IMO.  fuhgetaboutit
13:45 berick hah
13:45 csharp :-D
13:45 pinesol [evergreen|Jason Boyer] LP1733590: Only Print Selected Items Out - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3c34e5c>
13:45 csharp thanks
13:46 berick this IRC log is now your signoff
13:47 jeff_ print it out and keep it with you at all times. you may be challenged at any time to present it.
13:47 Dyrcona heh.
13:48 * csharp prints wallet-sized copy
14:21 JBoyer If anyone has time for another easy UI test, bug 1735816 has been updated to address some UI feedback and looks ready to go. :)
14:21 pinesol Launchpad bug 1735816 in Evergreen "Cannot Delete Existing Copy Notes" [Medium,Confirmed] https://launchpad.net/bugs/1735816
14:32 * csharp volunterrs
14:33 csharp er.. volunteers
14:34 berick as long as you don't volunterror
14:35 khuckins joined #evergreen
14:36 csharp berick: done that many many times
14:43 jeffdavis I would like bug 1715767 to get into 3.2. It's on the roadmap and targeted for the beta release, is there anything else I should be doing?
14:43 pinesol Launchpad bug 1715767 in Evergreen "Allow others to use my account (privacy waiver)" [Wishlist,New] https://launchpad.net/bugs/1715767
14:44 csharp ooh ooh - that looks cool
14:44 * csharp is in the middle of 50 things today, but I'll help test
14:45 Dyrcona But, it's past the deadline.... :)
14:46 Dyrcona Oh, wait, never mind.
14:46 * csharp forgets when the deadline is
14:46 Dyrcona I was thinking of the 2:00 pm cutoff for the monthly releases.
14:46 csharp oh - yeah, that deadline
14:47 * csharp watched it whoosh by
14:48 aabbee "I love deadlines. I love the whooshing noise they make as they go by." --Douglas Adams
14:48 csharp yes! that's the quote I was thinking of
14:48 aabbee :-)
14:49 jeffdavis Dogs bark, cats meow, deadlines get missed. It's the natural order of things.
14:51 jeffdavis Having said that, I would like to not miss the feature slush deadline for that bug if that's an issue.
14:52 Dyrcona I think feature slush begins today, but I could be wrong.
14:52 berick @band add Cascadia Subduction Zone
14:52 pinesol berick: Band 'Cascadia Subduction Zone' added to list
14:52 berick tonight is the cutoff for applying a pullrequest tag to a feature
14:52 berick next week is the cutoff for getting it merged
14:53 csharp JBoyer: it may be Just Me™, but the patch didn't work for me. Console errors: https://pastebin.com/dcdAatgV
14:53 csharp (bug 1735816)
14:53 pinesol Launchpad bug 1735816 in Evergreen "Cannot Delete Existing Copy Notes" [Medium,Confirmed] https://launchpad.net/bugs/1735816
14:53 Dyrcona berick: Experience a tremor?
14:54 csharp JBoyer: this was on PINES 3.0.2-ish test server, FYI
14:54 JBoyer You're going to need to Clear Cache and Hard Reload, because that's what it does pre-patch.
14:54 csharp ah - ok
14:55 Dyrcona @band add Clear Cache and Hard Reload
14:55 pinesol Dyrcona: Band 'Clear Cache and Hard Reload' added to list
14:55 JBoyer OpenILS/Application/Cat/AssetCommon.pm was calling delete_copy_note with an id where it should have been sending an object, hence the "blah blah properties of a number, blah blah."
14:55 * Dyrcona had been doing a lot of that today.
14:56 csharp hmm - I know I applied this - going to have to look at the code and make sure
14:56 JBoyer Dyrcona I thought we already had one like that in there, heh.
14:56 JBoyer Or maybe that's a dunno.
14:56 Dyrcona @band search Clear
14:56 pinesol Dyrcona: Nuclear Football ; Clear Cache and Hard Reload
14:56 csharp and there, I've run out of time :-/
14:56 csharp I have to run get my daughter, then come back and start building 3.0.11
14:56 Dyrcona @dunno search clear
14:56 pinesol Dyrcona: No matching dunnos were found.
14:57 Dyrcona @blame [band]
14:57 pinesol Dyrcona: It really IS Fleshing Children's fault!
14:57 JBoyer csharp, I'm sorry, I told you wrong. The change is in perl, not JS.  so a reload won't work, and I'm also not sure why it didn't work. :/
14:58 JBoyer @dunno search Clear
14:58 pinesol JBoyer: No matching dunnos were found.
14:58 JBoyer @dunno search clear
14:58 pinesol JBoyer: No matching dunnos were found.
14:58 csharp JBoyer: I can investigate tomorrow - it's definitely something we'd live patch once we see it work
14:58 JBoyer csharp++
14:58 JBoyer Now get goin'. :)
14:58 bshum joined #evergreen
14:59 Dyrcona csharp: Did you get remingtron's branch or JBoyer's?
14:59 csharp Dyrcona: JBoyer's
15:00 JBoyer Both would allow you to delete the notes, remingtron's would only be missing the UI shinys.
15:00 Dyrcona csharp: Ok. I was just gonna look at the diff.
15:04 Dyrcona So, looks like deleting copy notes has been busted for longer than I thought. :)
15:05 Dyrcona Is there going to be a 3.0.12 release or are we in security-only mode after 3.0.11?
15:17 yboston joined #evergreen
15:21 kmlussier joined #evergreen
16:37 bshum joined #evergreen
16:49 kmlussier @sortinghat
16:49 pinesol Hmm... kmlussier... Let me see now... GRYFFINDOR!
16:59 csharp @librarian
16:59 pinesol csharp: Management:5, Cataloging:13, Acquisitions:11, Reference:18, Circulation:11, Systems:15, Research:13, Custodial:9
17:02 jvwoolf left #evergreen
17:02 pinesol [evergreen|Jane Sandberg] Docs: finalizing 3.0.11 release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b2f630a>
17:02 pinesol [evergreen|Jane Sandberg] Docs: finalizing 3.1.5 release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f051ccd>
17:07 mmorgan left #evergreen
17:22 justanotheruser2 joined #evergreen
17:22 beanjammin joined #evergreen
17:33 PaulCapestany joined #evergreen
18:01 Pidgeotto joined #evergreen
18:21 Dyrcona joined #evergreen
18:23 asjoyner left #evergreen
18:31 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
19:49 alphor23 joined #evergreen
19:56 f13 joined #evergreen
20:10 ManyRaptors joined #evergreen
21:08 JBoyer-alt joined #evergreen
22:39 _bott_ joined #evergreen
22:41 sandbergja joined #evergreen
23:11 Algernop29 joined #evergreen

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat