| Time |
Nick |
Message |
| 00:30 |
|
beanjammin joined #evergreen |
| 00:45 |
|
remingtron_ joined #evergreen |
| 05:50 |
|
rlefaive joined #evergreen |
| 06:11 |
|
rlefaive joined #evergreen |
| 06:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:51 |
|
JBoyer joined #evergreen |
| 07:05 |
|
agoben joined #evergreen |
| 07:11 |
|
rjackson_isl joined #evergreen |
| 07:33 |
|
jvwoolf joined #evergreen |
| 07:38 |
|
jvwoolf1 joined #evergreen |
| 07:44 |
|
dwgreen joined #evergreen |
| 07:45 |
|
bdljohn1 joined #evergreen |
| 07:47 |
|
rlefaive joined #evergreen |
| 07:58 |
|
rlefaive_ joined #evergreen |
| 08:04 |
|
rlefaive joined #evergreen |
| 08:18 |
|
rlefaive joined #evergreen |
| 08:26 |
|
kmlussier joined #evergreen |
| 08:37 |
|
mmorgan joined #evergreen |
| 08:45 |
|
rlefaive joined #evergreen |
| 09:15 |
|
lsach joined #evergreen |
| 09:26 |
|
yboston joined #evergreen |
| 09:29 |
|
collum joined #evergreen |
| 09:29 |
|
rlefaive joined #evergreen |
| 09:48 |
|
rlefaive joined #evergreen |
| 10:01 |
|
Christineb joined #evergreen |
| 10:39 |
mmorgan |
I need to make changes to constraints on vandelay.import_item. Would there be any issues making this change on a running production system? |
| 10:41 |
mmorgan |
Some background, we were getting errors when importing and adding items on our 3.0.9 system. The errors were similar to those mentioned in lp 1724223 |
| 10:41 |
pinesol_green |
Launchpad bug 1724223 in Evergreen "Unable to delete copy notes / remove items from buckets, etc." [Medium,Fix released] https://launchpad.net/bugs/1724223 |
| 10:44 |
|
sandbergja joined #evergreen |
| 10:53 |
mmorgan |
I found different constraints on vandelay.import_item in our system vs. a stock system, and changed our training server to match stock. This fixed our training server, but I'm wondering if I can just slip in those changes on our production server. |
| 10:55 |
berick |
mmorgan: mind pasting the changes you want to make? |
| 10:57 |
mmorgan |
Actually, it looks like I need to drop a constraint. I have inherit_import_item_imported_as_fkey which has the following definition: |
| 10:58 |
mmorgan |
CREATE CONSTRAINT TRIGGER inherit_import_item_imported_as_fkey AFTER INSERT OR UPDATE ON vandelay.import_item DEFERRABLE INITIALLY IMMEDIATE FOR EACH ROW EXECUTE PROCEDURE vandelay_import_item_imported_as_inh_fkey() |
| 10:58 |
mmorgan |
That matches stock. |
| 10:58 |
mmorgan |
I also have inherit_imported_as_fkey with the definition: |
| 10:58 |
mmorgan |
CREATE CONSTRAINT TRIGGER inherit_imported_as_fkey AFTER INSERT OR DELETE OR UPDATE ON vandelay.import_item DEFERRABLE INITIALLY IMMEDIATE FOR EACH ROW EXECUTE PROCEDURE vandelay_import_item_imported_as_inh_fkey() |
| 10:59 |
mmorgan |
dropping inherit_imported_as_fkey on our training server solved the problem |
| 11:00 |
berick |
mmorgan: yeah, i can't imagine dropping the second contraint would cause any problems. |
| 11:00 |
mmorgan |
Thanks! I didn't think it would but wanted a sanity check. |
| 11:00 |
mmorgan |
berick++ |
| 11:08 |
mmorgan |
And ... Problem Solved! :) |
| 11:09 |
* mmorgan |
just needs to figure out where that odd constraint came from. |
| 11:40 |
jeff |
you're not alone: http://irc.evergreen-ils.org/evergreen/2018-06-14#i_363943 |
| 11:43 |
mmorgan |
jeff++ |
| 11:45 |
* mmorgan |
has looked through the git repo and hasn't found reference to that errant trigger |
| 11:45 |
|
jvwoolf joined #evergreen |
| 11:54 |
|
yboston joined #evergreen |
| 11:55 |
|
sandbergja joined #evergreen |
| 11:56 |
|
beanjammin joined #evergreen |
| 12:00 |
|
jihpringle joined #evergreen |
| 12:19 |
csharp |
so... looks like I jumped the gun committing bug 1739286 - is there a nice way to revert the commit in master/3.0/3.1? |
| 12:19 |
pinesol_green |
Launchpad bug 1739286 in Evergreen "web client: Cannot set default search box in Z39.50" [Low,Fix committed] https://launchpad.net/bugs/1739286 |
| 12:19 |
* csharp |
chalks it up to rookie committer mistake (ignoring the lack of pull request) |
| 12:20 |
csharp |
that is to say, is the proper procedure to actually git revert? |
| 12:26 |
csharp |
if possible, I'd like to handle this issue before building releases tomorrow :-/ |
| 12:43 |
berick |
csharp: is there actually a problem w/ the commit? |
| 12:43 |
dbwells |
csharp: Does it not work? I wouldn't worry too much about the lack of pullrequest. |
| 12:44 |
* dbwells |
often forgets to add the pullrequest tag |
| 12:59 |
|
idjit joined #evergreen |
| 13:01 |
kmlussier |
There was a followup bug on it. |
| 13:02 |
kmlussier |
bug 1782401 |
| 13:02 |
pinesol_green |
Launchpad bug 1782401 in Evergreen "web client z39.50 - account credentials typing malfunction" [Undecided,Confirmed] https://launchpad.net/bugs/1782401 |
| 13:04 |
kmlussier |
csharp: FWIW, if it were me, I probably would have assumed that the pullrequest was just forgotten. |
| 13:06 |
csharp |
yeah, sorry - the commit breaks entering z39.50 credentials |
| 13:14 |
berick |
csharp: if the commit causes problems it will need another commit to fix it or a 'git revert' -- no squashing/rebasing/etc. allowed on the origin branches. |
| 13:16 |
csharp |
berick: ok - so just 'git revert <commit hash>' on each affected branch? |
| 13:20 |
berick |
csharp: yep. and it should prompt you to enter a message |
| 13:22 |
csharp |
berick: ok - I'll do that on master, rel_3_0, and rel_3_1 |
| 13:24 |
csharp |
done - thanks for the help! |
| 13:24 |
kmlussier |
berick / JBoyer: Can I remove the pullrequest tag on bug 1768022? I just scanned through the comments, and it looks like there is no branch being actively tested. Is that correct? |
| 13:24 |
pinesol_green |
Launchpad bug 1768022 in Evergreen "Webclient Holds Pull List Returns 0 Results" [Undecided,New] https://launchpad.net/bugs/1768022 |
| 13:27 |
pinesol_green |
[evergreen|Chris Sharp] LP#1739286: Revert "lp1739286 default search box in Z39.50" - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=56a5915> |
| 13:31 |
JBoyer |
kmlussier, Comment 22 has a branch from me that was a significant improvement here and I think berick also showed improvement. To my knowledge that's all the pullrequest tag is referring ot. |
| 13:32 |
kmlussier |
JBoyer: OK, thanks! I'll leave it alone then. It wasn't clear to me if it was still under active consideration or not. |
| 13:33 |
berick |
comment #18 is also pull-able |
| 13:34 |
JBoyer |
Ah, yeah. They're not interdependent but they're both improvements and don't interfere with each other. |
| 13:36 |
* berick |
notes the lp |
| 13:38 |
berick |
csharp++ # your first revert |
| 13:38 |
kmlussier |
csharp++ |
| 13:54 |
|
rlefaive joined #evergreen |
| 13:58 |
JBoyer |
berick++ # recap-turing attention. |
| 14:00 |
|
beanjammin joined #evergreen |
| 14:06 |
|
yboston joined #evergreen |
| 15:08 |
|
mmorgan1 joined #evergreen |
| 15:20 |
Bmagic |
JBoyer: I am seeing the same error that you mentioned in chat last year: http://irc.evergreen-ils.org/evergreen/2017-05-25#i_306464 |
| 15:22 |
JBoyer |
Trying to load a few hundred copies somewhere? |
| 15:22 |
Bmagic |
yep |
| 15:22 |
Bmagic |
580 |
| 15:22 |
Bmagic |
Did you solve it at all? |
| 15:24 |
JBoyer |
I don't believe so, no. My preferred "Stop doing that" has eventually won out because people are getting more used to the web client. |
| 15:24 |
|
mmorgan joined #evergreen |
| 15:24 |
Bmagic |
ha! |
| 15:25 |
Bmagic |
yeah, I suppose the answer is: "Use Webby" or "upgrade to the newest version of EG, then use Webby" |
| 15:25 |
JBoyer |
My other recommendation was "dump that old junk" but if it's the library I'm thinking of they may or may not have ever taken me up on that. |
| 15:25 |
JBoyer |
Pretty much. XUL is never getting better in that regard. |
| 15:27 |
kmlussier |
Unfortunately, cataloging is an area that is still getting heavy xul use. |
| 15:27 |
JBoyer |
Ah, fantastic. Just got an email asking why someone's fund balance is 2.19666666666666666667. That'll be a fun talk. |
| 15:27 |
Bmagic |
at least it's not "NaN" |
| 15:27 |
csharp |
heh |
| 15:27 |
kmlussier |
lol |
| 15:28 |
kmlussier |
JBoyer: I believe that will be fixed as part of the process to move acq to Angular. |
| 15:28 |
JBoyer |
kmlussier, true, but if the ability to load more than 300+ items hasn't significantly improved in the last 10 years, the next 10 months aren't looking too hot either. |
| 15:28 |
* csharp |
adds "Schrute Bucks" to available acq currencies |
| 15:29 |
Bmagic |
lol |
| 15:29 |
JBoyer |
I am looking forward to angular acq. Also really looking forward to rm -rf dojo* |
| 15:29 |
csharp |
JBoyer: srsly |
| 15:31 |
Bmagic |
Do you think we could git commit the rm -rf dojo* at a hack-a-way or hackfest accompanied by streamers and perhaps a gong? Maybe the same one where we all buy a couple of pounds of that pinesol_green coffee? |
| 15:32 |
JBoyer |
We can celebrate it at the hackaway, but unless plans are dashed that'll be too late. (woo) |
| 15:33 |
Bmagic |
dang, I'm probably not going to make this year's hackaway :( |
| 15:35 |
csharp |
Bmagic: :-( |
| 15:37 |
JBoyer |
Well nuts. Turns out there's actually a 2.19666666666667 debit in the table. That's much gross. :/ |
| 15:37 |
JBoyer |
Also a bummer if Bmagic can't make it to GA. |
| 15:37 |
kmlussier |
Wait, what? The hackaway will be too late to remove dojo? I think it will be a few more years before that gets removed, right? |
| 15:37 |
JBoyer |
OH, right, yeah, sorry. |
| 15:38 |
JBoyer |
I was thinking xul, not dojo. |
| 15:38 |
JBoyer |
(I mean, both are causes to celebrate, but yeah, we're nowhere near ready for that yet.) |
| 15:38 |
kmlussier |
It would be great news indeed if we were ready! :) |
| 15:39 |
kmlussier |
JBoyer: I think those debits usually happen when direct charges are prorated against multiple funds used on an invoice. Something like that. |
| 15:40 |
kmlussier |
bug 996029 |
| 15:40 |
pinesol_green |
Launchpad bug 996029 in Evergreen "Totals in funds do not round to two decimal places when prorating is used" [Medium,Confirmed] https://launchpad.net/bugs/996029 |
| 15:40 |
JBoyer |
Ooh, thanks for the pointer kmlussier. I think this place may do that on some invoices. Gives me something to look for in the morning. |
| 15:40 |
JBoyer |
kmlussier++ |
| 15:44 |
|
mmorgan1 joined #evergreen |
| 15:46 |
|
sandbergja joined #evergreen |
| 15:49 |
kmlussier |
mmorgan++ # Adding test plan to bug 1511765 to make testing easier. |
| 15:49 |
pinesol_green |
Launchpad bug 1511765 in Evergreen "Checking in migrated lost status copies and Lost/Long Overdue/Lost and Paid copies with no associated circ generates error when zero-balance lost OU setting is enabled" [Medium,Confirmed] https://launchpad.net/bugs/1511765 |
| 16:06 |
|
abowling joined #evergreen |
| 16:48 |
|
kmlussier joined #evergreen |
| 16:59 |
|
jvwoolf joined #evergreen |
| 17:04 |
|
mmorgan left #evergreen |
| 17:25 |
|
kmlussier joined #evergreen |
| 17:45 |
|
abowling left #evergreen |
| 18:11 |
jeffdavis |
Is a 3.1.4 release still expected for tomorrow? |
| 18:28 |
dbwells |
jeffdavis: That's the plan. |
| 18:28 |
jeffdavis |
Great, thanks! |
| 18:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:58 |
|
sandbergja joined #evergreen |
| 23:35 |
pinesol_green |
[evergreen|Terran McCanna] LP#1777954 Open Electronic Resource Links in New Tab - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0b62a39> |
| 23:35 |
pinesol_green |
[evergreen|Dan Wells] LP#1777954 Open Electronic Resource Links in New Tab, Part 2 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a43c37d> |
