| Time |
Nick |
Message |
| 02:49 |
|
sandbergja joined #evergreen |
| 05:25 |
|
stephengwills joined #evergreen |
| 06:32 |
pinesol_green |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live> |
| 06:52 |
|
stephengwills joined #evergreen |
| 06:55 |
|
agoben joined #evergreen |
| 07:03 |
|
rjackson_isl joined #evergreen |
| 07:05 |
|
Dyrcona joined #evergreen |
| 07:16 |
* JBoyer |
throws a duck at jeff :p |
| 08:14 |
|
tlittle joined #evergreen |
| 08:30 |
|
mmorgan joined #evergreen |
| 08:52 |
|
bdljohn joined #evergreen |
| 08:57 |
|
kmlussier joined #evergreen |
| 09:01 |
|
idjit joined #evergreen |
| 09:09 |
|
lsach joined #evergreen |
| 09:19 |
|
jvwoolf joined #evergreen |
| 09:52 |
* miker |
looks at the TAP failure... |
| 09:53 |
miker |
yeah, I propagated that error, will fix with alternating quote types |
| 09:53 |
JBoyer |
$$mo quotes, mo problems$$ |
| 09:54 |
miker |
:) |
| 09:55 |
miker |
actually, I'll just make it a sentence rather than partially an SQL clause |
| 09:57 |
JBoyer |
gaaaaasssp. :( I didn't realize I screwed that up. (and I thought I had run that test, but obviously not.) |
| 09:58 |
miker |
JBoyer: I didn't think I'd run it, and trusted only my brain to verify the test sane. that's what I get for trusting my brain... |
| 09:58 |
pinesol_green |
[evergreen|Mike Rylander] Fix quote nesting issue in TAP test - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=372508d> |
| 09:59 |
JBoyer |
Well, the test does pass, our brains just have overly-permissive SQL parsers. ;) |
| 10:06 |
Dyrcona |
'' works, IIRC. |
| 10:06 |
Dyrcona |
'String with ''quoted'' word in it.' |
| 10:06 |
Dyrcona |
Or, double quotes, but I guess LONGOVERDUE doesn't need to be quoted. |
| 10:07 |
Dyrcona |
:) |
| 10:07 |
miker |
Dyrcona: it does, but I decided not to mix metaphors when the line starts with narrative text |
| 10:07 |
miker |
right |
| 10:07 |
Dyrcona |
Sure. Just sayin'. |
| 10:07 |
miker |
or use $$ quotes |
| 10:07 |
miker |
or E' ... \' ...' |
| 10:07 |
miker |
lots of ways |
| 10:07 |
Dyrcona |
yeah, I use those $$ a lot with xml. |
| 10:08 |
Dyrcona |
Well, xpath. |
| 10:08 |
miker |
aye |
| 10:08 |
Dyrcona |
And for posterity E'...' quotes are handy with regexps. |
| 10:09 |
|
mmorgan1 joined #evergreen |
| 10:09 |
miker |
posterity thanks you :) |
| 10:09 |
Dyrcona |
:D |
| 10:25 |
|
Christineb joined #evergreen |
| 10:32 |
|
bdljohn joined #evergreen |
| 10:42 |
kmlussier |
@dessert |
| 10:42 |
* pinesol_green |
grabs some Pecan Pie for kmlussier |
| 10:53 |
|
bdljohn joined #evergreen |
| 11:08 |
|
mmorgan1 left #evergreen |
| 11:17 |
|
sandbergja joined #evergreen |
| 11:32 |
|
JBoyer joined #evergreen |
| 11:46 |
csharp |
@dessert |
| 11:46 |
* pinesol_green |
grabs some of mllewellyn's Cupcakes for csharp |
| 11:47 |
Dyrcona |
@lunch |
| 11:47 |
pinesol_green |
Dyrcona: <shaggy>We're, like, doomed.</shaggy> |
| 11:48 |
Dyrcona |
@launch |
| 11:48 |
pinesol_green |
Dyrcona: Have you tried taking it apart and putting it back together again? |
| 11:54 |
|
beanjammin joined #evergreen |
| 12:11 |
|
sandbergja joined #evergreen |
| 12:22 |
|
abowling joined #evergreen |
| 13:08 |
|
sandbergja joined #evergreen |
| 14:58 |
kmlussier |
@quote [random] |
| 14:58 |
pinesol_green |
kmlussier: Error: The command "random" is available in the LoveHate and Quote plugins. Please specify the plugin whose command you wish to call by using its name as a command before "random". |
| 14:58 |
kmlussier |
@quote random |
| 14:58 |
pinesol_green |
kmlussier: Quote #8: "<Digital_Pioneer> When life gives you bad hardware, make bricks." (added by bshum at 12:31 PM, May 13, 2011) |
| 15:26 |
|
sandbergja joined #evergreen |
| 15:49 |
|
bdljohn joined #evergreen |
| 16:21 |
jeff |
going to try and make bug 1745623 happen for 3.2, if anyone has thoughts/input that they haven't shared on the original thread or bug yet. :-) |
| 16:21 |
pinesol_green |
Launchpad bug 1745623 in Evergreen "wishlist circ history - notify staff at checkout if item is in users circ history" [Wishlist,In progress] https://launchpad.net/bugs/1745623 - Assigned to Jeff Godin (jgodin) |
| 16:24 |
* kmlussier |
always has thoughts/input. ;) |
| 16:25 |
Dyrcona |
I have nothing useful to add except that I often read the same book twice because "La bonne lecture, c'est la relecture." (The good reading is the rereading.) |
| 16:26 |
Dyrcona |
There are a couple of books that I've read more than twice.... |
| 16:26 |
Dyrcona |
I guess a useful suggestion might come of that. |
| 16:29 |
jeff |
general idea is an org unit setting to enable the alert, then an overridable checkout event when a copy being checked out matches the patron's circ history, using logic similar to the opac search results tagging for previously circulated items. |
| 16:29 |
jeff |
don't care if you've read it before? override the alert. |
| 16:29 |
jeff |
you'd probably configure SIP2 clients to auto-override the event, if you have SIP2 self checkout and have enabled the event in the first place. |
| 16:30 |
Dyrcona |
I made a comment on the bug to add a user setting to disable the feature. |
| 16:30 |
Dyrcona |
I don't want to have to override repeatedly. |
| 16:31 |
kmlussier |
Yes, my input was going to be what Dyrcona just said. I was reading through the thread first to make sure I wasn't repeating what somebody else said. |
| 16:32 |
Dyrcona |
I also have some reservations about adding code to circulation in general. It's slow enough as it is, but I'll leave that reservation for right here. |
| 16:32 |
kmlussier |
I often check out books that have previously been checked out, but never read. I don't think I would like getting the reminder. |
| 16:32 |
kmlussier |
But I can see where it would be useful to other people. |
| 16:34 |
* kmlussier |
also remembers all those picture books she checked out over and over again because her kids never tired of them. |
| 16:34 |
Dyrcona |
"We didn't go fast and we didn't go far, but we made it to the lake in our rattletrap car!" :) |
| 16:34 |
jeff |
i don't have a clear picture in my head of how overridable events work in the web based self check, but I seem to recall there's existing examples there. |
| 16:34 |
kmlussier |
But it sounds like a neat feature! jeff++ |
| 16:35 |
Dyrcona |
jeff++ |
| 16:35 |
jeff |
not that I'm sure any of us are typical users, but I wonder if there should be a patron-level preference to disable the alert. |
| 16:35 |
Dyrcona |
jeff: That's what I said on the bug. |
| 16:35 |
jeff |
alert triggers if the library has it enabled and as long as the patron doesn't have it disabled. |
| 16:36 |
jeff |
hah. there you go, putting conversation in one central useful place again! |
| 16:36 |
jeff |
launchpad hasn't deigned to deliver that email to me yet. |
| 16:36 |
Dyrcona |
Yeah. Lp can be slow. |
| 16:36 |
Dyrcona |
Though I just got the email about 20 seconds ago. |
| 16:37 |
jeff |
yep, I have it now. |
| 16:40 |
* kmlussier |
sadly returns to looking at budgets. |
| 16:44 |
jeff |
I think that the requirement of an override permission is built-in to the override mechanism, but I can't think of any circumstance where we'd want to use a permission to prevent the event from being overridden. I haven't looked yet to see what our practice has been in the past with regard to upgrade scripts for new permissions. |
| 16:45 |
jeff |
But I'd be tempted to add any required permissions to the top of the tree, rather than require them to be manually added based on someone remembering to read the release notes. :-) |
| 16:45 |
jeff |
also on my list is looking to see how existing search result tagging handles metarecord vs record matches (if it does that at all) |
| 16:46 |
jeff |
merges and deletes... at least documenting the limitations. |
| 16:51 |
jeff |
Dyrcona++ kmlussier++ abneiman++ |
| 16:52 |
jeff |
and Stompro++ / StomproJ++ but I supect he may be enjoying a vacation. :-) |
| 16:52 |
jeff |
@seen Stompro |
| 16:52 |
pinesol_green |
jeff: Stompro was last seen in #evergreen 1 week, 0 days, 0 hours, 54 minutes, and 43 seconds ago: <Stompro> How come evergreen doesn't have a fax reactor for the action_trigger system? We get people coming in all the time that say the only way to contact them is via their fax line. I think fax use is really going to take off in 2019. |
| 16:52 |
abneiman |
jeff++ # yay new features! |
| 16:53 |
jeff |
amusing typo: fm_IDK.xml |
| 16:55 |
Dyrcona |
@quote search fax |
| 16:55 |
pinesol_green |
Dyrcona: No matching quotes were found. |
| 16:56 |
jeff |
trickier: enabling staff access to circ history on behalf of a patron, for the homebound and/or patron who does not have ability/desire to use their online account. |
| 16:57 |
jeff |
(i.e., enabling support for this in a responsible manner and in a way that isn't likely to invoke ire and outrage) :-) |
| 16:58 |
Dyrcona |
Does a patron have to have enabled circ history for this to work? |
| 16:59 |
Dyrcona |
And that reminds me. I meant to lookup how many circs we have left to age, but I forgot. |
| 17:00 |
Dyrcona |
That query is more complicated than I want to figure out at 5:00 pm on a Friday. |
| 17:01 |
kmlussier |
Yes, I think that was mentioned in the email thread. The search result tagging that jeff is leveraging also requires that circ history be enabled. |
| 17:09 |
jeff |
Yes, this would all rely on rows in actor.usr_circ_history. |
| 17:09 |
jeff |
It would not attempt to leverage unaged circs if present. |
| 17:27 |
|
gsams joined #evergreen |
| 17:30 |
|
sandbergja joined #evergreen |
| 17:42 |
miker |
jeff: I missed all the discussion, but how about an opt-in user setting to silence alert, rather than an override permission (if I understand)? |
| 17:42 |
miker |
or, well, doesn't even have to be opt-in. that's mainly about a/t events |
| 17:42 |
miker |
anyway... |
| 17:42 |
jeff |
miker: both, i think. |
| 17:43 |
jeff |
one sec. |
| 17:44 |
jeff |
My thought was that the checkout event mechanism was the best thing to leverage, especially since one of the use cases is "no, nevermind -- don't check that out after all". |
| 17:45 |
jeff |
Several things would need to happen for the evetnt to fire: org unit setting would need to be enabled, user would need to have circ history (either we check the setting or just check the history, not much difference at this point), and user would need to NOT have a user setting that suppresses the alert. |
| 17:45 |
miker |
and then staff would need the permission to push past it |
| 17:46 |
miker |
the override permission, obv |
| 17:46 |
miker |
that all sounds sane |
| 17:46 |
miker |
and SIP2 devices would say "see staff" |
| 17:46 |
jeff |
The permission question just comes down to "can you have an event that can be overridden without requiring a permission, or is the EVENT.override permission requirement baked in (don't remember, haven't verified), and then me musing on if it would be best to just auto-create the perm (if required) at top of tree in the upgrade script / baseline. |
| 17:47 |
miker |
it's essentially baked. when the "please proceed" second try fires, we say "this is an override checkout" and the ML tests for appropriate permissions |
| 17:47 |
jeff |
My recommendation for SIP2 devices would be to auto-override the event in the oils_sip.xml config, but a library could choose to not do so. Supporting overrides with messages and "try it again to force it" is... tricky due to various implementation quirks. |
| 17:48 |
miker |
ayup |
| 17:48 |
miker |
SIP2-- |
| 17:48 |
miker |
hard to say "try harder!" over sip2 |
| 17:48 |
miker |
but now |
| 17:48 |
* miker |
disappears |
| 17:48 |
jeff |
I was pretty sure you couldn't say "this event requires no override permission, just let it be overridden by anyone", but I didn't want to make that assertion without looking first. I suppose I could have looked then started talking... :-) |
| 17:48 |
miker |
jeff++ |
| 17:48 |
jeff |
miker: farewell! |
| 17:49 |
jeff |
miker++ |
| 18:32 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 21:09 |
|
sandbergja joined #evergreen |
| 21:31 |
|
sandbergja joined #evergreen |
