Time |
Nick |
Message |
06:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:11 |
|
rjackson_isl joined #evergreen |
07:35 |
|
dwgreen joined #evergreen |
08:11 |
|
Dyrcona joined #evergreen |
08:28 |
|
rlefaive joined #evergreen |
08:35 |
|
mdriscoll joined #evergreen |
08:35 |
|
mmorgan joined #evergreen |
08:37 |
|
bdljohn joined #evergreen |
08:49 |
|
bos20k joined #evergreen |
08:54 |
|
bdenis joined #evergreen |
08:55 |
|
kmlussier joined #evergreen |
09:01 |
|
dwgreen joined #evergreen |
09:02 |
|
yboston joined #evergreen |
09:10 |
|
idjit joined #evergreen |
09:13 |
|
lsach joined #evergreen |
09:14 |
kmlussier |
@coffee [someone] |
09:14 |
* pinesol_green |
brews and pours a cup of Fair Trade Organic Guatemala, and sends it sliding down the bar to mdriscoll |
09:14 |
kmlussier |
@tea [someone] |
09:14 |
* pinesol_green |
brews and pours a pot of Wild Snow Sprout Tea, and sends it sliding down the bar to mdriscoll (http://ratetea.com/tea/wild-tea-qi/wild-snow-sprout-tea/6447/) |
09:15 |
kmlussier |
Good morning mdriscoll! pinesol_green apparently thinks you need a lot of caffeine this morning. :) |
09:17 |
Dyrcona |
@who needs a lot of caffeine this morning |
09:17 |
pinesol_green |
akilsdonk needs a lot of caffeine this morning. |
09:19 |
|
terran joined #evergreen |
09:20 |
rhamby |
so do we all |
09:21 |
kmlussier |
@coffee rhamby |
09:21 |
* pinesol_green |
brews and pours a cup of Kenya Kangunu, and sends it sliding down the bar to rhamby |
09:22 |
rhamby |
yum yum |
09:25 |
* JBoyer |
bought 2 bags of coffee last night and upon arriving home discovered they were whole bean. |
09:25 |
* JBoyer |
does not own a coffee grinder. :/ |
09:27 |
* kmlussier |
recommends buying a coffee grinder. |
09:28 |
terran |
JBoyer: you deserve to own a coffee grinder. |
09:29 |
JBoyer |
That's the plan, but one did not materialize overnight so this day has been coffee-free. Tea intake has been increased substantially. |
09:30 |
|
stephengwills joined #evergreen |
09:30 |
terran |
You can put them in a freezer bag, cushion it with a dish towel, and bash it with a hammer. #firsthandexperience |
09:32 |
JBoyer |
#coffeehacks |
09:32 |
JBoyer |
terran++ |
09:32 |
rhamby |
JBoyer: it is acceptable to chew the beans when desperate. Just saying. |
09:32 |
terran |
Very little gets between me and my coffee. |
09:32 |
terran |
rhamby++ |
09:32 |
Dyrcona |
rhamby++ |
09:34 |
JBoyer |
rhamby++ |
09:34 |
Dyrcona |
I was going to suggest coating them in chocolate before eating them..... |
09:35 |
Dyrcona |
Ticket question: "Why isn't this copy filling a hold?" |
09:35 |
JBoyer |
I have chocolate chips. I am ready. |
09:35 |
Dyrcona |
My first thought: "Because it's lazy and it doesn't want to." |
09:36 |
Dyrcona |
Chocolate-coated coffee bean is my favorite coffee. |
09:37 |
JBoyer |
"Well, you see, what you have there is the obstinate printing edition. Sometimes things go wrong at the printer and there's just nothing to be done. Sometimes they can be rehabilitated into lucky day or browsing collections, sometimes they just won't leave your desk." |
09:37 |
Dyrcona |
:) |
09:37 |
JBoyer |
=020 \\$a9781234567890$q(obs.) |
09:48 |
|
dwgreen joined #evergreen |
09:50 |
|
jvwoolf joined #evergreen |
10:14 |
|
mmorgan left #evergreen |
10:14 |
berick |
reminder of https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2018-07-11 |
10:15 |
pinesol_green |
[evergreen|Jason Boyer] LP1736243: SMS Carrier Editing in Patron Editor - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b99e621> |
10:16 |
|
jvwoolf joined #evergreen |
10:18 |
terran |
I've noticed when placing holds from Item Status > Request Copy that it doesn't save any hold notification preferences. (It didn't in xul either.) Anyone know if that was an intentional decision? |
10:24 |
terran |
Request Copy = Request Items |
10:24 |
|
mmorgan joined #evergreen |
10:27 |
|
khuckins joined #evergreen |
10:38 |
kmlussier |
terran: I could be mistaken about this, but there may have been assumption that holds placed from item status are generally for staff holds where staff needs the item for cataloging or another purpose. In that case, notification wouldn't be necessary? However, if that's true, I would expect staff to select the Force or Cataloging recall option. |
10:38 |
* kmlussier |
is just grasping at straws. |
10:39 |
terran |
kmlussier: I was thinking that might have been the original logic behind it too. However, I don't necessarily agree with it - I'm going to go ahead and open a bug for it for discussion at least. |
10:42 |
csharp |
so another core committer question - is it good practice/desirable for a core committer to create a signoff branch? or just commit a change they've seen work and are willing to sign off on? |
10:42 |
mmorgan |
terran: kmlussier: I thought there was a bug on that, but I'm not able to find it. It was a conscious decision not to set notification preferences for that type of hold. |
10:42 |
csharp |
in the past I just created signoff branches and waited for a core committer to come around and push it to master/active branches |
10:42 |
terran |
mmorgan: thanks! |
10:44 |
mmorgan |
terran: http://irc.evergreen-ils.org/evergreen/2015-10-09#i_208619 |
10:44 |
terran |
mmorgan++ |
10:45 |
kmlussier |
csharp: I create the signoff branch locally, but then I just commit the change to master/active branches. IOW, I don't push the signoff to the working repo. |
10:45 |
kmlussier |
Sounds like we could use some good core committer documentation! :) |
10:46 |
kmlussier |
mmorgan++ |
10:46 |
csharp |
kmlussier: thanks! and yes, I would definitely benefit from a best practices manual and would be happy to assist in creating it |
10:51 |
pinesol_green |
[evergreen|Jason Etheridge] lp1739286 default search box in Z39.50 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d66db64> |
10:58 |
mdriscoll |
I'm running into the same problem with upgrade script 3.0.1-3.0.2 as described in Launchpad Bug #1772028. I added a comment to the bug. |
10:58 |
pinesol_green |
Launchpad bug 1772028 in Evergreen 3.0 "Missing db functions in 3.0.1-3.0.2 upgrade script" [High,Confirmed] https://launchpad.net/bugs/1772028 |
11:01 |
mdriscoll |
Should I be concerned that script 1063 does not find what it needs in information_schema.referential_constraints and information_schema.key_column_usage? I know how to create the missing functions, but is something else out of wack on my system? |
11:01 |
terran |
mmorgan and kmlussier: https://bugs.launchpad.net/evergreen/+bug/1781236 |
11:01 |
pinesol_green |
Launchpad bug 1781236 in Evergreen "Item Status - Request Items doesn't store hold notifications" [Wishlist,New] |
11:01 |
mmorgan |
terran++ |
11:11 |
pinesol_green |
[evergreen|Michele Morgan] LP#1692116 - Action trigger validator fix for paid Long Overdue items - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f299eb2> |
11:13 |
pinesol_green |
[evergreen|Jeff Davis] LP#1738499: barcode completion for copy buckets - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=bb4b31c> |
11:14 |
kmlussier |
csharp++ # Using your core committer superpowers for good! |
11:17 |
* csharp |
is mad with power |
11:18 |
* kmlussier |
was really concerned csharp might use those powers for evil. After all, he is the spy! |
11:19 |
* csharp |
using powers for evil: https://www.youtube.com/watch?v=e_DqV1xdf-Y |
11:20 |
mmorgan |
csharp++ |
11:47 |
pinesol_green |
[evergreen|Cesar Velez] LP1742782 - fix display of cbox label in list of removable fields - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=4d6a92a> |
11:48 |
|
kmlussier joined #evergreen |
11:49 |
|
rlefaive joined #evergreen |
11:50 |
kmlussier |
comcast-- |
11:50 |
kmlussier |
Are we still planning to have a dev meeting today? |
11:53 |
|
Christineb joined #evergreen |
11:56 |
berick |
kmlussier: we have an agenda |
11:56 |
* berick |
was assuming so |
11:56 |
berick |
i'll send a reminder |
11:57 |
kmlussier |
berick++ |
12:04 |
|
jvwoolf joined #evergreen |
12:14 |
csharp |
comcast-- |
12:21 |
|
bos20k joined #evergreen |
12:22 |
|
khuckins joined #evergreen |
12:30 |
|
khuckins joined #evergreen |
12:39 |
pinesol_green |
[evergreen|Galen Charlton] LP#1745207: tie together copy_tag() and site() search filters - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d8de665> |
12:54 |
|
abowling joined #evergreen |
12:55 |
csharp |
looking at bug 1746566 - this is a new feature - not a bug fix... should that mean it's not targeted to rel_3_0/3_1 and just to master? |
12:55 |
pinesol_green |
Launchpad bug 1746566 in Evergreen 3.1 "wishlist: increase row limits available in specific grids" [Wishlist,New] https://launchpad.net/bugs/1746566 |
12:55 |
csharp |
the bug is currently targeted to both of those series, but seems like the kind of thing that should come with a new release |
12:56 |
|
rlefaive joined #evergreen |
12:58 |
JBoyer |
csharp, that's how I understand it, for what my recollection is worth. |
13:02 |
|
collum joined #evergreen |
13:02 |
csharp |
JBoyer: makes sense |
13:11 |
pinesol_green |
[evergreen|Cesar Velez] LP#1746566: Enable 500, 1K, and ALL-the-Rows in patron grids - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6c511a7> |
13:11 |
pinesol_green |
[evergreen|Galen Charlton] LP#1746566: Enable 500, 1K, and all rows in more patron grids - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=60eec43> |
13:25 |
pinesol_green |
[evergreen|Bill Erickson] LP#1537228 Precat subsequent checkin shows route alert - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0e11b01> |
13:28 |
|
jvwoolf1 joined #evergreen |
13:30 |
* csharp |
notes that a lot of bugs linger because there's not a great way to mock up test environments for things like EDI, etc. |
13:31 |
Dyrcona |
True. |
13:32 |
csharp |
or action triggers |
13:33 |
Dyrcona |
Well, I've tested action triggers by sending all the mail to a specific account. :) |
13:33 |
csharp |
yeah, we do that too |
13:33 |
Dyrcona |
Not much fun, though. |
13:34 |
csharp |
we just have postfix deliver locally and can access the mail through mutt or even a remote client |
13:34 |
Dyrcona |
Yeah, basically what I did with exim. |
13:35 |
Dyrcona |
Basically had it put all the mail in the opensrf user's mbox. |
13:35 |
berick |
same here, deliver to opensrflocalhost, reivew w/ mutt |
13:35 |
mmorgan |
For action triggers, I've tested by setting the reactor to process template rather than send email. Then check the database for the trigger output. |
13:36 |
mmorgan |
Read that somewhere a long time ago, but forget where. |
13:36 |
csharp |
smart |
13:37 |
Dyrcona |
Yeah, I recall doing something like that, too. Of course, not running a MTA is about the same. :) |
14:32 |
pinesol_green |
[evergreen|Galen Charlton] LP#1745462: guard against scanning entire authority table - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=91cd25f> |
14:32 |
pinesol_green |
[evergreen|Galen Charlton] LP#1745462: avoid trying to validate empty fields - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=eb0c224> |
15:00 |
berick |
call for dev meeting volunteer.. |
15:03 |
dbwells |
#startmeeting Development meeting, 11 July 2018 |
15:03 |
pinesol_green |
Meeting started Wed Jul 11 15:03:00 2018 US/Eastern. The chair is dbwells. Information about MeetBot at http://wiki.debian.org/MeetBot. |
15:03 |
pinesol_green |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
15:03 |
pinesol_green |
The meeting name has been set to 'development_meeting__11_july_2018' |
15:03 |
kmlussier |
dbwells++ |
15:03 |
berick |
dbwells++ |
15:03 |
dbwells |
#info Agenda is https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2018-07-11 |
15:03 |
berick |
thanks dbwells |
15:03 |
dbwells |
#topic Introductions |
15:04 |
berick |
#info berick = Bill Erickson @ KCLS |
15:04 |
csharp |
#info csharp = Chris Sharp, GPLS |
15:04 |
dbwells |
#info dbwells = Dan Wells, Hekman Library (Calvin College) |
15:04 |
remingtron |
#info remingtron is Remington Steed, Hekman Library (Calvin College) |
15:04 |
phasefx |
#info phasefx = Jason Etheridge, EOLI |
15:04 |
kmlussier |
#info kmlussier is Kathy Lussier, MassLNC |
15:04 |
miker |
#info miker = Mike Rylander, EOLI |
15:05 |
cesardv |
#info cesardv = Cesar Velez, EOLI |
15:05 |
JBoyer |
#info JBoyer = Jason Boyer, ISL |
15:05 |
jeff |
#info jeff = Jeff Godin, Traverse Area District Library (TADL) |
15:06 |
dbwells |
#topic Action Items from Last Meeting |
15:06 |
dbwells |
#item gmcharlt will open and work on bugs for documentation changes for better ejabberd configuration during installation of OpenSRF |
15:06 |
|
khuckins joined #evergreen |
15:07 |
kmlussier |
I don't think #item does anything. |
15:08 |
dbwells |
kmlussier: ok, I was going off the last meeting log. I'll do info instead. Thank you |
15:08 |
dbwells |
#info gmcharlt will open and work on bugs for documentation changes for better ejabberd configuration during installation of OpenSRF |
15:09 |
dbwells |
Not seeing gmcharlt so far today. I'll go through these kinda fast, so please stop me if needed. |
15:09 |
dbwells |
#info gmcharlt will do a bugfix release of OpenSRF 3.0.2, particularly upon successful testing of bug 1774703 |
15:09 |
pinesol_green |
Launchpad bug 1774703 in OpenSRF "Websockets processes locked at 100% CPU" [Undecided,Confirmed] https://launchpad.net/bugs/1774703 |
15:09 |
gmcharlt |
#info gmcharlt = Galen Charlton, Equinox |
15:09 |
gmcharlt |
(also temporarily double-booked) |
15:10 |
dbwells |
gmcharlt: Good afternoon! |
15:10 |
miker |
should we circle back around to gmcharlt after other stuff? |
15:11 |
dbwells |
miker: sounds good |
15:11 |
dbwells |
#info csharp will upload an update for the Hatch FF add-on |
15:11 |
csharp |
yeah, I haven't done that yet :-( |
15:12 |
* csharp |
will get with JBoyer in the next week or so to discuss next steps |
15:12 |
dbwells |
no problem |
15:12 |
JBoyer |
+! |
15:12 |
dbwells |
#action csharp will upload an update for the Hatch FF add-on |
15:12 |
* gmcharlt |
is now single-booked |
15:14 |
dbwells |
gmcharlt: Are there specifc action items you would like to give an update on and/or carry over to August? |
15:14 |
gmcharlt |
yeah, sec |
15:14 |
gmcharlt |
#action gmcharlt will do a bugfix release of OpenSRF 3.0.2, particularly upon successful testing of bug 1774703 |
15:14 |
dbwells |
sure |
15:14 |
pinesol_green |
Launchpad bug 1774703 in OpenSRF "Websockets processes locked at 100% CPU" [Undecided,Confirmed] https://launchpad.net/bugs/1774703 |
15:14 |
gmcharlt |
#action gmcharlt will open and work on bugs for documentation changes for better ejabberd configuration during installation of OpenSRF |
15:16 |
gmcharlt |
(and that's it for me at the moment) |
15:17 |
dbwells |
gmcharlt: Thank you. Do you also want to carry over the OpenSRF 3.1.0 roadmap and the angular meeting action items? |
15:17 |
gmcharlt |
yeah |
15:17 |
dbwells |
#action gmcharlt will put out a call for roadmap entries for OpenSRF 3.1.0 |
15:17 |
gmcharlt |
#action Galen will start a OpenSRF 3.1.0 roadmap and issue calls for entries |
15:17 |
dbwells |
oh, sorry |
15:17 |
gmcharlt |
what is #action'ed twice will get done for the next meeting ;) |
15:18 |
gmcharlt |
no worries! |
15:18 |
dbwells |
#action gmcharlt to work with berick to see about setting up some kind of presentation/meeting to discuss angular |
15:18 |
* csharp |
files away "you only used #action once" excuse for future meetings |
15:18 |
dbwells |
#topic OpenSRF Release - Time for an LP 3.1 series? |
15:19 |
berick |
i added that question, btw, but I think gmcharlt action kind of answers that |
15:19 |
gmcharlt |
yeah, I and went ahead and registered the series now |
15:19 |
dbwells |
Okay, sounds good. |
15:19 |
gmcharlt |
so... target away! |
15:19 |
berick |
gmcharlt: oh cool, thanks |
15:20 |
dbwells |
#topic Evergreen Releases |
15:21 |
dbwells |
#info Evergreen 3.1.3 and 3.0.9 were released on 06/28/18 |
15:22 |
berick |
and 2.12 is now EOL? |
15:22 |
dbwells |
Thank you to all the Buildmaster folks who played a role on those releases. |
15:22 |
dbwells |
Yes, 2.12 is security only. |
15:22 |
berick |
i think we're past security, even (according to calendar) |
15:22 |
dbwells |
Ah, perhaps you are right. |
15:22 |
csharp |
dbwells++ #wranglin' |
15:22 |
gmcharlt |
https://wiki.evergreen-ils.org/doku.php?id=dev:release_process:schedule |
15:22 |
gmcharlt |
"It's dead, Jim!" |
15:23 |
dbwells |
#info A moment of silence was observed for 2.12. |
15:23 |
kmlussier |
Yes, we're past security. |
15:23 |
* gmcharlt |
edits it to add 3.1; will ask for double-checking my calculations in a omently |
15:24 |
dbwells |
berick: Anything to add for 3.2? |
15:24 |
kmlussier |
I can take 2.12 off the downloads page. |
15:24 |
berick |
5 weeks till feature slush for 3.2. |
15:24 |
berick |
i'd like to get some of the bigger ones merged earlier, though |
15:24 |
berick |
to limit the inevitible chaos |
15:25 |
berick |
feature list reminder: https://wiki.evergreen-ils.org/doku.php?id=faqs:evergreen_roadmap:3.2 |
15:25 |
|
khuckins_ joined #evergreen |
15:25 |
berick |
I'm prepared to merge 1766716 as soon as my final comments are addressed |
15:25 |
gmcharlt |
(https://wiki.evergreen-ils.org/doku.php?id=dev:release_process:schedule reading for double-checking) |
15:26 |
berick |
i have another item on that list noted already in this meeting |
15:26 |
berick |
anything else on that list ready ready for review? |
15:26 |
berick |
(that's not mine, anyway) |
15:27 |
berick |
in any event, i'm on hand to help reivew / merge any of those big-ticket items sooner than later |
15:27 |
dbwells |
berick++ |
15:27 |
dbwells |
Any questions for berick before we move ahead? |
15:27 |
miker |
berick: I shall comment thereon |
15:28 |
berick |
miker++ |
15:28 |
JBoyer |
berick++ |
15:29 |
dbwells |
#topic New Business |
15:29 |
dbwells |
#topic Feedback on bug #1750894 needed |
15:29 |
pinesol_green |
Launchpad bug 1750894 in Evergreen "Wishlist: Store web staff workstation settings on the server" [Wishlist,New] https://launchpad.net/bugs/1750894 |
15:29 |
berick |
carry over from last meeting, I should have added an action item |
15:30 |
berick |
this one's fairly disruptive and will require ang6 coding post-merge, so I'm hoping to merge well before the 3.2 cut-off |
15:30 |
berick |
and I expects a dragon or 2 may lurk, yar |
15:31 |
berick |
it could also affect other features in development |
15:31 |
kmlussier |
I can commit to looking at it over the next week. |
15:31 |
* JBoyer |
will also try to poke at it a bit soon |
15:32 |
JBoyer |
I have some thoughts re: workstations too. (for another time) |
15:32 |
dbwells |
berick: can you maybe explain a bit more about "require ang6 coding post-merge" ? |
15:32 |
* Dyrcona |
didn't get past blowing up his node installation with an upgrade to look at it. |
15:33 |
berick |
dbwells: if we have any desire to merge the ang6 stuff in 3.2, the client-side code from 1750894 will have to be ported for parity. i've been holding off on it in case any major changes occur in the bug. |
15:34 |
dbwells |
berick: Oh, I understand now, thanks. |
15:35 |
berick |
kmlussier: JBoyer: how many #action's can I put you down for? ;) |
15:35 |
berick |
i'll start with 1 |
15:35 |
dbwells |
I was thinking of the statement with the reverse effect, that somehow merging this would require us to use ang6 is some place. |
15:36 |
berick |
#action kmlussier and JBoyer to review https://launchpad.net/bugs/1750894 |
15:36 |
pinesol_green |
Launchpad bug 1750894 in Evergreen "Wishlist: Store web staff workstation settings on the server" [Wishlist,New] |
15:36 |
berick |
dbwells: ah, no, nothing like that |
15:36 |
JBoyer |
1 action is probably what I can commit to currently. ;) |
15:36 |
pinesol_green |
[evergreen|Mike Rylander] LP#1736269: Mark Missing Pieces is non-functional - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1524b7b> |
15:36 |
|
yboston joined #evergreen |
15:37 |
dbwells |
Well, that's the end of the agenda. Anything else for the good of the order? |
15:38 |
csharp |
well, as one of the newest core committers, I have found a need for some sort of procedural/best practices guide, which I'm willing to help create |
15:38 |
cesardv |
csharp++ |
15:38 |
csharp |
not sure if that's better as a hack-a-way-ish goal or what |
15:39 |
JBoyer |
the kind of high-bandwidth discussion that can be had in person seems helpful. |
15:39 |
csharp |
yeah, I was thinking the same thing, so maybe something to tack on to the hackaway agenda |
15:39 |
csharp |
I don't think it would take very long with the right people around |
15:40 |
dbwells |
Actually, I have one quick thing to mention as well. With the July 4th holiday, the buildmasters would like to push the July release back a week to 07/25. So that's the current plan unless there are strong objections. |
15:40 |
miker |
I OB-- no I don't |
15:40 |
JBoyer |
+1 |
15:41 |
kmlussier |
Either way. With csharp |
15:41 |
kmlussier |
gah |
15:41 |
kmlussier |
With csharp's merges, there's plenty to add to a release, but I don't mind waiting either. :) |
15:41 |
gmcharlt |
+1 |
15:41 |
csharp |
yeah, I'm just sweeping up signed-off or easily tested bugs |
15:43 |
dbwells |
okay, |
15:43 |
berick |
csharp++ |
15:43 |
dbwells |
#agreed July point releases will be scheduled for July 25 |
15:43 |
dbwells |
And with that... |
15:43 |
dbwells |
#endmeeting |
15:43 |
pinesol_green |
Meeting ended Wed Jul 11 15:43:44 2018 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
15:43 |
pinesol_green |
Minutes: http://evergreen-ils.org/meetings/evergreen/2018/evergreen.2018-07-11-15.03.html |
15:43 |
pinesol_green |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2018/evergreen.2018-07-11-15.03.txt |
15:43 |
pinesol_green |
Log: http://evergreen-ils.org/meetings/evergreen/2018/evergreen.2018-07-11-15.03.log.html |
15:43 |
JBoyer |
dbwells++ |
15:43 |
dbwells |
Thanks everyone |
15:44 |
remingtron |
dbwells++ |
15:44 |
berick |
thanks dbwells |
15:44 |
gmcharlt |
dbwells++ |
15:45 |
csharp |
dbwells++ |
15:45 |
jeff |
dbwells++ |
15:45 |
kmlussier |
dbwells++ |
15:45 |
|
rlefaive joined #evergreen |
15:45 |
miker |
dbwells++ |
15:49 |
miker |
berick: I thought the grid had HTML template compilation support. egGridField claims to offer it, but I don't see where it's used ... translateCellTemplate() doe not inspect the compiled flag on the column, it just uses $replace... (this is in re dates in the e-closing handler) |
15:51 |
berick |
miker: yeah, you should be able to insert html inside an eg-grid-field |
15:51 |
miker |
well, right |
15:51 |
miker |
but |
15:52 |
miker |
there's a compiled attr that's paired with a handlers attr for egGridField. the comment says it's for passing functions into the scope of the template when compiled |
15:52 |
miker |
but, that doesn't actually happen when the template is processed |
15:53 |
Dyrcona |
csharp: If you're looking for something easy to test, Lp 1780660 fits the bill to a t. :) |
15:53 |
pinesol_green |
Launchpad bug 1780660 in Evergreen "Add More Workstation Functions to OpenILS::Utils::TestUtils" [Wishlist,Confirmed] https://launchpad.net/bugs/1780660 |
15:53 |
miker |
it looks like that's attempting to signal to the grid that it should use $compile rather than $replace on the template |
15:54 |
miker |
berick: around line 1283 in grid.js |
15:54 |
berick |
ah, ok, I'm not actually familiar with that option. so the data in the 'item' is not sufficient, you need to pass in callbacks? |
15:55 |
berick |
ok, yeah, i'm seeing an example in cat/item/t_list.tt2 |
15:55 |
berick |
with compiled and a handlers=".." attribute |
15:56 |
miker |
well, it would be easier to inspect the type field on the closing, but we can't put logic in, just expressions |
15:56 |
berick |
gotcha |
15:56 |
mdriscoll |
I'm running into the same problem with upgrade script 3.0.1-3.0.2 as described in bug #1772028. |
15:56 |
pinesol_green |
Launchpad bug 1772028 in Evergreen 3.0 "Missing db functions in 3.0.1-3.0.2 upgrade script" [High,Confirmed] https://launchpad.net/bugs/1772028 |
15:56 |
miker |
but, I may be able to trick it into using egDueDate as I intended... |
15:56 |
mdriscoll |
Should I be concerned that script 1063 does not find what it needs to create the functions or just go ahead and create the missing functions? |
15:57 |
berick |
miker: curious if you tried setting it up like the example in cat/item/t_list.tt2 |
15:57 |
Dyrcona |
mdriscoll: It's likely the functions exist but have a slightly different name. I had this happen with one of them. |
15:57 |
miker |
berick: I doubt it ... I found the compiled flag after writing this code :) |
15:57 |
* miker |
looks |
15:57 |
Dyrcona |
It's OK to make the new functions, find the old one and then remove the old one. |
15:58 |
Dyrcona |
And, with that, I'm signing out. Stay cool, everyone! |
15:58 |
mdriscoll |
Dyrcona: thanks! |
16:00 |
miker |
gah, how is that even working... |
16:03 |
miker |
oooo... misdirection. the compile attr is a red herring, I think. the compile directive is doing the work. |
16:07 |
|
abowling joined #evergreen |
16:08 |
pinesol_green |
[evergreen|Garry Collum] LP#1730003 Courier code doesn't display in transit slip receipt preview - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=62c6706> |
16:10 |
pinesol_green |
[evergreen|a. bellenir] LP#1669856 and LP#1776557: right clicks on egGrid - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=999fb0b> |
17:04 |
|
mmorgan left #evergreen |
17:08 |
pinesol_green |
[evergreen|Bill Erickson] LP#1751368 Items-out checkin of deleted copies - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=23a21e4> |
17:12 |
pinesol_green |
[evergreen|Dan Wells] LP#1749795 Close circ on adjustment when rebilled - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a3adec2> |
18:05 |
|
beanjammin joined #evergreen |
18:28 |
pinesol_green |
[evergreen|Jason Stephenson] LP 1478712: Fix acq.fund_rollover_funds_by_org_tree DB function. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=bcdf3ae> |
18:31 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
19:36 |
|
hbrennan joined #evergreen |
20:15 |
|
abowling1 joined #evergreen |
23:59 |
|
lsach1 joined #evergreen |