Time |
Nick |
Message |
01:33 |
|
RBecker joined #evergreen |
06:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
06:59 |
|
agoben joined #evergreen |
07:14 |
|
rjackson_isl joined #evergreen |
07:25 |
|
stephengwills joined #evergreen |
07:29 |
|
dwgreen joined #evergreen |
07:39 |
|
collum joined #evergreen |
08:23 |
|
collum_ joined #evergreen |
08:43 |
|
kmlussier joined #evergreen |
08:45 |
|
idjit joined #evergreen |
08:49 |
|
mmorgan joined #evergreen |
08:55 |
|
bos20k joined #evergreen |
09:12 |
|
lsach joined #evergreen |
09:24 |
|
yboston joined #evergreen |
09:46 |
idjit |
good morning. creating a new branch for something like bug 1770752 seems silly. the fix is literally one line. is a branch easier to merge, or is this a case where i should've just attached a patch? does it make a difference from maintainers' perspective? |
09:46 |
pinesol_green |
Launchpad bug 1770752 in Evergreen "web client: Update Expire Date button does not cause "this page may have unsaved data" warning, when editing a patron account and navigating away unsaved." [Undecided,Confirmed] https://launchpad.net/bugs/1770752 |
09:47 |
kmlussier |
idjit: I've seen many branches with one-line fixes. In the end, it ultimately goes into a branch when it's merged, so it's better IMO to put it in a branch from the start. |
09:48 |
idjit |
kmlussier++ # ok, i'll continue doing that then. thanks! |
09:48 |
kmlussier |
idjit++ # Fixing bugs |
09:50 |
|
thblt joined #evergreen |
09:52 |
miker |
idjit: and it puts the code somewhere in a queue, in case a committer doesn't have time to handle it right then. and also records authorship. |
09:53 |
|
jvwoolf joined #evergreen |
09:54 |
idjit |
miker++ # good to know. ultimately, i want these things to be easier to deal with, so having insight to committer workflow is helpful |
09:55 |
|
thblt left #evergreen |
10:14 |
mmorgan |
phasefx: fyi bug 1775407 |
10:14 |
pinesol_green |
Launchpad bug 1775407 in Evergreen "Booking: Cannot find patron for picked-up reservations" [Undecided,New] https://launchpad.net/bugs/1775407 |
10:14 |
phasefx |
mmorgan++ |
10:16 |
|
jvwoolf joined #evergreen |
10:20 |
|
beanjammin joined #evergreen |
10:35 |
|
Christineb joined #evergreen |
10:41 |
|
khuckins_ joined #evergreen |
11:27 |
|
collum joined #evergreen |
12:11 |
|
jihpringle joined #evergreen |
12:55 |
|
terran joined #evergreen |
13:24 |
|
beanjammin joined #evergreen |
13:25 |
|
bwicksall joined #evergreen |
14:14 |
|
Dyrcona joined #evergreen |
14:52 |
|
sandbergja joined #evergreen |
14:56 |
csharp |
okay - I'm seeing breakage I and berick (?) have encountered before on master running AngularJS 1.6.9: |
14:56 |
csharp |
TypeError: copy_list[0].copy_alerts is not a function |
14:57 |
csharp |
I was going to see if adding a copy alert to a copy would prevent that message in "Item Status" but I'm getting the above variant of it when trying to add a copy alert |
14:58 |
csharp |
my working theory is that we need to be checking if the copy object has any alerts before trying that kind of thing |
14:59 |
* csharp |
is unclear on the copy_alerts().blah syntax in the first place :-/ |
14:59 |
csharp |
@monologue |
14:59 |
pinesol_green |
csharp: Your current monologue is at least 6 lines long. |
14:59 |
* berick |
looks up.. oh it's meeting time |
15:00 |
csharp |
wow, I'm actually paying attention when a dev meeting happens?! cool |
15:00 |
berick |
we having today's meeting and if so, anyone want to run it? |
15:01 |
gmcharlt |
berick: I can run it |
15:01 |
berick |
gmcharlt++ |
15:01 |
gmcharlt |
#startmeeting Development meeting, 6 June 2018 |
15:01 |
pinesol_green |
Meeting started Wed Jun 6 15:01:39 2018 US/Eastern. The chair is gmcharlt. Information about MeetBot at http://wiki.debian.org/MeetBot. |
15:01 |
pinesol_green |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
15:01 |
pinesol_green |
The meeting name has been set to 'development_meeting__6_june_2018' |
15:01 |
gmcharlt |
#info Agenda is https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2018-06-06 |
15:02 |
gmcharlt |
#topic Introductions |
15:02 |
gmcharlt |
#info gmcharlt = Galen Charlton, Equinox |
15:02 |
csharp |
#info csharp = Chris Sharp, GPLS |
15:02 |
jeffdavis |
#info jeffdavis = Jeff Davis, BC Libraries Coop |
15:02 |
remingtron |
#info remingtron is Remington Steed, Hekman Library (Calvin College) |
15:02 |
jeff |
#info jeff = Jeff Godin, Traverse Area District Library (TADL) |
15:02 |
dbwells |
#info dbwells = Dan Wells, Hekman Library (Calvin College) |
15:02 |
berick |
#info berick = Bill Erickson, KCLS |
15:03 |
abneiman |
#info abneiman = Andrea Neiman, EOLI |
15:05 |
JBoyer |
#info JBoyer = Jason Boyer, IN State Library |
15:05 |
miker |
#info miker = Mike Rylander, EOLI |
15:05 |
gmcharlt |
groovy |
15:05 |
gmcharlt |
#tpic Action Items from Last Meeting |
15:06 |
gmcharlt |
#item OpenSRF 3.0.1 was released |
15:06 |
gmcharlt |
#item gmcharlt did indeed write that blog post announcing 3.1.0 |
15:06 |
gmcharlt |
#item gmcharlt did indeed put out a call for 3.2 RM |
15:06 |
gmcharlt |
(... and then proceeded to VERY SNEAKILY dig a pit underneath berick) |
15:07 |
gmcharlt |
#action gmcharlt will open and work on bugs for documentation changes for better ejabberd configuration during installation of OpenSRF |
15:07 |
JBoyer |
There's a release manager in my tiger pit! |
15:07 |
berick |
heh |
15:07 |
gmcharlt |
any questions on those points? |
15:08 |
|
kmlussier_ joined #evergreen |
15:08 |
gmcharlt |
ok, moving on |
15:08 |
gmcharlt |
#topic OpenSRF release info |
15:08 |
gmcharlt |
#item OpenSRF 3.0.1 released |
15:08 |
gmcharlt |
hmm |
15:08 |
gmcharlt |
#info OpenSRF 3.0.1 released |
15:09 |
kmlussier |
#info kmlussier is Kathy Lussier, MassLNC |
15:09 |
kmlussier |
comcast-- |
15:09 |
csharp |
comcast-- |
15:09 |
gmcharlt |
anyway, I think the additinal work on the websockets code looks like it will warrant a 3.0.2 release later this month |
15:09 |
miker |
comcast-- # that one's for akilsdonk |
15:09 |
JBoyer |
The chunking/bundling changes? |
15:10 |
miker |
JBoyer: I think that's all on the evergreen side, if you mean csharp's work |
15:10 |
gmcharlt |
yeah, I was thinking more of bug 1774703 |
15:10 |
pinesol_green |
Launchpad bug 1774703 in OpenSRF "Websockets processes locked at 100% CPU" [Undecided,Confirmed] https://launchpad.net/bugs/1774703 |
15:10 |
JBoyer |
Ah, yes. |
15:10 |
Dyrcona |
charter-- |
15:11 |
* Dyrcona |
forgot about the meeting.... |
15:11 |
gmcharlt |
not that 1725317 isn't also a concern... but I think that has the potential to turn into something that warrants a /3.1.0/, as fixing it for real would entail updating some client javascript code |
15:11 |
Dyrcona |
#info Dyrcona is Jason Stephenson CW MARS |
15:12 |
Dyrcona |
On the topic at hand, I am testing that fix in production starting tonight. |
15:12 |
gmcharlt |
Dyrcona++ |
15:12 |
gmcharlt |
and also things like bug 1729610 might call for a 3.1 |
15:12 |
pinesol_green |
Launchpad bug 1729610 in OpenSRF "allow requests to be queued if max_children limit is hit" [Wishlist,New] https://launchpad.net/bugs/1729610 |
15:12 |
JBoyer |
+1 |
15:13 |
gmcharlt |
and bug 1626139 definitely would |
15:13 |
pinesol_green |
Launchpad bug 1626139 in OpenSRF "Deprecate OSRFGatewayLegacyJSON (/gateway)" [Low,Confirmed] https://launchpad.net/bugs/1626139 |
15:13 |
gmcharlt |
so, the more that I'm thinking about it, the more I think I'm talking myself into planning a 3.1.x series sooner rather than later |
15:13 |
gmcharlt |
possible as a minimum required version for 3.2 |
15:14 |
gmcharlt |
soooo.... berick in particular, thoughts on that? |
15:14 |
gmcharlt |
and are there other OpenSRF things you would particularly want for Evergreen 3.2? |
15:14 |
berick |
those all sound good to me |
15:15 |
JBoyer |
Where are we on the Plain/SASL deprecation timeline for ejabberd? |
15:15 |
berick |
good question |
15:15 |
* csharp |
is curious about that too |
15:15 |
JBoyer |
(Not to throw another log on the pile, but it also seems worthy of a X.y+1) |
15:16 |
Dyrcona |
Well, we (i.e. bshum and I) have not gotten OpenSRF to communicate with ejabberd on Ubuntu 18.04, yet. |
15:16 |
csharp |
right |
15:16 |
gmcharlt |
JBoyer: yeah, I think the question is whether to make it a goal for 3.1.x |
15:16 |
gmcharlt |
... which I think is at least reasonable to try for |
15:17 |
gmcharlt |
ok |
15:17 |
miker |
anyone want to volunteer to look for (at least) perl and C libs to leverage, either that hand the caller a socket (ideally) or manage the SASL stuff for us given a socket? |
15:17 |
csharp |
I think 18.04 support is a reasonable goal for the next release, but I know there are higher priorities |
15:18 |
gmcharlt |
#action gmcharlt will do a bugfix release of OpenSRF 3.0.2, particularly upon successful testing of bug 1774703 |
15:18 |
pinesol_green |
Launchpad bug 1774703 in OpenSRF "Websockets processes locked at 100% CPU" [Undecided,Confirmed] https://launchpad.net/bugs/1774703 |
15:18 |
miker |
(and, can we target a version of ejabberd, rather than a disto release? |
15:18 |
gmcharlt |
#action gmcharlt will put out a call for roadmap entries for OpenSRF 3.1.0 |
15:18 |
csharp |
miker: yeah, was just looking to see what's going on with Debian |
15:18 |
gmcharlt |
yeah, all other things being equal, targetting an ejabberd version level seems better |
15:19 |
gmcharlt |
ok, moving on |
15:19 |
gmcharlt |
#topic Evergreen release update |
15:19 |
gmcharlt |
berick: you have the floor |
15:19 |
berick |
k... |
15:19 |
berick |
first off, quick reminder of https://wiki.evergreen-ils.org/doku.php?id=faqs:evergreen_roadmap:3.2 |
15:20 |
berick |
if there are any other big ticket items, will be good to have them in the list |
15:21 |
berick |
early in the cycle, so I don't have much else to report on 3.2 at the moment. happy to field questions, though |
15:22 |
gmcharlt |
berick: one thing I'm kinda hoping for is the Angular stuff to get in sooner rather than later |
15:23 |
berick |
hey, that segues nicely into my next agenda item ;) |
15:23 |
gmcharlt |
heh |
15:24 |
berick |
one final 3.2. thing before we move on, thanks for all the work on these, and keep up the awesome work: https://bugs.launchpad.net/evergreen/+bugs?field.tag=webstaffblocker |
15:25 |
berick |
so the Angular stuff... |
15:25 |
berick |
i'm hoping everyone had a chance to glance at https://wiki.evergreen-ils.org/doku.php?id=dev:browser_staff:angjs_to_ang_migration#migration_strategy_proposal |
15:25 |
berick |
i know we talked about it some in IRC already |
15:26 |
berick |
i'm looking to get input both on the dev plan and the timing |
15:26 |
berick |
becuase it will impact 3.2. |
15:26 |
berick |
if nothing else, how we allocate resources |
15:27 |
gmcharlt |
one comment regarding the timing: I feel like we should try to get /something/ visible (other than just the navbar) present in 3.2 as a Angular app |
15:27 |
miker |
question: |
15:28 |
gmcharlt |
even if it's nothing more than just a minor egrid-based admin interface page |
15:28 |
miker |
is template /nesting/ possible in angular6? a la base.tt2, so we don't have to repeat ourselves for wrappers? |
15:28 |
csharp |
*cough* Library Settings Editor |
15:28 |
berick |
gmcharlt: as it stands, I have ported quite a few admin UI's already. |
15:29 |
gmcharlt |
berick: ah, OK |
15:29 |
JBoyer |
The staff opac would certainly be something and the fact that F-key shortcuts would always work would stop any complaints about functionality cold. (at some of our libs, anyway) |
15:29 |
* csharp |
thought of the staff OPAC too |
15:29 |
berick |
and I'm also in favor of earlier deployment -- i didn't want to be pushy in my timelines :) |
15:30 |
gmcharlt |
we'd also want to be sure that we're exposing strings for translation |
15:30 |
berick |
miker: it's certainly possible to have components that load other components within them |
15:31 |
berick |
miker: not sure if that exactly answers your question, but if you give me a specific example, I could probably scetch something out |
15:31 |
berick |
JBoyer: the staff opac would be a pretty tall order for 3.2 unless we make it a big priority |
15:31 |
miker |
berick: my hope is that we can avoid having to touch a bunch of files when, say, we add an attribute to a component |
15:31 |
berick |
there's still a lot of work to do on the staff opac |
15:32 |
berick |
for 3.2 i'm thinking navbar and a nice set of admin UI's is a good target |
15:32 |
JBoyer |
I wasn't sure how far complete it was, having only poked at it a little bit on your demo server. I'd probably prioritize ditching dojo ahead of that then. |
15:32 |
|
kmlussier joined #evergreen |
15:32 |
csharp |
+1 to ditching dojo |
15:32 |
gmcharlt |
berick: (and the batch OPAC actions project would add another functional point to be reimplemented in an Angular staff OPAC - namely, multi-select of records from search results) |
15:33 |
berick |
*nods* |
15:34 |
berick |
BTW I occasionally add notes to https://wiki.evergreen-ils.org/doku.php?id=dev:browser_staff:angjs_to_ang_migration#notes |
15:34 |
|
hbrennan joined #evergreen |
15:34 |
* berick |
has more notes to add for today |
15:35 |
csharp |
berick++ |
15:35 |
dbwells |
berick++ |
15:36 |
berick |
how can I better expose what I'm working on? do we need a temporary repository? should I migrate my branch to a collab branch? |
15:36 |
csharp |
gitlab! |
15:36 |
berick |
it does take a little getting used to, so I'd like to avoid as many surprises as possible |
15:37 |
* csharp |
plans to install berick's branch on his test/dev server this week |
15:37 |
berick |
csharp: cool, holler if I can help |
15:37 |
csharp |
will do |
15:37 |
gmcharlt |
berick: +1 to a collab branch |
15:37 |
JBoyer |
A collab branch sounds good |
15:37 |
csharp |
agreed |
15:38 |
berick |
sounds good. I'll open a LP for that too |
15:38 |
gmcharlt |
berick: and would it be useful to call a special IRC meeting? |
15:38 |
gmcharlt |
or a webinar from which you could do a show-and-tell? |
15:38 |
Dyrcona |
csharp: I tried upgrading node on an existing vm and got nothing but errors afterward. |
15:39 |
Dyrcona |
This was related to testing the ang6 branch. I have not had time to go back and try again. |
15:39 |
csharp |
Dyrcona: ah - good to know |
15:39 |
berick |
gmcharlt: i would be happy to participate |
15:39 |
gmcharlt |
ok |
15:39 |
berick |
whatever works best for everyone |
15:39 |
gmcharlt |
#action gmcharlt to work with berick to see about setting up some kind of presentation/meeting to discuss angular |
15:40 |
gmcharlt |
in the interest of time, any other Evergreen topics to discuss not otherwise on the agenda? |
15:40 |
* miker |
suspects he can guess the main hack-a-way activity |
15:40 |
berick |
:) |
15:40 |
gmcharlt |
miker: we should tell rhamby to book the CIRCULAR room, natch ;) |
15:40 |
JBoyer |
"You can have lunch AFTER the OU Editor is written in Ang6!" |
15:40 |
miker |
heh |
15:41 |
csharp |
wowsers - 73 commits so far in the ang6 branch |
15:41 |
gmcharlt |
ok, so moving on |
15:41 |
gmcharlt |
#topic Hatch update |
15:41 |
rhamby |
gmcharlt: I'll see what we can do :) |
15:41 |
gmcharlt |
rhamby++ |
15:42 |
berick |
Hatch will be affected by the Feedback agenda item below |
15:42 |
berick |
i'm not aware of any major Hatch changes since the last meeting though |
15:42 |
berick |
IIRC, the Dymo issue is still pending |
15:42 |
gmcharlt |
any news on the Firefox addon? |
15:42 |
JBoyer |
Firefox support was kind of a hassle... |
15:42 |
JBoyer |
Did I not pullrequest it? It's done. |
15:43 |
gmcharlt |
ah, cool |
15:43 |
berick |
JBoyer: oh, cool, i missed that |
15:43 |
* csharp |
still hasn't arranged a good environment to test JBoyer's branch on Windows |
15:43 |
gmcharlt |
#info the Firefox add-on for Hatch is available |
15:43 |
JBoyer |
Not merged and not updated, but I've seen the printer list in both browsers simultaneously. |
15:43 |
JBoyer |
updated -> uploaded. |
15:44 |
csharp |
JBoyer: I have credentials to the FF addons site, FYI |
15:44 |
JBoyer |
I thought you could upload the updated version once you're satisfied it's working, unless you'd rather I do it. |
15:45 |
csharp |
JBoyer: can do |
15:45 |
gmcharlt |
what's the relevant bug for that change? |
15:45 |
csharp |
bug 1731922 |
15:45 |
pinesol_green |
Launchpad bug 1731922 in Evergreen "Firefox add-on for Hatch" [Wishlist,Confirmed] https://launchpad.net/bugs/1731922 |
15:46 |
JBoyer |
csharp++ |
15:46 |
gmcharlt |
#action csharp will upload an update for the Hatch FF add-on |
15:46 |
gmcharlt |
so, moving on |
15:46 |
gmcharlt |
I think we discuss the Angular migratio plan sufficiently? |
15:46 |
gmcharlt |
so... |
15:47 |
gmcharlt |
#topic New business - What form will XUL deprecation take in 3.2? Are we removing the code? |
15:47 |
berick |
another one I added |
15:47 |
berick |
just want to get sense of the scope |
15:47 |
JBoyer |
I was under the impression that deprecation started at 3.0 and 3.2 was the drop dead date. |
15:47 |
berick |
and if we need a XUL Removal Tzar |
15:47 |
JBoyer |
re, release. |
15:47 |
gmcharlt |
I think we should plan on removing it entirely |
15:48 |
dbwells |
+1 to gutting it |
15:48 |
gmcharlt |
or at least go through the effort of ensuring that it works without it |
15:48 |
gmcharlt |
and unless somebody else wants to start it, I'm happy to start a XUL removal branch |
15:48 |
berick |
gmcharlt++ |
15:49 |
JBoyer |
gmcharlt++ |
15:49 |
miker |
note: there are some things that live under xul/server/ that are used in the web staff client, IIRC ... because they're actually html |
15:49 |
gmcharlt |
miker: indeed - exactly the sort of issue to flush out |
15:49 |
berick |
gmcharlt: one word of caution, and this plays nicely with the Angular / admin UI stuff -- there's a smattering of html UI's in the XUL directory ... |
15:49 |
csharp |
our catalogers are still on XUL and we'll need things like the omnibus bug done before our folks will even consider moving off it |
15:49 |
berick |
jinx |
15:49 |
miker |
do we risk moving those, or just leave out xulrunner |
15:50 |
gmcharlt |
miker: I think a full removal should be the goal, with removing just the bits that build the XUL client as a fallback |
15:50 |
|
kmlussier_ joined #evergreen |
15:50 |
miker |
if the latter, it would be possible, in theory, for PINES to keep using the xul client with appropriate symlinks |
15:50 |
Bmagic_ |
Anyone know anything about AstCall.pm, specifically RPC::XML::Client and UDP? It looks like the Astericks server on the other end is configured for UDP and from what I can gather, the Evergreen server is talking on TCP. |
15:50 |
miker |
ok |
15:50 |
Bmagic_ |
Ooops, meeting |
15:51 |
berick |
if the number of mixed-in UI's is low enough, we could make those the UI's that should be ported first to Angular |
15:51 |
kmlussier_ |
+1 to full removal being the goal |
15:51 |
JBoyer |
That's a good plan |
15:51 |
kmlussier |
also, comcast-- |
15:52 |
gmcharlt |
csharp: and I think we can meet in the middle - i.e., if we fail to make it w/o webstaff blockers, I'll aim to design the XUL removal so that it can be readily reverted |
15:52 |
csharp |
gmcharlt: works for me |
15:52 |
gmcharlt |
but in any event, given general support (and funding) for fixing those blockers, I'm fairly optimistic that those bugs will be squashed in time for 3.2 |
15:52 |
Dyrcona |
Should we remove it if there are still webstaff blockers, though? |
15:52 |
gmcharlt |
and that many of those fixes will make it to 3.1.x |
15:53 |
kmlussier |
I don't think we should release 3.2 with the webstaff blockers. |
15:53 |
csharp |
terran and I were just discussing yesterday that we'd like to have a webstaff-only upgrade in January with the XUL client quietly in reserve just in case |
15:53 |
gmcharlt |
Dyrcona: I think we should be living on a master with XUL removed sooner rather than later, at least during the dev runup to 3.2 |
15:54 |
csharp |
btw, despite my concerns about timing and being able to revert, I'm totally on board with full removal as soon as possible |
15:54 |
Dyrcona |
Well, that's an incentive to fix the bugs. :) |
15:54 |
berick |
burn the ships :) |
15:55 |
Dyrcona |
Actually, if you leave the files in /openils/var/web/xul. There's not thing stopping a site from continuing to use XUL. |
15:55 |
terran |
My concern is that until our catalogers are able to get past this first set of webstaff blockers and use the web client fully, we won't know if there are other blockers we haven't discovered yet. |
15:55 |
gmcharlt |
berick: just call me Hector ;) |
15:56 |
terran |
But yes, I'm also eager to get everyone moved over to the web client |
15:56 |
berick |
re: using old XUL files.. there's also the concern that webstaff code could break XUL functionality -- just having the files is not a guarantee XUL will work completely |
15:57 |
berick |
we've avoided that through 3.1 |
15:57 |
JBoyer |
That's already started. there's a bug someone here needs to file to that very effect. copy alert matrix unhappiness with the xul quick item add... |
15:57 |
berick |
but I think the gloves are off now |
15:57 |
JBoyer |
(Il'l write it up later) |
15:57 |
berick |
ah |
15:58 |
rjackson_isl |
JBoyer: https://bugs.launchpad.net/evergreen/+bug/1775240 |
15:58 |
pinesol_green |
Launchpad bug 1775240 in Evergreen "Fast Item Add Fails from Legacy Staff Client after Latest Upgrade " [Undecided,New] |
15:58 |
Dyrcona |
My understanding is that new copy alerts are not supposed to work in xul, but yeah. |
15:58 |
JBoyer |
Hey, look at me forgetting. |
15:58 |
JBoyer |
rjackson_isl++ |
15:59 |
* Dyrcona |
rushes off to set it Won't Fix. :P |
15:59 |
JBoyer |
Maybe read it first, ;p |
15:59 |
Dyrcona |
TL;DR. |
15:59 |
kmlussier |
But it shouldn't prevent you from adding a copy in xul. |
15:59 |
berick |
in <= 3.1 anyway |
16:00 |
gmcharlt |
anyway, need to move on in the agenda |
16:00 |
* csharp |
has to jet but will read scrollback |
16:00 |
gmcharlt |
#topic Bug #1750894 |
16:00 |
pinesol_green |
Launchpad bug 1750894 in Evergreen "Wishlist: Store web staff workstation settings on the server" [Wishlist,New] https://launchpad.net/bugs/1750894 |
16:00 |
berick |
big-ish change, hoping to merge sooner than later. it also impacts the Angular stuff pretty heavily |
16:00 |
miker |
I'll put some eyeball time on the server-settings branch |
16:01 |
berick |
thanks miker |
16:02 |
gmcharlt |
ok |
16:02 |
gmcharlt |
finally |
16:02 |
gmcharlt |
#topic Next meeting |
16:02 |
gmcharlt |
the auto-schedule for the next dev meeting puts it on a US holiday, 4 July |
16:02 |
gmcharlt |
shall we move it to 11 July? |
16:02 |
|
khuckins_ joined #evergreen |
16:02 |
miker |
+1 |
16:02 |
berick |
+1 |
16:02 |
JBoyer |
+1 |
16:02 |
Dyrcona |
+1 |
16:03 |
Bmagic |
+1 |
16:03 |
kmlussier |
+1 |
16:04 |
gmcharlt |
#agreed Next dev meeting will be held on 11 July |
16:04 |
gmcharlt |
thanks, folks! |
16:04 |
gmcharlt |
#endmeeting |
16:04 |
pinesol_green |
Meeting ended Wed Jun 6 16:04:08 2018 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
16:04 |
pinesol_green |
Minutes: http://evergreen-ils.org/meetings/evergreen/2018/evergreen.2018-06-06-15.01.html |
16:04 |
pinesol_green |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2018/evergreen.2018-06-06-15.01.txt |
16:04 |
pinesol_green |
Log: http://evergreen-ils.org/meetings/evergreen/2018/evergreen.2018-06-06-15.01.log.html |
16:04 |
kmlussier |
gmcharlt++ |
16:04 |
Dyrcona |
gmcharlt++ |
16:04 |
berick |
thanks gmcharlt |
16:04 |
JBoyer |
gmcharlt++ |
16:04 |
abneiman |
gmcharlt++ |
16:04 |
miker |
gmcharlt++ |
16:04 |
remingtron |
gmcharlt++ |
16:04 |
remingtron |
berick++ #3.2 rm-ing |
16:06 |
dbwells |
gmcharlt++ |
16:06 |
JBoyer |
csharp, depending on the issue you're running into on Windows https://www.mozilla.org/en-US/firefox/developer/ may help. It will allow you to load an unpacked extension. Unless the issue is you don't have a windows install nearby, in which case more work may be needed. ;) |
16:10 |
kmlussier |
The dev calendar has been updated with the July 11 meeting date. |
16:12 |
Dyrcona |
kmlussier++ |
16:23 |
kmlussier |
@quote random |
16:23 |
pinesol_green |
kmlussier: Quote #119: "< Dyrcona> I'm only fluent in English. It's not as good as my Perl. :)" (added by csharp at 03:40 PM, June 19, 2015) |
16:31 |
Bmagic |
Sorry I so rudely asked a question during meeting. |
16:41 |
hbrennan |
permissions experts.... what is the permission to asign access to Local > Hold Policies? I can't find it..... |
16:42 |
hbrennan |
search for "hold" in the lists of evergreen permissions isn't coming up with anything |
16:43 |
berick |
would it be ADMIN_HOLD_MATRIX_MATCHPOINT ? |
16:59 |
csharp |
JBoyer: it's the "no Windows nearby" issue - I'll find something to test with tomorrow :-) |
16:59 |
hbrennan |
berick: Thanks. Will try that. |
16:59 |
gmcharlt |
csharp: that thing that is both a problem... and gloriously not a problem ;) |
17:08 |
|
mmorgan left #evergreen |
17:10 |
csharp |
gmcharlt: exactly :-) |
17:12 |
|
kmlussier joined #evergreen |
17:15 |
berick |
csharp: you logging SQL? wondering if you can get an SQL example for bug 1724029 |
17:15 |
pinesol_green |
Launchpad bug 1724029 in Evergreen "Web Client: Patron Search sorted by last name not working as expected" [High,Confirmed] https://launchpad.net/bugs/1724029 |
17:15 |
berick |
see if we can narrow it down to a sql issues vs a UI issue |
17:16 |
berick |
well.. |
17:16 |
berick |
i know what the sql is, you'd need to look at what the SQL returns and see if the rows are correctly sorted in the DB |
17:20 |
csharp |
berick: I can help |
17:21 |
csharp |
yeah, we log statements, so we can get them, but if you already know something I can run... |
17:22 |
berick |
csharp: it would be good for you to test whatever SQL is coming over the wire there |
17:23 |
berick |
just run the sql in psql and reivew the output and see if it matches the issues reported in the UI |
17:23 |
berick |
or if the output looks right where the UI looks wrong |
17:23 |
berick |
csharp++ |
17:24 |
berick |
huh, no way to mark an LP as done/complete/mission-accomplished short of marking it fix released. |
17:24 |
berick |
which is odd when there's no code |
17:24 |
berick |
oh well |
17:25 |
gmcharlt |
"this fix is too large to be contained within the confines of this tarball..." |
17:29 |
berick |
:) |
17:29 |
berick |
also known as the "You're not the boss of me" status |
17:37 |
kmlussier |
berick: I usually mark those as a duplicate of whatever accomplished the mission or mark it Incomplete. |
17:37 |
csharp |
"... and you're not so big.." |
17:37 |
kmlussier |
Sorry, not Incomplete. Invalid. |
17:41 |
csharp |
berick: confirmed that DB sorts correctly |
17:42 |
csharp |
so it's gotta be something higher up |
17:46 |
* csharp |
adds comment and SQL to bug |
17:51 |
berick |
thanks csharp |
17:53 |
berick |
csharp: if/when you're up for it, running the matching API call in srfsh to see what it returns (compared to the sql output) would be great. should see an API call in the activity log for open-ils.actor.patron.search.advanced.fleshed |
17:53 |
berick |
which returns a stream of patron objects |
17:54 |
berick |
takes some squinting to find the names in the json output, unfortunately |
18:00 |
|
jvwoolf left #evergreen |
18:01 |
csharp |
berick: k - will do |
18:05 |
csharp |
berick: yep - it's out of order |
18:06 |
csharp |
and the order matches what's in the UI |
18:09 |
berick |
ah, so the api is busted |
18:10 |
berick |
that's odd cuz it's just looping over the ids returned from the db. |
18:10 |
berick |
oh well, will revisit tomorrow |
18:10 |
csharp |
berick: k - thanks! |
18:10 |
berick |
thanks csharp |
18:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
18:59 |
|
dickreckard left #evergreen |