Evergreen ILS Website

IRC log for #evergreen, 2018-04-23

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
00:54 beanjammin joined #evergreen
06:31 pinesol_green News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:30 rjackson_isl joined #evergreen
08:40 mmorgan joined #evergreen
08:41 stephengwills joined #evergreen
08:47 csharp morning, all - I'm trying to rewrite a JS fix "correctly" (that is, as efficiently as possible) and I'm going a bit crosseyed...
08:48 csharp this_year.length ? (Number(this_year[0].count()) + Number(this_year[1].count())) : 0;
08:48 csharp the problem with this is that this_year[1] may be undefined and I'm trying to correct for that
08:48 csharp I don't see a better way that using if statements, but I'm not sure if I now need to define a function that returns a value
08:49 dbwells joined #evergreen
08:49 jaswinder joined #evergreen
08:49 csharp (this is the JS that calculates circ counts in the detailed item status view - see bug 1746300 )
08:50 pinesol_green Launchpad bug 1746300 in Evergreen "Item Status screen - Total Circs Current and Prev Incorrect" [Undecided,Confirmed] https://launchpad.net/bugs/1746300 - Assigned to Jeff Davis (jdavis-sitka)
08:57 csharp I know this isn't right, but this is kind of what I'm thinking: https://pastebin.com/T1ZY3h1T
08:59 bos20k joined #evergreen
09:05 dbwells csharp: The old code totaled in a for loop.  I think that still seems reasonable if we don't know whether this_year is one or two items long.
09:08 csharp dbwells: do you have the file path handy for the old code?
09:09 dbwells csharp: Evergreen/Open-ILS/xul/staff_client/buil​d/server/circ/alternate_copy_summary.js
09:09 dbwells csharp: look for FM_CIRC_IMPROVED_COUNT_VIA_COPY
09:10 csharp dbwells: thanks!
09:16 dbwells csharp: I generally wouldn't troll through the XUL JS code for style pointers, but in this case at least we know this code works :)
09:16 csharp right :-)
09:20 kmlussier joined #evergreen
09:23 Christineb joined #evergreen
09:25 yboston joined #evergreen
09:39 jvwoolf joined #evergreen
10:02 mmorgan1 joined #evergreen
10:06 jaswinder Hey guys, Is it possible to retrieve user by barcode  without authenticated session? I tried passing in anonymous string, it did not work
10:07 berick jaswinder: you have to be authenticated and have permissions to retrieve user data
10:08 jaswinder thanks berick! I wish there was a built-in way to do this
10:17 dbwells jaswinder: This is from the service code you have been working on, right?  If so, use cstore.  No authentication needed for that.
10:17 jaswinder That is correct!
10:17 berick ugh, sorry jaswinder, i assumed you meant from outside the system.
10:18 jaswinder With cstore, I can use this api: open-ils.actor.user.fleshed.retrieve_by_barcode?
10:20 dbwells jaswinder: Not exactly, but you don't have to.  You can just access the data directly.
10:20 dbwells jaswinder: Very similar to what you have done using pcrud.
10:20 jaswinder dbwells: Let me try this then
10:25 dbwells jaswinder: That said, at some point you are going to need to consider security implications of your service.  If your client-facing API call doesn't require an authtoken or do a permissions check, then everything you give back must be public information.
10:29 jaswinder dbwells: The APIs will only return data from authenicated sessions. I need some of info for patron registration at vendor site.
10:29 mmorgan joined #evergreen
10:31 dbwells If your initial call itself requires an authtoken, then this opens up the possibility of using all the other authenticated API methods (such as open-ils.actor.user.fleshed.retrieve_by_barcode), as you can start passing that same token through to these service-to-service calls.  There may be individual permission hoops to jump through in that case, though.
10:31 collum joined #evergreen
10:34 beanjammin joined #evergreen
11:21 hbain joined #evergreen
11:45 idjit joined #evergreen
11:54 khuckins joined #evergreen
11:54 jaswinder dbwells: cstore worked for me. The issue here is that I need to retrieve user information from /EbookAPI/NewVendor.pm file which I asked about it before. I cannot get that without a token. So, cstore seems viable option
12:01 dbwells joined #evergreen
12:15 beanjammin joined #evergreen
12:17 beanjammin joined #evergreen
12:18 jaswinder joined #evergreen
12:19 jvwoolf joined #evergreen
12:42 jaswinder joined #evergreen
12:45 jihpringle joined #evergreen
13:12 pinesol_green [evergreen|Mike Rylander] LP#1745233: Don't test for LURIs during copy location searches - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=61d6e6c>
14:50 remingtron joined #evergreen
15:04 mmorgan1 joined #evergreen
15:05 jaswinder Does anyone know how I can change user password?
15:07 jaswinder It appears changing directly at table level (usr.password) does not work.
15:10 dbwells jaswinder: usr.password is now a placeholder, as the passwords are kept in a separate table due to security related changes.
15:11 jaswinder is there a way that I can change it. I need some test accounts and I want to change password for existing accounts
15:11 dbwells jaswinder: take a look at actor.set_passwd() (a database function).  It can probably help you out.  Otherwise, change it in the client :)
15:11 jaswinder okay thanks
15:12 dbwells jaswinder: new passwords are now in actor.passwd, by the way
15:12 jaswinder Okay, understood. I will note it down
15:13 berick see also Actor.pm:modify_migrated_user_password()
15:14 Bmagic I'm having a problem with pre-cat items on the items out screen. The title/author is not being populated. I can't remember if that is normal but we are getting complaints
15:19 kmlussier Bmagic: Using the Precat Dummy Title and Precat Dummy Author column picker options?
15:19 Bmagic Didn't see those in the items out (XUL)
15:20 Bmagic When checking them out, it shows it and I can confirm that it's being recorded in the DB
15:21 kmlussier Bmagic: You're right. I didn't realize they populate the standard title/author columns in xul. It's working for me.
15:22 kmlussier I wonder if people are going to dislike the additional column picker options in the web client.
15:22 Bmagic It's gotta me something in the fm_IDL
15:22 Bmagic me/be
15:25 kmlussier Actually, the precat title/author columns shows the precat data as well. Why do we have special columns for the precat dummy information?
15:26 Bmagic I might have found it
15:26 Bmagic related to this again: bug 1228392
15:26 pinesol_green Launchpad bug 1228392 in Evergreen "Item does not link to Monograph Parts in Evergreen Reports Module " [Medium,Triaged] https://launchpad.net/bugs/1228392
15:26 Christineb joined #evergreen
15:27 Bmagic I have a hard time connecting that fix with this issue, but it has something to do with columns in ac being "off"
15:29 khuckins joined #evergreen
15:29 kmlussier Bah! I meant to say the *standard* title/author columns are showing precat data in the web client too.
15:32 yboston joined #evergreen
15:43 Bmagic Well, It's not the IDL
15:58 Bmagic kmlussier: on your machine where it's working, do you have the reporter_extend schema?
16:01 kmlussier Bmagic: No
16:01 Bmagic alright
16:11 jvwoolf joined #evergreen
16:19 mmorgan joined #evergreen
17:04 mmorgan left #evergreen
17:27 jvwoolf joined #evergreen
17:37 Bmagic In theory, sub flesh_circ located in Actor.pm - has a line if($circ->target_copy->call_number->id == OILS_PRECAT_CALL_NUMBER) which should fill out the title and author for pre-cats when viewing items out right?
17:38 Bmagic provided that the ac.call_number = -1 (which it does) - I edited Actor.pm and added some log lines. When retrieving the patron items out, I am not seeing my logs. Perhaps this block of code isn't executed when viewing items out?
17:42 jaswinder joined #evergreen
17:46 jvwoolf left #evergreen
18:03 jaswinder joined #evergreen
18:23 beanjammin joined #evergreen
18:28 dbwells Bmagic: You are not seeing the Title/Author for precats in the XUL items out, is this correct?
18:30 dbwells Bmagic: If so, I'd be curious about your output for this in srfsh:
18:30 dbwells request open-ils.circ open-ils.circ.fleshed.retrieve.authoritative <some precat circ id here>
18:31 dbwells Particularly the "mvr" member of the top hash.
18:31 pinesol_green News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:56 jaswinder joined #evergreen
20:20 beanjammin joined #evergreen
20:29 jaswinder joined #evergreen
21:49 jaswinder joined #evergreen
21:57 jaswinder joined #evergreen

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat