| Time |
Nick |
Message |
| 00:36 |
|
jaswinder joined #evergreen |
| 05:01 |
|
yar joined #evergreen |
| 05:36 |
|
jaswinder joined #evergreen |
| 06:31 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:13 |
|
rjackson_isl joined #evergreen |
| 07:49 |
|
jaswinder joined #evergreen |
| 07:56 |
|
ngf42 joined #evergreen |
| 08:07 |
|
collum joined #evergreen |
| 08:25 |
|
dwgreen joined #evergreen |
| 08:29 |
|
kmlussier joined #evergreen |
| 08:37 |
|
jonadab joined #evergreen |
| 08:38 |
|
Dyrcona joined #evergreen |
| 08:52 |
|
agoben joined #evergreen |
| 08:53 |
|
mmorgan joined #evergreen |
| 08:59 |
|
bos20k joined #evergreen |
| 09:01 |
|
mmorgan1 joined #evergreen |
| 09:05 |
|
jaswinder joined #evergreen |
| 09:13 |
|
jvwoolf joined #evergreen |
| 09:14 |
|
jaswinder joined #evergreen |
| 09:24 |
|
jvwoolf1 joined #evergreen |
| 09:34 |
|
mmorgan1 left #evergreen |
| 09:47 |
|
rlefaive joined #evergreen |
| 09:58 |
|
jaswinder joined #evergreen |
| 10:12 |
|
annagoben joined #evergreen |
| 10:15 |
|
rlefaive joined #evergreen |
| 10:29 |
|
rlefaive joined #evergreen |
| 10:33 |
|
rlefaive joined #evergreen |
| 10:45 |
|
rlefaive joined #evergreen |
| 10:46 |
JBoyer |
Dyrcona, this seems relevant to some past discussions we've had: https://arstechnica.com/gadgets/2018/04/practical-passwordless-authentication-comes-a-step-closer-with-webauthn/ |
| 10:48 |
Dyrcona |
Well, I didn't plan to go that far. |
| 10:51 |
|
rlefaive joined #evergreen |
| 10:53 |
JBoyer |
I haven't given the standard that close a read, but some of the examples did sound a little over the top. (visit site on laptop/pc, click signin with phone. Do that on phone. Go back to laptop/pc. Repeat for every site...) |
| 10:54 |
JBoyer |
The fact that it will actually have some browser adoption will be interesting though, maybe it will have some chance of raising the tide, so to speak. |
| 10:56 |
csharp |
honestly if browsers can support some sort of keygen system with short expiration times that's tied to your OS user credentials or something, it would be both convenient and (theoretically) secure |
| 10:57 |
Dyrcona |
IDK, we've had client certificates since like, forever..... |
| 10:57 |
|
rlefaive joined #evergreen |
| 10:57 |
Dyrcona |
:) |
| 11:23 |
|
jaswinder joined #evergreen |
| 11:24 |
Bmagic |
Is there a setting somewhere that makes staff-placed holds default the pickup location to the staff branch and not the patron? |
| 11:25 |
|
Christineb joined #evergreen |
| 11:25 |
|
jaswinder joined #evergreen |
| 11:28 |
Dyrcona |
Bmagic: Yes, in 3.1. |
| 11:28 |
Bmagic |
ah! That might be where I saw it |
| 11:28 |
Dyrcona |
Lp 1699838 |
| 11:28 |
Bmagic |
Older versions of EG prefer the patron pickup location when the barcode is typed into the box? |
| 11:28 |
pinesol_green |
Launchpad bug 1699838 in Evergreen "OU setting needed for default pickup location for staff placed holds" [Medium,Fix released] https://launchpad.net/bugs/1699838 |
| 11:29 |
Dyrcona |
Bmagic: Only after 2.10 or so, prior to that it was staff home ou, IIRC. |
| 11:29 |
Dyrcona |
There was another bug that fixed it the way PINES wanted it. |
| 11:30 |
Dyrcona |
Bmagic: That branch on 1699838 is a straightforward backport if you want it on 3.0. |
| 11:30 |
Bmagic |
I see |
| 11:30 |
Dyrcona |
We're likely going to use it on 3.0 when we upgrade. |
| 11:31 |
Bmagic |
we are trying to look into a complain that the software is choosing the staff library instead of patron for holds |
| 11:31 |
Bmagic |
which doesn't seem like it should be doing that with stock 3.0.4 |
| 11:31 |
Bmagic |
sorry, 3.0.2 |
| 11:32 |
Dyrcona |
No, it shouldn't. |
| 11:32 |
Dyrcona |
Do you have commit 6739b7df88b605ec4ac36fb749c3ea6e7cec8e92 |
| 11:32 |
pinesol_green |
Dyrcona: [evergreen|Mike Rylander] LP#1167541: Use Patron home org for pickup lib instead of staff's - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6739b7d> |
| 11:33 |
Bmagic |
it's not there when searching git log |
| 11:33 |
Dyrcona |
Well, that's your problem. It never made it into your 3.0. |
| 11:34 |
Bmagic |
weird |
| 11:34 |
Dyrcona |
Depends on how/when you made your branch. |
| 11:34 |
Bmagic |
git branch shows tags/rel_3_0_2 |
| 11:35 |
Bmagic |
but if I search for the LP number, I do have it |
| 11:35 |
Bmagic |
commit is baaddaf0bc30a9f6 |
| 11:35 |
pinesol_green |
Bmagic: [evergreen|Mike Rylander] LP#1167541: Use Patron home org for pickup lib instead of staff's - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=baaddaf> |
| 11:35 |
Dyrcona |
That appears to be the commit hash from rel_2_12. :) |
| 11:35 |
Bmagic |
is that bad? |
| 11:35 |
Dyrcona |
No. |
| 11:35 |
Dyrcona |
We cherry-pick so commit hashes change. |
| 11:36 |
Dyrcona |
Another reason NOT to cherry-pick :) |
| 11:36 |
Bmagic |
oh well, the code is correct.. and we should expect the holds to default to the patron pickup location |
| 11:36 |
Dyrcona |
It makes figuring out which branches have which commits that much harder. |
| 11:37 |
Dyrcona |
Bmagic: I'd diff what's installed against the file changed in that commit. |
| 11:37 |
Dyrcona |
Just to make sure the correct one is installed. |
| 11:37 |
Dyrcona |
I'd also check that something later didn't mess with the file. |
| 11:37 |
Dyrcona |
You could have merged something that undid that commit. |
| 11:37 |
Bmagic |
hmmm |
| 11:39 |
Bmagic |
/openils/var/web/js/ui/default/opac/staff.js is right |
| 11:39 |
Dyrcona |
Well, there are 3 files affected. |
| 11:39 |
Bmagic |
yeah, still checking |
| 11:39 |
Dyrcona |
You're probably most concerned about the xul file. |
| 11:39 |
Bmagic |
Open-ILS/web/js/ui/default/staff/services/eframe.js is right |
| 11:40 |
Dyrcona |
Well, maybe not, but if it doesn't retrieve the user.home_ou the rest of the code may not work correctly. |
| 11:45 |
Dyrcona |
BTW, the hash I pasted is the commit from 2.12, and the one that Bmagic pasted is from master and rel_3_0. |
| 11:45 |
Dyrcona |
Just because it's not clear from what was said earlier. |
| 11:47 |
Bmagic |
oh weird, that file isn't installed in the production path at all |
| 11:48 |
Bmagic |
menu.js |
| 11:49 |
Dyrcona |
Bmagic: It goes in the client actually. |
| 11:49 |
Bmagic |
hmmm, so it wouldn't be in var/web/xul/server/...... |
| 11:50 |
Dyrcona |
Everything under staff_client/chrome goes in the staff client. |
| 11:50 |
Dyrcona |
No, it wouldn't be there, sorry. |
| 11:50 |
Bmagic |
alright that makes me feel a bit better |
| 11:50 |
Bmagic |
let me see if I can find it on an installation of the xul client somewhere |
| 11:51 |
* Dyrcona |
should have paid more attention. |
| 11:52 |
Bmagic |
that file exists in my example and the changed line is present |
| 11:52 |
Bmagic |
the staff must be doing something to counter that code somehow |
| 11:53 |
Bmagic |
Dyrcona++ |
| 11:53 |
Dyrcona |
Bmagic: You verified it on an example hold in the database? Staff could be confused. |
| 11:53 |
Dyrcona |
They also might have an older client. |
| 11:54 |
Dyrcona |
Do you delete the old directories under /openils/var/web/xul/ when you do upgrades? |
| 11:54 |
Bmagic |
yes |
| 11:54 |
Dyrcona |
OK. That's good. If they are still there, I think people can still connect with out of date clients. |
| 11:55 |
Bmagic |
All users are prompted for upgrades and the old clients will not work because the rel_XXXX directory doesn't exist on the server |
| 11:57 |
* Dyrcona |
decides it is close enough for lunch time. |
| 11:57 |
Bmagic |
good call |
| 12:14 |
|
mmorgan joined #evergreen |
| 12:24 |
|
khuckins joined #evergreen |
| 12:36 |
|
rlefaive joined #evergreen |
| 12:42 |
|
yboston joined #evergreen |
| 12:52 |
|
rlefaive joined #evergreen |
| 12:57 |
|
beanjammin joined #evergreen |
| 13:03 |
|
jihpringle joined #evergreen |
| 13:06 |
|
jwoodard joined #evergreen |
| 13:13 |
kmlussier |
berick: You're done working on bug 1729934, right? |
| 13:13 |
pinesol_green |
Launchpad bug 1729934 in Evergreen "Web Client: Patron Alerts not showing to staff from other libraries" [High,Confirmed] https://launchpad.net/bugs/1729934 - Assigned to Bill Erickson (berick) |
| 13:19 |
berick |
kmlussier: arg, yes, I'll remove me as assignee |
| 13:19 |
berick |
done |
| 13:25 |
csharp |
berick: btw, we applied your fixes to that to PINES production yesterday - so far so good |
| 13:25 |
csharp |
after another day or so we can comfortably sign off on it (may let terran do it) |
| 13:26 |
berick |
csharp++ |
| 13:29 |
pinesol_green |
[evergreen|Bill Erickson] LP#1729934 Webstaff penalty create org/depth repair - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=23be7df> |
| 13:29 |
pinesol_green |
[evergreen|Bill Erickson] LP#1729934 Webstaff display org-scoped penalties - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=67096ba> |
| 13:30 |
jeffdavis |
oh boy, more fun with non-schema-qualified db functions :( |
| 13:30 |
csharp |
oh - I see that kmlussier has already done it ;-) |
| 13:30 |
csharp |
jeffdavis: which one this time? |
| 13:30 |
kmlussier |
Oops, sorry csharp! I wasn't paying attention to IRC. |
| 13:30 |
csharp |
kmlussier: nah - no biggie |
| 13:31 |
jeffdavis |
3.1 upgrade script recreates the reporter.old_super_simple_record view with references to evergreen.oils_json_to_text, but we only have public.oils_json_to_text |
| 13:32 |
* csharp |
confirms the same on PINES |
| 13:32 |
jeffdavis |
a fresh install would have that function in the evergreen schema, only us dinosaurs would be affected |
| 13:35 |
csharp |
I had "greybeards" in my head (and a pain in my hip) |
| 13:35 |
jeffdavis |
:) |
| 13:35 |
csharp |
of course, my beard is going grey IRL |
| 13:44 |
jeffdavis |
At a glance we've got at least a dozen functions in public that should probably be in evergreen. But I don't see any duplicates so far, at least. |
| 14:06 |
|
jaswinder joined #evergreen |
| 14:32 |
|
yboston joined #evergreen |
| 14:44 |
kmlussier |
There must be a way to mark an address invalid that I'm not aware of. The Standing Penalty with id 29 is for an invalid address, but if I remove the valid checkmark for a patron's address, that standing penalty doesn't get applied. |
| 14:50 |
kmlussier |
Oh! There's a library setting for that! |
| 14:50 |
|
jaswinder joined #evergreen |
| 14:50 |
* mmorgan |
was thinking the same thing... |
| 14:51 |
* kmlussier |
was almost tempted to give negative karma to YAOUS. |
| 14:51 |
kmlussier |
But then I came to my senses. |
| 14:51 |
Dyrcona |
heh. |
| 14:52 |
kmlussier |
And voila! I see the penalty applied to the patron record. |
| 14:53 |
* Dyrcona |
is struggling against websocket/connection timeouts while trying to debug Item Status in the web staff client. |
| 14:55 |
berick |
Dyrcona: websockets should transparently reconnect after a timeout. |
| 14:55 |
Dyrcona |
Dunno. My debugging seemed to end with a connection timeout. |
| 14:55 |
berick |
yeah, they should regualrly recycle (and log when it happens) |
| 14:56 |
berick |
if idle long enough |
| 14:56 |
Dyrcona |
berick: What seems to be happening is only the last selected copy gets added for deletion, but I don't know why, yet. |
| 14:57 |
Dyrcona |
getSelectedItems and all of that returns the right thing. |
| 14:58 |
Dyrcona |
I'm gonna have to change where I set my breakpoint. |
| 15:03 |
|
rlefaive joined #evergreen |
| 15:07 |
Dyrcona |
So, berick, when the debugger halts on self.socket_send(msg) with an exception, how do I resend/restart things? |
| 15:09 |
Dyrcona |
I guess I just wait for it to die, and for Chromium to steal my focus away from whatever else I was doing. |
| 15:10 |
berick |
Dyrcona: that's JS? |
| 15:10 |
Dyrcona |
berkick: That is JS. |
| 15:10 |
berick |
the only thing called "socket_send" I can find in EG or OpenSRF is in the C code. |
| 15:11 |
berick |
what file? |
| 15:11 |
Dyrcona |
Line 74 of opensrf_ws.js |
| 15:11 |
berick |
ah, socket.send() |
| 15:11 |
berick |
ok |
| 15:11 |
Dyrcona |
After a few seconds, it started going again and now it's stuck. |
| 15:12 |
Dyrcona |
Yeah, guess I misquoted. |
| 15:12 |
berick |
no idea. i suspect the break points are not playing nicely |
| 15:13 |
Dyrcona |
Should I increase the timeouts to 10 minutes or something because this is painful? |
| 15:13 |
berick |
yeah, seems reasonable |
| 15:24 |
Dyrcona |
Actually, I don't see how to set a websocket timeout. |
| 15:25 |
Dyrcona |
There is a timeout setting but that seems to be for the initial conneciton. |
| 15:25 |
berick |
we have custom settings controlled via environment variables in /etc/apache2/envvars |
| 15:25 |
berick |
looking for docs.. |
| 15:27 |
berick |
Dyrcona: http://evergreen-ils.org/documentation/install/OpenSRF/README_3_0_0.html step 15.6 |
| 15:27 |
Dyrcona |
I just found them, thanks. :) |
| 15:28 |
berick |
cool |
| 15:30 |
Dyrcona |
When you mentioned, "docs" I remembered seeing them in the README. |
| 15:48 |
|
nfpl joined #evergreen |
| 15:51 |
Dyrcona |
Well, only 1 item ends up in copy_objects. |
| 15:55 |
Dyrcona |
And, why are we retrieving the copies from the database again before deleting them? Just to make sure that they were not deleted behind our back in the meantime? |
| 16:06 |
|
rlefaive joined #evergreen |
| 16:09 |
pinesol_green |
[evergreen|Morkor Quarshie] Docs: Minor updates in Ordering_materials.adoc - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d188baf> |
| 16:21 |
|
jeffdavis_ joined #evergreen |
| 16:21 |
|
pinesol_green` joined #evergreen |
| 16:24 |
|
berick_ joined #evergreen |
| 16:46 |
|
nfcb joined #evergreen |
| 17:07 |
|
mmorgan left #evergreen |
| 17:12 |
Bmagic |
Is it normal behavior for funds to go negative? The sum(amount) in acq.fund_debit is greater than acq.fund_allocation_total. Looking at each row in fund_debit, the last entry has encumbered ='t' if that matters? |
| 17:15 |
berick |
Bmagic: do the acq.fund rows have a balance_stop_percent value? |
| 17:19 |
csharp |
Bmagic: bug 1175400 ? |
| 17:19 |
pinesol_green` |
Launchpad bug 1175400 in Evergreen "ACQ: Possible to Over-allocate from a Funding Source" [High,Confirmed] https://launchpad.net/bugs/1175400 |
| 17:21 |
|
f_guel joined #evergreen |
| 17:21 |
kmlussier |
csharp: Since it's acq.fund_debit, it looks like the fund is over-allocating, not the funding source. |
| 17:22 |
kmlussier |
Bmagic: Yes, as berick noted, if there isn't a value in balance_stop_percent, there is nothing that will stop the user from over-allocating a fund. You can also enter a value that is greater than 100%, I think. |
| 17:22 |
f_guel |
Hi all, Good afternoon, Is there any kind of config in EG to could connect with Google services? I mean, Can I connect EG with Google for users accounts login? |
| 17:25 |
Bmagic |
berick: balance_stop_percent=100 |
| 17:28 |
Bmagic |
f_guel: not to my knowledge |
| 17:30 |
kmlussier |
Bmagic: Possibly a situation similar to the one found in bug 1347090? It doesn't check to see if a fund is active / inactive when activating an order at upload time. Maybe it doesn't check the balance_stop_percent either. |
| 17:30 |
pinesol_green` |
Launchpad bug 1347090 in Evergreen "Uploading and activating orders with an inactive fund should not be possible" [Medium,Confirmed] https://launchpad.net/bugs/1347090 |
| 17:31 |
Bmagic |
The fund is active |
| 17:31 |
jeff |
f_guel: What are you trying to do, and in what kind of environment? Public library? School? |
| 17:31 |
f_guel |
Bmagic: I was reading and by now the access could be just though LDAP right? |
| 17:31 |
f_guel |
jeff: I want to authenticate access in EG with Google user accounts |
| 17:32 |
jeff |
f_guel: staff, patrons, or both? |
| 17:32 |
f_guel |
both if possible |
| 17:32 |
Bmagic |
f_guel: perhaps someone else knows more about external authentication. I haven't set it up for Evergreen at all. |
| 17:32 |
berick |
Bmagic: it's possible some of the debits were created during invoicing only. the funds should display a warning in the fund selector of the exceed, but the invoice code does not prevent it from happening. |
| 17:32 |
kmlussier |
Bmagic: Yes, I'm not saying it is inactive. What I'm saying is that when an order is uploaded with the funds information in a tag, the system doesn't necessarily do all the checks that are done when applying a fund from the PO. |
| 17:33 |
berick |
s/of the/if they/ |
| 17:34 |
Bmagic |
alright, I think this is helping. It sounds like it's a bug no matter which way it was achieved. |
| 17:36 |
csharp |
kmlussier: ah - good point |
| 17:38 |
* csharp |
plans to ask his own questions about external auth (specifically openathens) when more people are around |
| 18:32 |
pinesol_green` |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:30 |
|
rlefaive joined #evergreen |
| 19:39 |
jaswinder |
Hey guys, can you anyone tell how I can query the db for a new table? |
| 20:32 |
jonadab |
jaswinder: You mean CREATE TABLE ? (Perhaps I am misunderstanding...) If so, https://www.postgresql.org/docs/10/static/sql-createtable.html |
| 20:33 |
jaswinder |
nope, how I can access data from db within EG. I have created a new schema and tables |
| 20:33 |
jonadab |
Ah. |
| 20:34 |
jonadab |
That makes somewhat more sense as a question here; unfortunately I don't know the answer, but perhaps someone else will. (Many folks are away this time of day, but if you stick around...) |
| 20:39 |
csharp |
jaswinder: you have to add the definition it to fm_IDL.xml (plenty of examples therein) |
| 20:40 |
csharp |
s/it// |
| 20:41 |
csharp |
jaswinder: depending on what you're doing, there may be other places it needs to be defined as well |
| 20:53 |
|
yboston joined #evergreen |
| 21:11 |
gsams |
I'd like to build a SQL query that outputs average lending time per item. I'd ideally like to factor renewals into the time if possible but I'm having a bit of trouble wrapping my brain around that. |
| 21:22 |
|
beanjammin joined #evergreen |
| 21:40 |
|
jaswinder joined #evergreen |
| 22:13 |
csharp |
gsams: you might look into the action.circ_chain() DB function to get a full chain of circulations from start to finish across possible renewals |
| 22:14 |
csharp |
you can do things like "select max(checkin_time) - min(xact_start) from action.circ_chain(166673995);" (where 166673995) is one of the circ IDs |
| 22:37 |
|
jaswinder joined #evergreen |
| 22:46 |
|
beanjammin joined #evergreen |
| 23:19 |
|
jaswinder joined #evergreen |
