| Time |
Nick |
Message |
| 05:37 |
|
jlundgren joined #evergreen |
| 06:02 |
|
remingtron_ joined #evergreen |
| 06:32 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:15 |
|
rjackson_isl joined #evergreen |
| 07:27 |
|
rjackson_isl_ joined #evergreen |
| 07:28 |
|
remingtron_ joined #evergreen |
| 07:32 |
|
agoben joined #evergreen |
| 07:42 |
|
rlefaive joined #evergreen |
| 07:53 |
|
rlefaive joined #evergreen |
| 08:30 |
|
ngf42 joined #evergreen |
| 08:33 |
csharp |
@who 's OU is a rank OU? |
| 08:33 |
pinesol_green |
ngf42 's OU is a rank OU. |
| 08:33 |
ngf42 |
O_o "rank" as in "smelly"? |
| 08:34 |
csharp |
I was punning off a question from kmlussier from yesterday about rank-ou |
| 08:34 |
ngf42 |
ah |
| 08:35 |
ngf42 |
well, unrelated, here's a cat: http://i.imgur.com/06QqNlj.gifv |
| 08:35 |
csharp |
ngf42++ |
| 08:44 |
|
Dyrcona joined #evergreen |
| 09:07 |
|
collum joined #evergreen |
| 09:12 |
|
yboston joined #evergreen |
| 09:13 |
|
jvwoolf joined #evergreen |
| 09:18 |
|
mmorgan joined #evergreen |
| 09:29 |
|
kmlussier joined #evergreen |
| 09:33 |
|
mmorgan joined #evergreen |
| 09:44 |
kmlussier |
@coffee [someone] |
| 09:44 |
* pinesol_green |
brews and pours a cup of Ethiopia Yirgacheffe, and sends it sliding down the bar to dbwells |
| 09:44 |
kmlussier |
@tea [someone] |
| 09:44 |
* pinesol_green |
brews and pours a pot of Wild Snow Sprout Tea, and sends it sliding down the bar to dkyle (http://ratetea.com/tea/wild-tea-qi/wild-snow-sprout-tea/6447/) |
| 09:45 |
kmlussier |
pinesol_green must know that dbwells has been working hard the last couple of weeks. |
| 09:45 |
pinesol_green |
kmlussier: I'm sorry, Dave. I'm afraid I can't do that. |
| 09:51 |
|
terran joined #evergreen |
| 09:53 |
Dyrcona |
The second most chilling line in cinema.... |
| 09:54 |
Dyrcona |
I think the most chilling line comes about 2 minutes later. |
| 09:54 |
Dyrcona |
"Dave, this conversation can server no purpose any more. Good bye." |
| 09:54 |
Dyrcona |
bah. s/server/serve/ |
| 09:58 |
|
rlefaive joined #evergreen |
| 10:22 |
|
kdt8 joined #evergreen |
| 10:46 |
|
beanjammin joined #evergreen |
| 10:51 |
|
mmorgan joined #evergreen |
| 10:57 |
|
dwgreen joined #evergreen |
| 11:15 |
|
blongwel joined #evergreen |
| 11:58 |
mmorgan |
I'm still trying to track down why attempts to delete some patrons time out in the client. Looking at the piece that deletes rows from money.billable_xact |
| 11:58 |
pastebot |
"mmorgan" at 64.57.241.14 pasted "EXPLAIN ANALYZE delete from money.billable_xact where usr = 1658222;" (24 lines) at http://paste.evergreen-ils.org/1190 |
| 11:59 |
|
jihpringle joined #evergreen |
| 11:59 |
mmorgan |
Does this imply that an index is needed on action.usr_circ_history.source_circ? |
| 12:03 |
|
rlefaive_ joined #evergreen |
| 12:08 |
dbwells |
mmorgan: It seems reasonable to try, and cannot really hurt. |
| 12:09 |
Dyrcona |
Bmagic encountered this recently. |
| 12:10 |
Bmagic |
mmorgan: yep |
| 12:10 |
Bmagic |
I just had this issue and came to the same conclusion |
| 12:10 |
Dyrcona |
mmorgan: Lp 1758160 |
| 12:10 |
pinesol_green |
Launchpad bug 1758160 in Evergreen "Deleting patrons can exceed staff client timeouts" [Undecided,New] https://launchpad.net/bugs/1758160 |
| 12:10 |
Bmagic |
haha, I was about to link that! |
| 12:11 |
Bmagic |
Dyrcona++ |
| 12:11 |
Dyrcona |
Bmagic++ |
| 12:11 |
Dyrcona |
I was thinking of testing your branch on that, but I've got enough on my plate for today. |
| 12:11 |
mmorgan |
Dyrcona++ |
| 12:11 |
mmorgan |
Bmagic++ |
| 12:12 |
|
khuckins joined #evergreen |
| 12:12 |
mmorgan |
Don't know how I missed that on Launchpad! |
| 12:12 |
jeff |
...said no-one ever. |
| 12:12 |
* jeff |
grins |
| 12:12 |
Dyrcona |
ha! |
| 12:13 |
mmorgan |
jeff++ |
| 12:13 |
Bmagic |
Ready Player One was awesome last night btw |
| 12:14 |
rhamby |
Bmagic: no spoilers, going to see it this weekend |
| 12:15 |
Bmagic |
no worries! |
| 12:17 |
Bmagic |
People in my office are tired of hearing me talk about it. I thought it was coming out in 2016, then I thought it was 2017 and now FINALLY |
| 12:17 |
* csharp |
needs to read the book |
| 12:17 |
csharp |
my son owns it - I just haven't gotten to it yet |
| 12:18 |
* Dyrcona |
turns up the volume of his music.... :) |
| 12:19 |
rhamby |
csharp: i think it’s worth reading but it’s also a love letter to my childhood so..... |
| 12:19 |
Dyrcona |
Yeah, I've been thinking about reading it, but I've got a ton of other books to read at the moment. |
| 12:20 |
rhamby |
Drycona: is a good problem to have (my to read list is always longer than my time to read) |
| 12:21 |
Bmagic |
Will Weaton does a good audio performance :) |
| 12:21 |
Bmagic |
Weaton/Wheaton |
| 12:22 |
Bmagic |
Will/Wil # LOL |
| 12:22 |
Dyrcona |
Shut up, Wesley. :P |
| 12:23 |
Dyrcona |
rhamby: Yes, same problem. |
| 12:24 |
mmorgan |
So I added the index on a test system and am not seeing an improvement in the EXPLAIN ANALYZE. Do I need to restart something? |
| 12:24 |
Bmagic |
mmorgan: no, it improved right away |
| 12:25 |
Bmagic |
the analyze that you need to be running is "delete from action.circulation where xxxx" |
| 12:26 |
Bmagic |
at least that is what I remember testing |
| 12:31 |
* dbs |
seconds wilw's audio performance on RP1 |
| 12:35 |
|
rlefaive joined #evergreen |
| 12:36 |
* rhamby |
agrees with dbs |
| 12:37 |
mmorgan |
Ok, tested the delete from action.circulation, still taking a long time |
| 12:37 |
pastebot |
"mmorgan" at 64.57.241.14 pasted "EXPLAIN ANALYZE delete from action.circulation where usr = 1658222;" (18 lines) at http://paste.evergreen-ils.org/1192 |
| 12:39 |
|
rlefaive joined #evergreen |
| 12:41 |
dbwells |
mmorgan: You created the index the same way Bmagic did on his bug? https://bugs.launchpad.net/evergreen/+bug/1758160 |
| 12:41 |
pinesol_green |
Launchpad bug 1758160 in Evergreen "Deleting patrons can exceed staff client timeouts" [Undecided,Confirmed] |
| 12:41 |
jeff |
mmorgan: can you share or reference the index that you added? |
| 12:41 |
kmlussier |
My son owns the book, but never showed an interest in reading it. Maybe I'll get the Wil Wheaton audio version for the long drives we'll be doing in a few weeks while touring colleges. |
| 12:42 |
mmorgan |
Yes, used Bmagic's create statement CREATE INDEX action_usr_circ_history_source_circ_idx ON usr_circ_history USING btree (source_circ); |
| 12:43 |
mmorgan |
This user has no rows in usr_circ_history. Could that be the problem? |
| 12:47 |
dbs |
kmlussier: a challenge with RP1 is that its POV an adolescent male obsessed with 80's-era geek cultural references, and the treatment of women almost matches that era (somewhat like "oh wow a girl can be a geek and hot?!? ZOMG") which is highly problematic |
| 12:48 |
dbs |
also it launches with references to drug use and prostitution so not particularly kid-friendly (had started it on our family vacation drive a few years back but quickly turned it off) |
| 12:48 |
kmlussier |
dbs: Yes, I forgot to mention that I've read it. My daughter has too. |
| 12:48 |
dbs |
ah okay |
| 12:49 |
rhamby |
My daughter read it and liked it as well. |
| 12:50 |
kmlussier |
I didn't remember the prostitution, but she actually mentioned it to me last night. |
| 12:50 |
kmlussier |
I guess I was too caught up in all those 80s references. |
| 12:52 |
jeffdavis |
mmorgan: not sure if this would make a difference, but do you have a lot of entries in action.usr_circ_history where source_circ is null? |
| 12:55 |
jeffdavis |
Also, does `ANALYZE action.usr_circ_history` improve performance? |
| 12:56 |
|
gsams joined #evergreen |
| 13:05 |
mmorgan |
jeffdavis: No rows with source_ circ NULL |
| 13:10 |
mmorgan |
ANALYZE action.usr_circ_history doesn't seem to make a difference in performance, for this usr anyway |
| 13:13 |
|
gsams joined #evergreen |
| 13:17 |
Bmagic |
Anyone remember any bug related to looking at item status for an item that has a deleted patron in it's history causing a js error "details.circ.max_fine_rule() is not a function" ? |
| 13:17 |
|
rlefaive joined #evergreen |
| 13:19 |
jeff |
Bmagic: xul or web? |
| 13:19 |
Bmagic |
xul |
| 13:20 |
jeff |
Bmagic: I've encountered similar when there is a rule (duration, max fine, etc) on a circ that does not exist by name in the config table for that rule, which in this case would be config.rule_max_fine |
| 13:21 |
jeff |
in my case it didn't have to do with a deleted patron, just a renamed or a "made up at migration time" (duration, max_fine, recurring_fine} rule. |
| 13:21 |
Bmagic |
the circ is no longer in action.circulation. It's in aged_circulation which tells me that the max_fine_fule is "default" |
| 13:22 |
Bmagic |
jeff++ |
| 13:22 |
Bmagic |
config.rule_max_fine does not contain "default" |
| 13:23 |
mmorgan |
My EXPLAIN ANALYZE is different for another user |
| 13:23 |
pastebot |
"mmorgan" at 64.57.241.14 pasted "EXPLAIN ANALYZE delete from action.circulation where usr = 2118473;" (11 lines) at http://paste.evergreen-ils.org/1195 |
| 13:32 |
jeff |
on that user, there appear to be no circulations at all, so there's no deleting being done, so there are no constraints needing to be checked. |
| 13:33 |
mmorgan |
Hmm. that usr in my test system has 2283 rows in action.circulation. |
| 13:34 |
|
rlefaive joined #evergreen |
| 13:35 |
jeff |
for usr 2118473, the explain analyze output includes (actual time=0.160..0.160 rows=0 loops=1) -- the actual rows being 0 there leads me to think that they have zero circulations in action.circulation. does a SELECT count(*) FROM action.circulation WHERE usr = 2118473; return something other than zero? |
| 13:35 |
jeff |
(I could be mis-reading the explain output) |
| 13:36 |
mmorgan |
jeff: SELECT count(*) FROM action.circulation WHERE usr = 2118473; returns 2283 |
| 13:38 |
mmorgan |
Interesting. Now getting a different EXPLAIN ANALYZE for that user |
| 13:39 |
pastebot |
"mmorgan" at 64.57.241.14 pasted "EXPLAIN ANALYZE delete from action.circulation where usr = 2118473; - take 2" (16 lines) at http://paste.evergreen-ils.org/1196 |
| 13:39 |
mmorgan |
oops. typos. |
| 13:40 |
mmorgan |
scratch that. |
| 13:41 |
mmorgan |
different user. That would have been too weird. |
| 13:41 |
|
khuckins_ joined #evergreen |
| 13:43 |
* mmorgan |
is going to have to step away and revisit with a fresh brain. |
| 13:56 |
|
khuckins__ joined #evergreen |
| 13:59 |
|
rlefaive joined #evergreen |
| 14:09 |
Bmagic |
This seems like an common issue - large hold shelves cause the xul staff client to error out because it takes too long for the server to give the list of over 250 holds. Throws a 501 network error. That is normal right? |
| 14:11 |
Dyrcona |
Bmagic: It can be. You also might need more cstores. We ran into an issue with our larger libraries at MVLC where looking at the hold shelf would eat up all the cstore processes. |
| 14:11 |
Dyrcona |
That was when we first came up on 2.4 or whatever, so it may have had some improvement since then. |
| 14:11 |
kmlussier |
bug 701208 |
| 14:11 |
pinesol_green |
Launchpad bug 701208 in Evergreen "Browse Hold Shelf crashes with "large" number of copies" [Undecided,Confirmed] https://launchpad.net/bugs/701208 |
| 14:13 |
* kmlussier |
gets nostalgic at the mention of 'trunk' |
| 14:15 |
Bmagic |
hmmm, let me check. There are 7 bricks each with 65 cstore max. osrf_control --diagnostic shows the largest at 19 drones |
| 14:17 |
Dyrcona |
Bmagic: You're probably all right, then. |
| 14:17 |
Bmagic |
grep "no child" /openils/var/log/osrfsys.log |grep cstore shows 0 results on all bricks |
| 14:18 |
Bmagic |
however, there are some hits on "no child" in the logs for supercat and open-ils.actor |
| 14:24 |
Bmagic |
What uses supercat? I've already raised the number of children and it's still hitting the limit. |
| 14:27 |
Dyrcona |
I think z39.50 hits supercat as do a number of feeds. |
| 14:27 |
Dyrcona |
Some other things might hit it, too. |
| 14:27 |
Dyrcona |
It's mostly for outside-facing stuff, IIRC. |
| 14:46 |
pinesol_green |
Showing latest 5 of 6 commits to Evergreen... |
| 14:46 |
pinesol_green |
[evergreen|Remington Steed] Docs: Update "Selection Lists" and "Invoices" for web client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=15aef52> |
| 14:46 |
pinesol_green |
[evergreen|Remington Steed] Docs: New screenshot for "MARC Import Remove Fields" - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=48a2cad> |
| 14:46 |
pinesol_green |
[evergreen|Kevin Tran] Docs: Update MARC_RAD_MVF_CRA.adoc for web client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d1e1b2d> |
| 14:46 |
pinesol_green |
[evergreen|Remington Steed] Docs: Update "User and Group Permissions" for web client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1692d3d> |
| 14:46 |
pinesol_green |
[evergreen|Remington Steed] Docs: Add screenshots to "Load MARC Order Records" - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=55b1aa7> |
| 14:49 |
kmlussier |
remingtron++ |
| 14:52 |
remingtron |
kmlussier: it's nice to have student workers doing the first draft of web client doc review |
| 14:53 |
remingtron |
student_workers++ |
| 14:53 |
Dyrcona |
remingtron: Any reason that the students don't sign off their own commits? |
| 14:53 |
kmlussier |
Indeed. But, even so, it takes time to work with the student workers. |
| 14:53 |
kmlussier |
student_workers++ |
| 14:54 |
dbwells |
Dyrcona: We're still learning the ropes of having them help out in this way. |
| 14:54 |
Dyrcona |
All right, just wondering. |
| 14:54 |
Dyrcona |
At least you name them in the commit messages. :) |
| 14:54 |
kmlussier |
A few of them have signed off, though, haven't they? |
| 14:54 |
remingtron |
Dyrcona: in some cases they have signed off, but in other cases they've just provided screenshots and haven't actually changed the asciidoc files |
| 14:54 |
Dyrcona |
yeah, maybe they did. |
| 14:56 |
dbwells |
Well, they have shown up as authors on some things, but I don't think we've asked them for proper sign-offs at this stage. |
| 14:57 |
dbwells |
They are also using GitHub at this point, and I don't know a thing yet about whether signoffs can be added automatically in the environment. Probably a way, though. |
| 15:00 |
Dyrcona |
dbwells: Signoff are the same in github as anywhere else. |
| 15:00 |
Dyrcona |
git commit -s |
| 15:00 |
dbwells |
Well, I mean they are using the web interface. |
| 15:00 |
dbwells |
Gotta start somewhere. |
| 15:00 |
dbs |
git does let you assign authorship to someone else at the command line too: "git committ --author=blah" |
| 15:01 |
dbs |
(could be used along with --reset-author, I think) |
| 15:02 |
Dyrcona |
yeahp. I've used that with patches from Lp. |
| 15:02 |
* Dyrcona |
has had to sign commits with a gpg key for monero, but not sure the commit went in. |
| 15:02 |
* Dyrcona |
signs his tags on github with his gpg key. |
| 15:03 |
Dyrcona |
gcharlt signs OpenSRF tags with his gpg key, last time I looked. :) |
| 15:03 |
Dyrcona |
gmcharlt.... |
| 15:03 |
Dyrcona |
My fingers don't want to work today. I'm making as many typos in my code, too. :( |
| 15:03 |
dbwells |
I don't know if the original question was meant to be about authorship or actual signoffs, but yes, the commits authored by the students have the correct authorship at this point. |
| 15:04 |
Dyrcona |
Well, that's cool. I was wondering about signoffs mostly. |
| 15:04 |
dbwells |
:) |
| 15:04 |
Dyrcona |
Authorship credit is important. |
| 15:05 |
Dyrcona |
One thing I haven't figured out how to change is the committer name. :) |
| 15:07 |
bshum |
Well isn't the signed-off-by line just text added to the commit message? If so, they could make it a saved template reply in github that ends with their signoff and then type in the rest of the commit message. |
| 15:38 |
cesardv |
Dyrcona: can't one just temporarily change the local repo's git config user info and do git commit --amend? |
| 15:39 |
Dyrcona |
cesardv: One can, but that's too much trouble. :) |
| 15:39 |
Dyrcona |
cesardv++ |
| 15:39 |
* Dyrcona |
is lazy. |
| 15:39 |
Dyrcona |
Plus, you probably don't want to change the committer, normally. |
| 15:40 |
Dyrcona |
I have a case where I work on CW MARS branches vs community branches, so I made a git command to commit the CW MARS branches with my CW MARS email address as the author. |
| 15:40 |
cesardv |
hmm doesn't the committer change like all the time? I think the author is important one, isnt? |
| 15:41 |
cesardv |
like the committer is just whomever rolled the commit no? |
| 15:41 |
Dyrcona |
The committer is whoever committed it to branch that is currently being pushed, yes. |
| 15:42 |
Dyrcona |
What I'm getting at is: 1) I've found no way to change it after fact, and 2) my CW MARS branches have the same name for committer and author, but different email addresses. |
| 15:42 |
Dyrcona |
Neither one is really important. |
| 15:43 |
cesardv |
I'd do something like git config user.name "new persona" && git config user.email "newperson email.com" then so if you do: git commit --amend --reset-author |
| 15:44 |
cesardv |
and then change back... but yeah prob something one would wanna make into a script |
| 16:08 |
Dyrcona |
cesardv: It's easier than that. |
| 16:08 |
Dyrcona |
GIT_COMMITTER_EMAIL="userdomain.tld" |
| 16:08 |
Dyrcona |
https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables |
| 16:11 |
cesardv |
Dyrcona: nice find |
| 16:11 |
Dyrcona |
Changing an environment variable, I don't mind doing in a script. |
| 16:16 |
jeff |
if you always use the same identity with the same repositories, you can just set the usual config vars for committer name/email in that repo. |
| 16:17 |
jeff |
the difference between --global and --local with "git config" |
| 16:18 |
Dyrcona |
jeff: I use different emails in the same repository. I don't want to make a separate local repository for CW MARS Evergreen. |
| 16:19 |
Dyrcona |
But, yeah, I do that for my CW MARS-only stuff like scripts, SQL, etc. |
| 16:19 |
jeff |
ah, different scenario, then. |
| 16:19 |
Dyrcona |
And, that's a good tip anyway. |
| 16:20 |
Dyrcona |
I kind of had this issue at MVLC, too. |
| 16:20 |
Dyrcona |
I decided that I'm only going to use my personal email address for stuff that I share with the community. |
| 16:20 |
Dyrcona |
Stuff that is CW MARS-only, I'll use the CW MARS email. |
| 16:21 |
|
yboston joined #evergreen |
| 16:27 |
|
jvwoolf left #evergreen |
| 16:38 |
|
mmorgan joined #evergreen |
| 16:38 |
abowling |
my first dive into postgres 9.6 in a production env. i note that the "archive" setting for "wal_level" is deprecated. just looking to someone to confirm that "replica" is the appropriate replacement. |
| 16:39 |
Dyrcona |
You could always ask in #postgres if no one answers here. |
| 16:41 |
abowling |
Dyrcona, i was already headed there too :) |
| 16:41 |
Dyrcona |
I'd have to look it up in the manual or ask there, myself. |
| 16:42 |
|
jvwoolf joined #evergreen |
| 16:42 |
abowling |
Dyrcona: confirmed. "replica" is the result of a 9.6 merge of "archive" and "hot_standby" |
| 16:43 |
Dyrcona |
Ah, good to know. I'll have to look that up since we use both settings on 9.5. |
| 16:44 |
abowling |
yeah. guessing 9.5 was the "here's the new, now be ready to get rid of the old next time" phase |
| 17:10 |
|
mmorgan1 joined #evergreen |
| 17:10 |
|
mmorgan1 left #evergreen |
| 17:20 |
pinesol_green |
[evergreen|Kevin Tran] Docs: Update circulation_limit_groups.adoc for web client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=15fc64d> |
| 17:20 |
pinesol_green |
[evergreen|Remington Steed] Docs: Update "Z39.50 Servers" for web client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2ff2723> |
| 17:20 |
pinesol_green |
[evergreen|Remington Steed] Docs: Update "User Activity Types" for web client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=eaec26b> |
| 17:38 |
|
abowling1 joined #evergreen |
| 17:43 |
|
rlefaive joined #evergreen |
| 18:23 |
|
rlefaive joined #evergreen |
| 18:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:24 |
|
abowling joined #evergreen |
| 20:07 |
|
genpaku_ joined #evergreen |
| 20:13 |
|
book` joined #evergreen |
| 20:13 |
|
mnsri joined #evergreen |
| 20:13 |
|
b_bonner joined #evergreen |
| 20:13 |
|
yar joined #evergreen |
| 20:13 |
|
Bmagic joined #evergreen |
| 20:14 |
|
bshum joined #evergreen |
