Time |
Nick |
Message |
00:33 |
|
book` joined #evergreen |
06:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:19 |
|
rjackson_isl joined #evergreen |
07:25 |
|
collum joined #evergreen |
07:46 |
|
rlefaive joined #evergreen |
08:34 |
|
Dyrcona joined #evergreen |
08:35 |
|
derekz joined #evergreen |
08:35 |
|
mmorgan joined #evergreen |
08:37 |
pinesol_green |
[evergreen|Jason Boyer] LP1737540: Add Patron Information to Receipts - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=870569b> |
08:38 |
|
kmlussier joined #evergreen |
08:39 |
|
ngf42 joined #evergreen |
08:59 |
mmorgan |
I'm remembering a bug where a volume hold gets cancelled when a call number is edited in the unified editor, but I can't find it in Launchpad. |
08:59 |
mmorgan |
Does it ring any bells with anyone? |
09:00 |
bshum |
mmorgan: That sounds familiarish |
09:01 |
bshum |
mmorgan: https://bugs.launchpad.net/evergreen/+bug/1040686 |
09:01 |
pinesol_green |
Launchpad bug 1040686 in Evergreen "Unified editor shouldn't always delete volumes" [Undecided,Won't fix] |
09:01 |
bshum |
kmlussier marked it won't fix, since it's apparently fixed in webby |
09:02 |
mmorgan |
bshum++ |
09:02 |
kmlussier |
And we were very happy when it was fixed in webby. :) |
09:02 |
mmorgan |
Thanks! I guess my search wasn't sufficiently caffeinated. |
09:03 |
mmorgan |
kmlussier: Yes, indeed.! |
09:03 |
bshum |
mmorgan: Well won't fix bugs wouldn't usually show up in searches. I cheated and went back to gmail searching of old LP notifications instead ;) |
09:04 |
Dyrcona |
You can search for bugs by status in advanced search. Not that helps much. |
09:05 |
mmorgan |
Ah, ok. I'm used to using advanced search to search for released bugs, but never thought of looking for "won't fix" |
09:07 |
Dyrcona |
I think the statuses that are not checked by default in advanced search are all hidden from default search. |
09:07 |
bshum |
Pretty much |
09:08 |
Dyrcona |
All too often the best way to find a bug is to report a new one. That search seems to be more thorough. |
09:08 |
Dyrcona |
I think the normal search only searches titles and maybe the description. |
09:08 |
|
rlefaive joined #evergreen |
09:08 |
Dyrcona |
Seems like filing a new bug does a better job. |
09:09 |
Dyrcona |
Suppose I could download the Launchpad source and see what it really does, but speculation is more fun. :) |
09:09 |
mmorgan |
Dyrcona: Good to know! |
09:34 |
|
agoben joined #evergreen |
09:36 |
bshum |
kmlussier++ # governance doc editing |
09:36 |
kmlussier |
bshum++ # posting governance doc changes to web site |
09:41 |
Bmagic |
@later tell hbrennan - Homer is getting a shout out at Code4Lib! |
09:41 |
pinesol_green |
Bmagic: The operation succeeded. |
09:41 |
Dyrcona |
D'oh! :) |
09:41 |
kmlussier |
heh |
09:59 |
csharp |
anyone else using the web client seeing duplicate payments? (like same second within 10ths of a second) |
09:59 |
csharp |
it's not happening everywhere all the time, but we have multiple libraries reporting that |
10:00 |
csharp |
Bmagic: https://frinkiac.com/img/S14E20/761761.jpg |
10:01 |
Bmagic |
csharp++ |
10:02 |
Bmagic |
csharp: I have not received any tickets for that issue but it could be happening without my knowledge |
10:02 |
csharp |
Bmagic: working on a query to find them |
10:02 |
Bmagic |
or gone un-noticed |
10:02 |
Bmagic |
ah, that was my next question |
10:06 |
JBoyer |
csharp, yes. Not cool. |
10:11 |
|
derekz left #evergreen |
10:13 |
JBoyer |
Yay video driver crashes. Yay windows. |
10:13 |
JBoyer |
Yay Friday. |
10:15 |
Dyrcona |
csharp: Double clicking? |
10:21 |
csharp |
Dyrcona: possible... we need more data |
10:21 |
csharp |
sounds like JBoyer is seeing the same thing |
10:22 |
csharp |
it seems like it has to be client-side - we had similar issues in the XUL client that were resolved c. 2010 |
10:22 |
csharp |
(so pre-launchpad, pre-git) |
10:23 |
JBoyer |
I believe in at least one of the examples we've seen the timestamps are so close that they both have the same last_xact_id and both still make it through. |
10:24 |
* mmorgan |
always wonders about double-clicks in a web environment causing problems |
10:25 |
csharp |
could be individual devices on individual workstations causing the trouble - seems like it has to be something non-human since the timestamps are that close |
10:27 |
Dyrcona |
Tenth of a second, you said? Sounds like a double click/double submit. |
10:34 |
csharp |
examples: https://pastebin.com/3VCAHkcb |
10:34 |
csharp |
Dyrcona: you may be right in this case |
10:34 |
csharp |
more than a tenth of a second - probably a double click |
10:36 |
Dyrcona |
I don't know what I'm looking at but those appear to be tripled. |
10:40 |
csharp |
confirmed - terran was able to reproduce the problem by double clicking on the button |
10:40 |
csharp |
and yeah, those were tripled |
10:41 |
Dyrcona |
Does it triple if you double-click? |
10:41 |
csharp |
in terran's case, no |
10:41 |
Dyrcona |
I suppose you can 3-click fast enough.... |
10:42 |
csharp |
... and terran verifies the triple-click/triple-payment |
10:42 |
csharp |
Dyrcona++ |
10:43 |
csharp |
so we probably need something to mitigate against that |
10:43 |
csharp |
(code, I mean) |
10:43 |
mmorgan |
So if I attempt to double-click the "Apply Payment" button, the client complains about INVALID_USER_XACT_ID |
10:43 |
Dyrcona |
Yeap. I agree with that 100%. |
10:43 |
mmorgan |
But the first payment does get applied. |
10:44 |
mmorgan |
Event: 1235:INVALID_USER_XACT_ID -> While you were trying to make payments, this account's transaction history changed. Please go back and try again. |
10:45 |
Dyrcona |
mmorgan: That's what should happen if a payment is doubled, but apparently not for csharp. |
10:45 |
Dyrcona |
Also, it would be better to prevent the multiple submit from happening in the first place. |
10:45 |
csharp |
mmorgan: interesting |
10:46 |
Dyrcona |
csharp: You could be missing some code. |
10:47 |
* mmorgan |
is banging on a 3.0.3 system |
10:47 |
|
terran joined #evergreen |
10:47 |
csharp |
this is 3.0.2-ish |
10:49 |
JBoyer |
Depending on transaction speed and double click time it may be possible to encounter a race condition where both payments pass the lxi check "simultaneously". |
10:50 |
Dyrcona |
JBoyer: I was thinking the same thing, but you articulated it much better than I would have. |
10:50 |
JBoyer |
In any event, beginning pretty much every click handler with this.disabled=true; (or it's equivalent) is probably a good idea. |
10:51 |
* mmorgan |
just produced a double payment on same system w/o getting the pop up alert :-( |
10:51 |
csharp |
mmorgan: good |
10:51 |
JBoyer |
Tada! |
10:52 |
* JBoyer |
should also look up that bug about modal dialogs and clicking outside the popup... |
10:52 |
csharp |
I was just digging through the code and there's nothing in the web client JS that would elicit INVALID_USER_XACT_ID (but it is in Money.pm) |
10:52 |
JBoyer |
Opinions! |
10:53 |
JBoyer |
csharp, it's changed by the backend after certain actions. the current value has to be sent with payments so it can be checked against the db for currency. (bah-dum, psh.) |
10:54 |
csharp |
JBoyer++ |
10:55 |
csharp |
@weather 30084 |
10:55 |
pinesol_green |
csharp: Tucker, GA :: Partly Cloudy :: 68F/20C | Friday: Partly cloudy skies this morning will give way to occasional showers during the afternoon. High 73F. Winds W at 10 to 20 mph. Chance of rain 40%. Friday Night: Cloudy. Slight chance of a rain shower. Low 51F. Winds NNW at 10 to 15 mph. |
10:55 |
* csharp |
has all the windows open |
10:55 |
csharp |
so at least there's that |
10:56 |
Dyrcona |
@weather |
10:56 |
pinesol_green |
Dyrcona: Methuen, MA :: Mostly Cloudy :: 51F/11C | Friday: Cloudy. High around 50F. Winds NW at 10 to 15 mph. Friday Night: A clear sky. Low 22F. Winds NW at 10 to 20 mph. |
10:58 |
Dyrcona |
Think I'll see if I can reproduce it. |
10:58 |
Dyrcona |
Just because. |
10:59 |
Dyrcona |
My vm seems a bit slow, so maybe it won't work for me. |
11:06 |
JBoyer |
If anything, a slow vm might help; what you really need to trigger it is a quicker clicker. |
11:07 |
Dyrcona |
Well, I found a concerto patron whoes $300.00, so we'll see what happens when I pay. |
11:08 |
|
Christineb joined #evergreen |
11:09 |
terran |
It does it with both full payments and partial payments. |
11:12 |
mmorgan |
I notice that the "Apply Payment" button is active even when there is nothing entered in the Payment Received box. Has that been problematic? |
11:15 |
Dyrcona |
Yeah. I got it to double. |
11:16 |
Dyrcona |
It looks inactive to me and I get a circle with a line through it for a cursor if I mouse over the Apply Payment button if Payment Received is empty. |
11:18 |
Dyrcona |
And, I'm getting nothing in transaction or payment history for this patron. |
11:18 |
Dyrcona |
Oh. Slow..... :) |
11:18 |
Dyrcona |
Doesn't help that the db server is loading a dump into another database. |
11:18 |
mmorgan |
I see the Apply Payment button active as long as there are bills selected, whether the payment received is filled in or not. |
11:19 |
mmorgan |
Both in Chrome and FF. Hmm. |
11:19 |
Dyrcona |
mmorgan: OK. I had no bills showing at all. |
11:19 |
Dyrcona |
It stayed inactive even after I put an amount in. |
11:20 |
Dyrcona |
However, when paying bills it was inactive until I put an amount in. I did not select any bills. |
11:20 |
Dyrcona |
But, yeah, I could make it double. Patron has 6 bills for $50. I paid $300. Twelve payments of $50.00 show up. |
11:21 |
terran |
I see it active if I have at least one bill selected, inactive if not. |
11:21 |
mmorgan |
terran: But nothing entered in "Payment Received"? |
11:22 |
terran |
mmorgan: correct |
11:22 |
mmorgan |
Dyrcona: That sounds normal. |
11:22 |
Dyrcona |
Sounds like there are two bugs here. |
11:23 |
terran |
I'm on 3.0.2 btw. |
11:23 |
csharp |
I don't think we've modded the bill payment screen at all |
11:24 |
Dyrcona |
And, my payment timestamps are almost exactly 1/10 of a second apart, .101 or so. |
11:24 |
mmorgan |
Yes, the state of the Apply Payment button is definitely a different issue, but I'm thinking it could lead to staff members thinking they have applied a payement when they haven't. Clicking the button, but neglecting to enter an amount. I'll open a bug on that. |
11:24 |
mmorgan |
Dyrcona: You made one payment of $300? |
11:24 |
|
derekz_ joined #evergreen |
11:24 |
Dyrcona |
mmorgan: Yes. |
11:25 |
mmorgan |
That's normal to be spread across the six distinct bills. |
11:25 |
Dyrcona |
And $600 was applied when I double clicked. |
11:25 |
mmorgan |
Oh. NM. ;-) |
11:25 |
Dyrcona |
Yeah, sure, 6 payments of $50... :) |
11:25 |
Dyrcona |
If someone opens a bug on the double payments, I'll happily confirm it. |
11:26 |
mmorgan |
Gotcha. Money is complicated. |
11:26 |
Dyrcona |
It shouldn't be, but it is.... Numbers with emotions attached. :) |
11:27 |
csharp |
ooh ooh - we should totally start adding emoticons to payments based on how the patron is acting |
11:29 |
Dyrcona |
BTW, berick, I'm doing some more testing of Lp 1739803. I like what I see so far. |
11:29 |
pinesol_green |
Launchpad bug 1739803 in Evergreen "Webstaff: Replace Grunt with Webpack + Angular 1.6" [Medium,New] https://launchpad.net/bugs/1739803 - Assigned to Jason Stephenson (jstephenson) |
11:29 |
csharp |
*standing with clipboard* "So Ms. Jones, how would you say you're *feeling* about paying this fine today?" |
11:29 |
Dyrcona |
heh. I used Gregory Jones to test. |
11:29 |
csharp |
:-) |
11:30 |
Dyrcona |
Only 3 patrons owe money in concerto. |
11:30 |
Dyrcona |
Out of the box, anyway. |
11:34 |
kmlussier |
I thought there were more. |
11:36 |
Dyrcona |
I only turned up 3 with a db query. |
11:36 |
kmlussier |
Donald Torres, Mae Scott. And I think there are two Gregory Jones who owe money. |
11:36 |
kmlussier |
I marked a bunch with an asterisk at https://wiki.evergreen-ils.org/doku.php?id=qa:concerto_logins, but those are patrons who have some kind of circ activity. They might not all owe money. |
11:37 |
Dyrcona |
Users 4, 5, & 6. I only used 4, Gregory Jones. |
11:38 |
terran |
I can create the bug ticket |
11:39 |
csharp |
terran++ |
11:41 |
terran |
csharp++ Dyrcona++ mmorgan++ |
11:45 |
terran |
https://bugs.launchpad.net/evergreen/+bug/1749992 |
11:45 |
pinesol_green |
Launchpad bug 1749992 in Evergreen "Web Staff Client: Duplicate bill payments with double-click" [Undecided,New] |
11:48 |
mmorgan |
terran++ |
11:49 |
mmorgan |
Also, lp 1749994 |
11:49 |
pinesol_green |
Launchpad bug 1749994 in Evergreen "Web Client: Apply Payment button on patron Bills screen should be inactive if Payment Received is blank" [High,New] https://launchpad.net/bugs/1749994 |
11:50 |
JBoyer |
terran++ |
11:56 |
|
beanjammin joined #evergreen |
12:00 |
Dyrcona |
terran++ |
12:07 |
dbs |
Do people find the Acq interfaces generally slow? 2.12 here and you can watch the first part of the info for a given PO load, then the next chunk a few seconds later, with interactivity frozen while it finishes loading |
12:17 |
kmlussier |
dbs: I can't say I've ever found the acq interfaces to be speedy, particularly when there are a lot of lineitems on the PO. |
12:17 |
kmlussier |
I haven't heard many complaints about it since the 2.6 days when bug 1254918 was added. |
12:17 |
pinesol_green |
Launchpad bug 1254918 in Evergreen 2.6 "rendering the fund drop-down in the line batch update controls can be slow" [Medium,Fix released] https://launchpad.net/bugs/1254918 |
12:18 |
* kmlussier |
is looking forward to angularacq |
12:20 |
dbs |
kmlussier: thanks |
12:21 |
dbs |
I'm always wondering if it's something we haven't configured properly, or if other sites just live with it :) |
12:21 |
kmlussier |
dbs: How many lineitems are on the PO? |
12:25 |
dbs |
I think we're generally one lineitem per PO |
12:27 |
kmlussier |
OK, then, that seems unusual to me. But I'm not as immersed in acq as I used to be. Christineb or jpringle may know better. |
12:28 |
Christineb |
I definitely find Acq to be the slowest module |
12:28 |
|
rlefaive joined #evergreen |
12:28 |
Christineb |
but usually we see the slowness with large orders |
12:28 |
Christineb |
one line item PO's are usually pretty quick to load / activate for us |
12:30 |
dbs |
I just timed loading one 1-line item PO; initial display took about 3 seconds, but filling in fields like "Prepayment required?" and "Activatable" and getting the cursor back to an active state took 35 seconds |
12:30 |
* Christineb |
is also looking forward to angularacq |
12:31 |
kmlussier |
angularacq++ |
12:34 |
Christineb |
dbs - I just timed loading a PO with 25 line items - initial display was very fast about 3 seconds the line items loaded and the cursor was back to active within 12 seconds |
12:35 |
Christineb |
I do see the initial load the PO looks blank, then the lines items generate in chunks and then the fields at the top populate |
12:38 |
|
jihpringle joined #evergreen |
12:39 |
dbs |
Yeah, so there's definitely something going on with our config. There's *always* something going on with our config :) |
12:39 |
* Dyrcona |
commiserates with dbs..... |
12:50 |
dbs |
Hmm, only difference between our open-ils.acq config and stock is that we have min_children 5 (instead of 1), and min_spare_children 2 (instead of 1) |
12:50 |
dbs |
We only have a maximum of three people using acq at a time |
12:50 |
* dbs |
= dunno |
12:54 |
Dyrcona |
@dunno |
12:54 |
pinesol_green |
Dyrcona: PHRASING!!! |
12:57 |
csharp |
in our case, the load time is slowed to ~16s/record because our match set creates terrible queries |
12:57 |
csharp |
acq loads^^ |
12:57 |
csharp |
but everything about acq is slow - old dojo is the main culprit |
12:58 |
csharp |
@band add Old Dojo |
12:58 |
pinesol_green |
csharp: Band 'Old Dojo' added to list |
12:59 |
|
hbrennan joined #evergreen |
12:59 |
hbrennan |
Bmagic: Cool! You see my M2M logo? :) |
13:03 |
Dyrcona |
OK. So never install updates and never reboot a working server.....'specially not when you won't have physical access to the box until next Wednesday..... |
13:04 |
hbrennan |
Dyrcona: Never installing updates would make my job much easier! (for a little while....) :) |
13:04 |
Dyrcona |
And, virtual machines make it worse, 'cause it's # virtual machines +1 that are actually down. |
13:04 |
Dyrcona |
hbrennan: Yeah. We don't update much in production. |
13:05 |
Dyrcona |
Members don't like the down time...any down time (scheduled or not) is too much. |
13:05 |
dbs |
Dyrcona: hey guess what I did this morning when open-ils.storage lost its drones and everything came crashing down? |
13:05 |
hbrennan |
Dyrcona: Happy Friday. Just remember, you could be in Alaska and juuuust starting your day. :) |
13:05 |
Dyrcona |
heh. |
13:05 |
Dyrcona |
dbs: I don't like guessing. |
13:06 |
Dyrcona |
hbrennan++ # Just 'cause. |
13:06 |
dbs |
answer: installed OS updates and rebooted because hey, might as well get security updates. only to run into a network issue preventing the box from connecting to the rest of the world (and me to it) |
13:06 |
dbs |
thankfully, BC Libraries Coop was on it :) |
13:06 |
dbs |
(7:30 am their time, good people) |
13:07 |
Dyrcona |
Yeah... good people indeed. |
13:07 |
Dyrcona |
Always fun the network drops out in the middle of something important. |
13:07 |
Dyrcona |
Had that happen during an upgrade. Loose cables in the machines fell out. |
13:08 |
Dyrcona |
Happened to the one I was using for the ssh tunnel and one other machine. |
13:08 |
dbs |
ugh |
13:09 |
Dyrcona |
Well, this puts a damper on my afternoon plans. I was going to see if I can reproduce Lp 1749992 on a vm running 2.12 on that machine. |
13:09 |
pinesol_green |
Launchpad bug 1749992 in Evergreen 3.0 "Web Staff Client: Duplicate bill payments with double-click" [Medium,Confirmed] https://launchpad.net/bugs/1749992 |
13:10 |
Dyrcona |
I hope it isn't a dead boot drive. You'd be surprised how long a system will stay up with a dead drive. |
13:11 |
* miker |
suggests we put a doubleclick handler on every button and link that pops up a native alert dialog with the message "this is a web page, don't doubleclick anything, ever" |
13:13 |
kmlussier |
Ummm...I think we have double-click support for some grid rows. |
13:13 |
* dbs |
was thinking the same as kmlussier |
13:15 |
kmlussier |
dbs: Great minds think alike, right? |
13:18 |
Dyrcona |
yeah, double clicking in a patron search results grid opens that patron. |
13:18 |
* Dyrcona |
noticed that just a bit ago. |
13:19 |
Dyrcona |
Anyway, I added my sign off to Lp 1739803. I think another pair of eyes are warranted. |
13:19 |
pinesol_green |
Launchpad bug 1739803 in Evergreen "Webstaff: Replace Grunt with Webpack + Angular 1.6" [Medium,New] https://launchpad.net/bugs/1739803 |
13:21 |
Dyrcona |
Heh. I missed the band that csharp added earlier, but when I looked up my brain turned it into something else. |
13:22 |
Dyrcona |
@band add Dang Old Banjo |
13:22 |
pinesol_green |
Dyrcona: Band 'Dang Old Banjo' added to list |
13:23 |
kmlussier |
I have a question about bug 1694058. I signed off on it back in November, but left it available for somebody else to test since Dyrcona did his work based on our requirements. I usually like to give somebody uninvolved in the project a chance to test it. |
13:23 |
pinesol_green |
Launchpad bug 1694058 in Evergreen "Ability to Place Multiple Title/Metarecord Holds at Once" [Wishlist,New] https://launchpad.net/bugs/1694058 |
13:23 |
kmlussier |
At this point, would anyone object if I merged it? |
13:24 |
Dyrcona |
I certainly don't object, and two months is plenty of time. :) |
13:27 |
Dyrcona |
Be nice if someone could have a look at Lp 1661688, too. |
13:27 |
pinesol_green |
Launchpad bug 1661688 in Evergreen "Want easy way to clear a hold when picked up by other patron" [Wishlist,Confirmed] https://launchpad.net/bugs/1661688 |
13:29 |
Dyrcona |
And, speaking of bugs and clicking on grids: Lp 1749593 might be good to have in before the releases next week. |
13:29 |
pinesol_green |
Launchpad bug 1749593 in Evergreen 3.0 "Webstaff: Grids on Bills and Patron Messages Screens do not show properly" [Undecided,New] https://launchpad.net/bugs/1749593 |
13:31 |
Dyrcona |
It only shows up in master, and likely rel_3_0, but not in 3.0.3, since the patch that causes it was added after the 3.0.3 release. |
13:42 |
Dyrcona |
Well, someone emailed me a photo of the console on the downed server....Looks like a HD error, probably dead. |
13:45 |
kmlussier |
Dyrcona: I plan to test that one (holds picku) if nobody else looks at it. I've just had to prioritize testing of bug 1744385 ahead of everything else this week. |
13:45 |
pinesol_green |
Launchpad bug 1744385 in Evergreen "Wishlist: Search & display infrastructure improvements" [Wishlist,New] https://launchpad.net/bugs/1744385 |
13:45 |
Dyrcona |
kmlussier: Thanks. Good to know. I understand your priorities. |
13:47 |
|
rlefaive joined #evergreen |
13:55 |
Dyrcona |
Wow. It just keeps getting more and complicated...my week in tech. |
13:58 |
|
krvmga_ joined #evergreen |
13:59 |
Dyrcona |
The photo was from a different machine.... |
14:00 |
|
mmorgan1 joined #evergreen |
14:01 |
Dyrcona |
The actual machine had an uncorrectable ECC error, and came up after hitting F1.... Still not good, but it's old and if it blows up, oh well. |
14:10 |
Dyrcona |
Oops. Meant to add something in the conversation with krvmga_ |
14:45 |
csharp |
Dyrcona: totally worth setting up out-of-band managment if it's available on the server |
14:46 |
csharp |
that's saved us so many times from late-night colo visits |
14:46 |
Dyrcona |
csharp: Yes. I'll have to look into it. |
14:48 |
Dyrcona |
Oh, yeah... payment history query times out.... :( |
14:48 |
csharp |
Dyrcona: also worth spending the money on a license for the web-based UIs/remote conoles when purchasing new equipment |
14:48 |
csharp |
iLO/idrac |
14:48 |
Dyrcona |
yeah, well, next time. |
14:49 |
csharp |
;-) |
14:54 |
Dyrcona |
terran | mmorgan | csharp: I can reproduce Lp 1749992 on 2.12. Guess it merits fixing there, too. Or, is 2.12 closed? |
14:54 |
pinesol_green |
Launchpad bug 1749992 in Evergreen 3.0 "Web Staff Client: Duplicate bill payments with double-click" [Medium,Confirmed] https://launchpad.net/bugs/1749992 |
14:55 |
kmlussier |
Dyrcona: 2.12 is still alive |
14:56 |
kmlussier |
Until March 22. |
14:59 |
* mmorgan1 |
found the bug much easier to reproduce after moving from a wired to wireless network connection. i.e. slower connection. |
14:59 |
Dyrcona |
"It's aliiive!" |
15:03 |
Dyrcona |
I'll take a stab at fixing it. |
15:03 |
Dyrcona |
How hard can it be? :) |
15:16 |
terran |
Dyrcona++ |
15:27 |
|
mmorgan joined #evergreen |
15:54 |
Dyrcona |
Pro tip: Be very careful when mixing branches and then doing a git reset --hard commithash... You may not end up with the results that you expected. |
16:03 |
Dyrcona |
That smiley was because it is harder than you would think it should be. |
16:05 |
kmlussier |
Dyrcona: It always is. |
16:05 |
mmorgan |
Many things are often harder than one thinks they should be ;-) |
16:06 |
Dyrcona |
Well, I expected it to be harder than it should be. |
16:10 |
Dyrcona |
And, maybe it's easier than I thought! |
16:16 |
Bmagic |
hbrennan: yep! |
16:16 |
Bmagic |
I am no longer at the conference, I am traveling at the moment |
16:20 |
hbrennan |
Bmagic: Very cool. Thanks for sharing :) |
16:20 |
Bmagic |
Cool indeed |
16:23 |
Dyrcona |
!?chown # my new best friend |
16:28 |
Dyrcona |
Oh, nice. Lp 1749593 is messing with my testing. |
16:28 |
pinesol_green |
Launchpad bug 1749593 in Evergreen 3.0 "Webstaff: Grids on Bills and Patron Messages Screens do not show properly" [Undecided,New] https://launchpad.net/bugs/1749593 |
16:29 |
|
derekz_ left #evergreen |
16:30 |
Dyrcona |
First time I've seen it happen on a patron with bills. |
16:31 |
* Dyrcona |
applies the patch and hopes. |
16:34 |
Dyrcona |
Nope. My first try didn't work. Neither did ng-dblclick="return false;" |
16:52 |
|
Dyrcona joined #evergreen |
16:58 |
|
mmorgan left #evergreen |
17:17 |
miker |
Dyrcona: https://stackoverflow.com/questions/20444409/handling-ng-click-and-ng-dblclick-on-the-same-element-with-angularjs may be relevant to your interests |
17:24 |
Dyrcona |
miker: Maybe. I tried using ng-dblclick without adding the controller (or whatever the proper name is) to the module list. |
17:24 |
Dyrcona |
The family wants to run out and get some take out, so maybe I'll have another look after dinner. I think I can get it to work. |
17:26 |
* kmlussier |
would like some of Dyrcona's take out. |
17:29 |
Dyrcona |
Trouble is, I was looking into it as the day was ending and the family arriving home, and git giving me trouble with loose objects.... |
17:31 |
Dyrcona |
Apparently, there is no module to add for ng-dblclick. It should just be there. |
17:32 |
|
kmlussier joined #evergreen |
17:35 |
Dyrcona |
Maybe I'll be back later. Mabye I won't. |
17:43 |
miker |
@later tell Dyrcona ng-{blah} versions of most html5 attributes are magical in angular, AFAIU. they "just work" ... or don't, I guess, in some cases |
17:43 |
pinesol_green |
miker: The operation succeeded. |
18:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
18:56 |
|
Dyrcona joined #evergreen |
18:57 |
Dyrcona |
Well, I'm giving it another shot. I think I needed to add a method to the service for the handler to call. It looks like raw JS doesn't work. |
19:01 |
Dyrcona |
What I said at 4:28:28 PM.... |
19:04 |
|
beanjammin joined #evergreen |
19:06 |
Dyrcona |
Nope. That doesn't work.... |
19:06 |
Dyrcona |
Same result as before. |
19:08 |
|
kmlussier joined #evergreen |
19:09 |
Dyrcona |
Weird how the double payment for the lost item doesn't show up in Refunds Available but the $1.40 overpaid in overdue fines does. Must be a setting? |
19:11 |
Dyrcona |
Nothing in the cosnsole log but the 2 payments being made. |
19:12 |
Dyrcona |
Obviously ng-dblclick is not the way to go. |
19:17 |
Dyrcona |
I'm giving up for now. I think we're going to have to add a scope variable to control when the button should be disabled and that might help with Lp1749994. |
19:17 |
Dyrcona |
pinesol_green, you there? |
19:17 |
pinesol_green |
Dyrcona: Down time is a fact of business when you're a poor 501c3 corporation. |
19:18 |
Dyrcona |
I'm out. |
22:51 |
|
beanjammin joined #evergreen |