Evergreen ILS Website

IRC log for #evergreen, 2017-12-18

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
00:19 pinesol_green [evergreen|Bill Erickson] LP#1735807 Webstaff holdings owning lib shortname - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fe30a5e>
06:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:15 rjackson_isl joined #evergreen
07:28 JBoyer joined #evergreen
08:48 Dyrcona joined #evergreen
08:58 bos20k joined #evergreen
09:36 yboston joined #evergreen
09:48 jvwoolf joined #evergreen
11:06 jvwoolf joined #evergreen
11:12 khuckins joined #evergreen
11:18 csharp ugh
11:18 csharp egweb: Context Loader error: Can't locate object method "new" via package "OpenILS::WWW::EGCatLoader" at /usr/local/share/perl/5.22.1/OpenILS/WWW/EGWeb.pm line 168.\n
11:18 csharp I've seen it before, but for the life of me I can't fix it :-/
11:18 csharp opensrf is running, apache is restarted afterwards
11:19 Christineb joined #evergreen
11:19 csharp there is indeed a new() method within EGCatLoader
11:21 csharp I've run autogen.sh too
11:21 berick csharp: at a /eg/opac/* url?
11:23 berick either apache can't find OpenILS::WWW::EGCatLoader or it's not compiling.  try: perl -MOpenILS::WWW::EGCatLoader
11:25 Dyrcona csharp also perl -c /path/to/perl/OpenILS/WWW/EGCatLoader.pm
11:25 csharp https://pastebin.com/HeEjqH4w
11:26 csharp wow - that's really busted
11:26 Dyrcona syntax error at /usr/local/share/perl/5.22.1/Op​enILS/WWW/EGCatLoader/Record.pm line 317, near "else"
11:27 Dyrcona Record.pm looks like your culprit.
11:27 * Dyrcona ran into something similar last week.
11:27 Dyrcona I busted something in circulation on a test server.
11:28 JBoyer EGCatLoader is almost never the problem when EGCatLoader is where the error is logged.
11:28 csharp I have no memory of customizing that file
11:28 Dyrcona Right. It's usually one of the modules used by EGCatLoader.
11:29 * csharp cranks up git blame
11:29 Dyrcona perl -c /usr/local/share/perl/5.22.1/Op​enILS/WWW/EGCatLoader/Record.pm
11:30 Dyrcona Dunno if that will add anything but repetitive noise.
11:30 csharp https://pastebin.com/x5uJmmAY - pretty much the same thing
11:30 Dyrcona Thought so.
11:31 csharp ok - that is a customization
11:32 Dyrcona OK. I was gonna suggest git log -p -- Open-ILS/src/perlmods/lib/Open​ILS/WWW/EGCatloader/Record.pm
11:32 Dyrcona The -p shows the "patches," so you can see what changed and when.
11:33 csharp Dyrcona: nice! I didn't know about that
11:33 csharp berick++ Dyrcona++ # helpin'
11:49 _adb joined #evergreen
12:08 jihpringle joined #evergreen
12:57 khuckins_ joined #evergreen
13:03 csharp argh - finally tracked down the issue - it's a closing brace somewhere along the way - nearly impossible to see where it's missing though :-/
13:05 Dyrcona csharp: Might be an extra open brace somewhere. My problem last week turned out to be an extra closing brace.
13:06 Dyrcona cperl-mode and perl-mode in Emacs can help with things like this. You can ask it to auto-indent the file and where it starts to go wrong is where you should start to look.
13:06 berick csharp: you're familiar with '%'  (AKA shift-5) in vim to find matching braces?
13:06 berick heh
13:06 Dyrcona Emacs can do that, too. :)
13:07 csharp berick: Dyrcona: thanks - very helpful
13:07 csharp better than chasing down a vim plugin that may or may not work (or switching editors just for this)
13:09 Dyrcona True. If you're used to vim...go for it.
13:09 _adb csharp: i've had reasonably good results using https://github.com/kien/rainbow_parentheses.vim
13:10 csharp _adb: awesome - I had just stumbled upon something similar (rainbow.vim - possibly one's a fork of the other)
13:13 Dyrcona rainbow claims to be an improvement on rainbow parentheses.
13:14 Dyrcona Looks like Nyan Cat puked on your screen. :P
13:15 _adb you may be amused by lolcat (it's in ubuntu repos.) it's a replacement for the 'cat' command.
13:23 csharp _adb++ # lolcat
13:34 khuckins__ joined #evergreen
13:50 dbs Dyrcona: ran your marc_export --uris today, seemed to do the job nicely! Considering signing it off but also considering how to write an automated test for it...
13:50 Dyrcona dbs: Yeah, tests are missing for most of the support scripts.
13:52 csharp maybe we need to have virtual hacking days for stuff like test writing
13:52 csharp ala DIG hackfests
13:58 Dyrcona Not a bad idea, though I'm not sure how you'd test some of the scripts.
15:04 jvwoolf joined #evergreen
15:10 Dyrcona FYI for anyone who cares, I just merged the evergreen-3.0-compatibility branch into evergreen_utilities master.
15:10 jeff ah.
15:10 jeff good to know!
15:10 Dyrcona If you're still on Evergreen 2.12, you'll not want to pull for a while.
15:12 Dyrcona Maybe I should have tagged commit d2bed80a166be9c03c0bcb80986304798955e334?
15:13 Dyrcona Guess I still can. Should I sign it with my GPG key that expires in 2 days? :)
15:16 Dyrcona There we go. I pushed a tag: eg-2.12-compat
16:17 Christineb joined #evergreen
16:19 Bmagic I'm getting an error when importing a test authority record. Complaining about a column that doesn't exist.
16:20 Bmagic Error retrieving vandelay::authority_match with query [SELECT  "vam".id, "vam".queued_record, "vam".eg_record, "vam".quality,...............  ERROR:  column vam.quality does not exist
16:20 Bmagic should vam have a quality column?
16:21 Bmagic the code tells me yes
16:21 khuckins joined #evergreen
16:21 Bmagic 012.schema.vandelay.sql
16:21 Dyrcona My 3.0.2 test database tells me yes.
16:21 Dyrcona quality       | integer | not null default 0
16:23 Bmagic weird. I wonder why we dont have that column
16:23 Dyrcona Failed db upgrade?
16:24 Dyrcona This 3.0.2 db was upgraded from a copy of production on 2.12.6.
16:24 * Dyrcona isn't sure when vandelay.authority_match was introduced.
16:25 Bmagic I don't see references to it in any of the upgrade scripts.... wait I found a release note about it
16:25 Bmagic 2.2 upgrade missing vandelay.authority_match.quality column
16:26 Bmagic haha
16:26 Dyrcona My 2.12.8 db has the column.
16:26 Dyrcona 2.2....
16:26 Dyrcona Didn't you guys come to Evergreen after that release?
16:27 Bmagic I believe the consortium was formed on 1.8
16:27 Bmagic I blame Justin!
16:27 Bmagic I wasn't here in those days
16:27 Dyrcona There was no 1.8. It went from 1.6 to 2.0.
16:27 Bmagic 1.6 then
16:27 Bmagic it was pre-2.0
16:27 Dyrcona All right then.
16:28 Dyrcona I figured you were contemporaneous with MVLC that came up on 2.0/2.1 or thereabouts.
16:28 Bmagic hopkinsju++ #failing to add the quality column
16:28 Dyrcona hah
16:30 Dyrcona Looks like you might have missed 0572.
16:30 Dyrcona Just from a quick grep.
16:33 Dyrcona No, that isn't the one.
16:35 Dyrcona Hm... Doesn't look like there is upgrade script for that column.
16:41 Dyrcona Ah ha!
16:42 Dyrcona This is a case of something being changed in the version upgrade script not making it to the numbered upgrade script.
16:42 Dyrcona hopkingsju must have run 0572 and not 2.1-2.2 upgrade-db.
16:44 Dyrcona Time for me to go, however.
16:44 abowling joined #evergreen
16:56 Bmagic gmcharlt: RE code changes to book carousel - I am troubleshooting the code in production now with javascript errors about OpenSRF is not defined
16:57 gmcharlt Bmagic: send me an email
16:57 Bmagic will do
17:30 jvwoolf left #evergreen
18:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat