| Time |
Nick |
Message |
| 06:03 |
|
eeevil joined #evergreen |
| 06:30 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 06:55 |
|
JBoyer joined #evergreen |
| 07:06 |
|
agoben joined #evergreen |
| 07:16 |
|
rjackson_isl joined #evergreen |
| 07:27 |
|
rlefaive joined #evergreen |
| 07:48 |
|
JBoyer joined #evergreen |
| 08:00 |
|
ericar joined #evergreen |
| 08:24 |
|
Jillianne joined #evergreen |
| 08:33 |
|
tlittle joined #evergreen |
| 08:38 |
|
plux joined #evergreen |
| 08:46 |
|
mmorgan joined #evergreen |
| 08:52 |
csharp |
so entering a price in a copy template is not simple :-/ |
| 08:53 |
csharp |
expectation: type "12.95" and move on - the "convenience" feature of adding the .00 to anything I type is getting in the way |
| 08:56 |
|
collum joined #evergreen |
| 08:57 |
mmorgan |
csharp: Indeed, that is problematic. |
| 08:57 |
csharp |
several catalogers here are calling it a showstopper (I disagree, but I don't have to enter item prices all day ;-) ) |
| 08:59 |
|
Dyrcona joined #evergreen |
| 08:59 |
* mmorgan |
is leaning toward agreeing with those catalogers. |
| 09:00 |
|
bos20k joined #evergreen |
| 09:06 |
* mmorgan |
checked a few other places where money is entered and they don't try and helpfully add .00 to everything. |
| 09:09 |
|
kmlussier joined #evergreen |
| 09:15 |
csharp |
mmorgan: oh really? where? |
| 09:15 |
kmlussier |
csharp: I noticed the price issue shortly before leaving for the holiday. I didn't realize it was a feature. |
| 09:16 |
csharp |
I assumed it was just a built-in angular thing that autopopulates |
| 09:16 |
mmorgan |
Billing a patron in circ and creating a fund allocation. Those were the only two placed I tried. |
| 09:17 |
csharp |
the downside of troubleshooting JS/Angular is that I have a really hard time finding the blocks of code that handle the business logic |
| 09:17 |
csharp |
I think fund allocations are still dojo |
| 09:17 |
csharp |
I'll check on the circ billing thing |
| 09:18 |
abneiman |
mmorgan / csharp -- I think this may be related: https://bugs.launchpad.net/evergreen/+bug/1714390 |
| 09:18 |
pinesol_green |
Launchpad bug 1714390 in Evergreen "Fix for Web Client Copy Editor Fix" [Undecided,New] |
| 09:18 |
mmorgan |
Oh yeah! you're right about the fund allocation - still dojo |
| 09:19 |
csharp |
abneiman: definitely in the same ballpark if not exactly the same thing - thanks! |
| 09:20 |
mmorgan |
csharp: Also entering a payment amount on the patron Bills screen works smoothly. |
| 09:21 |
kmlussier |
I should take another look at that one. I think it was interacting badly with other code loaded on my VM at the time. |
| 09:21 |
kmlussier |
abneiman++ |
| 09:21 |
mmorgan |
Well, unless you try to use the arrows to change the amount, then it jumps by whole dollars :-( |
| 09:22 |
JBoyer |
The up and down arrows are an artifact of the type of html input control, they aren't really intended to be used for anything. |
| 09:23 |
JBoyer |
Also, I have a fix for the price thing (i.e. forget about the formatting altogether) but it conflicts with another patch that addressed numeric values elsewhere. |
| 09:24 |
JBoyer |
The correct thing is to change one or the other patch to address both, but time. :( |
| 09:24 |
kmlussier |
JBoyer: I think we agreed at the time that the other patch is the one that should be cleared up. I'm going to load your again and, if it works, I'll merge it. |
| 09:24 |
JBoyer |
It works on its own, yes. |
| 09:24 |
* kmlussier |
should finish reading her e-mail from last week first. : / |
| 09:24 |
|
yboston joined #evergreen |
| 09:24 |
JBoyer |
ALSO, I've been meaning to ask you, kmlussier, how to get call number stuff into copy templates, I'm trying to work on the XUL clients template bug but can't figure out how to do that. |
| 09:25 |
kmlussier |
JBoyer: You have to use the unified copy editor. Also, you need to set the prefix/suffix/class scheme from the batch updater, which isn't exactly intuitive. |
| 09:26 |
JBoyer |
Seems almost accidental that it works then, honestly. (kind of like the call number owning_ou which you can also set in the template editor, for some reason.) |
| 09:29 |
kmlussier |
JBoyer: No, it's not accidental. It was part of the original tech requirements when affixes were added. |
| 09:30 |
JBoyer |
Oof. Ok, I'll continue to poke at it. |
| 09:30 |
JBoyer |
also, if you'd like to just export a smallish set and point me at them that will also work. :) |
| 09:30 |
JBoyer |
(When you have more time) |
| 09:34 |
|
bos20k joined #evergreen |
| 09:37 |
kmlussier |
JBoyer: Here's an export with one template that includes all three fields. https://drive.google.com/file/d/1jehp2-tbgtMzN8EwJ7CCpBGchfeduGOv/view?usp=sharing |
| 09:40 |
JBoyer |
kmlussier++ |
| 09:44 |
|
mmorgan1 joined #evergreen |
| 09:55 |
|
rlefaive joined #evergreen |
| 09:58 |
csharp |
abneiman++ # yep, on a second read, bug 1714390 is definitely the problem we're dealing with |
| 09:58 |
pinesol_green |
Launchpad bug 1714390 in Evergreen "Fix for Web Client Copy Editor Fix" [Undecided,New] https://launchpad.net/bugs/1714390 |
| 09:58 |
abneiman |
:) I thought it rang a bell! |
| 10:02 |
|
mmorgan1 joined #evergreen |
| 10:32 |
|
jvwoolf joined #evergreen |
| 10:54 |
|
mmorgan joined #evergreen |
| 11:35 |
|
Stompro joined #evergreen |
| 11:38 |
|
Christineb joined #evergreen |
| 11:45 |
* Dyrcona |
is quickly coming to the conclusion that mixing cherry-picks, rebases, and merges is a recipe for frustration. |
| 11:46 |
Stompro |
Hello, does anyone know if staff logout actions are recorded anywhere in the database. In addition, is the workstation logged into recorded anywhere? I've been asked for a list of staff logins and logout times for a specific location and I'm trying to figure out what is possible without looking at the logs. |
| 11:48 |
Dyrcona |
You'll have to look at the logs. None of that is recorded in the database AFAIK. |
| 11:48 |
csharp |
yeah - logs only |
| 11:48 |
csharp |
though seems like a good use case for actor.usr_activity |
| 11:49 |
Dyrcona |
Yeah, or a new table, but +1 to a Lp bug to add it to actor.usr_activity. |
| 11:49 |
* Dyrcona |
decides its easier to make a new branch..... |
| 11:50 |
Dyrcona |
s/its/it's/ |
| 11:50 |
* Dyrcona |
stop picking nits. |
| 11:57 |
|
rlefaive joined #evergreen |
| 12:00 |
Stompro |
csharp++, Dyrcona++ thanks |
| 12:08 |
|
rlefaive joined #evergreen |
| 12:08 |
|
sandbergja joined #evergreen |
| 12:14 |
|
rlefaive_ joined #evergreen |
| 12:24 |
|
jvwoolf joined #evergreen |
| 12:29 |
Stompro |
Logouts are not actually recorded, are they? Either the session times out or the client forgets the key? |
| 12:31 |
mmorgan |
Stompro: I suspect you're correct about that. I have never seen a logout logged. |
| 12:39 |
Dyrcona |
They may be recorded at a higher log setting. |
| 12:39 |
Dyrcona |
Like going to debug (4) or internal (5), but you probably don't want all the other noise that goes along with those settings. |
| 12:42 |
csharp |
yeah - I sometimes want an intermediate loglevel between INFO and DEBG for exactly this kind of thing |
| 12:46 |
Dyrcona |
You could always change the code where the logging takes place to change its priority. |
| 12:46 |
berick |
Stompro: see open-ils.auth.session.delete in activity logs (info level) |
| 12:46 |
Dyrcona |
There you go. |
| 12:46 |
Stompro |
Thanks |
| 12:47 |
Dyrcona |
I *knew* they were logged, just didn't make the connection. :) |
| 12:49 |
mmorgan |
berick++ |
| 12:49 |
Dyrcona |
berick++ |
| 12:55 |
|
khuckins joined #evergreen |
| 13:27 |
gmcharlt |
kmlussier: (et al.) I think I've carried bug 1691269 across the finish line; I'd like another committer to review before merging |
| 13:27 |
pinesol_green |
Launchpad bug 1691269 in Evergreen "web client: copy templates created on XUL not displayed" [Medium,Confirmed] https://launchpad.net/bugs/1691269 - Assigned to Galen Charlton (gmc) |
| 13:42 |
JBoyer |
gmcharlt++ |
| 13:43 |
JBoyer |
gmcharlt++ # and again, for taking that on today when I had not the time |
| 13:43 |
JBoyer |
I may try to wedge conversion into the importer since there has been much confusion here and elsewhere on that front. |
| 13:44 |
JBoyer |
(but that can wait until this hits master since it's so close.) |
| 13:48 |
pinesol_green |
[evergreen|Jason Boyer] LP1691269: Webstaff Copy Editor Templates - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ac38f44> |
| 13:48 |
pinesol_green |
[evergreen|Galen Charlton] LP#1691269: (follow-up) include new cust in seed data - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=810322a> |
| 13:48 |
pinesol_green |
[evergreen|Galen Charlton] LP#1691269: include volume fields in converted copy templates - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ec7e154> |
| 13:48 |
pinesol_green |
[evergreen|Galen Charlton] LP#1691269: add unit test for convert_xul_templates - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c8df12a> |
| 13:48 |
pinesol_green |
[evergreen|Galen Charlton] LP#1691269: (follow-up) fix whitespace to match local style - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=da8b81e> |
| 13:52 |
* miker |
grabs 1084 |
| 13:55 |
miker |
gmcharlt++ # for reminding me of the upgrade script |
| 13:56 |
pinesol_green |
[evergreen|Mike Rylander] Stamping upgrade script for xul-to-web copy template translation - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=97bd826> |
| 14:11 |
|
jihpringle joined #evergreen |
| 14:17 |
|
rlefaive joined #evergreen |
| 14:24 |
|
rlefaive joined #evergreen |
| 14:50 |
|
rlefaive joined #evergreen |
| 15:11 |
|
rlefaive joined #evergreen |
| 15:30 |
|
remingtron joined #evergreen |
| 16:01 |
|
mmorgan1 joined #evergreen |
| 16:19 |
|
remingtron joined #evergreen |
| 16:41 |
|
RBecker joined #evergreen |
| 16:49 |
csharp |
so... for the fix to bug 1691269, the expectation is that I export from XUL client into XUL client? or is it supposed to be XUL templates imported into web client? (sorry - I'm having trouble tracking the expected workflow) |
| 16:49 |
pinesol_green |
Launchpad bug 1691269 in Evergreen "web client: copy templates created on XUL not displayed" [Medium,Fix committed] https://launchpad.net/bugs/1691269 - Assigned to Galen Charlton (gmc) |
| 16:59 |
csharp |
ah: https://bugs.launchpad.net/evergreen/+bug/1691269/comments/12 |
| 16:59 |
pinesol_green |
Launchpad bug 1691269 in Evergreen "web client: copy templates created on XUL not displayed" [Medium,Fix committed] - Assigned to Galen Charlton (gmc) |
| 17:01 |
|
mmorgan joined #evergreen |
| 17:02 |
|
mmorgan left #evergreen |
| 18:30 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 22:10 |
|
Jillianne joined #evergreen |
