Evergreen ILS Website

IRC log for #evergreen, 2017-09-01

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
05:00 pinesol_green News from qatests: Test Failure <http://testing.evergreen-ils.org/~live>
06:57 kmlussier joined #evergreen
07:14 rjackson_isl joined #evergreen
08:24 * kmlussier just tried cherry picking a patron barcode number.
08:24 kmlussier need...more...coffee
08:26 * gmcharlt briefly ponders what it would take to generate a commit whose hash includes a specified patron's barcode number
08:28 pinesol_green [evergreen|Bill Erickson] LP#1709521 Apply recent patrons from checkout - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fc886e1>
08:35 collum joined #evergreen
08:59 JBoyer joined #evergreen
09:02 JBoyer joined #evergreen
09:03 _adb joined #evergreen
09:05 JBoyer Quick Survey incoming (Because I intend to act on part of it in a few minutes...)
09:07 JBoyer We have OUS for "This is what a barcode looks like" (opac.barcode_regex) and "This string is valid to use for a barcode" (ui.patron.edit.ac.barcode.regex)
09:10 JBoyer No, never mind.
09:12 gmcharlt ... but I wanted to respond to the survey and say mu ...
09:12 gmcharlt ;)
09:12 JBoyer As I was typing things I realized I was making this too complicated. Nothing to see here, but there's a super simple branch incoming because there is something broken.
09:13 JBoyer (Short version: The web editor is using the "Looks like" regex, not the validator. No good.)
09:18 Bmagic Anyone ever seen this: http://imgur.com/a/onOyv ?
09:21 kmlussier Bmagic: Nope
09:22 Bmagic That's holdings maintenance
09:26 rlefaive joined #evergreen
09:48 bshum When people have ejabberd issues like Bogna, I always wonder how complex their ejabberd passwords are.  That special character goofiness always messes people up :\
10:20 * jonadab mumbles something incoherent about correct horse battery staple.
10:28 gmcharlt :)
10:35 jvwoolf joined #evergreen
10:43 csharp ... and one of Harvey's southernmost bands scrapes across Atlanta
10:43 csharp looks like Indiana/KY/Ohio are having a time of it
10:46 csharp Bmagic: maybe have them blow away the OpenILS profile folder and let the client re-create it?
10:46 csharp sometimes solves some of those "this weirdness is happening on this station and no one else can reproduce" things
10:49 Bmagic csharp: the issue is no longer happening
10:49 Bmagic It happened for everyone at the same time. All libraries, all workstations
10:49 csharp oh
10:49 Bmagic it cleared itself in less than 2 hours
10:49 csharp hmm - not sure about that then
10:49 csharp seems like there would have to be *some* log output around that
10:50 Bmagic yeah, I looked at the logs. Postgres, opensrf and nothing glairingly obvious
10:54 Bmagic It happened after hours but some of the libraries were still open. I will take a closer look this morning
10:54 Bmagic it cleared itself is a clue. I think it might have been drone related? Perhaps the drone was recycled and it cleared itself?
11:37 jvwoolf1 joined #evergreen
12:16 jihpringle joined #evergreen
12:17 yboston joined #evergreen
12:21 gmcharlt I'd like to request one more pair of eyes on bug 1710949, which I've tested and signed off on
12:21 pinesol_green Launchpad bug 1710949 in Evergreen "A one-call login API would be swell" [Wishlist,New] https://launchpad.net/bugs/1710949
12:39 berick gmcharlt++
12:50 pinesol_green Showing latest 5 of 17 commits to Evergreen...
12:50 pinesol_green [evergreen|Galen Charlton] LP#1708291: introduce egI18N - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=9d4ce86>
12:50 pinesol_green [evergreen|Galen Charlton] LP#1708291: web staff client serials module - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=cf77f78>
12:50 pinesol_green [evergreen|Galen Charlton] LP#1708291: add release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=55b5bb1>
12:50 pinesol_green [evergreen|Jason Etheridge] LP#1708291: remove initials field for serial notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=1f81ff6>
12:50 pinesol_green [evergreen|Galen Charlton] LP#1708291: tweak to subscription selector - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b437f50>
12:53 * dbs gets caught by default non-nullability in reports yet again - heh
12:53 kmlussier Woo hoo!
12:54 kmlussier That was for the big serials merge, not dbs' report troubles. :)
12:54 miker kmlussier: I'm staring down bug 1251394 right now, but it will probably conflict with the authorities branch ... are you looking at that one now-ish?
12:54 pinesol_green Launchpad bug 1251394 in Evergreen "Metabib Display Fields" [Wishlist,Triaged] https://launchpad.net/bugs/1251394
12:54 kmlussier miker: Yes I am
12:55 miker cool, I'll wait and resolve, then, if you're close
12:55 kmlussier miker: About 30 minutes?
12:55 miker super!
13:02 miker gmcharlt: I'll take the login api
13:02 gmcharlt miker++
13:02 gmcharlt dbwells++
13:08 pinesol_green [evergreen|Bill Erickson] LP#1710949 open-ils.auth.login API - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=18b313d>
13:08 pinesol_green [evergreen|Bill Erickson] LP#1710949 auth.login Perl live test script - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3bc96cf>
13:08 pinesol_green [evergreen|Bill Erickson] LP#1710949 Redact open-ils.auth.login params - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=d067a00>
13:08 pinesol_green [evergreen|Bill Erickson] LP#1710949 Release notes for auth.login - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f1f6489>
13:08 pinesol_green [evergreen|Galen Charlton] LP#1710949: add tests for blocking after failed attempts - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=cd22fa0>
13:14 miker grabbing 1062-1067
13:18 miker I'm going to stamp a couple forgotten upgrade scripts
13:24 dbwells miker: ack, darn, that would be me.  Thanks.
13:25 miker dbwells: no worries! :) I was puzzed for a moment, but order shouldn't matter, I'm pretty sure
13:26 miker I know I've done that at least twice, so...
13:28 pinesol_green Showing latest 5 of 11 commits to Evergreen...
13:28 pinesol_green [evergreen|Galen Charlton] LP#1373690: normalize IMD values better - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=e4b050e>
13:28 pinesol_green [evergreen|Galen Charlton] LP#1373690: fix typos - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a016bea>
13:29 pinesol_green [evergreen|Galen Charlton] LP#1373690: add USE_ID_FOR_OWNING_LIB EDI attribute - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b460000>
13:29 pinesol_green [evergreen|Bill Erickson] LP#1373690 EDI attribute set clone operation - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=216bfe5>
13:29 pinesol_green [evergreen|Mike Rylander] Stamp upgrade scripts for native EDI support - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=2d5002c>
13:40 berick all_yall++
13:43 jeffdavis gmcharlt: I've signed off on your followups for bug 1673870
13:43 pinesol_green Launchpad bug 1673870 in Evergreen "Add support for ebook API transactions in OPAC (OverDrive/OneClickdigital)" [Wishlist,Confirmed] https://launchpad.net/bugs/1673870 - Assigned to Jeff Davis (jdavis-sitka)
13:46 jeffdavis ... and added release notes.
13:47 dbs So I figured out my mysterious report failures. Apparently it's a bad idea to leave a Clark process running on an old server that's still pointing to your production database...
13:47 dbs dbs--
13:48 bshum Bizarro Clark...
13:49 dbs (and due to NFS uid switching, couldn't write to the directory - thus the consistent error message when the old server won the race and the failure did happen)
13:50 miker dbs: doh! ... I wonder if we should use PG's application name with clark and have it check for an connection with that app name at start-up, rather than the lock file check?
13:50 miker I've had a hidden zombie clark bite me too
13:51 miker (though, if we do that, we should make the app name a command line param with a default, because there is a use case for multiple clarks...)
13:54 abowling1 joined #evergreen
14:29 miker kmlussier: I'm about to be in the car for a while ... I'll check in later to see if I'm clear to re-rebased the display fields branch
14:31 kmlussier miker: Did I happen to mention it would be a very long 30 minutes? :)
14:32 miker kmlussier: no worries! I've busied myself with other stuff, and some minor cleanup of DF
15:00 jvwoolf joined #evergreen
15:05 kmlussier Is anyone having trouble getting a login in screen for the web client on master?
15:10 gmcharlt kmlussier: hmm, works for me
15:11 berick all good here too
15:11 pinesol_green Showing latest 5 of 6 commits to Evergreen...
15:11 pinesol_green [evergreen|Suzanne Paterno] LP#1688398: revamp public catalog bill payment page - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=7a09d8a>
15:11 pinesol_green [evergreen|Cesar Velez] LP#1688398 - fix hardcoded logo url in payment email trigger template - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=d2c886e>
15:11 pinesol_green [evergreen|Galen Charlton] LP#1688398: some tidying - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=0efd7b6>
15:11 pinesol_green [evergreen|Galen Charlton] LP#1688398: add release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=9ede1f1>
15:11 pinesol_green [evergreen|Galen Charlton] LP#1582354: put release notes entry in proper directory and fix typo - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=6e64e97>
15:13 berick jeffdavis: gmcharlt: i have ebook_api service running (tests pass) and ebook settings enabled in config.tt2 (including test mode).  i do see the ebook counts in my account.  what else should I be seeing?  possible to perform actions in test mode?
15:21 berick ah, cool, i'm getting some useful error logs.
15:21 gmcharlt not sure about what test mode permits (I'd borrowed test OverDrive credentials)
15:21 berick gmcharlt: *nod* thanks
15:23 jeffdavis catalog search for Tolkien, you should see some sample records with URIs like http://example.com/ebookapi/t/001 ; those records should display ebook holdings info and a "Check Out E-Item" or "Place Hold on E-Item" link; clicking on those should (after OPAC login) take you to a page with a button for checking out or placing a hold
15:23 abowling joined #evergreen
15:25 berick jeffdavis: Tolkien returns zero results.  they were added to the concerto data set?
15:25 kmlussier gmcharlt: OK, then, is it possible that anything in the database bits of the authority branch that could affect being able to log into the web client? It worked fine this morning when I was testing on an ugpraded database.
15:25 kmlussier It's the only branch I have on that VM outside of current master. Everything else looks great.
15:26 jeffdavis berick: They're there for me. I'm currently not seeing any titles with located URIs but no physical holdings.
15:26 kmlussier https://mlnc4.noblenet.org/eg/staff/ is the page. It doesn't fully load in Chrome. In Firefox, it loads, but I can't log in.
15:26 jeffdavis er, non-web-client searches return 0 results for me if all the results only have located URIs but no physical copies
15:27 berick jeffdavis: aha!  i'm getting them in the web client
15:28 kmlussier berick: They're located URIs, so you have to scope your search in the public catalog.
15:28 kmlussier Oh, sorry, jeffdavis already mentioned the Located URIs.
15:29 berick kmlussier: ah, ok.  i didn't put all the pieces together
15:31 jeffdavis In the Tolkien records the URI is scoped to CONS but they don't show up in a CONS-scoped OPAC search. Ditto for manually created records with CONS-scoped URIs.
15:32 jeffdavis I don't think that's an issue with the ebook code (which doesn't touch search results until the page has been rendered) but I haven't had a chance to test more yet.
15:32 abneiman kmlussier: FWIW I can get mlnc4 to load in Chrome, but I get nothing when I try to log in.
15:34 kmlussier I can now too, but I'm guessing that's because gmcharlt is performing some kind of magic spell.
15:34 berick jeffdavis: thanks.  i have enough here to get a sense of things.
15:35 gmcharlt kmlussier: try again now; apache2-websockets needed to be bounced
15:36 kmlussier gmcharlt: Sigh. Ok, I checked to make sure they were running, but did nothing else. Sorry about that.
15:39 jeffdavis berick: and getting back to the original question, in theory clicking the Checkout button should result in a message like "Item has been checked out" and your checkout count being incremented temporarily. The EbookAPI::Test handler has hardcoded responses so it will only authenticate for patron 99999359616, checkout will always and only succeed with item 003, etc
15:39 jeffdavis item 003 = title with URI http://example.com/ebookapi/t/003
15:40 jeffdavis I should of course document this more thoroughly somewhere.
15:41 pinesol_green [evergreen|Ben Shum] LP#1710991: Do not translate username and workstation in webclient navbar - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=df79b43>
15:48 berick jeffdavis: nice! i have actions
15:50 * kmlussier clears her throat
15:50 kmlussier Calling 1068, 1069, 1070, 1071, and 1072
15:51 kmlussier It seems like just yesterday we were hitting 1000
15:57 gmcharlt kmlussier++ # you have just given me an idea for the duck trivia part of  tonight's dev update
16:02 bshum Yay duck trivia :)
16:07 * kmlussier is now confused as to how upgrade scripts relate to ducks
16:08 gmcharlt kmlussier: "calling"
16:09 pinesol_green Showing latest 5 of 39 commits to Evergreen...
16:09 pinesol_green [evergreen|Jeff Davis] LP#1673870: fix OneClickdigital handler to reflect how their API actually works, documentation notwithstanding - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=9710a3b>
16:09 pinesol_green [evergreen|Galen Charlton] LP#1673870: add support for cache-busting - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c8a0199>
16:09 pinesol_green [evergreen|Galen Charlton] LP#1673870: some tidying up of JavaScript - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=e6b541b>
16:09 pinesol_green [evergreen|Galen Charlton] LP#1673870: avoid e-session cookie weirdness - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=0cbe5b5>
16:09 pinesol_green [evergreen|Jeff Davis] LP#1673870: release notes for ebook transactions - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a3f854d>
16:10 kmlussier Hey! How come the Overdrive stuff made it into the channel before the authority stuff? I cry foul.
16:12 kmlussier miker: It's been about 30 minutes. Feel free to poke at the Display Fields branch.
16:15 jeffdavis ha
16:16 berick kmlussier: your commits are in there, just buried.. happened at essentially the same time
16:16 berick "latest 5 of 39" .. i think i merged about 20
16:17 kmlussier Ah, well. They're both good causes.
16:32 pinesol_green News from qatests: Test Failure <http://testing.evergreen-ils.org/~live>
16:40 * gmcharlt takes a look at those
17:03 miker great news everyone! display fields rebases over master-with-authority without any conflicts!
17:03 kmlussier miker++
17:03 gmcharlt miker: I need to quickly sneak in a change to evergreen.vandelay_import_i​tem_imported_as_inh_fkey()
17:03 csharp "and there was great rejoicing"
17:03 Bmagic miker++
17:03 miker grabbing 1073, 1074
17:03 kmlussier Of course, that means you could have looked at it hours ago miker.
17:03 gmcharlt currently doesn't account for possiblity that imported_as can be null
17:04 miker gmcharlt: point me at a commit, I shall pick it
17:04 Bmagic just created the much-wanted regression test on bug 1411422
17:04 pinesol_green Launchpad bug 1411422 in Evergreen 2.12 "Copy details repeated in search results when item/volume moved with parts attached" [Medium,Confirmed] https://launchpad.net/bugs/1411422
17:04 kmlussier Oooh!
17:06 Bmagic funny, creating that test actually uncovered a potential bug. LOL, I guess that's what those tests are for, huh?
17:07 pinesol_green [evergreen|Cesar Velez] LP#1599894 - OPAC disable Add to MyList when doing metabib search - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3a14a50>
17:07 gmcharlt miker: user/gmcharlt/fix_vii_inh_fkey
17:07 miker gmcharlt: thanks, looking
17:09 miker gmcharlt: consider 1152753 closed :) ... do we need an upgrade script?
17:10 bshum @later tell Dyrcona So as we suspected, Fedora also has the library path issue like Stretch shows now for opensrf libs, but also there's dep package name changes, and SELinux breaking Ejabberd issues with Fedora 26. No joy with it.
17:10 pinesol_green bshum: The operation succeeded.
17:10 gmcharlt miker: whoops, it would help if I actually commited it
17:10 miker heh. will pick 2 commits, then
17:11 gmcharlt miker: :) I've updated the branch
17:11 miker it is known
17:11 * miker also grabs 1075
17:12 gmcharlt Bmagic: Open-ILS/src/sql/Pg/t/regress/lp1629108_​metarecord_constituent_result_reroute.pg
17:12 gmcharlt am I understanding correctly that the partiuclar value of source_list doesn't actually matter for hte purpose of the test?
17:12 Bmagic gmcharlt: I was looking at that as well
17:13 Bmagic yes, those ID numbers were* the constituent records on concerto once upon a time
17:13 gmcharlt they're still showing up -- but the order of the ids in source_list appears to be varying
17:13 Bmagic that would break the test for sure
17:14 Bmagic STRING_AGG(x.id::TEXT, ',') AS source_list doesn't enforce an order.... so I suppose the test shouldn't expect it to be in order
17:14 gmcharlt yeah
17:14 gmcharlt OK, I'll work up a patch right quick
17:14 Bmagic ty
17:19 pinesol_green Showing latest 5 of 23 commits to Evergreen...
17:19 pinesol_green [evergreen|Bill Erickson] LP#1251394 Author display field xpath - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c095a3a>
17:19 pinesol_green [evergreen|Bill Erickson] LP#1251394 Display fields release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=d74649d>
17:19 pinesol_green [evergreen|Galen Charlton] LP#1152753: fix fake FK trigger on vandelay.import_item - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=4d96474>
17:19 pinesol_green [evergreen|Galen Charlton] LP#1152753: upgrade script - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=0161aef>
17:19 pinesol_green [evergreen|Mike Rylander] Stamping upgrade scripts for Display Fields and Vandelay regression - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b930174>
17:20 gmcharlt Bmagic: bug 1714594
17:20 pinesol_green Launchpad bug 1714594 in Evergreen "lp1629108_metarecord_cons​tituent_result_reroute.pg test failure" [Medium,New] https://launchpad.net/bugs/1714594
17:21 * Bmagic looks
17:22 Bmagic gmcharlt: looks like a great solution
17:22 gmcharlt are you in a position to test it right now?
17:22 Bmagic You could ditch the "sfaf" off the tail of the success message while you are at it
17:22 Bmagic yes, I can teset
17:22 Bmagic /teset/test
17:22 gmcharlt thanks! (and feel free to get rid of the sfaf in your signoff patch)
17:23 Bmagic it will be a few minutes, I gotta get the pgtap stuff installed
17:24 gmcharlt kk
17:40 Bmagic it's failing for me
17:41 Bmagic but, I'm not seeing why
17:43 kmlussier gmcharlt++ #For all the 3.0 things!
17:43 kmlussier Have a nice weekend everyone!
17:43 pinesol_green [evergreen|Jason Boyer] LP1714512: Patron Edit Barcode Validation - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f70f6f6>
17:45 gmcharlt Bmagic: the second test, specifically?
17:46 Bmagic yes, I commented it out, and I have success. So at least I know that my pgtap stuff is doing it's thing
17:46 Bmagic doing some manual checking
17:47 Bmagic wait a minute, I thought we addressed this already
17:48 Bmagic This broke some time back when we changed the concerto set
17:49 gmcharlt well, back in February
17:49 gmcharlt but it broke again more recently
17:49 Bmagic yeah, mmr 240 isn't a good id anymore
17:51 Bmagic sorry, no, I'm wrong
17:51 Bmagic select metarecord,count(*) from metabib.metarecord_source_map group by 1 having count(*) > 1;
17:55 gmcharlt select metarecord,array_agg(source) from metabib.metarecord_source_map group by 1 having count(*) > 1;
17:56 gmcharlt that gives me {242,243,244} for 240 in a stock DB
18:00 Bmagic yep, I have that in my data, my problem is the function on my test db
18:01 Bmagic Sorry, I'm not much help. Does the test work for you?
18:04 gmcharlt it does - I'll think I'll just go ahead and push it for a clean testbed
18:06 gmcharlt and with that, I'm out for now. have a good weekend, all!
18:07 pinesol_green [evergreen|Galen Charlton] LP#1714594: fix lp1629108_metarecord_constituent_result_reroute.pg - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=0bef0c2>
18:09 Bmagic laters
19:21 StomproJ joined #evergreen

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat