| Time |
Nick |
Message |
| 05:00 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 07:09 |
|
rlefaive joined #evergreen |
| 07:12 |
|
rjackson_isl joined #evergreen |
| 07:32 |
|
agoben joined #evergreen |
| 08:15 |
|
collum joined #evergreen |
| 08:33 |
|
jeffdavi1 joined #evergreen |
| 08:33 |
|
jeff_ joined #evergreen |
| 08:33 |
|
book` joined #evergreen |
| 08:33 |
|
jonadab joined #evergreen |
| 08:33 |
|
JBoyer joined #evergreen |
| 08:33 |
|
genpaku_ joined #evergreen |
| 08:34 |
|
gsams joined #evergreen |
| 08:37 |
|
kmlussier joined #evergreen |
| 08:55 |
kmlussier |
Happy Friday #evergreen! |
| 08:55 |
kmlussier |
@coffee [someone] |
| 08:55 |
* pinesol_green |
brews and pours a cup of Hacienda La Esmeralda Special Mario Carnaval, and sends it sliding down the bar to sallyf |
| 08:55 |
kmlussier |
@tea [someone] |
| 08:55 |
* pinesol_green |
brews and pours a pot of Assam TGFOP Black Tea, and sends it sliding down the bar to cesardv (http://ratetea.com/tea/arbor-teas/assam-tgfop-black-tea/4368/) |
| 09:00 |
|
Dyrcona joined #evergreen |
| 09:03 |
JBoyer |
Angular, why u no work? <input type="number" string-to-number ng-model="actually.a.string"/> is ignoring the string-to-number directive. :( |
| 09:03 |
|
_adb joined #evergreen |
| 09:03 |
JBoyer |
(So you can set but not see the Price and Cost of an item...) |
| 09:04 |
Bmagic |
gmcharlt++ #release released |
| 09:11 |
JBoyer |
Ugh. Of course. All of the references and Plunkers that demonstrate string-to-number being used this way also include their own implementation... Fantastic. |
| 09:11 |
|
rlefaive joined #evergreen |
| 09:14 |
|
yboston joined #evergreen |
| 09:27 |
Dyrcona |
JBoyer: So steal one. :) |
| 09:29 |
JBoyer |
Dyrcona, that's the plan now. The fact that the Angular docs has a simple example certainly helps. |
| 09:33 |
|
jvwoolf1 joined #evergreen |
| 10:12 |
|
rlefaive joined #evergreen |
| 10:16 |
gmcharlt |
bug 1712840 is an easy-review-and-merge for a committer |
| 10:16 |
pinesol_green |
Launchpad bug 1712840 in Evergreen "Ebook tabs always visible in My Account" [Low,Confirmed] https://launchpad.net/bugs/1712840 |
| 10:22 |
|
_bott_ joined #evergreen |
| 10:27 |
|
_adb1 joined #evergreen |
| 10:50 |
pinesol_green |
[evergreen|Jason Boyer] LP1712922: Exclude Deleted ACPL in Vol/Copy Editor - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f10de92> |
| 11:24 |
|
Christineb joined #evergreen |
| 11:29 |
Dyrcona |
Just got this from grunt all with rel_2_12: PhantomJS 2.1.1 (Linux 0.0.0) ERROR |
| 11:29 |
Dyrcona |
SyntaxError: Unexpected token ']' at /home/opensrf/Evergreen/Open-ILS/web/js/ui/default/staff/cat/item/app.js:131 |
| 11:31 |
Dyrcona |
Yeah, looks like that should be } instead. |
| 11:31 |
Dyrcona |
Nop... take that back. |
| 11:32 |
Dyrcona |
Looks like something else is missing. |
| 11:33 |
Dyrcona |
grr. There's at least one } missing in the code between lines 50 and 131, but I'm not sure, yet, where it belongs. |
| 11:33 |
Dyrcona |
Possibly two. |
| 11:34 |
Dyrcona |
Line 82 or thereabouts. |
| 11:35 |
Dyrcona |
Yeah, need two } there. |
| 11:37 |
Dyrcona |
grunt all still fails. |
| 11:37 |
kmlussier |
I resolved a merge conflict in that file when merging the barcode completion code. I probably messed something up there. |
| 11:38 |
JBoyer |
It does look more like service.gotCopy is misplaced as opposed to any } being missing. |
| 11:39 |
berick |
also beware node is more finicky about trailing/extraneous commas in lists/objects than browsers are |
| 11:39 |
berick |
(a la IE6 IIRC) |
| 11:41 |
Dyrcona |
IDK: But it's broken, and line 82 looked it needed the }} from eyeballing the code and using editor's feature to jump over subexpressions. |
| 11:42 |
Dyrcona |
Someone who knows it better than I should fix it, then. :) |
| 11:42 |
JBoyer |
gmcharlt++ |
| 11:43 |
JBoyer |
I didn't realize why we were seeing failures on inserting copies using deleted locations; we had 2 with identical names, one system and one branch that was deleted. |
| 11:45 |
|
jeffdavis joined #evergreen |
| 11:45 |
Dyrcona |
Anyway, if anyone comes up with a fix that works, ping me. I'm kinda stuck at the moment.--I was going to test something. |
| 11:46 |
Dyrcona |
Well, specifically, Lp 1710512 |
| 11:46 |
pinesol_green |
Launchpad bug 1710512 in Evergreen "Alert message in Open-ILS/web/js/ui/default/opac/holds-validation.js is not translatable" [Medium,Confirmed] https://launchpad.net/bugs/1710512 |
| 11:46 |
Bmagic |
Has anyone had the xul runner staff client preset an alert box randomly that says "This page uses an unsupported technology that is no longer available by default" ????? |
| 11:46 |
|
mmorgan joined #evergreen |
| 11:47 |
Bmagic |
/preset/present/ |
| 11:47 |
jeffdavis |
Dyrcona: you're getting that on the rel_2_12 branch? |
| 11:47 |
Dyrcona |
Yes, origin/rel_2_12. |
| 11:48 |
jeffdavis |
I think I see the issue, give me a sec. |
| 11:48 |
Dyrcona |
Bmagic: Sounds like you're using a newer version of XULrunner. |
| 11:48 |
kmlussier |
jeffdavis: I'm pretty sure I messed up resolving a merge conflict when backporting your barcode completion. |
| 11:48 |
Bmagic |
Dyrcona: I'm not sure how that is possible |
| 11:48 |
kmlussier |
kmlussier-- |
| 11:48 |
Bmagic |
Can it update itself? |
| 11:49 |
Dyrcona |
Bmagic: No, but you can if the bump_xul target still exists. |
| 11:49 |
Bmagic |
it's happening on production (for a single workstation) - we are using 2.11.0 in production |
| 11:49 |
JBoyer |
kmlussier++ # nonsense. everyone makes mistakes. |
| 11:50 |
Dyrcona |
That single workstation may have a newer XulRunner installed. |
| 11:51 |
JBoyer |
And I have to say, the way Angular is built on piles and piles of nested anonymous functions is increasingly difficult for humans to parse... |
| 11:51 |
Dyrcona |
Closures.... Gotta love 'em. :) |
| 11:51 |
Bmagic |
Dyrcona: is that a separate windows package? Does it bleed from Firefox somehow? |
| 11:52 |
Dyrcona |
Bmagic: Yes, you can still download XulRunner, though it is discouraged and not receiving updates. |
| 11:52 |
JBoyer |
Bmagic, is this happening on a Linux workstation, or was there any kind of unusual issue building Windows clients? (i.e. did you have to download anything by hand to build it? |
| 11:52 |
Dyrcona |
Firefox and XulRunner will share extensions/add-ons. |
| 11:53 |
Dyrcona |
My first thought wast it was Mac OS X with a custom built client. |
| 11:54 |
Dyrcona |
That seems to me the easiest way to get a too recent version of XulRunner. |
| 11:54 |
Bmagic |
JBoyer: it was originally 2.9.1 and they upgraded to 2.11.0 using the standard update method presented by the UI |
| 11:54 |
Bmagic |
it's Windows 7 |
| 11:54 |
Dyrcona |
Bmagic: That should not do it. |
| 11:54 |
Bmagic |
I just uninstalled the staff client, downloaded the 2.11.0 binary, and installed it. Logged in, and I haven't seen the alert message yet |
| 11:55 |
Dyrcona |
I'd recommend that they uninstall it and install fresh.... What you did... :) |
| 11:56 |
Dyrcona |
I'm still suspicious if they have XulRunner itself installed. Perhaps they use some other app built in on XulRunner? |
| 11:56 |
Bmagic |
odd indeed, we will see how that goes |
| 11:57 |
Dyrcona |
I can think of one other thing: Their update hosed the installation and the oils url wrapper was not working right. |
| 11:58 |
Dyrcona |
I think if the oils wrapper is removed/not working, you'll get that message. |
| 12:05 |
jeffdavis |
kmlussier: yeah, looks like the barcode completion stuff from master got inserted in that file in a way that doesn't work. I'll see about a fix. |
| 12:06 |
kmlussier |
jeffdavis++ |
| 12:12 |
berick |
anyone running master as of this morning? getting search failures, wondering if it's me |
| 12:14 |
berick |
ah, i thik it is me |
| 12:21 |
|
jihpringle joined #evergreen |
| 12:22 |
dbs |
@later tell JBoyer I'm pretty sure that's one reason Angular rebooted its whole architecture for Angular.io with a TypeScript-based component architecture |
| 12:22 |
pinesol_green |
dbs: The operation succeeded. |
| 12:30 |
* berick |
confirms his search issues are local |
| 13:05 |
|
eady joined #evergreen |
| 13:15 |
|
collum_ joined #evergreen |
| 13:26 |
pinesol_green |
[evergreen|Jeff Davis] LP#1684988: add opt-in check to patron service - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=42528f5> |
| 13:46 |
jeffdavis |
kmlussier: working branch user/jeffdavis/lp1699566-barcode-completion-fix attempts to clean up that backport - the fix gives a console error when scanning a barcode in item status, but seems to work regardless |
| 13:47 |
kmlussier |
Dyrcona: Are you still up for testing a fix for 2.12? |
| 13:47 |
Dyrcona |
I'm just copying the branch name to paste into a terminal. |
| 13:50 |
Dyrcona |
jeffdavis++ It passes grunt all. I'll have to finish the installation and check item status. |
| 13:50 |
Dyrcona |
Then, I'll check what I was originally going to check. |
| 14:15 |
* kmlussier |
takes a look |
| 14:23 |
Dyrcona |
It's working for me. I'll sign off on jeffdavis' branch. I'll let kmlussier test it and push it if she wants. |
| 14:24 |
kmlussier |
Dyrcona: If it works for you, go ahead and push it. I didn't know if you were testing the whole thing or just the build. |
| 14:25 |
Dyrcona |
Well, I just copied and pasted some barcodes into item status. |
| 14:25 |
Dyrcona |
I'm not sure I have the necessary set up at my working ou to test barcode copletion. |
| 14:25 |
Dyrcona |
completion. |
| 14:27 |
kmlussier |
OK, I'll take a look then. |
| 14:29 |
csharp |
I have seen that before - it's referring to remote XUL I think |
| 14:30 |
csharp |
oops - sorry - responding to scrollback from earlier - please ignore :-/ |
| 14:33 |
Dyrcona |
csharp: Yeah, I got it. :) |
| 14:35 |
Dyrcona |
kmlussier: I pushed a signoff branch: user/dyrcona/lp1699566-barcode-completion-fix_2_12_signoff |
| 14:35 |
kmlussier |
Dyrcona++ |
| 15:01 |
|
mmorgan1 joined #evergreen |
| 15:10 |
kmlussier |
Everything looks good to me. jeffdavis++ Dyrcona++ |
| 15:18 |
kmlussier |
Bmagic: I've merged the fix. The 2.12 branch is ready for release 2.12.5a whenever you're ready. |
| 15:18 |
Bmagic |
ok thanks, I'll get on that asap |
| 15:19 |
kmlussier |
Bmagic++ |
| 15:41 |
pinesol_green |
Showing latest 5 of 6 commits to Evergreen... |
| 15:41 |
pinesol_green |
[evergreen|Cesar Velez] LP#1685929 - Extract itemSvc from item module to core - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=85852d5> |
| 15:41 |
pinesol_green |
[evergreen|Cesar Velez] LP#1685929: add implementation print spine labels to checkin grid - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=91771c5> |
| 15:41 |
pinesol_green |
[evergreen|Galen Charlton] LP#1685929: (follow-up) fix rebase error - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a456080> |
| 15:41 |
pinesol_green |
[evergreen|Galen Charlton] LP#1685929: adjust egItem.print_spine_labels() - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=5ec2a27> |
| 15:41 |
pinesol_green |
[evergreen|Galen Charlton] LP#1685929: (follow-up) fix passing copy when opening volume/copy editor - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7b41b66> |
| 15:57 |
gmcharlt |
kmlussier++ # she knows why |
| 15:57 |
gmcharlt |
*psst* she promised to review lots of major patches next week |
| 15:58 |
kmlussier |
gmcharlt: I think 'hope' was the word I used. |
| 15:59 |
pinesol_green |
[evergreen|Jason Boyer] LP1713064: String / Float Value ACP Editor Fix - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0d0e404> |
| 15:59 |
gmcharlt |
fair enough |
| 16:19 |
|
Jillianne joined #evergreen |
| 16:25 |
|
mmorgan joined #evergreen |
| 16:30 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 17:00 |
|
jvwoolf1 left #evergreen |
| 17:00 |
|
mmorgan left #evergreen |
| 17:39 |
phasefx |
grabbing 1055 |
| 17:43 |
pinesol_green |
[evergreen|Bill Erickson] LP#1712657 Merge patron checkout history - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9254b70> |
| 17:43 |
pinesol_green |
[evergreen|Jason Etheridge] LP#1712657: stamping schema update - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a95db71> |
| 17:48 |
berick |
phasefx++ |
| 17:59 |
phasefx |
ha, I used 1065 instead of 1055 :) |
| 18:19 |
|
jvwoolf1 joined #evergreen |
| 21:06 |
gmcharlt |
2.12.5a now available from https://evergreen-ils.org/egdownloads/ |
