Evergreen ILS Website

IRC log for #evergreen, 2017-08-14

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
05:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:19 rjackson_isl joined #evergreen
08:34 Dyrcona joined #evergreen
09:09 yboston joined #evergreen
09:13 mmorgan joined #evergreen
10:02 mmorgan1 joined #evergreen
10:25 jvwoolf joined #evergreen
10:45 mmorgan joined #evergreen
10:48 collum joined #evergreen
10:52 bshum Dyrcona: I saw your LP report from the weekend about i18n and those JS alerts
10:52 bshum I feel like that was reported previously, but I couldn't find another LP bug on the subject
10:52 Dyrcona yeah, well I want to add a string to that file.
10:53 Dyrcona Well, something similar was reported, but in that case it could be translated.
10:53 Dyrcona This particular string is new.
10:54 bshum Well, I'm not 100% sure of how the JS alerts get translated
10:54 bshum It wouldn't surprise me if that doesn't work (or was never addressed at all)
10:54 Dyrcona Do they?
10:55 bshum I haven't tested it
10:56 Dyrcona Well, if you put the js in a tt2 file, you can have them translated by tt2.
10:56 Dyrcona That only works for static strings, though.
10:56 bshum Yeah, but the PO template probably isn't made aware of the string's existence
10:56 Dyrcona If you need to change some value while the script is running...
10:56 bshum Since it's only polling the tt2 files
10:56 Dyrcona The file in question is not a tt2 file.
10:56 bshum I don't recall it grabbing .js files for content
10:57 bshum At least not for tpac
10:57 bshum So like I said then, I'm not sure it's even paying attention to that file for i18n purposes
10:57 Dyrcona I've put that part of my work off until after I get the main part working.
10:58 Dyrcona No, I don't think it is or any of the opac ui javascript.
11:00 bshum Yeah, nope, nothing in i18n Makefile for checking over stuff in Open-ILS/web/js/ui/default/*anything
11:00 Christineb joined #evergreen
11:00 bshum So yeah, none of that is being added to any PO template for translation at large
11:00 Dyrcona Well, staff is supposedly handled by Angular, no?
11:01 bshum Well, the .tt2 files are setup for being added to the POT
11:01 berick yeah, staff strings are all in the tt2
11:01 bshum But I don't see anything in place for if there are any .js files like your case
11:01 berick even the dynamic ones
11:01 Dyrcona And, maybe that should be a larger bug than just 1 string in 1 file: We need a way to translate arbitrary JavaScript code strings. :)
11:02 bshum Right
11:03 bshum Or it was a bad feature in the first place by introducing a non-functioning piece for i18n.  :)
11:37 jvwoolf1 joined #evergreen
11:58 sandbergja joined #evergreen
11:59 jeffdavis For the ebook stuff, I defined some translatable strings in a JS block within the TT2 file that in turn includes JS from Open-ILS/web/js/ui/default
12:00 jeffdavis Open-ILS/src/templates/opac/​parts/ebook_api/base_js.tt2 lines 10-14 or so
12:00 jeffdavis it's a pretty ad-hoc solution, a better approach would be nice
12:04 khuckins_ joined #evergreen
12:14 bshum jeffdavis: Interesting...
12:14 * bshum will have to test that out too
12:16 jihpringle joined #evergreen
12:42 Dyrcona I'd need a solution for something like a printf string "You're  placing %d  holds." and that gets tricky with i18n and languages like Polish.
12:43 gmcharlt https://evergreen-ils.org/evergreen-3-0-developme​nt-update-14-results-of-the-second-feedback-fest/
12:47 abneiman gmcharlt++
13:18 dbs gmcharlt++
13:47 csharp gmcharlt++
13:48 Dyrcona gmcharlt++
16:11 berick wonder if it's time to make an open-ils.auth api that does the .init and .complete dance under the covers so the caller doesn't have to muck with the hashing and 2-stage auth.
16:11 berick as a step toward deprecating .init and .complete
16:11 Dyrcona berick +1
16:12 Dyrcona open-ils.auth.login ?
16:12 berick :)
16:12 berick i mean, pretty much
16:13 Dyrcona another +1
16:13 pinesol_green [evergreen|Galen Charlton] LP#1701001: carve out a reusable patron search service - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fcd4229>
16:13 pinesol_green [evergreen|Galen Charlton] LP#1701001: split patron search form into separate templates - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=2e0ea0e>
16:13 pinesol_green [evergreen|Galen Charlton] LP#1701001: add search-to-hold to catalog app - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=9c6a92f>
16:13 pinesol_green [evergreen|Galen Charlton] LP#1701001: add "patron search" button to OPAC place hold form - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a489dc1>
16:13 pinesol_green [evergreen|Galen Charlton] LP#1701001: add release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c5838c8>
16:17 mmorgan left #evergreen
16:18 Jillianne joined #evergreen
16:42 StomproJ joined #evergreen
16:45 StomproJ joined #evergreen
16:52 StomproJ joined #evergreen
17:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
19:24 pinesol_green [evergreen|Angela Kilsdonk] Docs: Asciidoc fix - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=0a4960f>
19:52 StomproJ joined #evergreen
19:53 sard joined #evergreen
19:55 jeff_ joined #evergreen
19:55 dbwells joined #evergreen
19:55 Guest53887 joined #evergreen
19:55 mnsri_away joined #evergreen
19:55 Bmagic joined #evergreen
19:56 sandbergja joined #evergreen
19:56 dkyle joined #evergreen
19:56 bshum joined #evergreen
19:56 wsmoak joined #evergreen
19:56 rhamby joined #evergreen
19:56 miker joined #evergreen
19:56 rashma joined #evergreen
19:56 Shae_ joined #evergreen
19:56 akilsdonk_ joined #evergreen
19:56 fbeaudry_ joined #evergreen
19:56 abneiman joined #evergreen
19:56 BigRig joined #evergreen
19:56 sallyf joined #evergreen
19:56 tsbere joined #evergreen
19:56 pinesol_green joined #evergreen
19:56 sbrylander joined #evergreen
19:59 jeff_ joined #evergreen
19:59 dbwells joined #evergreen
19:59 Guest53887 joined #evergreen
19:59 mnsri_away joined #evergreen
19:59 Bmagic joined #evergreen
20:03 rashma joined #evergreen
20:03 Shae_ joined #evergreen
20:03 akilsdonk_ joined #evergreen
23:58 bshum @later tell Dyrcona I was reminded of paxed old bug about plural i18n handling in https://bugs.launchpad.net/evergreen/+bug/1192249 ; not that we're ready to combat that issue yet either
23:58 pinesol_green bshum: The operation succeeded.
23:58 pinesol_green Launchpad bug 1192249 in Evergreen "Stop using MakeText for plural forms" [Wishlist,Triaged]

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat