| Time |
Nick |
Message |
| 03:52 |
|
Jillianne joined #evergreen |
| 04:31 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 06:20 |
|
tsadok joined #evergreen |
| 06:40 |
|
rlefaive joined #evergreen |
| 07:12 |
|
agoben joined #evergreen |
| 07:15 |
|
rjackson_isl joined #evergreen |
| 08:09 |
|
rlefaive joined #evergreen |
| 08:21 |
|
kmlussier joined #evergreen |
| 08:40 |
|
mmorgan joined #evergreen |
| 08:44 |
|
bos20k joined #evergreen |
| 09:16 |
|
jvwoolf joined #evergreen |
| 09:25 |
|
Dyrcona joined #evergreen |
| 09:25 |
|
jvwoolf1 joined #evergreen |
| 09:33 |
|
yboston joined #evergreen |
| 09:46 |
pinesol_green |
[evergreen|Cesar Velez] LP#1669534 - OPAC hold request should not default to first SMS carrier - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f7deb92> |
| 10:11 |
|
bos20k joined #evergreen |
| 10:33 |
gmcharlt |
csharp: I've made an updated branch for bug 1098685 if you'd care to test again |
| 10:33 |
pinesol_green |
Launchpad bug 1098685 in Evergreen "User can select SMS notify without providing a valid address" [Medium,Confirmed] https://launchpad.net/bugs/1098685 |
| 10:47 |
|
gsams joined #evergreen |
| 10:51 |
csharp |
gmcharlt: trying to test - I think I'm fighting cache but it's still not working for me |
| 10:52 |
csharp |
I copied the files from your last commit into place and started testing - if there's something else I need, let me know |
| 10:52 |
gmcharlt |
csharp: does view source show holds-validation.js being linked? |
| 10:53 |
csharp |
hmm - no |
| 10:53 |
csharp |
lemme verify that the files are actually there |
| 10:53 |
|
collum joined #evergreen |
| 10:53 |
gmcharlt |
an apache reload can also clear internal template caching |
| 10:54 |
csharp |
ah - that's probably what's going on |
| 11:00 |
* csharp |
has to run to a meeting & will resume afterwards |
| 11:02 |
pinesol_green |
[evergreen|Liam Whalen] LP#1463166 Fix Batch update of Funds in Selection Lists - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ce1b7dd> |
| 11:02 |
pinesol_green |
[evergreen|Bill Erickson] LP#1463166 Apply funds from view/place orders and search - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=cd8c5f9> |
| 11:05 |
|
Christineb joined #evergreen |
| 11:15 |
|
rlefaive joined #evergreen |
| 11:17 |
|
JBoyer joined #evergreen |
| 11:43 |
|
kmlussier joined #evergreen |
| 11:50 |
|
khuckins joined #evergreen |
| 12:27 |
miker |
berick: are you handy? |
| 12:27 |
berick |
miker: i am |
| 12:27 |
miker |
and have time to maybe look at why some karma tests hate me? |
| 12:27 |
miker |
:) |
| 12:29 |
kmlussier |
Gee, I wonder what prompted that question. :) |
| 12:29 |
berick |
heh |
| 12:29 |
berick |
miker: point me at it |
| 12:29 |
miker |
kmlussier: yes, I wonder :) |
| 12:29 |
miker |
berick: https://bugs.launchpad.net/evergreen/+bug/1706107 is the bug |
| 12:29 |
pinesol_green |
Launchpad bug 1706107 in Evergreen "Offline mode for the Web Client" [Undecided,New] |
| 12:30 |
miker |
I'm starting to suspect that lovefield does not like node.js enough to work |
| 12:30 |
miker |
kmlussier: hey! since you're here, can I ask you to try something related to that branch? |
| 12:30 |
miker |
:) |
| 12:31 |
berick |
still based on user/miker/lp-1706107-offline-mode ? |
| 12:31 |
miker |
kmlussier: specifically, just using `grunt copy` and `grunt build` instead of `grunt all` |
| 12:31 |
miker |
berick: confirming, sec... |
| 12:32 |
miker |
berick: yessir |
| 12:32 |
kmlussier |
miker: Now isn't a good time, actually. Sorry! |
| 12:33 |
miker |
ok, np |
| 12:37 |
|
jihpringle joined #evergreen |
| 12:57 |
pastebot |
"berick" at 64.57.241.14 pasted "for miker -- karma config update for lovefield" (12 lines) at http://paste.evergreen-ils.org/596 |
| 12:57 |
berick |
that fixes the tests for me |
| 12:58 |
berick |
fyi, the services have to be loaded in a certain order, that's why it's not a simple services/*.js import |
| 13:09 |
miker |
berick: bah ... thanks... I fixed a different test problem a week or so ago with that same thing. I should'a known |
| 13:13 |
miker |
kmlussier: so, berick's fix is pushed to the offline branch |
| 13:13 |
kmlussier |
miker: OK, I'll take a look when I have a moment. |
| 13:19 |
kmlussier |
It would be nice if there were a way to identify words that should never be stemmed. Like 'kissinger.' |
| 13:26 |
|
rlefaive joined #evergreen |
| 14:18 |
csharp |
gmcharlt: I think I've learned why the fix for bug 1098685 - wasn't working for me - it works when I place a hold, but not when I set my notification prefs |
| 14:18 |
pinesol_green |
Launchpad bug 1098685 in Evergreen "User can select SMS notify without providing a valid address" [Medium,Confirmed] https://launchpad.net/bugs/1098685 |
| 14:18 |
csharp |
I was expecting the change to apply to the account prefs as well |
| 14:23 |
* csharp |
comments on the bug |
| 14:36 |
|
_adb joined #evergreen |
| 14:58 |
remingtron |
Dyrcona: are you available to answer a SIPServer question? |
| 14:59 |
Dyrcona |
sure |
| 14:59 |
remingtron |
what value should I put in the "institution" variable? |
| 14:59 |
Dyrcona |
Whatever you want. It isn't really used, IIRC. |
| 15:00 |
remingtron |
I have two successful tests from 00sc_status.t, but test 3 fails with "Unable to connect to ILS..." |
| 15:00 |
Dyrcona |
I never run those tests... |
| 15:00 |
remingtron |
ha |
| 15:00 |
Dyrcona |
And, I'm not sure that they work with a real ILS, just the dummy one that comes with SIPServer. |
| 15:01 |
Dyrcona |
These are the SIPServer tests, right? |
| 15:01 |
remingtron |
yes |
| 15:01 |
remingtron |
so basically, a failure of those tests shouldn't concern me? |
| 15:02 |
|
mmorgan1 joined #evergreen |
| 15:03 |
Dyrcona |
Not in the least if you're talking to a real ILS. |
| 15:03 |
Dyrcona |
The test that's failing uses a username of sip_01. |
| 15:04 |
remingtron |
cool, thanks for calming my fears. |
| 15:06 |
Dyrcona |
heh. it might even fail with the ILS.pm supposed to be used for testing. |
| 15:09 |
Dyrcona |
Yeah, looks like it will just plain fail. |
| 15:12 |
JBoyer |
remingtron, While you can use just about anything for an institution, it is (can be?) used to select different options for some SIPServer backend options in oils_sip.conf. We have one institution that needs that msg_64_barcode_something_something turned off and another where it's turned on. |
| 15:13 |
Dyrcona |
Yeah. It will match up in the configs. I guess I sort of assumed..... |
| 15:13 |
JBoyer |
I think you're more likely to get noisy warnings in the logs too if you don't have a matching institution for clients to specify, but that may just be poot memory. |
| 15:14 |
JBoyer |
Dyrcona, If this is the first time it's being setup at Calvin you don't want to assume too much; you know how much fun SIP can be, heh. |
| 15:14 |
Dyrcona |
:) |
| 15:15 |
Dyrcona |
JBoyer: It wasn't a conscious thought. |
| 15:15 |
remingtron |
JBoyer: thanks for the added info |
| 15:16 |
Dyrcona |
So, yeah, the intsitution matches the institution configs in the oils_sip.xml, and you can have any number of them that you need, and they don't have to match anything in the database. |
| 15:16 |
Dyrcona |
you can use shortnames if you want, or just arbitrary names and so on. |
| 15:16 |
remingtron |
the official EG docs have a nice intro to SIPServer, which mention institutions in the config |
| 15:17 |
remingtron |
Dyrcona: thanks for confirming. I was worried that it needed to match the SIP user's org unit or something |
| 15:18 |
Dyrcona |
No. At mvlc we made institutions based on role, like selfcheck vs. patron look up, and so on. |
| 15:18 |
Dyrcona |
It also doesn't need to match what the client sends. |
| 15:19 |
Dyrcona |
The SIPServer will attempt to correct the client, but most clients ignore the server. :) |
| 15:20 |
remingtron |
good to know |
| 15:22 |
|
ohiojoe joined #evergreen |
| 15:28 |
berick |
remingtron: if you're planning to create more tests, this may be of value https://github.com/berick/pysip2 |
| 15:29 |
remingtron |
berick: thanks for sharing. I'm just scratching the surface at the moment, but I'll keep that in mind. |
| 15:30 |
rhamby |
berick++ : I've used pysip2 before and it's handy |
| 15:33 |
* Dyrcona |
usually uses phpsip2 but has used pysip2 |
| 15:37 |
|
Jillianne joined #evergreen |
| 15:37 |
berick |
phpsip2++ also handy Dyrcona, where does that live? i keep losing the link. |
| 15:39 |
Dyrcona |
http://git.mvlcstaff.org/?p=tsbere/PHPSIP2.git;a=summary |
| 15:39 |
berick |
ah, tried git.mvlc.org which ain't a thing |
| 15:41 |
|
abowling joined #evergreen |
| 15:50 |
|
kmlussier joined #evergreen |
| 16:14 |
|
mmorgan joined #evergreen |
| 16:31 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 16:49 |
|
ningalls joined #evergreen |
| 17:05 |
|
mmorgan left #evergreen |
| 17:11 |
gsams |
Anyone have advice for completely overhauling permission groups? |
| 17:12 |
* gmcharlt |
claims 1050 in the name of miners everywhere! |
| 17:16 |
pinesol_green |
[evergreen|Cesar Velez] LP#1480432 - Added tests for permission.usr_perms() change - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1f02799> |
| 17:16 |
pinesol_green |
[evergreen|Michele Morgan] LP#1480432: choose broadest depth if staff has same perm multiple times - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2790b6e> |
| 17:16 |
pinesol_green |
[evergreen|Galen Charlton] LP#1480432: stamp DB update - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=db7b67a> |
| 17:16 |
kmlussier |
Yay! mmorgan++ cesardv++ gmcharlt++ |
| 18:13 |
csharp |
gsams: been planning something like that in PINES for some time, but it hasn't risen to the top - I would do it on a test server and work incrementally |
| 18:15 |
gsams |
csharp: Seems wise for sure. We've not really adjusted well over the years and I think sooner would be better than later for this process. |
| 18:17 |
jihpringle |
gsams: we overhauled one of our permission group sets a while ago (we have different groups for different library types) |
| 18:17 |
jihpringle |
we set up the new permission groups on a test server and then copied them over to our production server when we were ready |
| 18:18 |
jihpringle |
and then updated the users to use the new groups |
| 18:18 |
jihpringle |
we didn't remove the old groups until we have confirmation that everything was working as expected |
| 18:19 |
jihpringle |
it worked well for us, but it was just our K-12 perms we overhauled so only 15 or 16 libraries affected |
| 18:21 |
gsams |
jihpringle: awesome, thanks for sharing. We are only 14 public libraries, so I think we could make that work really well. |
| 18:22 |
jihpringle |
gsams: you' |
| 18:22 |
jihpringle |
you're welcome :) |
| 18:22 |
jihpringle |
let me know if you have questions |
| 18:23 |
gsams |
Will do! |
| 18:23 |
kmlussier |
@sortinghat |
| 18:23 |
pinesol_green |
Hmm... kmlussier... Let me see now... GRYFFINDOR! |
| 19:35 |
|
rlefaive joined #evergreen |
| 20:37 |
|
Jillianne joined #evergreen |
