Evergreen ILS Website

IRC log for #evergreen, 2017-03-03

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
01:51 dbs yay, found fixes for corrupted mods3*, marctxt, and ris in bug 1442276
01:51 pinesol_green Launchpad bug 1442276 in Evergreen "Supercat encoding problems with MODS output (Zotero)" [High,Confirmed] https://launchpad.net/bugs/1442276
05:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
06:17 kmlussier joined #evergreen
06:55 kmlussier When I was re-looking at bug 1308090 yesterday, I realized I never checked or added anything for the required reingest for the upgrade script. It therefore didn't make it to the 2.12 upgade script.
06:55 pinesol_green Launchpad bug 1308090 in Evergreen "sorting of name headings with relator codes " [Wishlist,Fix released] https://launchpad.net/bugs/1308090
07:01 kmlussier And I see our tests are working again! Dyrcona++ bshum++ phasefx++
07:16 kmlussier Hmmm...the bottom row of the detailed item status page in the web client is misaligned.
07:29 agoben joined #evergreen
08:33 mmorgan joined #evergreen
08:34 * kmlussier could get through these signedoff bugs more quickly if she stopped adding commits to them.
08:39 kmlussier Hmmm...I've never noticed that 'publicly visible' option when creating a copy bucket in the web client. Is that new?
08:42 mmorgan Oooh! Must be new, can't do that in the xul client.
08:42 mmorgan Many times we've wanted to do just that!
08:42 kmlussier But what does it do?
08:45 mmorgan I'm guessing, but may be making this up, that it acts like it does when a public one is created by a patron in the catalog. You can link to it directly and anyone can see it.
08:45 kmlussier mmorgan: No, this is a copy bucket, not a record bucket.
08:46 kmlussier Though, now that you mention, /me checks record buckets.
08:46 mmorgan Oh, missed that bit. I also see the Publicly Visible when creating a record bucket.
08:47 kmlussier Yes. Something to play with later but unrelated to what I'm testing at the moment.
08:47 * kmlussier gets easily distracted.
08:48 * mmorgan also gets easily distracted :)
08:49 kmlussier On an entirely different note (distracted once again), it's a good idea to write test plans when submitting bug fixes to avoid problems I've seen in a couple of Bug Squashing events where testers don't realize they need to enable a setting to test the fix.
08:49 kmlussier My PSA of the day.
08:51 kmlussier Also, if anyone wants to see an example of good test plan writing to use as a model, take a look at any bug-fix commit that comes from gmcharlt. His are very clear and easy to follow.
09:17 mdriscoll joined #evergreen
09:19 terran joined #evergreen
09:22 kmlussier Now that terran is here, I just want to say that I think we should always have a full Bug Squashing Week in between the beta and RC releases. I think this has worked out very well!
09:22 kmlussier terran++
09:23 kmlussier bug_squashers++
09:25 maryj joined #evergreen
09:25 yboston joined #evergreen
09:27 terran I agree! I've really liked the pacing of this one and how more people have been able to participate at different times.
09:27 terran Catching up on statistics right now...
09:30 pinesol_green [evergreen|Kyle Huckins] LP#1537223 Show Username on copy buckets - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a1c55d7>
09:30 pinesol_green [evergreen|Bill Erickson] LP#1537223 Shared bucket barcode links; last name - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=befdbad>
09:42 pinesol_green [evergreen|Bill Erickson] LP#1539089 Webstaff grid actions disabled until selected. - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=33a071a>
10:00 * kmlussier chuckles at the number of signoffs we have for a commit that replaces a 1px image.
10:02 pinesol_green [evergreen|Jonathan Schatz] Replace the 'broken cover' image asset with an actually transparent single-pixel PNG. - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=7dae4c2>
10:13 terran Ha!
10:26 Jillianne joined #evergreen
10:35 csharp we should definitely pick a commit that everyone signs off on
10:35 * bshum feels like we've done that once before, but can't remember which one.  And of course it wasn't "everyone"
10:49 terran The bug squashing tracking sheet is now up to date: https://docs.google.com/spreadsheets/d/1RPR5gIL02E​iIvsg5vDKLs40rgw0Daqy4_TRWPlqU0WY/edit?usp=sharing
10:50 terran There are 12 new or updated patches that are ready to test listed on the bottom-right if anyone has time today
10:52 terran kmlussier: I have to do some other things first, but I intend to go through the test cases for 2.12 you sent out
10:52 kmlussier terran: Great, thanks!
11:00 * kmlussier points out that we need to get some kind of consensus here  https://bugs.launchpad.net/ever​green/+bug/1170795/comments/12 on whether we need a setting to determine if deposits should automatically be refunded at the time the deposit item is returned.
11:00 pinesol_green Launchpad bug 1170795 in Evergreen "Deposit refunds not applying as expected on item check in" [Medium,Confirmed]
11:07 * kmlussier hesitates to bring up the topic of negative balances, but here it goes...
11:08 mmorgan kmlussier beat me to it!
11:08 kmlussier I'm unable to produce a negative balance in the web client on 2.12. I have an OU setting to void the lost fee on an item's return...
11:09 kmlussier I mark an item lost and then have the user pay for it.
11:09 kmlussier I scan the item at checkin and see the red text above telling me there is a negative balance from the transaction...
11:09 kmlussier but when I retrieve the patron record, there is no negative balance.
11:09 kmlussier Am I missing a setting or a step?
11:09 * kmlussier hasn't tried the xul client.
11:10 terran I created a negative balance by creating a bill, paying it, and then voiding the original billing line item, and that worked.
11:10 kmlussier Of course, the inability to create a negative balance could be seen as a feature rather than a bug.
11:10 * mmorgan actually thought kmlusser was referring to the deposit issue...
11:10 kmlussier terran: OK, but I'm concerned that the checkin isn't doing what it's supposed to do.
11:11 kmlussier mmorgan: No, I'm just spouting opinions about deposit items. I'm not actually looking at them.
11:11 terran It sounds like the lost fee isn't really getting voided upon checkin - what do the full details of the bill show?
11:13 kmlussier I feel like my head rebels against thinking whenever I'm doing anything related to negative balances.
11:14 kmlussier Oh! The negative balance shows in Bill History.
11:14 kmlussier It doesn't show in the tally on the Bills tab
11:14 kmlussier Or in the current Bills
11:14 terran Oooh, that's definitely a bug then.
11:14 kmlussier https://mlnc2.noblenet.org/eg/staff/ci​rc/patron/10/bill_history/transactions
11:15 kmlussier terran: Well, the thing that sent me here is that I'm not able to retrieve any patrons in the Patrons with Negative Balances interface either.
11:16 terran The negative balance interface problem was patched this week
11:18 kmlussier Is it in master?
11:18 bshum https://bugs.launchpad.net/evergreen/+bug/1668351 <-- not yet
11:18 kmlussier Maybe I was testing one negative balance patch but missed the others.
11:18 pinesol_green Launchpad bug 1668351 in Evergreen "Web Staff Client - Patrons with Negative Balances selection problem" [Undecided,Confirmed]
11:18 * bshum assumes that bug is what terran is talking about
11:18 kmlussier bshum: Yes, that's the one I was testing.
11:19 mmorgan kmlussier: There's a cash payment that matches that negative billing. Or was that for a different billing?
11:19 kmlussier mmorgan: The only payments I performed happened before checking the item in. So, yes, there should be a cash payment that zeroed out the bill.
11:19 terran Thanks Ben, yes!
11:20 kmlussier And then the item checkin produces the negative balance.
11:20 mmorgan Ah. Gotcha.
11:20 * kmlussier looks at this patron in the xul client
11:23 kmlussier OK, so in the xul client, the negative balance doesn't show under the bills at the top of the patron record. So that's not a bug.
11:23 kmlussier But this record in the xul client does show -24.99 as Total Owed and also lists this transaction in the Current Bills. I guess this is the bug.
11:29 terran Agreed - it should show as -24.99 total owed as it does in the xul client
11:29 mmorgan kmlussier: Looking at that patron in the web client, I also see a Total Billed: $1.70, Total Paid: $1.70 that I don't see in the xul client.
11:30 terran The -24.99 bill should re-appear on the list of current bills as well as in the history
11:31 berick terran: for bug 1642378, now that the grid loads when the page loads, do you still think it would benefit from a progress bar?  (I have not tested on a large data set).  if it's going to appear then almost immediately disappear, probably best not to add one.
11:31 pinesol_green Launchpad bug 1642378 in Evergreen "Web Staff Client - Wish List - Patrons With Negative Balances Loading" [Wishlist,New] https://launchpad.net/bugs/1642378
11:31 kmlussier Yeah, so the Total Billed and Total Paid usually clear out after you leave that patron record, right?
11:32 kmlussier berick / terran: That's the other bug I was looking for. Without bug 1642378, would it be possible that I wouldn't retrieve a patron at all in that interface?
11:32 pinesol_green Launchpad bug 1642378 in Evergreen "Web Staff Client - Wish List - Patrons With Negative Balances Loading" [Wishlist,New] https://launchpad.net/bugs/1642378
11:33 berick kmlussier: as it stands, you have to select another org, then go back to the org you want.
11:33 kmlussier mmorgan: I find it odd that you see that too. I thought it might persist due to some kind of local storage issue on my part.
11:33 kmlussier berick: OK, I'll try that.
11:33 terran berick: I haven't tested with a large dataset, but I know with a large dataset in 2.11 it takes a long time to load that screen so I think it would benefit from the progress bar
11:33 berick terran: great, thanks, then i'll add one.
11:33 terran berick++
11:34 * kmlussier considers loading a new VM with all negative balance interface patches as well as progress bar code.
11:34 kmlussier And then I'll file bugs on these other bill issues. Phew! I think I fell down a rabbit hold.
11:34 kmlussier hole, even
11:35 brahmina joined #evergreen
11:36 kmlussier Huh, the patron doesn't show in the xul negative balance interface either. I wonder if there's something more going on here. Sigh...
11:36 kmlussier @hate negative balances
11:36 pinesol_green kmlussier: But kmlussier already hates negative balances!
11:39 * mmorgan has seen that before, where the negative balance shows in the bill detail, but not under the Bills total that the patron owes.
11:41 kmlussier mmorgan: Generally, I would expect the full payment would have already been made for the deposit item, right? So there would be a negative balance because the library is refunding the money.
11:42 kmlussier Oops! I switched topics without any kind of transition.
11:42 kmlussier I'm now talking about https://bugs.launchpad.net/ever​green/+bug/1170795/comments/14
11:42 pinesol_green Launchpad bug 1170795 in Evergreen "Deposit refunds not applying as expected on item check in" [Medium,Confirmed]
11:42 terran @hate deposit items
11:42 pinesol_green terran: The operation succeeded.  terran hates deposit items.
11:42 kmlussier This revelation also makes me change my mind on the OUS
11:46 mmorgan I'm not sure we can always assume that the full deposit will be paid. It gets added like any other bill, right?
11:47 berick terran: fyi, removed 'wish list' from the title of bug 1642378, since it's a legit bug.
11:47 pinesol_green Launchpad bug 1642378 in Evergreen "Web Staff Client: Patrons With Negative Balances Loading" [Wishlist,New] https://launchpad.net/bugs/1642378
11:49 kmlussier mmorgan: Actually, I think I need to look at this feature before I comment any further on it.
11:59 rlefaive joined #evergreen
12:13 jihpringle joined #evergreen
12:31 sandbergja joined #evergreen
12:36 ejk_ joined #evergreen
12:40 book`_ joined #evergreen
12:41 StomproJ joined #evergreen
12:44 pinesol_green [evergreen|Galen Charlton] LP#1667835: avoid edi_fetcher.pl crash upon fetching zero-length file - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a3d1b7c>
13:47 kmlussier OK, here's what I found with negative balances. In 2.12, on a negative balance caused by the return of a lost item, the patron does NOT display in the patrons with negative balance interfaces for either the xul or the web client and does not display correctly in the patron record in the web client.
13:48 kmlussier If the negative balance is caused by manually voiding a partially paid bill, the display works as expected in both clients and in both interfaces.
13:48 * kmlussier is going to look  in the database now to see what the difference is between the two transactions.
13:54 * dbs starts installing an ubuntu xenial vm in the hopes of creating a pgtap test for bug 1442276
13:54 pinesol_green Launchpad bug 1442276 in Evergreen "Supercat encoding problems with MODS output (Zotero)" [High,Confirmed] https://launchpad.net/bugs/1442276
14:03 kmlussier One has an xact_finish date, the other does not. The one with the xact_finish date is the one that has problems. I'm thinking that checked-in transactions that still have a negative balance associated with them should not have an xact_finish date?
14:04 dbwells kmlussier: That's correct.  I noticed this also the other day.
14:04 kmlussier dbwells: Ah, thanks for confirming!
14:05 kmlussier I think I have everything I need to file a bug, but I need to wander off for a bit. I can file one in a bit.
14:05 kmlussier Unless one's already been filed and I missed it.
14:06 terran kmlussier: FWIW, I haven't seen a bug for that one yet
14:09 dbwells kmlussier: Without looking deeply, I think it might be the same as or related to bug #1618624.  I'll add a pullrequest, as unfortunately it has just been sitting there a while.
14:09 pinesol_green Launchpad bug 1618624 in Evergreen "Adjusting Bills to Zero Will Prematurely Close a Transaction" [Undecided,New] https://launchpad.net/bugs/1618624
14:10 dbwells kmlussier: There is also bug #1666622.  These might all be the same bug, or maybe not.  In any case, probably makes sense to start with the existing fix :)
14:10 pinesol_green Launchpad bug 1666622 in Evergreen "Adjust to Zero closes bill, hides new billing amount from patron summary" [Undecided,New] https://launchpad.net/bugs/1666622
14:11 kmlussier dbwells: Thanks, I'll check those out then when I get back.
14:11 kmlussier I thought the problem sounded familiar, but I was thrown off by the bill adjustment when this was an old-time void.
14:12 terran dbwells++
14:16 * dbs raises an eyebrow at python-zope getting installed as part of opensrf prereqs on xenial
14:23 bshum dbs: Is that one of the subpackages that gets thrown in when you choose --with-python ?  (hasn't tested with python options, etc.)
14:25 bshum Or I guess it's "enable-python" option
14:25 bshum Shows how much I don't use it
14:26 csharp might be a dependency of a dependency?
14:26 bshum Oh yeah
14:27 bshum python-zope.interface
14:27 bshum Guess I have that installed on my xenial VMs too
14:28 * bshum doesn't know the significance of that though
14:38 bshum And I guess it always installs all the dependencies regardless of what you choose.  That enable-python thing is a configure option, not a choice during makefile.install
14:38 bshum So I checked and my trusty VM also has that package, etc.
14:46 dbs bshum: I assume so
14:46 dbs (--enable-python)
14:51 pinesol_green [evergreen|Dan Scott] Docs: trivial typo - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=ceba7dd>
14:52 Bmagic Anyone using emailed checkout receipts yet?
14:58 dbs bshum: oh, actually no it's just "make -f src/extras/Makefile.install ubuntu-xenial", so yes, probably some (bogus) dependency of a dependency sort of thing. no big deal
14:58 dbs and I'm just catching up to what you wrote 20 minutes ago, jeez
14:59 bshum dbs: Don't worry, I do the same thing every time I sneak a peek at IRC chat on my phone too :)
15:05 pinesol_green [evergreen|Bill Erickson] LP#1615845 In-house-use permacrud IDL access - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=4075257>
15:05 pinesol_green [evergreen|Kyle Huckins] LP#1615845 In House Uses on Item Status - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=6d11be6>
15:05 pinesol_green [evergreen|Bill Erickson] LP#1615845 Item status view columns aligned - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=e6a1e7f>
15:41 Bmagic So no one is using emailed checkout receipts in production?
15:43 bshum Bmagic: They didn't create that for the XUL client I thought?
15:43 bshum Wasn't it web client only?
15:44 terran Bmagic: I thought it was for web client only, as well - I know we're not using it
15:44 bshum If so, I wouldn't expect it to get a lot of use yet.
15:44 Bmagic Right, the feature is not displayed on the xul client however, if the patron has opted in, it was supposed to email them when the done button was clicked
15:45 Bmagic or at least that is the way I read the release notes
15:45 terran The only place I've seen it work aside from the web client is in the self-check interface
15:46 bshum So...... are you asking if anyone is using it, or asking because it's broken?  :)
15:46 Bmagic just wondering if anyone was using it, or played with it for reals
15:47 bshum Just checking... whenever people ask questions like that, I think "why, is it broken? noooooooooo"
15:47 kmlussier Bmagic: No, it doesn't work in the xul client at all. I updated the release notes a while back on that one to make it clearer.
15:47 mmorgan Bmagic: My understanding is that it would not work in the xul client, so we have the trigger disabled.
15:47 kmlussier Or, at least, I *think* I updated the release notes.
15:47 Bmagic I'm doing just that, and found 40 action_trigger.event related to our pre-enabled definition
15:47 kmlussier I do remember that the tech specs for the feature made it clear that it wasn't available in the xul client.
15:48 Bmagic kmlussier: ah! Well, I guess that's that then. When we told our membership about it, the release notes must have been more misleading
15:48 bshum Coming soon, to Evergreen 3.0 :)
15:49 terran I have to leave for an appointment, but I'll update the Bug Squashing Week stats sheet tomorrow - thank you for an awesome week everyone!
15:49 bshum terran++ # tracking progress
15:50 kmlussier terran++
15:50 bshum terran++ # and bug squashing too :)
15:50 * kmlussier notices that the pace of her testing decreases considerably whenever she starts looking at billing.
15:53 Bmagic terran++
16:00 * kmlussier likes seeing Ready Player One in the Concerto dataset now. rhamby++
16:03 Bmagic sweet!
16:03 Bmagic rhamby++
16:03 Bmagic I can't seem to find a straight answer to this: Who can use the evergreen logo? When is it ok to do so?
16:05 Bmagic reading https://evergreen-ils.org/trademark-policy
16:10 jeff okay, so Evergreen 2.11 and up has another fun search_path + unqualified function call quirk that trips up pg_restore.
16:11 jeff about to search lp/irc again to see if we've covered this (i think it may have come up already), but quickly:
16:11 kmlussier Bmagic: My understanding is anyone can use without permission if you follow the guidelines in 2.2
16:12 jeff the function evergreen.unaccent_and_squash calls unaccent() which exists in the public schema, but since pg_restore explicitly sets search_path to something that does not contain the public schema, the restore fails to add the three unaccent-related indexes on actor.usr.
16:12 kmlussier Bmagic: Well, really, if you follow all of the guidelines on that page.
16:12 Bmagic :)
16:13 jeff ah yes: http://irc.evergreen-ils.org/evergreen/2017-01-19
16:13 kmlussier Bmagic: But if you're in doubt that your use of the mark adheres to these guidelines, then you can ask. There are lots of people who are better versed on it than me.
16:16 jeff now i have a follow-up question for JBoyer about this conversation from January.
16:17 dbs okay, there is now a pgtap test for bug 1442276
16:17 pinesol_green Launchpad bug 1442276 in Evergreen "Supercat encoding problems with MODS output (Zotero)" [High,Confirmed] https://launchpad.net/bugs/1442276
16:18 kmlussier dbs++
16:19 dbs There's still the barrier of creating a databse upgrade script with the signoff but at least the most relevant pieces are in place to squash this thing
16:19 jeff dbs++ not looking, but suspecting that will intersect with some old annoyances
16:33 * mmorgan feels we may be running out of bugs, adds more.
16:37 jeff mmorgan++
16:38 csharp mmorgan++
16:38 mmorgan bug_squashers++
16:38 * csharp readies the bug spray
16:41 jeff okay, confirmed that the error JBoyer received after qualifying the call from unaccent() to public.unaccent() was what you'd get if you didn't have the unaccent extension added to your database (say, if you created the db from a script that didn't issue "CREATE EXTENSION unaccent;")
16:47 kmlussier joined #evergreen
16:48 kmlussier I was able to confirm that dbwells' patch at bug 1618624 fixed that specific bug, but did not address the issue I saw this morning.
16:48 pinesol_green Launchpad bug 1618624 in Evergreen "Adjusting Bills to Zero Will Prematurely Close a Transaction" [Medium,Confirmed] https://launchpad.net/bugs/1618624
16:48 kmlussier I also was unable to replicate bug 1666622 to see if the patch fixes that too. I'm guessing it does, but can't confirm it.
16:48 pinesol_green Launchpad bug 1666622 in Evergreen "Adjust to Zero closes bill, hides new billing amount from patron summary" [Undecided,New] https://launchpad.net/bugs/1666622
16:53 dbwells kmlussier: thanks for testing and reporting back!  It seems likely, then that you problem from earlier is happening from the opposite direction, i.e. a case where the xact was legitmately closed, and now needs to be reopened.
16:53 csharp dbs: I'm testing the zotero unicode bug and I was able to reproduce it, but post-fix I'm still seeing the issue (using FF on Ubuntu) I've cleared the cache and I'm looking to see if I missed something
16:53 csharp pgtap test passes
16:55 kmlussier dbwells: Yes, that's what I was thinking. But my eyes were too tired to look at it further. :)
16:57 pinesol_green [evergreen|Dan Wells] LP#1618624 Fix thinko in adjust-to-zero - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=5df06a1>
17:00 * csharp has confirmed that the changes are correctly applied on his test server
17:01 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:01 csharp I'm testing within zotero, fwiw
17:01 kmlussier Yay for successful tests just as I'm about to quit for the weekend!
17:01 kmlussier Have a nice weekend everyone!
17:01 mmorgan kmlussier: Have a great weekend!
17:01 csharp kmlussier++
17:02 csharp @praise kmlussier
17:02 * pinesol_green And kmlussier raised the report up on high, saying O Lord, bless this thy circ report, that with it thou mayst blow thine enemies to tiny bits, in thy mercy.
17:02 * kmlussier really doesn't know how to create a good circ report, but will take any praise you dole out to her. :)
17:03 mmorgan kmlussier++
17:07 mmorgan left #evergreen
17:08 * csharp also walks away for the weekend
17:12 rhamby bmagic: kmlussier: anyone can reference Evergreen or use the logo within the guidelines given, additionally the Oversight can grant exceptions which has been done once that I'm aware of (a use was allowed as grandfathered in because their use predated the guidelines being written)
17:14 Bmagic rhamby: thanks for the info. Sounds good.
17:29 rhamby left #evergreen
17:29 rhamby joined #evergreen
17:31 rhamby left #evergreen
17:31 rhamby joined #evergreen
18:55 Dyrcona joined #evergreen
19:05 dbwells joined #evergreen
20:44 Jillianne joined #evergreen
21:52 pinesol_green [evergreen|Remington Steed] LP#1669004 Darken background of web client open menus - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c2ff26a>
22:02 pinesol_green [evergreen|Jason Stephenson] LP 1648922: Hide orgs that can't have users in workstation registration. - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f78a751>
22:14 pinesol_green [evergreen|Dan Scott] LP1584891: Export MARC holdings with UTF8 subfields - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=7b64bf9>
22:42 pinesol_green [evergreen|Bill Erickson] LP#1668351 Patrons with neg. balance selection repair - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=5ddf363>
22:42 pinesol_green [evergreen|Bill Erickson] LP#1668351 Patrons with neg. balance dbl-click - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=0dccf2a>

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat