Time |
Nick |
Message |
02:42 |
|
gsams joined #evergreen |
05:00 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
07:06 |
|
agoben joined #evergreen |
07:15 |
|
rjackson_isl joined #evergreen |
07:45 |
|
krvmga joined #evergreen |
08:05 |
|
drigney joined #evergreen |
08:05 |
|
akilsdonk_ joined #evergreen |
08:10 |
krvmga |
is it documented anywhere how to allow the patron to switch between languages in the OPAC? |
08:10 |
krvmga |
like PINES is doing...from English to Spanish |
08:10 |
|
Shae joined #evergreen |
08:11 |
|
miker joined #evergreen |
08:12 |
csharp |
krvmga: I'm not sure if it is - though basically the process is to add the locale to the DB, add the locale .po file to the filesystem on your app servers and tell eg_vhost where to find it |
08:12 |
csharp |
I don't remember whether it requires editing TT2 templates |
08:13 |
JBoyer |
csharp, krvmga, No, it's just the db + eg_chost.conf editing. |
08:13 |
csharp |
JBoyer: thanks for confirming |
08:14 |
JBoyer |
(Unless you've done a lot of custom work on tpac templates, in which case ymmv.) |
08:14 |
|
abneiman_ joined #evergreen |
08:19 |
|
rhamby joined #evergreen |
08:20 |
krvmga |
Thanks! |
08:20 |
krvmga |
csharp++ |
08:20 |
krvmga |
JBoyer++ |
08:32 |
|
rhamby joined #evergreen |
08:33 |
|
collum joined #evergreen |
08:45 |
|
mmorgan joined #evergreen |
08:49 |
|
krvmga joined #evergreen |
09:14 |
|
yboston joined #evergreen |
09:35 |
|
maryj joined #evergreen |
09:41 |
|
jvwoolf joined #evergreen |
09:42 |
|
remingtron joined #evergreen |
09:45 |
|
kmlussier joined #evergreen |
10:08 |
kmlussier |
Good morning everyone! I just wanted to remind everyone that we agreed at the last dev meeting to reschedule the Feb. meeting and won't be meeting today. I'm going to move it off the dev calendar. |
10:54 |
Bmagic |
Has anyone created an image manually for a bib that does not get one from "regular" sources. Such as a dummy bib for "computer" would be great if it had a generic image of a computer |
10:55 |
|
bos20k joined #evergreen |
10:57 |
jeff |
Bmagic: you can do that right now for specific records by adding the generic image in the right location on the filesystem, based on the item's record id. |
10:57 |
mmorgan |
Bmagic: http://docs.evergreen-ils.org/2.7/_including_locally_hosted_content_in_your_public_interface.html |
10:57 |
jeff |
Bmagic: for general-purpose "use this as a fallback for this record type", i'm interested (and we might already do that in our catalog), but know of nothing currently supporting that. |
10:57 |
Bmagic |
that sounds like something staff cannot do |
10:57 |
jeff |
mmorgan++ for the link to docs |
10:58 |
jeff |
Bmagic: absent a system like ours where staff have the ability to upload images + record IDs to a distinct system which then rsyncs to the right location on the Evergreen system, no -- it's not something that can be done from say, within the staff client at this time. |
10:59 |
Bmagic |
cool, thanks for the confirmation. I figured as much but wasn't 100% positive. |
10:59 |
Bmagic |
jeff++ |
10:59 |
Bmagic |
mmorgan++ |
10:59 |
|
krvmga_ joined #evergreen |
11:00 |
jeff |
you could tweak templates to key off of a specially-formatted 856 that points to one of a series of generic icons that you host. |
11:00 |
jeff |
there may even be an old ticket with a branch (also old) that allows 856 tags of a special format to override images at display time. |
11:00 |
jeff |
it would be nice to bake that in to the general AC system, too. we have records that would benefit from that. |
11:10 |
|
khuckins__ joined #evergreen |
11:26 |
csharp |
live PG disaster recovery: https://www.youtube.com/c/Gitlab/live |
11:45 |
|
bmills joined #evergreen |
11:50 |
|
mmorgan joined #evergreen |
12:02 |
|
maryj_ joined #evergreen |
12:05 |
|
dteston joined #evergreen |
12:16 |
|
jihpringle joined #evergreen |
12:18 |
tsbere |
Part of Today's fun for me: Disabling metarecord holds without disabling metarecords. |
12:19 |
* tsbere |
came up with what he hopes is a good enough solution for now |
12:21 |
|
remingtron joined #evergreen |
12:30 |
|
sandbergja joined #evergreen |
12:35 |
|
brahmina joined #evergreen |
13:12 |
|
Christineb joined #evergreen |
13:23 |
|
khuckins_ joined #evergreen |
14:08 |
|
khuckins joined #evergreen |
14:09 |
_bott_ |
Finding random holds that have no action_trigger.event entry for notifications. There seems to be matching errors recorded like this: http://pastebin.com/raw/btwtQfvK |
14:09 |
_bott_ |
Notice the random left paren in that query. |
14:17 |
phasefx |
@later tell Dyrcona another oreilly humble bundle going on. Different books this time |
14:17 |
pinesol_green |
phasefx: The operation succeeded. |
14:17 |
_bott_ |
I should note, we're running the bleeding edge hold targeter |
14:20 |
jeff |
_bott_: 2.11ish with bleeding edge hold targeter, or 2.10ish? |
14:20 |
_bott_ |
jeff: 2.11 |
14:25 |
csharp |
_bott_: seeing the same error here (2.11 with new hold targeter) |
14:26 |
_bott_ |
I believe that query comes from: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm;h=125b395ac757a6454047a853540a7aaf012272d4;hb=cea03ca2fe3bad3c5a2c6237086d91f3d4b847f2#l470 |
14:27 |
_bott_ |
I can't figure out if that $self->hold_id has the paren, or if it's getting introduced from something else |
14:29 |
csharp |
AND "ahr".cancel_time IS NULL AND "ahr".id != 16493998( ) |
14:29 |
csharp |
both parens are random |
14:31 |
_bott_ |
Ah, yes. I thought it was part of the JOIN, but you are correct |
14:38 |
csharp |
I'm trying to figure out if "$self" has a "hold_id" here |
14:39 |
csharp |
I mean, the hold ID is obviously there, but I'm wondering if it's adding () because it's a function not a field |
14:39 |
* csharp |
shrugs |
14:41 |
JBoyer |
I've been peeking some too, and my $hold = $self->hold is at the top of the sub, I suspect $self->hold_id should actually be $hold->{id} instead. |
14:41 |
csharp |
oh, I see - it's on lines 298-302 |
14:41 |
JBoyer |
That is, "my $hold = $self->hold;" not MY my, I mean, uh, never mind. ;) |
14:44 |
JBoyer |
Hmm, never mind indeed, I didn't realize $self had a hold_id and a hold. |
15:12 |
JBoyer |
Press delete, Word crashes the nVidia driver on my machine. Yay computers! |
15:12 |
|
jvwoolf joined #evergreen |
15:21 |
|
kmlussier joined #evergreen |
15:36 |
Bmagic |
I'm lost in Circulate.pm - Does a paid deposit get refunded upon checkin? It should right? I just dont see it in the code |
15:45 |
|
khuckins joined #evergreen |
15:47 |
mmorgan |
Bmagic: In a quick unscientific test, I did not see the paid deposit refunded on checkin. |
15:48 |
Bmagic |
mmorgan: yeah, that is what I am doing too. There is a permission I discovered: ITEM_RENTAL_FEE_REQUIRED.override that doesnt exist (yet) |
15:49 |
Bmagic |
I wonder if that somehow is needed to do the refund? |
15:51 |
mmorgan |
Hmm. I see ITEM_DEPOSIT_REQUIRED in the client override window at checkout. |
15:54 |
mmorgan |
That permission was missing, we added it. |
15:56 |
jihpringle |
Bmagic: we're running 2.10 and the deposit doesn't get refunded for us either. Ideally we'd want the bill to be voided on check in so the patron has a negative balance on their account to be refunded (like when a lost item is returned) |
15:56 |
mmorgan |
Also, ITEM_DEPOSIT_PAID pops up on checkin. We added the override permission for that as well. |
15:57 |
Bmagic |
I must be missing something |
15:57 |
Bmagic |
It seems like this feature would have been developed with the refund automated upon checkin. How did that get overlooked? |
15:59 |
mmorgan |
Bmagic: The item has a deposit amount and a checkbox: Deposit True/False. If the Deposit flag is set to False, I see the ITEM_RENTAL_FEE_REQUIRED exception. |
15:59 |
Bmagic |
yep, that is the difference I was just picking up on |
16:00 |
mmorgan |
lp 1170795 |
16:00 |
pinesol_green |
Launchpad bug 1170795 in Evergreen "Deposit refunds not applying as expected on item check in" [Medium,Confirmed] https://launchpad.net/bugs/1170795 |
16:01 |
mmorgan |
Not new, apparently. |
16:01 |
Bmagic |
oh! good, it's been reported |
16:02 |
Bmagic |
wow, that is old |
16:02 |
Bmagic |
well, I'll take a stab at it |
16:02 |
mmorgan |
We don't use the functionality at all, but have tripped over it when an amount was inadvertently entered into the deposit field. |
16:03 |
mmorgan |
er, deposit amount field. |
16:06 |
mmorgan |
Bmagic++ |
16:07 |
Bmagic |
Is there documentation somewhere that describes the combiniations of "Deposit Required" and "Deposit Amount" ? |
16:08 |
Bmagic |
It looks like depending on the combinations, the permissions required are different which I don't understand |
16:08 |
Bmagic |
Why do we have RENTAL and DEPOSIT categories? Should this just be condensed to a single permission set? |
16:09 |
jeff |
docs are likely weak there. if memory serves, a given copy can either require a rental or a deposit, but not both. if there is a non-zero value in the deposit amount field and deposit required is false, then that is a "rental". if there is a non-zero amount in the deposit amount field and deposit required is true, then that is a "deposit" copy. |
16:11 |
mmorgan |
I would favor the separate permissions, since the seeds are apparently already there. |
16:11 |
Bmagic |
why have a difference? |
16:12 |
Bmagic |
Either money is required to check it out or not... what am I missing? |
16:12 |
mmorgan |
If the deposit worked as intended, then the patron is owed that money upon return, so money needs to be available for that. |
16:12 |
jeff |
rentals and deposits are different things, so that combined with an existing install/status quo makes me lean toward remaining distinct absent convincing argument otherwise. :-) |
16:13 |
Bmagic |
Ah! So, when it's returned and it's a "DEPOSIT" then a refund is in order. Where "RENTAL" is non-refundable |
16:13 |
jeff |
rental is not intended to be refunded, correct. |
16:13 |
jeff |
original use case was billed-and-paid at time of checkout for rentals. |
16:13 |
jeff |
we never had renewals on rentals, so i don't know how that works or would be expected to work. |
16:14 |
jeff |
also, there was an old display/cosmetic quirk in jspac of "overdue, fines accruing" for rental items, because the fact that there was a (paid or not) billing on the xact violated previous assumptions. |
16:14 |
Bmagic |
ITEM_DEPOSIT_PAID is a permission that comes up upon checkin when "Deposit Required" is set to TRUE on the item. That is the only saving grace here. It alerts the staff that they need to do something |
16:14 |
jeff |
i don't know if that applied to deposit also, and i don't know if that's an issue in tpac at all. |
16:15 |
jeff |
we stopped doing rentals here before we stopped using jspac, i think. |
16:16 |
jeff |
yes, the intent of the override was to alert staff that they needed to bring up the patron account and manually handle the matter of the deposit. i don't know what usual steps were required there, but i expect that in most cases the patron was present at checkin and expecting the deposit be returned at that time. |
16:16 |
jeff |
others who used/use deposits may have more info there. |
16:17 |
* jeff |
plays with window functions across auditor tables |
16:17 |
Bmagic |
mmorgan++ |
16:17 |
Bmagic |
jeff++ |
17:00 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
17:04 |
|
mmorgan left #evergreen |
17:33 |
|
jvwoolf left #evergreen |
17:54 |
csharp |
Bmagic: PINES uses that feature - I can research and/or pass on any questions |
17:55 |
Bmagic |
csharp: Does Evergreen automatically void the deposit fee when the item is checked in? |
17:55 |
csharp |
if I remember right, it acts like a deposit if there's a deposit_amount entered and the deposit flag is set to true |
17:55 |
|
bmills joined #evergreen |
17:55 |
Bmagic |
checking out seems to be ok, its the checkin that has the issue |
17:55 |
csharp |
if the amount is there but deposit is false, it acts like a rental (no refund) |
17:55 |
csharp |
that's totally from (probably faulty) memory ;-) |
17:56 |
Bmagic |
csharp: we hashed that out earlier, I think I understand the difference between deposit and rental. The issue is LP1170795 |
17:57 |
csharp |
if($self->copy->deposit_amount and $self->copy->deposit_amount > 0) { |
17:57 |
csharp |
$self->is_deposit(1) if $U->is_true($self->copy->deposit); |
17:57 |
csharp |
$self->is_rental(1) unless $U->is_true($self->copy->deposit); |
17:57 |
csharp |
} |
17:57 |
csharp |
oh, I see |
18:02 |
csharp |
you're probably already there, but I'm looking at the check_circ_deposit subroutine that gets run within do_checkin |
19:07 |
|
dbwells joined #evergreen |
19:41 |
|
dbwells_ joined #evergreen |
19:46 |
csharp |
Bmagic: my research into this shows me that all checkin of deposit has *ever* done is push the ITEM_DEPOSIT_PAID event to the client - it never has created a refund/credit (as far as I can see) |
20:13 |
|
JBoyer_alt joined #evergreen |
22:12 |
|
apalma200 joined #evergreen |