Evergreen ILS Website

IRC log for #evergreen, 2016-08-24

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
01:03 rjackson_isl_ joined #evergreen
05:48 eady joined #evergreen
06:09 gsams joined #evergreen
07:08 TARA joined #evergreen
07:19 agoben joined #evergreen
07:28 rjackson_isl joined #evergreen
07:51 gsams_ joined #evergreen
07:54 miker just a few hours left to get your favorite feature branches merged ... unless anyone would like to advocate for a friday beta.
08:02 ericar joined #evergreen
08:03 * JBoyer looks at the FF window full of LP tabs...
08:05 * miker envies a single window...
08:08 rlefaive joined #evergreen
08:13 JBoyer The rest were lost in the great desktop reimage of '16. Now they're mostly bugs I have a branch for myself.
08:15 JBoyer bug 1593834 is fairly low impact and will end the scourge of Android email clients assuming our mail is sent from the beginning of unix time.
08:15 pinesol_green Launchpad bug 1593834 in Evergreen "Date header not set in default A/T email templates" [Low,New] https://launchpad.net/bugs/1593834
08:15 pinesol_green [evergreen|Jason Stephenson] LP 1306666: Abort Transit Only Change Copy Status if In Transit - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=cfe5110>
08:15 pinesol_green [evergreen|Jason Stephenson] LP 1306666: Add Perl tests for new behavior. - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=5f1362f>
08:15 pinesol_green [evergreen|Mike Rylander] LP#1306666: Rename test file - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=d3e3f3b>
08:15 JBoyer (I was hesitant to set the milestone to anything but 2.next because I thought the RMs were doing that.)
08:16 rlefaive joined #evergreen
08:24 kmlussier joined #evergreen
08:25 kmlussier miker: What is the deadline to merge? Can we still merge today or is it too late?
08:26 miker kmlussier: you can merge today
08:26 kmlussier Awesome!
08:27 miker JBoyer: I'd call that a bug fix, fwiw, but, I'm 'bout to merge it to master and 2.10
08:27 kmlussier I would like to advocate for bug 1612274 if somebody wants to look at it.
08:27 pinesol_green Launchpad bug 1612274 in Evergreen "Improvements to My Account Holds Screens" [Wishlist,Confirmed] https://launchpad.net/bugs/1612274
08:31 kmlussier I also wondered what the likelihood is of bug 1596595 getting in. I'm not in a position to test it myself since I would want to use a test system with production data, but we have a lot of interest in seeing faster holds targeting.
08:31 pinesol_green Launchpad bug 1596595 in Evergreen "Hold targeter features and refactoring" [Wishlist,New] https://launchpad.net/bugs/1596595
08:31 pinesol_green [evergreen|Jason Boyer] LP1593834: Add Date Header to A/T Email Examples - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=780f40a>
08:33 JBoyer miker, I suppose it's a seed data bug fix, the real benefit for existing installations is the brief documentation (if they don't follow LP).
08:34 miker kmlussier: about to look at the code. that's not an omnibus bug for all the ones listed in your last comment, right?
08:34 kmlussier miker: No, it's not. The other two I consider to be bug fixes, not new features.
08:38 jeff hecked_out_count
08:39 jeff this string brought to you by some unusual terminal wrapping.
08:39 kmlussier heh
08:39 jeff oh, probably horizontal scroll in less before the ssh session was terminated abnormally.
08:41 bshum I was thinking about this yesterday, but curious to gather some feedback from the group on https://bugs.launchpad.net/eve​rgreen/+bug/1095280/comments/3
08:41 pinesol_green Launchpad bug 1095280 in Evergreen "Build process doesn't get all translatable strings from templates" [Medium,Confirmed]
08:42 miker kmlussier: but you'd agree the UI behavior change in bug 1612274 is a feature, yeah?
08:42 pinesol_green Launchpad bug 1612274 in Evergreen "Improvements to My Account Holds Screens" [Wishlist,Confirmed] https://launchpad.net/bugs/1612274
08:42 kmlussier miker: Yes
08:42 miker cool
08:42 bshum It's a bug fix more than anything (so I won't distract from feature review), but that said, i18n sync for templates happens at beta too.  So if we can fix some of it before that, I imagine it would be nice for i18n efforts.
08:45 Dyrcona joined #evergreen
08:47 bos20k joined #evergreen
08:49 miker kmlussier: **sadface** ... I get a merge conflicts between 1612274 and 1614807. I'd prefer to  merge the bug fixes first, to both master and 2.10 ... do you think you'll have time to rebase the feature if I push the bug fixes to master now?
08:52 csharp miker: so if I want the fix to bug 1613374 in, I'll need to reconcile it with the fix for bug 1316666 that just got committed to master, yes?
08:52 pinesol_green Launchpad bug 1613374 in Evergreen "Feature Request: "Canceled Transit" Item Status" [Wishlist,Confirmed] https://launchpad.net/bugs/1613374 - Assigned to Chris Sharp (chrissharp123)
08:52 pinesol_green Launchpad bug 1316666 in OpenStack Dashboard (Horizon) "wrap_list is not honored for not-editable cells" [Low,Fix released] https://launchpad.net/bugs/1316666 - Assigned to Davide Guerri (davide-guerri)
08:52 * tsbere suspects one of those numbers was wrong
08:53 csharp doh - bug 1306666
08:53 pinesol_green Launchpad bug 1306666 in Evergreen 2.9 "When Aborting a Transit, items should not automatically get a status change." [Low,Confirmed] https://launchpad.net/bugs/1306666
08:53 * csharp has to step away
08:55 miker csharp: I'll look. resolution looks very simple, though, at a glance. I'll ping you if I'm uncomfortable with the merge resolution
08:56 bwicksall_ joined #evergreen
09:06 Dyrcona Grr... bash git completion is not working on my xenial vm.
09:06 _adb joined #evergreen
09:09 Dyrcona Because the shell script is not executable when it should be.
09:09 Dyrcona Thanks, Ubuntu....
09:11 Dyrcona Hrm. That's not it either, but oddly enough, the file has a different timestamp on two different xenial installations.
09:14 csharp miker: thanks
09:14 Dyrcona fixed it. but whatevs... ;)
09:17 Dyrcona gmcharlt bshum: It looks like moving the mod_perl prerequisite from OpenSRF to Evergreen fixes the enabling of the module on Xenial.
09:18 bshum Dyrcona: Yes, that's what I found too
09:19 Dyrcona I didn't look to see if we explicitly enable it, or the package is doing it, now.
09:19 kmlussier miker: Yes, I have time now.
09:19 miker kmlussier: cool. I'll push those bug fixes, then. thanks!
09:21 * Dyrcona will do his best to test the tz branch today, but time is not on his side.
09:21 pinesol_green [evergreen|Kathy Lussier] LP#1614807: Fix Circ History table header display on small screens - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=4c16071>
09:21 pinesol_green [evergreen|Kathy Lussier] LP#1614807: Holds history should look like other My Account screens - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=4e1ab37>
09:21 pinesol_green [evergreen|Kathy Lussier] LP#1614807: Fix spacing issues in responsive design for My Account screens - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f414ddd>
09:21 pinesol_green [evergreen|Kathy Lussier] LP#1614807: Make holds history more responsive - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=cbdb2e3>
09:21 pinesol_green [evergreen|Kathy Lussier] LP#1612364: Add transparency to some format icons - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a06fd54>
09:24 mmorgan joined #evergreen
09:25 * csharp changes timezones so he has more hours in the day
09:25 Dyrcona Grr....
09:25 Dyrcona Copy/pasta....
09:26 tsbere csharp: http://xkcd.com/320/
09:27 Dyrcona One of these days, I'll stop making typos and things, and then I'll be really dangerous. :)
09:49 tarac_ joined #evergreen
09:56 maryj joined #evergreen
09:59 Dyrcona joined #evergreen
10:23 kmlussier miker: Conflicts are resolved for bug 1612274
10:23 pinesol_green Launchpad bug 1612274 in Evergreen "Improvements to My Account Holds Screens" [Wishlist,Confirmed] https://launchpad.net/bugs/1612274
10:24 miker kmlussier: thanks!
10:28 pinesol_green [evergreen|Kathy Lussier] LP#1612274: Improve display of holds status in My Account - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b39eaf4>
10:28 pinesol_green [evergreen|Kathy Lussier] LP#1612274: Add distinct classes for hold statuses - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=5040765>
10:28 pinesol_green [evergreen|Kathy Lussier] LP#1612274: Release notes for improved holds interfaces - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=36f3313>
10:29 miker dbwells: re bug 1315552, is http://git.evergreen-ils.org/?p=working/Everg​reen.git;a=shortlog;h=refs/heads/user/dbwells​/lp1315552_fix_duplicates_in_ranked_volumes the correct branch still?
10:29 pinesol_green Launchpad bug 1315552 in Evergreen "Duplicate initial search results where copy circ lib/call number owning lib are different" [Medium,Confirmed] https://launchpad.net/bugs/1315552
10:34 berick just updated to master.., upgrade/0990.data.copy-count-badge.sql not happy.  could be my janky test db..
10:34 berick ERROR:  null value in column "id" violates not-null constraint
10:34 berick DETAIL:  Failing row contains (null, Copy Count, null, rating.copy_count, f, f, t).
10:39 berick maybe id should be a SERIAL?
10:39 berick in rating.popularity_parameter
10:40 * berick has not been following that branch closely
10:49 kmlussier Oof. I guess I didn't test the upgrade script on that one.
10:49 miker berick: I'll fix it. it needs to be a pinned ID
10:50 * berick nods
10:51 miker pushed
10:51 miker berick: thanks for testing!
10:54 pinesol_green [evergreen|Mike Rylander] Correct upgrade script - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=58fc8f0>
11:06 akilsdonk joined #evergreen
11:07 Stompro Does anyone know off the top of their heads if meta holds not showing up in catalog hold counts is expected behavior?  I tried to find a bug report on that, to see if anyone had suggested changes in that area, but didn't find anything.  Is that configurable?
11:08 tsbere Stompro: I believe it is known, I think in part due to issues with "should the given hold even show up on this bib?"
11:10 Stompro We just ran into a workflow situation, where cataloging staff use the current holds count to decide if something goes on the rush cart. There were several meta holds but since they didn't show up the copies took the slow boat to processing town.
11:12 * tsbere wonders if that is the basic reason one library keeps asking for us to put hold counts on the marc view screen in the staff client, without really saying anything more than "we need to know"
11:13 Stompro tsbere, you mentioned some improvements to searching and storing holds counts on bug 1155706 back in 2013, did those happen?  Should that bug be closed?
11:13 pinesol_green Launchpad bug 1155706 in Evergreen "Speed Up Hold Count Calculation/Display" [Wishlist,Triaged] https://launchpad.net/bugs/1155706 - Assigned to Kyle Tomita (tomitakyle)
11:14 tsbere Stompro: No, it didn't end up happening. Or rather, it initially happened, then other dev went into master and broke it horribly and I didn't re-write it.
11:18 Stompro tsbere, Thanks, is it something you still want to happen someday, or is it dead.  I can add a note to the ticket but I want to make sure I'm accurate.
11:18 tsbere Stompro: At this point I am not likely to get back around to it, though some other work may cover some of it at some point. Not really sure.
11:20 pinesol_green [evergreen|Jason Boyer] LP1259196: Use Location as Workstation on Login - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f5867b2>
11:20 pinesol_green [sipserver|Jason Boyer] LP1579144: On Login, Send Location to ILS - <http://git.evergreen-ils.org/?p=​SIPServer.git;a=commit;h=69fd465>
11:20 Stompro tsbere, thanks.
11:34 collum joined #evergreen
11:44 Christineb joined #evergreen
11:51 dbwells miker: was afk, let me check
11:55 dbwells miker: Yes, that is the correct branch.
11:57 miker dbwells: thanks!
11:58 miker grabbing 0991
12:02 pinesol_green [evergreen|Dan Wells] LP#1315552 Don't use circ_lib name in ranked_volumes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=db9a0bb>
12:02 pinesol_green [evergreen|Mike Rylander] Stamping upgrade script for ranked-volumes update - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=51759b2>
12:04 rlefaive joined #evergreen
12:10 miker berick: I've signed off your commits to the is_available branch ... want to look at the branch one last time, or are you happy with it?
12:10 berick miker: i'm happy with it.  did a few more tests this a.m.
12:11 berick gracias
12:12 miker kk
12:12 berick miker: did you see the comment on bug #1588948 I added just before you posted your code?
12:12 miker grabbing 0992
12:12 pinesol_green Launchpad bug 1588948 in Evergreen "Authority update propagation should update bib record editor and edit_date" [Undecided,New] https://launchpad.net/bugs/1588948
12:14 miker berick: update_headings_tgr is a BEFORE trigger, and aaa_auth_ingest_or_delete is an AFTER, so they run in the right order already
12:14 berick miker: oh!  nevermind then
12:14 berick thanks
12:15 berick i'll test that branch
12:15 miker (I had the same thought, so doublechecked when looking for the best place to insert the check)
12:15 jihpringle joined #evergreen
12:22 pinesol_green Showing latest 5 of 7 commits to Evergreen...
12:22 pinesol_green [evergreen|Bill Erickson] LP#1464709 Rename checkout_ok to is_available - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=2c40b84>
12:22 pinesol_green [evergreen|Mike Rylander] LP#1464709: teach QP about is_available statuses - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fed65df>
12:22 pinesol_green [evergreen|Mike Rylander] LP#1464709: Disentangle on-holds-shelf from is_available - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f0aa5d5>
12:22 pinesol_green [evergreen|Bill Erickson] LP#1464709 Copy status is_available release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=d60ea52>
12:22 pinesol_green [evergreen|Mike Rylander] Stamping upgrade of is_available branch - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=40e2068>
12:24 bmills joined #evergreen
12:32 miker csharp: please see my comment on bug 1613374
12:32 pinesol_green Launchpad bug 1613374 in Evergreen "Feature Request: "Canceled Transit" Item Status" [Wishlist,Confirmed] https://launchpad.net/bugs/1613374 - Assigned to Chris Sharp (chrissharp123)
12:33 miker berick: I'm a little dubious about backporting bug 1570909 ...
12:33 pinesol_green Launchpad bug 1570909 in Evergreen 2.9 "User activity tracking should be transient by default" [Undecided,New] https://launchpad.net/bugs/1570909
12:33 rlefaive joined #evergreen
12:34 berick miker: I'm on the fence, myself.  in theory it has no direct affect w/o manual intervention, but that kind of lessens the need to backport to begin with.
12:34 berick if it's questionable, don't backport, I say
12:36 miker ok, thanks.  I'm calling it a feature for backporting purposes, then :)
12:38 miker grabbing 0993
12:42 csharp miker: if my branch for bug 1612752 gets accepted, it would theoretically be possible to "unwrap" the status on canceled transit checkin too, right?
12:42 pinesol_green Launchpad bug 1612752 in Evergreen "Feature Request: Cancel Transits, Don't Delete Them" [Wishlist,Confirmed] https://launchpad.net/bugs/1612752 - Assigned to Chris Sharp (chrissharp123)
12:42 pinesol_green [evergreen|Bill Erickson] LP#1570909 User activity transient default - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b1f4d59>
12:42 pinesol_green [evergreen|Bill Erickson] LP#1570909 User activity purge function - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=ea8b2ae>
12:42 pinesol_green [evergreen|Bill Erickson] LP#1570909 User activity purge pgtap test - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fc5b3ec>
12:42 pinesol_green [evergreen|Bill Erickson] LP#1570909 User activity purge release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=cfad22b>
12:42 pinesol_green [evergreen|Mike Rylander] Stamping upgrade script for transient usr_activity - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=95ea3d5>
12:43 miker csharp: not sure I follow.  If an item got into Canceled Transit, and then transited (was scanned somewhere) the transit home would carry the Canceled Transit status and the copy would end up with that until a user did something about that ... is that what you mean?
12:44 miker (that's the case regardless of whether we restrict the situations we make use of Canceled Transit, though)
12:45 miker ah, you mean "the data still exists because it's on a closed transit"
12:46 miker well, your code doesn't make that happen, though, does it? (not seeing it in a quick scan if so)
12:54 pinesol_green [evergreen|Galen Charlton] LP#1205492: fix crash when attempting to renew deposit & rental loans in OPAC - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=92deb9c>
12:54 miker grabbing 0994
12:58 csharp miker: right - the data still exists - and no, my branch doesn't do that
12:59 yboston joined #evergreen
12:59 csharp I was trying to keep the features separate in case one didn't get accepted, the other still had a chance
12:59 bmills joined #evergreen
13:00 miker I'm concerned that we'd be trading confusion for (effectively, to the user) lost data, unless we have something that pulls the old status from the canceled transit and uses that for any /new/ transit. which, I think, would fix the issue for remote aborts that re-transit.
13:00 pinesol_green Showing latest 5 of 6 commits to Evergreen...
13:00 pinesol_green [evergreen|Bill Erickson] LP#1588948 Authority propagation PGTAP test - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=7605ed8>
13:00 pinesol_green [evergreen|Bill Erickson] LP#1588948 Release notes (auth prop. bib edit[or|_date]) - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=8e95974>
13:00 pinesol_green [evergreen|Bill Erickson] LP#1588948 Auth propagate bib meta on change only - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=d61a652>
13:00 pinesol_green [evergreen|Mike Rylander] LP#1588948: Only attempt a bib update if the heading changes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=84bed71>
13:00 pinesol_green [evergreen|Mike Rylander] Stamping upgrade script for authority edit changes and propagation improvement - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=1215938>
13:07 serflog joined #evergreen
13:07 Topic for #evergreen is now Welcome to the #evergreen library system channel! | We are publicly logged: http://irc.evergreen-ils.org/evergreen | Large pastes at http://paste.evergreen-ils.org
13:08 jyorio joined #evergreen
13:09 tarac_ joined #evergreen
13:34 berick kmlussier: thanks for testing bug #1497335.  investingating now...
13:34 pinesol_green Launchpad bug 1497335 in Evergreen "Display aged circulations for copies (was: "virtually aged circulations")" [Wishlist,New] https://launchpad.net/bugs/1497335
13:35 * berick will also rebase
13:36 kmlussier berick: Thanks!
13:36 kmlussier Unfortunately, I can't test it in the web client at the moment.
13:37 csharp miker: I'm looking to change my canceled transit status branch (bug 1613374) so that it checks the stored copy status... how much time do I have before you call the beta done? :-)
13:37 pinesol_green Launchpad bug 1613374 in Evergreen "Feature Request: "Canceled Transit" Item Status" [Wishlist,Confirmed] https://launchpad.net/bugs/1613374 - Assigned to Chris Sharp (chrissharp123)
13:39 miker csharp: commit by EOB today, or whenever level3 decides to stop having problems, whichever comes later ;)
13:39 csharp ok :-)
13:39 miker csharp: are you also rebasing to master?
13:40 csharp I have been, yes, and I will do before it's done
13:40 berick is level3 why git.evergreen-ils.org is not responding?
13:40 csharp er...
13:41 csharp berick: I'm able to get to git.evergreen-ils.org fine, but I suspect regional net issues since I just got a call from a library about it
13:41 berick csharp: gotcha, thanks for checking
13:41 csharp (well, about not being able to get to gapines.org)
13:41 graced https://www.product-reviews.net/do​wn/level3-internet-outage-status/
13:42 csharp ah
13:42 * csharp didn't know what level3 was :-)
13:43 graced http://downdetector.com/status/level3/map/
13:43 graced the map is ugly.
13:44 * graced didn't know what Level 3 was until about 20 minutes ago...
13:48 kmlussier I didn't know what it was until 5 minutes ago. :)
13:50 gmcharlt yay! that means that us network admin types are now sharing the sufferring^W knowledge more widely!
13:51 graced thanks?
13:51 gmcharlt any time! :D
13:52 berick yay, git's back
13:53 ericar_ joined #evergreen
13:55 * csharp just got a notification from QTS that they are having connectivity problems too
13:59 jonadab Oh, wow, you don't often see a network provider as important as level3 go down.
14:04 tarac_ joined #evergreen
14:28 kmlussier I'm going through committed bugs to check for missing release notes. Should bug 1496556 also be backported to 2.10 and 2.9? It looks more like a bug fix than new feature.
14:28 pinesol_green Launchpad bug 1496556 in Evergreen "Claimed never checked out count not increased when applied to LOST circulation" [Undecided,Fix committed] https://launchpad.net/bugs/1496556
14:37 sandbergja Is there a postgres function that can merge copies on different volumes onto the same volume?  Sorta like asset.merge_record_assets(), but for merging volumes rather than bibs? I didn't see anything in the 2.9 schema, but I'm new to these functions. :-)
14:38 Stompro sandbergja, I have a function to merge volume's together... do you need to specify specific copies, or would all copies work?
14:39 sandbergja all copies would work!  As long as they are only connected to those two volumes
14:39 sandbergja Stompro++
14:41 Stompro sandbergja, let me see if I can find it.  I've been using it to clean up magazine records where front line staff add the copies, they sometimes forget to name the volume corretly, or create a second volume.
14:44 Stompro sandbergja, found it, but it is only for moving to a volume on the same bibliographic record, so it is really only for where a owning location has added multiple volumes by mistake.
14:45 sandbergja actually, that's our situation.  We have several bibs that have two redundant volumes attached -- typically one with a space in the label and one without.  We'd like all the copies to be on the same volume, with the space in the call_number.label
14:46 sandbergja would your function work for that?
14:49 csharp eww - something got busted in master
14:49 csharp eg_db_config is blowing up
14:50 Stompro sandbergja, Yes, that is exactly what it is for.
14:50 Stompro sandbergja, https://gist.github.com/stompro/​edf9ec85eacf2f1a2483f5c06f1fd422
14:50 csharp psql:002.schema.config.sql:1032: ERROR:  schema "actor" does not exist
14:50 sandbergja This is fabulous!  Thank you so much!
14:50 miker it sure doesn't in 002...
14:51 miker csharp: ah... I'll move that. berick's purge function, should be elsewhere
14:51 csharp miker: thanks - was just gonna investigate
14:52 berick thanks for fixin'
14:53 miker csharp: fix pushed
14:53 Stompro sandbergja, You are welcome.  Let me know if you have any problems with it.  You need the asset.call_number.id and the new label name as arguments.
14:55 csharp miker: ah... that's better
14:55 miker grabbing 0995
14:56 csharp okay, I've pushed a commit on top of my fix for bug 1613374 and I want to test it with mmorgan's testing method before calling it done, but I'm letting others know in case they want to look/test after me
14:56 pinesol_green Launchpad bug 1613374 in Evergreen "Feature Request: "Canceled Transit" Item Status" [Wishlist,Confirmed] https://launchpad.net/bugs/1613374 - Assigned to Chris Sharp (chrissharp123)
14:57 pinesol_green [evergreen|Mike Rylander] Moving function creation to later in the schema def, where its deps exist. - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=9fc0603>
14:57 pinesol_green [evergreen|Kathy Lussier] LP#1614290: Add badge_score_generator to example crontab - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fd725a7>
14:57 csharp basically, I check the stored statuses to make sure they aren't "special" then marked the copy "Canceled Transit" if they pass
14:57 csharp gonna head home now and log back in from there
14:59 pinesol_green [evergreen|Kathy Lussier] LP#1614237: Popularity badge seed data - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=6d176fe>
14:59 pinesol_green [evergreen|Mike Rylander] Stamping upgrade script for badge seed data - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=7bdfe9f>
15:09 jeff is it too early for bugfixes for features merged today? ;-)
15:13 kmlussier berick: Added some feedback to your question here https://bugs.launchpad.net/ever​green/+bug/1497335/comments/17
15:13 pinesol_green Launchpad bug 1497335 in Evergreen "Display aged circulations for copies (was: "virtually aged circulations")" [Wishlist,New]
15:15 miker jeff: never too early for bug fixes. what's up
15:16 ericar joined #evergreen
15:20 berick kmlussier++
15:21 mmorgan1 joined #evergreen
15:31 pinesol_green [evergreen|Ben Shum] LP#1603708: Remove support for Ubuntu 12.04 Precise - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=be0ed35>
15:58 kmlussier joined #evergreen
16:04 * kmlussier needs to leave and won't be able to test https://bugs.launchpad.net/evergreen/+bug/1497335/ again if berick is able to incorporate the changes he made in his last comment. If anyone else has tuits to look at it, feel free!
16:04 pinesol_green Launchpad bug 1497335 in Evergreen "Display aged circulations for copies (was: "virtually aged circulations")" [Wishlist,New]
16:06 csharp miker: bug 1613374 looks good to me after some poking
16:06 pinesol_green Launchpad bug 1613374 in Evergreen "Feature Request: "Canceled Transit" Item Status" [Wishlist,Confirmed] https://launchpad.net/bugs/1613374 - Assigned to Chris Sharp (chrissharp123)
16:07 Dyrcona joined #evergreen
16:11 csharp unfortunately, my solution adds to the problems I reported in bug 1616170 but that's for another day
16:11 pinesol_green Launchpad bug 1616170 in Evergreen "Not possible to create copy status without manual code changes" [Medium,New] https://launchpad.net/bugs/1616170
16:33 mmorgan joined #evergreen
17:08 mmorgan left #evergreen
18:01 miker grabbing 0996
18:05 pinesol_green Showing latest 5 of 11 commits to Evergreen...
18:05 pinesol_green [evergreen|Mike Rylander] LP#1356477: add quick receipt button - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f8422d9>
18:05 pinesol_green [evergreen|Galen Charlton] LP#1356477: move email receipt checkbox on patron editor - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=4d512bf>
18:05 pinesol_green [evergreen|Mike Rylander] LP#1356477: update selfcheck interface - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=92f1bdb>
18:05 pinesol_green [evergreen|Galen Charlton] LP#1356477: release notes for email checkout receipts - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=33746b3>
18:05 pinesol_green [evergreen|Mike Rylander] Stamping upgrade for email receipts - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c820aa4>
18:07 miker csharp: I'm going to merge 1613374, but will you please create some release notes for that soon?  TIA
18:07 miker grabbing 0997
18:09 pinesol_green Showing latest 5 of 6 commits to Evergreen...
18:09 pinesol_green [evergreen|Chris Sharp] LP#1613374 - Make 'Canceled Transit' status holdable and OPAC-visible. - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fcc46cc>
18:09 pinesol_green [evergreen|Chris Sharp] LP#1613374 - Add 'Canceled Transit' to "magical statuses" - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=49ea249>
18:09 pinesol_green [evergreen|Chris Sharp] LP#1613374 - Add 'Canceled Transit' to non-'BAD' copy statuses. - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=58cd99e>
18:09 pinesol_green [evergreen|Chris Sharp] LP#1613374 - Check stored copy status before clobbering it. - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a5f6a48>
18:09 pinesol_green [evergreen|Mike Rylander] Stamping upgrade script for Canceled Transit status branch - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=8decad6>
18:30 miker grabbing 0998
18:31 miker looks like we won't make it to script number 8 this release ...
18:32 * miker groans at own binary joke
18:35 pinesol_green Showing latest 5 of 6 commits to Evergreen...
18:35 pinesol_green [evergreen|Bill Erickson] LP#1497335 Browser client item details aged circs - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=11d7f22>
18:35 pinesol_green [evergreen|Bill Erickson] LP#1497335 Item details shows aged circs (XUL edition) - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b9e5c62>
18:35 pinesol_green [evergreen|Bill Erickson] LP#1497335 Aged circ display release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=5769707>
18:35 pinesol_green [evergreen|Bill Erickson] LP#1497335 Show Last Few Circs patron retrieve options - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3f2d3a0>
18:35 pinesol_green [evergreen|Mike Rylander] Stamping upgrade scripts for aged circs display branch - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=15ad6d4>
18:42 miker and ... that's it, folks.  I think I've merged anything that was ready to be merged and was a feature.  the remainder are bug fixes, or are in some way not complete or well tested enough (given their relative invasiveness).  Now, on to bug fix merging (not today)!
18:42 * miker calls beta locked for features
18:44 Dyrcona joined #evergreen
19:05 gsams joined #evergreen
19:06 Dyrcona miker: If you're still around, what do you think of bug 1583608?
19:06 pinesol_green Launchpad bug 1583608 in Evergreen 2.9 "The make_release script should always create a DB upgrade script." [Undecided,Confirmed] https://launchpad.net/bugs/1583608
19:28 kmlussier joined #evergreen
19:28 miker Dyrcona: I think it's a bug fix... haven't looked at the code in a long time
19:28 miker also
19:28 miker Dyrcona++ # backport
19:29 kmlussier miker: I have some release notes additions I should be finishing up in the next 30 minutes. Should I hold off on merging?
19:29 Dyrcona I'm looking at kmlussier's responsive fixes. At least 1 commit doesn't cherry-pick cleanly into 2.9, so I might skip the whole thing.
19:30 Dyrcona miker: I was just wondering if you'd like that release script changes for 2.11-beta. I had a release of 2.9 where it would have helped.
19:30 dbwells kmlussier: miker: if the question pertains to building of the beta, it isn't going to happen until tomorrow at this point :)
19:31 kmlussier dbwells: OK, thanks! Yes, I do think it pertains to building of beta.
19:31 miker Dyrcona: I'm on my phone, but please push the release script fix if you're in a position to. I looked and it's +1 from me
19:31 miker kmlussier: push at will
19:31 dbwells kmlussier: cool, I say merge away
19:31 Dyrcona OK. Will do.
19:32 miker docs and bug fixes are still fair game
19:32 Dyrcona I'll wait for the release notes. I'm still looking at the responsive changes to decide if any of the commits could/should be backported to 2.9.
19:32 kmlussier miker++ #Merging all the new things dbwells++ #Early karma for tomorrow's build
19:39 Dyrcona Well, unfortunately, 2.9 won't get the responsive fixes. Only 1 commit cherry-picks cleanly, and I don't have the zots to resolve any conflicts.
19:39 Dyrcona Thanks for the branch, kmlussier++
19:40 kmlussier Dyrcona: Yeah, I was going to offer to look at them, but I don't think I can get to it at the moment.
19:40 * kmlussier made some promises about going out for ice cream.
19:40 Dyrcona That's OK. Ice cream is definitely the better choice. :)
19:41 Dyrcona At this point, people should be getting ready to upgrade away from 2.9.
19:41 Dyrcona I'll see if the branch on bug 1496556 backports cleanly to 2.9.
19:41 pinesol_green Launchpad bug 1496556 in Evergreen 2.9 "Claimed never checked out count not increased when applied to LOST circulation" [Undecided,New] https://launchpad.net/bugs/1496556
19:42 kmlussier Dyrcona++
19:42 Dyrcona If it does, I'll recommend backporting, but won't backport unless gmcharlt also wants a backport to 2.10.
19:47 kmlussier OK, release notes additions merged. I'll do a more thorough check when I get back next week.
19:47 * kmlussier disappears for ice cream.
19:50 pinesol_green [evergreen|Kathy Lussier] Docs: Some missing release notes for 2.11 - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b2af487>
19:58 pinesol_green [evergreen|Jason Stephenson] LP 1583608: The make_release script always makes a db upgrade script. - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=edb3958>
20:02 Dyrcona miker++ # For all the merging today.
21:41 csharp miker: I'll tackle release notes tomorrow - thanks
22:27 Christineb joined #evergreen
22:58 dcook joined #evergreen

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat