| Time |
Nick |
Message |
| 01:27 |
|
mrpeters joined #evergreen |
| 02:24 |
|
Mark__T joined #evergreen |
| 02:38 |
|
mrpeters joined #evergreen |
| 04:33 |
|
mrpeters joined #evergreen |
| 05:08 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 06:05 |
|
sbrylander joined #evergreen |
| 06:07 |
|
pmurray_away joined #evergreen |
| 07:11 |
|
sarabee joined #evergreen |
| 07:21 |
|
mrpeters joined #evergreen |
| 07:36 |
miker |
bshum: re later from last night, I'll respond to your comment when I get to a real computer, but tldr is "no, there are no concerns about 9.2+, and yes imo it should be pushed". I was hoping csharp would test as the reporter, but such is life and bugs |
| 07:45 |
|
rjackson_isl joined #evergreen |
| 07:47 |
|
jboyer-isl joined #evergreen |
| 08:02 |
|
ericar joined #evergreen |
| 08:04 |
|
akilsdonk joined #evergreen |
| 08:16 |
|
_bott_ joined #evergreen |
| 08:34 |
|
mmorgan joined #evergreen |
| 08:36 |
Stompro |
bshum++ |
| 08:43 |
|
collum joined #evergreen |
| 08:45 |
|
Shae joined #evergreen |
| 08:51 |
|
yboston joined #evergreen |
| 08:56 |
|
Dyrcona joined #evergreen |
| 08:58 |
|
ericar_ joined #evergreen |
| 09:05 |
dbwells |
bshum: thanks for testing. I am guessing you didn't grab enough commits from that branch. There are four by remingtron, but they are proceeded by two of mine, and those have the function you seek. |
| 09:08 |
Dyrcona |
FYI, I usually do a git merge into a development branch when testing. |
| 09:08 |
Dyrcona |
That way you don't miss commits. |
| 09:09 |
Dyrcona |
And, you can can always use https://gist.github.com/Dyrcona/4629200 |
| 09:10 |
Dyrcona |
Just don't use the latter if cherry-picking into a rel_* branch, it'll end up moving over most of master, too. |
| 09:10 |
Dyrcona |
Don't merge into a rel_* branch either. |
| 09:11 |
Dyrcona |
Hmm. Maybe quickpick could use an option to not do anything but show the commits that would be picked? |
| 09:19 |
|
maryj joined #evergreen |
| 09:25 |
Dyrcona |
bshum++ # The hardest workin' person in Evergreen! ;) |
| 09:41 |
dbwells |
Live Dyrcona: a man, a plan, a canal, Panama, a no-cry devil... sorry, it's the best I could do ;) |
| 09:41 |
Dyrcona |
heh |
| 09:42 |
|
Khanson_ joined #evergreen |
| 09:44 |
Dyrcona |
So, the beta is when the rel_2_X branch gets made, correct? |
| 09:53 |
dbwells |
I think I waited until RC, with the goal of minimizing hassle while focusing on bug fixes, but either way makes sense. In reality, master isn't likely to drift far very fast, so the hassle is really minimal. |
| 09:54 |
mrpeters |
from a personal standpoint, the branch would be nice to have at beta time, as we use it to test our debs |
| 09:54 |
mrpeters |
but, if a tarball is available, that is sufficient too |
| 09:55 |
dbwells |
It would get a "tag" branch in any case, I would think. |
| 10:00 |
|
pmurray joined #evergreen |
| 10:04 |
|
Khanson_ joined #evergreen |
| 10:05 |
berick |
bshum++ # indeed |
| 10:05 |
|
pmurray left #evergreen |
| 10:08 |
jeff |
sure, perfect morning for my browser to decide to start fresh all on its own. |
| 10:08 |
jeff |
oh, better. |
| 10:09 |
* Dyrcona |
wishes he had setup a dev database reload for last night, so he doesn't have to wait for one today. |
| 10:10 |
Dyrcona |
On the branches, I was considering rel_2_9 and rel_2_9_beta |
| 10:10 |
|
RoganH joined #evergreen |
| 10:10 |
Dyrcona |
well, tag/rel_2_9_beta |
| 10:11 |
Dyrcona |
tags, even |
| 10:11 |
* Guest34760 |
reads up after 2 1/2 work days off |
| 10:11 |
jeff |
welcome back, Guest34760! |
| 10:11 |
Dyrcona |
heh |
| 10:12 |
|
csharp joined #evergreen |
| 10:13 |
jeff |
oh neat. chance of 40-60 MPH winds this afternoon. |
| 10:13 |
Dyrcona |
jeff: Are you looking at bshum's branch on lp 1312309 ? |
| 10:13 |
pinesol_green |
Launchpad bug 1312309 in Evergreen "to remove last remnants of JSPAC" (affected: 3, heat: 14) [Wishlist,Confirmed] https://launchpad.net/bugs/1312309 - Assigned to Jeff Godin (jgodin) |
| 10:13 |
jeff |
yup. |
| 10:13 |
csharp |
wow - you're gone a few days and freenode just forgets you! |
| 10:13 |
* csharp |
weeps |
| 10:13 |
Dyrcona |
I have an idea for resolving the makefile.am issue with existing installs. |
| 10:14 |
jeff |
hi, csharp! welcome to #evergreen! |
| 10:14 |
jeff |
Dyrcona: i think my original plan was to rip more out -- what did you have in mind? |
| 10:14 |
csharp |
jeff: :-D |
| 10:15 |
Dyrcona |
bshum removed code from Makefile.am that cleans out existing files because it breaks with fresh installs after the branch is applied. |
| 10:15 |
Dyrcona |
I think we should put those lines back, but add if [ -d .... ] and if [ -f .... ] around the shell code. |
| 10:16 |
Dyrcona |
Or just throw the tests on the line with && in appropriate places. |
| 10:16 |
csharp |
miker: bshum: I'll give bug 1438136 a final poke and will comment on it and/or signoff - sorry for the delay :-/ (yep, life getting in the way) |
| 10:16 |
pinesol_green |
Launchpad bug 1438136 in Evergreen 2.8 "OPAC searching significantly slowed by adding format filters" (affected: 4, heat: 20) [High,Triaged] https://launchpad.net/bugs/1438136 |
| 10:16 |
Dyrcona |
But, maybe, instead of what it does, it should rm existing files for upgrades. |
| 10:17 |
Dyrcona |
I was going to play with it, but realize that may be too much for a couple of hours of poking. |
| 10:18 |
jeff |
Dyrcona: i had been leaning away from removing anything that had been previously installed. |
| 10:19 |
Dyrcona |
jeff: Ok. That is the safer move. |
| 10:19 |
jeff |
It would be difficult to avoid removing files that may have been used locally, for example -- images that someone used in a local template, etc. Maybe that's too corner case? I was hoping to avoid violating least surprise. |
| 10:20 |
Dyrcona |
I'll leave it in your hands and I'll have a look at lp 1485794 |
| 10:20 |
pinesol_green |
Launchpad bug 1485794 in Evergreen "integrate web staff client sprint 2 into the 2.9 beta" (affected: 1, heat: 8) [Wishlist,New] https://launchpad.net/bugs/1485794 - Assigned to Jason Stephenson (jstephenson) |
| 10:20 |
berick |
+1 to leaving files in place in existing insatlls |
| 10:20 |
jeff |
browser has decided that my history and bookmarks are back, but now has cookie amnesia. bah. |
| 10:20 |
Dyrcona |
yep, +1 from me, too. |
| 10:20 |
jeff |
invonvenient, but not a disaster. :P |
| 10:20 |
Dyrcona |
jeff: could be hd trouble. |
| 10:21 |
Dyrcona |
or ssd trouble, depending.... ;) |
| 10:21 |
|
ericar_ joined #evergreen |
| 10:21 |
* berick |
likes jeff's new word invonvenient |
| 10:21 |
jeff |
berick: it almost suggests its own accent. |
| 10:21 |
Dyrcona |
it does. een-vonn-veeenee-ent. |
| 10:22 |
|
akilsdonk joined #evergreen |
| 10:22 |
jeff |
actually, i suspect full disk confused firefox. we'll hope it's that and not a failing ssd. |
| 10:22 |
jeff |
that would be Very Invonvenient. |
| 10:23 |
|
TaraC joined #evergreen |
| 10:24 |
miker |
csharp: life's always doing that ;) |
| 10:25 |
pinesol_green |
[evergreen|Matt Berowski] Documentation typo fixes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=df265a5> |
| 10:25 |
|
rlefaive joined #evergreen |
| 10:26 |
|
berowskim joined #evergreen |
| 10:26 |
Stompro |
berowskim++ first doc commit! |
| 10:26 |
yboston |
berowskim++ |
| 10:29 |
Dyrcona |
berowskim++ |
| 10:30 |
csharp |
berowskim++ |
| 10:32 |
Dyrcona |
Don't be surprised if later I say, "Grabbing XXXX-YYYY." ;) |
| 10:32 |
berick |
Dyrcona: i'll probably wait until you're about to do your release cutting before I work on 2.8, since that will be my clue that merging has settled down. minder hollering at me when you're at that point? |
| 10:33 |
Dyrcona |
berick: Sure thing. I'll probably be asking for help by that point. :) |
| 10:33 |
berick |
k, no problem. and I'm not in any rush, so do your thing :) |
| 10:38 |
|
RoganH joined #evergreen |
| 10:39 |
bshum |
dbwells: I could have sworn I did a merge/rebase when I tested, but you must be right. |
| 10:39 |
bshum |
dbwells: I'll see if I can rectify all that once I get to the office.. |
| 10:39 |
dbwells |
bshum: thanks! |
| 10:40 |
bshum |
No thank you! dbwells++ |
| 10:40 |
Dyrcona |
I'd /like/ to have the tarball on the website by 16:00 EDT. |
| 10:40 |
bshum |
This is what happens when I test at the 11th hour. |
| 10:43 |
kmlussier |
16:00? So how long does that give us to do any last-minute sign-offs? |
| 10:43 |
bshum |
Heh |
| 10:44 |
* bshum |
salutes Dyrcona, "Yes sir!" |
| 10:45 |
Dyrcona |
kmlussier that is 4:00 pm, I'd like everything in there by maybe 2:00 pm at the latest. |
| 10:46 |
kmlussier |
Yes, I got the 4 p.m. bit. ;) |
| 10:46 |
Dyrcona |
I thought so. ;) |
| 10:47 |
Dyrcona |
The i18n dance takes a while. Though I don't know how long. I haven't done it since December or so. |
| 10:47 |
berick |
about 10 minutes, IIRC |
| 10:47 |
* kmlussier |
wonders what the likelihood is of getting bug 1479107 resolved in time for beta. |
| 10:47 |
pinesol_green |
Launchpad bug 1479107 in Evergreen "Replace manual void option with an "adjust to zero" option" (affected: 1, heat: 6) [Medium,New] https://launchpad.net/bugs/1479107 - Assigned to Dan Wells (dbw2) |
| 10:47 |
bshum |
Agreed, maybe no more than 15-20 tops. |
| 10:48 |
Dyrcona |
About 0, I think, but I'm making an exception for that as I consider it part of a feature that is already in. |
| 10:48 |
Dyrcona |
I think I'll note that on the bug, actually. |
| 10:48 |
kmlussier |
OK, then, I think I'll update the release notes to reflect what is there now. |
| 10:49 |
dbwells |
kmlussier: I guess I am more optimistic than Dyrcona, but I don't know how much chance it really has. Testing the code internally now... |
| 10:49 |
kmlussier |
I can always update it when bug 1479107 is done. |
| 10:49 |
pinesol_green |
Launchpad bug 1479107 in Evergreen "Replace manual void option with an "adjust to zero" option" (affected: 1, heat: 6) [Medium,New] https://launchpad.net/bugs/1479107 - Assigned to Dan Wells (dbw2) |
| 10:49 |
kmlussier |
dbwells: I'm on hand to drop everything else to test it when it's ready. :) |
| 10:49 |
Dyrcona |
dbwells: Oh. I don't know how far along you were. |
| 10:49 |
Dyrcona |
s/don't/didn't/ |
| 10:50 |
kmlussier |
Also, the other remaining piece of the negative balance puzzle was bug 1479107 . Just an update to the description for an OU setting if anyone wants to take a look at it. |
| 10:50 |
Dyrcona |
I can test it, too. I'm still waiting on a db reload to finish, so I can add it to my branch with sprint2. |
| 10:50 |
kmlussier |
Wrong bug number apparently |
| 10:50 |
kmlussier |
bug 1479110 |
| 10:50 |
pinesol_green |
Launchpad bug 1479110 in Evergreen "Negative balance settings used in combination with one another should interact differently" (affected: 1, heat: 6) [Medium,New] https://launchpad.net/bugs/1479110 |
| 10:50 |
kmlussier |
How do I copy and paste a bug number incorrectly? |
| 10:51 |
jeff |
then when the beta's out, we can REALLY find the bugs. ;-) |
| 10:52 |
jboyer-isl |
I’d also like to stump for bug 1371647 real quick, it’s just a seed data bump (and full tests therefore, Dyrcona changed my mind about that) but not being a bugfix if it’s not in today, it’s 2.9.1 :( |
| 10:52 |
pinesol_green |
Launchpad bug 1371647 in Evergreen "config.marc21_ff_pos_map needs an audit" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1371647 |
| 10:52 |
Dyrcona |
kmlussier: Good typo, though, I've been meaning to look at that one, too. |
| 10:53 |
dbwells |
I guess I'll join the party. If anybody has any extra review eyes, I'd be very happy to see bug 1422379 get in. I have some good display improvements which depend on it, and I feel that biting the bullet it better than stringing it along. |
| 10:53 |
pinesol_green |
Launchpad bug 1422379 in Evergreen "Move money.billing timestamps back to moment of fine" (affected: 1, heat: 6) [Wishlist,Triaged] https://launchpad.net/bugs/1422379 |
| 10:55 |
jeff |
dbwells: would the improvements be dampened if the upgrade script doesn't touch ALL billings? i.e., if it were to opt not to change the date on billings on transactions that were closed, or had payments? |
| 10:55 |
jeff |
dbwells: are there interactions with conditional negative billing? |
| 10:55 |
jeff |
dbwells: should we throw it in the beta so it's in there, THEN test the heck out of it? ;-) |
| 10:56 |
dbwells |
jeff: The only billings it /has/ to change are the open ones, i.e. ones which might accrue more overdue files. Otherwise, there will be a ripple in the fine stream. |
| 10:56 |
dbwells |
s/files/fines |
| 10:57 |
kmlussier |
Can I also make a pitch to core committers to review bugs that already have a signedoff tag? http://bit.ly/1E3DGNg |
| 10:58 |
jeff |
dbwells: and that would include open xacts with payments. hrm. |
| 10:58 |
Dyrcona |
jboyer-isl: I commented on lp 1371647 |
| 10:58 |
pinesol_green |
Launchpad bug 1371647 in Evergreen "config.marc21_ff_pos_map needs an audit" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1371647 |
| 10:59 |
|
jwoodard joined #evergreen |
| 10:59 |
dbwells |
jeff: of course, then you have lost things which might "reopen" if returned. And general confusion. I know the solution isn't beautiful, but we also shouldn't go on forever the way we are. For what it's worth, we ran that upgrade script locally 6 months ago, and no problems reported. We're all in :) |
| 10:59 |
* jeff |
nods |
| 11:00 |
jboyer-isl |
Dyrcona: Ah, I did forget about the actual reingest notice, I did intend to do that properly, heh. |
| 11:01 |
jboyer-isl |
As for the milestone, I can’t change that (unless there’s a tag those of us without powers are using?) |
| 11:01 |
* bshum |
thinks jboyer-isl should have powers. |
| 11:02 |
jboyer-isl |
Launchpad respectfully disagrees. (unless the UI is inscrutable, which is always possible...) |
| 11:03 |
bshum |
jboyer-isl: Refresh, you may see new powers you have inherited :) |
| 11:05 |
jboyer-isl |
I AM LIKE UNTO A … Milestone maker. Was getting a big head there for a minute. |
| 11:05 |
jboyer-isl |
bshum++ |
| 11:05 |
Dyrcona |
:) |
| 11:05 |
bshum |
jboyer-isl++ # welcome to the party |
| 11:06 |
bshum |
jboyer-isl: Next conference we can toast to a nice bourbon or something ;) |
| 11:06 |
Dyrcona |
too...many...launchpad...tabs open....can't tell...which one...I want. |
| 11:06 |
jboyer-isl |
bshum: You’re on! |
| 11:07 |
jboyer-isl |
Dyrcona: I keep an entire FF window of just LP bugs of interest at work. It is very haystack like. |
| 11:08 |
Dyrcona |
bshum: Did you once tell me that you wished people would target bugs to milestones more often? If you did, I agree with you. |
| 11:08 |
bshum |
Dyrcona: Yep! |
| 11:08 |
bshum |
It's hard to do though |
| 11:09 |
bshum |
Not everybody can do it unless they're drivers |
| 11:09 |
Dyrcona |
yeah. |
| 11:09 |
bshum |
But those of us who are... for SHAME! |
| 11:09 |
Dyrcona |
And that may give them more power than we want to give them. |
| 11:10 |
Dyrcona |
We should have a bug wrangling days every couple of months. |
| 11:14 |
bshum |
Indeed. |
| 11:17 |
pinesol_green |
[evergreen|Jason Boyer] LP 1437292: Order Bucket Names Alphabetically - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e4a3fd1> |
| 11:17 |
kmlussier |
Dyrcona: If a bug is targeted towards 2.next, should it be moved to 2.9beta if we want to see it in by the end of the day? |
| 11:18 |
* kmlussier |
tries to target bugs to milestones, but also quite often forgets. |
| 11:18 |
Dyrcona |
kmlussier: Yes, unless it brought to someone's attention specifically. |
| 11:19 |
Dyrcona |
Just targeting them won't guarantee that they get in, though. |
| 11:19 |
Dyrcona |
Someone has to take the time to look at them and push them. |
| 11:22 |
berick |
bshum: if you have a spare minute, the code for bug 1476370 included an accidental copy/paste, duplicating a chunk of the template. it doesn't break anything, but it's confusing to have it there. i've pushed a fix http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1476370-selfcheck-auth-warning-cleanup |
| 11:22 |
pinesol_green |
Launchpad bug 1476370 in Evergreen "Selfcheck warn on patron auto-logout, reset activity timer on checkout" (affected: 3, heat: 14) [Wishlist,Fix committed] https://launchpad.net/bugs/1476370 |
| 11:23 |
bshum |
berick: Ah, okay, I'll do a quick sign and push on that in two seconds. |
| 11:23 |
berick |
bshum++ thanks |
| 11:23 |
* berick |
hates making messes |
| 11:23 |
bshum |
Just getting tsbere's fix for amnesty/backdating in first |
| 11:25 |
Dyrcona |
To any of the core committers: Feel free to push anything from test writing day that hasn't gone in, yet. If tests break, we can fix them after. :) |
| 11:25 |
pinesol_green |
[evergreen|Thomas Berezansky] LP#1444514: Have amnesty mode override backdate for voiding - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=dcdce01> |
| 11:26 |
bshum |
berick: Pushed, thanks |
| 11:26 |
bshum |
berick++ |
| 11:26 |
jeff |
Dyrcona: are you saying those need to go in before beta, otherwise wait until next? |
| 11:26 |
Dyrcona |
No, I'm not saying that. I suppose that they could go in at any time, really. |
| 11:27 |
pinesol_green |
[evergreen|Bill Erickson] LP#1476370 Selfcheck warning template cleanup - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8e0fdc5> |
| 11:28 |
Dyrcona |
I s'pose I'm giving a temporary dispensation to not test the tests for the beta. :) |
| 11:28 |
jeff |
hah |
| 11:28 |
jeff |
okay, noted. :-) |
| 11:29 |
berick |
thanks bshum |
| 11:31 |
jeff |
memecached |
| 11:32 |
Dyrcona |
memecached -> buzzfeed? |
| 11:34 |
berick |
heh |
| 11:35 |
jboyer-isl |
Seems awfully hard on poor old memcached. ;) |
| 11:35 |
Dyrcona |
"You have assigned this bug to yourself for Evergreen" |
| 11:39 |
jeff |
"Please do not forget about it." |
| 11:43 |
|
Christineb joined #evergreen |
| 11:45 |
* csharp |
signs off on bug 1438136 |
| 11:45 |
pinesol_green |
Launchpad bug 1438136 in Evergreen 2.8 "OPAC searching significantly slowed by adding format filters" (affected: 4, heat: 20) [High,Triaged] https://launchpad.net/bugs/1438136 |
| 11:45 |
csharp |
miker++ # thanks for the work on it and sorry for my slow signoff ;-) |
| 11:47 |
pinesol_green |
[evergreen|Adam Bowling] LP#1406370 Set Search Preferences Ordered by Name - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9e946f5> |
| 11:52 |
|
bmills joined #evergreen |
| 11:57 |
kmlussier |
miker: Are you around to answer a question about bug 1367926 ? |
| 11:57 |
pinesol_green |
Launchpad bug 1367926 in Evergreen "Add support for (nearly) direct access to the full unapi backend" (affected: 2, heat: 10) [Wishlist,New] https://launchpad.net/bugs/1367926 - Assigned to Kathy Lussier (klussier) |
| 12:00 |
miker |
kmlussier: for a minute, aye. shoot |
| 12:01 |
kmlussier |
I've loaded it on a test vm again. marcxml looks fine, but I still get errors when trying http://mlnc2.mvlcstaff.org/opac/extras/unapi?id=tag::U2@bre/165&format=mods32 in a browser. |
| 12:01 |
kmlussier |
I see your discussion with Stompro. I'm just wondering if that points to a problem or if it's okay because whatever is accessing that data won't be doing it from a browser. |
| 12:02 |
miker |
kmlussier: right. it's perfectly valid xml .. I don't know what firefox's complaint is about |
| 12:02 |
kmlussier |
miker: I get complains from Chrome too. |
| 12:03 |
kmlussier |
miker: Also, for now, it just supports marcxml and mods32, right? |
| 12:03 |
miker |
for some things, yes |
| 12:04 |
miker |
well, that's not true |
| 12:04 |
miker |
for bre, any registered format should work |
| 12:04 |
miker |
registered in config.xml_transform |
| 12:05 |
miker |
xmllint is complaining about the characters in your link above. the record looks to be latin-1 encoded |
| 12:05 |
jeff |
fwiw, I think i've been seeing issues with encoding of é and friends by mods32 but not marcxml as far back as 2.7, and not just in this branch. |
| 12:05 |
kmlussier |
hmmm...I thought I had problems with other formats when using bre, but I'll have to double check. |
| 12:05 |
miker |
encodings-- |
| 12:06 |
jeff |
i've been seeing it cause issues with SIP in production. |
| 12:06 |
kmlussier |
miker: Yeah, I just picked a random record from Concerto. Should have stuck with Harry Potter I guess. ;) |
| 12:06 |
miker |
heh |
| 12:06 |
jeff |
concerto needs more Pokémon? |
| 12:07 |
miker |
could be related to the magical encoding stuff that dbs was poking at in the long ago at the apache or mod_perl level? |
| 12:07 |
miker |
but, it's unrelated to the branch, per se |
| 12:08 |
jeff |
It is also apparent if you view these two outputs -- no encoding error is thrown, but search for the surname starting with "Chass" to see the difference: |
| 12:08 |
jeff |
http://mlnc2.mvlcstaff.org/opac/extras/supercat/retrieve/mods32/record/165 |
| 12:08 |
jeff |
http://mlnc2.mvlcstaff.org/opac/extras/supercat/retrieve/marcxml/record/165 |
| 12:09 |
jeff |
And since I've been seeing it in SIP land, it seems to be mods32 (and some/all other mods variants), and likely unrelated to Apache. |
| 12:10 |
miker |
the difference at the output level is the <?xml> processing instruction ... it doesn't claim utf-8 in the supercat links |
| 12:10 |
* jeff |
nods |
| 12:10 |
jeff |
that's why there isn't an encoding error thrown |
| 12:10 |
miker |
so, I suspect the stylesheets... |
| 12:10 |
miker |
right |
| 12:10 |
miker |
(I suspect them, now, I mean. revising my earlier wild guess) |
| 12:10 |
bshum |
mllewellyn++ # dbwells, it looks like we're good to roll with the stat cat vandelay deal |
| 12:11 |
bshum |
I'll get my signoff and get that pushed momentarily. |
| 12:11 |
bshum |
(with all the commits this time... big sigh...) |
| 12:13 |
bshum |
Calling... hmm |
| 12:13 |
bshum |
0928 and 0929 |
| 12:14 |
miker |
bshum / Dyrcona: regarding bug 1484650, I'm happy to pull that into the sprint2 branch, but TBH, I'm not sure which branch(es) might be getting merged? |
| 12:14 |
pinesol_green |
Launchpad bug 1484650 in Evergreen "Translation for the web client (and other interfaces)" (affected: 1, heat: 6) [Wishlist,Triaged] https://launchpad.net/bugs/1484650 |
| 12:15 |
bshum |
miker: I updated the branch, but I wasn't sure if we wanted to add it now |
| 12:15 |
bshum |
Or wait a little longer for some more interfaces to flesh out |
| 12:16 |
bshum |
So I left it pointed at 2.next pending some more discussion. |
| 12:16 |
miker |
there's plenty to translate already if we thing translators may want to get a jump on it, but that's fine by me, too |
| 12:16 |
|
jihpringle joined #evergreen |
| 12:16 |
Dyrcona |
miker: I'm looking at working/user/gmcharlt/webstaff-sprint2-rel-2-9-integration |
| 12:16 |
jeff |
bshum, berick: i've reviewed and rebased (again) the branch containing legacy selfcheck and jspac removal. i've no objections and feel comfortable signing off on bshum's latest commit adjusting the Makefile. |
| 12:17 |
kmlussier |
miker: When you say you suspect the stylesheets, does that mean more work needs to be done on that branch? |
| 12:18 |
jeff |
bshum, berick: I suppose we need a release notes entry and then I can sign off on bshum's commit and i can push it? |
| 12:18 |
miker |
kmlussier: no, the branch just exposes another facet of some other bug, one we haven't pinned down |
| 12:18 |
bshum |
miker: I'm good with that plan then. |
| 12:19 |
berick |
jeff: i think that should do it |
| 12:19 |
pinesol_green |
Showing latest 5 of 7 commits to Evergreen... |
| 12:19 |
pinesol_green |
[evergreen|Remington Steed] LP#1379815 Add code to assign stat cats on Vandelay imported items - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f974781> |
| 12:19 |
pinesol_green |
[evergreen|Remington Steed] LP#1379815 Add pgTAP test - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8df8d6b> |
| 12:19 |
pinesol_green |
[evergreen|Remington Steed] LP#1379815 Add release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=97806b5> |
| 12:19 |
pinesol_green |
[evergreen|Remington Steed] LP#1379815 Better error handling - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=303608c> |
| 12:20 |
pinesol_green |
[evergreen|Ben Shum] LP#1379815: Stamping upgrade scripts for vandelay stat cat import - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3cd206a> |
| 12:21 |
bshum |
miker: One thing I can't remember now if I checked for was whether we needed to add a folder for webstaff to contain the translated pot. |
| 12:21 |
bshum |
We might need that in the mix somewhere so that git doesn't forget/destroy things |
| 12:21 |
bshum |
Or maybe that'll get covered when we run the update_pofiles later |
| 12:22 |
* bshum |
wanders away for a bit to go to get lunch |
| 12:23 |
|
akilsdonk joined #evergreen |
| 12:26 |
miker |
bshum: yeah, I'm not sure about that part |
| 12:27 |
miker |
csharp: thanks! working for pines now? (bug 1438136) |
| 12:27 |
pinesol_green |
Launchpad bug 1438136 in Evergreen 2.8 "OPAC searching significantly slowed by adding format filters" (affected: 4, heat: 20) [High,Triaged] https://launchpad.net/bugs/1438136 |
| 12:27 |
bshum |
miker: I'm sure we'll figure it out as we work through the i18n dance with Dyrcona |
| 12:29 |
jboyer-isl |
marc— |
| 12:29 |
jboyer-isl |
miker: I don’t suppose you have another moment? |
| 12:29 |
miker |
jboyer-isl: shoot |
| 12:30 |
jboyer-isl |
So some of the fixed fields I’m adding are multi-position, but are made of multiple single-letter codes. |
| 12:30 |
|
buzzy joined #evergreen |
| 12:30 |
jboyer-isl |
So you could have 1,2,3 entries, with the “most important” on the left. |
| 12:31 |
jboyer-isl |
Except that I don’t see any way to tell Evergreen that, none of those fields will ingest. |
| 12:31 |
jboyer-isl |
(i.e. they’re not in metabib.record_attrs_flat) |
| 12:32 |
miker |
jboyer-isl: for 006? |
| 12:32 |
berick |
anyone called 0930/0931 ? |
| 12:32 |
jboyer-isl |
and 008, yes. |
| 12:32 |
miker |
can you point me at docs for one? |
| 12:32 |
jboyer-isl |
one sec |
| 12:33 |
jboyer-isl |
miker: LTxt on Music records: http://www.loc.gov//marc/bibliographic/bd008m.html |
| 12:34 |
* berick |
calls 0930/0931 |
| 12:34 |
jboyer-isl |
Comp is only defined as 2-char values, and it works fine. LTxt is either a code + space, or 2 codes, in order of import. |
| 12:35 |
jboyer-isl |
OCLC spells that out a little better: http://www.oclc.org/bibformats/en/fixedfield/ltxt.html |
| 12:35 |
miker |
jboyer-isl: one thought: create one ff entry that encapsulates the set, and one for each position (by byte offset). LTxt, uncontrolled, for the whole (for the marc editor) and LTxt1, lTxt2, LTxt3 for use with the coded value map |
| 12:36 |
miker |
think of LTxt as a peer to Date1, and LTxt1 as a peer to Type, say |
| 12:37 |
jboyer-isl |
I see. That should work; I was really hoping to have the FF editor work properly. Sounds like this does that and works as expected. |
| 12:37 |
jboyer-isl |
Guess I’ll be changing that milestone though, that’s not a 1.5 hour job with testing. |
| 12:37 |
jboyer-isl |
Thanks! |
| 12:37 |
jboyer-isl |
miker++ |
| 12:37 |
miker |
np! also... |
| 12:37 |
miker |
marc21-- |
| 12:38 |
miker |
jboyer-isl++ |
| 12:39 |
|
jacobsd joined #evergreen |
| 12:43 |
* Dyrcona |
waits on upgrade scripts. |
| 12:44 |
* jeff |
writes release notes |
| 12:44 |
kmlussier |
jeff++ # Release Notes! |
| 12:45 |
* berick |
is done w/ 0930/0931 |
| 12:45 |
kmlussier |
OK, I'm removing myself as the assignee of https://bugs.launchpad.net/evergreen/+bug/1367926 mainly because I don't feel qualified to test it. |
| 12:45 |
pinesol_green |
Launchpad bug 1367926 in Evergreen "Add support for (nearly) direct access to the full unapi backend" (affected: 2, heat: 10) [Wishlist,New] |
| 12:45 |
kmlussier |
But I think it looks really cool, and the code will remain on mlnc2.mvlcstaff.org for the rest of the afternoon if anyone else wants to look at it. |
| 12:46 |
pinesol_green |
Showing latest 5 of 9 commits to Evergreen... |
| 12:46 |
pinesol_green |
[evergreen|Bill Erickson] LP#1440114 Blanket order release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0938e29> |
| 12:46 |
pinesol_green |
[evergreen|Bill Erickson] LP#1440114 Blanket order pgtap tests - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2fb0fb3> |
| 12:46 |
pinesol_green |
[evergreen|Bill Erickson] LP#1440114 invoice item type prorate/blanket warning - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b393a14> |
| 12:46 |
pinesol_green |
[evergreen|Bill Erickson] LP#1440114 PO stays open with active blanket charges - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ae9f8cb> |
| 12:46 |
pinesol_green |
[evergreen|Bill Erickson] LP#1440114 Stamping upgrade for Blanket PO - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c6a391d> |
| 12:46 |
dbs |
mmm, blankets |
| 12:46 |
|
jacobsd_ joined #evergreen |
| 12:47 |
kmlussier |
dbs: Are you cold? :) |
| 12:48 |
dbs |
kmlussier: AC in this place is a bit crazy, so yeah! |
| 12:49 |
dbs |
despite being 29C (~90F) outside |
| 12:50 |
dbs |
err, ~85F. Double it and add thirty, but don't round up before doubling, and not quite 30 :) |
| 12:50 |
kmlussier |
dbs: Wow! I didn't know temps ever reached that high in your parts. |
| 12:51 |
jeff |
dbs: did you get those early august thunderstorms/winds we got here? |
| 12:51 |
* kmlussier |
still recalls being told in elementary school that she would be using the metric system by the time she was a grown up. |
| 12:52 |
dbs |
jeff: yep, we've had some muggy muggy days |
| 13:01 |
dbwells |
kmlussier: hit some issues in testing :( Still pounding away on it, but looking less likely. |
| 13:02 |
miker |
F = C * 9/5 + 32 ... I actually remembered that! I'm sure I could use that space for something else, though, so ... how to forget it? |
| 13:03 |
jeff |
@praise git-rebase -i |
| 13:03 |
* pinesol_green |
And git-rebase -i raised the report up on high, saying O Lord, bless this thy circ report, that with it thou mayst blow thine enemies to tiny bits, in thy mercy. |
| 13:04 |
dbs |
miker: yeah, I learned "double it and add thirty" from the hosers on The Great White North (SCTV show within a show) |
| 13:05 |
dbs |
but also a very common early coding exercise :) |
| 13:05 |
miker |
sctv++ |
| 13:06 |
dbs |
Mostly, they were interested in how a metric two-four converted into an imperial two-four |
| 13:08 |
|
bmills1 joined #evergreen |
| 13:08 |
jeff |
okay, preparing to push this to master: user/jeff/kill-jspac-and-friends-with-release-notes aka http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/kill-jspac-and-friends-with-release-notes |
| 13:09 |
jeff |
added release notes that include recommendations on manual removal steps for upgrading. |
| 13:12 |
jeff |
The phones remain silent. No last minute reprieve from the release manager. |
| 13:12 |
* jeff |
pushes to master |
| 13:12 |
jeff |
Somewhere, a train whistle sounds. |
| 13:14 |
pinesol_green |
Showing latest 5 of 12 commits to Evergreen... |
| 13:14 |
pinesol_green |
[evergreen|Jeff Godin] LP#1312309: remove unused images - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=cc942ca> |
| 13:14 |
pinesol_green |
[evergreen|Jeff Godin] LP#1312309: Remove unused images added by craftsman - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=aa04189> |
| 13:14 |
pinesol_green |
[evergreen|Ben Shum] LP#1312309: Initial changes to web Makefile to avoid copying JSPAC files - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2f7133d> |
| 13:14 |
pinesol_green |
[evergreen|Jeff Godin] LP#1312297 Legacy selfcheck removal release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b15ec96> |
| 13:14 |
pinesol_green |
[evergreen|Jeff Godin] LP#1312309 JSPAC removal release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=402307e> |
| 13:15 |
jeffdavis |
If I'm moving an existing org unit to a different place in the org tree, should I restart osrf services or is running autogen sufficient? |
| 13:17 |
miker |
jeffdavis: I'd restart at least apache |
| 13:20 |
kmlussier |
dbwells: OK, thanks for letting me know. Just ping me if you need a tester! |
| 13:25 |
|
kitteh__ joined #evergreen |
| 13:25 |
Dyrcona |
C = (F -32) * 5/9 |
| 13:26 |
* Dyrcona |
has it memorized also. |
| 13:26 |
Dyrcona |
Anyway, I'm gonna push sprint2 and something else even though I've managed to hose my database. |
| 13:26 |
Dyrcona |
The sprint2 stuff worked the other day, so.... |
| 13:29 |
Dyrcona |
So, I am grabbing 0932 through 0938 |
| 13:34 |
dbwells |
kmlussier: okay, rough cut is up: working/user/dbwells/lp1479107_adjust_to_zero_interface |
| 13:34 |
kmlussier |
dbwells++ |
| 13:34 |
kmlussier |
Perfect timing! I just finished signing off on something else. |
| 13:35 |
dbwells |
I tried to incorporate the functionality of berick's old branch which focused on just negative bills as well. |
| 13:35 |
kmlussier |
I don't know if anyone took me up on my offer to test the unapi branch on mlnc2, but I'm about to take it down for a few minutes. Or maybe more than a few minutes. |
| 13:36 |
dbwells |
It's a bit more of a rush job than I would like, but unlikely to break anything. |
| 13:38 |
pinesol_green |
[evergreen|Kathy Lussier] lp1479110 Provide more clarity for negative balance settings - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a3fd9d7> |
| 13:38 |
pinesol_green |
[evergreen|Jason Stephenson] LP 1479110: Stamping Upgrade Script for Negative Balance Settings - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c8dd43e> |
| 13:38 |
kmlussier |
Yay! My first commit with an upgrade script. :) |
| 13:39 |
kmlussier |
It doesn't take much to make me happy. |
| 13:50 |
Stompro |
kmlussier++ |
| 13:52 |
jeff |
okay, i have a branch for bug 1013786 if anyone's desperate to see it get in. :-) |
| 13:52 |
pinesol_green |
Launchpad bug 1013786 in Evergreen "tpac: Check for password strength at login" (affected: 7, heat: 36) [Medium,Confirmed] https://launchpad.net/bugs/1013786 |
| 13:54 |
pinesol_green |
Showing latest 5 of 108 commits to Evergreen... |
| 13:54 |
pinesol_green |
[evergreen|Mike Rylander] webstaff: Teach the grid some new tricks - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=61feb0a> |
| 13:54 |
pinesol_green |
[evergreen|Mike Rylander] webstaff: Add the beginnings of copy attribute editing - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ba45b10> |
| 13:54 |
pinesol_green |
[evergreen|Mike Rylander] webstaff: more volume/copy editor work - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c434fe4> |
| 13:54 |
pinesol_green |
[evergreen|Galen Charlton] webstaff: add brief release notes for the 2.9 web staff cataloging integration - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=70f2bcf> |
| 13:54 |
pinesol_green |
[evergreen|Jason Stephenson] LP 1485794: Stamping web staff client sprint2 upgrade scripts. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d316f10> |
| 13:55 |
* kmlussier |
is very interested but otherwise engaged. :( |
| 13:57 |
jeff |
i think the jspac/selfcheck removal summarized to this (including addition of release notes): 262 files changed, 62 insertions(+), 13997 deletions(-) |
| 13:57 |
kmlussier |
wow |
| 13:58 |
berick |
jeff++ |
| 13:58 |
jeff |
167 images removed. |
| 13:59 |
Stompro |
jeff++ |
| 14:04 |
kmlussier |
dbwells: The adjust to zero option works great. But I'm no longer getting negative balances when I should. Just returned a paid-for lost item with none of the prohibit negative balance settings enabled. |
| 14:04 |
kmlussier |
Still poking at it in case I'm just doing something wrong. |
| 14:05 |
kmlussier |
dbwells: Oh, wait, Never mind. I know what I did. |
| 14:07 |
kmlussier |
Yes, it works! Last negative balance branch tested and ready to be signed off! |
| 14:07 |
jeff |
kmlussier++ |
| 14:07 |
kmlussier |
dbwells++ |
| 14:07 |
jeff |
dbwells++ |
| 14:09 |
dbwells |
I have to admit, this comes as a surprise to me :) |
| 14:22 |
|
afterl joined #evergreen |
| 14:23 |
kmlussier |
As an aside, I'm thinking it would be nice to have some patrons in the Concerto set with barcodes like hasoverdues, hasbills, hasitemsout to make it easy to pull up the right record when you need it. |
| 14:24 |
pinesol_green |
[evergreen|Jason Boyer] LP#1217052 Include Inactive Users in Dupe Search - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=79b3a3f> |
| 14:25 |
bshum |
Grabbing 0939 |
| 14:26 |
jeff |
kmlussier: we could take advantage of the fact that patrons can have multiple active cards for that. |
| 14:27 |
|
ericar_ joined #evergreen |
| 14:29 |
bshum |
Releasing 0939... need to fine-tune some upgrade script weirdness first |
| 14:35 |
|
jboyer-isl joined #evergreen |
| 14:36 |
pinesol_green |
[evergreen|Dan Wells] LP#1479107 Move VOID_BILLING perm check to top-level API - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a7526df> |
| 14:36 |
pinesol_green |
[evergreen|Dan Wells] LP#1479107 Fix IDL classname for account adjustments - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=637f2a2> |
| 14:36 |
pinesol_green |
[evergreen|Dan Wells] LP#1479107 adjust to zero API - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3e54f24> |
| 14:36 |
pinesol_green |
[evergreen|Bill Erickson] LP#1479107 adjust to zero UI - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d905fd5> |
| 14:39 |
|
buzzy joined #evergreen |
| 14:46 |
pinesol_green |
[evergreen|Bill Erickson] LP#1240119 Safe auth token activity logging - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=697933a> |
| 14:46 |
pinesol_green |
[evergreen|Bill Erickson] LP#1240119 safe auth activity live test - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=28dfad8> |
| 14:47 |
bshum |
Okay, calling 0939 and meaning it this time! |
| 14:52 |
pinesol_green |
Showing latest 5 of 6 commits to Evergreen... |
| 14:52 |
pinesol_green |
[evergreen|Josh Stompro] LP#1124498 - Patron Notice when account expires - fixes and enhancements - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1532a1b> |
| 14:52 |
pinesol_green |
[evergreen|Josh Stompro] LP#1124498 - Added 30 Day pre expire notice to 950.data.seed-values.sql - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6d9d244> |
| 14:52 |
pinesol_green |
[evergreen|Josh Stompro] LP#1124498 - Made a few format changes just to better match how other sql is formatted. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b90f304> |
| 14:52 |
pinesol_green |
[evergreen|Josh Stompro] LP#1124498 - Changed hook name so it includes a prefix to make it clear - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e4c10b3> |
| 14:52 |
pinesol_green |
[evergreen|Ben Shum] LP#1124498: Stamping upgrade script for 30 day pre-expiration notice - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=84278b4> |
| 14:54 |
pinesol_green |
[evergreen|Josh Stompro] LP#1124498 - Release notes for expiration notice. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d81c0b2> |
| 14:57 |
Dyrcona |
Grabbing 0940. |
| 14:58 |
bshum |
berick: I'm looking at backports to rel_2_8 and rel_2_7 for some of these upgrade scripts. |
| 14:58 |
bshum |
I know that at least one of the "fixes" that went as part of sprint2 was marked for backport |
| 14:58 |
bshum |
Things get wonky when backporting out of order, so I'll do a little conflict resolution as I work through those for us |
| 14:59 |
berick |
bshum: i'm here to help |
| 14:59 |
|
jlitrell joined #evergreen |
| 15:04 |
pinesol_green |
[evergreen|Mike Rylander] LP#1438136: Teach QP to be smart about attribute selectivity - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e348639> |
| 15:04 |
pinesol_green |
[evergreen|Mike Rylander] LP#1438136: Update baseline schema files - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=4958460> |
| 15:04 |
pinesol_green |
[evergreen|Mike Rylander] LP#1438136: Protect PG < 9.2 from our stats probe - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8f11e93> |
| 15:04 |
pinesol_green |
[evergreen|Mike Rylander] LP#1438136: Make upgrade script forgiving - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=305aae5> |
| 15:04 |
pinesol_green |
[evergreen|Jason Stephenson] LP 1438136: Stamping upgrade script. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=76b2771> |
| 15:07 |
bshum |
Backporting 0940 next. |
| 15:08 |
|
akilsdonk joined #evergreen |
| 15:10 |
bshum |
Okay, that's set. |
| 15:13 |
Dyrcona |
bshum did you look at 0936? There's a separate launchpad bug for that, but it was part of the omnibus sprint2 branches, also. |
| 15:14 |
bshum |
Dyrcona: Yep I got that first |
| 15:14 |
bshum |
Then I did 0940 |
| 15:14 |
bshum |
Both are backported to the relevant supported branches |
| 15:14 |
pinesol_green |
[evergreen|Bill Erickson] LP#1457111 eg-pbx-allocator uses modern rpc api name - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f1e09f9> |
| 15:15 |
Dyrcona |
All right. I haven't been paying much attention to email for the last several minute.s |
| 15:24 |
pinesol_green |
[evergreen|Dan Pearl] LP# 1086934 - TPAC: Complete column sorting in some screens - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c8493ca> |
| 15:27 |
Dyrcona |
Well, I think that's all the code that's printed to fit. If your branch didn't make it today, there's always 2.next. |
| 15:28 |
dbwells |
Dyrcona++ # I think I feel a song coming on... |
| 15:28 |
bshum |
Dyrcona++ |
| 15:30 |
dbwells |
♪ ♫ "It's on-ly six months a-way" ♪ ♫ |
| 15:34 |
* bshum |
felt small tugs on his heart strings with that |
| 15:35 |
* bshum |
plays the world's smallest violin for missed features |
| 15:36 |
Dyrcona |
My arm is tired, so I had to call it, and there's not enough time to smoke test everything. |
| 15:37 |
jboyer-isl |
YAAAAASSSS. Victory in my tilting at fixed windmills. Shame I couldn’t have figured this out sooner, but I’ll be ready for 2.9.1 at least. |
| 15:38 |
kmlussier |
dbwells: I'm much happier about singing that song than I was the last time you sang it. :) |
| 15:39 |
dbwells |
heh |
| 15:41 |
Dyrcona |
Well, one last i18n commit before rolling a tarball, I guess. |
| 15:44 |
pinesol_green |
[evergreen|Ben Shum] LP#1484650: Add webstaff as an i18n target - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d0f1146> |
| 15:46 |
dbwells |
Dyrcona: It can wait, but depending on where you're at, I pushed a couple more tests to flex the neg balance API bits: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=227af4a527c19c660315cd14f2a6e8a115d8558d |
| 15:47 |
bshum |
:) |
| 15:48 |
* kmlussier |
forgot to commit the neg balance release notes. |
| 15:48 |
* kmlussier |
forgot where she put the negative balance release notes. |
| 15:49 |
berick |
Dyrcona: beware, looks like the 0940 script uses 0939 in the check |
| 15:49 |
berick |
just tried updating my server and 0940 failed to run |
| 15:49 |
bshum |
Oy |
| 15:49 |
|
kitteh___ joined #evergreen |
| 15:50 |
bshum |
Indeed it does |
| 15:50 |
bshum |
berick++ |
| 15:52 |
Dyrcona |
It works for me. |
| 15:52 |
Dyrcona |
Doh! |
| 15:52 |
Dyrcona |
Easy fix. |
| 15:52 |
bshum |
We have to backport it to rel_2_8 and rel_2_7 too |
| 15:53 |
Dyrcona |
Yep. I'll take care of it. |
| 15:54 |
Dyrcona |
I got it right in 002.schema.config.sql, though. |
| 15:56 |
pinesol_green |
[evergreen|Jason Stephenson] Fix mis-stamping of 0940.schema.vlist_freq.sql. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=cb82733> |
| 15:59 |
bshum |
so for i18n steps |
| 16:00 |
bshum |
I think we should be updating the pot files before we do a sync with the bzr |
| 16:00 |
bshum |
But maybe I'm missing a detail |
| 16:00 |
bshum |
I guess it makes sense to sync translations first actually |
| 16:00 |
bshum |
Cause the LP doesn't have the latest pot file changes yet |
| 16:01 |
bshum |
Dyrcona: when you run the make newpot step, it will create a new webstaff folder that has to be added to git to track the webstaff.pot file for future translation merging |
| 16:02 |
pinesol_green |
[evergreen|Kathy Lussier] lp1198465 Release notes for Conditional Negative Balance branch - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=538a1a0> |
| 16:06 |
Dyrcona |
So do I still do the bzr steps first? |
| 16:08 |
bshum |
I think it makes sense yes. |
| 16:08 |
* jeffdavis |
adds release notes for bug 1400829, just missing the cutoff |
| 16:08 |
pinesol_green |
Launchpad bug 1400829 in Evergreen "Cannot flag user as deleted" (affected: 1, heat: 6) [Wishlist,New] https://launchpad.net/bugs/1400829 |
| 16:08 |
bshum |
Basically that'll grab the latest LP translations first |
| 16:08 |
bshum |
And then update_pofiles will create new pot templates for the main branch |
| 16:08 |
Dyrcona |
ok. |
| 16:08 |
bshum |
That will eventually get merged back to LP |
| 16:08 |
bshum |
And start the cycle again |
| 16:08 |
bshum |
It's kind of backwards, yet forwards |
| 16:09 |
bshum |
But I need to study it more |
| 16:09 |
Dyrcona |
Meh. We do it all wrong anyway. If we're going to use Lp, we should use bzr and all of that workflow, but anyway. |
| 16:09 |
bshum |
well, git soon enough |
| 16:09 |
bshum |
Once more of that fleshes out :) |
| 16:10 |
bshum |
It's happening, slowly. |
| 16:10 |
bshum |
I don't think LP links the translations with git yet. |
| 16:10 |
bshum |
But we can store code as git now |
| 16:14 |
* bshum |
dusts off his tarball skills to go make rel_2_7_& |
| 16:14 |
bshum |
*7 |
| 16:20 |
berick |
ditto 2.8.3 |
| 16:22 |
bshum |
dbwells: We never merged anything for http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ada2e932f83a9ed9f0e54b6b3cd934d556dab183 did we? |
| 16:22 |
pinesol_green |
[evergreen|Dan Wells] Changes to smooth out make_release - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ada2e93> |
| 16:23 |
bshum |
I just remembered that whole problem with the HEADURL just now |
| 16:23 |
bshum |
And went looking through older notes to try finding a commit example |
| 16:24 |
bshum |
We should probably add that changeset to make_release to every branch |
| 16:25 |
berick |
was just thinking about release notes |
| 16:25 |
berick |
oh, n/m, different topic |
| 16:25 |
bshum |
I think kmlussier is going to help you with point release notes for 2.8.3 |
| 16:26 |
* bshum |
stares expectantly in kmlussier's direction |
| 16:26 |
kmlussier |
berick: Yes, I'm just working on them now. Was focused on other things earlier. Sorry. :( |
| 16:26 |
berick |
kmlussier: that's quite alright. i just had a moment of confusion as to what was happening |
| 16:28 |
dbwells |
The HeadURL was a subversion thing, so it isn't a big deal to get right. I just figured if we were going to shoehorn a URL into that spot, it might as well be one which works. |
| 16:29 |
bshum |
dbwells: Yeah I'm happy with that. |
| 16:29 |
bshum |
I think we should commit that changeset to master and backport to everywhere |
| 16:29 |
bshum |
I'm testing mine with it now |
| 16:29 |
berick |
it's in master and 2.8 |
| 16:30 |
dbwells |
ah, ok |
| 16:30 |
dbwells |
I couldn't remember, either. |
| 16:30 |
berick |
http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7af5e29c321acf2ec3c649c69ab23a936358b9f8 |
| 16:30 |
pinesol_green |
[evergreen|Dan Wells] Changes to smooth out make_release - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7af5e29> |
| 16:30 |
bshum |
Oh, so it's just me then |
| 16:30 |
bshum |
It's not in rel_2_7 :P |
| 16:31 |
* bshum |
goes back to humming along |
| 16:32 |
* bshum |
just backports that to his branch and calls it a day then |
| 16:33 |
berick |
get 'r done |
| 16:33 |
bshum |
dbwells++ berick++ |
| 16:35 |
bshum |
Ugh, I always forget this part |
| 16:35 |
bshum |
https://bugs.launchpad.net/evergreen/+bug/1407507 |
| 16:35 |
pinesol_green |
Launchpad bug 1407507 in Evergreen "TPAC: update relator code mappings" (affected: 3, heat: 16) [Medium,Fix released] |
| 16:35 |
bshum |
it's at the bottom of the page |
| 16:36 |
bshum |
But we should probably do that before we run pot updates |
| 16:36 |
|
bmills joined #evergreen |
| 16:40 |
berick |
bshum: hm, got a sample invocation handy? |
| 16:40 |
berick |
i've never run that before |
| 16:40 |
bshum |
I think it's a script in the code we committed |
| 16:40 |
bshum |
Generated from http://www.loc.gov/marc/relators/relacode.html |
| 16:40 |
bshum |
# using the build/tools/relator_map script |
| 16:46 |
berick |
bshum: so basically: perl build/tools/relator_map > Open-ILS/src/templates/opac/parts/relators.tt2 |
| 16:47 |
bshum |
berick: I think something like that, yeah |
| 16:47 |
bshum |
We should add that step directly onto the wiki page |
| 16:49 |
berick |
i'm on there, i can add it |
| 16:50 |
bshum |
berick++ cool, thanks |
| 16:50 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 16:50 |
bshum |
I'm uploading the tarballs for 2.7.7 now. |
| 16:55 |
bshum |
Aww, it's time to pull 2.6 off the downloads page. |
| 16:55 |
bshum |
End of an era. |
| 16:57 |
dbwells |
;( |
| 16:57 |
jeff |
meeting ended early! celebrate! |
| 17:01 |
berick |
weird, Chrome is throwing up the SSL cert warning page intermittently as I navigate the tpac. |
| 17:02 |
bshum |
berick: Well that's no fun |
| 17:02 |
dbs |
berick: http/https? |
| 17:02 |
dbs |
good old mixed content? |
| 17:02 |
dbs |
@roulette 2.6 |
| 17:02 |
pinesol_green |
dbs: (roulette [spin]) -- Fires the revolver. If the bullet was in the chamber, you're dead. Tell me to spin the chambers and I will. |
| 17:03 |
berick |
don't know. for example, clicking the next/previous links in search results |
| 17:04 |
|
jwoodard joined #evergreen |
| 17:04 |
berick |
it's intermittent. even browser-Back button causes it to happen |
| 17:05 |
berick |
hope it's just me |
| 17:05 |
dbs |
maybe you're in a time warp, and jumping in and out of the cert's valid date range with each click |
| 17:05 |
bshum |
berick: *sad face* |
| 17:05 |
bshum |
berick: I'll be refreshing our main test server tomorrow with master |
| 17:05 |
bshum |
So I'll tell you if I see weirdness too :\ |
| 17:05 |
RoganH |
Has anyone had requests to use the patron self registration to give out a barcode immediately to patrons through the OPAC interface? |
| 17:07 |
berick |
RoganH: i've heard people discuss it in general terms. i don't know if anyone's trying to pursue it |
| 17:07 |
dbs |
berick: is your site HTTPS only? I'm still getting console errors for the Google Books Preview loading, which tries to send an HTTP request (grr) |
| 17:07 |
jeff |
RoganH: we had an earlier self reg that would create a patron in evergreen with a license number (since we allow their use as a valid barcode to check out books / etc) |
| 17:07 |
dbs |
(but that console error doesn't kick in until someone actually clocks on the Google Preview button) |
| 17:08 |
jeff |
the patrons were created in a temporary group -- could place holds, but couldn't circ until they were "blessed" (aka verified) by a staff member. |
| 17:08 |
jeff |
berick: what is the specific cert error from chrome? |
| 17:08 |
RoganH |
jeff: yeah, I know something new could be created, I'm hoping for something in the realm of quick hack to existing tpac :) |
| 17:08 |
berick |
dbs: standard 2.8 dev install. haven't touched the apache configs in some time. the 'ssl for everything' stuff is commented out |
| 17:08 |
jeff |
berick: also, is the url public for the instance that's throwing ssl cert errors for you? |
| 17:08 |
berick |
jeff: NET::ERR_CERT_AUTHORITY_INVALID |
| 17:08 |
berick |
it's a standard homemade cert |
| 17:09 |
jeff |
RoganH: no quick hack to do what you want that i can think of, no. |
| 17:09 |
jeff |
berick: ah. yeah, i've mostly moved away from those. (yay!) |
| 17:10 |
|
mmorgan left #evergreen |
| 17:10 |
jeff |
$99 wildcard cert: money reasonably well spent. |
| 17:11 |
berick |
FF still only requires the 1 click-through |
| 17:12 |
jeff |
berick: what platform and branch of chrome are you running? win/mac/linux/chromeos? release/beta/dev/canary? |
| 17:13 |
jeff |
sorry, s/branch/channel/ and s/release/stable/ :P |
| 17:13 |
Dyrcona |
berick bshum: Does make release always mess up the config.upgrade_deps_block_check? |
| 17:13 |
Dyrcona |
For 2.9-beta it says 0921, but shouldn't it be 940? |
| 17:13 |
Dyrcona |
0940... |
| 17:14 |
berick |
jeff: ubuntu 44.0.2403.155 (64-bit) |
| 17:15 |
jeff |
berick: you might be hitting the issue fixed here: https://chromium.googlesource.com/chromium/src/+/f1bad5724196aba822024362b481b9c2ab37dc9f |
| 17:15 |
Dyrcona |
Oh never mind. |
| 17:15 |
Dyrcona |
I see there are more than one. My tired fingers failed me in a search. |
| 17:17 |
pinesol_green |
[evergreen|Kathy Lussier] Release notes for 2.8.3 release - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=98f16b8> |
| 17:17 |
pastebot |
"Dyrcona" at 64.57.241.14 pasted "This doesn't look good." (19 lines) at http://paste.evergreen-ils.org/25 |
| 17:18 |
Dyrcona |
Neither does a message that it can't find a local grunt. |
| 17:18 |
berick |
jeff: i bet you're right |
| 17:18 |
bshum |
Well that doesn't seem good. |
| 17:19 |
bshum |
Dyrcona: You ran the make target for packager? |
| 17:19 |
bshum |
Those are weird errors though |
| 17:19 |
Dyrcona |
Yes, I did or I wouldn't have gotten that far. |
| 17:19 |
berick |
kmlussier++ |
| 17:20 |
jeff |
berick: alternately, you're hitting a related-but-different issue and might find more details in chrome issue 473390 (nothing that i saw, but starred it in case someone chimes in with an issue similar to yours in the next few days) |
| 17:20 |
jeff |
berick: also, check your internal flags for chrome://flags/#allow-insecure-localhost and chrome://flags/#remember-cert-error-decisions |
| 17:20 |
bshum |
Dyrcona: Googling that kind of git inflate error, it's talking about stuff like corrupt hard drives or such |
| 17:20 |
bshum |
That sounds bad. |
| 17:21 |
Dyrcona |
yeah, but I never put much stock in most of those kings of things. It's just people blaming hardware for their software bugs, usually. |
| 17:21 |
bshum |
Indeed. |
| 17:21 |
Dyrcona |
So, I'll kill my branch, run git gc, and start over..... |
| 17:23 |
Dyrcona |
Well, I can't do anything with git in that repo. |
| 17:23 |
berick |
thanks jeff |
| 17:23 |
berick |
good resources |
| 17:24 |
* berick |
will poke more after release cutting |
| 17:24 |
berick |
kmlussier: are you planning to backport your docs to rel_2_8 or want me to do it? |
| 17:27 |
Dyrcona |
Most of what I'm finding says my repo/branch got corrupted not the hard drive. |
| 17:27 |
Dyrcona |
git fsck is not so helpful. |
| 17:28 |
bshum |
Hmm |
| 17:30 |
Dyrcona |
I'm just gonna delete my local repo (bye, bye, local branches) and clone it over again. |
| 17:31 |
berick |
you could just move it if you want to keep the old ones |
| 17:31 |
berick |
s/old ones/local branches/ |
| 17:33 |
berick |
kmlussier: nevermind. I now see you've back-ported. thanks, again! |
| 17:34 |
Dyrcona |
berick: I can't do anything with git in that repo, and there is very little that I want to keep. |
| 17:34 |
Dyrcona |
And, it's too late. |
| 17:34 |
Dyrcona |
I blame that i18n crap.... |
| 17:35 |
bshum |
Dyrcona: Since you're starting over, would now be a bad time to add a commit for updating the relator map? |
| 17:35 |
Dyrcona |
bshum: Go ahead. |
| 17:35 |
Dyrcona |
I'm contemplating going home before continuing this. |
| 17:37 |
bshum |
Well running that script produces no changes |
| 17:37 |
bshum |
So.... I guess nothing new to worry about |
| 17:47 |
berick |
2.8.3 files uploaded |
| 18:02 |
bshum |
berick++ # I'll make changes to the downloads page once we get the 2.9 files going |
| 18:03 |
bshum |
I put all the 2.7.7 files up too. |
| 18:13 |
pinesol_green |
[evergreen|Ben Shum] LP#1484650: Missing webstaff2pot make target for newpot - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=95f71fd> |
| 18:22 |
Dyrcona |
BTW, that whole for loop dance on the release instructions is a complete waste of time. The files all end up added and the metadata-only changes never get removed from the cache. |
| 18:31 |
Dyrcona |
Things look better in a fresh repo. |
| 18:37 |
Dyrcona |
I still get fatal error unable to find local grunt. |
| 18:37 |
|
afterl left #evergreen |
| 18:54 |
|
artunit_away joined #evergreen |
| 19:24 |
kmlussier |
So I guess it's a good sign that our qa tests were successful after all the merging that happened today. |
| 19:30 |
bshum |
Heh, probably |
| 20:02 |
kmlussier |
New app that works with Evergreen - https://play.google.com/store/apps/details?id=com.thehoick.evergreenwishlist |
| 20:02 |
kmlussier |
We should put up a wiki page that lists Evergreen-related apps. |
| 20:19 |
|
jacobsd joined #evergreen |
| 20:58 |
|
Stompro_home joined #evergreen |
| 21:39 |
bshum |
Hmm, I just saw that warning from the make install finally |
| 21:39 |
bshum |
WARNING: the following files are missing in your kit: |
| 21:39 |
bshum |
lib/OpenILS/Application/Penalty.pm |
| 21:39 |
bshum |
Please inform the author. |
| 21:40 |
bshum |
Which is true, we don't have Penalty.pm anymore when it was removed as part of 432a106facf4ee93e544408d70524f06d55ff56e |
| 21:40 |
pinesol_green |
[evergreen|Bill Erickson] LP#1312308 remove deprecated open-ils.penalty service - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=432a106> |
| 21:41 |
bshum |
I think it's a matter of removing that file from Open-ILS/src/perlmods/MANIFEST |
| 22:00 |
gmcharlt |
bshum: indeed it is |
| 22:00 |
gmcharlt |
jeff++ |
| 22:00 |
gmcharlt |
berick++ |
| 22:00 |
gmcharlt |
Dyrcona++ |
| 22:00 |
gmcharlt |
here's why I'm incrementing them now: https://galencharlton.com/blog/2015/08/evergreen-2-9-now-with-fewer-zombies/ |
| 22:01 |
bshum |
Whoot :) |
| 22:01 |
bshum |
jeff++ berick++ Dyrcona++ |
| 22:04 |
bshum |
So many shiny things |
| 22:08 |
jeff |
heh. thanks. just read that. :-) |
| 22:09 |
jeff |
gmcharlt++ |
| 22:10 |
berick |
gmcharlt++ |
| 22:22 |
bshum |
I'll go ahead and file a new bug and prepare a simple branch to fix that make warning |
| 22:22 |
bshum |
Something to target towards 2.9-RC! :) |
| 22:26 |
bshum |
@later tell Dyrcona I deactivated the 2.9-beta milestone for now, will mark it released tomorrow once you've got your files uploaded. |
| 22:26 |
pinesol_green |
bshum: The operation succeeded. |
| 22:27 |
bshum |
berick: I also added new milestones for 2.8 and 2.7. Probably do some bug shuffling tomorrow or something. |
| 22:28 |
berick |
bshum: right on |
| 22:33 |
|
finnx joined #evergreen |
