| Time |
Nick |
Message |
| 07:49 |
|
artunit joined #evergreen |
| 09:19 |
|
Dyrcona joined #evergreen |
| 10:29 |
Dyrcona |
Heh. It has been a while since I did a git fetch --all on my personal laptop. |
| 10:31 |
Dyrcona |
Well, maybe not that long, just over 3 months. |
| 12:37 |
|
bmills joined #evergreen |
| 12:38 |
|
bmills joined #evergreen |
| 12:46 |
dbs |
tsbere: around for about a minute, have to take kids out to dance |
| 12:47 |
Dyrcona |
dbs: He may not be around, but he wanted your opinion on something that changes something you wrote. |
| 12:47 |
Dyrcona |
Hang on a sec and I'll find the branch. |
| 12:48 |
dbs |
Dyrcona: thanks! |
| 12:48 |
Dyrcona |
dbs: Here's the commitdiff: http://git.mvlcstaff.org/?p=tsbere/ILS.git;a=commitdiff;h=d0e6bdc4d7b086991a5f3bc5812f73872b7ab24e |
| 12:49 |
Dyrcona |
I can see that from home, so it should be world visible. |
| 12:51 |
dbs |
Hard for me to opine all that quickly, but I don't think there's any real savings to one less seq scan on config.copy_status unless sites have ccs tables with thousands of rows |
| 12:52 |
Dyrcona |
I think it comes out to 0.6 ms. |
| 12:52 |
dbs |
Typo in "availble" (just a comment) |
| 12:52 |
Dyrcona |
I joked what would I do with all that time. :) |
| 12:52 |
Dyrcona |
I think it changes the order of a couple of them, though. |
| 12:52 |
dbs |
I don't see how it could even take that long, I suspect there's some other reason you're seeing that savings :) |
| 12:53 |
dbs |
yeah |
| 12:53 |
Dyrcona |
I mean it was 0.6 ms faster than the previous version. |
| 12:53 |
Dyrcona |
At least in a couple of tsbere's tests. |
| 12:53 |
dbs |
right, I get that, I just don't think that has to do with a seq scan against config.copy_status :) |
| 12:54 |
Dyrcona |
Anyway, since you wrote the original he wanted to know what you though of it, and I think he wanted to ask why it was based on 10 before. |
| 12:54 |
Dyrcona |
But, he should speak for himself, really. I just happen to be paying attention and he isn't at the moment. |
| 12:54 |
dbs |
thanks for that though! |
| 12:55 |
dbs |
gotta roll |
| 12:56 |
Dyrcona |
Have fun! |
| 12:57 |
* Dyrcona |
is supposed to be working on development proposals. |
| 14:01 |
kmlussier |
dbs: Although tsbere mentioned a time savings in his commit, I think the main motiviation was to get checked in and reshelving items to display higher than items on the holds shelf. Since those are technically not available. |
| 14:07 |
Dyrcona |
Yep. |
| 14:08 |
Dyrcona |
Something like that. |
| 14:42 |
|
jwoodard joined #evergreen |
| 14:53 |
dbs |
kmlussier: yes, I understood that from the commit message, I was just responding to the more straightforward technical detail mentioned in the commit |
| 14:54 |
dbs |
part of me wonders whether we should add a "rank" column to config.copy_status so that sites can make ranking tweaks for other copy statuses, but probably overkill |
| 15:19 |
Dyrcona |
dbs: tsbere thought of add the same column and made almost the same conclusion. |
| 15:19 |
Dyrcona |
dbs: He thought it would be worth it if it were used in more places through out Evergreen. |
| 15:20 |
* Dyrcona |
just got back from a nice walk. |
| 16:16 |
|
dcook__ joined #evergreen |
| 16:30 |
|
dcook joined #evergreen |
| 17:12 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
