| Time |
Nick |
Message |
| 00:27 |
|
mtj_ joined #evergreen |
| 01:30 |
paxed |
eeevil: re. MARC::Record - $marc->subfield('650', 'x') always returns the 1st subfield, how do i get the others? (as 650x is repeatable) |
| 01:43 |
paxed |
ah. $field->{'_subfields'} array. |
| 02:03 |
|
gsams joined #evergreen |
| 04:11 |
|
dcook__ joined #evergreen |
| 05:14 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 07:23 |
phasefx |
@later tell paxed I wouldn't use _subfields, the underscore is a convention for internal details that could change. You should be able to do something like @a = $marc->field('650','x') in a list context |
| 07:23 |
pinesol_green |
phasefx: The operation succeeded. |
| 07:28 |
paxed |
phasefx: for a single-use quick data mangling, doesn't really matter. |
| 07:48 |
|
graced joined #evergreen |
| 08:25 |
|
Dyrcona joined #evergreen |
| 08:26 |
|
ericar joined #evergreen |
| 08:27 |
|
collum joined #evergreen |
| 08:27 |
|
akilsdonk_ joined #evergreen |
| 08:27 |
|
akilsdonk joined #evergreen |
| 08:30 |
Dyrcona |
Well, damn. They say they still can't choose the library as a hold pickup location. |
| 08:30 |
Dyrcona |
Maybe, it's.... No, can't be can_have_users, 'cause none of them would work. |
| 08:32 |
|
mmorgan joined #evergreen |
| 08:33 |
Dyrcona |
Shit. It's gonna be one of those days, isn't it? |
| 08:33 |
Dyrcona |
Now, for some reason psql is ignoring its environment variables. |
| 08:34 |
csharp |
Dyrcona: there's a library setting for that |
| 08:35 |
Dyrcona |
csharp: I was gonna look for something like that, but couldn't get into the database. |
| 08:35 |
csharp |
sec... I'll find it for you |
| 08:35 |
Dyrcona |
S'ok. I'll try pgadmin. ;) |
| 08:36 |
csharp |
opac.holds.org_unit_not_pickup_lib |
| 08:36 |
csharp |
OPAC: Org Unit is not a hold pickup library |
| 08:36 |
csharp |
If set, this org unit will not be offered to the patron as an option for a hold pickup location. This setting has no affect on searching or hold targeting |
| 08:38 |
Dyrcona |
csharp: Thanks. I was getting an answer to a question in #postgresql. |
| 08:38 |
Dyrcona |
I don't remember touching that setting. Maybe someone else did. |
| 08:38 |
csharp |
gotcha |
| 08:38 |
* Dyrcona |
checks his script, first. |
| 08:39 |
csharp |
we have temporarily set that for some libraries if they were undergoing a construction project or something |
| 08:39 |
Dyrcona |
Be nice if the history recorded who changed a setting and not just when it was changed, but there's a private bug for that. |
| 08:39 |
Dyrcona |
Yeah, this library is having similar issues. |
| 08:40 |
Dyrcona |
Being closed for a while, etc. |
| 08:41 |
Dyrcona |
And, guess what. That's not set for any of our libraries. |
| 08:41 |
csharp |
weird |
| 08:42 |
* csharp |
wonders if that change requires autogen.sh |
| 08:42 |
csharp |
nah - probably not |
| 08:43 |
csharp |
probably a template-level settings check |
| 08:43 |
Dyrcona |
Hmm. Maybe they're telling me something that isn't true. |
| 08:44 |
Dyrcona |
Well, I messed with Opac visibility yesterday and ran autogen.sh. |
| 08:44 |
Dyrcona |
Then restarted apache. |
| 08:44 |
csharp |
probably rules that out then |
| 08:45 |
Dyrcona |
I just placed a hold for pickup at the library and it works for me. |
| 08:45 |
Dyrcona |
I'd better cancel it. |
| 08:45 |
csharp |
may be browser caching |
| 08:45 |
Dyrcona |
Staff client, and I had them restart yesterday afternoon. She claims no dice. |
| 08:45 |
Dyrcona |
Maybe she only logged out. |
| 08:46 |
Dyrcona |
You never know what they actually do. |
| 08:46 |
* csharp |
agrees |
| 08:47 |
|
mrpeters joined #evergreen |
| 08:47 |
Dyrcona |
I'll just tell her it works for me. It will probably work them today. |
| 08:50 |
Dyrcona |
Who knows? Maybe she's logging into the training database and doesn't realize it. They might be blocked there. |
| 08:51 |
* Dyrcona |
needs the clairvoyant, telepathic mind upgrade. |
| 08:51 |
Dyrcona |
WTF is up with Ubuntu? |
| 08:51 |
Dyrcona |
Third kernel update for the same kernel version since last Wednesday. |
| 08:52 |
Dyrcona |
Is Debian doing the same? |
| 08:53 |
|
Shae joined #evergreen |
| 08:54 |
Dyrcona |
Well, since I'm gonna have to reboot in a few minutes, I'm signing out for now. |
| 08:56 |
|
jboyer-isl joined #evergreen |
| 08:58 |
|
maryj joined #evergreen |
| 08:58 |
dbs |
bshum++ |
| 08:59 |
dbs |
bshum++ |
| 08:59 |
dbs |
bshum++ |
| 09:02 |
|
Dyrcona joined #evergreen |
| 09:03 |
Dyrcona |
S'pose I should try placing a hold as their circ account. |
| 09:03 |
|
jwoodard joined #evergreen |
| 09:07 |
Dyrcona |
Well, all I can say is, it works for me. |
| 09:10 |
|
akilsdonk joined #evergreen |
| 09:12 |
|
yboston joined #evergreen |
| 09:14 |
csharp |
Dyrcona: several linux security vulnerabilities announced in the last week: https://lists.ubuntu.com/archives/ubuntu-security-announce/2015-February/thread.html |
| 09:15 |
Dyrcona |
csharp: I figured as much, when the updates for 3.13.0-46 kept coming. |
| 09:15 |
Dyrcona |
And, I don't like how Debian and Ubuntu number the kernels, but that's a minor quibble. |
| 09:15 |
* Dyrcona |
ponders switching to OpenBSD on the desktop. |
| 09:16 |
* Dyrcona |
ran a FreeBSD desktop for over a decade, then switched to Ubuntu. |
| 09:16 |
* csharp |
has been happily living on Fedora for the last 6 months |
| 09:16 |
* Dyrcona |
likes to experiment and wishes he had more time to play. |
| 09:17 |
* Dyrcona |
has used all the major GNU/Linux distros: Debian, Fedora, RedHat (pre-Fedora), and Slackware. |
| 09:18 |
csharp |
Fedora runs whatever is the current stable kernel release - it's not locked in to a minor version for the duration of an OS release like Debian/Ubuntu |
| 09:18 |
yboston |
kmlussier: are you around? |
| 09:18 |
Dyrcona |
Most other distros are derivatives of one of the above. |
| 09:18 |
csharp |
yep |
| 09:18 |
csharp |
I wanted to try out Arch a few years ago, but never got past the "poke in a VM" stage |
| 09:18 |
Dyrcona |
I really wish I had the time to do a Linux From Scratch setup on a laptop or something. |
| 09:18 |
csharp |
yeah - I'd like that too |
| 09:19 |
Dyrcona |
I don't play with vms that much, other than for Evergreen development. |
| 09:19 |
csharp |
Gentoo was the original platform for EG iirc |
| 09:19 |
Dyrcona |
I'd like to mess with NetBSD, too. |
| 09:20 |
Dyrcona |
I've never used Gentoo, though I considered it, 'cause its basically Debian with ports! |
| 09:20 |
* Dyrcona |
likes "ports." |
| 09:20 |
Dyrcona |
I never much got the point of Debian with a FreeBSD kernel, though. |
| 09:21 |
Dyrcona |
BSD kernel with a GNU userland. |
| 09:21 |
Dyrcona |
Just install the GNU utilities on FreeBSD. |
| 09:21 |
Dyrcona |
You pretty much need to install gmake anyway. |
| 09:22 |
csharp |
makes sense |
| 09:22 |
Dyrcona |
Last time I messed with NetBSD, it was 2001 or 2002 and I had to get networking to function on a SPARC box. |
| 09:22 |
Dyrcona |
'Cause the EE student who set it up in the lab couldn't figure it out. |
| 09:23 |
Dyrcona |
I should buy myself a nice, fat box for home and play with VMs. |
| 09:23 |
|
TaraC joined #evergreen |
| 09:26 |
Dyrcona |
One thing I'd like to do is measure postgres performance on different O/S file system combinations. |
| 09:26 |
Dyrcona |
Last time I saw something comprehensive, the guy was using the 3.2 Linux kernel, so naturally 2.6 and FreeBSD 9 spanked it in performance. |
| 09:27 |
Dyrcona |
FreeBSD 9 with ZFS came out the winner, but it wasn't really fair given that 3.2 had busted performance. |
| 09:33 |
kmlussier |
yboston: I'm here now |
| 09:33 |
bshum |
https://bugs.launchpad.net/evergreen/+bug/1205061 anyone got a sec to check this before we start wrapping up and cutting releases? |
| 09:33 |
pinesol_green |
Launchpad bug 1205061 in Evergreen "Need more "IF EXISTS" clauses in 2.3-2.4.0-upgrade-db.sql" (affected: 1, heat: 8) [Medium,Triaged] |
| 09:33 |
yboston |
kmlussier: I just put in my msg in a commnet on your subfield e patch |
| 09:34 |
bshum |
Also anything else I've missed that needs pushing... Let us know. |
| 09:34 |
yboston |
I tested the code, and looks good, I am just not familiar enough with the get_graphic_880s fucntions full use yet, to be sure there are no consequences to your change. despite that |
| 09:34 |
yboston |
I can offer a signoff |
| 09:35 |
gmcharlt |
Dyrcona: indeed; 3.2 is kind of a perfect storm of slow for Pg |
| 09:37 |
* Dyrcona |
winks at gmcharlt, 'cause he probably knows that we're *still* running Pg on a 3.2 kernel. |
| 09:37 |
kmlussier |
yboston: https://bugs.launchpad.net/evergreen/+bug/1427331/comments/3 |
| 09:37 |
pinesol_green |
Launchpad bug 1427331 in Evergreen "Author links on search results page include subfield e" (affected: 2, heat: 12) [Medium,New] - Assigned to Kathy Lussier (klussier) |
| 09:38 |
gmcharlt |
Dyrcona: heh - I had not, in fact, had that thought in mind personally |
| 09:38 |
gmcharlt |
of course, the problem with database servers is finding opportunities to reboot them :) |
| 09:38 |
kmlussier |
yboston: It might not be a bad idea to get somebody else's opinion, though. Maybe dbs has some thoughts since he was the dev who originally did the 880 work. |
| 09:39 |
Dyrcona |
Yes. That and we're supposed to order new hardware any day, now. |
| 09:39 |
Dyrcona |
I just have to find time to finalize the specs and place the order. |
| 09:39 |
yboston |
kmlussier: that makes sense, and you can tell him that I can do the signoff busy work if he is OK with your code |
| 09:39 |
yboston |
kmlussier: thanks for sharing your research process |
| 09:39 |
Dyrcona |
So, it's kind of like, just wait for the new hardware at this point. |
| 09:40 |
yboston |
kmlussier: for the record, I did not doubt you had done that type of research |
| 09:40 |
yboston |
kmlussier: BTW, when can I start calling you a developer? |
| 09:40 |
kmlussier |
yboston: No worries! I actually expected somebody to raise the question, so I probably should have mentioned it when I posted the code. |
| 09:40 |
kmlussier |
yboston: Never! :) |
| 09:41 |
yboston |
kmlussier: then stop developing code ;) |
| 09:41 |
gmcharlt |
yboston: hush! ;) |
| 09:42 |
yboston |
kmlussier: seriously, yesterday I was asked to display the bib tag 245 subfield h ("medium") in search results , I will probaly need to look at the same bits of code you worked on |
| 09:51 |
kmlussier |
yboston: Based on what I recall seeing for the 245 field, I don't think it should be too difficult to add. |
| 09:52 |
yboston |
kmlussier: thanks, I was hoping that too |
| 09:52 |
yboston |
kmlussier: but hearing if from a developer, soorry I mean you is reasurring |
| 09:52 |
yboston |
:) |
| 09:52 |
kmlussier |
yboston: You may call me a contributor if it makes you happy. |
| 09:53 |
yboston |
kmlussier: for now that makes me happy, but I am not sure for how long |
| 09:53 |
yboston |
kmlussier++ |
| 09:54 |
Dyrcona |
I never liked the word "developer." Makes me think of condos, subdivisions, etc. |
| 09:54 |
|
akilsdonk joined #evergreen |
| 10:08 |
jonadab |
"Coder"? |
| 10:08 |
jonadab |
Or I suppose there's always "programmer", but in a library context that could be misunderstood too. |
| 10:28 |
kmlussier |
dbs++ #Feedback on subfield e |
| 10:30 |
yboston |
dbs++ |
| 10:33 |
kmlussier |
So was it the consensus that we should use needsrepatch as our new tag? |
| 10:33 |
kmlussier |
And it should be used if you've tested a patch, but you think it needs additional work? |
| 10:34 |
* kmlussier |
is working on updating the Bug Squashing Day Guidelines for signoffs |
| 10:37 |
* bshum |
isn't sure consensus was reached, and didn't see an email from gmcharlt |
| 10:37 |
bshum |
But I used that tag last night on one bug where I thought it could use some extra love. |
| 10:40 |
csharp |
"The Developers" is the term mostly used in the PINES library vernacular |
| 10:41 |
csharp |
it's often said as if "The Developers" are a single unit |
| 10:42 |
bshum |
dbwells: Hmm, on https://bugs.launchpad.net/evergreen/+bug/1205072, I know you've already pushed through all previous branches, but the last comment by Stompro on minor upgrade misgivings is part of the reason I havent' been sure whether we should backport that change to earlier versions. |
| 10:42 |
pinesol_green |
Launchpad bug 1205072 in Evergreen 2.7 "Action trigger Granularity strings saving lable not value" (affected: 3, heat: 24) [Undecided,Fix committed] |
| 10:42 |
csharp |
@who is one of THE DEVELOPERS? |
| 10:42 |
pinesol_green |
dbs is one of THE DEVELOPERS. |
| 10:42 |
bshum |
Last opinions before we solidify cutting the releases. |
| 10:42 |
csharp |
indeed |
| 10:42 |
bshum |
oooh, spooky csharp :) |
| 10:51 |
dbwells |
bshum: yeah, I kinda feel like the only way people are going to get through that change smoothly is if we make a lot of noise, so in that sense I think it would help to do all three versions at once. We don't really have good precedent for a change like this, since we can't really "upgrade" folks' cron jobs. |
| 10:52 |
bshum |
dbwells: Right, that's kind of where it's easier to swallow something like that during a major version change. But I guess it's all relative, and doesn't really impact me personally... so.... :) |
| 10:52 |
|
maryj joined #evergreen |
| 10:58 |
bshum |
For this particular change, I guess we'll just have to make sure we note it alongside the other changes in the announcements. |
| 10:59 |
|
jboyer-isl joined #evergreen |
| 11:00 |
dbwells |
bshum: One thing which might set minds at ease, the current settings aren't going to change even if you edit and save, unless you actually select the new lower-case value. There seems to be some misunderstanding in the bug about that. |
| 11:03 |
jboyer-isl |
So there are going to be entries for Hourly and hourly? |
| 11:03 |
jboyer-isl |
Ick. |
| 11:05 |
Dyrcona |
jboyer-isl: Most databases I've worked with are case insensitive by default, Postgres does it the opposite. |
| 11:05 |
jonadab |
I don't so much mind case-insensitive by _default_; what bugs me to death is when there's no easy way to do a case-sensitive match. |
| 11:06 |
jboyer-isl |
I know the db will let you use whatever, I read dbwells last message as the staff interface for A/T events will now have options in both cases to minimize changes. |
| 11:06 |
jboyer-isl |
jonadab: ilike? |
| 11:06 |
jonadab |
jboyer-isl: tSQL, to the best of my knowledge. |
| 11:06 |
jboyer-isl |
Oh, case sensitive. I misread |
| 11:06 |
jonadab |
Right, I don't mind case-sensitive either. |
| 11:07 |
jonadab |
Because you can always upcase or downcase both for the comparison. |
| 11:07 |
Dyrcona |
jboyer-isl: I admit to not having reviewed the bug in ages. |
| 11:07 |
Dyrcona |
I just assumed part of the issue with things not working is case sensitivity. |
| 11:07 |
dbwells |
jboyer-isl: The form is a combo select-an-option-or-type-whatever-you-want box. The options listed will all be lower case, but existing uppercase settings will persist until changed manually and purposefully. |
| 11:08 |
* Dyrcona |
goes back to being just swamped instead of swamped and distracted. |
| 11:08 |
jboyer-isl |
dbwells: Ah! That’s what I was hoping for. I may have jumped to conclusions when I read your message at 11:00. |
| 11:09 |
jboyer-isl |
I read that as “The title case options will be there, they’ll have to choose the lower case options to change them.” I was forgetting how the combo box worked currently. |
| 11:12 |
dbwells |
I am not sure why berick opted to not simply make the granularity case-insensitive on the code side. Perhaps we should still do that as well? |
| 11:12 |
Dyrcona |
@hate futzing around in GUIs when I could actually get the work done instead of correcting all the horse shit the GUI insists on doing. |
| 11:12 |
pinesol_green |
Dyrcona: The operation succeeded. Dyrcona hates futzing around in GUIs when I could actually get the work done instead of correcting all the horse shit the GUI insists on doing.. |
| 11:26 |
jboyer-isl |
dbwells: I like the case-insensitivity idea. When you can enter anything you like there’s no realistic reason to actually treat Hourly and hourly as separate things. Use hourly and hourly-(special reason here), etc. (we have 5 or 6 things that start with Daily- here) |
| 11:38 |
bshum |
Sigh... so are we done enough that I can start cutting anything or are we actively working on anything else that needs pushing here? |
| 11:44 |
berick |
we can always pull the A/T case stuff later. |
| 11:48 |
dbwells |
berick: Do you mean roll back the stuff already committed, or leave it and make it insensitive in a follow up bug? |
| 11:49 |
berick |
ah, didn't realize it was already committed. |
| 11:50 |
|
sandbergja joined #evergreen |
| 11:52 |
dbwells |
I don't have a problem taking it back out; it's really a very minor bug in the first place. The fix works as is, but not without potential gotchas. |
| 11:57 |
berick |
if the long-term plan is to make it case-insensitive on the back end, which I agree is a good idea, it probably would make sense to roll back part of the committed fix |
| 11:58 |
berick |
it's good the strings are now un-translated, but there's no reason for the UI to be case-sensitive if the backend is not |
| 11:58 |
berick |
well, it wouldn't hurt, but it could cause confusion |
| 12:00 |
dbwells |
I suggest we revert the whole thing for the maintenance branches, leave it as-is for master, then deal with the move to case-insensitivity in a new bug. How does that sound? |
| 12:02 |
berick |
that works for me |
| 12:02 |
berick |
well, hmm, if we implement a fix which varies from the code in master, then it will be easier to merge across branches if it's the same for all branches |
| 12:03 |
berick |
iow, reverting from all branches |
| 12:03 |
dbwells |
alright, revert from all branches, then add case-insensitivity as a requirement to the current bug? |
| 12:03 |
berick |
+1 |
| 12:04 |
dbwells |
okay, I'll get started. Any objections, please speak soon... |
| 12:06 |
dbwells |
March 3rd, bug unsquashing day |
| 12:06 |
berick |
dbwells++ |
| 12:07 |
jboyer-isl |
dbwells++ |
| 12:10 |
kmlussier |
dbwells++ |
| 12:12 |
bshum |
For the upgrade script |
| 12:12 |
|
bmills joined #evergreen |
| 12:12 |
bshum |
I'm thinking for 0914's bit, we should consider placing the UPDATE portion outside the regular transaction block |
| 12:12 |
bshum |
For the version-upgrade script I mean |
| 12:13 |
bshum |
And have it commit everything, then run the three UPDATE's |
| 12:14 |
berick |
+1 |
| 12:15 |
csharp |
berick: if you're still looking for EG conf presentation ideas/fodder, the PINES staff here would *love* to see a primer on EDI |
| 12:16 |
bshum |
Isn't EDI already on the proposals page? |
| 12:16 |
bshum |
Or you mean something more technical on the code side, csharp ? |
| 12:17 |
berick |
hmm, EDI lightning talk ;) |
| 12:17 |
pinesol_green |
[evergreen|Dan Wells] Revert LP#1205072 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=23705b6> |
| 12:18 |
csharp |
bshum: berick: yeah, something more technically-minded than that description indicates |
| 12:18 |
* csharp |
hadn't noticed the EDI program |
| 12:27 |
kmlussier |
I would attend that presentation |
| 12:32 |
|
mglass joined #evergreen |
| 12:34 |
kmlussier |
Final numbers from bug squashing day: bit.ly/1EGhB4Q |
| 12:34 |
kmlussier |
http://bit.ly/1EGhB4Q |
| 12:34 |
kmlussier |
If I missed any activity, let me know! |
| 12:37 |
csharp |
if I hadn't rm -rf *'ed my home directory yesterday, I would've had better numbers :-/ |
| 12:37 |
gmcharlt |
! |
| 12:37 |
gmcharlt |
csharp: I'm so sorry |
| 12:38 |
|
mglass joined #evergreen |
| 12:38 |
csharp |
gmcharlt: thanks - it was just a minor inconvenience, but it sucked up most of my morning getting everything back to normal ;-) |
| 12:39 |
kmlussier |
csharp: Sorry! The problem with Bug Squashing Day numbers is that they don't reflect the ongoing contributions we get from people. |
| 13:01 |
* jeff |
tries to remember if he's debated between the "track NCIP users via actor.usr_activity, actor.usr_setting, or actor.stat_cat_entry_usr_map |
| 13:05 |
Dyrcona |
csharp: Turns out I had circ.holds.target_skip_me turned on for this location. |
| 13:05 |
* Dyrcona |
grumbles... |
| 13:05 |
Dyrcona |
And, I believe I'm late for lunch. |
| 13:16 |
jboyer-isl |
kmlussier: one (potential) addition to your list. I’m down for a new patch, but that bug was new yesterday too. I didn’t know if you were merging them together since both were me, or if the bug just got missed. |
| 13:17 |
kmlussier |
jboyer-isl: I merged them together, but I could separate them out. I'm never sure how to handle those. |
| 13:17 |
kmlussier |
But I guess it's better to show more activity than less. :) |
| 13:17 |
jboyer-isl |
It’s entirely up to you, I was just checking. :) |
| 13:17 |
|
maryj_ joined #evergreen |
| 13:18 |
mmorgan |
kmlussier: Previously, did you have a column for commented bugs? |
| 13:18 |
kmlussier |
mmorgan: I have a column for feedback on a patch that didn't get a signoff. I figure if the time went into testing or reviewing the code, but a signoff wasn't given, it should still count. |
| 13:19 |
kmlussier |
It may have said bug feedback before, but I think I counted it the same way. |
| 13:19 |
|
maryj__ joined #evergreen |
| 13:20 |
mmorgan |
OK, gotcha. |
| 13:20 |
dbs |
kmlussier++ |
| 13:20 |
mmorgan |
kmlussier++ |
| 13:24 |
bshum |
kmlussier++ |
| 13:27 |
pinesol_green |
[evergreen|Kathy Lussier] lp1427331: Remove relator information from author links - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=012a0eb> |
| 13:28 |
kmlussier |
dbs++ #Thank you! |
| 13:28 |
Dyrcona |
kmlussier: And I have a ticket to make the actual relator name show somewhere instead of just "Added Author." |
| 13:29 |
kmlussier |
Dyrcona: It is showing on record summary, isn't it? |
| 13:29 |
Dyrcona |
I don't know off the top of my head. I have too many irons in the fire right now. |
| 13:30 |
Dyrcona |
I'll show you the ticket when you're in the office next time, if you care. |
| 13:30 |
dbs |
on record details, it will likely say "Bar, Foo, director (Added Author)" because details works with $4 instead of $e |
| 13:30 |
kmlussier |
Dyrcona: I think C/W MARS was looking at the same issue today. I'll be there Monday. |
| 13:30 |
dbs |
RDA_relator_text-- |
| 13:30 |
Dyrcona |
kmlussier: Yep. I got the message mixed up on that and thought it was today. |
| 13:32 |
Dyrcona |
I've been messing with the Boxford mess and email account changes this morning. |
| 13:33 |
dbs |
Here's an example: https://laurentian.concat.ca/eg/opac/record/2885289?locg=1 |
| 13:33 |
kmlussier |
Dyrcona: I would like to take a stab at incorporating the subfield e in the record summary in a sensible, but it may be beyond my abilities. |
| 13:33 |
kmlussier |
I get a little lost when I look at authors.tt2 |
| 13:34 |
dbs |
"ed.", it's like we're suffering from storage limits or something. sheesh. |
| 13:34 |
dbs |
RDA_relator_text-- |
| 13:34 |
dbs |
kmlussier: open a bug and I'll come up with a record details fix |
| 13:34 |
csharp |
Dyrcona: ah - makes sense |
| 13:34 |
Dyrcona |
dbs: I can copy and paste what one of our catalogers requested. |
| 13:35 |
dbs |
need to do some dancing around schema.org/Role and handling $4 and $e both potentially appearing in the same field as well |
| 13:35 |
Dyrcona |
csharp: yeah. they expect me to remember what I did in December. |
| 13:35 |
csharp |
heh |
| 13:35 |
* dbs |
would just turn it into "Bar, Foo (director)" rather than "Bar, Foo, director (Added Author)" |
| 13:36 |
dbs |
s/director/ed./ if you're into real-world abbreviated examples |
| 13:36 |
* csharp |
saw the episode of Black Mirror where the implant recorded everything their eyes saw and considered advantages to his job |
| 13:36 |
Dyrcona |
dbs: I'll open a launchpad bug. I'll let you decide on implementation. |
| 13:36 |
kmlussier |
When I see author in http://catalog.mvlc.org/eg/opac/record/1540484, then, that's not subfield e? |
| 13:36 |
csharp |
of course, the implants ruined everyone's personal lives too, so there's that |
| 13:36 |
Dyrcona |
Well, i dug it out of a script. |
| 13:38 |
dbs |
kmlussier: "author" is from $e, "(Author)" is from it being a 1xx instead of a 7xx |
| 13:38 |
dbs |
7xx gets "(Added Author)" if it doesn't have a $4 |
| 13:39 |
dbs |
1xx gets "(Author)" if it doesn't have a $4 |
| 13:39 |
Dyrcona |
Well, the local bug description is sparse. |
| 13:39 |
kmlussier |
dbs: OK, thanks! So we may want to give it (Added Author) or (Author) if it doesn't have a $4 or $e, right? |
| 13:40 |
Dyrcona |
Anyway, lp 1427805 |
| 13:40 |
pinesol_green |
Launchpad bug 1427805 in Evergreen "700 tag $e and the OPAC view." (affected: 1, heat: 6) [Wishlist,New] https://launchpad.net/bugs/1427805 |
| 13:42 |
dbs |
kmlussier: yes, that's what happens now. But it also still gives those if it does have a $e currently, that's what we need to fix :) |
| 13:44 |
kmlussier |
Dyrcona++ dbs++ |
| 13:56 |
|
TaraC joined #evergreen |
| 14:23 |
|
maryj joined #evergreen |
| 14:24 |
|
TaraC joined #evergreen |
| 14:40 |
|
dreuther joined #evergreen |
| 14:44 |
|
mtate joined #evergreen |
| 15:52 |
mrpeters |
can i get a sanity check on an IF statement for a Trigger Event template? http://pastie.org/9996968 -- i've inserted the event def and path 'target_copy.circ_modifier' to the environment as well |
| 15:54 |
phasefx |
mrpeters: do you need to quote those circ mod codes? |
| 15:55 |
mrpeters |
phasefx: not sure -- perhaps, since they aren't id (integers) |
| 15:55 |
Dyrcona |
Yes, you do. You don't need the parens, though. |
| 15:55 |
Dyrcona |
Also, I'm not sure that's gonna do what you want exactly. |
| 15:56 |
mrpeters |
ok, thats what i wanted to check on -- i only want to send this email if the circ modifier matches one of those two codes |
| 15:56 |
Dyrcona |
Doesn't that template send 1 email for multiple circulations? |
| 15:57 |
Dyrcona |
This will stop the generation of the email if the first (and only the first) matches the circ modifier. |
| 15:57 |
mrpeters |
in theory, yes, i suppose it could |
| 15:57 |
Dyrcona |
In practice, I'm pretty sure it does, too. |
| 15:57 |
Dyrcona |
Patrons often have more than 1 overdue item at a time. |
| 15:57 |
berick |
yeah, you'll have to loop |
| 15:58 |
mrpeters |
so in a perfect world, we only send an hourly overdue notice for the items out which have RS2 and RS8 circ mods |
| 15:58 |
berick |
(or grep) |
| 15:58 |
Dyrcona |
Can you grep from a template? |
| 15:58 |
Dyrcona |
I never tried that. |
| 15:58 |
berick |
template toolkit has a grep operator |
| 15:58 |
Dyrcona |
OK. |
| 15:58 |
mrpeters |
yeah id love to see an example of how you could grep |
| 15:58 |
berick |
it's a little funky |
| 15:59 |
Dyrcona |
I forgot this had to do with hourly overdue notices. |
| 15:59 |
mrpeters |
if i could select all circs, but only grep for ones with RS2 and RS8 and only send email about those items, that would be wicked |
| 15:59 |
berick |
http://template-toolkit.org/docs/manual/VMethods.html#section_grep |
| 15:59 |
mrpeters |
Dyrcona: yeah -- i got them to drop the hourly lost piece, it just doesnt exist right now and they dont want to invest in developing it |
| 15:59 |
berick |
it works on arrays somehow.. i forget the exact syntax |
| 15:59 |
berick |
well, i guess that is the syntax |
| 15:59 |
mrpeters |
but i think with the stuff mmorgan showed, i can make the notices still go out |
| 16:00 |
berick |
fwiw, you don't have to add circ_modifier to the env either. target_copy.circ_modifier is the code (when unfleshed) |
| 16:00 |
mrpeters |
so what would you grep on, since there is no directory of txt files |
| 16:01 |
mrpeters |
oh, ok cool |
| 16:01 |
Dyrcona |
And, I misspoke, this would only send the email when the first matches, not stop the generation of the email. |
| 16:01 |
berick |
actually, forget grep. it gets weird w/ nested objects. |
| 16:01 |
berick |
loop++ |
| 16:01 |
mrpeters |
thanks for the clarification Dyrcona |
| 16:02 |
Dyrcona |
The documentation on grep is pretty short there. |
| 16:02 |
mrpeters |
http://www.template-toolkit.org/docs/manual/Variables.html#section_loop what i want berick? |
| 16:03 |
Dyrcona |
perl has grep function that works on lists, not files. |
| 16:04 |
jeff |
heh. item status != "On hold shelf" gives -1 for a hold status, but item deleted doesn't. :-) |
| 16:07 |
berick |
mrpeters: there's a loop like you need a few lines down in the template |
| 16:08 |
mrpeters |
ah, right, the one that gets all of the item information |
| 16:08 |
Dyrcona |
I'd try to build a list of just the circs you want to report on, and then if that has anything in it, do the email with the new list. |
| 16:10 |
mrpeters |
yeah, that makes sense -- so get rid of the [%FOR circ IN target %] and replace it with something more like [%FOR circ_modifier IN target %], and of course squeezing in an IF circ_modifier == RS2 or RS8 in there somewhere |
| 16:12 |
Dyrcona |
I'd build the new list before where you have your IF right now. |
| 16:12 |
Dyrcona |
The IF would be [% IF new_list.size %] |
| 16:12 |
Dyrcona |
Then replace target with new_list below. |
| 16:15 |
Dyrcona |
I wonder if you can do all that in a template, though. |
| 16:15 |
Dyrcona |
build a new list... |
| 16:16 |
mrpeters |
you would know better than me :) i am awful with the templating portion of this |
| 16:16 |
mrpeters |
i have a pretty good grasp on the cron jobs, validity, etc. type stuff |
| 16:16 |
mrpeters |
but as cool as template toolkit is, it still is not my friend haha |
| 16:17 |
Dyrcona |
Well, from what I can tell, the grep vmethod looks like it only does a simple pattern match. It's not as sophisticated as grep in Perl. |
| 16:18 |
Dyrcona |
That would be the easiest want to do it. |
| 16:18 |
Dyrcona |
s/want/way/ |
| 16:18 |
mrpeters |
so you say grep vs. loop? |
| 16:18 |
mrpeters |
the circ mod codes are all pretty simple short strings |
| 16:19 |
Dyrcona |
yeah, but looks like it won't work here. |
| 16:19 |
Dyrcona |
Or, i don't see how to make it work. |
| 16:19 |
|
buzzy joined #evergreen |
| 16:24 |
Dyrcona |
Something like should work: http://pastie.org/9997040 |
| 16:24 |
Dyrcona |
Not 100% on the syntax, but that should build a newList with just the circs you want. |
| 16:25 |
Dyrcona |
So, do that before the IF, and change the If to be newList.size(). Then use newList instead of target in the email. |
| 16:27 |
Dyrcona |
You might want push instead of unshift if you want to preserve the order from the original list. |
| 16:29 |
Dyrcona |
For the record, that's more programming than I'd like to see in a template, but there you go. ;) |
| 16:39 |
|
hopkinsju joined #evergreen |
| 16:39 |
|
Bmagic joined #evergreen |
| 16:57 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:08 |
|
mrpeters left #evergreen |
| 17:08 |
|
mmorgan left #evergreen |
| 17:10 |
jeffdavis |
the commit message for commit 51d2b34 references the wrong LP bug (should be bug 1210541, not 121054) |
| 17:10 |
pinesol_green |
Launchpad bug 1210541 in Evergreen "Copy locations table should have a 'deleted' flag" (affected: 9, heat: 52) [Wishlist,Fix committed] https://launchpad.net/bugs/1210541 |
| 17:10 |
pinesol_green |
[evergreen|Ben Shum] LP#121054: Stamping upgrade script for asset.copy_location-delete-rule - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=51d2b34> |
| 17:15 |
kmlussier |
I'm surprised I haven't made that mistake yet. |
| 17:16 |
* gmcharlt |
finds a forest, knocks on it |
| 17:17 |
jeffdavis |
:) |
| 17:42 |
bshum |
jeffdavis: Yeah I blame that on the original commit line, that's my bad. I noticed it right after I pushed it through to master. |
| 17:42 |
bshum |
I think I've done that... hmm, twice. |
| 17:43 |
bshum |
So far anyways :( |
| 17:43 |
* bshum |
survived his drive home in the silly snow. |
| 17:50 |
|
Newziky left #evergreen |
| 17:56 |
gmcharlt |
http://evergreen-ils.org/security-releases-evergreen-2-7-4-2-6-7-and-2-5-9/ |
| 18:03 |
pinesol_green |
[evergreen|Jason Stephenson] LP#1206589: Temporary Fix for Org. Unit Settings History Bug - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ac588e8> |
| 18:03 |
pinesol_green |
[evergreen|Jason Stephenson] LP#1424755: Org Unit Setting view permissions can be bypassed - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3a0f1cc> |
| 18:03 |
pinesol_green |
[evergreen|Jason Stephenson] LP#1424755: Add IMPORTANT SECURITY INFORMATION release note. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=27c608c> |
| 18:03 |
pinesol_green |
[evergreen|Ben Shum] Forward-port 2.7.3-2.7.4 upgrade script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ab9da07> |
| 18:13 |
|
Bmagic joined #evergreen |
| 18:13 |
|
hopkinsju joined #evergreen |
| 18:54 |
|
bmills1 joined #evergreen |
| 18:57 |
|
Bmagic joined #evergreen |
| 18:57 |
|
hopkinsju joined #evergreen |
| 19:06 |
|
Bmagic joined #evergreen |
| 19:06 |
|
hopkinsju joined #evergreen |
| 22:10 |
|
mmorgan joined #evergreen |
