| Time |
Nick |
Message |
| 00:03 |
|
mrpeters joined #evergreen |
| 00:07 |
|
mrpeters left #evergreen |
| 04:59 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 07:16 |
|
graced joined #evergreen |
| 07:27 |
kmlussier |
@coffee |
| 07:27 |
* pinesol_green |
brews and pours a cup of Ka'u Coffee Natural Dried, and sends it sliding down the bar to kmlussier |
| 07:29 |
kmlussier |
Thank you pinesol_green for not sending me decaf this time. I woke up at 3 a.m. and really need the caffeine. |
| 07:46 |
|
rjackson_isl joined #evergreen |
| 07:50 |
|
jboyer-isl joined #evergreen |
| 08:01 |
|
ericar joined #evergreen |
| 08:05 |
|
graced joined #evergreen |
| 08:08 |
|
akilsdonk joined #evergreen |
| 08:23 |
|
Shae joined #evergreen |
| 08:25 |
|
collum joined #evergreen |
| 08:26 |
|
collum|2 joined #evergreen |
| 08:26 |
|
collum|2 left #evergreen |
| 08:27 |
|
maryj joined #evergreen |
| 08:31 |
|
mmorgan joined #evergreen |
| 08:37 |
|
yboston joined #evergreen |
| 08:39 |
|
Dyrcona joined #evergreen |
| 08:47 |
|
yboston joined #evergreen |
| 08:57 |
|
jwoodard joined #evergreen |
| 09:22 |
|
ericar_ joined #evergreen |
| 09:22 |
collum |
@tea [someone] |
| 09:22 |
* pinesol_green |
brews and pours a pot of Golden Orchid, and sends it sliding down the bar to BigRig (http://ratetea.com/tea/whispering-pines/golden-orchid/7244/) |
| 09:23 |
csharp |
@who needs something warm to drink today? |
| 09:23 |
pinesol_green |
remingtron needs something warm to drink today. |
| 09:23 |
|
sarabee joined #evergreen |
| 09:25 |
mmorgan |
Everyone needs something warm to drink today! ;-) |
| 09:25 |
* csharp |
slogs into his mostly-neglected pile of helpdesk tickets |
| 09:26 |
csharp |
eww -reports |
| 09:26 |
|
ericar_ joined #evergreen |
| 09:27 |
|
ericar left #evergreen |
| 09:36 |
|
tsbere joined #evergreen |
| 10:09 |
yboston |
I have a question about what is the common practice with using git working branches, specifically if I make a working branch and decide to restart my code form scratch. Should I delete the previous remote branch, and then push my code again with the same to the same branch name? |
| 10:10 |
dbs_ |
yboston: or you could force-push it "git push -f working local_branch:remote_branch" |
| 10:10 |
kmlussier |
yboston: I usually force push it to the same branch. Add --force at the end of the command you use when pushing to the working repository. |
| 10:10 |
kmlussier |
Or do what dbs says. ;) |
| 10:10 |
yboston |
thank you both |
| 10:11 |
dbs |
kmlussier++ |
| 10:11 |
dbs |
bshum: yes, indeed, one release notes entry for all the discoverability-related stuff is the plan :) |
| 10:11 |
dbs |
bshum++ |
| 10:11 |
bshum |
dbs++ # cool deal :) |
| 10:13 |
|
finnx joined #evergreen |
| 10:13 |
Dyrcona |
I force push unless I know someone has checked out the branch. |
| 10:13 |
Dyrcona |
I almost never force push collab branches. |
| 10:15 |
yboston |
another quick question; often I see that working branches feature the LP bug number in their name; that makes perfect sense. I have a working branch for a whishlist LP bug, not sure if it would be best recreate the branch and then add the bug number. I do plan to mention the bug number in the commit message |
| 10:16 |
bshum |
That's preference for the branch name. Not required, but possibly helpful. |
| 10:16 |
Dyrcona |
yboston: I would recreate the branch with the lp# in the name. |
| 10:16 |
Dyrcona |
Then update the bug accordingly. |
| 10:17 |
Dyrcona |
You can change branch names when you push, btw. |
| 10:17 |
yboston |
Dyrcona: that is what I thought, the more info the better |
| 10:17 |
Dyrcona |
Technically, you are changing the name when do user/yboston/branch |
| 10:18 |
Dyrcona |
If I've created fix_branch locally, I'll push like so after creating the launchpad bug so I have the number: git push working fix_branch:user/dyrcona/lp#######_fix_branch |
| 10:18 |
Dyrcona |
OR something like that. |
| 10:18 |
yboston |
I was just wondering if it might be overkill for a wishlist bug, but I can see how it is always helpful to point back to LP |
| 10:18 |
Dyrcona |
I do it for wishlist bugs, too. |
| 10:19 |
yboston |
Dyrcona: thanks |
| 10:19 |
Dyrcona |
We also prefer to have the LP# in the top line of the commit message. |
| 10:19 |
Dyrcona |
You can edit commits with git commit --amend, or do a rebase -i and edit the commit. |
| 10:19 |
yboston |
in this case I had already pushed my code to working without the LP number, was not sure if it was overkilll to redo it with the LP |
| 10:20 |
Dyrcona |
We can let it slide, this time. :p |
| 10:20 |
yboston |
now I was planning to delete the old branch without the LP number that was pushed to working, unless that is overkill |
| 10:20 |
bshum |
When I review patches, I'll often amend the first line of the commit to make it include the LP if not already there. |
| 10:20 |
Dyrcona |
That would be fine. I have deleted a couple of remote branches for similar reasons, but don't do it very often. |
| 10:20 |
yboston |
Dyrcona: thanks, but “lucky for me” I found other things to fix besides the branch name |
| 10:21 |
|
finnx left #evergreen |
| 10:21 |
bshum |
Keeping things presentable and tidy makes for happier reviewing though. :) |
| 10:21 |
Dyrcona |
On an unrelated note, I gathered some statistics from our cstore issues for a meeting this afternoon. |
| 10:22 |
Dyrcona |
From 12/12 @ 10:45 am through 01/27 @ 15:30, we averaged 72.5 cstore drones per minute. |
| 10:22 |
|
finnx joined #evergreen |
| 10:22 |
Dyrcona |
Since 01/27 @ 15:30, we have averaged 14.6 cstore drones per minute. |
| 10:23 |
kmlussier |
yboston++ #digging into git |
| 10:24 |
|
finnx joined #evergreen |
| 10:25 |
|
finnx joined #evergreen |
| 10:26 |
bshum |
Dyrcona++ # that looks like an improvement to me ;) |
| 10:26 |
|
finnx joined #evergreen |
| 10:27 |
|
finnx left #evergreen |
| 10:27 |
csharp |
Dyrcona++ |
| 10:27 |
Dyrcona |
Yep. Our patrons really like to manage their circulations in the OPAC. That's a good thing! |
| 10:32 |
|
dreuther joined #evergreen |
| 10:57 |
* kmlussier |
questions whether non-parted is an actual word, but decides to use it in a bug report anyway. |
| 10:57 |
gmcharlt |
kmlussier: it is NOW! |
| 10:57 |
gmcharlt |
:) |
| 11:00 |
Dyrcona |
Hyphenated words are always words. |
| 11:02 |
berick |
ceci-n'est-pas-un-mot |
| 11:03 |
berick |
<--dork |
| 11:03 |
jonadab |
I'm told transliterated Arabic has hyphenated words out the al-wa-zoot-ee. |
| 11:03 |
jonadab |
Whatever that means. |
| 11:04 |
berick |
heh |
| 11:04 |
Dyrcona |
berick++ |
| 11:04 |
Dyrcona |
German just jams nouns together to make new words. |
| 11:07 |
Dyrcona |
Schokoladepuddingsfabriklandsgearbeiter |
| 11:07 |
jeff |
i prefer my pudding to remain distinct from my fabric softener. |
| 11:07 |
Dyrcona |
heh |
| 11:08 |
Dyrcona |
Grounds keeper at a chocolate pudding factory. :) |
| 11:08 |
Dyrcona |
I prefer not to think of my chocolate pudding as coming from a factory. ;) |
| 11:08 |
* jonadab |
hits the brown pudding with a thoroughly corrided -3 knife. |
| 11:08 |
jonadab |
*corroded |
| 11:09 |
Dyrcona |
*Rolls d20* |
| 11:09 |
Dyrcona |
The brown pudding dissolves the knife. |
| 11:09 |
jonadab |
That sounds like something GruntHack would implement. |
| 11:10 |
* Dyrcona |
will DM for beer. :) |
| 11:10 |
bshum |
@roll 1d20 |
| 11:10 |
pinesol_green |
bshum: well, that's what you get for not being a shell script |
| 11:10 |
bshum |
Aww |
| 11:10 |
bshum |
Oh dice maybe |
| 11:10 |
bshum |
@dice 1d20 |
| 11:10 |
pinesol_green |
bshum: 6 |
| 11:10 |
bshum |
Miss anyways |
| 11:13 |
|
vlewis joined #evergreen |
| 11:15 |
Dyrcona |
I like that response. |
| 11:15 |
Dyrcona |
@dnd |
| 11:15 |
pinesol_green |
Dyrcona: strength:10 dexterity:13 constitution:10 intelligence:13 wisdom:13 charisma:12 |
| 11:16 |
Dyrcona |
Joe Just-slightly-better-than-average |
| 11:17 |
|
mdriscoll joined #evergreen |
| 11:17 |
bshum |
Looks like one of my bards. 13's and 10's all the way. |
| 11:19 |
Dyrcona |
Good stats for a NPC-class: Adept or something like that. |
| 11:19 |
Dyrcona |
I prefer point buy systems over rolling dice for stats. |
| 11:21 |
|
bmills joined #evergreen |
| 11:35 |
|
dMiller_ joined #evergreen |
| 11:54 |
kmlussier |
@sortinghat |
| 11:54 |
pinesol_green |
Hmm... kmlussier... Let me see now... GRYFFINDOR! |
| 11:57 |
kmlussier |
We've had a frequent request from libraries that the "Show" link that displays under available copies when you are scoped to a specific ou should also display when there are no available copies. |
| 11:57 |
kmlussier |
Has anyone had a similar request for their libraries? I'm trying to think of a good place to put it. |
| 11:57 |
csharp |
@sortinghat |
| 11:57 |
pinesol_green |
Hmm... csharp... Let me see now... SLYTHERIN! |
| 11:57 |
csharp |
muhahaha |
| 11:58 |
kmlussier |
csharp: I always knew you were secretly evil. |
| 11:58 |
csharp |
@who is secretly evil? |
| 11:58 |
pinesol_green |
_bott_ is secretly evil. |
| 11:59 |
csharp |
@who is secretly eeevil? |
| 11:59 |
pinesol_green |
jeffdavis is secretly eeevil. |
| 11:59 |
kmlussier |
Heh |
| 12:00 |
|
bmills joined #evergreen |
| 12:00 |
csharp |
kmlussier: I would suggest you ask that question on the general list - Terran is continually reviewing such questions for the PINES opac |
| 12:00 |
|
bmills joined #evergreen |
| 12:00 |
kmlussier |
Looking at catalog.mvlc.org/eg/opac/record/673601?locg=5 as an example, what if the "29 total copies" was a link to all of the copies. |
| 12:00 |
kmlussier |
csharp: Yeah, I think I'll do that. |
| 12:11 |
jeffdavis |
Hmm, I see my secret's out. |
| 12:11 |
csharp |
jeffdavis++ |
| 12:12 |
eeevil |
jeffdavis: SHHHHHHH |
| 12:14 |
mmorgan |
We are investigating aging circulations. Any guidelines? Advice? Cautionary tales? |
| 12:19 |
csharp |
mmorgan: in our case, we set the cutoff based on the PINES Executive Commmittee's judgment and deleted the circs |
| 12:19 |
csharp |
mmorgan: the only fallout was that some of our libraries use forgive payments to track patrons in collections |
| 12:20 |
csharp |
so you might formulate your query to exclude circs like that (if your libraries do similar) |
| 12:21 |
mmorgan |
So when the circs are deleted, billings and payments also get deleted? |
| 12:22 |
csharp |
no, but they are no longer attached to active circulations |
| 12:22 |
mmorgan |
Ah ok, gotcha |
| 12:22 |
csharp |
I'm looking for the query we used... |
| 12:23 |
Dyrcona |
"some of our libraries use forgive payments to track patrons in collections" That speaks volumes right there about humans and software. |
| 12:23 |
csharp |
Dyrcona: absolutely |
| 12:23 |
csharp |
it *never* occurred to us that they would do that |
| 12:23 |
Dyrcona |
It should *never* have occurred to them, either. ;) |
| 12:23 |
csharp |
heh |
| 12:24 |
|
yboston joined #evergreen |
| 12:28 |
|
kitteh_ joined #evergreen |
| 12:32 |
jeff |
csharp: how were they using forgive payments to track patrons in collections? |
| 12:32 |
mmorgan |
Any problems with lost statistical information for aged circs? We're aware of lp 1394356 for purged patrons. |
| 12:32 |
pinesol_green |
Launchpad bug 1394356 in Evergreen 2.6 "Circulations anonymized via user purge missing post code" (affected: 1, heat: 6) [Undecided,Fix released] https://launchpad.net/bugs/1394356 |
| 12:32 |
* Dyrcona |
doesn't want to know, just accepts that they were in come convoluted fashion that people invent when they don't know what they are doing. |
| 12:33 |
Dyrcona |
s/come/some/ |
| 12:33 |
csharp |
jeff: it may not have been collections - I think it was actually the mind-boggling concept of "unrecovered debt" that they were/are addressing that way |
| 12:33 |
Dyrcona |
mmorgan: You want to make sure that the patron stat cats you are interested in are archived. |
| 12:34 |
mmorgan |
Dyrcona: Yes, we actually have all stat cats set to archive. |
| 12:34 |
csharp |
jeff: they "forgive" the fines with a note that says "unrecovered" or something like that, then place alerts on the patron account, then, when the patron comes back in they can see from the billing history how much they still owe |
| 12:34 |
Dyrcona |
And every time they do that a kitten dies. |
| 12:35 |
csharp |
that allows the money to be "off the books" but still actually owed if the patron ever comes back |
| 12:35 |
csharp |
I'm sure accountants/auditors weep over this kind of thing too ;-) |
| 12:36 |
Dyrcona |
I'm sure they'd weep over what Evergreen does with money in general. |
| 12:36 |
jeff |
csharp: i recently encountered something like that. alert messages saying "patron still owes for foo and bar" where "foo and bar" had been checked in and the billings no longer outstanding. it was due to limitations of a legacy system. |
| 12:36 |
csharp |
mmorgan: yes - you do want to use the library setting to keep stat cats |
| 12:36 |
Dyrcona |
And, that is related to something that I wanted to bring up at the dev meeting actually. |
| 12:37 |
Dyrcona |
But, I'll wait since that gives more time for thought and reflection. |
| 12:37 |
Dyrcona |
Right now, I think I'll give commit a1f4d11684ba25c38eb443710482e2f04350958b a whirl. |
| 12:38 |
csharp |
jeff: yeah - many staff members don't realize that if they just let us know that there's a need, we can work out a process or workflow to solve the problem (whether software-related or not) ;-) |
| 12:39 |
|
mrpeters joined #evergreen |
| 12:39 |
mmorgan |
csharp: Is there also a library setting to keep stats? I was looking at the "Circ Archive" flag on statistical categories. |
| 12:39 |
csharp |
mmorgan: yeah - sorry - that's what I meant |
| 12:40 |
mmorgan |
ok, thanks. Got that covered :) |
| 12:41 |
Dyrcona |
Hmm.. Doesn't look like requires a new client, just throw the file in the right place on the server. |
| 12:41 |
* Dyrcona |
gives that a shot. |
| 12:44 |
dbwells |
berick: jeff: It was posted a few weeks ago on the cond. neg. balances bug, but certainly may have been missed. Since I saw it on the agenda, I thought I'd point you guys to the cstore branch in case you wanted to do anything with it in the next couple hours :) http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dbwells/1198465_cstore_fines_gen |
| 12:45 |
gsams |
kmlussier: In our catalog the (Show) link pops up in multiple places doing what I suspect you would prefer. |
| 12:45 |
dbwells |
berick: jeff: I also just pushed a small fix to a penalty generation bug eeevil pointed out in IRC a week or two back. |
| 12:45 |
eeevil |
dbwells++ |
| 12:47 |
dbwells |
Turned out to be even simpler than I thought, since that code was already set up to allow an optional editor argument. |
| 12:47 |
jeff |
dbwells++ thanks! i was finally looking at that collab branch. |
| 12:52 |
gmcharlt |
bounced Apache on lupin |
| 12:52 |
Dyrcona |
ldw: You might want to sign off on the that commit I mentioned above. |
| 12:52 |
Dyrcona |
"the that" take your pick! |
| 12:52 |
Dyrcona |
:( |
| 12:54 |
Dyrcona |
Hmm. The web is the perfect medium for choose your own adventure but that genre seems to have died off..... |
| 12:54 |
Dyrcona |
Oh wait. That's now called Google with safe mode turned off. |
| 12:54 |
|
TaraC joined #evergreen |
| 12:55 |
gmcharlt |
Dyrcona: I was about to respond seriously... interactive fiction |
| 12:55 |
gmcharlt |
;) |
| 12:55 |
Dyrcona |
gmcharlt: Yep. I never see much of that. I think MORPGs kinda took over. |
| 12:57 |
gmcharlt |
dear server in the Ukraine whose spending all your time posting to /wp-login.php -- go away |
| 12:57 |
* Dyrcona |
remembers MUDs fondly, or not so fondly considering the time sink. ;) |
| 12:57 |
Dyrcona |
I get that all the time and I don't run word press. :) |
| 13:04 |
|
kitteh_ joined #evergreen |
| 13:16 |
dbs |
Dyrcona: one second, just last week I saw a link to classic choose your own adventures that had been posted online |
| 13:18 |
dbs |
http://www.cyoa.com/collections/classics?page=1 was not what I was thinking of ? |
| 13:29 |
Dyrcona |
Heh. I remember a couple of those. |
| 13:33 |
jonadab |
Ugh, R.A. Montgomery. |
| 13:34 |
jonadab |
He was so focused on ramping up the number of possible endings, an individual story was never more than about six pages long. |
| 13:34 |
kmlussier |
gsams: Thanks, I'll take a look! |
| 13:35 |
jonadab |
Edward Packard's books were so much better. |
| 13:36 |
jonadab |
These ones: http://www.goodreads.com/author/show/35422.Edward_Packard |
| 13:37 |
Dyrcona |
I remember more of those. |
| 13:38 |
Dyrcona |
The Cave of Time and The Mystery of Chimney Rock, I remember as being awesome. |
| 13:44 |
jonadab |
I think I got the Cave of Time from a library once, don't think I ever read Chimney Rock. Probably still have You Are A Shark and Underground Kingdom at home someplace. |
| 13:46 |
dbs |
Ah, "Your Code Name is Jonah" may have been the first I read |
| 13:46 |
jonadab |
Oh, yeah, I read that one at one point too. |
| 13:46 |
jonadab |
Oh, and I think I had the Third Planet from Altair at some point. |
| 13:48 |
dbs |
Definitely had the Third Planet from Altair |
| 13:49 |
kmlussier |
I liked Space and Beyond, but I think the cover looked a bit different |
| 13:49 |
kmlussier |
Oh yeah, and the Third Planet from Altair. |
| 13:50 |
kmlussier |
My kids read a bunch of them too. We picked them up at a library book sale. |
| 13:52 |
jonadab |
Packard's books had a tendency to bring divergent paths back together, so as to get more mileage out of the pages and thus longer stories average. |
| 14:04 |
|
akilsdonk joined #evergreen |
| 14:26 |
|
graced joined #evergreen |
| 14:29 |
|
DPearl joined #evergreen |
| 14:49 |
|
collum|2 joined #evergreen |
| 14:49 |
|
julialima_ joined #evergreen |
| 14:50 |
|
BigRig_ joined #evergreen |
| 14:59 |
berick |
can we get a volunteer to chair the dev meeting? |
| 14:59 |
bshum |
berick: I can do it. |
| 15:00 |
berick |
bshum++ |
| 15:00 |
DPearl |
bshum++ |
| 15:00 |
* jeff |
quickly erases line and increments bshum instead |
| 15:00 |
bshum |
#startmeeting 2015-02-17 - Developer Meeting |
| 15:00 |
pinesol_green |
Meeting started Tue Feb 17 15:00:22 2015 US/Eastern. The chair is bshum. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 15:00 |
pinesol_green |
Useful Commands: #action #agreed #help #info #idea #link #topic. |
| 15:00 |
pinesol_green |
The meeting name has been set to '2015_02_17___developer_meeting' |
| 15:00 |
jeff |
bshum++ |
| 15:00 |
bshum |
#topic Welcome and introductions |
| 15:00 |
bshum |
#info bshum = Ben Shum, Bibliomation |
| 15:00 |
gmcharlt |
#info gmcharlt = Galen Charlton, ESI |
| 15:01 |
DPearl |
#info DPearl = Dan Pearl, C/W MARS |
| 15:01 |
berick |
#info berick Bill Erickson, KCLS |
| 15:01 |
julialima_ |
#info julialima_ = Julia Lima. UI Style Guide (OPW), Argentina. |
| 15:01 |
bshum |
#link Agenda: http://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2015-02-17 |
| 15:01 |
jeff |
#info jeff = Jeff Godin, Traverse Area District Library (TADL) |
| 15:01 |
dbwells |
#info dbwells = Dan Wells, Hekman Library (Calvin College) |
| 15:01 |
remingtron |
#info remingtron = Remington Steed, Hekman Library (Calvin College) |
| 15:01 |
phasefx |
#info phasefx = Jason Etheridge, ESI |
| 15:02 |
bshum |
Alrighty, well, as others come along, feel free to add yourselves. We'll move on for now. |
| 15:03 |
bshum |
#topic Action items from last meeting |
| 15:03 |
bshum |
#info dbwells will separate the cstore billing code into a separate bug; jeff and berick will help with testing |
| 15:03 |
kmlussier |
#info kmlussier is Kathy Lussier - MassLNC |
| 15:03 |
bshum |
Any report on that? |
| 15:03 |
berick |
#info dbwells posted collab/dbwells/1198465_cstore_fines_gen -- I have not done any testing yet |
| 15:04 |
jeff |
i can confirm that dbwells has a working branch with said separation and that i'm still planning to test -- sooner than later. |
| 15:04 |
eeevil |
#info eeevil = Mike Rylander, ESI |
| 15:04 |
Bmagic |
#info bmagic is Blake GH - MOBIUS |
| 15:04 |
dbwells |
I did split it, but I also did a bad job at bothering people about it. |
| 15:04 |
eeevil |
(I added a couple things to the agenda at the last moment ... sorry) |
| 15:04 |
bshum |
Alrighty, I think we can leave it off the meeting action items. Hopefully you guys can test it out before the beta cutoff? :) |
| 15:04 |
kmlussier |
We have it loaded on a test server at MassLNC, but I've only looked at it quickly. I'm planning to take a closer look this week. |
| 15:05 |
bshum |
#info Testing to continue. |
| 15:05 |
berick |
one sec... |
| 15:05 |
dbwells |
kmlussier: I did push an update earlier today to fix penalty generation. Just FYI. |
| 15:05 |
kmlussier |
dbwells: OK, thanks. I' |
| 15:05 |
berick |
this branch basically blocks the pending billing code? |
| 15:05 |
kmlussier |
I'll let Dyrcona know. |
| 15:06 |
eeevil |
berick: you mean the negative balance branches? |
| 15:06 |
berick |
the conditional negative balances code? |
| 15:06 |
bshum |
eeevil: Noted, I will refresh my agenda and go from what I see then. |
| 15:06 |
berick |
eeevil: yeah |
| 15:06 |
eeevil |
I don't think so, on either, actually |
| 15:06 |
dbwells |
berick: Yes, this is a precursor to that. |
| 15:07 |
jeff |
berick: my understanding is that it is some cleanup found during conditional negative balance work, which was seen as being useful to break out on its own. |
| 15:07 |
eeevil |
well, it shouldn't block mine |
| 15:07 |
jeff |
before merge, it should probably gain a LP of its own. |
| 15:07 |
berick |
which means it needs to get merged before bug #1198465, which needs to be merged by friday. |
| 15:07 |
pinesol_green |
Launchpad bug 1198465 in Evergreen "Support for Conditional Negative Balances" (affected: 15, heat: 70) [Wishlist,Confirmed] https://launchpad.net/bugs/1198465 |
| 15:07 |
berick |
(just making sure I'm understanding right) |
| 15:08 |
dbwells |
berick: any branches on 1198465 would need to be heavily rebased after this gets in. These change were all mixed into that code, so this was an attempt to make it more bite sized. |
| 15:08 |
dbs |
#info dbs = Dan Scott, Laurentian University |
| 15:09 |
berick |
dbwells: that's fine. i'm just trying to make sure we're on the same page as far as order of events and when they need to get done |
| 15:10 |
bshum |
Alrighty. |
| 15:10 |
dbwells |
berick: Right. I can try to make that more clear on the bug page. |
| 15:11 |
bshum |
Okay then. |
| 15:12 |
bshum |
#topic OpenSRF release |
| 15:12 |
gmcharlt |
so, a couple things about that |
| 15:12 |
gmcharlt |
I've got some WIP for improving osrf_control --diagnostic |
| 15:12 |
gmcharlt |
and the incipient pound proxy example config |
| 15:12 |
gmcharlt |
stuff that warrants a 2.4.next in March |
| 15:13 |
gmcharlt |
but I want to ask others: any other pending stuff that folks would want to target for a March release? |
| 15:13 |
* bshum |
assumes the pound proxy example config is in reference to getting websockets happier with standard ports? |
| 15:13 |
gmcharlt |
yep |
| 15:14 |
bshum |
Sweet, gmcharlt++ # looking forward to testing those things out. |
| 15:15 |
bshum |
#info gmcharlt with new WIP for improving osrf_control --diagnostic and pound proxy example config for websockets in upcoming OpenSRF release. |
| 15:16 |
bshum |
... anything else on OpenSRF? |
| 15:16 |
bshum |
Do we want to assign an action for 2.4.1 cutting? |
| 15:17 |
|
bibliophylum joined #evergreen |
| 15:17 |
gmcharlt |
bshum: go for it |
| 15:17 |
gmcharlt |
you have... THE POWER |
| 15:17 |
bshum |
@who will have the last say about cutting OpenSRF 2.4.1 |
| 15:17 |
pinesol_green |
artunit will have the last say about cutting OpenSRF 2.4.1. |
| 15:18 |
bshum |
Well anyways |
| 15:18 |
gmcharlt |
seriously, I'll accept an action item :) |
| 15:18 |
bshum |
#action gmcharlt will cut OpenSRF 2.4.1 in March once new features are pushed. |
| 15:18 |
bshum |
Thanks gmcharlt |
| 15:18 |
bshum |
;) |
| 15:18 |
bshum |
Alrighty, moving along |
| 15:19 |
bshum |
#topic Evergreen release (web client help) |
| 15:19 |
bshum |
eeevil: I think this is one of your topics? |
| 15:19 |
eeevil |
yes. |
| 15:19 |
eeevil |
in particular, we are embedding many interfaces so we can get to a web client faster |
| 15:20 |
eeevil |
and there's an opportunity for folks to jump in by reimplementing them in angularjs |
| 15:20 |
jeff |
currently no work is in progress for the patron editor, for example (unless i'm wrong). |
| 15:20 |
|
dkyle1 joined #evergreen |
| 15:20 |
eeevil |
for instance, the user editor/registration screen, and the user permission editor |
| 15:20 |
eeevil |
jeff: zackly |
| 15:22 |
eeevil |
these are things that can be worked on essentially in isolation, without concern for breaking work already done or planned |
| 15:22 |
eeevil |
they'd be good learning projects |
| 15:23 |
eeevil |
so ... that's pretty much it :) |
| 15:23 |
* bshum |
tries crafting an entry for the notes. |
| 15:23 |
Bmagic |
The user permission editor has bugs for sure, hopefully the reimplementation would do something about that. I am interested in helping but I don't know what sort of time we are looking at |
| 15:23 |
|
julialima_ joined #evergreen |
| 15:23 |
* gmcharlt |
woudl be more than happy to give some pointers and review code for anybody who wants to take a crack at any of this |
| 15:23 |
dbs |
So, "Hi community, please plan amongst yourselves to implement the things that some subset of us are not planning on implementing"? |
| 15:23 |
bshum |
#help Looking for intrepid folks interested to help in rewriting certain embedded interfaces to angularjs. (like the user editor/registration screen, user permission editor) |
| 15:24 |
dbs |
If there's a published plan for what those who are working on the current web client are planning on implmeenting so that we don't tread on those toes, that would be helpful |
| 15:24 |
jeff |
i'm interested and i know there's interest here in having more of the "embedded legacy" web interfaces... modernized. |
| 15:24 |
* dbs |
wants to create a simple hours-of-operation UI |
| 15:24 |
eeevil |
dbs: "hi community, please feel free to jump in and start working in parallel on things that you all agreed could be pulled over in the interest of expedience" |
| 15:25 |
kmlussier |
Yes, there is strong interest here in having those interfaces modernized too. The patron editor being the most critical among them. |
| 15:26 |
Bmagic |
I don't want to commit to something that I can't finish inside of a timetable |
| 15:26 |
jeff |
http://wiki.evergreen-ils.org/doku.php?id=dev:browser_staff:dev_sprints is the current best resource for "these are the things that are planned to be worked on", but I don't know if that's the place for coordination. |
| 15:26 |
eeevil |
dbs: there are exactly such published plans |
| 15:27 |
eeevil |
NTS: start crossing stuff off sprint2 :) |
| 15:28 |
jeffdavis |
Can we add jeff's link to the minutes if it's the de facto roadmap for web client dev? |
| 15:28 |
bshum |
jeffdavis: Seems like a good idea to me. If that's what we're going to check towards. |
| 15:28 |
kmlussier |
I don't know if that particular link is helpful. It doesn't note the interfaces that were carried over, as is. |
| 15:29 |
bshum |
kmlussier: Good point :) |
| 15:29 |
eeevil |
jeffdavis: it is the roadmap |
| 15:29 |
dbs |
eeevil: so jeff's link (to a page with no title, and which has exactly one line--from the DIG doc planning page) are the published plans? |
| 15:29 |
kmlussier |
Would it be helpful to have somebody identify the interfaces that need to be angularized on a wiki page? |
| 15:29 |
dbs |
s/line/link/ |
| 15:29 |
berick |
kmlussier: they are marked on there |
| 15:29 |
eeevil |
kmlussier: it does ... if it's got a * by it, we pulled the existing version |
| 15:29 |
bshum |
*, gotcha |
| 15:29 |
kmlussier |
Ah, ok. I didn't scroll down to the bottom of the page. |
| 15:30 |
eeevil |
dbs: ? ... his link brings you to a page of links |
| 15:30 |
dbs |
eeevil: one backlink from the entire wiki: http://wiki.evergreen-ils.org/doku.php?id=dev:browser_staff:dev_sprints&do=backlink |
| 15:30 |
jeff |
"where can I start to learn and contribute without colliding with existing planned work" has been on my mind, so I'm interested in working on those suggested interfaces above, but can't commit off the cuff to specifics. sounds like that's me, bshum, Bmagic and gmcharlt offering to do some mentoring/guidance |
| 15:31 |
dbs |
I'm just confirming that's the page. Sounds like it is, and now we can give it more visibility. |
| 15:31 |
eeevil |
dbs: sorry, I'm not following. if you go to http://wiki.evergreen-ils.org/doku.php?id=dev:browser_staff:dev_sprints you will see sprints 1-4 documented |
| 15:32 |
eeevil |
I'm happy to provide guidance as well. and berick has been responsive (thanks!) |
| 15:32 |
kmlussier |
eeevil: Yeah, I think he's saying that the docs page is the only page that links to that page and that we need to increase the visibility of the dev sprints page. |
| 15:32 |
jeff |
yes, berick++ -- already helpful just in getting things running for training here |
| 15:33 |
kmlussier |
Sorry, I don't think that last statement from me made any sense. |
| 15:33 |
eeevil |
kmlussier: ah, gotcha. |
| 15:33 |
berick |
jeff++ # taking the plunge! |
| 15:33 |
bshum |
Okay folks, so, let's use that page as a starting point for coordinating some of this. Or at least noting areas that can use help. |
| 15:33 |
* dbs |
has added a title and brief description to the page |
| 15:33 |
bshum |
Anything else about web client work before we move along? |
| 15:34 |
eeevil |
dbs: thanks. IIRC, that's be posted to the lists a few times ... maybe |
| 15:34 |
jeff |
the existing dev sprints page reflects / is influenced by the fact that most/all of the work so far has been the community funding ESI performing the work. now that that's likely to change (with more contributions), i expect the page will change also. |
| 15:34 |
eeevil |
bshum: not from me, thanks |
| 15:34 |
jeff |
dbs++ edits |
| 15:34 |
bshum |
Alrighty, berick you're up next with... |
| 15:35 |
bshum |
#topic Evergreen 2.8 |
| 15:35 |
berick |
ok, i posted a list of reminders in the agenda |
| 15:35 |
berick |
most notable of course is the pending feature merge cut-off this friday |
| 15:36 |
bshum |
#info 2.8 Beta *features* merge cut-off is Friday, February 20, 2015. |
| 15:36 |
gmcharlt |
speaking of which - just so there are no surprises, the one feature we'd like some leeway re merging is message center (bug 1410369) |
| 15:36 |
pinesol_green |
Launchpad bug 1410369 in Evergreen "Message Center for the Public Catalog" (affected: 1, heat: 6) [Wishlist,New] https://launchpad.net/bugs/1410369 - Assigned to Jason Etheridge (phasefx) |
| 15:36 |
gmcharlt |
it will be complete with a pull request tomorrow afternoon |
| 15:37 |
jeffdavis |
I don't see bug 1410537 on either of those feature-related LP search results - presumably because it doesn't have a pullrequest tag |
| 15:37 |
pinesol_green |
Launchpad bug 1410537 in Evergreen "Overdrive API integration" (affected: 2, heat: 12) [Wishlist,Triaged] https://launchpad.net/bugs/1410537 |
| 15:37 |
berick |
jeffdavis: yeah, the lists I posted filtered on pullrequests |
| 15:37 |
jeffdavis |
Has anyone had a chance to look at it (besides hbrennan)? I'm assuming it hasn't had enough eyeballs to get in to 2.8 |
| 15:37 |
berick |
gmcharlt: re merging? |
| 15:37 |
berick |
ohh |
| 15:37 |
berick |
re:.. merging |
| 15:38 |
berick |
<-- slow |
| 15:38 |
gmcharlt |
berick: well, a quick review to be clear |
| 15:38 |
Bmagic |
Im sure no one looked at this one https://bugs.launchpad.net/evergreen/+bug/1174498 |
| 15:38 |
pinesol_green |
Launchpad bug 1174498 in Evergreen "Payment by billing type breakdown" (affected: 7, heat: 38) [Wishlist,In progress] - Assigned to Jeff Godin (jgodin) |
| 15:38 |
bshum |
jeffdavis: I actually got my Overdrive API test key last week. So I might look more closely soon, but not sure if it'll be in time for Friday :\ |
| 15:38 |
gmcharlt |
jeffdavis: I'd look at it when you mentioend it (last month? how time flies); have you made any tweaks since then? |
| 15:39 |
jeff |
Bmagic: i have concerns about payment by billing type interaction with some other billing changes -- it currently can be wrong about things with regard to future-dated overdues. |
| 15:39 |
jeffdavis |
gmcharlt: no, no changes since then |
| 15:39 |
Bmagic |
jeff: this is a materialized table |
| 15:39 |
jeff |
Bmagic: right. i'm familiar with it. :-) |
| 15:40 |
gmcharlt |
jeffdavis: I'm not sure about 2.8, but I'd be willing to give it some time to toughen it up against DOM changes and set it up as a contrib |
| 15:40 |
gmcharlt |
I think the main blocker for that, though, would be clarifying the license? |
| 15:41 |
berick |
gmcharlt: i'd be up for some horsetrading. 1171984 for 1410369 |
| 15:41 |
jeffdavis |
It's MIT licensed and my employer owns the copyright. |
| 15:42 |
gmcharlt |
jeffdavis: I think some concerns about work-for-hire were expessed -- but I think that's OK for it living as a contrib |
| 15:42 |
kmlussier |
We also have some people lined up here to look at 1410369. |
| 15:42 |
bshum |
In the interests of finishing up this meeting, I'm going to ask us to delay discussions on specific features / requests for 2.8 post-meeting. I'll give it a moment to wrap up last typing. |
| 15:42 |
gmcharlt |
berick: you've got a deal; I'll start testing that tomorrow |
| 15:43 |
berick |
gmcharlt++ # point me at the branch when it's published |
| 15:43 |
bshum |
berick: Anything else about 2.8 beta before we move on? |
| 15:43 |
gmcharlt |
berick: will do |
| 15:43 |
berick |
and kmlussier's testing is welcome :) |
| 15:43 |
berick |
bshum: one last thing. |
| 15:43 |
kmlussier |
berick: The more the merrier. :) |
| 15:44 |
berick |
i want to reiterate that any testing we can do with master between Friday and next Wednesday (beta release) is greatly apprecaited |
| 15:44 |
berick |
to reduce the amount of beta bugs |
| 15:44 |
berick |
or bug fix merges, for that matter |
| 15:45 |
berick |
i'll try to finalize the DB upgrade script well before wednesday, too, for eyes |
| 15:45 |
jeff |
berick++ |
| 15:45 |
bshum |
#info Beta release cut on Wednesday, February 25 |
| 15:45 |
bshum |
#help Please help test between beta deadline and cut to minimize bugs in beta. And also help with bug fixes in general. |
| 15:46 |
bshum |
berick++ |
| 15:46 |
bshum |
Alrighty. |
| 15:46 |
bshum |
#topic OPW Progress Report |
| 15:46 |
dbwells |
The OPW group would like to update the community on the progress of the Evergreen Style Guide project. Our intern julialima_ has joined us today to give the update. |
| 15:47 |
julialima_ |
We have been working very hard and we have made a lot of progress. |
| 15:47 |
julialima_ |
We are focused mainly in ensuring consistency and providing the best user experience we can. Of course it is a working progress, we are still testing some ideas and thinking new solutions for different situations. We still have 3 weeks until my internship is finished so we have a lot of time to try new things. |
| 15:48 |
julialima_ |
You can find the UI style guide in https://github.com/JuliaLima/Evergreen/tree/patch-1/docs/style_guide, remember that we are working on it, and also you can check in my blog for updates about our progress: http://lima-julia.tumblr.com/EG-style-guide. |
| 15:48 |
julialima_ |
Feel free to contact us and give your opinion, we need your feedback in order to improve our work, it is very important for us. |
| 15:49 |
kmlussier |
julialima_ / dbwells: I can't remember. Have the links to the blog and github repo been posted to the mailing list yet? |
| 15:49 |
bshum |
#link Style guide: https://github.com/JuliaLima/Evergreen/tree/patch-1/docs/style_guide |
| 15:49 |
bshum |
#link Blog: http://lima-julia.tumblr.com/EG-style-guide |
| 15:50 |
dbwells |
kmlussier: I can't recall either, but I'd say the blog more likely than the github repo. We could certainly post them again. |
| 15:50 |
kmlussier |
Sure. I know there have been a lot of discussions in here, but the mailing list post might reach some people who don't venture into IRC. |
| 15:51 |
dbwells |
#action julialima_ will send a similar update with links to the mailing list |
| 15:51 |
dbwells |
:) |
| 15:51 |
kmlussier |
dbwells: Thanks! :) |
| 15:51 |
bshum |
julialima_++ # thanks for the update! |
| 15:51 |
julialima_ |
:) |
| 15:51 |
kmlussier |
julialima++ dbwells++ |
| 15:51 |
bshum |
Any other questions or comments on OPW before we move on? |
| 15:52 |
bshum |
dbwells++ too :) |
| 15:52 |
dbs |
julialima_: is there anything you need or want from us other than feedback? |
| 15:52 |
jeff |
julialima_++ dbwells++ |
| 15:53 |
julialima_ |
dbs: I think that your feedback is the most important thing we need now. |
| 15:54 |
bshum |
Okie dokey then. |
| 15:54 |
bshum |
#topic Google Summer of Code 2015 |
| 15:54 |
* bshum |
takes a deep breath. |
| 15:55 |
kmlussier |
I added that item to the agenda to see if there was interested in applying for GSoC this year. |
| 15:56 |
kmlussier |
We came up with a few solid ideas for coding projects for OPW, and I could see us building off of that list if there are devs who have time to mentor. |
| 15:57 |
kmlussier |
We've also heard from a couple of potential OPW candidates over the past month who have been interested in some of those projects. |
| 15:58 |
bshum |
So I see three coding ideas on that page http://wiki.evergreen-ils.org/doku.php?id=opw#coding |
| 15:59 |
bshum |
Do the potential dev mentors for any of those projects want to reaffirm their interest in helping if we do decide to try using them as a baseline. Or any other good ideas? |
| 15:59 |
* bshum |
is generally okay with the idea, but isn't sure we have enough ideas / interest from the developers to mentor coding projects. |
| 16:00 |
* bshum |
isn't ready to stand alone on that front either (since he notices now that his name is on two of those ideas) |
| 16:00 |
jeff |
i wondered if you were going to notice that. :-) |
| 16:00 |
gmcharlt |
heh |
| 16:00 |
kmlussier |
Ha ha. It's all on you bshum |
| 16:00 |
* gmcharlt |
is going to make a firm stand: I've got too much on my plate this summer, and do not put my name forward as a mentor |
| 16:01 |
* bshum |
wonders if anyone else has the chops/time to mentor on angularjs rewriting (which is basically the first idea) |
| 16:01 |
kmlussier |
It sounds like it's a resounding 'no' for this round? |
| 16:02 |
bshum |
Seems quiet. |
| 16:03 |
bshum |
Alrighty then... |
| 16:03 |
berick |
a little too quiet |
| 16:03 |
dbs |
We don't use the self-check currently, so.. |
| 16:03 |
berick |
dang, too late |
| 16:03 |
dbs |
I could still help with responsive design, round 34 |
| 16:04 |
dbs |
But I fear all of the overhead associated with GSoC applications, etc is not appealing |
| 16:05 |
kmlussier |
I would be willing to co-admin and help with applications, even though it's a very busy week, but it doesn't look like we have enough potential mentors throwing their hat in the ring. |
| 16:06 |
* dbwells |
probably should sit out mentoring for the summer as well :( |
| 16:06 |
bshum |
kmlussier: It didn't take many mentors last time we did it (there were only three who registered I think), but I'd be nervous that we don't have a lot of interest / project ideas for students to poke with. |
| 16:07 |
bshum |
Anyways, we can talk more about it post-meeting, since we're not grabbing enough solid interest. Other than dbs on responsive, whee! :) |
| 16:08 |
kmlussier |
bshum: True, but if it's just dbs and you, it looks like we would only be offering responsive design as an option. |
| 16:08 |
bshum |
Anything else for this meeting before we close? Thanks for your attention and participation. |
| 16:09 |
bshum |
Alrighty, thanks folks. |
| 16:09 |
bshum |
#endmeeting |
| 16:09 |
pinesol_green |
Meeting ended Tue Feb 17 16:09:10 2015 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
| 16:09 |
pinesol_green |
Minutes: http://evergreen-ils.org/meetings/evergreen/2015/evergreen.2015-02-17-15.00.html |
| 16:09 |
pinesol_green |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2015/evergreen.2015-02-17-15.00.txt |
| 16:09 |
pinesol_green |
Log: http://evergreen-ils.org/meetings/evergreen/2015/evergreen.2015-02-17-15.00.log.html |
| 16:09 |
kmlussier |
bshum++ |
| 16:09 |
berick |
thanks, bshum |
| 16:09 |
gmcharlt |
bshum++ |
| 16:09 |
jeff |
bshum++ |
| 16:09 |
dbwells |
bshum++ |
| 16:10 |
jeffdavis |
bshum++ |
| 16:10 |
julialima_ |
bshum++ |
| 16:10 |
dbs |
bshum++ |
| 16:10 |
kmlussier |
FWIW, the two people who recently reached out were both interested in Awesome Box. |
| 16:10 |
jeffdavis |
gmcharlt: if there are still concerns about licensing on the OD API code, could you or someone else update bug 1410537 with details on the concerns and what needs to be done? |
| 16:10 |
bshum |
I wondered if Dyrcona would still be interested in it. He didn't say anything cause I think he had a meeting conflict, but it might be worth asking. |
| 16:10 |
pinesol_green |
Launchpad bug 1410537 in Evergreen "Overdrive API integration" (affected: 2, heat: 12) [Wishlist,Triaged] https://launchpad.net/bugs/1410537 |
| 16:11 |
gmcharlt |
jeffdavis: I'll see if I can dig up the discussion |
| 16:11 |
jeffdavis |
Thanks. |
| 16:11 |
Dyrcona |
Interested in the overdrive code or something else, bshum? |
| 16:12 |
kmlussier |
Dyrcona: Awesome Box |
| 16:12 |
Dyrcona |
Yeah, I mentioned in the gsoc-evergreen channel that I'd be interested in that, but it sounds like there is otherwise not enough interest in doing GSOC this year. |
| 16:13 |
Dyrcona |
I did have a meeting conflict, but it ended before that discussion was over. |
| 16:13 |
jeffdavis |
Does anyone have a bit of time to look at bug 1400829? It's not quite a bug, not quite a feature, but would be great to get into 2.8 either way. |
| 16:13 |
pinesol_green |
Launchpad bug 1400829 in Evergreen "Cannot flag user as deleted" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1400829 |
| 16:13 |
|
eeevil joined #evergreen |
| 16:13 |
|
sarabee joined #evergreen |
| 16:14 |
jeffdavis |
I'd also love to get my fix for bug 1418772 into 2.8, but it's a bugfix so can be post-beta. Both are smal changes. |
| 16:14 |
pinesol_green |
Launchpad bug 1418772 in Evergreen "Internal server error on viewing full record when copy create_date is null" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1418772 |
| 16:14 |
jeff |
jeffdavis: in your experience, does enough of evergreen respect actor.usr.deleted? |
| 16:15 |
jeffdavis |
jeff: In our experience, yes, I think so. Our libraries flag patrons as deleted (using a custom application) regularly and things seem to work well for them. |
| 16:15 |
jeff |
jeffdavis: and, you have reasons to want to preserve-but-flag users, but you don't care about deleting the card(s) and losing reference to the barcode(s)? |
| 16:18 |
jeffdavis |
jeff: Preserve-but-flag on users is useful -- our libs often want to mark an account as deleted but may not want to completely purge all records related to it (which is the only currently available option). |
| 16:19 |
jeffdavis |
jeff: I agree fully deleting from actor.card could be problematic. Adding a deleted column and a flag_as_deleted method wouldn't be a bad approach. Purging cards works ok for us. |
| 16:20 |
jeffdavis |
I'll note as well that those functions reflect the fact that actor.usr has a rule to mark as deleted instead of actually deleting the record, whereas actor.card has no such rule. |
| 16:20 |
jeffdavis |
Which isn't much of a justification, but probably was the original source of the thinking there :) |
| 16:21 |
jeff |
jeffdavis: the other currently-available option is marking the user inactive -- it's the step we use |
| 16:22 |
jeffdavis |
We could mark cards as inactive when a patron is flagged as deleted, but that would prevent libraries from reusing their barcode which some of our libs do, I believe. |
| 16:23 |
jeff |
(it has different effects, of course) |
| 16:23 |
jeffdavis |
Yeah, I think inactive users are more retrievable within EG than we'd like, but it's certainly a valid option. |
| 16:23 |
jeff |
sorry, not trying to pick apart the branch, just taking advantage of you being present to pick your brain. |
| 16:23 |
jeffdavis |
They are good questions :) |
| 16:25 |
Dyrcona |
jeffdavis: so the problem that you are trying to solve is that you can only obliterate the patron from the staff client and not just simple flag them deleted? |
| 16:26 |
jeff |
i took it to be "short of at the database level, there's no way to set actor.usr.deleted" |
| 16:29 |
jeffdavis |
Really it's both. (I think the code may actually predate the existing Delete Patron option in the client, but we disable that locally to prevent problematic purging.) |
| 16:29 |
yboston |
berick: got a minute |
| 16:36 |
jeffdavis |
1/away afk |
| 16:46 |
|
julialima_ left #evergreen |
| 16:48 |
mdriscoll |
Dyrcona: I have been testing your code for LP#957466 today. Are you still here for a question? |
| 16:50 |
Dyrcona |
Yes. I'm here. |
| 16:50 |
mdriscoll |
If a record has a user in a 905 $u, an update to an existing record will use the 905 $u as the editor, but for a new record, the 905 $u is ignored. |
| 16:51 |
mdriscoll |
I'm not sure if it's important for update and create to work the same way. |
| 16:51 |
Dyrcona |
I'm not either, but they probably should. |
| 16:51 |
Dyrcona |
I don't know if I missed something of if it is in the database function. |
| 16:52 |
Dyrcona |
..or.. |
| 16:53 |
Dyrcona |
I can maybe take a look tomorrow. |
| 16:54 |
mdriscoll |
Ok. I'll post my comments on launchpad. For us this works great! We don't use the 905 $u. |
| 16:56 |
Dyrcona |
Well, in theory, nothing else should use 905$u, either, but in practice, I've seen all kinds of junk in incoming MARC records. ;) |
| 16:57 |
|
bmills1 joined #evergreen |
| 17:01 |
mdriscoll |
Dyrcona: in the case of marc_steam_importer, the user that the process is running as will be the creator. That's not necessarily a bad thing. Our libraries add a 990 to record the person who is uploading the record. |
| 17:02 |
Dyrcona |
mdriscoll: The focus of this change is on Vandelay. I don't know if the marc_stream_importer uses the same API underneath. |
| 17:05 |
|
mdriscoll left #evergreen |
| 17:06 |
gsams |
question on action triggers: We are having an interesting issue where if a patron has their default set to send emails for hold notifications and they change it in the request to not do this, it will still send a request. Is there a setting within action triggers that will stop this from happening? |
| 17:07 |
eeevil |
berick: I'm looking into the vandelay authority stuff, and I'm concerned about the removal of parens here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=bbcf50b073f41d399739aef7420ff27ed6650367#patch3 |
| 17:23 |
phasefx |
gsams: make sure there is the event param check_email_notify set to 1 for the definition |
| 17:24 |
mmorgan |
gsams: also remember that the notification method is stored in the hold at the time of placement. Changes made to preferences will not affect existing holds. |
| 17:25 |
gsams |
mmorgan:This is for changes made at the time the hold is placed, simply unchecking the notify by boxes before placing the hold. |
| 17:25 |
jeff |
(which i'd love to see change) |
| 17:25 |
gsams |
phasefx:checking into that! |
| 17:28 |
|
mmorgan left #evergreen |
| 17:28 |
gsams |
phasefx: I'm pretty sure that was it... There are no event parameters. |
| 17:31 |
phasefx |
gsams: so all that's doing is tweaking the behavior of the HoldIsAvailable valdiator |
| 17:31 |
phasefx |
it'll return invalid if that param is set and $hold->email_notify is not true |
| 17:32 |
phasefx |
and as said, $hold->email_notify won't change for the life of the request |
| 17:32 |
|
gmcharlt left #evergreen |
| 17:32 |
phasefx |
or at least, I don't think it will. Can you edit that? |
| 17:35 |
phasefx |
looks like no |
| 17:35 |
gsams |
phasefx: I believe you can edit the hold notification settings on a per hold basis by right clicking on the hold on the users account |
| 17:35 |
phasefx |
oh, in the staff client, yes |
| 17:35 |
* phasefx |
forgets about that |
| 17:36 |
gsams |
otherwise, I'd imagine it would have to be a sql command to edit the hold table |
| 17:36 |
gsams |
I did too, I had to go look at it to make sure I wasn't dreaming about the idea |
| 17:36 |
phasefx |
so I mistated what was said, re: preferences |
| 17:36 |
phasefx |
preferences won't affect existing holds |
| 17:37 |
phasefx |
however, changing your email address will affect existing holds. And changing your phone number will not |
| 17:37 |
gsams |
phasefx++ #thanks for the help on that |
| 17:38 |
phasefx |
you're welcome. I feel like I just confused myself in the process :) |
| 17:44 |
berick |
eeevil: doh! removal of parens was not intentional |
| 17:44 |
berick |
thanks for pointing that out |
| 18:01 |
* berick |
will push an update for that by tomorrow at latest |
| 18:10 |
|
bmills joined #evergreen |
| 18:14 |
|
bmills1 joined #evergreen |
| 18:29 |
|
graced joined #evergreen |
| 19:03 |
|
wlayton joined #evergreen |
| 20:23 |
jeffdavis |
not super important, but I'd appreciate feedback on bug 1423025 if anyone has a spare moment |
| 20:23 |
pinesol_green |
Launchpad bug 1423025 in Evergreen "Show active date instead of create date in holdings grid" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1423025 |
| 20:25 |
* jeffdavis |
plugging away at pushing local customizations upstream |
| 20:27 |
|
sarabee joined #evergreen |
| 20:29 |
|
eeevil joined #evergreen |
| 20:45 |
|
buzzy joined #evergreen |
| 20:47 |
|
graced joined #evergreen |
| 21:01 |
|
graced joined #evergreen |
| 23:00 |
|
akilsdonk joined #evergreen |
