| Time |
Nick |
Message |
| 04:59 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 05:42 |
|
artunit_ joined #evergreen |
| 06:50 |
|
kmlussier joined #evergreen |
| 06:56 |
|
wsmoak joined #evergreen |
| 06:56 |
|
wsmoak joined #evergreen |
| 07:29 |
kmlussier |
Google Hangout link for web client documentation day - https://plus.google.com/hangouts/_/g3rpsa6kxtroslyv4okgzsnhg4a |
| 07:38 |
|
_bott_ joined #evergreen |
| 07:40 |
|
dkyle joined #evergreen |
| 07:51 |
|
dkyle joined #evergreen |
| 07:52 |
|
_bott_ joined #evergreen |
| 07:53 |
|
rjackson-isl joined #evergreen |
| 07:59 |
|
jboyer-isl joined #evergreen |
| 08:11 |
|
SallyF joined #evergreen |
| 08:13 |
|
Shae joined #evergreen |
| 08:21 |
kmlussier |
So the current docs for logging into the staff client address adding SSL exceptions if the server has a self-signed certificate. I wonder if there is some kind of equivalent extra step that needs to be documented for the web client. |
| 08:23 |
|
mrpeters joined #evergreen |
| 08:29 |
|
mdriscoll joined #evergreen |
| 08:32 |
|
Christineb joined #evergreen |
| 08:37 |
|
Dyrcona joined #evergreen |
| 08:40 |
|
mmorgan joined #evergreen |
| 08:41 |
|
ericar joined #evergreen |
| 08:42 |
|
ericar left #evergreen |
| 08:46 |
|
mrpeters joined #evergreen |
| 09:07 |
pinesol_green |
[evergreen|Kathy Lussier] Minor fix to web client section headers in root.txt - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=278e1ac> |
| 09:13 |
remingtron |
graced: eeevil: gmcharlt: I'm writing web client docs. Where should early adopters send feedback? Dev list? Launchpad? |
| 09:21 |
|
mrpeters joined #evergreen |
| 09:34 |
graced |
remingtron: what kind of feedback? |
| 09:35 |
graced |
I do have a known bug list that we're working through and I was hoping to get a copy out to the community this week but, alas, I haven't gotten it tidied up yet. |
| 09:36 |
remingtron |
I can direct certain kinds of feedback to certain places. Any preferences? |
| 09:36 |
remingtron |
e.g. feature requests to the dev list, but bugs/errors to launchpad? |
| 09:37 |
* dbs |
would suggest open-ils-dev as a starting point |
| 09:37 |
graced |
I wouldn't do bugs to LP since we already have a pretty good accounting. |
| 09:37 |
dbs |
and if we don't have one already, perhaps we should set a standard tag for web staff client bugs in launchpad so they can be easily checked |
| 09:37 |
graced |
I apologize for not getting that list out before today. :-/ |
| 09:38 |
dbs |
graced: who is "we"? |
| 09:38 |
graced |
We, Equinox, have an internal list of bugs as reported by the testers who were the funders of Sprint #1. |
| 09:38 |
graced |
And we're working thorugh those bugs now. |
| 09:38 |
kmlussier |
At some point, though, bugs will eventually be funneled through Launchpad, right? I'm guessing the testers didn't find everything. |
| 09:39 |
graced |
Yes, but I'd hate to see duplication of things we're currently fixing. |
| 09:39 |
remingtron |
right, these docs don't have to be published right away |
| 09:39 |
graced |
And that's my faulty for not making that list more visible before today. |
| 09:39 |
graced |
*fault |
| 09:39 |
remingtron |
do you have a timeframe on the current bug list? |
| 09:39 |
kmlussier |
graced: There's a lot of manage there. :) |
| 09:40 |
graced |
End of the month for critical bugs. |
| 09:40 |
graced |
And then I'm going to reassess where we are and what we've got left. I think that we'll make it through most of the list before year end though |
| 09:41 |
dbs |
Seems like at this point if the community in general is writing docs then we need to shift into more standard-operations community mode |
| 09:42 |
|
yboston joined #evergreen |
| 09:44 |
kmlussier |
I do agree, though, that it doesn't make much sense to start posting things to Launchpad until the list is out there, primarily because many of those bugs may already be reported with fixes in the works. |
| 09:44 |
remingtron |
dbs: or at least we (the community) need to communicate more with ESI |
| 09:44 |
remingtron |
kmlussier: +1 |
| 09:45 |
graced |
really, it's on us for not communicating more. apologies! |
| 09:45 |
remingtron |
what if we push our docs to master as they are ready, but not push into 2.7 until January? |
| 09:45 |
remingtron |
graced: apology accepted. thanks for taking responsibility. :) |
| 09:46 |
remingtron |
we all want this thing to succeed |
| 09:46 |
graced |
remingtron: you are very kind. :) |
| 09:48 |
dbs |
+1 to that :) |
| 09:51 |
remingtron |
kmlussier: sound good to you to hold back web client docs until January (checking with ESI first)? |
| 09:52 |
remingtron |
and the docs will suggest bugs go to launchpad at that point |
| 09:53 |
kmlussier |
remingtron: Hold back from 2.7, right? But add to master? |
| 09:53 |
remingtron |
kmlussier: yes |
| 09:53 |
kmlussier |
I'm fine with that. |
| 09:53 |
kmlussier |
But maybe I should revert some of those changes I made to 2.7 over the past 24 hours. |
| 09:54 |
remingtron |
kmlussier: sure, sounds good |
| 09:55 |
remingtron |
graced: sound good? that new web client docs will start saying in January: "Post bugs to launchpad" |
| 09:55 |
remingtron |
of course, we'll check in with you first, but that general timeframe |
| 09:55 |
graced |
sounds perfect, thank you! |
| 09:56 |
remingtron |
#agreed :) |
| 09:56 |
kmlussier |
yboston: Are you paying attention to all of this? |
| 09:56 |
* kmlussier |
runs off for a second to grab caffeine. |
| 10:10 |
remingtron |
@coffee kmlussier |
| 10:10 |
* pinesol_green |
brews and pours a cup of Costa Rica Micro Lot "Pepe" Honey Processed, and sends it sliding down the bar to kmlussier |
| 10:11 |
kmlussier |
remingtron: Thank you! That's much better than the cup of Lipton Tea I'm drinking now. |
| 10:33 |
* kmlussier |
is not being as productive as she had hoped. |
| 10:34 |
remingtron |
stuck on something? |
| 10:35 |
kmlussier |
No, just wandering down the path of straying too far from just updating what's there. What we talked about at yesterday's meeting. :) |
| 10:36 |
remingtron |
ah yes, the common temptation |
| 10:36 |
remingtron |
don't give up! |
| 10:36 |
remingtron |
you can do it! |
| 10:37 |
kmlussier |
Heh. I commit to commit something by day's end. |
| 10:37 |
remingtron |
kmlussier++ |
| 10:41 |
|
dkyle1 joined #evergreen |
| 10:42 |
|
_bott_1 joined #evergreen |
| 10:44 |
|
sfortin joined #evergreen |
| 10:58 |
eeevil |
remingtron / kmlussier: I've got a few fixes from Bill that are not yet deployed on webby. would you like me to make that happen? it'll cause just a second of outage while apache is restarted |
| 10:58 |
kmlussier |
I'm okay with that. I think there are only a few of us working on it right now. |
| 10:59 |
remingtron |
eeevil: I'm not actively testing right now |
| 10:59 |
remingtron |
eeevil: thanks! |
| 10:59 |
kmlussier |
eeevil: Anything interesting with the fixes? |
| 10:59 |
pinesol_green |
[evergreen|Remington Steed] Docs: Web Client preview intro - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=14784b3> |
| 11:01 |
eeevil |
kmlussier: they're all right here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/miker/web-client-sprint1-bug-fixing-rebased-collab ... |
| 11:01 |
|
vlewis joined #evergreen |
| 11:02 |
eeevil |
kmlussier: I think just those top 3 are from berick and were not already applied (about to apply that branch, heads up!) |
| 11:03 |
|
alynn26 joined #evergreen |
| 11:04 |
berick |
kmlussier: the big one is the org tree race condition one, which caused intermittent patron app render failures for me |
| 11:05 |
berick |
probably dependant on the environment, though, since it's a race condition. |
| 11:05 |
kmlussier |
Yeah, I don't know if that's one I ever came across. |
| 11:05 |
kmlussier |
eeevil++ berick++ |
| 11:10 |
alynn26 |
quick Question can someone explain how to set up hatch for printing in the web client, I've looked for directions, and have not found them anywhere. |
| 11:11 |
berick |
alynn26: we don't have a Hatch installer yet. it can be run from source, though. |
| 11:12 |
berick |
i have some install notes for linux in the repository README |
| 11:12 |
berick |
http://git.evergreen-ils.org/?p=working/random.git;a=blob;f=README;h=3add0a0059fa0c2be422f5fd5e957524e9d7b818;hb=refs/heads/collab/berick/hatch2 |
| 11:12 |
berick |
windows is.. very different, though |
| 11:12 |
alynn26 |
I'm looking more for a windows machine |
| 11:12 |
berick |
you could work backwards from these docs to figure it out on windows, but it's not documented. |
| 11:13 |
berick |
hatc has a lot of work left to do |
| 11:13 |
berick |
er, hatch |
| 11:13 |
alynn26 |
I saw the linux version, i quess that is what I am going to have to do. |
| 11:22 |
|
mtcarlson joined #evergreen |
| 11:30 |
|
bshum joined #evergreen |
| 11:30 |
|
mceraso joined #evergreen |
| 11:32 |
|
kbutler joined #evergreen |
| 11:35 |
|
dreuther joined #evergreen |
| 11:41 |
mrpeters |
Fix for Bug #1154656 at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters/lp1154656_marc_expert_search_duplicate_rows if anyone has a break from documentation party today for a signoff/pullrequest! |
| 11:41 |
pinesol_green |
Launchpad bug 1154656 in Evergreen 2.4 "MARC Expert Search "Add Rows" adds duplicate row" (affected: 5, heat: 22) [Medium,Confirmed] https://launchpad.net/bugs/1154656 |
| 11:49 |
kmlussier |
If you exit the browser without first logging out, you stay logged into the web client. Is that right? |
| 11:49 |
kmlussier |
Do we know how long users stay logged in? |
| 11:51 |
|
sandbergja joined #evergreen |
| 11:51 |
* kmlussier |
can't test this without either completely exiting out of the browser with my Google Hangout session or the browser that is playing my music. :( |
| 11:51 |
|
sandbergja joined #evergreen |
| 11:51 |
jcamins |
kmlussier: time to download a new browser! |
| 11:51 |
remingtron |
kmlussier: don't you have seven different browsers installed just for testing purposes? :) |
| 11:52 |
jcamins |
kmlussier: fortunately, there are lots of options, even just with Firefox: https://www.mozilla.org/en-US/firefox/developer/ https://nightly.mozilla.org/ |
| 11:53 |
kmlussier |
No, but I have about 12 different xul staff clients installed. |
| 11:54 |
eeevil |
bshum: first, thank you for signing off the sip branch!!! unfortunately, you've got some merge issues remaining in your commit ... look at the bottom of http://git.evergreen-ils.org/?p=working/SIPServer.git;a=blobdiff;f=SIPServer.pm;h=beb6e001719b477bd7ae6d43167aafb64d96a3d2;hp=36f505de5cb99b10dd081c8586339c26f69168e3;hb=b0786d3ae13fedb87b13463c18e1bfb43df9c3b5;hpb=c8e2ac5fe68961219095ab1b42486b161ce68e48 |
| 11:54 |
kmlussier |
jcamins: I'll remember that next time. For this go-around, sacrificed the music. |
| 11:54 |
alynn26 |
I'm in the middle of staff day, had a break thought I would work on Hatch, Got to go back with the rest of the crowd, and I've logged into Webby, will close it out and come back later, and test it after a few hours. |
| 11:54 |
eeevil |
bshum: if you want, I can rebase the branch to master for a clean signoff |
| 11:55 |
bshum |
eeevil: Maybe you mean to be talking to Bmagic? |
| 11:55 |
kmlussier |
eeevil: I think that was Bmagic, wasn't it? |
| 11:55 |
bshum |
:P |
| 11:55 |
kmlussier |
bshum: Beat me to it! |
| 11:55 |
eeevil |
bshum: HA! |
| 11:55 |
eeevil |
yes |
| 11:55 |
* eeevil |
hangs head |
| 11:55 |
bshum |
Not that I wouldn't sign off either |
| 11:55 |
bshum |
:D |
| 11:56 |
Bmagic |
? |
| 11:56 |
Bmagic |
SIPServer? |
| 11:56 |
csharp |
Bmagic: http://git.evergreen-ils.org/?p=working/SIPServer.git;a=shortlog;h=refs/heads/user/blake/LP1339190 |
| 11:57 |
mrpeters |
pushed one more change to "user/mrpeters/lp1154656_marc_expert_search_duplicate_rows" in order to make sure the <label> for the cloned rows gets bolded, like the original. |
| 11:57 |
csharp |
Bmagic: check the SIPServer.pm file |
| 11:57 |
eeevil |
Bmagic: want me to rebase the branch to master? |
| 11:58 |
Bmagic |
Perhaps I made a mistake? |
| 11:58 |
Bmagic |
oh, I see it, sorry yall |
| 11:58 |
Bmagic |
yeah, rebase |
| 11:59 |
Bmagic |
I thought it was odd that I only needed to change the includes...... silly rabbit |
| 12:04 |
|
sandbergja left #evergreen |
| 12:05 |
mrpeters |
bah, hold off on testing that -- i broke Advanced Search now -- ReferenceError: addSearchRow is not defined :( |
| 12:05 |
mrpeters |
fix one thing, break another ;P |
| 12:05 |
|
sandbergja__ joined #evergreen |
| 12:08 |
Dyrcona |
mrpeters++ |
| 12:08 |
* mrpeters |
loves a good game of whack-a-mole |
| 12:08 |
mrpeters |
we used to cheat so bad on that at Chuck E Cheese haha |
| 12:09 |
mrpeters |
way back when it was Showbiz Pizza --- ah the memories! |
| 12:10 |
eeevil |
Bmagic: I'm not sure why you got conflicts... my branch is already completely rebased to master. are you using http://git.evergreen-ils.org/?p=working/SIPServer.git;a=shortlog;h=refs/heads/user/miker/timeout-keepalive-relais-status_before_login-multiplex-final_squash ? |
| 12:10 |
Dyrcona |
@quote get 99 |
| 12:10 |
pinesol_green |
Dyrcona: Quote #99: "<mrpeters> fix one thing, break another ;P" (added by Dyrcona at 12:09 PM, December 05, 2014) |
| 12:10 |
mrpeters |
heh nice that might be my first quote |
| 12:10 |
Dyrcona |
@quote random |
| 12:10 |
pinesol_green |
Dyrcona: Quote #90: "<jeff> I feel like I'm stuck inside of a TCP joke." (added by gmcharlt at 12:37 PM, August 27, 2014) |
| 12:11 |
kmlussier |
mrpeters++ |
| 12:11 |
|
sandbergja joined #evergreen |
| 12:11 |
mrpeters |
Dyrcona: you guys are still running master right? |
| 12:11 |
mrpeters |
i think Advanced Search add row may be broken to begin with |
| 12:11 |
Dyrcona |
Yes, but from late July at this point. |
| 12:11 |
mrpeters |
the href is just to javascript:; whereas Expert does javascript:addExpertRow(); |
| 12:12 |
kmlussier |
It works for me in master |
| 12:12 |
Dyrcona |
We'll be upgrading to basically 2.7.1 this Sunday, i.e. master as of 11/06. |
| 12:12 |
|
jeff_ joined #evergreen |
| 12:13 |
|
jihpringle joined #evergreen |
| 12:13 |
mrpeters |
interesting |
| 12:13 |
kmlussier |
mrpeters: How is it broken? |
| 12:13 |
mrpeters |
i see <a href="javascript:;" id="myopac_new_global_row" onclick='addSearchRow();'>[% l('Add Search Row') %]</a> -- ill try flipping that to act like the Expert search and see what happens |
| 12:13 |
mrpeters |
kmlussier: http://eg-master.emeralddata.net/eg/opac/advanced?pane=advanced |
| 12:14 |
mrpeters |
nothing happens when you click add row, js console shows ReferenceError: addSearchRow is not defined |
| 12:14 |
tsbere |
mrpeters: I will point out that both are valid, and changing to javascript:addSearchRow won't help, because addSearchRow may still not be defined. |
| 12:15 |
* tsbere |
usually sees href="#" instead of href="javascript:;" though |
| 12:15 |
kmlussier |
Huh. I had not trouble with it here - https://mlnc1.mvlcstaff.org/eg/opac/advanced. I don't remember when master was loaded there, but there haven't been a lot of commits to master lately. |
| 12:16 |
mrpeters |
yeah, you are right it doesnt help |
| 12:16 |
jboyer-isl |
mrpeters: You might check for any syntax errors in the JS, One of the things I’ve run into is that if there’s any problem in a file, everything in that file is ignored. |
| 12:16 |
mrpeters |
kmlussier: well, my patch to fix Expert Search has clearly broken the Advanced tab :( |
| 12:17 |
mrpeters |
jboyer-isl: good point |
| 12:19 |
mrpeters |
doesn't appear to be any syntax errors though |
| 12:21 |
jboyer-isl |
Anything interesting in the JS Console? It may be complaining about something that looks otherwise ok. |
| 12:21 |
mrpeters |
nothing in the firefox js console log |
| 12:22 |
mrpeters |
just ReferenceError: addSearchRow is not defined |
| 12:22 |
mrpeters |
and adv_expert_row is not defined (which I expect) |
| 12:24 |
jboyer-isl |
Huh. :/ Paste a ‘git diff master’ (or whatever branch you started with) or the whole JS file you edited if it’s not in git yet, maybe something will stick out. |
| 12:24 |
mrpeters |
its in git |
| 12:25 |
mrpeters |
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=51e00a7fe43f69fe82e5d6c65138b80057a47424 |
| 12:26 |
jboyer-isl |
Take out line 16 and give it a shot. |
| 12:26 |
mrpeters |
line 16 of the diff, or of the blob? |
| 12:29 |
mrpeters |
removing line 16 of my simple.js breaks everything |
| 12:29 |
|
Shae joined #evergreen |
| 12:29 |
jboyer-isl |
blob, but nevermind that, just taking that out won’t help. All of the functions defined between 16 and 45 are being hidden from the rest of the file, they’re only available within the redefined $() function. |
| 12:33 |
jcamins |
jboyer-isl: change it to (function($, window) { ... })($, window); |
| 12:33 |
mrpeters |
eh, i did something else and its working |
| 12:34 |
jboyer-isl |
I’m not familiar enough with what’s going on in there to offer much more than this: You probably can’t use that (function $() { … })($) construction at all becuse there’s a $() defined at the top of the file. |
| 12:34 |
mrpeters |
i just put http://pastie.org/9762953 back in above the new function i created for expert search |
| 12:35 |
mrpeters |
so i can likely remove that from the new function |
| 12:35 |
jcamins |
jboyer-isl: (function($) { ... })($) is just running the code inside the function and giving it access to the jQuery library. |
| 12:35 |
mrpeters |
yep thats working perfect |
| 12:35 |
jboyer-isl |
That puts it outside of the $() that was hiding it, which is why it appears |
| 12:37 |
jboyer-isl |
jcamins: Yes, but near the top of the file there’s another definition of $(), which is just an alias for document.getElementById, I don’t think jQuery is used anywhere in Eg yet. |
| 12:40 |
jcamins |
jboyer-isl: that's... different. |
| 12:42 |
mrpeters |
jboyer-isl++ jcamins++ thanks guys, pushing up an amendment |
| 12:42 |
sandbergja |
remingtron: Just started working on docs for holds in the web client, but I only seem to be able to place holds for admin |
| 12:43 |
sandbergja |
remingtron: Is there a different section of the docs I should work on? Or choose one at random? |
| 12:45 |
remingtron |
sandbergja: I think that's a good question for kmlussier or yboston |
| 12:46 |
remingtron |
sandbergja: you are certainly welcome to choose whichever sections interest you |
| 12:46 |
remingtron |
but maybe someone can help you place holds for other users in the web client |
| 12:47 |
bshum |
Hmm |
| 12:47 |
bshum |
sandbergja: Did you register a workstation before trying to place holds? |
| 12:47 |
bshum |
I think I've seen before where if I log into the web client without specifying my workstation, that sometimes it weirded out on hold placements |
| 12:47 |
sandbergja |
bshum: oh! thanks! I will try that |
| 12:48 |
kmlussier |
Sorry, I was eating lunch. I recall that problem, but thought it was fix. Try what bshum suggested with workstation registration. |
| 12:48 |
kmlussier |
There are a couple of other things that work better with workstation registration, IIRC |
| 12:48 |
* bshum |
is eating mushroom pizza today. :D |
| 12:48 |
kmlussier |
bshum: Lucky you. |
| 12:49 |
jcamins |
bshum: I haven't made pizza in ages. |
| 12:49 |
jcamins |
That is very sad, I must say. |
| 12:49 |
sandbergja |
bshum: now I am super hungry! |
| 12:49 |
* kmlussier |
makes pizza every Sunday night. |
| 12:49 |
sandbergja |
yes! workstation registration makes all the holds business work |
| 12:49 |
sandbergja |
thanks everyone |
| 12:50 |
* kmlussier |
would love to see a requirement for workstation registration in the web client. |
| 12:50 |
sandbergja |
kmlussier: I was just going to ask about that |
| 12:51 |
sandbergja |
kmlussier: is it worth adding a note to the docs that your station has to be registered in order for holds to work properly? |
| 12:53 |
kmlussier |
sandbergja: Sure. I don't know if that's going to be a problem for the long-term future, but it's something that could be removed if need be. |
| 12:53 |
sandbergja |
kmlussier: sounds good |
| 12:53 |
sandbergja |
kmlussier: also, a quick stylistic thing. Should I call it the "staff client", the "staff web client", the "web client", or some other term? Just want to be consistent with what other folks are calling it. |
| 12:53 |
kmlussier |
I was just working on the logging in section. I think I'll add a note strongly recommending workstation registration to get certain features to work. |
| 12:54 |
sandbergja |
:-) |
| 12:55 |
kmlussier |
It looks like I've been calling it the web client. |
| 12:55 |
kmlussier |
But, in some cases, I've simply been calling it the client. |
| 12:55 |
bshum |
+1 to "web client" |
| 12:55 |
kmlussier |
For now, I guess we should refer to it as the web client to distinguish it in the docs. |
| 12:56 |
sandbergja |
sounds good -- thanks! |
| 12:56 |
kmlussier |
But once we're all moved over, I'm thinking that word "web" won't be necessary anymore. |
| 12:57 |
* kmlussier |
returns to finishing lunch while dreaming of pizza |
| 12:57 |
remingtron |
kmlussier: +1 |
| 12:57 |
remingtron |
kmlussier: that's a +1 to "web client" for now, until it's all we have |
| 12:58 |
* bshum |
is +1 to pizza too |
| 12:58 |
remingtron |
kmlussier: but +1 to pizza dreaming, too |
| 12:58 |
bshum |
pizza++ |
| 12:58 |
bshum |
@love pizza |
| 12:58 |
pinesol_green |
bshum: But bshum already loves pizza! |
| 12:58 |
bshum |
:D |
| 12:58 |
kmlussier |
@whocares pizza |
| 12:58 |
pinesol_green |
bshum loves pizza |
| 12:58 |
kmlussier |
@love pizza |
| 12:58 |
pinesol_green |
kmlussier: The operation succeeded. kmlussier loves pizza. |
| 13:01 |
csharp |
@love pizza |
| 13:01 |
pinesol_green |
csharp: The operation succeeded. csharp loves pizza. |
| 13:07 |
|
purcellm joined #evergreen |
| 13:07 |
|
nhilton joined #evergreen |
| 13:12 |
|
dreuther_ joined #evergreen |
| 13:23 |
|
dreuther joined #evergreen |
| 13:26 |
Bmagic |
eeevil: my git expierence is little which is the problem here. here is the sequence: git clone git://github.com/atz/SIPServer.git SIPServer git remote add working git://git.evergreen-ils.org/working/SIPServer.git git checkout -b LP1339190 origin/master git cherry-pick -s 9b3ca581d92298904652f52b512dc2eb1b153977 |
| 13:27 |
Bmagic |
eeevil: perhaps I should have simply checked out the working branch instead of cherry pick |
| 13:28 |
bshum |
Bmagic: I think the problem is that origin/master in that situation is atz's branch |
| 13:28 |
bshum |
Not the community remote |
| 13:29 |
Bmagic |
bshum: there we go |
| 13:29 |
Bmagic |
im not sure how I arrived at that link |
| 13:29 |
bshum |
In the future, I might suggest cloning the main repo |
| 13:29 |
bshum |
It used to be that we used that sipserver |
| 13:29 |
bshum |
But we stopped a long time ago |
| 13:30 |
Bmagic |
bshum: oh, here is how http://docs.evergreen-ils.org/2.1/html/sipserver.html |
| 13:30 |
Bmagic |
is there a more updated doc for it? |
| 13:31 |
Bmagic |
I think I answered my own question |
| 13:36 |
purcellm |
quit |
| 13:37 |
eeevil |
Bmagic: ah! well, no worries. the code works for you, so I'm happy :) |
| 13:37 |
yboston |
Bmagic: there is a newwer version with a couple of small cahnges that I help re-format |
| 13:37 |
yboston |
http://docs.evergreen-ils.org/dev/_sip_server.html |
| 13:41 |
jboyer-isl |
Oh, man |
| 13:41 |
jboyer-isl |
@love pizza |
| 13:41 |
pinesol_green |
jboyer-isl: The operation succeeded. jboyer-isl loves pizza. |
| 13:42 |
jboyer-isl |
Wouldn’t have made it through 1.5 semesters of college without that. |
| 13:42 |
kmlussier |
@who doesn't love pizza? |
| 13:42 |
pinesol_green |
StomproJ doesn't love pizza. |
| 13:42 |
bshum |
Haha |
| 13:47 |
dbs |
Bmagic: don't feel too bad about that old misleading link, our team was misled back in June too :/ |
| 13:51 |
Dyrcona |
@who is play Throwing Muses' The Real Ramona? |
| 13:51 |
pinesol_green |
tsbere is play Throwing Muses' The Real Ramona. |
| 13:51 |
Dyrcona |
o.O |
| 14:05 |
Bmagic |
dbs: thanks! |
| 14:08 |
kmlussier |
Maybe pinesol_green meant to say tsbere can hear Throwing Muses' The Real Ramona from the next office over? ;) |
| 14:08 |
Dyrcona |
:) |
| 14:20 |
|
mtcarlson joined #evergreen |
| 14:21 |
yboston |
does the new web client support "function keys", like F4 to bring up "search for patrons"? |
| 14:21 |
kmlussier |
No |
| 14:21 |
kmlussier |
Not yet |
| 14:21 |
yboston |
OK, will take it out of the docs for now. |
| 14:22 |
yboston |
are there plans at this point for the web client to have a "toolbar"? |
| 14:25 |
kmlussier |
I would like to see some kind of equivalent to the toolbar, even if it isn't a toolbar, but I personally haven't heard any solid plans for something like that. |
| 14:25 |
kmlussier |
For today, I guess I would stick to documenting what's there, and then we can return to these other areas if/when they are added. |
| 14:29 |
|
dreuther_ joined #evergreen |
| 14:31 |
|
dreuther__ joined #evergreen |
| 14:34 |
pinesol_green |
[evergreen|Kathy Lussier] DOCS: Logging into the web client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b3a7ce9> |
| 14:34 |
pinesol_green |
[evergreen|Kathy Lussier] DOCS: Tab documentation for web client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d7e1c5e> |
| 14:37 |
remingtron |
kmlussier++ |
| 14:38 |
kmlussier |
I've committed to my commitment to commit by the end of the day. :) |
| 14:38 |
kmlussier |
remingtron++ #For keeping us focused on getting web client docs done. |
| 14:39 |
* kmlussier |
needs to take a break from documentation for a bit, but hopes to do a little more before the day is done. |
| 14:46 |
yboston |
kmlussier: thanks for the updates, I was going to ignore those features but I was curious if there were any ongoing plans for both |
| 14:50 |
|
akilsdonk joined #evergreen |
| 15:19 |
bshum |
eeevil: I updated the couple of bugs that were also pushed today for SIPServer. I was confused at first why there were so many new commits in SIPServer till I realized it were multiple bug tickets afoot. |
| 15:19 |
bshum |
New stuff looks cool :) |
| 15:22 |
bshum |
A question though |
| 15:22 |
bshum |
The changes for sipconfig.xml in the commit, that's a test config file of some kind right? |
| 15:23 |
bshum |
Do those need to be adapted towards oils_sip.xml config or whatever we point SIPServer to use? |
| 15:23 |
Bmagic |
I didnt look at that |
| 15:23 |
bshum |
I'm thinking on things like the <cache> area, and specifying a different memcache source for the Multiplex mode |
| 15:24 |
bshum |
And the keepalive params |
| 15:27 |
kmlussier |
For those who are still in the Hangout (I don't think anyone is sitting at their computer right now), I need to leave right now. I don't know if that's going to shut down the entire Hangout since I'm the one who started it, but, if it does, you'll need to start up a new one. |
| 15:28 |
kmlussier |
Or finish up the Hangouts for today. It's been very quiet there today. |
| 15:30 |
eeevil |
bshum++ # thanks for the cleanup! |
| 15:31 |
|
dreuther joined #evergreen |
| 15:31 |
bshum |
Well I guess it's actually oils_sip.xml.example in the repo. We just turn it into oils_sip.xml :) |
| 15:31 |
eeevil |
bshum: I left them out of the evergreen sip config example, since, really, the sipserver's example should trump evergreens. I'd argue for /removing/ oils_sip.xml.example from evergreen, personally |
| 15:32 |
eeevil |
and saying "look at SIPconfig.xml that comes with the SIPServer you installed" |
| 15:32 |
bshum |
eeevil: I'm fine with that, we just need to also find all the places where we tell people which config file to use and follow appropriately. |
| 15:32 |
bshum |
In the documentation. |
| 15:34 |
bshum |
eeevil++ |
| 15:35 |
bshum |
Maybe something to work towards for 2.8? Deprecate oils_sip.xml and update instructions to say use the one that ships with SIPServer |
| 15:36 |
bshum |
In any case, if I wanted the benefits of the fancy newest SIPServer, that's what I need to do. Cool, cool. |
| 15:37 |
eeevil |
+1 to that. if we do that, though, we should see if the koha folken are close to being able to use stock SIPServer, and if so, we can each have an example <institution> with the appropriate implementation attribute |
| 15:39 |
|
kmlussier joined #evergreen |
| 15:39 |
phasefx |
berick: in services/ui.js, with the focusMe directory, how kludgy/horrible does it sound to you to add a second to that timeout wrapping the .focus method? I've been beating my head against the problem of the patron-checkout-barcode input not getting focus after scanning in a patron |
| 15:40 |
phasefx |
s/directory/directive/ |
| 15:43 |
* berick |
looks |
| 15:44 |
|
kmlussier1 joined #evergreen |
| 15:45 |
bshum |
eeevil: I filed bug 1399790 against Evergreen for now to keep track of it for 2.next. I'll spend some time poking at it in the coming weeks unless someone else beats me there. |
| 15:45 |
pinesol_green |
Launchpad bug 1399790 in Evergreen "deprecate oils_sip.xml" (affected: 1, heat: 6) [Wishlist,Triaged] https://launchpad.net/bugs/1399790 |
| 15:46 |
phasefx |
berick: 1-second works for me, but it's obviously a race condition and not ideal. Without the timeout, I can see that the input does get focus, but it immediately blurs afterward.. <body> ends up getting it |
| 15:48 |
eeevil |
bshum: rock, thanks! |
| 15:51 |
|
sandbergja left #evergreen |
| 15:54 |
berick |
phasefx: that's very odd. first time you access it from anywhere, it won't focus. jump to a tab, jump back, it focuses fine |
| 15:54 |
phasefx |
berick: yeah |
| 15:54 |
berick |
even a timeout in the checkout controller reseting focusMe has no effect |
| 15:55 |
phasefx |
berick: I tried an $emit/$on deal with a virtual event for focusing, fired off in the controller, and that works in Firefox, but not Chrome |
| 15:56 |
phasefx |
berick: and the watch handler _is_ getting called with the existing code |
| 15:58 |
berick |
phasefx: did you try a shorter timeout? like 1? |
| 15:58 |
phasefx |
berick: yeah, tried 1, and an explicit 0. DIdn't try 30 or anything |
| 15:59 |
berick |
hm, yeah, 1 fails for me to. confirmed 1000 works, though. ugh. |
| 16:00 |
phasefx |
you can spit out document.activeElement to the console, and in some scenarios with code tweaks, I can it to show the input temporarily, but body has it most of the time |
| 16:02 |
berick |
phasefx: yeah, i don't have any better suggestion at the moment |
| 16:03 |
jcamins |
phasefx: might I look at the code? |
| 16:03 |
jcamins |
I was just fiddling with Angular focus directives the other day. |
| 16:04 |
phasefx |
jcamins: the first directive here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=blob;f=Open-ILS/web/js/ui/default/staff/services/ui.js;h=c960ffb6af0bfb674d38349727a024bf3cfffeca;hb=refs/heads/collab/miker/web-client-sprint1-bug-fixing-rebased-collab |
| 16:05 |
phasefx |
the corresponding template: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=blob;f=Open-ILS/src/templates/staff/circ/patron/t_checkout.tt2;h=f42bfe967349de2532641487bc219bd622aed1b9;hb=refs/heads/collab/miker/web-client-sprint1-bug-fixing-rebased-collab#l27 |
| 16:06 |
bshum |
dbs: I just pushed to working this branch to address the problems for upgrading you found with the skipped 2.6.2-2.6.3 script and 2.7 series: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/fix_2.7_upgrade_scripts_in_master |
| 16:06 |
phasefx |
berick: thanks man |
| 16:06 |
bshum |
It's for master only, we'll need to port the 2.6.2-2.6.3 to rel_2_7 before adding the rest of those changes on top of it. |
| 16:07 |
bshum |
Along the way, I also want to finish vetting StomproJ's changes in bug 1390138 for upgrading to 2.7 |
| 16:07 |
pinesol_green |
Launchpad bug 1390138 in Evergreen "Documentation: 2.7 upgrade docs need to be updated" (affected: 1, heat: 6) [Medium,Confirmed] https://launchpad.net/bugs/1390138 - Assigned to Josh Stompro (u-launchpad-stompro-org) |
| 16:07 |
bshum |
And include a note about how the upgrade path is 2.6.3-2.7.0 |
| 16:07 |
bshum |
So that folks don't miss the stuff in the 2.6.2-2.6.3 version upgrade script. |
| 16:09 |
bshum |
If I've missed anything there, let me know. |
| 16:12 |
|
buzzy joined #evergreen |
| 16:18 |
|
sandbergja joined #evergreen |
| 16:22 |
bshum |
"Reduce GIN index size" sounds... nice from the PG 9.4 release notes. |
| 16:22 |
bshum |
:) |
| 16:23 |
jcamins |
bshum: the smaller the index, the faster you can find it and drink it? |
| 16:23 |
bshum |
:D |
| 16:24 |
bshum |
Guess 9.4 is getting close to being official: http://www.postgresql.org/message-id/26295.1417708564@sss.pgh.pa.us |
| 16:49 |
* Dyrcona |
is looking forward to VODKA indexies. ;) |
| 16:49 |
Dyrcona |
And that's how you spell after too much indexing with VODKA or GIN. :) |
| 16:58 |
|
kmlussier joined #evergreen |
| 17:03 |
phasefx |
berick: jcamins: eeevil figured out a good solution for the focus issue, using promises: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=9730cb52064bce949a352e379759f9daec28550c |
| 17:04 |
jcamins |
phasefx: ooh, good call! |
| 17:09 |
berick |
++ to that. but I wonder why that worked and not $timeout(func-to-set-focus, some-huge-number-to-test) |
| 17:09 |
|
mdriscoll left #evergreen |
| 17:09 |
berick |
even tested an embedded $apply() |
| 17:09 |
berick |
anyway, eeevil's approach is superior to any time |
| 17:09 |
berick |
glad it works |
| 17:14 |
phasefx |
berick: we can actually get rid of the $timeout, but I didn't want to do that until we looked at all other uses of focusMe |
| 17:15 |
phasefx |
but I experimented with removing $timeout with .finally in play and it worked |
| 17:16 |
berick |
phasefx: hm, yeah, i'd be wary of removing the timout within the focusMe directive |
| 17:17 |
berick |
i mean, i'd be wary of the original zero timeout |
| 17:17 |
berick |
arg, i'd be wary of *removing* the original zero timeout |
| 17:17 |
phasefx |
berick: the some-huge-number-to-test not working thing, I'm not groking that. 1-second was working for you? |
| 17:17 |
berick |
sorry, that comment was unclear |
| 17:18 |
berick |
i tested adding a timeout within the checkout controller |
| 17:18 |
phasefx |
oh, right |
| 17:18 |
berick |
which would fire after initTab had completed (also promise-based) |
| 17:18 |
berick |
so, i was confused why one promise resolver worked, but not another |
| 17:19 |
phasefx |
very weird stuff.. an alert() prior to the .focus() would also "fix" things |
| 17:19 |
phasefx |
we've seen stuff like that before with xulrunner I recall |
| 17:19 |
|
mmorgan left #evergreen |
| 17:43 |
* kmlussier |
is making the executive decision to remove the hyphen from check-box in our documentation. |
| 17:51 |
Bmagic |
so, when you are looking at a bib with the staff client, holdings maintenance for example, you see the bib title and author at the top. We have a bib that has a space in the title but only in that view. The MARC does not have this. I have the reingest_same_marc flag turned on and set id=id. It still doesnt fix |
| 17:52 |
Bmagic |
I found a few tables in the metarecord schema that have the space, I corrected those, but it still doesnt go away in the staff client |
| 17:54 |
Bmagic |
it looks like the code is from bib_brief_overlay.xul, however, I can't seem to trace/connect the data back to a db table |
| 19:14 |
|
StarLibrary joined #evergreen |
| 19:14 |
|
dreuther_ joined #evergreen |
| 19:15 |
StarLibrary |
I need some help |
| 19:16 |
StarLibrary |
When issueing PATH=/openils/bin:$PATH ./configure --prefix=/openils --sysconfdir=/openils/conf I get bash: ./configure: No such file or directory |
| 20:58 |
|
sarabee joined #evergreen |
| 21:24 |
|
kmlussier joined #evergreen |
