| Time |
Nick |
Message |
| 02:00 |
|
jeffdavis joined #evergreen |
| 02:06 |
paxed |
bshum: well, i did some good at least... :) |
| 02:54 |
|
RBecker_ joined #evergreen |
| 02:56 |
|
snigdha26 joined #evergreen |
| 03:07 |
|
RBecker_ joined #evergreen |
| 03:15 |
|
Guest33632 joined #evergreen |
| 05:07 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 05:26 |
|
Stompro joined #evergreen |
| 06:12 |
|
sarabee joined #evergreen |
| 06:34 |
|
RBecker joined #evergreen |
| 07:23 |
|
kmlussier joined #evergreen |
| 07:35 |
* kmlussier |
still wants to create a locale for pirate in Evergreen. |
| 07:38 |
|
jboyer-isl joined #evergreen |
| 07:45 |
|
athira joined #evergreen |
| 07:58 |
|
eeevil joined #evergreen |
| 07:58 |
|
mtate joined #evergreen |
| 07:59 |
|
Callender joined #evergreen |
| 07:59 |
|
phasefx joined #evergreen |
| 08:00 |
|
graced joined #evergreen |
| 08:08 |
|
jventuro_ joined #evergreen |
| 08:20 |
|
akilsdonk joined #evergreen |
| 08:26 |
|
mrpeters joined #evergreen |
| 08:29 |
|
Dyrcona joined #evergreen |
| 08:31 |
|
Shae joined #evergreen |
| 08:42 |
|
mmorgan joined #evergreen |
| 08:47 |
Dyrcona |
Sometimes, less code is better: 1 file changed, 12 insertions(+), 84 deletions(-) |
| 08:50 |
|
ericar joined #evergreen |
| 09:11 |
csharp |
Dyrcona++ |
| 09:23 |
|
asimon joined #evergreen |
| 09:31 |
asimon |
I am attempting to load a file of records using Vandelay. I have created a Holdings Import Profile for the local holdings. A test record load fails. The osrfsys.log file shows: "vl: record 1 was not imported" but no errors. Where should I go from here? |
| 09:35 |
dbs |
paxed: you did a lot of good! |
| 09:37 |
kmlussier |
asimon: Could you share what your holdings import profile looks like and what the holdings field looks like in the record your are importing? |
| 09:42 |
asimon |
kmlussier: Let me pull that info together for you. |
| 09:43 |
kmlussier |
berick: l'm looking back on bug 1209291 (for doc purposes). If a site doesn't set a prefix for the auto barcodes/call numbers, will it still automatically generate those fields or does another setting need to be enabled first? IOW, does the feature just work without any intervention from the user? |
| 09:44 |
pinesol_green |
Launchpad bug 1209291 in Evergreen "Vandelay item import support for some default copy values." (affected: 1, heat: 6) [Wishlist,Fix released] https://launchpad.net/bugs/1209291 |
| 09:44 |
* berick |
looks |
| 09:45 |
|
yboston joined #evergreen |
| 09:51 |
berick |
kmlussier: in either case, you have to set vandelay.item.barcode.auto / vandelay.item.call_number.auto to enable automatic generation |
| 09:51 |
berick |
if no prefix is set, it will default to 'VAN' |
| 09:51 |
kmlussier |
berick: OK, thanks! |
| 09:52 |
kmlussier |
berick: And, now that you mention it, I see that setting in the release notes. The answer had been staring me in the face all along. |
| 09:53 |
berick |
well, those are always the hardest things to find |
| 10:00 |
|
dcook__ joined #evergreen |
| 10:01 |
|
ericar_ joined #evergreen |
| 10:01 |
|
sseng joined #evergreen |
| 10:05 |
|
dbs_ joined #evergreen |
| 10:08 |
|
dcook__ joined #evergreen |
| 10:10 |
|
snigdha26 joined #evergreen |
| 10:14 |
|
dac joined #evergreen |
| 10:16 |
kmlussier |
Could somebody more knowledgeable about custom dojo builds than thank I am let me know if the documentation in http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/edoceo/lp1076582 can be pushed as is? Or does it need more work? |
| 10:36 |
kmlussier |
Also, any guidance on whether the doc change in bug 1131279 should be backported to 2.5/2.6 as Josh suggested? |
| 10:36 |
pinesol_green |
Launchpad bug 1131279 in Evergreen "no mention of server side actions needed when manipulating org units in the documentation" (affected: 1, heat: 8) [Undecided,Fix committed] https://launchpad.net/bugs/1131279 - Assigned to Josh Stompro (u-launchpad-stompro-org) |
| 10:37 |
Stompro |
Woohoo |
| 10:40 |
Stompro |
Maybe the changelog for the autogen.sh would say when the -u flag functionality was changed... I'll look when I have a chance. |
| 10:45 |
|
kmlussier1 joined #evergreen |
| 10:46 |
|
mdriscoll1 joined #evergreen |
| 10:53 |
* kmlussier |
now tries to become more familiar with github |
| 10:58 |
|
dMiller joined #evergreen |
| 10:59 |
|
mrpeters1 joined #evergreen |
| 11:00 |
yboston |
kmlussier: I may have been giving the docs for "adjustable font size in the catalog" to load up into the repo, ebfore I was comfortable with pushing stuff there. will need to look for it |
| 11:00 |
yboston |
it was doen last year at the DIG hack-a-way, IIRC |
| 11:01 |
|
mdriscoll joined #evergreen |
| 11:02 |
|
goood joined #evergreen |
| 11:03 |
|
kmlussier1 joined #evergreen |
| 11:04 |
|
Darth_Tater joined #evergreen |
| 11:04 |
yboston |
kmlussier: I found the docs that I had to process from the last DIG hack-a-way |
| 11:05 |
yboston |
though I might not get to push them today, since I need to check if there are conflicts when I merge in the new content |
| 11:06 |
|
Guest72335 joined #evergreen |
| 11:06 |
kmlussier |
yboston: Awesome! |
| 11:06 |
kmlussier |
ericar_++ #Sending along more bitesize docs for me to post. |
| 11:10 |
|
gmcharlt joined #evergreen |
| 11:11 |
|
gmcharlt joined #evergreen |
| 11:12 |
kmlussier |
jboyer-isl: I know of something else that's similar to the bug you reported in bug 1371647 |
| 11:12 |
pinesol_green |
Launchpad bug 1371647 in Evergreen "config.marc21_ff_pos_map needs an audit" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1371647 |
| 11:12 |
jboyer-isl |
kmlussier: how so? |
| 11:13 |
kmlussier |
jboyer-isl: Audiobooks don't use the fiction/nonfiction fields that books use. So if you limit to an audiobook and select fiction or non-fiction, you won't get the results you expected. |
| 11:13 |
kmlussier |
Just thought I would mention it since it seems like the same issue. |
| 11:14 |
jboyer-isl |
That would be a good comment on the bug, in case someone smarter than me starts looking into it. :) |
| 11:14 |
jboyer-isl |
(I can add it if you’re busy currently) |
| 11:14 |
kmlussier |
jboyer-isl: I'll do so. :) |
| 11:14 |
jboyer-isl |
kmlussier++ |
| 11:15 |
|
vlewis joined #evergreen |
| 11:16 |
|
dreuther joined #evergreen |
| 11:23 |
|
linuxhiker joined #evergreen |
| 11:24 |
linuxhiker |
anyone ever seen this? Can't locate Unix/Syslog.pm in @INC (@INC contains: /openils/lib/perl5 /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at /openils/lib/perl5/OpenSRF/Utils/Logger.pm line 5. BEGIN failed--compilation aborted at /openils/lib/perl5/OpenSRF/Utils/Logger.pm line 5. |
| 11:24 |
linuxhiker |
If I use perl -e, I can use the module jsut fine |
| 11:24 |
linuxhiker |
even when ran as the opensrf user |
| 11:24 |
|
RBecker_ joined #evergreen |
| 11:32 |
|
serflog joined #evergreen |
| 11:32 |
|
Topic for #evergreen is now Welcome to the #evergreen library system channel! | We are publicly logged. | Large pastes at http://paste.evergreen-ils.org |
| 11:33 |
|
ningalls joined #evergreen |
| 11:33 |
mmorgan |
another day, another selfcheck question ... |
| 11:33 |
bshum |
~search_path |
| 11:33 |
pinesol_green |
After restoring a database, make sure to reset the search_path accordingly with something like: alter database unpredicable_haxxors_go_away set search_path = evergreen, public, pg_catalog; |
| 11:34 |
mmorgan |
Trying to configure the library setting "Selfcheck override events list", referring to http://markmail.org/search/?q=selfcheck+override+events+list but it's not working. |
| 11:34 |
mmorgan |
I'm trying to add COPY_ALERT_MESSAGE to the event list, but not sure of the syntax. Do I need quotes? |
| 11:34 |
jboyer-isl |
mmorgan: Are you using the event name or code number? |
| 11:34 |
mmorgan |
Using the event name, should it be code number? |
| 11:35 |
jboyer-isl |
That setting type (array) seems to only like numbers, I’m trying to help someone here do the same thing and haven’t had a lot of luck so far. (It’s possible that you can only enter the code, but the code checks the name, I don’t know.) |
| 11:36 |
mmorgan |
will try the code number... |
| 11:36 |
jboyer-isl |
The number will be accepted, but I don’t know if it will actually work. |
| 11:38 |
|
nhilton joined #evergreen |
| 11:39 |
mmorgan |
nope. No matter what I try, I get a javascript error: TypeError: overrideEvents.filter is not a function selfcheck.js:1067 |
| 11:39 |
mmorgan |
Hoping it's my syntax rather than a bug. |
| 11:41 |
jboyer-isl |
Ah. I haven’t had a chance to look into errors on the actual selfcheck page itself, I’ve been making suggestions remotely and was just about to look into it myself today. |
| 11:41 |
jboyer-isl |
That sounds like it’ll be a problem. |
| 11:42 |
mmorgan |
yeah, one without a viable workaround :-( |
| 11:44 |
|
ningalls1 joined #evergreen |
| 11:47 |
jboyer-isl |
Bah. I can’t remember the selfcheck path. mmorgan, do you have it handy? |
| 11:47 |
jboyer-isl |
(lazy IRC googling) |
| 11:47 |
berick |
mmorgan: what browser are you using? |
| 11:48 |
mmorgan |
https://<hostname>/eg/circ/selfcheck/main |
| 11:48 |
jboyer-isl |
mmorgan++ |
| 11:48 |
mmorgan |
berick: Using firefox |
| 11:48 |
mmorgan |
Also OpenKiosk for the station itself |
| 11:50 |
berick |
mmorgan: the setting uses code names.. |
| 11:51 |
berick |
it should look llke ["SOME_THING","SOMETHING_ELSE"] |
| 11:52 |
berick |
["COPY_ALERT_MESSAGE"] |
| 11:52 |
mmorgan |
ok, so double quotes, and separated by commas. Including the square brackets? |
| 11:53 |
berick |
i'm not 100% sure you can actually apply a value to that setting from the interface |
| 11:53 |
berick |
IIRC, the library settings UI doesn't know how to handle arrays like that |
| 11:53 |
berick |
if you can access the database, probably better to set it there |
| 11:54 |
berick |
insert into actor.org_unit_setting (org_unit, name, value) values (<org-id>, 'circ.selfcheck.auto_override_checkout_events', '["COPY_ALERT_MESSAGE"]') |
| 11:55 |
mmorgan |
Oh, ok. *THAT's* good to know. Will pop it in the database. |
| 11:55 |
berick |
or update as the case may be |
| 11:55 |
jboyer-isl |
berick, mmorgan: Actually, it looks like “array” setting types will either let you enter raw ints, or it will allow the full brackets and quote format, because I just tried that on our migration server and it did work this time. |
| 11:55 |
berick |
jboyer-isl: the stored value is a valid JSON array and not a string that looks like an array? |
| 11:56 |
jboyer-isl |
Oh, you mean it gets mangled in the db? Let me check... |
| 11:56 |
|
RBecker_ joined #evergreen |
| 11:56 |
berick |
no, i think the UI takes whatever is in the text box and turns it into JSON |
| 11:56 |
berick |
that's my guess, anyway |
| 11:56 |
berick |
i haven't tried it in a while |
| 11:57 |
jboyer-isl |
This is the value of that setting when entered into the client: "[\"COPY_ALERT_MESSAGE\"]" |
| 11:57 |
jboyer-isl |
So that’s likely no good. |
| 11:57 |
jboyer-isl |
? |
| 11:57 |
berick |
right, that's just a string |
| 11:57 |
|
kbutler joined #evergreen |
| 11:58 |
kbutler |
Does anyone know if those "Invalidate" buttons in the patron reg screen are supposed to do anything besides just blank out the box they're next to? |
| 11:58 |
jboyer-isl |
Well, at least I know how to get our lib here going. Who wants to visit Launchpad? :) |
| 11:59 |
jboyer-isl |
kmlussier: I thought they applied a standing penalty also, though it’s been a while since I’ve looked. |
| 12:00 |
kmlussier |
kbutler ^ ^ |
| 12:00 |
jboyer-isl |
Oops! |
| 12:00 |
kmlussier |
jboyer-isl: Too many k's in here. :) |
| 12:00 |
kmlussier |
But not enough Jasons. |
| 12:01 |
jeff |
kbutler: *nod* |
| 12:02 |
kbutler |
jboyer-isl: that's what I would have thought but it's not. Hrm. |
| 12:02 |
jeff |
kbutler: they blank the value (an action which actually takes place without needing to click Save) and apply a standing penalty, possibly optional based on config. |
| 12:02 |
|
linuxhiker left #evergreen |
| 12:03 |
jboyer-isl |
It’s the optional part I’m not familiar with. (We had a customization that accidentally hid them for quite a while so we may not use them as much as others) |
| 12:04 |
kbutler |
jeff: any ideas on where the config for the penalty might be? In ours it just seems to blank and nothing else happens at all. |
| 12:04 |
kbutler |
I don't see anything in library settings |
| 12:05 |
jeff |
kbutler: looking |
| 12:05 |
mmorgan |
jboyer-isl: still trying to get my selfcheck override to work, did you literally add "[\"COPY_ALERT_MESSAGE\"]" in the client? Or did you add it in the database? |
| 12:07 |
jboyer-isl |
That’s what the client did to my entry. in the DB set it to this: '["COPY_ALERT_MESSAGE"]' |
| 12:08 |
jboyer-isl |
Then if there was interest in overriding multiple events it would be like so: '["COPY_ALERT_MESSAGE”,”EVENT_2”,”ETC.”]’ |
| 12:08 |
mmorgan |
ok, will try that |
| 12:10 |
jeff |
kbutler: the penalty is applied at the patron's home library, so depending on $things, you might not see it. |
| 12:10 |
kbutler |
jeff: we're a single branch library so it shouldn't be that. I hope. |
| 12:12 |
jeff |
you'll need the stock penalties in your db -- it's possible that they were missed during an upgrade. their names are INVALID_PATRON_EMAIL_ADDRESS, INVALID_PATRON_DAY_PHONE, INVALID_PATRON_EVENING_PHONE, and INVALID_PATRON_OTHER_PHONE |
| 12:13 |
mmorgan |
Checkout succeeded!! |
| 12:14 |
mmorgan |
jboyer-isl++ berick++ |
| 12:14 |
mmorgan |
I will pay a visit to Launchpad |
| 12:14 |
kbutler |
jeff: ooh. That is entirely possible. Will check it out. Thanks! |
| 12:16 |
kbutler |
jeff: looks like it's working now. Thanks for your help. |
| 12:17 |
jboyer-isl |
mmorgan++ |
| 12:17 |
|
jeffdavis joined #evergreen |
| 12:17 |
jboyer-isl |
Glad it’s going. Our lib running into the same problem will be glad to hear it. |
| 12:19 |
eeevil |
time for an informal poll! |
| 12:20 |
eeevil |
so, the next browser staff client sprint is for catalog[u]ing, and one of the parts of cataloging is the ability to create and edit items and volumes |
| 12:20 |
eeevil |
we have, in the XUL SC, two ways of doing that |
| 12:20 |
eeevil |
the old way (separate copy and volume editors) |
| 12:21 |
eeevil |
and the new way (the unified copy/volume editor) |
| 12:21 |
Dyrcona |
And, I have some members who use one way and some who use the other, so do both! ;) |
| 12:21 |
Dyrcona |
Next question? :) |
| 12:21 |
eeevil |
and, we have an opportunity to consolidate the code in different ways |
| 12:21 |
eeevil |
Dyrcona: that wasn't quite where I was going, but thanks! ;) |
| 12:22 |
Dyrcona |
eeevil: OK. :) |
| 12:22 |
* Dyrcona |
will be more patient. |
| 12:22 |
kmlussier |
eeevil: I'm all for consolidating if you do it the way I want. ;) |
| 12:23 |
jboyer-isl |
eeevil: and I’m all for consolidating and telling people “this is how it works now” ;D |
| 12:23 |
eeevil |
both have their (um) quirks, and the constraints of the XUL impose some of those |
| 12:23 |
kmlussier |
Poor eeevil. He hasn't even had a chance to telling us what he's thinking, and we're already throwing opinions at him. |
| 12:24 |
jeff |
kbutler: was it the lack of those penalties being defined? |
| 12:24 |
eeevil |
kmlussier: opinions: we all got 'em ;) |
| 12:24 |
eeevil |
so my first question for the room is, what do folks actually like about each interface, considered in isolation |
| 12:25 |
eeevil |
(let's accentuate the positive! ;) ) |
| 12:25 |
kmlussier |
eeevil: I have an answer for you, but part of me thinks this is the wrong place to ask the question. |
| 12:25 |
kmlussier |
Because we don't have many catalogers in here. |
| 12:25 |
* mmorgan |
agrees |
| 12:25 |
eeevil |
kmlussier: I'm "stirring the pot" right now, but this will /all/ go to the lists, fear not |
| 12:27 |
eeevil |
but, if nobody wants to answer here, that's OK too. this is just a seeding poll, not a FinalDecision(tm) thing, I promise |
| 12:27 |
kmlussier |
eeevil: OK, then, I'll bite. The big thing with the unified editor is that is saves clicks in the workflow. You enter all of the information on one screen. If you need to edit both the volume and copy info, you only need to edit it in one place. |
| 12:27 |
mmorgan |
One stop shopping! |
| 12:27 |
kmlussier |
We would have a very difficult time giving up that one-stop place. |
| 12:27 |
eeevil |
kmlussier: perfect, thank you! |
| 12:27 |
kmlussier |
Disclaimer: MassLNC funded development of the unified editor. |
| 12:27 |
eeevil |
heh, indeed |
| 12:29 |
jboyer-isl |
I think the unified editor is more popular here for the same reason. |
| 12:29 |
kmlussier |
I can't speak to advantages of the separate copy/volume editor. I sometimes wonder if Dyrcona's members are split because the unified editor wasn't quite finished when their libs were trained and therefore want to stick with what they know. But I shouldn't assume that's the reason. |
| 12:29 |
mmorgan |
Our libraries have never seen the "old way", we came live with the unified editor for all. |
| 12:30 |
jeff |
i don't have a specific answer to the question you asked, but i do want to voice support for taking the opportunity to develop a single better interface that takes advantage of the new environment, rather than picking one of the XUL interfaces to "win for now" and replacing it with a better interface later (which would probably result in a future with 'two interfaces' again) :-) |
| 12:30 |
eeevil |
anyone have any likes from the separate editors, off the top of their head? maybe csharp? (I think PINES liked that better when unified first happened, maybe?) |
| 12:30 |
* kmlussier |
agrees with jeff. |
| 12:31 |
* mmorgan |
agrees with jeff, too. |
| 12:31 |
jeff |
(which isn't to say that i'm saying anything new, just that "i strongly approve of the direction in which i think you are headed") |
| 12:31 |
eeevil |
jeff: right, that's the goal. do it better by taking the important user-time-saving parts of all, because it's not going to be XUL-in-html5 |
| 12:31 |
kmlussier |
I can think of one specific thing I don't like with the unified editor that I think isn't a problem with the separate editors. |
| 12:32 |
kmlussier |
bug 1040686 |
| 12:32 |
pinesol_green |
Launchpad bug 1040686 in Evergreen "Unified editor shouldn't always delete volumes" (affected: 11, heat: 62) [Undecided,Confirmed] https://launchpad.net/bugs/1040686 |
| 12:34 |
kmlussier |
IIRC, that was a design decision resulting from the fact that both were being edited in the same interface. But I can't recall the specifics now. Maybe because if you were editing one copy when you changed the call number, you don't necessarily want to change it for all of the copies attached to that call number? |
| 12:34 |
|
mllewellyn joined #evergreen |
| 12:35 |
* kmlussier |
notices that mllewellyn magically appeared as soon as we started discussing cataloging. |
| 12:35 |
eeevil |
kmlussier: ah, yes, good point. or, in the very least, move V holds with the rename-by-insert/delete (but the specific implementation details are not yet in stone in any case) |
| 12:35 |
* gmcharlt |
tosses something into the pot, which I think will turn into a set of threads on the mailing list |
| 12:35 |
mllewellyn |
I felt a disturbance in the force. |
| 12:36 |
gmcharlt |
namely - bits of volume & item maintenance that currently can be done separately, mostly because they need to be doable by circ staff |
| 12:36 |
* gmcharlt |
is thinking of mark damaged, and particularly replace barcode |
| 12:36 |
eeevil |
mllewellyn: "like a thousand asset.copy rows cried out in pain and were suddenly silenced" |
| 12:37 |
gmcharlt |
and so the question: whether any of that can be folded into the resulting volume/copy editor |
| 12:37 |
mllewellyn |
eeevil:precisely! |
| 12:38 |
mmorgan |
gmcharlt: To me those seem like functions that should be outside the editor |
| 12:38 |
mmorgan |
Since they are single attributes that circ users need to change |
| 12:40 |
kmlussier |
bshum: Ugh. Do I have to start backporting to 2.7 now? |
| 12:40 |
* kmlussier |
answers her own question. |
| 12:42 |
pinesol_green |
[evergreen|Snigdha Dagar] Updated formats - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a8f955f> |
| 12:42 |
pinesol_green |
[evergreen|Kathy Lussier] Small typo fix for Blu-Ray spelling - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=027768d> |
| 12:48 |
|
jihpringle joined #evergreen |
| 12:52 |
* csharp |
scrolls up |
| 12:52 |
kmlussier |
remingtron++ #GitHub Workflow instructions |
| 12:53 |
kmlussier |
remingtron: Very easy to follow and understand! |
| 12:54 |
csharp |
eeevil: PINES catalogers are currently using the unified interface AFAIK. There used to be many complaints about the item editor, but I haven't heard any lately |
| 12:55 |
csharp |
eeevil: I'm sure Elaine would reply to a list thread :-) |
| 12:56 |
kmlussier |
remingtron / yboston: I have just one question. In the end where it says to close out the github pullrequest, how is that done? I'm not seeing anything that jumps out at me. |
| 12:58 |
kmlussier |
snigdha26: I reviewed and pushed your updated formats into the docs repository. I probably won't have a chance to look at your other pullrequests today, but I'll take a look at them next week if somebody else doesn't get to it first. |
| 12:58 |
kmlussier |
snigdha26++ |
| 13:01 |
kmlussier |
Looking at the commit more closely, I wonder if I missed a step. snigdha26 is the author, and I see my signoff, but wouldn't we typically get the author's sign-off in the commit too? |
| 13:03 |
eeevil |
csharp: perfect, thanks! |
| 13:06 |
kmlussier |
I think I know why. I didn't use cherry-pick for my sign-off. I did it through a commit --amend because I had to use it anyway to change the name. I'm guessing cherry-pick is where the author's sign off is pulled in? |
| 13:08 |
jcamins |
kmlussier: I don't know where the branch in question is, but unless you deleted a sign off line when amending, most likely there just was no sign off from the author. |
| 13:09 |
|
dMiller joined #evergreen |
| 13:12 |
|
ericar joined #evergreen |
| 13:13 |
kmlussier |
jcamins: OK, thanks! |
| 13:34 |
snigdha26 |
kmlussier: sorry! I was away. Thank you for pushing the updated reforms :) I made the typo error, my bad. |
| 13:36 |
yboston |
kmlussier: when I cherry pick I usually use the "-n" glaf to get a chance to commit again, and at that point I can change the subject line of the commit (like add "Docs" at the beguining) |
| 13:36 |
kmlussier |
snigdha26: No problem. We all make those typos sometimes. Without them, we wouldn't so many bitesize docs out there. ;) |
| 13:37 |
yboston |
kmlussier: I also make sure I set the author like "git commit -s --author='Yamil Suarez yxz xyz.com' , if not after a cherry pick, I have seent he author changed to me an not the original author |
| 13:37 |
kmlussier |
yboston: Sure, I could have changed the subject when amending the commit too. |
| 13:37 |
kmlussier |
yboston: I did change the author. While amending it. |
| 13:38 |
kmlussier |
yboston: My question was in releation to why she wasn't one of the sign-offs. |
| 13:38 |
yboston |
OK |
| 13:39 |
yboston |
I have been adding those by hand, if the original commite did not add them themselves |
| 13:39 |
yboston |
*committer |
| 13:40 |
kmlussier |
yboston: oh, I see. So it might be good to add something to the intermediate isntructions telling people how to add the signoff in github. If it isn't already there. |
| 13:40 |
yboston |
not sure if it can be automated in gu=ithub, might have to be done manually |
| 13:42 |
kmlussier |
Hmmm...so how important is it to have the author's sign-off for doc commits then? I know with code commits, it's very important because of the DCO. |
| 13:43 |
kmlussier |
It just seems a little strange to add a sign-off on somebody else's behalf. It almost feels like forging a signature on a document. |
| 13:43 |
yboston |
I asked a smiliar question on the dev list about Josh's committs a while back |
| 13:43 |
yboston |
I did not get any response |
| 13:44 |
kmlussier |
Heh |
| 13:45 |
jcamins |
kmlussier: yboston: if the author is required to sign off every commit (and as far as I understand it, the author is), you can just have the authors do "git commit -s" instead of "git commit" when making changes. |
| 13:47 |
jcamins |
(rather than adding an extra sign off step) |
| 13:47 |
yboston |
jcamins: kmlussier and I do it all the time with our own commits, but some of these are Github committs, and I am not sure of a goof workflow for these volunteers to redo the commits witht he -s flag |
| 13:47 |
kmlussier |
jcamins: Yeah, but in this case, we're having some of our documentors make the changes by editing the files directly in github. I've never actually walked through the workflow myself, but I don't even know if they are typing "git commit" anything as part of that process. |
| 13:47 |
* kmlussier |
should probably walk through the process to see what's actually happening. |
| 13:47 |
jcamins |
kmlussier: oh, I thought you were having the documentors *push* commits to GitHub. |
| 13:48 |
kmlussier |
jcamins: No. We're trying to lower the barrier for getting documentation changes in. |
| 13:48 |
yboston |
kmlussier: some of them were editing right on the Github site, never using the commandline |
| 13:48 |
yboston |
kmlussier: I decided that these docs commits were mostly quite trivial, and since it was covering EG features |
| 13:49 |
yboston |
kmlussier: there was practically no chance that copyright woudl be violated int heir content |
| 13:49 |
jcamins |
Got it. In that case, undisregard my suggestion from the other day for how to deal with a firewall for people who want to use a local git repo. |
| 13:49 |
kmlussier |
yboston: Sure, I understand. I'm not disagreeing with the process. |
| 13:49 |
yboston |
kmlussier: I did not think you disagreeed, I just wanted to share my thinking |
| 13:50 |
yboston |
kmlussier: it flet wierd signing off for Josh, but we spoke about it beforehand |
| 13:50 |
yboston |
*felt weird |
| 13:51 |
kmlussier |
yboston: Oh, did you see my question above about how to close out a pullrequest? |
| 13:52 |
yboston |
kmlussier: yes, you might need to be a member of the "EG Github organization" |
| 13:52 |
yboston |
I am |
| 13:52 |
yboston |
I can try to close it for you. |
| 13:53 |
kmlussier |
yboston: I would prefer to try to close it myself. Just so that I don't have to ping somebody everytime I review a pullrequest. :) |
| 13:53 |
yboston |
OK, though one times I swear I did not see the close button becuase they had not done a proper fork? |
| 13:53 |
yboston |
let me know what happens |
| 13:54 |
jcamins |
kmlussier: yboston: now that I've seen the GH editing interface, you could just tell authors "Add the following line to the end of your 'extended description' to affirm your right to license this code under the GPL: Signed-off-by: Your Name <youremailyourdomain.com>" |
| 13:55 |
* jcamins |
will stop bugging you now, promise! |
| 13:55 |
kmlussier |
jcamins++ |
| 13:55 |
jcamins |
(I may have had my fingers crossed) |
| 13:55 |
gmcharlt |
:) |
| 13:55 |
kmlussier |
jcamins: It's not bugging at all. I always appreciate your help with git. I need all the help I can get. |
| 13:56 |
yboston |
jcamins++ |
| 13:56 |
kmlussier |
I have to say, I do feel like I'm starting to finally get a small grasp on understanding git. One day, I may even add git to my loves instead of my hates. |
| 13:57 |
kmlussier |
But not quite yet. |
| 13:57 |
kmlussier |
@whocares git |
| 13:57 |
pinesol_green |
Dyrcona, tsbere, bshum and csharp love git |
| 13:57 |
pinesol_green |
kmlussier hates git |
| 13:57 |
gmcharlt |
@love git |
| 13:57 |
pinesol_green |
gmcharlt: The operation succeeded. gmcharlt loves git. |
| 13:57 |
csharp |
@who loves git? |
| 13:57 |
pinesol_green |
ktomita loves git. |
| 13:57 |
* kmlussier |
suspects she is not the only person in this community who hates git. |
| 13:58 |
csharp |
@who hates git? |
| 13:58 |
pinesol_green |
yboston hates git. |
| 13:58 |
Dyrcona |
kmlussier: Ah, but you've never used the alternatives.... |
| 13:58 |
gmcharlt |
@who loves CVS? |
| 13:58 |
pinesol_green |
mnsri_ loves CVS. |
| 13:58 |
kmlussier |
Dyrcona: That's true. |
| 13:58 |
kmlussier |
It isn't really that I hate git. I just feel like git hates me. |
| 13:59 |
Dyrcona |
It is a bit opaque at first. |
| 13:59 |
* Dyrcona |
makes an understatement. |
| 14:00 |
kmlussier |
So does anyone know how I can become a member of the EG Github organization? |
| 14:01 |
yboston |
I like Git, specially now that I am using it succesfully with the main repo |
| 14:01 |
yboston |
@love git |
| 14:01 |
pinesol_green |
yboston: The operation succeeded. yboston loves git. |
| 14:02 |
csharp |
http://rogerdudler.github.io/git-guide/ is a good git guide (some NSFW language, prolly) |
| 14:06 |
Dyrcona |
kmlussier: I think gmcharlt can add you, maybe jeff or someone else. |
| 14:06 |
|
dMiller joined #evergreen |
| 14:06 |
gmcharlt |
kmlussier: what's your github username? your usual nick? |
| 14:07 |
kmlussier |
gmcharlt: Yes |
| 14:07 |
jeff |
Dyrcona: i am not a member of the org in question. |
| 14:08 |
Dyrcona |
jeff: Ah! I thought you would be. |
| 14:09 |
gmcharlt |
kmlussier: k, you have an inveite |
| 14:10 |
Stompro |
Is the web client supposed to work for mobile devices/android/IOS? I just tried logging in with my Android phone using the default android browser and the login form doesn't do anything. |
| 14:10 |
kmlussier |
yboston: If we do indeed believe it's important for doc authors to have a sign-off in their commit (and I'm open to opinions from all of you git lovers out there), then I would like to encourage documentors to add that sign-off line in the way jcamins suggested. |
| 14:10 |
kmlussier |
gmcharlt: Thank you! |
| 14:11 |
jeff |
Stompro: you might have success with Chrome or Chrome Beta, but I don't know if much if any attention to non-desktop browsers has yet been paid |
| 14:11 |
Dyrcona |
Stompro: I can't answer your question directly, but I will share that I have found the recent Chrome update to be buggy with password fields that contain special characters, specifically ; and &. |
| 14:11 |
jeff |
Stompro: in theory, Chrome or Chrome Beta would work... I am not surprised to hear that the built-in browser does not (unless you're on new enough Android so that the built-in IS Chrome...) |
| 14:12 |
Dyrcona |
Stompro: I've had to use the plain vanilla "Internet" browser on my Android to use the OPAC because of my password. |
| 14:12 |
jeff |
Dyrcona: interesting. which version of Chrome, and do you know if there's a bug report yet? |
| 14:12 |
jeff |
(on the Chrome/Chromium side, I would assume) |
| 14:13 |
Stompro |
Jeff: I'll try out chrome and see if that works. |
| 14:13 |
Dyrcona |
jeff: Chrome 37.0.2062.117. Not looked for a bug report. |
| 14:13 |
yboston |
kmlussier: do we want to bring this issue up at the next dev meeting or the dev hack-a-way? |
| 14:14 |
kmlussier |
yboston: Well, it's documentation, so maybe the next DIG meeting? |
| 14:14 |
jeff |
Stompro: i'd be interested to hear how well it works/doesn't |
| 14:14 |
yboston |
kmlussier: I want to get feedback form committers too |
| 14:14 |
yboston |
*from |
| 14:15 |
kmlussier |
Sure, but I'm guessing if committers had an opinion,, they would be speaking up now or would have responded to your e-mail to the dev list. |
| 14:16 |
gmcharlt |
FWIW, I prefer that all commits get the signoff |
| 14:16 |
Dyrcona |
Well, sign offs on documentation commits is a good idea. |
| 14:17 |
kmlussier |
gmcharlt , Dyrcona: Thanks! |
| 14:18 |
yboston |
if we do push for it, since some will be typing the signoff manually, I hope we can accept some variations like "Signed-of-by: Yamil" v.s. "Singed of by: Yamil" |
| 14:18 |
yboston |
(that was actuallly an accidental typo, but it fits) |
| 14:18 |
kmlussier |
And I'm assuming they are a good idea because the sign-offs have some meaning. But if we make a regular practice to manually add it on behalf of the author, it loses some meaning. |
| 14:19 |
yboston |
and feels weird |
| 14:19 |
gmcharlt |
yboston: smoky! |
| 14:19 |
kmlussier |
yboston: Sure, we can accept that, but you have to sign every time you use the "signed off" typo. |
| 14:19 |
gmcharlt |
but seriously, I don't think typos are a problem |
| 14:19 |
* Dyrcona |
would rather be singed off than singed on.... |
| 14:19 |
gmcharlt |
kmlussier: well, the signoff is supposed to mean something |
| 14:19 |
kmlussier |
Ack! A typo in my example typo. |
| 14:20 |
Dyrcona |
Depending on the git tool used, there are ways to automate adding the Signed-off-by: |
| 14:20 |
gmcharlt |
i.e., if you sign off on somebody's behalf, it should be because they've been asked and have stated that they've read the DCO and that their doc commits can be submitted |
| 14:20 |
yboston |
we should also link to the DCO fromt he DIG page too, so they know what the signoff represents |
| 14:21 |
gmcharlt |
as far as record-keeping goes -- doing so in a Github issue suffices IMO |
| 14:21 |
yboston |
gmcharlt: to be clear, do you mean if the commit came from github you are OK with skipping the signoff, but it if came from Git then they should add it |
| 14:21 |
yboston |
? |
| 14:22 |
gmcharlt |
yboston: no, I'm saying that I want the signoff added, but the submitter say that they've read and agree to the DCO in a GitHub issue is sufficient documentation that they've in fact agreed... |
| 14:22 |
gmcharlt |
if it's necessary for a DIG member to manually add a Signed-off-by: line on their behalf |
| 14:22 |
gmcharlt |
make sense? |
| 14:23 |
yboston |
gmcharlt: OK that makes sense, and would lead to us using the git command and keeping the proper spelling :) |
| 14:24 |
yboston |
we can ask them on the comments field of their Github commit to make sure they are OK with the DCO, andthey can |
| 14:24 |
yboston |
acknowledge reading it in their reply right there |
| 14:24 |
gmcharlt |
right |
| 14:25 |
Stompro |
jeff: no luck with Chrome or Chrome beta on my Galaxy S3 running A4.4.2. Login form never gives any feedback. |
| 14:26 |
jeff |
Stompro: thanks! as I mentioned, I don't think it's been tested or that working on mobile was a goal yet, but it's good to know what you experienced. |
| 14:30 |
Stompro |
Jeff: Sure, I know it is early days. We are just excited about the possibility of having staff functions on mobile devices in the future. |
| 14:31 |
jeff |
Stompro: which staff functions interest you most? |
| 14:31 |
kmlussier |
Holds pull list! |
| 14:34 |
Stompro |
Jeff: Basic Circ, Patron registration (Staff would love to take a tablet to an event and sign up customers and check out items on the spot). Pull list would be nice, save some paper, be able to scan items right from the shelf and sort right there. Inventory. |
| 14:37 |
* kmlussier |
likes all of Stompro's ideas. |
| 14:38 |
kmlussier |
But we need to have regular inventory before we can have mobile inventory. : / |
| 14:41 |
Stompro |
kmlussier: I use inventory loosely, for us checking in all the items on the shelves is an inventory. |
| 14:43 |
jeff |
item status modifier "update 'last seen' time" :-) |
| 14:43 |
gmcharlt |
kmlussier: yboston: et al. https://github.com/k88hudson/git-flight-rules |
| 14:45 |
kmlussier |
gmcharlt: Funny you should mention that. After helping a couple of people through git over the past few weeks, I was thinking of adding a section to the Evergreen git section on common problems that arise and what to do when they come up. |
| 14:46 |
yboston |
kmlussier++ |
| 14:46 |
kmlussier |
For example, when you cherry-pick a commit that needs to be rebased, how to abort the cherry-pick. |
| 14:46 |
yboston |
I have saved some error messages that could be used |
| 14:46 |
bshum |
git cherry-pick --get-me-the-hell-out-of-here |
| 14:46 |
bshum |
(kidding, that's not the real command) |
| 14:46 |
bshum |
For logs that's "git cherry-pick --abort" |
| 14:46 |
kmlussier |
bshum: I think I've tried that one. |
| 14:47 |
eeevil |
kmlussier: I just use git reset --hard, IIRC |
| 14:47 |
eeevil |
and then go rebase the branch before picking again |
| 14:48 |
kmlussier |
I've actually used both bshum's and eeevil's method. It all depends on which article comes up first when I google the problem. |
| 14:48 |
eeevil |
heh |
| 14:48 |
eeevil |
man git -> see: google |
| 14:48 |
kmlussier |
But instead of rebasing the branch, I usually add a comment to the LP bug asking somebody else to rebase it. :) |
| 14:56 |
|
RBecker joined #evergreen |
| 15:02 |
mmorgan |
In case anyone wants to add anything, here's the selfcheck override list bug: lp 1371752 |
| 15:02 |
pinesol_green |
Launchpad bug 1371752 in Evergreen "Org unit settings for "Selfcheck override events list" cannot be entered in the client's Library Settings Editor" (affected: 2, heat: 10) [Undecided,New] https://launchpad.net/bugs/1371752 |
| 15:04 |
Stompro |
kmlussier: I wonder if this is the TRIGGER that replaced the autogen.sh -u functionality in the DB. http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/sql/Pg/020.schema.functions.sql#l425 |
| 15:04 |
pinesol_green |
[evergreen|Yamil Suarez] Docs: for new "Imported As" column in Vandelay queue results view - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=556c52e> |
| 15:05 |
kmlussier |
Stompro: You would need to ask somebody wiser about these things than me. :) |
| 15:05 |
kmlussier |
But whatever the answer ends up being, I'm happy to backport those docs accordingly. |
| 15:07 |
Stompro |
kmlussier: found it http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=5154c4e237a76ca4fcda95fcea5381e9a07ce27d, It's like a treasure hunt. |
| 15:07 |
pinesol_green |
[evergreen|Steven Callender] LP#836768 Proximity update trigger - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=5154c4e> |
| 15:14 |
Stompro |
Now, I have no clue how to tell which releases have that... I'm sure branches or tags are involved... |
| 15:14 |
kmlussier |
2011? I would say 2.5 is fine then. |
| 15:23 |
Stompro |
I'll update the ticket for posterity. |
| 15:23 |
kmlussier |
Stompro: Thanks! It will serve as a reminder for me to merge it. |
| 15:38 |
Stompro |
yboston: Are my zips.txt docs on your todo list? Should I create a LP bug for that? |
| 15:39 |
yboston |
Stompro: yes they are, but I wont get to them today. I think the comit should be fine wihout a pull request. if not I will let you know |
| 15:40 |
yboston |
Stompro: since I am assigned to push it, we could skip the LP bug, but in theory it could keep someone else from starting owrk on it |
| 15:40 |
yboston |
*work |
| 15:41 |
kmlussier |
Stompro++ #Jumping into doc writing so quickly! :) |
| 15:44 |
Stompro |
It's a great way to learn about how the system work. I've been lurking since 2005, but now I've got real reason to get more involved :) |
| 15:45 |
yboston |
Stompro++ |
| 15:47 |
kmlussier |
Heh. I just came across an old e-mail from gmcharlt to Stompro suggesting the signed off line in github commit messages. And so we come full circle. :) |
| 15:48 |
kmlussier |
Stompro: Are you working with a single library going to Evergreen or is it a consortium? |
| 15:48 |
|
gmcharlt joined #evergreen |
| 16:18 |
kmlussier |
@dessert [someone] |
| 16:18 |
* pinesol_green |
grabs some Lemon Chess Pie for jventuro_ |
| 16:18 |
|
remingtron joined #evergreen |
| 16:27 |
Dyrcona |
@swill |
| 16:27 |
* pinesol_green |
grabs a bottle of Extra Dry Champale and sends it sliding down the bar to Dyrcona |
| 16:27 |
* Dyrcona |
shudders....*champale* |
| 16:28 |
kmlussier |
yuck |
| 16:28 |
kmlussier |
@swill Dyrcona |
| 16:28 |
* pinesol_green |
grabs a can of Sparks Red and sends it sliding down the bar to Dyrcona |
| 16:28 |
Dyrcona |
Well, that's better, maybe. :) |
| 16:31 |
mmorgan |
Kinda reminds me a little of a cd mixup while working circ once. Patron borrowed a Madonna CD, got home and opened the case and found the Carpenters. |
| 16:32 |
kmlussier |
Heh |
| 16:41 |
Dyrcona |
:) |
| 16:46 |
|
gmcharlt joined #evergreen |
| 16:46 |
|
gmcharlt joined #evergreen |
| 17:03 |
|
mdriscoll left #evergreen |
| 17:03 |
* kmlussier |
needs to put her work things away and start planning a birthday party. |
| 17:03 |
kmlussier |
Have a nice weekend everyone! |
| 17:14 |
|
mmorgan left #evergreen |
| 17:31 |
|
dMiller joined #evergreen |
| 17:40 |
pinesol_green |
Incoming from qatests: Test Failure - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:52 |
berick |
huh, browser client installer deps -> node plugin error |
| 18:35 |
|
dbwells joined #evergreen |
| 20:52 |
|
gmcharlt joined #evergreen |
