Time |
Nick |
Message |
03:55 |
|
dbwells_ joined #evergreen |
03:55 |
|
remingtron_ joined #evergreen |
04:53 |
|
pastebot0 joined #evergreen |
04:53 |
|
ningalls joined #evergreen |
05:03 |
pinesol_green |
Incoming from qatests: Test Failure - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
06:42 |
|
ningalls joined #evergreen |
07:41 |
|
Callender joined #evergreen |
07:41 |
|
eeevil joined #evergreen |
07:51 |
|
collum joined #evergreen |
08:01 |
|
rjackson-isl joined #evergreen |
08:04 |
|
jboyer-isl joined #evergreen |
08:08 |
|
Dyrcona joined #evergreen |
08:10 |
|
akilsdonk joined #evergreen |
08:27 |
|
Shae joined #evergreen |
08:33 |
|
mrpeters joined #evergreen |
08:44 |
|
mmorgan joined #evergreen |
08:47 |
|
mrpeters left #evergreen |
09:22 |
|
krvmga joined #evergreen |
09:23 |
krvmga |
a patron sent me a note that she couldn't see the dropdown for placing a hold in My Lists when she was on her mobile. |
09:24 |
krvmga |
this seems to be the case on our server as well. |
09:24 |
krvmga |
is this just a spot that the responsive catalog design didn't get to? |
09:28 |
krvmga |
i've tested this on a vanilla version of 2.5 and it seems to be the case. |
09:30 |
Dyrcona |
krvmga: It seems bug worthy to me. I haven't really tried using the catalog much from my phone. |
09:30 |
pinesol_green |
[evergreen|Jason Stephenson] Fix 030.schema.metabib.sql breakage. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b0c4299> |
09:34 |
|
yboston joined #evergreen |
09:35 |
Dyrcona |
tsbere++ # for testing and pushing |
09:47 |
jeff |
Dyrcona++ tsbere++ |
09:48 |
Dyrcona |
You should thank tsbere. He noticed the break and I didn't, 'cause he tried to build a fresh database yesterday. |
09:48 |
krvmga |
https://bugs.launchpad.net/evergreen/+bug/1353509 |
09:48 |
pinesol_green |
Launchpad bug 1353509 in Evergreen "responsive catalog design fail in my lists" (affected: 1, heat: 6) [Undecided,New] |
09:48 |
Dyrcona |
I'll have to test these things with a fresh database, too, from now on. |
09:49 |
Dyrcona |
The automated build bot caught it, too. |
09:51 |
dbs |
krvmga: please include your specific mobile device and mobile browser in the bug report, just in case it's limited to a specific combination |
09:52 |
dbs |
And a bug report title of "Unable to place hold in My Lists from a mobile device" would be both a more useful description and less negative than "responsive catalog design fail" |
09:54 |
dbs |
Maybe it's the case that it's just a limitation of the hover vs. touch event model on mobile devices, and not due to the responsive catalog design, in which case you might have insulted those who worked on the responsive design for no good reason... |
10:06 |
krvmga |
dbs: the condition can be tested in a web browser by resizing the browser to the mobile device size you'd like |
10:09 |
krvmga |
dbs: i changed the title as you suggested and added the reported device and os as well as the browser info |
10:09 |
krvmga |
https://bugs.launchpad.net/evergreen/+bug/1353509 |
10:09 |
pinesol_green |
Launchpad bug 1353509 in Evergreen "Unable to place holds in My Lists from mobile device" (affected: 1, heat: 8) [Undecided,New] |
10:18 |
bshum |
krvmga: Well I think I agree with dbs that any specific information about how the bug was originally discovered can be helpful information to others who test the issues noted in bugs. |
10:18 |
krvmga |
bshum: i added it. |
10:30 |
krvmga |
in eg 2.6, openils/var/opac/parts/base.tt2, semiauto.css and style.css are linked. are these links obsolete? |
10:32 |
bshum |
krvmga: I think I see the issue for mobile view of my lists. |
10:32 |
bshum |
http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/templates/opac/css/style.css.tt2;h=84d5fa5b175eaf53e5917730bbe23321eb4a8d03;hb=refs/heads/master#l1965 |
10:32 |
bshum |
Is a part where the column headers are hidden |
10:32 |
bshum |
and because the column is what contains the place hold (and also, notes) option |
10:33 |
bshum |
But the row itself contains no information |
10:33 |
bshum |
The column(s) go poof |
10:33 |
krvmga |
guessing that going poof = not good :) |
10:34 |
bshum |
Well, realistically I think we need to redesign the my list area to work better in mobile circumstances. |
10:34 |
bshum |
There are so many repeated buttons and actions it makes me unhappy :) |
10:34 |
bshum |
It's a very busy area. |
10:39 |
bshum |
Anywho |
10:39 |
bshum |
I added my findings to the bug for now and marked it confirmed. |
10:39 |
bshum |
Maybe it's something we'll work on later at the Hackaway or whenever time permits again. |
10:40 |
|
jwoodard joined #evergreen |
10:41 |
krvmga |
what's the best way for me to stay in the loop as far as opac development goes? being out of the loop has caused me more than a few headaches because of all of the customizations that cwmars has. |
10:42 |
Dyrcona |
krvmga: Monitoring Launchpad, monitoring IRC, monitoring the dev mailing list, basically being highly involved in the community. |
10:43 |
bshum |
Or reading every git commit and seeing what changes are made to every file in Open-ILS/src/templates/opac/.. |
10:43 |
bshum |
:D |
10:43 |
bshum |
(but I read every commit anyways) |
10:43 |
krvmga |
bshum: :P |
10:44 |
krvmga |
i'm gathering that there's no particular "opac development interest group" and things are just generalized throughout the community. |
10:45 |
Dyrcona |
Actually, getting the git commit email is the best way to stay up on what is going into Evergreen. |
10:45 |
bshum |
krvmga: I think care for the catalog stretches across all groups fairly broadly. |
10:45 |
bshum |
It's the most visible point of the ILS |
10:46 |
berick |
OPAC release notes should offer some help there as well |
10:46 |
bshum |
So if we started trying to silo discussions about it into a specific group or list, it would just add to making it more difficult to know what's happening. Since work on it covers many angles. |
10:47 |
bshum |
But that's just my opinion. |
10:48 |
dbs |
Sorry for disappearing folks, I had a training session to give that I had to run off to |
10:50 |
krvmga |
anyway, back to style.css and semioauto.css in base.tt2: are those links obsolete? |
10:51 |
pinesol_green |
[evergreen|Yamil Suarez] Docs: How to use the MARC 007 Physical Characteristics Wizard - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7e5604c> |
10:51 |
krvmga |
<link rel="stylesheet" type="text/css" href="[% ctx.media_prefix %]/css/skin/default/opac/semiauto.css" /> |
10:51 |
krvmga |
<link rel="stylesheet" type="text/css" href="[% ctx.opac_root %]/css/style.css" /> |
10:51 |
dbs |
krvmga++ bshum++ # for looking deeper into the mobile issue |
10:52 |
dbs |
krvmga: no, style.css.tt2 generates css/style.css IIRC |
10:52 |
dbs |
and semiauto.css still hase some elements that have not made their way into style.css, IIRC |
10:53 |
krvmga |
okey dokey then :) |
10:53 |
krvmga |
dbs++ |
10:59 |
|
kmlussier joined #evergreen |
11:01 |
|
akilsdonk_ joined #evergreen |
11:07 |
dbs |
Hey Dyrcona, re: #1304462 I signed off on your commit but haven't pushed anything, so ysuarez probably shouldn't add the release note to the docs until the commits get pushed :) |
11:08 |
dbs |
bug 1304462 that is (zoia) |
11:08 |
pinesol_green |
Launchpad bug 1304462 in Evergreen "Add 264 tag values to Record Summary" (affected: 3, heat: 20) [Wishlist,In progress] https://launchpad.net/bugs/1304462 - Assigned to Ben Shum (bshum) |
11:09 |
csharp |
krvmga: (late to conversation, but) I would add to what bshum and Dyrcona said that it helps to run the master branch on a test machine and assist with testing bugfixes and new features |
11:09 |
yboston |
dbs: thaks for the heads up. Would it help if I did a collab branch and cherry picked Dyrcona's commit and add the release notes there? |
11:09 |
csharp |
that way it's not just a matter of hearing about features, but actually using them in their raw state |
11:10 |
dbs |
yboston: well of course I would like my commit to be signed off too :) |
11:10 |
dbs |
but sure, that would help, then we can sign off on your release note + push the whole thing |
11:10 |
krvmga |
csharp: thanks. (now just has to learn how to install master instead of x.x versions) |
11:11 |
bshum |
csharp: Sort of a "don't complain about the pie's ingredients after it's finished baking" sort of approach? :D |
11:11 |
csharp |
krvmga: once you've built the server, it's mostly a matter of knowing how to check out and install branches on git |
11:11 |
csharp |
s/on/from/ |
11:11 |
* krvmga |
adds to list of must-learn-how-to-do. |
11:12 |
csharp |
bshum: or taste the soup before it's served ;-) |
11:12 |
bshum |
csharp: Ahh, I like that one better :) |
11:12 |
krvmga |
csharp: i like that one, too :) |
11:14 |
yboston |
dbs: I forgot about the schema.org changes. I probably won't have time to test the schema.org changes in a test VM this week, I can wait for soemone else to sign off on those changes |
11:14 |
yboston |
before making the collab branch |
11:14 |
yboston |
or I can just wait until both sets of changes are pulled in |
11:15 |
csharp |
oh btw, I volunteered last week to test web sockets - unfortunately, I got bogged down trying to get that running (mostly confusion about apache vs apache-websockets and whether both should be running and whether there needs to be separate config? etc.) |
11:24 |
bshum |
@later tell jeffdavis Not sure if you had more work on https://bugs.launchpad.net/evergreen/+bug/1046420 to do (the bug comments lead me to believe there is some more to be done), let us know later. |
11:24 |
pinesol_green |
bshum: The operation succeeded. |
11:24 |
pinesol_green |
Launchpad bug 1046420 in Evergreen "Wishlist: Cut off due dates so they don't extend past card expiration date" (affected: 3, heat: 26) [Wishlist,Triaged] |
11:26 |
bshum |
dbs: I believe you expressed interest in that bug too, since it was one of the things you need before we dropped circ scripts? |
11:48 |
Dyrcona |
dbs: I was on a conference call, but yeah, point well taken about the release note. :) |
11:48 |
Dyrcona |
My fingers get ahead of my brain sometimes. |
12:00 |
|
mllewellyn joined #evergreen |
14:06 |
|
collum joined #evergreen |
14:25 |
pinesol_green |
[evergreen|Bill Erickson] LP#1319519 Add to PO limits to new/pending PO's - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=101d652> |
14:34 |
bshum |
dbs: Dyrcona: yboston: I finally found my old branch that I put together to switch out the publisher, etc. for 264 display in search results branch. |
14:34 |
bshum |
Would it make sense for me to start a collab branch with everything in it? |
14:35 |
bshum |
I'll start by pulling Dyrcona and dbs stuff and signing off on them |
14:35 |
bshum |
And then add in my commits and yboston's notes |
14:35 |
bshum |
If it looks good, we can push the whole thing on up |
14:35 |
* bshum |
tests |
14:39 |
|
hbrennan joined #evergreen |
14:42 |
dbs |
bshum++ |
14:42 |
* dbs |
will need to look at bug 1046420 too |
14:42 |
pinesol_green |
Launchpad bug 1046420 in Evergreen "Wishlist: Cut off due dates so they don't extend past card expiration date" (affected: 3, heat: 26) [Wishlist,Triaged] https://launchpad.net/bugs/1046420 |
14:43 |
hbrennan |
Is there a dev mtg going on? |
14:43 |
bshum |
hbrennan: Not at the moment. |
14:43 |
dbs |
hbrennan: just the regular 24-hour-a-day kind :) |
14:43 |
hbrennan |
dbs: hehe |
14:43 |
hbrennan |
Just checking |
14:44 |
hbrennan |
I just had a patron ask a really interesting question. "When I place a hold, can I be notified what place in the line I am?" |
14:44 |
hbrennan |
I thought it was a great idea |
14:45 |
hbrennan |
Hold on Blah Blah was successful. There are 4 holds ahead of you. |
14:45 |
hbrennan |
That type of thing |
14:45 |
* dbs |
suspects for sites with complex holds, the line may be more of a lie |
14:45 |
hbrennan |
possibly |
14:45 |
dbs |
But for straightforward hold setups, that would be nice, yeah. |
14:45 |
hbrennan |
It's the most common questions following a hold being place though |
14:46 |
bshum |
For a standalone library, it's less crazy. |
14:46 |
hbrennan |
and it's not the quickest workflow to find |
14:46 |
bshum |
With consortiums forget about it :) |
14:46 |
bshum |
When you're one building, holds progress slightly more logically. |
14:46 |
bshum |
Only slightly. |
14:46 |
bshum |
It'll still skip over people who are bad |
14:46 |
hbrennan |
Yeah, I don't even want to think about floating and transits and all that |
14:46 |
bshum |
Or if frozen holds come back |
14:46 |
csharp |
a straight queue is impossible in PINES |
14:46 |
hbrennan |
We don't skip bad people! We lure them in |
14:46 |
bshum |
So more or less it's basically a lie. |
14:47 |
hbrennan |
You have a hold, come on in! Oh, but first give us $20. |
14:47 |
csharp |
I think PINES libraries tried to charge for holds at one point in the distant past, but it was not adopted as policy |
14:48 |
csharp |
bribes weren't part of that calculus though ;-) |
14:48 |
hbrennan |
I sometimes want to do that with the people who put holds on 30 things that are available, just so we'll pull them and have them waiting (I know we can turn this off... but we're nice) |
14:49 |
csharp |
"you're number 38 on the list, but if you *know* somebody, you're number 10" |
14:49 |
hbrennan |
ha |
14:49 |
* csharp |
has dealt with patrons who wanted it to actually work that way |
14:49 |
csharp |
(not in PINES) |
14:50 |
hbrennan |
So the "place in line" feature wouldn't do much for consortium or complicated holds systems, but it a feasible project? |
14:50 |
hbrennan |
There is already a notification of success... and there's a way to find the place in line.. so it would be merging them |
14:51 |
hbrennan |
(Holly strikes again by grossly simplifying the process and enraging the brilliant dev minds!) |
14:52 |
bshum |
dbs: yboston: Dyrcona: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/bshum/lp1304462_rda_264 |
14:52 |
yboston |
I have a git workflow question, I am preparing some documentation commits from a DIG member to inlude in master & 2.6 |
14:53 |
bshum |
That's the collab I started rolling with. I have to test it again on a server to make sure my commits don't break anything new. |
14:53 |
bshum |
It's been awhile. |
14:53 |
csharp |
in a FIFO setup, that sounds reasonable, but in the "default" setup that was built for contant transits across systems, no that wouldn't work |
14:53 |
csharp |
s/contant/constant/ |
14:54 |
hbrennan |
csharp: Sounds like it would be something we'd have to take on ourselves. Thanks! |
14:55 |
hbrennan |
Back to work you guys! |
14:55 |
hbrennan |
and by guys I mean "yous guys" meaning everyone |
14:55 |
mmorgan |
hbrennan: I'll just throw this out there - couldn't one set up a trigger notification based on a hold being placed, and send the queue position (however flawed it may be) in the email message? |
14:55 |
pinesol_green |
[evergreen|Remington Steed] Docs: Fix patron registration screenshot - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b0691c4> |
14:56 |
hbrennan |
mmorgan: Oh, good idea... I haven't played with trigger notifications since our set up |
14:56 |
bshum |
mmorgan: I played with creating a notification for that, but I think that the hook or event didn't work for me. |
14:56 |
bshum |
In any event I never got notified whenever a hold was created. |
14:56 |
yboston |
bshum: I believe you made that release notes commit what I posted on LP, did you just use git ci --amend? |
14:56 |
hbrennan |
Yikes. If bshum can't make it happen... there is no hope |
14:56 |
yboston |
(git commit --amend) |
14:56 |
bshum |
yboston: I used something like git commit --author="your name <email>" |
14:57 |
bshum |
And that set the author to you to give you the credit |
14:57 |
yboston |
bshum: good timing, becuase I need to do that to give Erica credit on soem docs comits |
14:58 |
kmlussier |
I've done something like that with doc commits before. |
14:59 |
yboston |
I already pushed of her commits to master, but now noticed that I had her signoff, but she is not listed as the author |
14:59 |
yboston |
:( |
14:59 |
yboston |
I'll do that from now on |
15:00 |
yboston |
the git commit --author="your name <email>" |
15:01 |
bshum |
yboston++ ericar++ |
15:01 |
bshum |
remingtron++ too |
15:03 |
yboston |
for the record, shoudl I do anything about the commit I did not give her credit on? There have been two new commits added to master since, so a simple amend will not work. |
15:04 |
bshum |
We have since moved on. |
15:04 |
yboston |
I could fix it for when I backport to the 2.6 branch |
15:26 |
pinesol_green |
[evergreen|Bill Erickson] LP#1279998 marc_stream_importer support alternate match strategies - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1e3e3e7> |
15:26 |
pinesol_green |
[evergreen|Bill Erickson] LP#1279998 marc_stream_importer option no-match import; delete repairs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d0399c9> |
15:26 |
pinesol_green |
[evergreen|Bill Erickson] LP#1279998 marc stream importer release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=aa3bed5> |
15:28 |
Dyrcona |
On the commit thing: I've done it a couple of times with patches to give the patch author credit, not me. |
15:38 |
pinesol_green |
[evergreen|Erica Rohlfs] Docs: MARC Record Attribute Definitions, Multi Valued Fields, Composite Record Attributes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1f8b86d> |
16:00 |
pinesol_green |
[evergreen|Erica Rohlfs] Docs: How to perform metarecord search and hold - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ae82e4d> |
16:00 |
|
vlewis joined #evergreen |
16:04 |
pinesol_green |
[evergreen|Erica Rohlfs] Docs: How to use MARC Fixed Field Editor - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c901231> |
16:12 |
pinesol_green |
[evergreen|Erica Rohlfs] Docs: How to create routing list and shows address on routing list - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b69c63b> |
16:46 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
16:46 |
phasefx |
yay |
17:15 |
|
mmorgan left #evergreen |
17:19 |
|
kmlussier left #evergreen |
17:23 |
remingtron |
berick: FYI, I plan to test bug 1329503 tomorrow morning |
17:23 |
pinesol_green |
Launchpad bug 1329503 in Evergreen "View / Edit Existing Reports" (affected: 5, heat: 30) [Wishlist,New] https://launchpad.net/bugs/1329503 |
17:24 |
remingtron |
unless you have enough eyes on that already, then I'll test something else |
17:25 |
berick |
remingtron++ # that would be much appreciated |
17:25 |
remingtron |
great, will do |
17:25 |
berick |
beware it relies on another LP / branch mentioned in the ticket |
17:27 |
remingtron |
right, thanks for the reminder |
17:32 |
|
RoganH joined #evergreen |
21:47 |
|
dcook joined #evergreen |
21:58 |
|
dcook joined #evergreen |