| Time |
Nick |
Message |
| 02:10 |
|
zerick joined #evergreen |
| 03:13 |
|
Callender_ joined #evergreen |
| 03:16 |
|
zxiiro joined #evergreen |
| 10:50 |
* csharp |
gets a nofication that the web server is down again - indeed it is |
| 10:51 |
csharp |
pinesol_green: you there? |
| 10:51 |
pinesol_green |
csharp: Mr. Spock: Something fascinating just happened. |
| 10:58 |
* bshum |
stirs awake. |
| 11:01 |
|
serflog joined #evergreen |
| 11:01 |
|
Topic for #evergreen is now Welcome to the #evergreen library system channel! | We are publicly logged. | Large pastes at http://paste.evergreen-ils.org |
| 11:01 |
|
pinesol_green joined #evergreen |
| 11:01 |
|
pastebot joined #evergreen |
| 11:01 |
bshum |
csharp++ |
| 11:02 |
csharp |
bshum: is that all the bots? ;-) |
| 11:02 |
bshum |
Heh, yes. |
| 11:02 |
csharp |
good |
| 11:02 |
bshum |
I fired up the ilbot |
| 11:02 |
csharp |
oh good |
| 11:02 |
csharp |
I did OS upgrades |
| 11:03 |
bshum |
Cool deal. |
| 11:51 |
|
stevenyvr2 joined #evergreen |
| 12:30 |
dbs |
Our 2.4 upgrade is not going well... stuck on renewals failing with circ errors related to an inability to find nearest hold. Good fun. Gotta run now though, back later |
| 12:31 |
dbs |
Also having fun with auth_proxy getting undefined usernames and passwords when logging in via staff client, so had to disable auth_proxy for now. Fun! :) |
| 12:46 |
paxed |
dbs: "Fun" |
| 15:02 |
|
stevenyvr2 left #evergreen |
| 21:54 |
|
pinesol_green joined #evergreen |
| 22:25 |
dbs |
Forced client upgrades working on our 2.4 system. Yay! auth_proxy login seems to be working with the new staff client. Yay! |
| 22:35 |
pastebot |
"dbs" at 204.193.129.146 pasted "Renewals failing on 2.4 system - objects getting passed into SQL?" (16 lines) at http://paste.evergreen-ils.org/10 |
| 22:41 |
dbs |
I think I hate holds even more than I ever did before. |
| 22:42 |
|
ldwhalen joined #evergreen |
| 22:43 |
jeff_ |
'evening |
| 22:43 |
ldwhalen |
hello |
| 22:43 |
dbs |
hiya |
| 22:52 |
jeff_ |
looking at your paste and the code in master, it looks like the nearest_hold sub in Publisher/action.pm is receiving a fleshed copy object and trying to use $cp->circ_lib when it should be using $cp->circ_lib->id |
| 22:52 |
jeff_ |
not sure why it isn't affecting more people, or if it looks like that in 2.4 (again, looked at master) |
| 22:53 |
dbs |
Yeah, I'm creating a clean rel_2_4 system right now to see what's happening |
| 22:54 |
jeff_ |
i could of course be wrong. looks like master has had what i think is an error since April. |
| 23:02 |
dbs |
Hmm. Works with the admin user, in-db circulation |
| 23:09 |
dbs |
Works with default scripts too. |
| 23:10 |
jeff_ |
i can see a different code path in the circ code resulting in a fleshed circ_lib object on the copy one way and not another, but i'm not sure if config would result in that |
| 23:10 |
jeff_ |
which is to say, i wonder why this isn't more well known. |
| 23:12 |
dbs |
Different soft / hard hold boundaries? |
| 23:12 |
* dbs |
grasps at straws. |
| 23:12 |
* dbs |
suspects holds are made of straws |
| 23:13 |
dbs |
500+ lines of ifs and elseifs; pylint would be very grumpy about that :) |
| 23:15 |
jeff_ |
$MK_ENV_FLESH in Circulate.pm seems to indicate that circ_lib should not be being fleshed... |
| 23:24 |
dbs |
ah good, I've narrowed it down to a problem in our rel_2_4_mergery_tpac branch, vs. rel_2_4 |
| 23:24 |
dbs |
thanks for humouring me |
| 23:24 |
dbs |
not sure _what_ the difference is, yet, but soon to find out. |
| 23:25 |
jeff_ |
is it only tpac renewals that have the issue? |
| 23:26 |
dbs |
staff client renewals too |
| 23:26 |
dbs |
git diff origin/rel_2_4 rel_2_4_mergery_tpac -- Open-ILS/src/perlmods # will tell all |
| 23:33 |
dbs |
AHA |
| 23:34 |
dbs |
scripts it is. but not the generic scripts; our scripts |
| 23:37 |
|
rri joined #evergreen |
| 23:37 |
dbs |
perhaps, specifically, the use of copy.fetchBestHold() which leads to my ($hold) = $holdcode->find_nearest_permitted_hold( $e, $copy, $reqr, 1 ) |
| 23:39 |
|
rri joined #evergreen |
| 23:39 |
jeff_ |
and thus answering the question of why this isn't more widely known. :-) |
| 23:42 |
dbs |
It may be broader than that - but seems likely that the holds improvement stuff wouldn't have taken script-based circ into account when they started passing objects around |
| 23:42 |
dbs |
Ironically, we had planned to cut over to in-db circ but decided to take things one step at a time: get a stable 2.4 first, then cut over to in-db a few weeks later. |
| 23:57 |
dbs |
Hmm. Maybe not _just_ our scripts. |
