Evergreen ILS Website

IRC log for #evergreen, 2022-03-17

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat

All times shown according to the server's local time.

Time Nick Message
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
06:49 JBoyer joined #evergreen
07:30 rjackson_isl_hom joined #evergreen
07:57 rfrasur joined #evergreen
08:11 mantis1 joined #evergreen
08:30 Keith-isl joined #evergreen
08:38 mmorgan joined #evergreen
08:51 Dyrcona joined #evergreen
09:15 Keith_isl joined #evergreen
09:31 terranm joined #evergreen
09:35 jvwoolf joined #evergreen
09:38 Dyrcona Does anyone have a workaround for npm install hanging in Open-ILS/src/eg2 on extract:rsjs?
09:38 Dyrcona That should be extract:rxjs...
09:41 rjackson_isl_hom joined #evergreen
09:51 Dyrcona chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
09:52 Dyrcona I'm going to ask this question again: Why are we using npm/Node.js to manage dependencies?
09:52 pinesol News from commits: Added Author to Pending view in Item Buckets <https://git.evergreen-ils.org/?p=E​vergreen.git;a=commitdiff;h=65baa5​07bb9037a244bf05cf5aabe8c331799ed5>
09:52 pinesol News from commits: Add Author field to Item buckets. <https://git.evergreen-ils.org/?p=E​vergreen.git;a=commitdiff;h=864193​e981ac8387e0d64c07d53586b6a5b3bffe>
10:05 Dyrcona I have tried a couple of things that I've found online from previous instances of rxjs not installing and none of them work: 1. running npm as root, 2. using ---unsafe-perm, 3. deleting package-lock.json and node_modules.
10:07 Dyrcona npm update hangs, too.
10:19 Dyrcona It is not reassuring that the npm project and repositories on github are returning 500 errors.
10:21 Dyrcona Oh, nice. I think github is having issues. I got an internal server pushing to one of my own repos.
10:26 terranm yikes
10:26 csharp_ re: node deps - I too am interested in The Plan™ for how we should be handling those when they warn or show deprecation
10:26 csharp_ github actually autocommitted to my forked EG repo upgrading karma for instance
10:28 Dyrcona github can do that. If you go to the Evergreen mirror on github, it will tell you about the security issues and will offer to update the dependencies.
10:28 csharp_ yeah - another point for github :-)
10:29 Dyrcona Also, I'm looking at some on repo.or.cz, and I'm surprised that service is still around. I had an account there.
10:29 Dyrcona s/some/something/
10:32 Dyrcona Bet I still have the account, but the key is likely out of date.
10:33 Dyrcona csharp_: I have occasionally run npm update, and Evergreen has always worked afterward, but we may have some packages pinned to specific versions, still.
10:34 csharp_ probably a worthwhile security discussion
10:35 Dyrcona Given the number of malicious packages that turn up, our use of npm is a worthwhile security discussion.
10:38 Dyrcona Github seems to be OK, now. I can access npm.
10:39 terranm gmcharlt: Yesterday Bill revised the patch for bug 1958265 that you have on festivus - could you please update it with the newest version for testing?
10:39 pinesol Launchpad bug 1958265 in Evergreen "Angular Holds Pull List - Download CSV and Print Full Grid missing barcode" [Medium,Confirmed] https://launchpad.net/bugs/1958265
10:40 terranm gmcharlt: Bill also updated the patch for bug 1950826 which is also loaded onto festivus
10:40 pinesol Launchpad bug 1950826 in Evergreen 3.7 "invalidate email silent failure" [High,Confirmed] https://launchpad.net/bugs/1950826
10:52 Dyrcona Well, I'm not any closer to resolving the extract rxjs issue.
10:56 berick Dyrcona: it will finish if you give it time.  annoying, for sure, but it will eventually complete.
10:57 Dyrcona Yeah, one of the closed issues from 2018 said that. It was where I picked up trying --unsafe-perm in the discussion.
10:59 * Dyrcona was about to "close" a Lp bug that I'm no longer interested in but 33 other people say it affects them.
11:01 Dyrcona JBoyer: I have a question about https://bugs.launchpad.net/eve​rgreen/+bug/1914625/comments/2. Did you actually try it in vim to see if did stop the vim mode line from working?
11:01 pinesol Launchpad bug 1914625 in Evergreen "Add Emacs mode to fm_IDL.xml" [Wishlist,New]
11:02 * Dyrcona ponders "closing" that bug or possibly redoing the patch.
11:07 rjackson_isl_hom rfrasur does this still mean I am not to actually start the bib loading until after 5 PM even if it were ready say at 12 ?
11:07 rjackson_isl_hom due to announced cataloging freezer timeframe
11:09 rjackson_isl_hom oops sorry wrong window :(
11:10 rfrasur Hi everyone!  We're migrating a library today.  It's a big deal.  Please send all your good energy.  Everything's fine :D.
11:10 * Dyrcona sends good vibes to rfrasur and rjackson_isl_hom.
11:10 rjackson_isl_hom Dyrcona++
11:11 rfrasur Dyrcona++
11:11 mantis1 *sends Amish cheese*
11:11 Dyrcona :)
11:11 Dyrcona mantis1++
11:11 mmorgan Good Luck!!
11:11 rfrasur Oh man.  That's VERY GOOD energy
11:11 rfrasur mantis1
11:11 rfrasur mmmorgan++
11:11 rfrasur mantis1++
11:12 Dyrcona So, git add -p is nice, but it's tedious when you want to keep patch 231 out of 231 and not the rest.....
11:14 Bmagic miker: JBoyer: In your esitmation, this bug where Evergreen trips on many-to-one hold notes for the hold pull list, is not an issue in EG >= 3.8 because of the interface port?
11:16 jvwoolf rfrasur++ ##We're all fine here now, thank you. How are you? :-D
11:18 rfrasur jvwoolf++ # I'm glad you're all fine now.  I'm pretty equal parts excited and nervous but inching toward more excited as minutes go by.
11:19 jvwoolf rfrasur: I was sending you some Star Wars energy: https://www.youtube.com/watch?v=KYAbFqkvzQA
11:20 mmorgan jvwoolf++
11:20 rfrasur lol, thank you :-)
11:20 rfrasur jvwoolf++
11:22 mantis1 Clarification for our docs; for Hold Groups, when creating a new hold group, there's a checkbox that overrides all hold-blocking conditions possible.  Does this negate hold rules or hold-blocking conditions specifically associated with the patron account?
11:23 miker Bmagic: IMO, yes. for 3.6/3.7, I'd mostly like to stop it from asking for notes at all in that particular call-- they're not actually returned in the body of the query, so I suspect that's just being pulled later or being fleshed or something.
11:30 mmorgan mantis1: My understanding is that it overrides the patron block on placing holds.
11:31 terranm rfrasur++ good luck!
11:31 rfrasur terranm++
11:31 mantis1 mmorgan++ thanks I just wanted to check on that
12:28 jihpringle joined #evergreen
13:02 Christineb joined #evergreen
13:18 * Dyrcona has a branch with a wrong bug # and I can't find the bug it was for.
13:24 * Dyrcona manually searches through the 2,606 bugs....
13:26 mmorgan Dyrcona: Can you fix them all while you're searching through? ;-)
13:27 Dyrcona mmorgan: I've seen  a few old ones that are Fix Committed and should probably be Fix Released..... :)
13:27 terranm :)
13:27 Dyrcona I'm going from oldest to newest.
13:27 Dyrcona There are a lot of old ones that likely no longer apply, either.
13:28 terranm Whenever I find one that is clearly no longer relevant I mark it Won't Fix
13:28 Dyrcona My branch has 1802757 as the bug number, but that's a bug from linux-aws.
13:31 mmorgan Dyrcona: What files does your branch change?
13:31 Dyrcona Open-ILS/src/templates/staff/admi​n/workstation/t_workstations.tt2
13:32 Dyrcona I have checked that it is still broken in master.
13:32 Dyrcona If you look around line 19, there's an extra >.
13:33 rfrasur terranm, added a signoff for https://bugs.launchpad.net/evergreen/+bug/1945836
13:33 pinesol Launchpad bug 1945836 in Evergreen "wishlist: Simple Reporter" [Wishlist,Confirmed]
13:34 Dyrcona I'm looking for bug 1807257.
13:34 pinesol Launchpad bug 1807257 in Evergreen 3.6 "Web Client Allows Register Workstation with Org_Unit that Can't Have Users" [Undecided,Confirmed] https://launchpad.net/bugs/1807257
13:35 * Dyrcona fixes his branch and updates the bug.
13:35 mmorgan Dyrcona++
13:36 Dyrcona IDK, I said last April that I was going to look at it again....
13:36 * Dyrcona shrugs.
13:37 mmorgan What's the best way to handle two bugs that touch the same code? Like bug 1919494 and bug 1920039
13:37 pinesol Launchpad bug 1919494 in Evergreen "The More details button is not translatable" [Undecided,Confirmed] https://launchpad.net/bugs/1919494
13:37 pinesol Launchpad bug 1920039 in Evergreen "Bootstrap Opac: More Details button does not change on use" [Medium,Confirmed] https://launchpad.net/bugs/1920039
13:38 mmorgan The latter is signedoff, but if committed, the former will have a conflict.
13:39 Dyrcona mmorgan: I'd push the signed off one. Then, the other will need to be rebased.
13:39 Dyrcona The rebase is usually left up to the original code submitter.
13:40 mmorgan Ok, that makes sense, but I wanted to avoid having the term "Less Details" display in the BOOPAC.
13:41 Dyrcona Well, if you feel up to it, you could always do the rebase.
13:41 terranm I was just about to sign off on bug 1919494
13:41 pinesol Launchpad bug 1919494 in Evergreen "The More details button is not translatable" [Undecided,Confirmed] https://launchpad.net/bugs/1919494
13:44 mmorgan terranm: I'd say go for it!
13:45 mmorgan If that one goes in first, that fixes the "Less/Fewer Details" term. Then 1920039 will need the rebase.
13:45 mmorgan Either way something's going to need a rebase.
13:46 Dyrcona It is unavoidable some times.
13:47 terranm Signed off
13:48 mmorgan Dyrcona: I'm happy to try my hand at the rebase, but am not quite clear on the steps.
13:48 mmorgan terranm++
13:49 Dyrcona One the other patch goes into master, you do a git pull. You then checkout the branch that you want to rebase and do `git rebase master` You resolve and code conflicts, do `git add` for the resolved files, then `git rebase --continue`
13:50 Dyrcona modulo the typos in my intructions. :)
13:50 Dyrcona heh....
13:51 mmorgan Dyrcona: Thanks for the tips! I have to run out for a bit, but will give it a try when I get back.
13:52 mmorgan Dyrcona++
13:52 Dyrcona You could alternately rebase the branch for bug 1920039 on the branch for 1919494 if the latter hasn't gone into master, yet.
13:52 pinesol Launchpad bug 1920039 in Evergreen "Bootstrap Opac: More Details button does not change on use" [Medium,Confirmed] https://launchpad.net/bugs/1920039
13:52 Dyrcona mmorgan++
14:06 Dyrcona I have number of signedoff branches that have been signed off for a while. Maybe I'll push them in later? They're almost all bug fixes.
14:09 Dyrcona And one where our own testing has been held up by the pandemic and other things.
14:10 gmcharlt rfrasur++ # giving ALL Evergreen catalogers a vacation ;)
14:10 Dyrcona :)
14:11 rfrasur You're so very welcome :))
14:11 rfrasur I can't do much, but I can definitely send a big announcement out to the wrong listserv.
14:11 * rfrasur bows
14:13 csharp_ rfrasur++
14:13 csharp_ going look me up some bugs
14:14 terranm rfrasur++
14:15 * Dyrcona is going through local branches and deleting those that are not longer needed, i.e. fix committed/fix released.
14:18 jvwoolf rfrasur++
14:19 JBoyer Dyrcona, I missed your Q for a while, but no, I didn't try the emacs patch in vim. With modelines disabled in some distros and some apparent uncertainty in the number of lines checked I was just going from what I could find in the docs. I was hopeful that there was a one-line file variables format but apparently not. (not sure why not, since there's a 1-liner format for something else emacs supports in comments...)
14:21 Dyrcona JBoyer: S'OK. I fixed the branch per your suggestions. Emacs has a 1-line mode, but it has the be the first line or the second if the first line is a shebang: https://www.gnu.org/software/emacs/manual/ht​ml_node/emacs/Specifying-File-Variables.html
14:22 JBoyer speaking of those modelines / file vars, the IDL is probably due for a whitespace realignment / lint enforcement or they're not really doing much.
14:22 JBoyer (same for the apache config files and others)
14:27 Dyrcona JBoyer: My branch includes a whitespace fix for the IDL.
14:27 Dyrcona It's the top commit.
14:28 * csharp_ read "modelines" as "madeleines"
14:28 csharp_ @dessert [someone]
14:28 * pinesol grabs some Moon Pie and some RC Cola for JBoyer
14:28 csharp_ pinesol++
14:28 * Dyrcona jealous.
14:28 csharp_ @dessert Dyrcona
14:28 * pinesol grabs some of yboston's cheese flan for Dyrcona
14:28 JBoyer Dyrcona++
14:28 Dyrcona Yum!
14:28 JBoyer Been too long since I looked at it.
14:29 Dyrcona JBoyer: If you're talking about the branch, I just fixed it today while going through my local branches.
14:40 JBoyer For anyone interested in testing lp 1091588 (different A/T templates for user-specific locales) I've set up pattypan to send email and have updated the Test Email Notification template with all of the currently available non-English locales (According to Google Translate, anyway.)
14:40 pinesol Launchpad bug 1091588 in Evergreen "Send out emails in patron's preferred language" [Wishlist,Confirmed] https://launchpad.net/bugs/1091588
15:00 jihpringle joined #evergreen
15:58 terranm joined #evergreen
17:07 rfrasur joined #evergreen
17:16 mmorgan left #evergreen
17:31 jvwoolf left #evergreen
17:44 jihpringle joined #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
22:50 JBoyer joined #evergreen

| Channels | #evergreen index | Today | | Search | Google Search | Plain-Text | summary | Join Webchat